Toshio Kuratomi
2fdb8e7f90
Fix a traceback with python3 and diff output
...
When retrieving file contents for diffing we need to get the contents as
binary. Otherwise python3 will try to convert the file to text and fail
with non-decodable contents.
Fixes #23171
2017-04-07 14:35:50 -07:00
Chris Alfonso
d4bd54d3b8
Fixes #23388 Network provider masks too much ( #23418 )
...
* Fixes #23388 Network provider masks too much
* Fix trailing whitespace
2017-04-07 14:34:47 -06:00
Matt Clay
0cf1e8e061
Fix ansible-test handling of import/syntax errors.
2017-04-07 12:20:31 -07:00
Dag Wieers
3648e6fd2b
vmware_guest: Add delegate_to directive to examples ( #22932 )
...
Without this it is likely not going to do what people expect.
2017-04-07 18:17:18 +01:00
Brian Coca
0d5d5f2bf6
correctly get all hosts in 'all'
2017-04-07 13:17:03 -04:00
Pierre-Alexandre
283a88444f
BUGFIX : using yaml hosts inventory, hosts in groups weren't added to the group 'all'
2017-04-07 13:16:14 -04:00
Matt Martz
621e27b5dd
Urls client cert auth ( #18141 )
...
* Build HTTPSClientAuthHandler more similarly to how HTTPSHandler works
* Add docs for new client cert authentication
* Support older versions of python
* Simplify logic
* Initial support for client certs in urls.py
* Add an extra test
* Add a get_url test for client cert auth
* Add additional test for client cert auth, with validation and ssl mismatch
* Skip assert when http tester not available
* Update version_added for new options
2017-04-07 09:54:37 -07:00
Ganesh Nalawade
3934513121
Fix a10 pylint issues ( #23410 )
...
* Fix a10 pylint issues
* Moving imports to standard location
2017-04-07 22:23:55 +05:30
Toshio Kuratomi
78ced5318f
Fix for recursive copy slowness
...
Copy module was walking over files in subdirectories repeatedly (a
directory tree a few levels deep could bring the time spent into the
tens of minutes)
This was traced to the fix for this bug report: https://github.com/ansible/ansible/issues/13013
Fixed #13013 a different way and added an integration test to check for
regressions of #13013 as we optimize this code.
Fixes #21513
2017-04-07 12:41:42 -04:00
Matt Martz
ac61f09203
Extra deps needed for building cryptography
2017-04-07 09:19:26 -07:00
Matt Martz
13ac993d25
Fallback to old ssl_wrap_socket
2017-04-07 09:19:26 -07:00
Matt Martz
b4b76bab14
Update install deps for SNI tests
2017-04-07 09:19:26 -07:00
Matt Martz
33f7a27cba
Use PyOpenSSLContext instead of deprecated wrap_ssl_context from urllib3.contrib.pyopenssl. Fixes #18528
2017-04-07 09:19:26 -07:00
Strahinja Kustudić
9f0be5a556
Ignores ControlPersist broken pipe errors. Fixes #16731
...
Ansible will now automatically retry a connection if SSH returns an error:
mux_client_hello_exchange: write packet: Broken pipe
This is probably a bug in SSH, but because it's safe to retry this
connection there is no need for Ansible to fail because of it.
2017-04-07 09:06:28 -07:00
Ricardo Carrillo Cruz
13b2f11139
Do not assert session name on idempotent eos banner ( #23402 )
...
* Check for proper response key on eos_banner map_config_to_obj
If we run the task with 'login' banner, the 'show banner' command
will return a dict containing key 'loginBanner'.
However for motd, it will just return 'motd'.
Yay naming consistency!
* Do not assert session exists on eos_banner response not changing device
2017-04-07 15:44:06 +02:00
Ricardo Carrillo Cruz
ba7ba7adc3
Check for proper response key on eos_banner map_config_to_obj ( #23399 )
...
If we run the task with 'login' banner, the 'show banner' command
will return a dict containing key 'loginBanner'.
However for motd, it will just return 'motd'.
Yay naming consistency!
2017-04-07 15:32:10 +02:00
Ricardo Carrillo Cruz
ce9826d76e
Fix eos_banner basic-motd eapi asserts ( #23398 )
...
The commands in EAPI does not contain the plain command sent to the
device as a one liner, but it is split in cmd/input keys.
2017-04-07 14:18:40 +02:00
Ricardo Carrillo Cruz
2cc2b8fb4d
Add missing provider to eos_banner basic-motd eapi test ( #23396 )
...
Otherwise this stalls and timeouts, it doesn't have creds to run.
2017-04-07 13:39:33 +02:00
Matt Clay
48eeab8a53
Fix errors reported by pylint. ( #23282 )
...
* Fix pylint misplaced-bare-raise errors.
* Fix pylint return-in-init error.
* Fix pylint bad-format-character error.
* Fix pylint too-many-format-args errors.
* Fix pylint too-few-format-args errors.
* Fix pylint truncated-format-string error.
2017-04-06 16:58:16 -07:00
Matt Clay
9e1bf1c6f2
Update fedora24 Dockerfile to resolve dnf issue.
2017-04-06 16:03:29 -07:00
John R Barker
6633ae1afa
look_for_keys & allow_agent actually added in 2.4
...
https://github.com/ansible/ansible/pull/22429 was merged, though not cherry picked into stable-2.3, so update docs
2017-04-06 19:17:59 +01:00
Guillaume Coré
3c75808c5c
fix incorrect parsing of xfs_info
...
when device name ends with 'data' line matches in :
- if 'data ' in line:
closes #23352
2017-04-06 11:11:13 -07:00
Toshio Kuratomi
dcc63c8f93
Fix imports and pep8 problems so CI can pass again.
2017-04-06 10:41:18 -07:00
Ricardo Carrillo Cruz
3537b24742
Unhardcode the port and protocol on eos EAPI ( #23350 )
...
We were hard-coding the protocol, port and validate_certs on
eos EAPI via the action plugin.
Put defaults on the eos_argument_spec and pull those values from it.
2017-04-06 19:18:28 +02:00
Toshio Kuratomi
5f4673b5ae
Update metadata for openssl_csr
2017-04-06 10:16:50 -07:00
Ganesh Nalawade
0cd50f0706
Fix #22880 junos_config update issue ( #23333 )
...
For update parameter add 'override' as acceptable value.
'override' name is in sync with junos naming convention.
2017-04-06 12:59:33 -04:00
Chris Alfonso
394cb3477b
Fixes loginBanner plucking over eapi transport when loginBanner isn't set. ( #23363 )
2017-04-06 10:58:04 -06:00
Ganesh Nalawade
990ba90380
Fix #23360 junos_config set format issue ( #23365 )
2017-04-06 10:45:15 -06:00
Nathaniel Case
98c23a3342
Attempt to clear up nxos_mtu tests and documentation ( #23361 )
...
nxos_system wasn't added until 2.3, so nxos_mtu should have been deprecated
then.
2017-04-06 12:26:17 -04:00
nerzhul
637e9942ff
Nsupdate idempotency fix
2017-04-06 09:20:01 -07:00
Yanis Guenane
2705e7a8aa
crypto: Add new module openssl_csr ( #21004 )
...
This new module allows one to automate the generation of OpenSSL
Certificate Signing Request. It supports SAN extension.
2017-04-06 18:09:07 +02:00
Matt Clay
40e88dadbe
Disable zypper tests for CI due to timeouts.
2017-04-06 08:48:31 -07:00
Peter Sprygada
f0008248d4
fix iosxr commands to encode json ( #23346 )
...
the command dict in the iosxr module_utils wasn't encoding the request
to json. this patch will fix that problem
2017-04-06 15:44:21 +01:00
John R Barker
13dc02d49d
More network_debug_troubleshooting.html ( #23335 )
...
More "unable to open shell" -> network_debug_troubleshooting.html
2017-04-06 12:39:59 +01:00
Takuya Sato
dff35bc205
ecs_taskdefinition module : Convert environment variables to string ( #23297 )
...
Before modification, it fails unless it is a string type
2017-04-06 10:46:40 +01:00
John R Barker
529df8640b
'unable to open shell' -> direct to web help ( #23267 )
...
* 'unable to open shell' -> direct to web help
The "unable to open shell" error is returned for a number of different,
direct people to online docs (we we can update out of band of releases)
to guide them though the various solutions.
* fix pep8 errors
2017-04-06 10:11:28 +01:00
Varadharajan
4540853a50
Pass CSRF token along with Jenkins POST requests ( #23250 )
2017-04-06 10:03:57 +01:00
Matt Davis
b71b157fb3
Cleanse CLIXML from win_shell stderr ( #23329 )
...
prunes all but Error stream values
2017-04-06 01:39:20 -07:00
Matt Davis
8d291f91ee
improve become_method: runas error handling ( #23328 )
...
Prescriptive errors for username/password issues and NTLM/Kerb auth failures, cleans up exception noise.
2017-04-06 01:34:30 -07:00
Dag Wieers
e66c98281e
Small consistency fixes ( #23294 )
2017-04-05 22:03:29 +01:00
Ricardo Carrillo Cruz
b9b4e68206
Check text key exists on eos_banner absent case ( #23319 )
...
This can fail if we don't check the key exists.
2017-04-05 21:07:18 +02:00
Ricardo Carrillo Cruz
4571ff0b52
Fix eapi basic-login asserts ( #23318 )
...
The asserts where not checking the commands sent to the device
2017-04-05 20:37:58 +02:00
Ricardo Carrillo Cruz
cf30f0f27d
Fix asserts on ios_banner tests ( #23315 )
...
The contain assert was broken.
2017-04-05 20:00:10 +02:00
Chris Alfonso
3a78861cb5
Fixes #23308 ios_banner: KeyError: 'text' on state: absen ( #23313 )
2017-04-05 11:30:40 -06:00
Ricardo Carrillo Cruz
d268471739
Fix basic-login eapi tests for eos_banner ( #23304 )
...
We should be passing the provider dict, not the transport.
2017-04-05 19:11:12 +02:00
John R Barker
f22702eee2
enable ios_facts tests again ( #23310 )
2017-04-05 17:50:32 +01:00
Adrian Likins
a936ea1333
update the flake8 config in tox.ini
2017-04-05 09:43:37 -07:00
Nathaniel Case
d890167575
Fix nxos_facts for nxapi transport ( #23302 )
...
* Partial revert of 2e476e64cd
This broke handling of nxos_facts over nxapi
* Fix nxos_facts tests not run in isolation
2017-04-05 11:47:37 -04:00
John R Barker
485affeb12
eapi & nxapi: Document validate_certs ( #23305 )
...
* Document validate_certs for eapu & nxapi
* formatting
2017-04-05 16:37:40 +01:00
Tim Rupp
780b2f2c84
Fixes pylint errors ( #23279 )
...
Reported by gundalow, this fixes pylint errors in F5 modules
2017-04-05 14:24:42 +01:00