Brian Coca
6f2f7a79b3
add support for diff in file settings
...
this allows modules to report on what specifically changed when using
common file functions
2016-01-01 21:53:19 -05:00
Yannig Perré
c4d2dbfcdb
Replace to_string by to_unicode.
...
Fix https://github.com/ansible/ansible/issues/13707
2016-01-01 15:55:51 +01:00
Thilo Uttendorfer
5c34be15b1
Fix unsupported format character
2015-12-31 02:31:38 +01:00
James Cammarata
e39e8ba308
Fix logic mistake in unarchive action plugin
2015-12-30 13:49:39 -05:00
Eric Feliksik
946b82bef7
shred ansible-vault tmp_file. Also when editor is interruped.
2015-12-30 18:21:34 +01:00
Brian Coca
d3deb24ead
output color is now configurable
2015-12-29 17:40:47 -05:00
James Cammarata
2d11cfab92
Squashed commit of the following:
...
commit 24efa310b58c431b4d888a6315d1285da918f670
Author: James Cammarata <jimi@sngx.net>
Date: Tue Dec 29 11:23:52 2015 -0500
Adding an additional test for copy exclusion
Adds a negative test for the situation when an exclusion doesn't
exist in the target to be copied.
commit 643ba054877cf042177d65e6e2958178bdd2fe88
Merge: e6ee59f
66a8f7e
Author: James Cammarata <jimi@sngx.net>
Date: Tue Dec 29 10:59:18 2015 -0500
Merge branch 'speedup' of https://github.com/chrismeyersfsu/ansible into chrismeyersfsu-speedup
commit 66a8f7e873ca90f7848e47b04d9b62aed23a45df
Author: Chris Meyers <chris.meyers.fsu@gmail.com>
Date: Mon Dec 28 09:47:00 2015 -0500
better api and tests added
* _copy_results = deepcopy for better performance
* _copy_results_exclude to deepcopy but exclude certain fields. Pop
fields that do not need to be deep copied. Re-assign popped fields
after deep copy so we don't modify the original, to be copied, object.
* _copy_results_exclude unit tests
commit 93490960ff4e75f38a7cc6f6d49f10f949f1a7da
Author: Chris Meyers <chris.meyers.fsu@gmail.com>
Date: Fri Dec 25 23:17:26 2015 -0600
remove uneeded deepcopy fields
2015-12-29 11:40:18 -05:00
Brian Coca
56454d6a91
added newer vars to 'reset_vars'
...
these vars pass back info to the task about the connection
moved to their own block at start at file for readability and
added the newer standard vars
2015-12-28 12:25:27 -05:00
Toshio Kuratomi
d70a97b562
Update submodule refs
2015-12-25 12:17:22 -08:00
Toshio Kuratomi
deac4d00b2
bigip changes as requested by bcoca and abadger:
...
* Fix to error if validate_cert is True and python doesn't support it.
* Only globally disable certificate checking if really needed. Use
bigip verify parameter if available instead.
* Remove public disable certificate function to make it less likely
people will attempt to reuse that
2015-12-24 11:49:31 -08:00
Brian Coca
fd7e01696f
updated submodule refs to pick up module changes
2015-12-23 17:16:21 -05:00
Brian Coca
db1d153aca
Merge pull request #13647 from bcoca/fix_role_search
...
corrected role path search order
2015-12-23 15:11:49 -05:00
Brian Coca
9a118ce213
Merge pull request #13648 from bcoca/fix_invocation_and_moderrors
...
better module error handling
2015-12-23 10:42:40 -05:00
Michael Scherer
42b9a206ad
Fix last commit, make it python3 compatible (and py24)
2015-12-23 13:24:11 +01:00
Brian Coca
957b376f9e
better module error handling
...
* now module errors clearly state msg=MODULE FAILURE
* module's stdout and stderr go into module_stdout and module_stderr keys
which only appear during parsing failure
* invocation module_args are deleted from results provided by action
plugin as errors can keep us from overwriting and then disclosing info that
was meant to be kept hidden due to no_log
* fixed invocation module_args set by basic.py as it was creating different
keys as the invocation in action plugin base.
* results now merge
2015-12-22 23:01:56 -05:00
Brian Coca
202b92179d
corrected role path search order
...
the unfraking was matching roles in current dir as it always returns a full path,
pushed to the bottom as match of last resort
fixes #13645
2015-12-22 22:09:45 -05:00
Brian Coca
010839aedc
fix no_log disclosure when using aliases
2015-12-22 17:15:58 -05:00
Toshio Kuratomi
c4da5840b5
Convert to bytes later so that make_become_command can jsut operate on text type.
2015-12-22 08:22:02 -08:00
Brian Coca
474772c81c
Merge pull request #13639 from emonty/bool-conversion
...
Also convert ints to bool for type=bool
2015-12-22 10:21:18 -05:00
Monty Taylor
c60749c922
Also convert ints to bool for type=bool
2015-12-22 09:14:12 -06:00
Brian Coca
bbdfaf0522
move hostvars.vars to vars
...
this fixes duplication under hostvars and exposes all vars in the vars dict
which makes dynamic reference possible on 'non hostvars'
2015-12-22 00:24:35 -05:00
Toshio Kuratomi
0c013f592a
Transform the command we pass to subprocess into a byte string in _low_level-exec_command
2015-12-21 13:53:35 -08:00
Brian Coca
75e94e0cba
allow for non standard hostnames
...
* Changed parse_addresses to throw exceptions instead of passing None
* Switched callers to trap and pass through the original values.
* Added very verbose notice
* Look at deprecating this and possibly validate at plugin instead
fixes #13608
2015-12-21 13:42:34 -05:00
Yannig Perré
a4674906c6
Merge role params into variables separately from other variables
...
Fixes #13617
2015-12-21 13:03:09 -05:00
James Cammarata
6ae04c1e4f
Fix logic in PlayIterator when inserting tasks during rescue/always
...
Because the fail_state is potentially non-zero in these block sections,
the prior logic led to included tasks not being inserted at all.
Related issue: #13605
2015-12-20 12:39:08 -05:00
James Cammarata
3ec0104128
Fixing bugs in conditional testing with until and some integration runner tweaks
2015-12-19 21:14:48 -05:00
Brian Coca
bb2935549f
corrected service detection in docker versions
...
now if 1 == bash it falls back into tool detection
2015-12-19 16:16:10 -05:00
Toshio Kuratomi
e66c070e5c
Add package module to squash list
2015-12-19 13:00:58 -08:00
Toshio Kuratomi
224d596336
Remove args from get_name() as we can't tell if any of the args are no_log
2015-12-19 11:51:16 -08:00
Toshio Kuratomi
8ffc1fa838
Comment to explain why we strip _ansible_notify specially
2015-12-19 11:31:46 -08:00
Toshio Kuratomi
d32a885e98
Make return invocation information so that our sanitized copy will take precedence over what the executor knows.
2015-12-19 11:24:59 -08:00
Toshio Kuratomi
2936682f00
Revert "removed invocation info as it is not no_log aware"
...
This reverts commit 6127a8585e
.
2015-12-19 11:09:20 -08:00
Brian Coca
6127a8585e
removed invocation info as it is not no_log aware
...
This was added in 1.9 and 2.0 tried to copy, but since it cannot
obey no_log restrictions I commented it out. I did not remove as
it is still very useful for module invocation debugging.
2015-12-19 11:48:48 -05:00
Toshio Kuratomi
07a0059306
update submodule ref for doc fix
2015-12-18 22:23:25 -08:00
Toshio Kuratomi
3197eeaaa8
update submodule refs
2015-12-18 22:16:49 -08:00
James Cammarata
a3dcb910b8
Fixing bugs with {changed,failed}_when and until with registered vars
...
* Saving of the registered variable was occuring after the tests for
changed/failed_when.
* Each of the above fields and until were being post_validated too early,
so variables which were not defined at that time were causing task
failures.
Fixes #13591
2015-12-18 10:58:55 -05:00
Toshio Kuratomi
3057fc1753
Update submodule ref for mysql_user fix
2015-12-17 13:46:15 -08:00
James Cammarata
4ba7158282
Fixing a mistake from tweaking list stuff too much
...
Use the action only if the task name is not set
2015-12-17 16:33:23 -05:00
James Cammarata
d4ffc96c80
Further tweaks to the output format of list tasks/tags
2015-12-17 16:30:23 -05:00
James Cammarata
5929ffc7c3
Make --list-tasks respect tags
...
Also makes the output closer to the appearance of v1
Fixes #13260
2015-12-17 16:10:27 -05:00
Toshio Kuratomi
bad1c173b8
Update core submodule for mysql_db fix
2015-12-17 11:36:36 -08:00
Toshio Kuratomi
1b5e7ce025
Update submodule refs
2015-12-17 10:23:30 -08:00
James Cammarata
e546219426
Revert "Enable host_key checking at the strategy level"
...
This reverts commit 1a6d660d7e285cceec474952a33af4d8dffd0a8d.
2015-12-17 12:43:47 -05:00
James Cammarata
586208234c
Revert "Fixing bugs in ssh known_host fetching"
...
This reverts commit 21c127c581
.
2015-12-17 12:43:47 -05:00
James Cammarata
21c127c581
Fixing bugs in ssh known_host fetching
...
* If remote_addr is not set in the PlayContext, use the host.address
field instead (which is how the action plugin works)
Fixes #13581
2015-12-17 12:06:17 -05:00
James Cammarata
d9c74536be
Fix handling of environment inheritence, and template each inherited env
...
Environments were not being templated individually, so a variable environment
value was causing the exception regarding dicts to be hit. Also, environments
as inherited were coming through with the tasks listed first, followed by the
parents, so they were being merged backwards. Reversing the list of environments
fixed this.
2015-12-17 09:44:40 -05:00
James Cammarata
e5c2c03dea
Enable host_key checking at the strategy level
...
Implements a new method in the ssh connection plugin (fetch_and_store_key)
which is used to prefetch the key using ssh-keyscan.
2015-12-16 21:41:07 -05:00
James Cammarata
15135f3c16
Make sure we're using the original host when processing include results
...
Also fixes a bug where we were passing an incorrect number of parameters to
_do_handler_run() when processing an include file in a handler task/block.
Fixes #13560
2015-12-16 19:13:45 -05:00
James Cammarata
857456ea5f
Fixing template integration test for python 2.6 versions
...
No longer immediately fallback to to_json if simplejson is not installed
2015-12-16 18:22:22 -05:00
Toshio Kuratomi
fd4ad2c8f2
Update submodule ref to fix a bug in mysql_user with mariadb
2015-12-16 14:08:08 -08:00
James Cammarata
8716bf8021
All variables in complex args again
...
Also updates the CHANGELOG to note the slight change, where bare variables
in args are no longer allowed to be bare variables
Fixes #13518
2015-12-16 16:39:08 -05:00
James Cammarata
76b4b9ed2c
Merge pull request #13501 from chouseknecht/galaxy-2.0-update
...
Galaxy 2.0 update
2015-12-16 15:01:12 -05:00
nitzmahone
baece499df
fix plugin loading for Windows modules
...
force plugin loader to only consider .py files, since that's the only place docs can live ATM...
2015-12-16 11:47:12 -08:00
Toshio Kuratomi
9724117bbb
Update submodule refs for mysql refactor
2015-12-16 11:15:39 -08:00
Toshio Kuratomi
1116bc6ca6
Merge pull request #13191 from Jmainguy/mysql
...
Add shared connection code for mysql modules
2015-12-16 10:47:49 -08:00
Jonathan Mainguy
34e88e48a5
Add shared connection code for mysql modules
2015-12-16 13:36:18 -05:00
James Cammarata
6a252a3f77
Preserve the cumulative path for checking includes which have parents
...
Otherwise, each relative include path is checked on its own, rather
than in relation to the (possibly relative) path of its parent, meaning
includes multiple level deep may fail to find the correct (or any) file.
Fixes #13472
2015-12-16 11:23:06 -05:00
Toshio Kuratomi
0095d04af9
Update submodule refs
2015-12-16 08:02:46 -08:00
Toshio Kuratomi
7d519127fe
Merge pull request #13573 from ansible/ssl-context-with-proxy
...
Fix a few problems with url handling.
2015-12-16 08:00:59 -08:00
Toshio Kuratomi
33863eb653
Conditionally create the CustomHTTPSConnection class only if we have the required baseclasses.
...
Fixes #11918
2015-12-16 07:47:09 -08:00
Toshio Kuratomi
72a0654b81
Fixes for proxy on RHEL5
2015-12-16 07:47:07 -08:00
Toshio Kuratomi
73ead4fbba
First attempt to fix https certificate errors through a proxy with python-2.7.9+
...
Fixes #12549
2015-12-16 07:46:54 -08:00
Brian Coca
97275110d7
Merge pull request #13533 from bcoca/debug_fixes
...
debug now validates its params
2015-12-16 10:36:20 -05:00
James Cammarata
fcc9258b74
Use the original host rather than the serialized one when processing results
...
Fixes #13526
Fixes #13564
Fixes #13566
2015-12-16 01:48:22 -05:00
Toshio Kuratomi
d203438a2c
Merge pull request #13554 from Yannig/devel_fix_python3_tests
...
Use six lib to import urlparse properly.
2015-12-15 07:55:56 -08:00
Brian Coca
be5488cb60
clean debug output to match prev versions
2015-12-15 09:27:53 -05:00
Brian Coca
a0842781a6
renamed ssh.py shared module file to clarify
2015-12-15 08:45:12 -05:00
Yannig Perré
be4d1f9ee3
Fix a part of python 3 tests (make tests-py3, see https://github.com/ansible/ansible/issues/13553 for more details).
2015-12-15 13:37:35 +01:00
Peter Sprygada
27cd7668c1
the ssh shared module will try to use keys if the password is not supplied
...
The current ssh shared module forces only password based authentication. This
change will allow the ssh module to use keys if a password is not provided.
2015-12-15 07:16:28 -05:00
Toshio Kuratomi
8d16638fec
Fix for template module not creating a file that was not present when force=false
2015-12-14 10:55:21 -08:00
Michael Scherer
a7ac98262d
Make module_utils.known_hosts.get_fqdn work on ipv6
2015-12-14 19:30:54 +01:00
Toshio Kuratomi
c9eb41109f
Update submodule refs
2015-12-14 08:03:56 -08:00
James Cammarata
80d23d639c
Use an octal representation that works from 2.4->3+ for known_hosts
2015-12-14 10:43:30 -05:00
James Cammarata
6312e38133
Fixing up some non-py3 things for unit tests
2015-12-14 10:35:58 -05:00
Brian Coca
2a37f11738
Merge pull request #13542 from h0nIg/devel_default_ask
...
ansible vault, ask pass: use default settings from ansible.cfg
2015-12-14 09:14:48 -05:00
Hans-Joachim Kliemeck
f5f9b2fd35
use default settings from ansible.cfg
2015-12-14 15:04:31 +01:00
James Cammarata
f8ff63f8c8
A few tweaks to improve new forking code
2015-12-14 03:06:52 -05:00
Brian Coca
175c2d6510
Merge pull request #13502 from robinro/patch-3
...
use shallow clones by default in ansible-pull
2015-12-13 09:31:35 -05:00
Toshio Kuratomi
2bc3683d41
Restore comment about for-else since it is an uncommon idiom
2015-12-13 05:55:31 -08:00
chouseknecht
06dde0d332
Fixed documentation typos and bits that needed clarification. Fixed missing spaces in VALID_ACTIONS.
2015-12-13 05:23:04 -05:00
chouseknecht
342dee0023
Define and handle ignore_certs correctly. Preserve search term order. Tweak to Galaxy docsite.
2015-12-13 05:23:04 -05:00
chouseknecht
bc73920090
Updated ansible-galaxy man page. Removed -b option for import.
2015-12-13 05:23:04 -05:00
chouseknecht
d8e6bc98a2
Fix overloaded options. Show an error when no action given. Don't show a helpful list of commands and descriptions.
2015-12-13 05:23:04 -05:00
Robin Roth
1bd8d97093
fix whitespace
2015-12-13 11:19:50 +01:00
Robin Roth
1b2ebe8def
make shallow clone the default for ansibel-pull
2015-12-13 10:56:47 +01:00
Brian Coca
d73562902b
debug now validates its params
...
simplified var handling
made default message the same as in pre 2.0
fixes #13532
2015-12-13 00:13:13 -05:00
Brian Coca
f3bedbae29
simplified skippy
...
thanks agaffney!
2015-12-12 17:50:55 -05:00
Brian Coca
99e46440bd
changed shell delimiters for csh
...
fixes #13459
2015-12-12 16:10:18 -05:00
Brian Coca
8e445c551a
removed unused imports in galaxy/cli
2015-12-12 13:43:10 -05:00
James Cammarata
120b9a7ac6
Changing the way workers are forked
2015-12-11 23:35:07 -05:00
Brian Coca
ae988ed753
avoid set to unique hosts to preserver order
...
swiched to using a list comp and set to still unique but keep expected order
fixes #13522
2015-12-11 15:38:04 -05:00
Brian Coca
de71171fc2
removed merge conflict
2015-12-11 15:11:26 -05:00
James Cammarata
7f7e730dea
Don't mark hosts failed if they've moved to a rescue portion of a block
...
Fixes #13521
2015-12-11 14:55:44 -05:00
Brian Coca
d9e510b192
narrow down exception catching in block builds
...
this was obscuring other errors and should have always been narrow scope
2015-12-11 13:13:05 -05:00
Chrrrles Paul
e56efa49c4
Merge pull request #13509 from chrrrles/vca_default_host
...
fix default host for non vcd service types
2015-12-11 10:17:55 -05:00
Abhijit Menon-Sen
37c4e9aee3
Clean up debug logging around _low_level_execute_command
...
We were logging the command to be executed many times, which made debug
logs very hard to read. Now we do it only once.
Also makes the logged ssh command line cut-and-paste-able (the lack of
which has confused a number of people by now; the problem being that we
pass the command as a single argument to execve(), so it doesn't need an
extra level of quoting as it does when you try to run it by hand).
2015-12-11 07:11:48 +05:30
Charles Paul
a6a58d6947
fix default host for non vcd service types
2015-12-10 16:39:27 -05:00
Toshio Kuratomi
bd9582d072
Update submodule refs
2015-12-10 08:10:45 -08:00
Toshio Kuratomi
1dda8158ff
become_pass needs to be bytes when it is passed to ssh.
...
Fixes #13240
2015-12-10 07:29:38 -08:00
Charles Paul
6680cc7052
allow custom callbacks with adhoc cli for scripting
...
missing import of CallbackBase
2015-12-10 09:49:54 -05:00