James Cammarata
9d61a6cba8
Fixing PlayIterator bugs
...
* Unit tests exposed a problem where nested blocks did not correctly
hit rescue/always portions of parent blocks
* Cleaned up logic in PlayIterator
* Unfortunately fixing the above exposed a potential problem in the
block integration tests, where a failure in an "always" section may
always lead to a failed state and the termination of execution
beyond that point, so certain parts of the block integration test
were disabled.
2016-03-09 13:31:30 -05:00
Brian Coca
d7bd5fc075
Merge pull request #14824 from bcoca/ansible_shell
...
draft 1st release of ansible shell
2016-03-09 13:21:25 -05:00
Brian Coca
7067bb32b8
make all conditionals lists
...
this brings them to equivalence with when:
fixes #13905
2016-03-09 09:33:59 -05:00
Matt Clay
33f93f9241
Fix misplaced paren.
2016-03-08 22:16:23 -08:00
James Cammarata
aee2eb6287
Merge pull request #14864 from dagwieers/patch-12
...
Only show diff when the task actually induced a change
2016-03-08 15:02:49 -05:00
James Cammarata
1a5ee115f0
Fixing minor logic error in error detection/handling in ssh connection plugin
...
If max retries were reached, no AnsibleConnectionFailure was raised, which
means potentially in some cases an unreachable error might not be returned
2016-03-08 14:50:35 -05:00
Dag Wieers
f5b6f52940
Only show diff when the task actually induced a change
...
This implements solution #1 in the proposal #14860 .
It only shows the diff if the task induced a change, which means that if the changed_when control overrides the task, not diff will be produced.
See #14860 for a rationale and the use-case.
2016-03-08 17:33:29 +01:00
Dag Wieers
175351f200
Little improvement in flow
...
Don't get the hostname if it's not needed.
2016-03-08 17:23:34 +01:00
Brian Coca
49bb4803b5
clarify --step prompt
...
now shows full words and indicates default
fixes #7433
2016-03-08 10:57:54 -05:00
Brian Coca
3d6ec52e83
Merge pull request #14830 from bcoca/assemble_fix
...
fix assemble to not pass extra args to copy/file
2016-03-08 09:22:15 -05:00
Brian Coca
eb4cb46c84
Merge pull request #14859 from sivel/issue/14858
...
Strip proc_1 before testing it. Fixes #14858
2016-03-08 09:14:05 -05:00
Matt Martz
2f90a4f4e2
Strip proc_1 before testing it. Fixes #14858
2016-03-08 07:42:42 -06:00
Brian Coca
e24e619cf1
added stderr from vault script to error
2016-03-07 20:51:58 -05:00
Brian Coca
75ae62a978
Merge pull request #12674 from sudarkoff/fail_if_executable_password_file_returns_nonzero
...
(TRIVIAL) Fail if the vault password script returns non-zero.
2016-03-07 20:45:26 -05:00
Brian Coca
e74ab3ecdd
draft 1st release of ansible-console
...
porting @dominis 's ansible-shell tool from 1.9 and integrating it into ansible
added verbosity control
made more resilitent to several errors
added highlight color, to configurable colors
more resilient on exception and interruptions
prompt coloring, goes red and changes to # when using become = true and root
become setting is now explicit and not a toggle
2016-03-07 20:25:21 -05:00
Matt Martz
53bb889ef6
update submodule refs
2016-03-07 16:12:19 -06:00
Matt Martz
098333b2ec
Fix redirects for get_url
...
* fetch_url shouldn't both accept follow_redirects and support follow_redircts via module.params
* Default follow_redirects for open_url should be 'urllib2'
* Add redirect test for get_url
2016-03-07 15:44:31 -06:00
Brian Coca
325fccfa78
added v for least verbose display function
2016-03-07 13:17:31 -05:00
James Cammarata
299d93f6e9
Updating unit tests for PlayIterator
...
This knowingly introduces a broken test, planning to fix that later.
2016-03-07 13:03:06 -05:00
Brian Coca
66ea464ebd
Merge pull request #14793 from xiaket/devel
...
remove main_q for simplicity.
2016-03-07 12:51:38 -05:00
Brian Coca
25e9b5788b
add per item diff handling
...
fixes #14843
2016-03-07 09:49:18 -05:00
John Barker
8b4ebd8e4a
Make it easier to read error message
2016-03-07 12:49:41 +00:00
Brian Coca
0b2f631197
Merge pull request #14504 from bcoca/template_comments
...
template also when only comments present
2016-03-06 10:45:18 -05:00
Brian Coca
7d8b84dae6
fix assemble to not pass extra args to copy/file
...
also small refactor to dedupe code
fixes https://github.com/ansible/ansible-modules-core/issues/3154
2016-03-06 10:00:36 -05:00
Brian Coca
5aab158987
removed unused imports
2016-03-06 09:14:25 -05:00
Peter Sprygada
c0f1e1801b
adds multiline flag to regex test for search and match
...
This commit adds the multiline flag to the regexp search and match test
plugin. It defaults to re.M = False for backwards compatibility. To use
the multiline feature add multiline=True to the test filter
{{ config | search('^hostname', multiline=True) }}
2016-03-06 08:11:46 -05:00
Brian Coca
66a9a1feff
Merge pull request #14823 from jjahns/devel
...
add find_vm_by_name function to vmware utils
2016-03-05 23:17:35 -05:00
Brian Coca
75b9c7db14
moved hardcoded settings from doccli to constants
2016-03-05 17:40:44 -05:00
Jay Jahns
3a1944edc1
add find_vm_by_name function to vmware utils
2016-03-05 11:50:51 -08:00
Kishin Yagami
299c18d700
Support strategy_plugins setting in a configuration file
2016-03-05 20:15:04 +09:00
Brian Coca
62ac5c047e
clarified message
2016-03-04 14:44:03 -05:00
Brian Coca
8867d73420
reject extraneous data passed to mode
...
strictly permissions are allowed, file type info should not be passed in
alternate fixes #14771
2016-03-04 14:42:29 -05:00
Toshio Kuratomi
bd618c3490
Merge pull request #14797 from mattclay/unicode-fixes
...
Use to_bytes on filenames in filesystem calls.
2016-03-04 10:38:56 -08:00
Brian Coca
d6546a7513
make sure group_names is always sorted
...
this makes it consistent with previous ansilbe versions and other
paths that create the group_names variable
2016-03-04 13:12:35 -05:00
Matt Clay
5b79ed77e7
Use to_bytes on filenames in filesystem calls.
2016-03-04 09:08:41 -08:00
Brian Coca
27a33a6f18
dont erase previous nameservers in fact gathering
...
fixes #14806
2016-03-04 11:34:44 -05:00
夏恺(Xia Kai)
b33074b703
remove main_q for simplicity.
...
main_q is not used anywhere in the codebase.
It is created in TaskQueueManager._initialize_processes, bundled with rslt_q
into TaskQueueManger._workers, later unwrapped in StrategyBase but not used.
This queue is closed in TaskQueueManger._cleanup_processes.
Historically, it is passed as a init parameter into WorkerProcess,
introduced in 62d7956120b9a7
2016-03-04 07:58:18 +00:00
Toshio Kuratomi
8f1303c81a
Remember to use errors=strict since this is looking up a filename on the filesystem (ie it has to match exactly)
2016-03-03 20:56:50 -08:00
Toshio Kuratomi
253376b3b7
Make the source path into a byte string before passing to os.path
2016-03-03 20:44:01 -08:00
Brian Coca
e762095497
better task parsing errors
...
fixes #14790
2016-03-03 19:51:15 -05:00
Brian Coca
f565508d7f
Merge pull request #14764 from bcoca/max_diff_config
...
made max diff size configurable
2016-03-03 18:19:27 -05:00
Brian Coca
e432973310
Merge pull request #14757 from bcoca/register_no_template
...
don't template register
2016-03-03 18:18:44 -05:00
Brian Coca
13282e29a8
Merge pull request #14500 from yfried-redhat/fix_os_auth
...
Fix openstack auth type
2016-03-03 18:16:56 -05:00
Brian Coca
b901b15d3b
Merge pull request #14537 from Yannig/devel_better_error_handling
...
Improve message content to get more hint about the raised error.
2016-03-03 18:11:04 -05:00
Brian Coca
cc3cb0f65e
fix issues with older yaml lib versions
...
also added missing json import and removed unused ones
2016-03-03 18:13:36 -05:00
Brian Coca
6cad356b3b
updated docs to show new output
2016-03-03 18:05:39 -05:00
Brian Coca
b2a6784a9f
changed the output to keep backwards compat
...
still shows path when verbose
2016-03-03 18:03:02 -05:00
Brian Coca
fd8593d613
Merge pull request #14661 from jjshoe/fix-up-profile-tasks
...
Update the profile task callback plugin to include a fix for duplicate named tasks. Added additional features to adjust the number of tasks output and the sort order.
2016-03-03 17:46:40 -05:00
Brian Coca
c022a43a47
fixed str to to_str
2016-03-03 14:40:35 -05:00
Brian Coca
347aa7b032
Merge pull request #14774 from lamby/ignore-epipe-when-flushing-stdout-stderr
...
Ignore EPIPE when flushing stdout stderr
2016-03-03 14:26:20 -05:00
