Dag Wieers
63fa33b0b7
Make sure we always return 'rc' from the command module
...
If this is not a certainty, playbooks will fail without an 'rc' and checking both if there is an rc, and whether the 'rc' is (not) 0 is very complicated. (especially because ${something.rc} will not be substituted and all that)
2012-10-26 15:02:03 +02:00
Daniel Hokka Zakrisson
73cd3ef617
Only strip trailing newlines from output, preserving other space
2012-10-25 14:26:37 +02:00
Jan-Piet Mens
feab57e270
Reformat code: examples consistently
...
- added terse syntax to modules.rst
- added description of special variables to template module
2012-10-23 15:14:01 +02:00
Michael DeHaan
f67aa85c3f
Fixing various module related things.
2012-10-02 22:32:17 -04:00
Michael DeHaan
85a31616de
Call os.path.expanduser in the creates= and removes= section of the command module so ~/ and the like works.
2012-10-02 22:12:49 -04:00
Michael DeHaan
6600f7b7ac
Merge pull request #1170 from jpmens/docspatch01
...
Jumbo DOCUMENTATION patch
2012-10-01 05:19:16 -07:00
Daniel Hokka Zakrisson
6477bdc6fc
Use a regexp to filter out arguments instead
...
pipes.quote is a bit overzealous for what we want to do, quoting ;
and other characters that you most likely want to use in your shell
invocations. The regexp is the best I could come up with to be able
to only replace the parts of the arguments that shouldn't be
executed.
2012-10-01 12:13:17 +02:00
Jan-Piet Mens
e620fed755
Jumbo DOCUMENTATION patch
2012-10-01 09:18:54 +02:00
Daniel Hokka Zakrisson
9261d3962b
Properly parse escaped special arguments
...
Fixes issue #1134
2012-09-29 21:05:49 +02:00
Jan-Piet Mens
e0fb264a89
Module DOCUMENTATION: assemble, authorized_key, command, copy
...
plus a small fix in rst.j2 template
manpages generated & checked
modules.html generated & checked
2012-09-28 21:55:49 +02:00
Marco Vito Moscaritolo
2dd430d9c0
Add support to removes control param
...
Execute action only if specified file using param removes exist (execute reverse control of creates).
Some usage eg.:
```yaml
- name: enable apache2 default websites
action: command /usr/sbin/a2ensite $item
creates=/etc/apache2/sites-enabled/$item
with_items:
- default
- default-ssl
- name: disable apache2 default websites
action: command /usr/sbin/a2dissite $item
removes=/etc/apache2/sites-enabled/$item
with_items:
- default
- default-ssl
```
2012-09-05 14:06:47 +03:00
willthames
8b8eae7d82
Allow ~ expansion in chdir argument of command module
...
This allows the use of ~ in the chdir argument of the command module
I know the later change is absolutely necessary as the first change
was not sufficient. It may be that the first change fixes shell and
the second fixes command.
2012-09-04 14:22:53 +10:00
Michael DeHaan
c93df29249
Make a more logical error when the command/shell module is used with no arguments.
2012-08-16 21:40:52 -04:00
Michael DeHaan
7ab0d60b1a
update config code
2012-08-13 20:17:07 -04:00
Michael DeHaan
75bbd73173
Fix indentation
2012-08-11 18:39:09 -04:00
Michael DeHaan
477ca2ed1a
Make pep8 tests run against the library directory as well, and associated tweaks (mostly to indentation) in the library
...
directory.
2012-08-11 12:35:58 -04:00
Michael DeHaan
ce01c3f7e7
Allow unicode transfer by not base64 encoding. Also: faster
2012-08-02 21:20:43 -04:00
Michael DeHaan
8700de964c
Teach the common module code to warn users about typo'd arguments and also set everything to None automatically such
...
that code doesn't have to do a lot of params.get('foo', None) everywhere.
2012-07-31 21:23:34 -04:00
Petros Moisiadis
4ad0ff61e5
added a 'chdir' argument to the command module
...
the 'chdir' argument changes the current working directory to the
fullpath supplied as its value, before the execution of the command.
2012-07-30 18:39:45 +03:00
Michael DeHaan
45354c6be5
Port command module over to new common code. Notice that this has to subclass AnsibleModule -- this should be the only
...
one that has to do that.
2012-07-24 18:52:52 -04:00
Stephen Fromm
aea022b002
Apply logging of arguments to modules (issue #122 )
...
The ohai and facter modules use /usr/bin/logger to log the fact that
they have been invoked. I added 'import os' to the ping module
so that it could have the same syslog statements as the other modules.
I separated the condensed:
shlex.split(open(argfile, 'r').read())
into two separate statements similar to the other modules.
2012-05-09 15:19:20 -07:00
Michael DeHaan
38c7f1db4d
Added 'creates=filename' to the shell/command module, which can skip command execution if a file
...
already exists
2012-04-06 11:16:53 -04:00
Michael DeHaan
40fd778e2c
'shell' is a magic module that executes the command module with shell=True
2012-03-14 20:40:06 -04:00
Michael DeHaan
696b67f935
Fix async to use the new argfiles method (wrapping brain around rock, really must write module development guide)
2012-03-14 19:57:56 -04:00
Seth Vidal
1f53c89b14
convert so they handle argsfiles rather than arguments
2012-03-14 18:47:13 -04:00
Michael DeHaan
c86b388812
Strip trailing newlines from command module, which happens in some shell commands
2012-04-04 10:30:22 -04:00
Michael DeHaan
c8b1bbc7ea
make command module error when no -a more obvious as command is the default module and someone
...
may forget about -a. The CLI already warns about no host pattern by pulling up usage.
2012-03-01 22:25:01 -05:00
Michael DeHaan
847846af0e
-p has been replaced by a required option. Various docs changes.
2012-03-01 22:10:47 -05:00
Michael DeHaan
19fdb7305d
have command module raise an error if no arguments are supplied
2012-02-28 04:02:29 -05:00
Michael DeHaan
7de661dd2c
Add ansible command, fix import error in runner
2012-02-28 00:45:37 -05:00
Michael DeHaan
be4cb64c92
Relicensing to GPLv3, all previous committers ok'd on mailing list.
2012-02-28 19:08:09 -05:00
Seth Vidal
39f42cfd75
when it is an IOError or an OSError - return a normal error message instead of a traceback barf
2012-02-27 17:53:02 -05:00
Michael DeHaan
b44ae0af90
applying indentation patch from skvidal
2012-02-25 17:16:23 -05:00
Michael DeHaan
440bac4a95
Added remote templating engine using jinja2, see examples/playbook.yml for usage.
...
Cleanup is due in runner.py
2012-02-24 04:35:51 -05:00
Jeremy Katz
24e10dc2e8
Don't use a shell and thus avoid a whole class of problems
2012-02-24 16:10:53 -05:00
Jeremy Katz
ef8ea13495
Fall back to standalone simplejson module
...
CentOS5 has python 2.4 which doesn't have a built-in json
module
2012-02-23 20:52:53 -05:00
Michael DeHaan
a2a8deaeaa
Added command module
2012-02-23 17:19:06 -05:00
