Pierre-Louis Bonicoli
4d4512940d
Fix "AttributeError: 'ActionModule' object has no attribute '_shell'"
...
'_shell' was removed with commit 2a5fbd8570
2015-07-01 17:22:09 +02:00
James Cammarata
ec4d1b11df
Fix some more handler issues
...
* Only notify handlers when the task is changed
* Don't run handlers on hosts which have failed
2015-06-30 14:44:41 -04:00
Brian Coca
d149ea5222
ported timer.py callback to v2
2015-06-29 20:45:50 -04:00
James Cammarata
9785e5397e
Fix typo in SharedObjectLoader field basedirs
2015-06-29 22:51:53 -04:00
James Cammarata
927072546b
Fixing up some issues with plugin loading
2015-06-29 22:49:25 -04:00
James Cammarata
2a5fbd8570
Winrm fixes for devel
...
* Include fixes for winrm connection plugin from v1 code
* Fixing shell plugin use
2015-06-29 22:49:25 -04:00
Henry Finucane
2d1cb7f328
Treat generators like lists and tuples
2015-06-29 14:55:11 -07:00
Matt Martz
4059904a18
Add splitext filter
2015-06-29 15:39:57 -05:00
Dustin Lundquist
cf7744f2f1
IPv6 SLAAC address computation filter
...
Jinja2 filter to compute SLAAC address.
Usage:
{{ '2db8::/64' | slaac(ansible_eth0.macaddress) }}
2015-06-25 13:20:21 -07:00
Toshio Kuratomi
548a7288a9
Use BUFSIZE when putting file as well as fetching file.
2015-06-24 01:00:22 -07:00
Toshio Kuratomi
270be6a6f5
Fix exec_command to not use a shell
2015-06-23 22:27:45 -07:00
Toshio Kuratomi
e461241d7b
Fix fetch_file() method
2015-06-23 14:45:44 -07:00
James Cammarata
d0d9be30d5
Correctly compile handler blocks for dependent roles
2015-06-23 15:48:48 -04:00
Hugh Saunders
4246777759
Re-implement the ssh connection retry, originally added in 2df690
2015-06-23 12:14:14 -04:00
James Cammarata
006391eb83
Add the improved exception reporting to the minimal callback plugin
2015-06-23 12:14:14 -04:00
Toshio Kuratomi
952166f48e
Fix problem with chroot connection plugins and symlinks from within the chroot.
2015-06-22 20:08:08 -07:00
Toshio Kuratomi
61e367f549
Better error messages when the file to be transferred does not exist.
2015-06-22 20:08:08 -07:00
James Cammarata
7490044bbe
Implement play_hosts magic variable (and ansible_current_hosts)
...
Fixes #8073
2015-06-22 21:03:55 -04:00
James Cammarata
97954ff658
Minor tweak to potentially speed the linear strategy up
...
* Don't fetch vars for the task unless we're going to use them
2015-06-22 00:53:34 -04:00
Brian Coca
b34b606fcf
fixed and/or grouping
2015-06-21 01:51:28 -04:00
Brian Coca
68325dbfe2
fixed remote tmp creation when becoem user is not root and '~/' instead of $HOME is the default
2015-06-21 01:43:35 -04:00
Brian Coca
102de96ebf
avoid password handling when no password is supplied
2015-06-21 01:24:35 -04:00
Brian Coca
3bad03d57a
cleaned up and optimized become handling paths
2015-06-21 01:13:22 -04:00
James Cammarata
0d92599d18
Make exception printing a bit smarter
2015-06-19 22:59:12 -04:00
Toshio Kuratomi
a77b58e351
Bumpt the BUFSIZE to 64k for better performance
2015-06-19 11:52:06 -07:00
Toshio Kuratomi
0777d02505
Fix problem with jail and zone connection plugins and symlinks from within the jail/zone.
2015-06-19 11:09:48 -07:00
Toshio Kuratomi
ca2f2c4ebd
Fix problem with jail and zone connection plugins and symlinks from within the jail/zone.
2015-06-19 09:41:48 -07:00
James Cammarata
c0dfa8d512
Make sure task names are templated before callbacks are sent
2015-06-18 14:27:20 -04:00
James Cammarata
98fee172ee
Fix bug in async action plugin
2015-06-18 13:49:34 -04:00
Brian Coca
7bb2a7aa87
actually no password to handle, this should return false
2015-06-18 10:23:37 -04:00
Brian Coca
87a0ccc354
fixed typo
2015-06-18 10:12:04 -04:00
Brian Coca
aede9f08db
fixed case in which prompt was None
2015-06-18 10:05:23 -04:00
Brian Coca
7c65f3ddd7
partial become support for local connection plugin
2015-06-18 01:46:43 -04:00
Brian Coca
671118ba71
fixed become password handling with paramiko
2015-06-17 23:31:55 -04:00
Brian Coca
744ec2bbad
put hostkey locking into function (still needs fixing)
...
implemneted become handling here, cannot generalize well enough in base class
2015-06-17 23:31:54 -04:00
Brian Coca
d6672ad285
removed unused import
2015-06-17 23:31:54 -04:00
Brian Coca
5cfd0f82a0
moved away from generic function for become
2015-06-17 23:31:54 -04:00
Brian Coca
3fab516d3d
fixed detection of incorrect password
2015-06-17 23:31:54 -04:00
James Cammarata
c3c398cffe
Cleaning up some task failure detection problems
...
* fixed a bug in which failures from a with_* loop were not being
caught correctly, leading to tasks continuing when they should stop
* when ignore_errors is enabled, the failure will no longer count
towards the number of failed tasks
2015-06-17 15:40:04 -04:00
Brian Coca
3b1b95b916
moved ipv6 handling to init
...
fixed become password handling
2015-06-16 15:48:10 -04:00
Brian Coca
bb7d33adbc
moved become password handlingn to base class
2015-06-16 15:48:10 -04:00
James Cammarata
4b28a51f25
Don't fail outright when a play has an empty hosts list
2015-06-16 13:56:23 -04:00
Brian Coca
c87591f76f
updated to new exec_command signature
2015-06-16 09:28:27 -04:00
Brian Coca
98f5534d9c
adaptaed to new exec signature
...
should fix #11275
2015-06-16 09:12:42 -04:00
Brian Coca
dcf81e3ffe
removed useless comments
2015-06-15 15:04:19 -04:00
Brian Coca
8ae58f7ea3
fixed executable, correctly this time
2015-06-15 11:26:45 -04:00
Brian Coca
1ce1c52f6f
centralized bad password handling, fixed outputing of become method
2015-06-15 01:40:53 -04:00
Brian Coca
b89071e485
now detects incorrect password with sudo and su (at least in english)
2015-06-15 01:30:03 -04:00
Brian Coca
580993fef7
enabled initial support for password prompt on become
...
- moved check prompt/password functions to connection, make more senes there
- TODO: consider moving make_become to connection from connection_info
- removed executable param that was never overriden outside of connection info
2015-06-15 00:09:25 -04:00
Brian Coca
bac35ae773
set correct become mehotds for plugin
...
fixed mixup with remote password vs become_password
2015-06-14 23:49:10 -04:00
Brian Coca
c3ccf26b70
added become check back to connections
2015-06-14 23:45:56 -04:00
Brian Coca
a248678518
initial become support to ssh plugin
...
- password prompt detection and incorrect passwrod detection to connection info
- sudoable flag to avoid become on none pe'able commands
2015-06-14 23:03:23 -04:00
Brian Coca
e7abe06440
added first_found to template
2015-06-13 00:34:15 -04:00
Brian Coca
8ee4c7266c
corrected original_file code path to use actually use data from original file
2015-06-13 00:10:17 -04:00
Brian Coca
491761f880
added note to add faf deprecation
2015-06-12 23:54:09 -04:00
Brian Coca
a6ca133da8
got first_available working with copy
2015-06-12 23:54:09 -04:00
Brian Coca
aca125d03e
Merge pull request #11252 from sivel/deprecated-warning
...
Display a warning when using a deprecated module
2015-06-12 16:30:45 -04:00
Matt Martz
9ed3e2ef48
Display a warning when using a deprecated module
2015-06-12 15:21:33 -05:00
Toshio Kuratomi
d315f6e22c
Fix Etcd constructor
2015-06-12 12:59:29 -07:00
Toshio Kuratomi
77c76e632e
Switch etcd and url lookup plugins to verify ssl certificates
2015-06-12 12:54:57 -07:00
Brian Coca
e07dde1a3c
Merge pull request #11251 from sivel/issue/11244
...
Require passlib over crypt in password_hash for Mac OS X/Darwin. Fixes #11244
i was almost done with my patch ... but I like yours better
2015-06-12 14:58:02 -04:00
Matt Martz
a4e2d1eb62
Require passlib over crypt in password_hash for Mac OS X/Darwin. Fixes #11244
2015-06-12 13:54:43 -05:00
Brian Coca
aaab69cae9
brought back terms testing as with_ is not only way to call and we cannot guarantee terms is a list otherwise.
2015-06-11 13:45:04 -04:00
Brian Coca
c8fde467b5
Merge pull request #11163 from sivel/ssh-private-key-fixme
...
Re-introduce ssh connection private key support
2015-06-11 09:16:27 -04:00
Brian Coca
40336b50af
removed redundant string check
...
added playbook path lookup
2015-06-10 22:58:08 -04:00
Brian Coca
19161dfd72
fixed typo in placeholder check
2015-06-09 11:46:08 -04:00
Brian Coca
8e3213a91e
updated copyright as MPD does not deserve the blame for this one
2015-06-08 20:20:07 -04:00
Brian Coca
70b5c28694
initial implementation of the generic OS package module
2015-06-08 20:12:42 -04:00
Toshio Kuratomi
e88a9e943c
Use to_bytes to avoid tracebacks when passed a byte str instead of a unicode string
...
Fixes #11198
2015-06-08 11:15:11 -07:00
Brian Coca
97bc92d2df
minor cleanup, pushed ipv6 fixing to init
...
pushed up using host short var
made close conditional, started implementing close for controlmaster
2015-06-08 10:52:08 -04:00
Brian Coca
bdba807fd1
minor fixes to ssh error reporting
...
shoudl fix #11041
2015-06-06 00:16:35 -04:00
Matt Martz
6f5ebb4489
Fix syntax error in winrm
2015-06-05 16:02:29 -05:00
Brian Coca
04f4f77d91
Merge pull request #11124 from sivel/jit-connect
...
Use a decorator to perform just in time connection
2015-06-05 11:38:17 -04:00
James Cammarata
73c956366e
Correctly determine failed task state when checking results
...
Fixes #11172
2015-06-05 07:16:19 -04:00
James Cammarata
a4ebee4b16
Merge pull request #11170 from dguerri/devel
...
Fix lookup() plugin
2015-06-04 16:05:06 -04:00
James Cammarata
ee5e166563
Fixing ansible_*_interpreter use
...
Fixes ansible/ansible-modules-core#1459
2015-06-04 15:43:07 -04:00
Davide Guerri
ee06eebea3
Fix lookup() plugin
...
lookup() plugin is currently broken because _get_file_contents() now
returns a tuple: (contents, show_data).
This patch fix that issue.
2015-06-04 19:46:09 +01:00
Matt Martz
bce281014c
Decorate the ConnectionBase methods, switch to calling super from individual connection classes
2015-06-04 13:27:18 -05:00
Matt Martz
9754c67138
Use a decorator to ensure jit connection, instead of an explicit call to _connect
2015-06-04 13:14:28 -05:00
James Cammarata
f3f3fb7c49
Fixing vars_prompt
2015-06-04 13:54:51 -04:00
Matt Martz
6a97e49a06
Re-introduce ssh connection private key support
2015-06-04 08:15:25 -05:00
Toshio Kuratomi
7dd3ef7b60
Older python-six from early RHEL and ubuntu do not have add_metaclass but do have with_metaclass
2015-06-03 13:29:24 -07:00
Brian Coca
3e2e81d896
missing path in import path for making paths
2015-06-02 23:42:00 -04:00
James Cammarata
c4ae51089d
Merge pull request #11129 from sivel/fix-scp-if-ssh
...
Fix command building for scp if ssh
2015-06-02 14:02:51 -05:00
Matt Martz
71014ab01e
Fix command building for scp if ssh
2015-06-02 13:35:53 -05:00
Brian Coca
2590df6df1
created makedirs_safe function for use in cases of multiprocess
...
should fix #11126 and most race conditions
2015-06-02 11:41:30 -04:00
James Cammarata
4bc7703db3
Fixing some small bugs related to integration tests (v2)
2015-06-01 16:42:10 -05:00
James Cammarata
7985d2a8be
Moving included file stuff to a proper dedicated class and file (v2)
2015-05-28 23:58:38 -05:00
James Cammarata
fe014148d9
Removing errant debug print
2015-05-28 20:29:16 -05:00
Brian Coca
16c70dd7d4
added equivalent of #9636 to v2
2015-05-26 11:55:52 -04:00
James Cammarata
9921a1d2be
Unit tests for base strategy class (v2)
2015-05-21 02:03:59 -05:00
James Cammarata
21fa385ce7
Reorganizing plugin unit tests and adding start of strategy tests (v2)
2015-05-18 17:26:59 -07:00
James Cammarata
9aa8676bdd
More template unit tests for v2
2015-05-17 01:06:02 -05:00
Toshio Kuratomi
b91ce29007
Go to next task when we get an error in linear
2015-05-13 12:52:51 -07:00
James Cammarata
b94e2a1f4e
Fixing bugs related to parsing and fixing up parsing integration tests (v2)
2015-05-13 11:27:12 -05:00
James Cammarata
830225d9c1
Fix errors in subelements lookup plugin and associated tests (v2)
2015-05-12 15:09:03 -05:00
James Cammarata
b03b7892f8
Fix method of exiting task loop (v2)
2015-05-12 13:09:08 -05:00
Serge van Ginderachter
9b646dea41
Add optional 'skip_missing' flag to subelements
2015-05-12 12:52:16 -05:00
James Cammarata
3697d6582f
Connection plugins no longer auto-connect (v2)
...
Also fixed a bug in ssh.py where an attribute was being inappropriately
initialized in the _connect() method instead of __init__()
2015-05-12 11:23:40 -05:00
James Cammarata
daf533c80e
V2 fixes
...
* PluginLoader class will now be more selective about loading some
plugin classes, if a required base class is specified (used to avoid
loading v1 plugins that have changed significantly in their apis)
* Added ability for the connection info class to read values from a
given hosts variables, to support "magic" variables
* Added some more magic variables to the VariableManager output
* Fixed a bug in the ActionBase class, where the module configuration
code was not correctly handling unicode
2015-05-11 11:29:48 -05:00
James Cammarata
0f1eb3cfc2
Better fix for serializing/deserializing cache plugins (v2)
2015-05-07 23:56:33 -05:00
James Cammarata
cd6d1f9221
Fix pickling errors with cache plugins (v2)
...
Fixes #10945
2015-05-07 21:15:02 -05:00
James Cammarata
198476e345
Cleaning up some portions of synchronize action plugin (v2)
2015-05-07 13:06:51 -05:00
Matt Martz
88e8ecb620
Actually get the synchronize action plugin to work
2015-05-07 12:27:30 -05:00
Matt Martz
4f4df29cb0
Add ability to specify using ssh_args in synchronize for v2
2015-05-07 11:38:15 -05:00
James Cammarata
1152c7327a
Fix serialization bug for plugins (v2)
2015-05-06 15:18:37 -05:00
James Cammarata
4f28a814ae
Return a list instead of tuple when password is specified to ssh connection plugin (v2)
2015-05-06 08:47:23 -05:00
Toshio Kuratomi
7733dc7bb5
Fix for new octal syntax
2015-05-06 06:41:16 -07:00
James Cammarata
8214ac7841
Add serializer/deserializer to plugin base object (v2)
...
Fixes #10923
2015-05-06 01:31:02 -05:00
James Cammarata
d34b586eb6
Add ability for connection plugins to set attributes based on host variables (v2)
2015-05-05 16:40:11 -05:00
James Cammarata
8fae2abed4
Properly fail out of the task loop in the linear strategy on failures (v2)
2015-05-05 13:41:32 -05:00
James Cammarata
803fb397f3
Fixing filter plugins directory from switch
2015-05-04 01:33:10 -05:00
James Cammarata
ce3ef7f4c1
Making the switch to v2
2015-05-03 21:47:26 -05:00