Michael DeHaan
9006d4557d
Added code to allow insertion of boilerplate into modules to make them able to share lots of code, the result
...
should be a huge reduction of total ansible source, at a slight cost of difficulty in original module development.
We need to apply this now to all modules, but may need to have some exemptions to things like command, which should
subclass this module.
2012-07-17 22:34:52 -04:00
Peter Sankauskas
5e35cd6466
Pass through error message when repo not found
2012-07-19 15:48:13 -07:00
John Kleint
ae665c15b3
Service module outputting extra data.
...
The service module was printing stuff to stderr, returning two
JSON dicts, not using consistent 'failed' values, had dead code
and unused variables. Added detection for the case when service
status returns 'xxx is dead and pid file exists' and made the
code a bit easier to read.
2012-07-19 13:15:09 -04:00
Michael DeHaan
1a88a3362f
add noninteractive to debian module per #602
2012-07-16 20:18:58 -04:00
Seth Vidal
f6a09bc4c1
Squashed commit of the following:
...
commit ea14bbfb52587bf5b97b5577c0439b01cb0b4836
Merge: 82819a9 285aaf8
Author: Michael DeHaan <michael.dehaan@gmail.com>
Date: Sun Jul 15 14:38:28 2012 -0400
Merge branch 'devel' of https://github.com/skvidal/ansible into skvidal_mount
commit 285aaf836c41de578bec4254624d6cabc2509f77
Merge: 634c117 32b6879
Author: Seth Vidal <skvidal@fedoraproject.org>
Date: Mon Jul 16 12:42:21 2012 -0400
Merge remote-tracking branch 'upstream/devel' into devel
* upstream/devel: (52 commits)
format fixes to make fetch more usable
...
commit 634c11748eb6aa8951a6dc4933858fbf9f2248de
Author: Seth Vidal <skvidal@fedoraproject.org>
Date: Thu Jul 12 01:16:00 2012 -0400
fix a bunch of small bugs in mount module - test with bind and local mounts
commit fcfd73de711f1927f265afe016c81265425d87fa
Author: Seth Vidal <skvidal@fedoraproject.org>
Date: Wed Jul 11 20:46:14 2012 -0400
fix some obvious bugs pointed out by #ansible
commit 13c308038370fbd06d89e2ba3c41f2accad568de
Author: Seth Vidal <skvidal@fedoraproject.org>
Date: Wed Jul 11 19:35:34 2012 -0400
mount/fstab editor
2012-07-15 14:38:40 -04:00
Michael DeHaan
64c51ade1e
Change the way we do with_items to make them happen next to each other in runner, which eliminates the problem of with_items and vars_files sometimes not playing nice with each other.
...
(Also a fix for the user module error handling when the user
is not present at the time of the return. This can only really be caused by multiple ansible executions).
2012-07-14 19:18:33 -04:00
Michael DeHaan
931f9f1a61
Setup module no longer saves to disk, as templates are mostly useful in playbooks and this allows lots of simplifications
...
around file pathing and removes occasional permissions conflicts depending on how things are used.
2012-07-14 11:59:12 -04:00
Mark Theunissen
f47cc1693d
The MySQL modules
2012-07-13 17:07:23 -05:00
Jeremy Smitherman
e5a6627d10
Removed unused recurse option in file module.
2012-07-12 02:04:51 -04:00
Michael DeHaan
fd7e96d33e
Merge pull request #578 from jeremysmitherman/boolean_parameters
...
Removed boolean parameter setting from user module.
2012-07-11 10:58:09 -07:00
Michael DeHaan
626e4cb003
Merge pull request #572 from goozbach/devel
...
fixes #569 apt module problems on old versions of apt-python
2012-07-11 10:53:29 -07:00
Jeremy Smitherman
ecacb67d31
Added yes/no to user options instead of False comparison for force and remove options for user module
2012-07-11 12:16:40 -04:00
Michael DeHaan
3f5c4772be
Merge pull request #575 from jeremysmitherman/apt-force
...
Added cmd modifications to use a force-yes option for apt module
2012-07-11 07:16:40 -07:00
Michael DeHaan
949f8b8fc5
Merge pull request #571 from sfromm/group
...
Group module fixes
2012-07-11 05:27:56 -07:00
Jeremy Smitherman
a35a0f885e
Added cmd modifications to use a force-yes option for apt module
2012-07-10 22:22:52 -04:00
Derek Carter
f38b9d1ca7
added filter for future warning
2012-07-10 19:50:08 -04:00
Stephen Fromm
ac3341cc12
Minor fix to user module to further streamline setting 'changed' flag
2012-07-10 16:37:07 -07:00
Derek Carter
e261d49acc
fixes #569 apt module problems on old versions of apt-python (namely debian 5.0)
2012-07-10 19:28:14 -04:00
Stephen Fromm
3a5f2126a6
Fixes to group module for better error handling
...
Takes a lot of the fixes to the user module and applies them to the
group module: provide stdout/stderr in result if available and call
fail_json() if the attempted action fails.
2012-07-10 16:18:53 -07:00
Michael DeHaan
3235da074e
Merge pull request #568 from sfromm/user
...
User modules fixes
2012-07-10 16:04:17 -07:00
Michael DeHaan
8bb41bc627
Merge pull request #566 from jeremysmitherman/service-no-pid
...
Added additional output to service status checker
2012-07-10 16:03:51 -07:00
Stephen Fromm
09f025b7a0
Fixes to user module for better error handling
...
The user module now returns the output, both stdout and stderr, from
useradd, usermod, and userdel. This should help debug cases why one of
those commands fail. In addition, the user module will now call
fail_json() when the attempted command failed so as to properly
communicate a failure in a playbook.
2012-07-10 15:55:39 -07:00
Seth Vidal
2f11350665
modify user module so that password is NEVER logged before the command runs
2012-07-10 17:13:51 -04:00
Jeremy Smitherman
7af3bdc89e
Added additional output to service status checker
2012-07-10 16:13:39 -04:00
John Kleint
375a1eaf43
Use iterative MD5 hashing.
2012-07-09 13:27:47 -04:00
Dave Hatton
55694db7c3
switch to hashlib.md5 or md5 instead of OS md5 commands
2012-07-09 08:52:00 +01:00
Peter Sankauskas
fed1e9870c
Assigning to boolean first
2012-07-06 18:05:15 -07:00
Peter Sankauskas
fced8cf6b0
Getting the apt module to accept and understand a 'install-recommends' parameter which allows running apt with --no-install-recommends
2012-07-06 12:12:04 -07:00
Dave Hatton
ecaa794f7f
copy always returned change=true
2012-07-06 13:43:19 +01:00
Dave Hatton
9d85a55434
switch to shutil.copy rather than os.system(cp)
2012-07-04 12:26:25 +01:00
Dave Hatton
263fcab594
md5 allow copy if file is missing
2012-07-03 20:07:08 +01:00
Jeremy Smitherman
3003aa2d47
Added IndexError catch for copy module, IndexError is thrown if a destination file doesn't exist
2012-07-03 14:12:19 -04:00
Dave Hatton
d47de18b6c
improve error trapping for md5
2012-07-03 12:44:37 +01:00
Brad Olson
be9ff7ff46
Fixes ansible/ansible#522 , no longer creates comment in ~/.ssh/authorized_keys, does not create directory or file if state==absent.
2012-07-02 19:16:57 +00:00
Brad Olson
756df550f8
Fixes ansible/ansible#523 . Removed 'with:' blocks so module works with Python 2.4 for CentOS 5 support, courtesy of mcodd/ansible@29af24b732 .
2012-07-02 17:57:38 +00:00
Derek Carter
fc4ae3e270
remove UID/GID from output
2012-07-01 17:38:17 -04:00
Derek Carter
a548769792
removed print from debug code of file module
2012-06-29 21:38:31 -04:00
Derek Carter
82832021e8
file when UID or GID doesn't exist
2012-06-29 20:05:23 -04:00
Michael DeHaan
efac68b636
Remove the -D module debug flag, which no longer is functional due to sudo pty requirements, and replace with -v/--verbose.
...
This flag will show playbook output from non-failing commands. -v is also added to /usr/bin/ansible, but not yet used.
I also gutted some internals code dealing with 'invocations' which allowed the callback to know what module invoked
it. This is not something 0.5 does or needed, so callbacks have been simplified.
2012-06-19 21:57:43 -04:00
Ludovic Claude
daf858648b
Add basic support for Solaris
2012-06-26 19:49:26 +02:00
Ingo Gottwald
a42167ca73
Copy module: Extended error handling and fixed error messages
2012-06-25 20:45:05 +02:00
Ingo Gottwald
270266e920
Added to copy module: Error handling for missing permissions on the copy destination
2012-06-23 21:39:37 +02:00
Michael DeHaan
25083953fc
Merge pull request #495 from nafeger/devel
...
make copy module implemented closer to other newer modules when returning results
2012-06-20 13:12:24 -07:00
Nathan A. Feger
26816b72ec
attempt to make copy more idiomatic.
2012-06-20 14:17:15 -05:00
Ingo Gottwald
abe33a5881
Enhanced the service state recognition in the service module:
...
- Added Upstart support
- Added an initial unknown state
- Prevented state changes when the current state is not recognized
- Changed the keyword recognition to a safer method
2012-06-17 15:55:26 +02:00
Fred Alger
80f402aa9b
Remove unused md5sum function from file module
2012-06-15 00:13:35 -04:00
Fred Alger
834f6a216d
Make shell outs to md5sum work on FreeBSD and OS X
...
Tested with OS X local connection and Linux remote. The paths to the
md5sum and md5 commands are hardcoded to the most common location. This
will definitely fail if the commands are elsewhere, or if the md5
command doesn't support the -q 'quiet' option.
2012-06-15 00:04:01 -04:00
Stephen Fromm
4a6a3fd305
Conditionally import hashlib (issue #471 )
...
Import hashlib if it is there, otherwise import md5. Adds method
file_digest that wraps the logic on which module to invoke.
2012-06-14 07:18:46 -07:00
Michael DeHaan
7926ab5b95
Merge pull request #469 from nafeger/devel
...
Add support for older version of python-apt
2012-06-13 19:21:31 -07:00
Nathan A. Feger
1d553830f2
Add support for older version of python-apt
2012-06-13 13:57:47 -05:00