1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

26421 commits

Author SHA1 Message Date
Brian Coca
577566139f fixed undefined msg and now actually return something meaningful fixes #1127 2016-12-08 11:33:29 -05:00
Rene Moser
ea6fdeb585 cloudstack: add new loadbalancer rule modules 2016-12-08 11:33:29 -05:00
Shawn Siefkas
29d6313366 Handling dry run exception 2016-12-08 11:33:29 -05:00
Shawn Siefkas
253d177dc3 Check mode support for VPC route table creation 2016-12-08 11:33:29 -05:00
Christopher M. Fuhrman
5574516934 pkgin: Support multiple matching packages
pkgin searches for packages such as 'emacs' can return multiple matches,
the first of which is not guaranteed to match.  So, iterate through
found packages until we have an appropriate match.  Should we *not* find
a match, then return False indicating match failure.
2016-12-08 11:33:29 -05:00
Brian Geihsler
2f6f6cedf8 Fix #1099: Only populate site result when it is there 2016-12-08 11:33:28 -05:00
Siva Popuri
002fc53863 minor change to remove extra brackets 2016-12-08 11:33:28 -05:00
Siva Popuri
85c09c9944 fixed typos 2016-12-08 11:33:28 -05:00
Siva Popuri
d13e34e131 corrected a typo 2016-12-08 11:33:28 -05:00
Siva Popuri
56cdaba0ab ansible module for managing anti affinity policy in centurylink cloud has been added 2016-12-08 11:33:28 -05:00
Siva Popuri
843ad8e7e8 minor refactor to remove un-used parameter 2016-12-08 11:33:28 -05:00
Siva Popuri
fd09597267 removed empty aliases from doc string 2016-12-08 11:33:28 -05:00
Siva Popuri
a2c2efb2ae Corrected a typo 2016-12-08 11:33:28 -05:00
Siva Popuri
4a8e3e9632 ansible module for managing alert policy in centurylink cloud has been added 2016-12-08 11:33:28 -05:00
Siva Popuri
01847f7bfc Ansible module for managing server snapshots in Centurylink Cloud 2016-12-08 11:33:28 -05:00
Toshio Kuratomi
60c495f18c Fix win_acl docs build 2016-12-08 11:33:28 -05:00
Toshio Kuratomi
0111b616d7 Fix docs to build 2016-12-08 11:33:28 -05:00
Linus Unnebäck
ebfb8bc7cf iptables: add note about rules 2016-12-08 11:33:28 -05:00
Linus Unnebäck
8d93747275 iptables: expand rule options 2016-12-08 11:33:28 -05:00
Linus Unnebäck
1790722dd4 module: system/iptables 2016-12-08 11:33:28 -05:00
Phil
0524904dda fixes examples in docs to use updated param name 2016-12-08 11:33:28 -05:00
Phil
43074a736d changes param src to path, and updates docs accordingly 2016-12-08 11:33:27 -05:00
Phil
00a4ec5e3b updates user search verification for local/domain - Thanks to @trondhindenes for implementing this strategy - also updated documentation 2016-12-08 11:33:27 -05:00
Phil
9ad30acd96 changes check for src 2016-12-08 11:33:27 -05:00
Phil
6abfcffc70 check if the rule exists or not before allow/deny rules are added/removed, and fixes where result changed would be true on all executions. 2016-12-08 11:33:27 -05:00
schwartzmx
25a3793a49 inital commit win_acl 2016-12-08 11:33:27 -05:00
Brian Coca
a65647efee added version_added and fixed some doc parsing issues 2016-12-08 11:33:27 -05:00
Jeremy Wells
c8e0f3a552 Add consul http checks to consul.py
Consul module already supports ttl and script checks. This commit adds
http checks.
2016-12-08 11:33:27 -05:00
Steve
fea8995df1 Fix bug #1105 - incorrect use of lstrip()
Remove only the literal prefix '/dev/mapper/' - not any of the characters
in '/dev/mapper/' - from the name param of the crypttab module.
2016-12-08 11:33:27 -05:00
Brian Coca
d530764c49 fixed option in examples 2016-12-08 11:33:27 -05:00
Charles Paul
3913de1c43 reference instance_id in docs, fixes for calls to fail_json 2016-12-08 11:33:27 -05:00
Trond Hindenes
15ac8e9141 turned out strict msi code checking 2016-12-08 11:33:27 -05:00
Nicolas Landais
4fc4030c58 Adding fix to get around bug found with the New-Webstire command when running playbook on a vanilla machine. 2016-12-08 11:33:27 -05:00
Dreamcat4
40a1bd1962 fix: Add 'enable:' flag for enabling existing rules which are disabled by default.
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.

Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.

But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
2016-12-08 11:33:27 -05:00
Dreamcat4
e0da4a3362 fix: update documentation with new module name "win_firewall_rule" 2016-12-08 11:33:27 -05:00
Dreamcat4
7188ae4fe1 fix: The names of firewall profiles are different on win10 & win2008r2
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
2016-12-08 11:33:27 -05:00
Dreamcat4
f64e438150 fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
2016-12-08 11:33:26 -05:00
Dreamcat4
b9dd3568f3 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
2016-12-08 11:33:26 -05:00
Ramon de la Fuente
1d09eaf6d0 updated the examples to the new Slack API 2016-12-08 11:33:26 -05:00
Ramon de la Fuente
918012a42f module guidelines compliency 2016-12-08 11:33:26 -05:00
Stefan Berggren
aeb1090542 Add attachments support to slack module. 2016-12-08 11:33:26 -05:00
Kevin
b43329b6a0 Remove homebrew- prefix when checking if repo has already been tapped
See: https://github.com/Homebrew/homebrew/blob/master/Library/Homebrew/cmd/tap.rb

Example:

```
$ brew tap neovim/homebrew-neovim
$ brew tap
neovim/neovim
...
```
2016-12-08 11:33:26 -05:00
Luis Rodriguez
adedc7ef3f Fix bug #1067 2016-12-08 11:33:26 -05:00
Brian Coca
1426c3ba02 added missing GPL licences fixes #508 2016-12-08 11:33:26 -05:00
Michael Perzel
f84dc8fd5d Improve example wide_ip variable 2016-12-08 11:33:26 -05:00
Michael Perzel
9c8891740c Wrap main() in conditional 2016-12-08 11:33:26 -05:00
Michael Perzel
21425f36ef Update bigip_api method to use variable name server 2016-12-08 11:33:26 -05:00
Michael Perzel
6681a5b386 Style updates 2016-12-08 11:33:26 -05:00
Michael Perzel
ca0d4aad52 Module for managing F5 wide ip 2016-12-08 11:33:26 -05:00
Toby Fleming
3293fe7231 Homebrew: Allow colons, direct check for outdated formula 2016-12-08 11:33:26 -05:00