Brian Coca
f66ba92745
now vault prompts for password if no password file was given, as in 1.x
2015-07-19 22:24:20 -04:00
Brian Coca
a8ba9cac3f
fixed ansible pull bad options ref, removed print in favor of display
2015-07-19 18:28:03 -04:00
Brian Coca
f8905013cd
now executes fact search when needed
2015-07-19 18:00:27 -04:00
James Cammarata
2c98b271c8
Make paramiko password detection logic match ssh connection
2015-07-19 02:23:53 -04:00
James Cammarata
3d77723e3d
Cleaning up some stuff related to the connection info/become/executable change
2015-07-19 01:12:23 -04:00
James Cammarata
1c185b68be
Rearranging some become stuff in relation to action/connection plugins
...
Moving the make_sudo_cmd() calls back up to the action level so that connection
plugins don't have to know about it at all, and moving some of the become data
(prompt and success_key) into the ConnectionInformation object so they don't
need to be passed around needlessly.
2015-07-19 01:12:23 -04:00
James Cammarata
7a9b5b6fe8
Remove unnecessary make_become_cmd from paramiko exec_command
...
Fixes #11611
2015-07-19 00:08:09 -04:00
Brian Coca
9dc5607730
Merge pull request #11519 from bcoca/human_readable
...
new human_readable filter to transform bits and bytes into cake
2015-07-18 23:10:53 -04:00
Brian Coca
115dce028d
Merge pull request #11604 from bcoca/faf_deprecated_fixes
...
fixed first_available_found for template
2015-07-18 23:09:47 -04:00
Brian Coca
4f98fac494
Merge pull request #10914 from bcoca/non_posix_file_copy_fix
...
hack to prevent tempalte/copy errors on vagrant synced folders
2015-07-18 23:08:08 -04:00
Indrajit Raychaudhuri
4553a41ab5
Add homebrew to package managers' list
2015-07-18 19:46:26 -05:00
James Cammarata
271a7f3281
Cleaning up some of the notify/facts logic added earlier to fix problems
2015-07-17 14:44:19 -04:00
Brian Coca
1aa4155266
generalized warning handling, added it to adhoc also
2015-07-17 14:14:15 -04:00
James Cammarata
d4ac73a1bc
Adding back capability to display warnings contained in results
...
Fixes #11255
2015-07-17 13:44:22 -04:00
James Cammarata
5abdd3b821
Handle notifications when coupled with a loop
...
Fixes #11606
2015-07-17 12:03:04 -04:00
Serge van Ginderachter
8d1549900c
fix AnsibleError object name in subelements plugin
...
fixes #11624
2015-07-17 17:39:31 +02:00
Brian Coca
bc5a7fce79
Merge pull request #11616 from halberom/ssh_port
...
fixes 11607, override ansible_ssh_port in group/host_vars
2015-07-17 11:21:17 -04:00
Gerard Lynch
a6c8d30f3e
callbacks require a version constant or the v2 code doesn't pass the display param and it gives an error
2015-07-17 15:33:48 +01:00
Brian Coca
6ba706f753
minor doc reformatting
...
now version_added < 1.3 does not get shown, up from 1.0
option's version_added is also now filterd against this threshold
module version_added is more prominent
exaples now uses pure rst instead of intermingled with html formatting
aliases now shown in description for options
bad version fields now throw warnings instead of exceptions
ansible-doc errors now show traceback in very very verbose mode, for easier debugging
2015-07-17 10:07:22 -04:00
Brian Coca
da890f9328
Merge pull request #11622 from amenonsen/gathering
...
devel breaks «gathering=explicit» setting in ansible.cfg
2015-07-17 09:04:23 -04:00
Brian Coca
a09f6236a5
adapated to v2
2015-07-17 08:55:22 -04:00
Brian Coca
10e5c2b46d
fixed var scope
2015-07-17 08:54:28 -04:00
Tom Paine
097ed1f17b
Add plugin that profiles playbook tasks
...
Resubmission of https://github.com/ansible/ansible/pull/11270 to
correct v2 file location.
[Description and console output
demonstration](https://github.com/aioue/ansible-plugin-profile/blob/mast
er/README.md#features).
Provides per-task timing, ongoing playbook elapsed time and ordered
list of top 20 longest running tasks at end.
2015-07-17 13:04:31 +01:00
Abhijit Menon-Sen
28e2eae902
Make gathering=explicit work again
...
There was a confusion between the valid values for defaults.gathering
(explicit/implicit/smart) and a play's gather_facts setting (boolean),
which resulted in gathering=explicit being ignored.
2015-07-17 13:05:00 +05:30
Gerard Lynch
d23ab261e1
fixes 11607, allows ansible_ssh_port to be overridden from group or host_vars
2015-07-16 23:00:17 +01:00
Brian Coca
978390693b
changed to default 'auto' as it better describes the use= option
2015-07-16 16:45:04 -04:00
James Cammarata
94fa741f96
Make sure files loaded by template action are decoded properly
...
Fixes #11247
2015-07-16 15:23:40 -04:00
Brian Coca
5ba9fe4748
now supports maintainers and author field for display as MAINTAINERS
2015-07-16 15:18:33 -04:00
Brian Coca
c603caca27
removed extra print now that items are getting passed to callback in result
2015-07-16 15:13:35 -04:00
James Cammarata
86a83c16b8
Remove some dead code from the base load_data method
...
Was causing an odd error which threw off the error detection code
when the datastructure was a string corresponding to a variable.
2015-07-16 15:10:41 -04:00
James Cammarata
d977dd507c
Merge pull request #11609 from ofpiyush/devel
...
Fix #11369 A result is skipped when all it's children are skipped. Th…
2015-07-16 11:45:04 -04:00
James Cammarata
052f3c2ece
Fixing allow_duplicate and variable resolution bugs
...
Fixes #11205
2015-07-16 11:39:40 -04:00
Piyush
f2bdd9af29
Fix #11369 A result is skipped when all it's children are skipped. This makes it fundamentally different from a result that was changed/failed/unreachable
2015-07-16 17:50:15 +05:30
Brian Coca
5a5b7ff561
fixed first_available_found for template, refactored into common function
...
added deprecation warning
fixed display.deprecated to make version optional (code already assumed this)
turned warning + 'deprecated' in plugin loader into actual call to deprecated()
2015-07-15 19:47:59 -04:00
Jonathan Davila
6ea772931f
Connection function for boto3
...
Boto3 conn
2015-07-15 16:52:01 -04:00
Toshio Kuratomi
3d3e1c82a2
Have openssl autonegotiate tls protocol on python < 2.7.9
...
This allows usage of tls-1.1 and tls-1.2 if the underlying openssl
library supports it. Unfortunately it also allows sslv2 and sslv3 if
the server is only configured to support those. In this day and age,
that's probably something that the server administrator should fix
anyhow.
2015-07-15 13:17:00 -07:00
James Cammarata
ba7243c5f9
Don't set changed for include tasks
...
Fixes #11197
2015-07-15 15:11:46 -04:00
James Cammarata
291f07242c
Properly return Jinja2 Undefined class for bad hostvars lookups
...
Fixes #11176
2015-07-15 14:36:42 -04:00
James Cammarata
9fe0f21f6a
Allow omit to be used on Playbook-level fields
...
Fixes #11173
2015-07-15 13:53:59 -04:00
James Cammarata
165fff8a1e
Fixing module arg parsing splitting when action is a variable
...
Fixes #11122
2015-07-15 12:03:02 -04:00
Brian Coca
b76cb8f655
now that invocation is only async again, no need to sanitize
2015-07-15 10:40:37 -04:00
James Cammarata
2d870b7112
Fix logic where invocation details are added to results
2015-07-15 10:20:55 -04:00
James Cammarata
0b035a4e35
Unicode in result debug statements caused a traceback
2015-07-15 01:56:28 -04:00
Brian Coca
ae6d9ebf28
added maintainers (from author field) to ansible-doc
2015-07-14 17:33:27 -04:00
Brian Coca
fbec8bfb90
updated ref to add docfixes
2015-07-14 17:03:57 -04:00
Brian Coca
0e1d771a33
updated submodule refs
2015-07-14 16:47:47 -04:00
Toshio Kuratomi
3e293f524a
Merge pull request #11589 from ansible/get_url-sni-tls-fix
...
Add support for SNI and TLS-1.1 and TLS-1.2 to the fetch_url() helper
2015-07-14 12:49:37 -07:00
Toshio Kuratomi
327b1676a8
Add support for SNI and TLS-1.1 and TLS-1.2 to the fetch_url() helper
...
Fixes #1716
Fixes #1695
2015-07-14 12:48:35 -07:00
James Cammarata
8d887d8dd3
Adding back --start-at-task feature
...
Also implemented framework for --step, though it's not used yet
2015-07-14 15:02:20 -04:00
Brian Coca
3c7faa8378
fixed missing self in self.action on rekey in vault
...
fixes #11584
2015-07-14 10:10:03 -04:00
Brian Coca
42e355f9a3
fragments can now be a list
2015-07-14 10:07:59 -04:00
Brian Coca
ea159ef9de
fixed backup and validate fragments
2015-07-14 10:07:59 -04:00
James Cammarata
4e94bb64d8
Fix group/host var loading relative to playbook basedir
2015-07-14 09:26:24 -04:00
James Cammarata
7dd5600839
Allow empty include files again
...
Fixes #11582
2015-07-14 08:26:11 -04:00
Brian Coca
8793308c39
made md5 into generic checksum function that uses sha now
2015-07-14 07:28:32 -04:00
James Cammarata
6971e92f39
Fixing up some output stuff
2015-07-14 00:23:17 -04:00
James Cammarata
9a586c3512
Properly catch AnsibleError and not all errors
2015-07-13 20:49:11 -04:00
Brian Coca
2b723c6130
added missing re import
2015-07-13 20:42:09 -04:00
Brian Coca
3102469b94
fixing become success string
2015-07-13 20:40:40 -04:00
Brian Coca
a09f44210e
now callback errors are not silent but warnings
2015-07-13 19:23:27 -04:00
Brian Coca
e0632cb9a4
Merge pull request #11577 from srvg/yaml_file_extensions
...
Use YAML_FILENAME_EXTENSIONS for vars files.
2015-07-13 18:29:26 -04:00
Brian Coca
5daa540bc0
Merge pull request #11576 from srvg/combine_empty_vars_file
...
Do not combine group_vars with an empty file
2015-07-13 18:26:02 -04:00
Serge van Ginderachter
d5fb11d89c
Use YAML_FILENAME_EXTENSIONS for vars files.
...
The v2 codebase didn't use this previously introduced constant yet.
C.YAML_FILENAME_EXTENSIONS
2015-07-14 00:23:35 +02:00
Serge van Ginderachter
9c8f0da327
Do not combine group_vars with an empty file
...
This addresses a specific case with multiple vars files
in a group_vars/${groupname}/ directory where one of those files
is empty, which returns None instead of an empty dict.
2015-07-14 00:14:13 +02:00
Brian Coca
24b830bbc8
fixed executable for raw module
2015-07-13 16:23:14 -04:00
Brian Coca
c4b6d91275
added skipped to oneline
2015-07-13 15:54:12 -04:00
Brian Coca
8ad52c2e4f
readded oneline output feature to adhoc
...
fixes #11573
2015-07-13 15:43:31 -04:00
Brian Coca
3a768b3b9f
removed unused methods, these now live in base class
2015-07-13 15:43:31 -04:00
James Cammarata
c18fdd0c18
Re-implement "conditional imports" for vars_files
2015-07-13 15:18:23 -04:00
James Cammarata
d977da5b41
Fixing up fact_cache use in VariableManager
2015-07-13 11:06:03 -04:00
James Cammarata
932d1e57f7
Removing stray debugging print
2015-07-13 10:56:09 -04:00
James Cammarata
91c9bb96e3
Moving jsonfile cache plugin over and fixing #10883
...
Fixes #10883
2015-07-13 10:42:10 -04:00
Brian Coca
d8abae71a4
now assemble skips during checkmode
...
TODO: actually make it check with checkmode
fixes http://github.com/ansible/ansible-modules-core/issues/661
2015-07-13 10:34:44 -04:00
Alejandro Guirao
587a6cb44c
Remove v1 code
2015-07-13 15:48:23 +02:00
Alejandro Guirao
6e99023c84
Changed to support Ansible v2
2015-07-13 15:37:27 +02:00
Alejandro Guirao
8efc42d993
Add shelvefile lookup plugin
2015-07-13 10:31:35 +02:00
James Cammarata
f40b66d841
Make sure the basedir is unicode
...
Fixes #10773
2015-07-12 16:40:00 -04:00
Brian Coca
ba92965670
fix for when invocation data is missing
2015-07-12 16:10:52 -04:00
James Cammarata
c5c1dc2f11
Removing tags/when from role param hash calculation
2015-07-11 21:49:35 -04:00
Brian Coca
4203b699a8
removed dict comprehension as 2.6 does not like
2015-07-11 15:15:46 -04:00
Brian Coca
032690a843
fix read_vault_password_file ref
2015-07-11 15:05:32 -04:00
Brian Coca
d993e7000c
added cyan back to ignoring message
2015-07-11 15:01:50 -04:00
Brian Coca
064a34689a
now actually continues play on ignore errors
2015-07-11 14:53:23 -04:00
Brian Coca
fe91f7b506
moved read_vault_file to CLI from utils and renamed to clearer read_vault_password_file
2015-07-11 14:24:45 -04:00
Brian Coca
e4097ed279
simplified ansible errors, moved md5 hash import with notes to be more prominent
2015-07-11 14:24:00 -04:00
Brian Coca
1274ce565d
added result sanitation to registered var and to callbacks
...
removed time display as it only is provided by command module
2015-07-11 01:05:29 -04:00
Brian Coca
fdea00880b
now default shows time taken when -vv or above
2015-07-11 00:02:40 -04:00
Brian Coca
7a1bce1b5d
added verbose option to show callback loaded info
...
also made mail module print nicer without all those 'u'
2015-07-10 23:48:12 -04:00
Brian Coca
4b9a79d42b
removed trailing newline
...
fix from #10973 by @retr0h
2015-07-10 22:12:46 -04:00
teh 4r9h
705018a417
Misspell in mail.py callback.
...
Looks like little misspell.
2015-07-11 02:53:32 +02:00
Brian Coca
e9a3a2912d
Merge pull request #9281 from woltage/devel
...
Enables 'force basic auth' -feature globally
2015-07-10 18:20:52 -04:00
James Cammarata
4608897c27
Submodule update
2015-07-10 13:55:44 -04:00
Carlos E. Garcia
657495d13f
minor spelling changes
2015-07-10 12:42:59 -04:00
Brian Coca
aaad33ccb6
fixed a couple of bugs
2015-07-10 10:30:33 -04:00
Brian Coca
d0c6d2ff1c
poreted log_plays, syslog_json and osx_say callbacks to v2
...
renamed plugins to contrib (they are not really plugins)
rewrote README.md to reflect new usage
added new dir to setup.py so it gets copied with installation, in views
of making using inventory scripts easier in teh future
2015-07-10 10:30:33 -04:00
Brian Coca
50d54b1be7
ported hipchat callback to v2 (needs testing)
2015-07-10 10:30:33 -04:00
Brian Coca
e92e15b5f6
moved unused functions to base object
2015-07-10 10:30:33 -04:00
Brian Coca
b47d7babe5
removed warning i was using for debug
2015-07-10 10:30:33 -04:00
Brian Coca
834b7a2857
ported context_demo to v2 callbacks
2015-07-10 10:30:33 -04:00
Brian Coca
ba0e5323d6
removed connection info to _verbosity, just needed callbacks to call correct display.verbosity
...
added v2 methods and made them call v1 when possible by tranforming the data
2015-07-10 10:30:33 -04:00
Brian Coca
a918a1bd16
now calls correct v2_on_any callback method
2015-07-10 10:30:33 -04:00
Brian Coca
f9d817e636
now looks at correct verbosity and removes the need to set a copy of it in _verbosity
2015-07-10 10:30:33 -04:00
James Cammarata
cf2a66ef30
Add ansible_version magic variable
...
Fixes #11545
2015-07-10 03:22:37 -04:00
James Cammarata
b0e6baf8c3
Fix bug where options may not have the force_handlers value from the cli
2015-07-10 03:19:48 -04:00
James Cammarata
f8ddf2eb04
Move role cache into the play to avoid roles crossing play boundaries
2015-07-10 02:43:53 -04:00
James Cammarata
b520d5bc60
Lots of fixes for integration test bugs
2015-07-10 01:53:59 -04:00
Iiro Uusitalo
4e7542af37
Merge upstream changes
2015-07-10 08:44:20 +03:00
Iiro Uusitalo
403f4881ee
Enables 'basic auth force' -feature globally
2015-07-09 23:11:52 +03:00
James Cammarata
a9712bb0fb
Fixing some delegate_to bugs
...
* Moving connection creation until after the task is post_validated,
to make sure all fields are properly templated (#11230 )
* Fixing problems related to the connection method and remote address
lookup on the delegated-to host
Fixes #11230
2015-07-09 08:25:08 -04:00
Brian Coca
3ba67dd2d0
added ignore_hidden to assemble
2015-07-09 00:27:29 -04:00
Brian Coca
b5f3e84014
now allows for empty vars sections, returns empty dict
...
fixes #11532
2015-07-08 22:45:01 -04:00
Brian Coca
55366bdc6d
ported mail callback plugin to work with v2
2015-07-08 16:33:51 -04:00
Brian Coca
897e098b27
minor fixes to constants
2015-07-08 16:33:51 -04:00
Toshio Kuratomi
dd058a1dc2
Fix required_if (needed to pass list to _count_terms)
2015-07-08 09:45:02 -07:00
James Cammarata
27fcf1a4b5
Fix bug in registered variables related to delegate_to changes
2015-07-08 12:38:24 -04:00
James Cammarata
64a1b1e043
Fix first_available_file: support for copy and template actions
2015-07-08 12:23:42 -04:00
Toshio Kuratomi
ddac6fa9f3
Update exception handling to be python3 compat
2015-07-08 08:59:42 -07:00
James Cammarata
8f0496d7ce
Fix usage of set_host_var when registering a result var
...
Fixes #11521
2015-07-08 09:15:55 -04:00
James Cammarata
2e5dfd57cc
Clear flag indicating role had run before each play is run
...
Fixes #11514
2015-07-07 21:47:48 -04:00
Brian Coca
a02555ad91
Merge pull request #11483 from pilou-/jinja2_header_overrides
...
implement jinja2 header overrides
2015-07-07 18:02:00 -04:00
James Cammarata
f67949e42c
Readd logic for ansible_managed to template action plugin
...
Fixes #11317
2015-07-07 16:48:19 -04:00
James Cammarata
da307c8bfd
Fix bug in logic introduced in 614c626
2015-07-07 16:09:36 -04:00
James Cammarata
293dd38d05
Correctly handle assigning results to the delegated to host
2015-07-07 16:09:36 -04:00
Brian Coca
688088547b
new human_readable filter to transform bits and bytes into cake (not really)
2015-07-07 15:58:18 -04:00
Toshio Kuratomi
49a148056c
Ensure that we're dealing with byte str when we print or log messages
2015-07-07 12:05:59 -07:00
James Cammarata
614c626ed0
Fix no hosts remaining logic in linear strategy
2015-07-07 14:20:07 -04:00
Toshio Kuratomi
135fa41e3a
Update submodules refs
2015-07-07 10:54:36 -07:00
Marc Abramowitz
314bae2a9e
Don't wrap text for AnsibleParserError
...
This allows not messing up the wonderful error reporting that is
carefully created. Instead of:
$ ansible-playbook foo.yml
[ERROR]: ERROR! 'foo' is not a valid attribute for a Task The error appears
to have been in '/Users/marca/dev/git-repos/ansible/foo.yml': line 4, column 7,
but may be elsewhere in the file depending on the exact syntax problem. The
offending line appears to be: tasks: - name: do something ^ here
we get:
$ ansible-playbook foo.yml
ERROR! 'foo' is not a valid attribute for a Task
The error appears to have been in '/Users/marca/dev/git-repos/ansible/foo.yml': line 4, column 7, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
tasks:
- name: do something
^ here
which is much nicer.
2015-07-07 09:31:00 -07:00
Brian Coca
50efeb13ba
made squashable with_ plugin list configurable
...
partially deals with #11383
2015-07-07 11:59:20 -04:00
Brian Coca
a6aedbcc51
now correctly picks up old become password host vars
2015-07-06 23:24:00 -04:00
Toshio Kuratomi
49e17b8ff6
Get rid of an unused import so that we don't have circular imports
2015-07-06 14:19:13 -07:00
Toshio Kuratomi
5b0b1f8da6
unquote strings in the ansible config file
2015-07-06 14:12:10 -07:00
Toshio Kuratomi
f44f9569e1
Test unquote works as expected and fix two bugs:
...
* escaped end quote
* a single quote character
2015-07-06 13:16:42 -07:00
James Cammarata
1d8ccfb99f
Fixing includes where the included file is "{{item}}"
2015-07-06 14:30:56 -04:00
James Cammarata
46b33152c8
Check for ansible_su*_pass as well as _password
...
Fixes #11500
2015-07-06 13:49:25 -04:00
Toshio Kuratomi
378c8fd549
Update submodule refs
2015-07-06 10:44:27 -07:00
Brian Coca
2c9d1257ba
put type checking before looking against choices array to always get type comparrison correctly
2015-07-05 19:55:11 -04:00
Brian Coca
22a0aa016f
pbrun not forced to use local daemon anymore
2015-07-05 15:51:12 -04:00
Brian Coca
2a0cc38922
Merge pull request #11494 from jonhadfield/add_iso8601_basic_datetime
...
Add facts for datetime 8601 basic and basic short.
2015-07-05 14:55:20 -04:00
Brian Coca
05be30168d
return empty string when config file is not used
2015-07-05 12:51:05 -04:00
Jon Hadfield
82e00b1022
add facts for datetime 8601 basic and basic short.
2015-07-05 17:23:22 +01:00
Brian Coca
51efd765be
Merge pull request #11415 from msabramo/remove_unnecessary_imports
...
Remove unnecessary imports
2015-07-05 01:09:28 -04:00
James Cammarata
9155af20e3
Make sure vars in debug tasks aren't templated too early
...
If the syntax var={{something}} is used, that can be templated too
early in the post_validation, leading the debug module to fail when it
tries to template the same value in turn.
2015-07-05 01:06:54 -04:00
James Cammarata
38cc54b717
Make 'vars' a copy to prevent recursion issues
2015-07-04 23:34:07 -04:00
James Cammarata
bddadc9565
Fix bug in relative path determination
2015-07-04 23:18:54 -04:00
James Cammarata
38c5da9d2a
Revert "Backing out vars magic variable due to failed tests"
...
This reverts commit 388e46a485
.
2015-07-04 22:48:20 -04:00
James Cammarata
388e46a485
Backing out vars magic variable due to failed tests
2015-07-04 22:44:45 -04:00
James Cammarata
76c5be3a31
Add 'vars' to magic variables
2015-07-04 21:28:28 -04:00
Marc Abramowitz
0676157897
Remove unnecessary imports
2015-07-04 17:41:36 -07:00
Brian Coca
552715f072
added validate and backup doc fragments
2015-07-04 17:58:23 -04:00
Spencer Krum
3887173c2c
Use cfacter instead of facter if possible
...
CFacter is the facter replacement written in C++. It is available from
the puppetlabs repo.
2015-07-04 09:13:20 -07:00
Brian Coca
5f791329ce
now verbose mode shows config file used
2015-07-04 10:23:49 -04:00
James Cammarata
67671e328a
Fix callback loading issue a slightly different way
2015-07-04 00:07:17 -04:00
James Cammarata
a51c165157
Revert "load callbacks on init again as they did not seem to load with new call from executor"
...
This reverts commit cf4ed9a556
.
2015-07-03 23:52:59 -04:00
James Cammarata
2ddd83360a
Revert "removed 2nd load_callbacks that was causeing dupe output"
...
This reverts commit de98dc2968
.
2015-07-03 23:52:49 -04:00
Brian Coca
4d35d8bd31
properly booleanify copy field
2015-07-03 18:59:49 -04:00
Pierre-Louis Bonicoli
720e184f88
implement jinja2 header overrides
2015-07-03 22:27:49 +02:00
Brian Coca
de98dc2968
removed 2nd load_callbacks that was causeing dupe output
2015-07-03 14:28:10 -04:00
Brian Coca
bdccfa71a8
Merge pull request #11482 from verm666/issue-1627
...
facts: add aliases to ansible_all_ipv4_addresses on OpenBSD
2015-07-03 13:57:10 -04:00
Brian Coca
5122455db8
ported missing sequence updates from 1.9
2015-07-03 13:54:51 -04:00
Brian Coca
cf4ed9a556
load callbacks on init again as they did not seem to load with new call from executor
2015-07-03 13:01:21 -04:00
Brian Coca
9e37402cb7
added ramfs to selinux ignored filesystems
...
as reported in #11442
2015-07-02 17:25:05 -04:00
James Cammarata
31239f44cd
Show failed result on a retry message
...
Fixes #10099
2015-07-02 10:33:41 -04:00
verm666
d91947ee96
facts: add aliases to ansible_all_ipv4_addresses on OpenBSD
2015-07-02 15:36:56 +03:00
James Cammarata
08ad05c83b
Make sure callbacks are loaded in the tqm a bit earlier
...
Fixes #11463
2015-07-02 02:51:24 -04:00
Brian Coca
1b74102ab3
Merge pull request #11435 from hfinucane/ipwrap-generator
...
Treat generators like lists and tuples
2015-07-01 18:34:44 -04:00
Toshio Kuratomi
71f72b655e
Merge pull request #11432 from sivel/splitext-filter
...
Add splitext filter
2015-07-01 13:17:56 -07:00
James Cammarata
9341148f04
Throw an error if with_first_found finds no files by default
...
Fixes #9976
2015-07-01 16:09:34 -04:00
Toshio Kuratomi
b11e69f3d0
Merge pull request #11452 from soarpenguin/devel
...
fix type error.
2015-07-01 12:41:05 -07:00
Brian Coca
13ac0ba1fe
now setuptools will pull the data dir with templates that are used by galaxy init
2015-07-01 11:12:10 -04:00
Brian Coca
08e981b9f4
corrected api permissions
2015-07-01 11:12:10 -04:00
James Cammarata
cf51d0a790
Fixing up some check-mode stuff
2015-07-01 15:10:25 -04:00
James Cammarata
ad53b6f36a
Merge pull request #11461 from pilou-/shell_removed
...
Fix "AttributeError: 'ActionModule' object has no attribute '_shell'"
2015-07-01 14:35:27 -04:00
James Cammarata
7fa37870c8
Merge pull request #9683 from justinwyer/logical-block-size-and-sectors-9549
...
Disk size for advanced drives over 2 TB is incorrect
2015-07-01 14:14:04 -04:00
James Cammarata
dcb9b5a69f
Make --module-path work and expand tilde's in paths
...
Fixes #9937
Fixes #9949
2015-07-01 12:39:39 -04:00
Toshio Kuratomi
fffb65d45f
Update submodule refs
2015-07-01 09:34:17 -07:00
James Cammarata
2e386deeae
Make undefined variables in debug var=foo more obvious
...
Fixes #9935
2015-07-01 11:55:00 -04:00
James Cammarata
b6c52ce115
Allow role variables to be optionally kept in a private scope
2015-07-01 11:33:14 -04:00
Pierre-Louis Bonicoli
4d4512940d
Fix "AttributeError: 'ActionModule' object has no attribute '_shell'"
...
'_shell' was removed with commit 2a5fbd8570
2015-07-01 17:22:09 +02:00
Brian Coca
dcb06ac7a8
Merge pull request #11445 from emonty/devel
...
Fix a tiny typo
2015-07-01 09:34:32 -04:00
Brian Coca
0a2a9557b8
now allows for users to use ^D to not input a password
...
fixes #11413
2015-07-01 05:22:49 -04:00
Benno Joy
4889d04fc6
fixes 11448 , yum with with_items
2015-07-01 10:02:54 +05:30
soarpenguin
c6ed1ff4ad
fix type error.
2015-07-01 12:16:01 +08:00
James Cammarata
7c1d569a26
Make sure tags are pulled out of playbook includes properly
...
Fixes #9862
2015-06-30 16:09:04 -04:00
Toshio Kuratomi
54e7c8a3f7
Add python requirement to the documentation for openstack modules requiring shade
2015-06-30 12:51:20 -07:00
Monty Taylor
e89f1186e7
Fix a tiny typo
2015-06-30 14:46:43 -04:00
James Cammarata
ec4d1b11df
Fix some more handler issues
...
* Only notify handlers when the task is changed
* Don't run handlers on hosts which have failed
2015-06-30 14:44:41 -04:00
James Cammarata
2576f480fd
Restoring a state check to play_iterator, which otherwise broke block functionality
2015-06-30 13:57:47 -04:00
Matt Martz
65fdcf8b9d
Check for name or pkg when templating squashed items. Fixes #11430
2015-06-30 10:15:25 -05:00
James Cammarata
0cfebb8760
Fixes a bug whereby tags are expected to be a set
...
Fixes #11424
Fixes #11429
2015-06-30 07:18:41 -04:00
Brian Coca
d149ea5222
ported timer.py callback to v2
2015-06-29 20:45:50 -04:00
Brian Coca
7416e00541
fixed condition for loading whitelisted callbacks
2015-06-29 20:45:50 -04:00
James Cammarata
9785e5397e
Fix typo in SharedObjectLoader field basedirs
2015-06-29 22:51:53 -04:00
James Cammarata
927072546b
Fixing up some issues with plugin loading
2015-06-29 22:49:25 -04:00
James Cammarata
2a5fbd8570
Winrm fixes for devel
...
* Include fixes for winrm connection plugin from v1 code
* Fixing shell plugin use
2015-06-29 22:49:25 -04:00
Henry Finucane
2d1cb7f328
Treat generators like lists and tuples
2015-06-29 14:55:11 -07:00
Toshio Kuratomi
8a76371a1c
Merge pull request #11394 from dlundquist/ipaddr-slaac-filter
...
IPv6 SLAAC address computation filter
2015-06-29 14:23:50 -07:00
Matt Martz
4059904a18
Add splitext filter
2015-06-29 15:39:57 -05:00
Toshio Kuratomi
be6db1a730
Refactor the argspec type checking and add path as a type
2015-06-29 08:05:58 -07:00
James Cammarata
21c14363fd
Allow callback plugins to be whitelisted
2015-06-29 10:56:28 -04:00
James Cammarata
24226646fc
When loading the play hosts list, enforce some consistency
...
Fixes #9580
2015-06-28 01:00:32 -04:00
James Cammarata
9d9cd0c42c
Handle getting the ds for Conditionals which may not be mixed in
2015-06-28 00:30:27 -04:00
James Cammarata
f433e709f2
Fix templating of hostvars values
...
Also adds play information into the hostvars creation, to assure the
variable manager used there has access to vars and vars_files
Fixes #9501
Fixes #8213
Fixes #7844
2015-06-27 21:04:16 -04:00
James Cammarata
8ef28253e3
Properly catch and report conditional test failures
2015-06-27 15:37:10 -04:00
James Cammarata
0eb1c880dd
Use itertools instead of set for tags, as the data may not hash well
...
The tags field may contain bad data before it is post_validated, however
some methods assumed it would be a simple list or string. Using itertools
gets us around the problem of the data potentially not being hashable
Fixes #9380
2015-06-27 15:19:44 -04:00
Brian Coca
af49944ab2
Merge pull request #11398 from resmo/for-ansible
...
cloudstack: fixes and updates
2015-06-27 13:28:37 -04:00
James Cammarata
bb8d87ceb6
Allow field attributes which are lists to validate the type of the list items
...
Starting to apply this for tags too, however it is not correcting things
as would be expected.
2015-06-27 01:01:51 -04:00
James Cammarata
f68223b9ed
Don't add module args into variables at all
...
Getting recursive errors otherwise, so this is probably not something
we want to do. This most likely only worked in v1 due to the fact that
module args were templated earlier than the point in Runner() when
they were fed into the templating engine.
2015-06-27 01:01:51 -04:00
Brian Coca
e153f76c95
now validate that we do get a vault password
2015-06-27 00:02:24 -04:00
Uli Martens
25fc0c7e1b
Fixing bug in failed_when results introduced by c3c398c
2015-06-26 16:55:06 -04:00
James Cammarata
b723f9a09a
Allow squashed loop items to use name=foo-{{item}}
...
Fixes #9235
Fixes #11184
2015-06-26 13:56:45 -04:00
Rene Moser
7952723530
cloudstack: fix domain name is not unique, use full path
2015-06-26 09:25:26 +02:00
Rene Moser
b9b1e294d7
cloudstack: add get_or_failback()
2015-06-26 09:25:26 +02:00
Dustin Lundquist
cf7744f2f1
IPv6 SLAAC address computation filter
...
Jinja2 filter to compute SLAAC address.
Usage:
{{ '2db8::/64' | slaac(ansible_eth0.macaddress) }}
2015-06-25 13:20:21 -07:00
Toshio Kuratomi
9911a947ed
Vendorize match_hostname code so that ansible can push it out to clients along with the code that uses it.
2015-06-25 08:17:58 -07:00
Toshio Kuratomi
00aed57295
Update submodule refs
2015-06-25 07:13:46 -07:00
Toshio Kuratomi
160e71e2cf
Some flake8 cleanup
2015-06-25 07:13:37 -07:00
James Cammarata
332ca927d9
Fix parent attribute lookup
...
Using 'value is None' instead of 'not value', in order to account
for boolean values which may be false
Fixes #11232
2015-06-24 20:57:53 -04:00
James Cammarata
256a323de5
Submodule update
2015-06-24 15:03:34 -04:00
Toshio Kuratomi
548a7288a9
Use BUFSIZE when putting file as well as fetching file.
2015-06-24 01:00:22 -07:00
Toshio Kuratomi
270be6a6f5
Fix exec_command to not use a shell
2015-06-23 22:27:45 -07:00
Toshio Kuratomi
a1a7d6c462
Fix forwarding the user-given params from fetch_url() to open_url()
2015-06-23 15:17:26 -07:00
Toshio Kuratomi
e461241d7b
Fix fetch_file() method
2015-06-23 14:45:44 -07:00
James Cammarata
d0d9be30d5
Correctly compile handler blocks for dependent roles
2015-06-23 15:48:48 -04:00
James Cammarata
0b16580567
Add in playbook_dir magic variable
2015-06-23 14:29:39 -04:00
James Cammarata
4c6adcf143
Submodule pointer update
2015-06-23 13:32:50 -04:00
Hugh Saunders
4246777759
Re-implement the ssh connection retry, originally added in 2df690
2015-06-23 12:14:14 -04:00
James Cammarata
006391eb83
Add the improved exception reporting to the minimal callback plugin
2015-06-23 12:14:14 -04:00
Toshio Kuratomi
6aae500a2c
Documentation fix
2015-06-23 08:58:26 -07:00
Toshio Kuratomi
125e6f49a1
Update submodule refs
2015-06-23 08:49:01 -07:00
James Cammarata
72d4b40a26
Don't allow empty (none) loop values
...
Fixes #8593
2015-06-23 10:42:33 -04:00
James Cammarata
24d2202591
Make sure role parsing can handle a few more types in includes/defs
2015-06-23 10:20:09 -04:00
James Cammarata
aa53212a9b
Don't use all task params for vars, just the module args
2015-06-23 10:20:09 -04:00
Toshio Kuratomi
952166f48e
Fix problem with chroot connection plugins and symlinks from within the chroot.
2015-06-22 20:08:08 -07:00
Toshio Kuratomi
61e367f549
Better error messages when the file to be transferred does not exist.
2015-06-22 20:08:08 -07:00
James Cammarata
7490044bbe
Implement play_hosts magic variable (and ansible_current_hosts)
...
Fixes #8073
2015-06-22 21:03:55 -04:00
James Cammarata
cb5f630f33
Don't post_validate vars and vars_files on Play objects
...
Fixes #11343
2015-06-22 11:23:23 -04:00
James Cammarata
ff251a0dcc
Catch runtime errors due to recursion when calculating group depth
...
Fixes #7708
2015-06-22 02:06:07 -04:00
James Cammarata
97954ff658
Minor tweak to potentially speed the linear strategy up
...
* Don't fetch vars for the task unless we're going to use them
2015-06-22 00:53:34 -04:00
Benno Joy
f17bdc4d61
Set the ansible_ssh_port variable instead of saving it internally for Host
...
Fixes #11330
2015-06-22 00:38:41 -04:00
Brian Coca
b34b606fcf
fixed and/or grouping
2015-06-21 01:51:28 -04:00
Brian Coca
68325dbfe2
fixed remote tmp creation when becoem user is not root and '~/' instead of $HOME is the default
2015-06-21 01:43:35 -04:00
Brian Coca
102de96ebf
avoid password handling when no password is supplied
2015-06-21 01:24:35 -04:00
Brian Coca
3bad03d57a
cleaned up and optimized become handling paths
2015-06-21 01:13:22 -04:00
Benno Joy
be81b650e8
fixes issue 11286 where role handlers are not run
2015-06-21 00:36:37 -04:00
James Cammarata
fc5be30c2f
Change the use of a mutable arg for a default value for locals
2015-06-19 23:04:35 -04:00
James Cammarata
0d92599d18
Make exception printing a bit smarter
2015-06-19 22:59:12 -04:00
Toshio Kuratomi
a77b58e351
Bumpt the BUFSIZE to 64k for better performance
2015-06-19 11:52:06 -07:00
Toshio Kuratomi
0777d02505
Fix problem with jail and zone connection plugins and symlinks from within the jail/zone.
2015-06-19 11:09:48 -07:00
Toshio Kuratomi
ca2f2c4ebd
Fix problem with jail and zone connection plugins and symlinks from within the jail/zone.
2015-06-19 09:41:48 -07:00
Toshio Kuratomi
f0777d9c4e
Update submodule refs
2015-06-19 09:08:57 -07:00
James Cammarata
18a9eff11f
Properly use local variables from templates including other templates
...
Fixes #6653
2015-06-18 16:10:21 -04:00
James Cammarata
c0dfa8d512
Make sure task names are templated before callbacks are sent
2015-06-18 14:27:20 -04:00
James Cammarata
98fee172ee
Fix bug in async action plugin
2015-06-18 13:49:34 -04:00
James Cammarata
270eb4274c
Make sure we safe_eval booleans too
...
Fixes #5779
2015-06-18 11:12:46 -04:00
Brian Coca
4d5a98d8d9
Merge pull request #11307 from dagwieers/patch-6
...
Change syslog (priority) level from LOG_NOTICE to LOG_INFO
2015-06-18 10:29:16 -04:00
Brian Coca
7bb2a7aa87
actually no password to handle, this should return false
2015-06-18 10:23:37 -04:00
Brian Coca
87a0ccc354
fixed typo
2015-06-18 10:12:04 -04:00
Brian Coca
aede9f08db
fixed case in which prompt was None
2015-06-18 10:05:23 -04:00
Dag Wieers
4ca4d36ae6
Change syslog (priority) level from LOG_NOTICE to LOG_INFO
...
If you look at the meaning of the different syslog levels, NOTICE means that the event may need someone to look at it. Whereas INFO is pure informational.
Since module invocations are in fact requested (deliberate) actions, they shouldn't need any additional post-processing, and therefore should not be logged as NOTICE.
This may seem like hairsplitting, but correctly categorizing system events helps weeding through the noise downhill.
According to Wikipedia: https://en.wikipedia.org/wiki/Syslog
5 Notice notice Events that are unusual but not error conditions .
6 Informational info Normal operational messages -no action required. Example an application has started, paused or ended successfully.
2015-06-18 11:00:10 +02:00
Brian Coca
7c65f3ddd7
partial become support for local connection plugin
2015-06-18 01:46:43 -04:00
Brian Coca
671118ba71
fixed become password handling with paramiko
2015-06-17 23:31:55 -04:00
Brian Coca
744ec2bbad
put hostkey locking into function (still needs fixing)
...
implemneted become handling here, cannot generalize well enough in base class
2015-06-17 23:31:54 -04:00
Brian Coca
d6672ad285
removed unused import
2015-06-17 23:31:54 -04:00
Brian Coca
5cfd0f82a0
moved away from generic function for become
2015-06-17 23:31:54 -04:00
Brian Coca
3fab516d3d
fixed detection of incorrect password
2015-06-17 23:31:54 -04:00
Brian Coca
faed1b2d05
better error reporting when doc parsing fails
2015-06-17 23:31:54 -04:00
James Cammarata
87ca475704
Exclude the all/ungrouped groups from pattern matching results
...
Fixes #5375
2015-06-17 16:25:58 -04:00
James Cammarata
90445ee67d
Add ::1 where we see 127.0.0.1, for better ipv6 support
...
Fixes #5764
2015-06-17 16:03:19 -04:00
James Cammarata
c3c398cffe
Cleaning up some task failure detection problems
...
* fixed a bug in which failures from a with_* loop were not being
caught correctly, leading to tasks continuing when they should stop
* when ignore_errors is enabled, the failure will no longer count
towards the number of failed tasks
2015-06-17 15:40:04 -04:00
Marc Abramowitz
a385744426
Add inventory file to "Unable to find" error msg
...
E.g.:
$ ansible gabriel -m ping -i ssh_config.py
ERROR! Unable to find an inventory file (ssh_config.py), specify one with -i ?
2015-06-17 11:00:13 -07:00
James Cammarata
daa319881f
Make sure registered variable message is sent before other messages
...
Avoids a race condition where previously the registered variable message
was being sent after the 'host_task_ok' message, meaning the next task
may be started before the var is registered, leading to an undefined
variable error
2015-06-17 12:42:47 -04:00
Benno Joy
0d5b7ae669
fixes 11296 where the groups does not have all the groups
2015-06-17 19:18:19 +05:30
James Cammarata
ff998b6022
Make sure the templar is using the right vars when evaluating conditionals
2015-06-17 00:10:11 -04:00
Brian Coca
d7fcd9456a
Merge pull request #11288 from kstrauser/aixfixes
...
Don't panic if AIX's uname doesn't support -W
2015-06-16 19:02:50 -04:00
Kirk Strauser
eb820837ac
Don't panic if AIX's uname doesn't support -W
...
The current code expects "uname -W" on AIX to always succeed. The AIX 5
instance I have doesn't support the -W flag and facts gathering always
crashes on it.
This skips some WPAR handling code if "uname -W" doesn't work.
2015-06-16 15:26:02 -07:00
Kirk Strauser
935da01068
Fixes for FreeBSD get_memory_facts
...
- swapinfo on FreeBSD 6 (maybe 7 too?) doesn't support the "-m" flag for
fetching amounts in megabytes. This patch fetches amounts in kilobytes
and divides by 1024 (and also returns the result as an int instead of
a string).
- When no swap is configured, swapinfo prints a header line and nothing
else:
$ swapinfo
Device 1K-blocks Used Avail Capacity
The old version unexpectedly parsed that header line and emitted
nonsense values like:
"ansible_swapfree_mb": "Avail"
"ansible_swaptotal_mb": "1K-blocks"
This version emits those items altogether.
2015-06-16 14:35:36 -07:00
Brian Coca
3b1b95b916
moved ipv6 handling to init
...
fixed become password handling
2015-06-16 15:48:10 -04:00
Brian Coca
bb7d33adbc
moved become password handlingn to base class
2015-06-16 15:48:10 -04:00
James Cammarata
4b28a51f25
Don't fail outright when a play has an empty hosts list
2015-06-16 13:56:23 -04:00
James Cammarata
30c1a2d861
Have group/host var file loading check for YAML extensions too
...
Fixes #11132
2015-06-16 11:55:56 -04:00
Brian Coca
423f1233c8
removed typo file
2015-06-16 10:49:37 -04:00
Brian Coca
c87591f76f
updated to new exec_command signature
2015-06-16 09:28:27 -04:00
Brian Coca
b76dbb01cc
generalized prereqs check
...
added vaultfile class for action and lookup plugin usage
2015-06-16 09:20:15 -04:00
Brian Coca
9116ff1c28
replaced removed pager_print for print
2015-06-16 09:19:37 -04:00
Brian Coca
98f5534d9c
adaptaed to new exec signature
...
should fix #11275
2015-06-16 09:12:42 -04:00
Brian Coca
6c884c9e39
Merge pull request #11271 from sivel/build-play-method
...
Allow AdHocCLI to be more flexible for overriding
2015-06-15 16:21:32 -04:00
Brian Coca
dcf81e3ffe
removed useless comments
2015-06-15 15:04:19 -04:00
Matt Martz
1d55e193c1
Expose the TaskQueueManager to self
2015-06-15 13:50:40 -05:00
Matt Martz
670894e2bd
Move building the play_ds into a method, that can be overridden
2015-06-15 10:35:26 -05:00
Brian Coca
8ae58f7ea3
fixed executable, correctly this time
2015-06-15 11:26:45 -04:00
Brian Coca
f576d29b6b
allow for any non string iterable in listify
2015-06-15 11:02:51 -04:00
Brian Coca
1ce1c52f6f
centralized bad password handling, fixed outputing of become method
2015-06-15 01:40:53 -04:00
Brian Coca
b89071e485
now detects incorrect password with sudo and su (at least in english)
2015-06-15 01:30:03 -04:00
Brian Coca
be8d797c23
fixed su prompt function reference
2015-06-15 01:07:02 -04:00
Brian Coca
872448e9e8
updated connection info update_vars to only update if data is not alreayd present
...
aslo added comment clarifying why we do this
2015-06-15 01:02:27 -04:00
Brian Coca
956937b110
made executable shell configurable again
2015-06-15 00:15:31 -04:00
Brian Coca
580993fef7
enabled initial support for password prompt on become
...
- moved check prompt/password functions to connection, make more senes there
- TODO: consider moving make_become to connection from connection_info
- removed executable param that was never overriden outside of connection info
2015-06-15 00:09:25 -04:00
Brian Coca
bac35ae773
set correct become mehotds for plugin
...
fixed mixup with remote password vs become_password
2015-06-14 23:49:10 -04:00
Brian Coca
ff443d4534
added note to figurte out correct var udpate on connection_info
2015-06-14 23:48:03 -04:00
Brian Coca
c3ccf26b70
added become check back to connections
2015-06-14 23:45:56 -04:00
Brian Coca
de82c953f2
added privilege escalation special var mapping
2015-06-14 23:19:49 -04:00
Brian Coca
a248678518
initial become support to ssh plugin
...
- password prompt detection and incorrect passwrod detection to connection info
- sudoable flag to avoid become on none pe'able commands
2015-06-14 23:03:23 -04:00
Brian Coca
a267f93c83
removed incorrect assumption on become user being set
2015-06-14 21:05:23 -04:00
Brian Coca
ff15f374ad
fixed new become settings, rearranged constants to find PE related vars easier
2015-06-14 20:50:38 -04:00
Brian Coca
e7abe06440
added first_found to template
2015-06-13 00:34:15 -04:00
Brian Coca
8ee4c7266c
corrected original_file code path to use actually use data from original file
2015-06-13 00:10:17 -04:00
Brian Coca
491761f880
added note to add faf deprecation
2015-06-12 23:54:09 -04:00
Brian Coca
a6ca133da8
got first_available working with copy
2015-06-12 23:54:09 -04:00
Brian Coca
aca125d03e
Merge pull request #11252 from sivel/deprecated-warning
...
Display a warning when using a deprecated module
2015-06-12 16:30:45 -04:00
Matt Martz
9ed3e2ef48
Display a warning when using a deprecated module
2015-06-12 15:21:33 -05:00
Toshio Kuratomi
d315f6e22c
Fix Etcd constructor
2015-06-12 12:59:29 -07:00
Toshio Kuratomi
77c76e632e
Switch etcd and url lookup plugins to verify ssl certificates
2015-06-12 12:54:57 -07:00
Toshio Kuratomi
4161d78a94
Split the fetch_url() function into fetch_url and open_url().
...
open_url() is suitable for use outside of a module environment. Will
let us use open_url to do SSL cert verification in other, non-module
code.
2015-06-12 12:54:56 -07:00
Brian Coca
e07dde1a3c
Merge pull request #11251 from sivel/issue/11244
...
Require passlib over crypt in password_hash for Mac OS X/Darwin. Fixes #11244
i was almost done with my patch ... but I like yours better
2015-06-12 14:58:02 -04:00
Matt Martz
a4e2d1eb62
Require passlib over crypt in password_hash for Mac OS X/Darwin. Fixes #11244
2015-06-12 13:54:43 -05:00
Brian Coca
aaab69cae9
brought back terms testing as with_ is not only way to call and we cannot guarantee terms is a list otherwise.
2015-06-11 13:45:04 -04:00
Toshio Kuratomi
c346788194
Slight optimization of how we squash loops. Add dnf to the list of modules for which we squash.
...
Fixes #11235
2015-06-11 08:55:56 -07:00
Brian Coca
aed429554d
better checks to ensure listify emits a non string iterable
2015-06-11 10:03:44 -04:00
Brian Coca
c8fde467b5
Merge pull request #11163 from sivel/ssh-private-key-fixme
...
Re-introduce ssh connection private key support
2015-06-11 09:16:27 -04:00
Brian Coca
f174682e19
facts should now not be overriten with NA option unless they are NA
...
this way we don't need a break per distro that matched already with
the python default functions
2015-06-11 00:48:40 -04:00
Brian Coca
4098e8283e
several fixes to template
...
- now obeys global undefined var setting and allows override (mostly for with_ )
- moved environment instanciation to init instead of each template call
- removed hardcoded template token matching and now use actually configured tokens, now it won't break if someone changes default configs in ansible.cfg
- made reenetrant template calls now pass the same data it got, dictionary and lists were loosing existing and new params
- moved fail_on_undeinfed parameter to template call, as it should only realky be set to false on specific templates and not globally
- added overrides, which will allow template to implement jinja2 header override features
- added filter list to overrides to disallow possibly insecure ones, TODO: check if this is still needed as facts should not be templated anymore
- TODO: actually implement jinja2 header overrides
2015-06-11 00:21:53 -04:00
Brian Coca
7291f9e965
removed cruft
...
made sure it does not fail on undefined
2015-06-11 00:13:40 -04:00
Brian Coca
f29c1c7452
respect undefined config setting
2015-06-10 23:26:01 -04:00
Brian Coca
40336b50af
removed redundant string check
...
added playbook path lookup
2015-06-10 22:58:08 -04:00
Brian Coca
7306a5397e
simplified function, always attempt to template, always check if string before return, should avoid most cases of strings being passed to lookups
2015-06-10 22:55:50 -04:00
Brian Coca
aa6e204b6e
Merge pull request #11115 from jhawkesworth/second_go_at_fixing_1404
...
Part fix for https://github.com/ansible/ansible-modules-core/issues/1404 (replaces #11086 )
2015-06-10 20:43:32 -04:00
Brian Coca
f2934eeb0a
Merge pull request #11226 from resmo/for-ansible
...
cloudstack: cleanup, remove unused parts
2015-06-10 14:44:49 -04:00
Brian Coca
d68111382d
updated with nagios doc fix
2015-06-10 13:00:29 -04:00
Brian Coca
39764ed7d8
updated submodule refs
2015-06-10 13:00:29 -04:00
Rene Moser
0b074c449b
cloudstack: methods renaming
2015-06-10 17:31:46 +02:00
Rene Moser
7b3dd55c3d
cloudstack: remove unused methods used for backward compatibility
2015-06-10 17:28:45 +02:00
Dionysis Grigoropoulos
6f11896303
ansible-pull: Add option to verify gpg signature of a commit
...
Add option '--verify-commit' to verify a GPG signature of the checked
out commit. As noted in the git module documentantion, this requires
git version >= 2.1.0
2015-06-10 17:29:04 +03:00
Brian Coca
757fb39a2e
now uses new module_loader
2015-06-09 21:35:44 -04:00
Brian Coca
24b7c353cc
readjusted limit opts, makes no sense in adhoc when you already specify selection
...
changed pull to reflect this
2015-06-09 17:35:19 -04:00
Brian Coca
845d564d89
removed debug, moved limit to runtask instead section
2015-06-09 17:32:34 -04:00
Brian Coca
fdeca37257
switched to argv[0] from __file__ as it is what we actually wanted
2015-06-09 17:29:46 -04:00
Brian Coca
5aec5e5eb0
fixed ansible pull, reorged validate function for cli to be function specific like parser
...
added missing cmd_functions with run_cmd, mostly for ansible pull
2015-06-09 17:24:43 -04:00
Brian Coca
19161dfd72
fixed typo in placeholder check
2015-06-09 11:46:08 -04:00
Rene Moser
fc3020c57a
cloudstack: prevent getting the wrong project.
...
Since we use domain and account data to filter the project, listall is not needed and can return the wrong identical named project of another account if root admin permissions are used.
Fixed projects names are not case insensitive.
2015-06-09 16:16:58 +02:00
Brian Coca
8e3213a91e
updated copyright as MPD does not deserve the blame for this one
2015-06-08 20:20:07 -04:00
Brian Coca
45f80328ae
updated submodule refs
2015-06-08 20:14:47 -04:00
Brian Coca
70b5c28694
initial implementation of the generic OS package module
2015-06-08 20:12:42 -04:00
Toshio Kuratomi
e88a9e943c
Use to_bytes to avoid tracebacks when passed a byte str instead of a unicode string
...
Fixes #11198
2015-06-08 11:15:11 -07:00
Brian Coca
97bc92d2df
minor cleanup, pushed ipv6 fixing to init
...
pushed up using host short var
made close conditional, started implementing close for controlmaster
2015-06-08 10:52:08 -04:00
Matt Martz
6a1c175991
Raise AnsibleParserError instead of AssertionError
2015-06-06 09:16:38 -05:00
Brian Coca
bdba807fd1
minor fixes to ssh error reporting
...
shoudl fix #11041
2015-06-06 00:16:35 -04:00
Edward J Kim
6a5a930c5a
Add missing import in vault.py
2015-06-05 23:04:21 -04:00
Toshio Kuratomi
65d982b186
Merge pull request #11186 from sivel/winrm-syntax-error
...
Fix syntax error in winrm
2015-06-05 15:47:21 -07:00
Brian Coca
d67c9858a9
removed become_pass as it should not be used
2015-06-05 18:43:42 -04:00
Brian Coca
46673cd620
Merge pull request #11183 from sivel/issue/11169-become-pass
...
Don't empty out become_pass. See #11169
2015-06-05 18:21:29 -04:00
Matt Martz
6f5ebb4489
Fix syntax error in winrm
2015-06-05 16:02:29 -05:00
Matt Martz
45b4ee9cfe
Don't allow setting become_pass in a play
2015-06-05 14:10:00 -05:00
Toshio Kuratomi
f9b56a5d7c
Fix raising AnsibleError
2015-06-05 11:41:23 -07:00
Matt Martz
6bc2ea1f2b
Don't empty out become_pass. See #11169
2015-06-05 12:02:35 -05:00
Brian Coca
04f4f77d91
Merge pull request #11124 from sivel/jit-connect
...
Use a decorator to perform just in time connection
2015-06-05 11:38:17 -04:00
James Cammarata
73c956366e
Correctly determine failed task state when checking results
...
Fixes #11172
2015-06-05 07:16:19 -04:00
James Cammarata
a4ebee4b16
Merge pull request #11170 from dguerri/devel
...
Fix lookup() plugin
2015-06-04 16:05:06 -04:00
James Cammarata
ee5e166563
Fixing ansible_*_interpreter use
...
Fixes ansible/ansible-modules-core#1459
2015-06-04 15:43:07 -04:00
Davide Guerri
ee06eebea3
Fix lookup() plugin
...
lookup() plugin is currently broken because _get_file_contents() now
returns a tuple: (contents, show_data).
This patch fix that issue.
2015-06-04 19:46:09 +01:00
Matt Martz
bce281014c
Decorate the ConnectionBase methods, switch to calling super from individual connection classes
2015-06-04 13:27:18 -05:00
Matt Martz
9754c67138
Use a decorator to ensure jit connection, instead of an explicit call to _connect
2015-06-04 13:14:28 -05:00
James Cammarata
f3f3fb7c49
Fixing vars_prompt
2015-06-04 13:54:51 -04:00
Matt Martz
6a97e49a06
Re-introduce ssh connection private key support
2015-06-04 08:15:25 -05:00
Toshio Kuratomi
7dd3ef7b60
Older python-six from early RHEL and ubuntu do not have add_metaclass but do have with_metaclass
2015-06-03 13:29:24 -07:00
Brian Coca
f3ccff42e5
Merge pull request #11142 from Etienne-Carriere/factor_f5
...
Add common fonctions for F5 modules (FQ Name functions)
2015-06-03 16:27:57 -04:00
Etienne CARRIERE
94fa5e8794
Simplify Fully Qualified function
2015-06-03 21:19:11 +02:00
Brian Coca
9856a8f674
added missing imports to doc module
2015-06-03 15:00:41 -04:00
Toshio Kuratomi
96836412aa
Make error messages tell which inventory script the error came from
2015-06-03 11:51:33 -07:00
Brian Coca
a87687dccb
Merge pull request #11147 from sivel/module-docs-import-mutablemapping
...
Import missing MutableMapping class for module_docs
2015-06-03 14:50:17 -04:00
Toshio Kuratomi
1c8527044b
Fix error handling when pasing output from dynamic inventory
2015-06-03 11:29:20 -07:00
Toshio Kuratomi
c3caff5eeb
Fix for six version 1.1.0 (rhel6).
2015-06-03 10:25:07 -07:00
Brian Coca
6b642afc7b
Merge pull request #11146 from sivel/issue/11136
...
Don't set a default on the _become FieldAttribute
2015-06-03 12:38:20 -04:00
Toshio Kuratomi
d8c8ca11cf
Add compatibility for old version of six (present on rhel7)
2015-06-03 08:45:36 -07:00
Matt Martz
89dceb503a
Import missing MutableMapping class
2015-06-03 10:02:27 -05:00
Matt Martz
f983557e7e
Don't set a default on the _become FieldAttribute. Fixes #11136
2015-06-03 09:54:00 -05:00
Etienne CARRIERE
5204d7ca88
Add common fonctions for F5 modules (FQ Name functions)
2015-06-03 08:20:26 +02:00
Patrick McConnell
a899f8f016
Fix for task_executor on OS X
...
I get this exception during the setup task:
AttributeError: 'ConnectionInformation' object has no attribute 'remote_pass'
I believe it is supposed to be looking at the password attribute. Either that
or we should create a remote_pass attribute in ConnectionInformation.
2015-06-03 07:26:18 +02:00
Brian Coca
3e2e81d896
missing path in import path for making paths
2015-06-02 23:42:00 -04:00
Brian Coca
65b82f69e4
avoid failing when mode is none
2015-06-02 23:39:57 -04:00
Brian Coca
5622fc23bc
fixed frozen set, missing iterable
2015-06-02 23:35:15 -04:00
Brian Coca
48c0d6388f
moved RAW var to class and as a frozenset
2015-06-02 23:35:15 -04:00
Matt Martz
1b48111b12
If remote_addr isn't set, set to ipv4_address
2015-06-02 14:56:32 -05:00
James Cammarata
f57eaece88
Merge pull request #11134 from sivel/import-display-cli-base
...
Add missing import in ansible.cli
2015-06-02 14:11:32 -05:00
Matt Martz
6519118106
Add missing import in ansible.cli
2015-06-02 14:11:16 -05:00
James Cammarata
7a617e7b93
Merge pull request #11131 from sivel/issue/11130
...
Don't override ansible_ssh_host with inventory_hostname
2015-06-02 14:03:25 -05:00
James Cammarata
c4ae51089d
Merge pull request #11129 from sivel/fix-scp-if-ssh
...
Fix command building for scp if ssh
2015-06-02 14:02:51 -05:00
Matt Martz
697a1a4061
Don't override ansible_ssh_host with inventory_hostname
2015-06-02 14:01:11 -05:00
Matt Martz
71014ab01e
Fix command building for scp if ssh
2015-06-02 13:35:53 -05:00
Brian Coca
093b5b6051
Merge pull request #11127 from bcoca/makedirs_safe
...
created makedirs_safe function for use in cases of multiprocess
2015-06-02 13:36:39 -04:00
Brian Coca
e0ef217f97
Revert "Adding raw module to list of modules allowing raw params"
...
This reverts commit bc041ffea0
.
same fix x2 does not fix it 'more'
2015-06-02 13:33:33 -04:00
Brian Coca
ba02e5e3bf
minor adjustments as per code review
2015-06-02 13:01:59 -04:00
Brian Coca
2590df6df1
created makedirs_safe function for use in cases of multiprocess
...
should fix #11126 and most race conditions
2015-06-02 11:41:30 -04:00
Brian Coca
47be5b4166
added missing ansibleoptionserror import and moved args check in playbook to after parser exists to allow for creating usage info
2015-06-02 11:03:17 -04:00
James Cammarata
d1b4371287
Correctly evaluate changed/failed for tasks using loops
2015-06-02 09:42:08 -05:00
Brian Coca
860a96cf70
Merge pull request #11097 from resmo/for-ansible
...
cloudstack: updates and v1 sync
2015-06-02 10:25:45 -04:00
James Cammarata
bc041ffea0
Adding raw module to list of modules allowing raw params
...
Fixes #11119
2015-06-02 08:42:24 -05:00
Brian Coca
e251e70178
added raw to 'raw' modules
2015-06-02 08:54:37 -04:00
Rene Moser
caf3cf6930
cloudstack: add timeout to utils
2015-06-02 14:51:25 +02:00
Rene Moser
fc807e29c8
cloudstack: add api_timeout to doc fragments
2015-06-02 14:51:25 +02:00
Rene Moser
7bb9cd3766
cloudstack: minor cleanup in doc fragments
2015-06-02 14:51:25 +02:00
James Cammarata
620fad9f8d
Fixing an oops in inventory/__init__.py where the slots are incorrect
2015-06-01 20:02:15 -05:00
James Cammarata
7f1b64d934
Submodule pointer update for core to the merged v2 branch
2015-06-01 19:46:29 -05:00
James Cammarata
e547e1f9ba
Merge branch 'devel' into devel_switch_v2
2015-06-01 16:53:15 -05:00
James Cammarata
fe41f109a9
Merge branch 'v2_final' into devel_switch_v2
2015-06-01 16:42:59 -05:00
James Cammarata
4bc7703db3
Fixing some small bugs related to integration tests (v2)
2015-06-01 16:42:10 -05:00
Jon Hawkesworth
30b92a6f4c
Get-FileChecksum allways returns a string now,
...
and the test_win_copy integration tests that depend on the checksum
have been updated in this change too.
2015-06-01 21:53:49 +01:00
Brian Coca
9a90ca5a36
Merge pull request #11062 from Etienne-Carriere/factor_f5
...
Factor primitives for F5 modules
2015-06-01 10:34:11 -04:00
sysadmin75
816b20af0b
Fixes #11046
2015-06-01 10:24:20 -04:00
sysadmin75
908d6c0ef2
Fixes #11046
2015-05-31 20:05:02 -04:00
Toshio Kuratomi
5954892457
Update submodule refs
2015-05-29 19:00:16 -07:00
Brian Coca
529726d0ba
fixed mistaken module update in prev commit
2015-05-29 16:22:55 -04:00
Brian Coca
7e020d21de
correctly identify ubuntu now in all cases
...
made NA the last resort
2015-05-29 16:19:09 -04:00
Brian Coca
a8c290cc3b
fixed ubuntu facts for all versions
...
made sure NA is option of last resort
2015-05-29 16:14:30 -04:00
Monty Taylor
2046d76310
Add defaults and a link to os-client-config docs
2015-05-29 13:10:13 -07:00
Monty Taylor
b659621575
Remove unneeded required_one_of for openstack
...
We're being too strict - there is a third possibility, which is that a
user will have defined the OS_* environment variables and expect them to
pass through.
2015-05-29 13:09:45 -07:00
Toshio Kuratomi
2924c90a5d
Merge pull request #10977 from emonty/fix-envvars
...
Fix envvars support in openstack modules
2015-05-29 13:05:03 -07:00
Toshio Kuratomi
dee2d53b3e
Update v2 submodule refs
2015-05-29 08:51:50 -07:00
Jon Hawkesworth
12691ce109
Add -Compress to ConvertTo-Json calls in common powershell code
2015-05-29 10:40:24 -04:00
Jon Hawkesworth
9371c38af9
Add -Compress to ConvertTo-Json calls in common powershell code
2015-05-29 14:50:08 +01:00
James Cammarata
7985d2a8be
Moving included file stuff to a proper dedicated class and file (v2)
2015-05-28 23:58:38 -05:00
James Cammarata
fe014148d9
Removing errant debug print
2015-05-28 20:29:16 -05:00
Brian Coca
e7a096c4c5
cowsay is back!
2015-05-28 20:01:39 -04:00
Stefan Midjich
e5190327f2
this fixes ansible on openbsd and freebsd systems. only tested on openbsd.
2015-05-28 19:17:31 -04:00
Toshio Kuratomi
5d213cab23
Update extras submodule ref for doc fix
2015-05-28 16:00:58 -07:00
Toshio Kuratomi
5ffc1183dd
WHoops, that was the core module stable branch
2015-05-28 15:37:12 -07:00
Toshio Kuratomi
2f4ad2714f
Update core module ref
2015-05-28 15:36:35 -07:00
Toshio Kuratomi
4d8427538d
Update submodule refs
2015-05-28 15:10:06 -07:00
James Cammarata
60bea844b3
Merge branch 'v2_final' into devel_switch_v2
2015-05-28 15:27:09 -05:00
James Cammarata
2bad888f28
Merge branch 'v2_final' into devel_switch_v2
...
Conflicts:
lib/ansible/inventory/__init__.py
lib/ansible/modules/core
lib/ansible/utils/__init__.py
lib/ansible/utils/module_docs.py
2015-05-28 15:26:03 -05:00
Toshio Kuratomi
afc19894e1
Make fetch_url check the server's certificate on https connections
2015-05-28 13:20:40 -07:00
Toshio Kuratomi
1ccf2a4685
Make fetch_url check the server's certificate on https connections
2015-05-28 12:35:37 -07:00
alberto
37ae5aab31
Capture only IOError when reading shebang from inventory file, to avoid ignoring other possible exceptions like timeouts from a task
2015-05-28 12:19:32 +02:00
James Cammarata
e59d4f3b51
More module_utils/basic.py unit tests for v2
2015-05-28 01:26:04 -05:00
Toshio Kuratomi
388827a636
Update submodule ref
2015-05-27 20:28:29 -07:00
Yannig Perre
c2968d6d84
New lookup plugin : ini. Can handle ini file and java properties file.
...
Can also read a list of value in a section using regexp.
2015-05-27 21:51:20 +02:00
Toshio Kuratomi
b72a912562
Update submodule refs
2015-05-27 06:50:46 -07:00
James Cammarata
339a02c384
Started reworking module_utils/basic unit tests (v2)
2015-05-27 03:21:15 -05:00
Toshio Kuratomi
ea4421d10e
Update submodule refs
2015-05-26 15:33:47 -07:00
Toshio Kuratomi
f1ab1c48f4
Update submodule refs for v2
2015-05-26 12:38:26 -07:00
Brian Coca
3865c5051b
Merge pull request #11058 from srvg/bug/11017
...
limit extensions for files in group/host_vars dir
2015-05-26 15:31:12 -04:00
Toshio Kuratomi
d793ed360b
Fix syntaxerror in the required_if arg spec check
2015-05-26 11:30:06 -07:00
Toshio Kuratomi
0f23d8a503
Fix syntaxerror in the required_if arg spec check
2015-05-26 11:29:35 -07:00
Brian Coca
7c6ebcab6d
Merge pull request #11073 from msabramo/include_more_info_in_errors
...
Include more info when a task fails
2015-05-26 14:26:50 -04:00
Monty Taylor
31609e1b16
Add required_if to AnsibleModule
...
There is a common pattern in modules where some parameters are required
only if another parameter is present AND set to a particular value. For
instance, if a cloud server state is "present" it's important to
indicate the image to be used, but if it's "absent", the image that was
used to launch it is not necessary. Provide a check that takes as an
input a list of 3-element tuples containing parameter to depend on, the
value it should be set to, and a list of parameters which are required
if the required parameter is set to the required value.
2015-05-26 11:21:38 -07:00
Toshio Kuratomi
c6b286424f
Merge pull request #9423 from emonty/features/required-if
...
Add required_if to AnsibleModule
2015-05-26 11:20:40 -07:00
Marc Abramowitz
d0a154c446
Include more info when a task fails
...
Adds "playbook", "role", and "task" fields to the output when a task fails.
This makes it easier to pinpoint where the problem is, especially
when you have a lot of roles and playbooks.
e.g.:
failed: [vagrant] => {..."playbook": "/Users/marca/dev/ansible/vagrant.yml",
..."role": "pythonapp",
..."task": "pip install -r /opt/src/{{ sm_app_role }}/requirements.txt"...}
2015-05-26 09:25:12 -07:00
Stefan Midjich
540c23dfce
this fixes ansible on openbsd and freebsd systems. only tested on openbsd.
2015-05-26 12:04:35 -04:00
Brian Coca
16c70dd7d4
added equivalent of #9636 to v2
2015-05-26 11:55:52 -04:00
Brian Coca
6000db7e5d
Merge pull request #9636 from Batmat/fix-message-i18n-parsing-error
...
Setting LC_MESSAGES: prevent unparseable messages (fixes issue #9635 )
2015-05-26 11:49:56 -04:00