1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

197 commits

Author SHA1 Message Date
Jan Gaßner
eb2369a934
yarn: Fix handling of empty outdated & scoped packages (#474)
* Fixed index out of range in yarn module when no packages are outdated

* Fixed handling of yarn dependencies when scoped modules are installed

* Added changelog fragment for yarn module fixes

* Adhere changelogs/fragments/474-yarn_fix-outdated-fix-list.yml to current standards

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Added scoped package to yarn integration test

Co-authored-by: Jan Gaßner <jan.gassner@plusserver.com>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2020-07-23 10:19:32 +03:00
Martin Migasiewicz
80cd8329e0
launchd: new module to control services on macOS hosts (#305) 2020-07-22 16:54:58 +03:00
Orion Poplawski
669b7bf090
Add cobbler inventory plugin (#627)
* Add cobbler inventory plugin

* Add elements, caps

* Use fail_json if we cannot import xmlrpc_client

* [cobbler] Raise AnsibleError for errors

* [plugins/inventory/cobbler] Add cache_fallback option

* [inventory/cobbler] Use != for comparison

* [inventory/cobbler] Add very basic unit tests

* Update plugins/inventory/cobbler.py

Use full name

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-07-21 23:37:01 +03:00
Andrew Klychkov
c207b7298c
osx_defaults: fix handling negative integers (#676)
* osx_defaults: fix handling negative integers

* add changelog fragment
2020-07-21 16:12:21 +02:00
Felix Fontein
7ac467a359
Restore removed google modules (#675)
* Revert "Remove entries of modules that no longer exist." partially.

This reverts commit c1e1b37da4.

* Revert "The _info module is in google.cloud."

This reverts commit 26f5c84924.

* Revert "Remove modules that were moved to the google.cloud collection according to ansible/ansible's ansible_builtin_runtime.yml."

This reverts commit a1442ccc35.

* Fix FQCNs in examples and module references.

* Add changelog fragment.

* Update ignore.txt.

* Remove bad lines.
2020-07-21 07:45:32 +01:00
Minh Ha
52cce0b7af
removes advertise_addr from required parameters when state is "join" (#646)
* removes advertise_addr from required parameters when state is "join"

addressing this issue: https://github.com/ansible-collections/community.general/issues/439

* adjusts test

* adds changelog
2020-07-20 18:14:16 +02:00
Andrew Klychkov
09d68678ee
postgresql_query: add search_path parameter (#653)
* postgresql_query: add search_path parameter

* add CI tests

* add ref to seealso

* add changelog fragment

* fix test syntax

* fix test syntax

* fix

* fix

* fix CI syntax

* cosmetic change

* improve CI test

* move CI tests to the right place

* improve CI
2020-07-20 10:08:02 +03:00
Felix Fontein
ee6baa30cf
Prevent CI failure with older pip versions. (#670) 2020-07-19 14:50:40 +02:00
John Westcott IV
a86195623b
Adding ODBC module (#606)
* Adding ODBC module

* Adding symink and fixing docs and argspec

* Another sanity issue

* Hopefully last fix for elements

* Making changes suggested by felixfontein

* Making changes suggested by Andersson007

* Removing defaults and added info in description

* Fixing line too long

* More cleanup suggested by felixfontein

* Changing module call
2020-07-17 07:39:37 +03:00
Adam Miller
64c4548b7f
migrate firewalld to ansible.posix (#623)
* migrate firewalld to ansible.posix

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix removal_version for runtime.yml

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog fragment

Signed-off-by: Adam Miller <admiller@redhat.com>

* Update meta/runtime.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/firewalld_migration.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* add module_util routing entry

Signed-off-by: Adam Miller <admiller@redhat.com>

* Update meta/runtime.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-07-16 22:21:22 +02:00
VMax
a0c8a3034a
modules: fix names with hyphens (#656) (#659)
* modules: fix names with hyphens (#656)

* modules: fix names with hyphens (#656)

* Fix param name for postgresql_schema

* Add double quotes for schema name

* Add delete created DB objects

* Fix module code

* Set correct test tasks order

Co-authored-by: Maxim Voskresenskiy <maxim.voskresenskiy@uptick.com>
2020-07-16 17:44:19 +03:00
Andrew Klychkov
2c3efea14b
Test of using FQCN for some builtin plugins (#660) 2020-07-16 12:24:04 +03:00
Andrew Klychkov
c055340ecb
modules: fix examples to use FQCN for builtin modules (#648)
* modules: fix examples to use FQCN for builtin modules

* fix

* fix

* fix

* fix

* fix

* fix

* fix
2020-07-14 18:28:08 +03:00
Abhijeet Kasurde
c034e8c04f
gitlab_project: add support for merge_method on projects (#636)
Migrated from ansible/ansible#66813

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-07-14 20:17:46 +05:30
Adam C. Migus
a424ee71e3
Add Thycotic DevOps Secrets Vault lookup plugin (#90)
* Add the Thycotic DevOps Secrets Vault lookup plugin.

* Update plugins/lookup/dsv.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update plugins/lookup/dsv.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update plugins/lookup/dsv.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix import error check per code review.

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add a unittest for plugins/lookup/dsv.py

* Add copyrights.

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Fixed formatting bug in test_dsv.py

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-07-13 05:45:07 +00:00
Adam C. Migus
4c6e2f2a40
Add the Thycotic Secret Server lookup plugin. (#91)
* Add the Thycotic Secret Server lookup plugin.

* Update plugins/lookup/tss.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix import error check per code review.

* Apply suggestions from code review

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Trivial changes based on suggestions from code review.

* Add a unittest for plugins/lookup/tss.py

* Add copyrights.

* Fixed formatting bug in test_tss.py

* Fix formatting bugs in tss.py and test_tss.py

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-07-13 07:37:20 +02:00
Amin Vakil
b31de003bd
Reduce ignored files sanity tests (#639)
* Remove all files ignores to see errors

* Fix

* Revert archive.py as its change should be discussed in another PR

* Ignore archive.py

* Revert xml

* Fix
2020-07-12 00:22:15 +02:00
ekaulberg
7f76d8aff4
Remove old infini modules to prepare for collection implementation (#607)
* Removed old infini modules, added redirects to new collection.

* Fix key names.

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-07-10 21:08:09 +02:00
Ben Mildren
f420e8f02e
Migrating MySQL to community.mysql (#633)
* Migrating MySQL to community.mysql

* Added PR to changelog

* Removed missed tests

* Removed missed changelog fragments

* Update meta/runtime.yml

Co-authored-by: Ben Mildren <bmildren@digitalocean.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
2020-07-10 18:54:04 +02:00
Felix Fontein
c1b5b51366
Remove DigitalOcean modules (moved to community.digitalocean) (#622)
* Remove DigitalOcean modules.

* Remove inventory scripts.
2020-07-07 16:41:16 +02:00
Ben Mildren
25aec0d712
migrating ProxySQL to community.proxysql (#624)
* migrating ProxySQL to community.proxysql

* Added PR to changelog

* Removed symlinks, fixed grammer in changelog fragment

* Fixed typo

* Added redirects to meta/runtime.yml

* Added docs_fragment redirect to meta/runtime.yml

Co-authored-by: Ben Mildren <bmildren@digitalocean.com>
2020-07-07 13:38:54 +01:00
Andrew Klychkov
17f905eb35
postgres modules: fix CI timeouts (#628) 2020-07-07 11:33:35 +03:00
Andrew Klychkov
5e23f01a76
mysql_user: fix overriding user passowrd to the same (#609)
* mysql_user: fix overriding user passowrd to the same

* add changelog
2020-07-06 15:16:48 +03:00
Felix Fontein
a1c03a3cfe master -> main 2020-07-06 08:53:01 +02:00
Felix Fontein
65a8dbad8d Fix coverage parameters for shippable script. 2020-07-03 20:15:31 +02:00
Felix Fontein
786f082976
Run tests with Ansible 2.9 as well (#296)
* Run some tests with Ansible 2.9. No need to run extra tests multiple times.

* Update ignore-2.9.txt.

* Adjust README.

* Add changelog fragment.
2020-07-02 13:40:16 +02:00
Andrew Klychkov
3cde447eb8
postgresql CI tests: fix timeouts (#598)
* postgresql CI tests: fix timeouts

* fix

ci_complete
2020-07-02 09:01:20 +02:00
Andrew Klychkov
a5f11b085b
postgresql_idx: add CI tests (#603) 2020-06-30 17:11:43 +03:00
anshulbehl
cca84abeb5
conjur_variable: redirecting to correct collection (#570)
* - Redirecting to correct collection
- Removing the plugin and adding changelog and deprecation

* Making suggested changes

* Earlier version on leftovers

* Update changelogs/fragments/cyberarkconjur-removal.yml

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-06-30 07:36:08 +02:00
Joey Zhang
d2ee51253d
nmcli: add idempotent support for any kinds of connections (#562)
* nmcli: add idemptent support for any kinds of connections

Fixes #481: nmcli reports changed status even if nothing needs to change
- Implement show_connection() to retrieve connection profile from command line
- Parse integer enumeration values in show_connection()
- Convert 'bond.options' to alias shortcuts
- Modify connection only if changes are detected
- Support generic alias in during the property comparison

* nmcli: add idemptent support for any kinds of connections

Add mock object for modification cases when connection state changes

* nmcli: add idempotent support for any kinds of connections

- Add more test cases to check idempotent for each type of connections
- Verify 'changed' and 'failed' in the result of each test
- Append prefixlen for 'ip4' values in test data
- Fix the incorrect 'return_value' of execute_command() in previous mockers
- Ignore the empty string in _compare_conn_params()
- Fix the property key mapping of 'bridge-port.hairpin-mode' for bridge-slave
- Add 'override_options' in the result output for playboot debug

* nmcli: add idempotent support for any kinds of connections

Fix pep8 issues in test_nmcli.py: Comparison to False should be 'not expr'

* nmcli: add idempotent support for any kinds of connections

Support setting 'ipv4.method' or 'ipv6.method' via nmcli if the configuration method changes

* nmcli: add idempotent support for any kinds of connections

Simplify the if statements in show_connection() according to vlours's advice

* nmcli: add idempotent support for any kinds of connections

Fix the list argument comparison method with multiple values.

* nmcli: add idempotent support for any kinds of connections

Use ansible --diff option output to show detailed changes instead of a private return value.

* nmcli: add idempotent support for any kinds of connections

Add changelog fragment for bugfix.
2020-06-30 05:43:39 +02:00
Amin Vakil
72ca27a6ae
Reduce ignored packaging sanity tests (#568)
* Remove all packaging sanity tests to see errors

* fix

* Fix

* Minor fixes

* Fix

* Fix redhat

* Fix redhat_subscription

* Fix redhat_subscription

* Fix redhat_subscription

* Ignore redhat_subscription return-syntax-error

* Remove more ignored sanity tests

* Remove force from xbps argument_spec as it doesn't do anything(?)

* Remove unnecessary sanity test for xbps

* Fix suggestions made by felixfontein

* Better changelog description, fix portage wrong default values

* Fix

* Fix

* Remove root default from urpmi doc

* Fix wrong type of default for booleans

* Add default value as suggested by felixfontein

* Fix changelog
2020-06-26 15:17:11 +02:00
Jon Dufresne
16cd8e49d2
Fix typo in fatpak tests: state=preset → state=present (#585) 2020-06-26 08:31:53 +02:00
Abhijeet Kasurde
832dd55144
sanity: Add future boilerplate (#573)
* sanity: Add future boilerplate

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* Module Utils

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* Scripts

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* sanity: Add future boilerplate

* Tests

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* CI failure

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-06-24 21:50:36 +02:00
Felix Fontein
5269213907
Deprecate logicmonitor and logicmonitor_facts (#541)
* Deprecate logicmonitor and logicmonitor_facts.

* Remove modules instead of deprecating them.

* Remove bad entry from BOTMETA.

* Remove ignore.txt entries.
2020-06-23 15:55:59 +02:00
Robert Osowiecki
ced14746a8
parted: Allow passing negative numbers to specify partition boundary relative to disk end (#129)
* Allow passing negative numbers to specify partition boundary relative to disk end
Fixes: https://github.com/ansible/ansible/issues/43369

* parted: unit test case, create partition with part_start: -1GiB

* fs_type parameter is not really optional for negative part_start parameter

* Revert "fs_type parameter is not really optional for negative part_start parameter"

This reverts commit 800b1cb00b.

Instead: added notes and documentation about netagive part_start and fs_type.

* include fs_type in negative part_start example
2020-06-23 14:02:35 +02:00
Felix Fontein
a6c225e4a0
Fix docker_container tests (#549)
* Stop using ansible.netcommon.next_nth_usable.

It requires netaddr to be installed before running the playbook, which isn't the case in CI.
This undoes cf61474c3b.

* Use own filter to avoid needing netaddr installed.
2020-06-21 16:28:58 +02:00
Adam Miller
42c5cdf01a
firewalld: add zone target set (#526)
* firewalld: add zone target set

Fixes https://github.com/ansible/ansible/issues/49232

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix sanity tests, add example of zone target setting

Signed-off-by: Adam Miller <admiller@redhat.com>

* test different zone/target combination as we're not hitting default settings

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix enabled values for zone operations

Signed-off-by: Adam Miller <admiller@redhat.com>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-06-19 23:04:17 +02:00
Adam Miller
42a43586f1
fix and enable firewalld tests (#499)
* fix and enable firewalld tests

Signed-off-by: Adam Miller <admiller@redhat.com>

* skip docker for firewalld tests

Signed-off-by: Adam Miller <admiller@redhat.com>
2020-06-19 22:36:03 +02:00
Abhijeet Kasurde
67ae100cee
hashi_vault: Handle equal sign in secret name value (#537)
Fixes: ansible/ansible#55658

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-06-19 14:10:11 +02:00
Andrew Klychkov
498ace1210
CI tests: fix setup_postgresql_db (#533)
* CI tests: fix setup_postgresql_db

* fix

* fix

* fix

* fix

* fix

* fix
2020-06-18 12:11:40 +03:00
Andrew Klychkov
1d1f7ec582
mysql_db: add config_overrides_defaults parameter (#513)
* mysql_db: add config_overrides_defaults parameter

* Add CI tests

* Add changelog fragment

* add more tests

* improve tests

* fix CI

* fix feature
2020-06-18 11:24:23 +03:00
Jose Angel Munoz
54014529bd
Return correct values when running yarn in check mode (#153)
* Fixes Check Mode

* Adds parenthesis

* Adds changelog and tests
2020-06-17 17:39:24 +02:00
Felix Fontein
9f9d160ad1
[WIP] Prepare for stable-2.10 branching of ansible-base (#524)
* Allow to use multiple different ansible versions in CI.

* Fix script.
2020-06-16 22:51:38 +01:00
Felix Fontein
7ef43c60df
Prepare for devel version bump. (#523) 2020-06-16 21:20:52 +02:00
René Moser
e5bb9dab9d
cloudscale migrated to cloudscale_ch.cloud (#517) 2020-06-16 17:12:47 +02:00
Felix Fontein
1c97afd40a
Remove sops lookup (moved to https://github.com/ansible-collections/community.sops). (#518) 2020-06-16 14:24:31 +02:00
Felix Fontein
b54ddaa28c
Clean up deprecations (#504)
* Adjust deprecation versions.

* Remove redirects that are already made in ansible/ansible's ansible_builtin_runtime.yml

* Remove modules that were moved to the google.cloud collection according to ansible/ansible's ansible_builtin_runtime.yml.

* The _info module is in google.cloud.

* The gcp doc_fragment is a copy of the one in google.cloud and is only used by one lookup. Mark as deprecated/internal.

* Remove entries of modules that no longer exist.

* Update ignore.txt.

* Try to fix test.

* Remove debug output.
2020-06-16 13:15:19 +02:00
Trevor Highfill
c718a610cf
Added DIY callback plugin (#432)
* Added diy callback plugin

* Update plugins/callback/diy.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/callback/diy.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/callback/diy.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Add diy callback plugin integration tests

* Update tests\integration\targets\callback_diy\tasks\main.yml

* Update tests\integration\targets\callback_diy\tasks\main.yml

* Add tests/integration/targets/callback_diy/handlers/main.yml

* Update tests/integration/targets/callback_diy/tasks/main.yml

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

* Update plugins/callback/diy.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/callback/diy.py

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2020-06-15 21:06:52 +03:00
Abhijeet Kasurde
2aaab59d04
nmcli: Typecast parameter values to string as required (#477) 2020-06-15 17:02:55 +05:30
Felix Fontein
94ee25cace
Since ansible-test now includes the changelog test, it is no longer needed separately. (#510) 2020-06-14 17:06:36 +02:00