ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity
43519 commits 10 branches 167 tags 272 MiB
Commit graph

26066 commits

Author SHA1 Message Date
Sloane Hertel
9687879840
Fix inventory cache interface (#50446) 
* Replace InventoryFileCacheModule with a better developer-interface

Use new interface for inventory plugins with backwards compatibility

Auto-update the backing cache-plugin if the cache has changed after parsing the inventory plugin

* Update CacheModules to use the config system and add a deprecation warning if they are being imported directly rather than using cache_loader

* Fix foreman inventory caching

* Add tests

* Add integration test to check that fact caching works normally with cache plugins using ansible.constants and inventory caching provides a helpful error for non-compatible cache plugins

* Add some developer documentation for inventory and cache plugins

* Add user documentation for inventory caching

* Add deprecation docs

* Apply suggestions from docs review

* Add changelog
 2019-03-06 12:12:35 -06:00
Abhijeet Kasurde
831f068f98 tower_credential: Add parameter vault_id (#53400) 
vault_id allows user to specify vault identifier as per Tower UI.

Fixes: #45644

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-03-06 12:44:14 -05:00
Brian Coca
b94bfed1a6
scan_packages: made adding package managers easier (#49079) 
* made adding package managers easier

  added portage support

* moar pkg mgrs and moar info

 - added 'pkg' pkg manager (freebsd)
 - added pip
 - more apt info

* updated clgo

* Updates from feedback

Co-Authored-By: bcoca <bcoca@users.noreply.github.com>

* incorporated more feedback and added docstrings

* moar from feedback

  - made manager list dynamic and names based on class
  - better not found msg
  - made abstract metaclass again
  - test is now init exception
  - module to global
  - better dedupe comments

* more targetted errors/warnings

* added strategy, reordered to conserve priority

* rpm > apt

* move break to top

* fix trate

* piping it

* lines and meta

* refactored common functions

 - moved pip into it's own module
 - cleaned up base clases
 - ensure 'lower' match in package_facts

* missing license

* avoid facts

* update clog

* addressed feedback

* fix clog

* cleanup

* upd

* removed pip as that was removed

* renamed cpan

* added a single line since 2 lines are needed to be

readabnle instead of just 1 line, it is a huge problem otherwise

* fix internal ref

* not intended in this round

* updated as per fb
 2019-03-06 12:29:51 -05:00
Nathaniel Case
3fe2013b3f
Change handle_httperror in httpapi plugins (#53391) 
* Change return of handle_httperror

* Fix restconf for handle_httperror changes
 2019-03-06 12:13:58 -05:00
Chaitanya Deshpande
662dd2c1de Avi: Fixed import issues (#52661) 2019-03-06 12:09:49 -05:00
Anil Kumar Muraleedharan
77565554c8 To fix bug on switch port issue of L3 interfaces. (#53267) 
* To fix bug on switch port issue of L3 interfaces.

* Adding mock return value for is_switch_port method
 2019-03-06 12:08:53 -05:00
Brian Coca
d241794daa
Add toggle to control invalid character substitution in group names (#52748) 
* make add_group return proper name
* ensure central transform/check
* added 'silent' option to avoid spamming current users
  those already using the plugins were used to the transformations, so no need to alert them
* centralized valid var names
* dont display dupes
* comment on regex
* added regex tests
  ini and script will now warn about deprecation
* more complete errormsg
 2019-03-06 11:49:40 -05:00
Chris Archibald
9c54649449 Bug Fix: na_elementsw_cluster_pair.py check if clusters are allready paired (#52379) 
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a37b42886aebb4d2b2ab27c91c96d97858a.

* bug fix

* bug fixes

* bug fix
 2019-03-06 16:20:00 +00:00
Alan Rominger
e21ca4a00d Add option for tower inventory to give general metadata (#52747) 2019-03-06 15:32:05 +00:00
René Moser
4ac317239c
cloudscale_server: fix missing param use_private_network (#53381) 2019-03-06 16:22:15 +01:00
Dag Wieers
c44e83ee13 rhevm: Fix validate-modules issues (#52436) 
This PR includes:

* Adding parameter types
* Fix validate-modules issue
* Improve parameter types and resulting changes

This PR needs to be verified and tested by maintainer(s).
 2019-03-06 14:05:14 +00:00
Andrea Tartaglia
5c6b16edc3 Fix ec2_instance eventual consistency when wait: false (#51885) 
* Do not return 'instances' when wait is false

* Added integration tests for wait: false

* Added changelog fragment

* Fix test suite to work with ec2_instance

* Additional permissions
* Enforce boto3 version
* Fix broken tests
* Improve error messages

* fix linter issues
 2019-03-06 22:46:37 +10:00
Xander Madsen
d0db99e023 Fix redfish_facts GetPsuInventory command not returning correct output (#52675) 
* Move GetPsuInventory from Systems category to Chassis category

* Change get_psu_inventory to search through Chassis instead of Systems and PoweredBy for PowerSupplies

* Remove GetPsuInventory from Examples

* remove trailing whitespace

* Change boolean check from '!= None' to 'is not None'

* Don't include 'Absent' PSUs in get_psu_inventory()

* Add check to see if Power key is in Chassis before proceeding

* remove trailing whitespace

* Add continue step for when powersupply property is not found, and check if resulting entries is empty, returning message if nothing was found rather than an empty list
 2019-03-06 12:43:23 +00:00
Fabian von Feilitzsch
65424dd614 Allow user to specify a custom condition when waiting (#52185) 2019-03-06 12:41:17 +00:00
Tad Merchant
b979b26a74 Add launch type to ecs task (#49081) 
* adds fargate launch_type to ecs_task module

* White space changes

* fix documentation for running ecs task on fargate

* remove extraneous example from ecs_task

* White space changes

* Adds changelog fragment

* Pluralize minor_changes in changelog fragment

* Add Stop and Start task permissions
 2019-03-06 22:40:32 +10:00
Xander Madsen
539cab89e1 Fix get_disk_inventory() not using Storage resource and add more prop… (#52939) 
* Fix get_disk_inventory() not using Storage resource and add more properties to output

* don't include null entries

* Add the SimpleStorage resources as well

* Fix misspelling of disk_result
 2019-03-06 12:39:06 +00:00
Chris Keller
d32df92d3e Adding ovirt_event_facts Module (#51760) (#52984) 
* Adding ovirt_event_facts Module (#51760)

* Cleaning up Copyright, Documentation and Examples section per Akasurde comments in #52982
 2019-03-06 12:36:52 +00:00
Abhijeet Kasurde
5b0eae75fa tower: Handle AuthError (#53377) 
Handle AuthError raised when user provides incorrect password
for Tower admin user.

Fixes: #50535

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-03-06 06:18:43 -05:00
Andrey Klychkov
e246e74843 New module postgresql_ping: Checks remote PostgreSQL server availability. (#51477) 
* New module postgresql_ping: simple module to check remote PostgreSQL server availability.

* New module postgresql_ping: simple module to check remote PostgreSQL server availability, doc fixes

* postgresql_ping: added integration tests

* New module postgresql_ping: misc changes

* New module postgresql_ping: change return suit

* New module postgresql_ping: tests reformatting, return value

* Various cosmetic/documentation fixes

* A few more fixes

* And even more cleanups

* Fix PEP8 issue
 2019-03-06 11:01:13 +00:00
Felix Fontein
61abbfc269 docker_swarm_service: rename return variable to swarm_service (#53229) 
* Rename return variable to swarm_service.

* Add changelog.

* Add that old name will stay in Ansible 2.7.x.
 2019-03-06 10:27:11 +00:00
Abhijeet Kasurde
70f6cdb814
VMware: add cluster name in facts (#53056) 
Fixes: #45280

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-03-06 10:15:26 +05:30
Yuwei Zhou
5fa3d307e8 Fixes #42407 add inbound_nat_rules for loadbalancer (#52966) 2019-03-06 07:15:52 +08:00
Brian Coca
7a0b4a5117
Allow user to control output of verbose messages (#52948) 
to stdout (default) or stderr
 2019-03-05 16:08:15 -05:00
Brian Coca
1160e506e9
write to file option for ansible-inventory (#53183) 
* write to file option for ansible-inventory

* changed comment, ensure text mode
 2019-03-05 16:07:53 -05:00
Brian Coca
949ddb48c0
make debconf compare apples to apples (booleans) (#53331) 
hope to fix #25481
 2019-03-05 16:03:54 -05:00
Wojciech Sciesinski
8136e2e4fe Extend win_psmodule - the second attempt, the previous was #46516 (#50621) 
* Extend win_psmodule - rebased at 2019-01-07

* Change a way how defined parameters are added to the list

* Correct registering a repository

* Change way how tests for the check_mode: true are run

* Post-review updates

* Post-review updates -2

* Post-review updates -3

* Switch to PowerShell loop

* Minor updates

* Remove variants of an exception handling

* Change error handling
 2019-03-06 06:56:55 +10:00
Chris Archibald
98343993ee Fix Example for lun copy (#53281) 
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a37b42886aebb4d2b2ab27c91c96d97858a.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a37b42886aebb4d2b2ab27c91c96d97858a.

* documentation changes

* Revert "documentation changes"

This reverts commit 02c369d0414fdff492d90865c903bdade3174261.

* Fix example
 2019-03-05 15:50:42 -05:00
Jordan Borean
6b294eab4d
win_dsc - Add argument validation and other fixes (#53093) 
* win_dsc - Add argument validation and other fixes

* Fix doc issues
 2019-03-06 06:49:37 +10:00
Brian Coca
853a65eead
made chroot exe configurable (#53147) 
* made chroot exe configurable

 fixes #53146

* added default for executable
 2019-03-05 15:48:31 -05:00
Abhijeet Kasurde
ef8be6a599 Fix wrong number of arguments in string format (#53265) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-03-05 15:32:20 -05:00
Hannes Ljungberg
7a130d5446 docker_swarm_service: Add hosts option (#53290) 
* Add hosts option

* Add changelog fragment
 2019-03-05 18:59:49 +00:00
Alan Rominger
56e3597856 Add keyed_groups feature (#52045) 
This implements:
- Allow creating keyed group parents
 2019-03-05 12:34:34 -06:00
Matt Martz
a639dc6d88
Add a new check to ensure that module arguments are valid python identifiers (#53278) 
* Add a new check to ensure that module arguments are valid python identifiers

* Move the check up higher, out of the if docs block

* Skip validate-modules on py2

* Remove errant alias
 2019-03-05 10:26:06 -06:00
Chris Archibald
04c6f94269 New Module: na_ontap_quotas (#49783) 
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* new module na_ontap_quotas

* fix file location

* Fix author

* updates

* Revert "Revert "changes to clusteR""

This reverts commit 1c82958764ea38a91d51d3cfe8a85b418df8f0b8.

* fix author

* Add types
 2019-03-05 16:22:31 +00:00
Felix Fontein
8c628c9b2c Simplify docker_*_facts return names (#51939) 
* Simplify docker_*_facts return names.

* Adjust regular return values of modules to match style of docker_*_facts modules.
 2019-03-05 16:09:00 +00:00
Felix Fontein
1510435577 acme_account: improve account deactivation idempotency (#53234) 
* Improve account deactivation idempotency.

* Using newer testing container.

* Add comment to test.
 2019-03-05 16:08:01 +00:00
Maxim Babushkin
8ba2e15578 Add public key return to openssh_keypair (#53214) 
- The openssh_keypair module will return a public key output on the
  private key creation.
- Add integration test in order to verify the public key output.
 2019-03-05 16:07:43 +00:00
Hannes Ljungberg
139abd0849 docker_swarm_service: Add option groups (#53213) 
* Add logging option

* Add limits option

* Add reservations option

* Add restart_config option

* Add update_config option

* Add placement option and remove placement_preferences

* Yaml indentation

* Use correct PR number for change log

* Handle grouper fallbacks better

* Add removed_in_version to argument spec

* Fix broken suboption usage check

* Reduce duplicate deprecated option tests

* Clearer deprecation documentation

* Compare bytes with MiB

* Use correct test service suffix
 2019-03-05 16:07:27 +00:00
Felix Fontein
628326b879 openssl_csr: improve invalid SAN error messages (#53201) 
* Improve invalid SAN error messages.

* Add changelog.
 2019-03-05 16:07:07 +00:00
Chris Archibald
af6e4cc75b Add tcp_max_xfer_size option for na_ontap_nfs, plus unit test (#52288) 
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* updates

* Revert "Revert "changes to clusteR""

This reverts commit 8e56b999e6cf6a65de339e516f7134a6b6b39cba.

* fix docs

* Fix boolean to bool

* Update lib/ansible/modules/storage/netapp/na_ontap_nfs.py

Co-Authored-By: carchi8py <carchi@netapp.com>
 2019-03-05 16:04:21 +00:00
Chris Archibald
5fbdb0cfdf Bug Fix for na_elementsw_backup.py (Default argument spec wasn't given) (#52378) 
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a37b42886aebb4d2b2ab27c91c96d97858a.

* bug fix

* Fix exception
 2019-03-05 16:03:43 +00:00
Felix Fontein
07fcb60d55 Python 2: accept both long and int for type=int (module options) (#53289) 
* Added unit test
 2019-03-05 09:39:03 -05:00
Nathaniel Case
1112e1d0da
Add missing RETURN to restconf_config (#53324) 2019-03-05 08:53:23 -05:00
Nijin Ashok
ff0285c6c4 ovirt_network: Fix update_check for cluster network role (#53318) 
Currently if we didn't specify the "role" in the task which is already
available for the network, the update_check will return FALSE. The
patch fixes the same and update_check will only return FALSE if there
is any additonal role specified for the network that are not currently
available for the network.
 2019-03-05 08:40:15 -05:00
Ondra Machacek
6b2c2f169a kubevirt: Add datavolumes support (#52998) 2019-03-05 17:13:40 +05:30
Miguel Angel Muñoz González
330d0827ec Fortinet's FortiOS user adgrp (#52831) 
* Fortinet's FortiOS user adgrp

* Remove unnecessary code
 2019-03-05 16:48:47 +05:30
Viktor Utkin
b2a7561a7f [win_get_url] feature: Add support checksum to module win_get_url (#51986) 
* set valid_until equal to current time + spot_wait_timeout

* Add checksum check for downloaded file.

* refactoring

* fix typo

* add fixes

* mart try,catch handling

* revert lib/ansible/modules/cloud/amazon/ec2.py from upstream

* refactoring

* remove empty lines

* add checksum verification for existing file

* fix current file check

* refactoring destination file check

* add handling exceptions

* refactoring

* Added download file hash data from url

* fix string aligning

* fix bug with uri

* Added get hash from multy-string file

* Added URI support for checksum file location

* refactoing

* Remove any non-alphanumeric characters for hash from url

* fix discussions; add support for PS3

* refactoring

* add size return value

* checkout from upstream for lib/ansible/modules/cloud/amazon/ec2.py

* add Ansible.ModuleUtils.Legacy support; refactoring

* Copyright added

* Checking files size before and after downloading added.

* remove unused code

* Corrected regexp for dotted slashed file name prefix in hash-file

* hotfix typo error; add int tests

* remove legacy module support; split checksum to checksum, checksum_algorithm, checksum_url

* changed default hash algorithm

* Fixed case for ContentLength = -1

* Old comment removed

* fix typo

* Remove file size check before downloading

* add alias to ; fix tests

* adjust tests; fix lint warnings from PSScritpAnalyzer

* workaround for bug in win_chocolatey module on win2008

* remove win_get_url.ps1 from /test/sanity/pslint/ignore.txt

* add checksum_algorithm as retuen value

* first normalise before return Result

* resolve discussions

Signed-off-by: Viktor Utkin <viktor.utkin7@yandex.ru>

* fix discussions
fix http tests as discussed

* fix last discussions

* Reduce code duplication and add idempotency check

* fix sanity issue and remove testing code

* move back to using tmp file for checksum comparison
 2019-03-05 20:37:00 +10:00
René Moser
aafc5538bc
cloudscale_server: refactor to implement update (#52683) 2019-03-05 10:40:16 +01:00
ftntcorecse
d1c0df9e92 FortiManager Plugin Module Conversion: fmgr_secprof_web (#52788) 
* Auto Commit for: fmgr_secprof_web

* Auto Commit for: fmgr_secprof_web

* Auto Commit for: fmgr_secprof_web
 2019-03-05 14:55:43 +05:30
ftntcorecse
7ee7c3cf2c FortiManager Plugin Module Conversion: fmgr_secprof_waf (#52789) 
* Auto Commit for: fmgr_secprof_waf

* Auto Commit for: fmgr_secprof_waf

* Auto Commit for: fmgr_secprof_waf
 2019-03-05 14:53:30 +05:30
ftntcorecse
60c0069fec Auto Commit for: fmgr_secprof_spam (#53021) 2019-03-05 14:51:33 +05:30
ftntcorecse
55e431de54 Auto Commit for: fmgr_secprof_av (#53022) 2019-03-05 14:49:57 +05:30
ftntcorecse
73e6f15d64 Auto Commit for: fmgr_secprof_wanopt (#53023) 2019-03-05 14:47:51 +05:30
ftntcorecse
d684359997 Auto Commit for: fmgr_secprof_ips (#53024) 2019-03-05 14:44:23 +05:30
ftntcorecse
803c2b4724 New FortiManager Module: fmgr_device_provision_template (#53025) 
* Auto Commit for: fmgr_device_provision_template

* Auto Commit for: fmgr_device_provision_template

* Auto Commit for: fmgr_device_provision_template
 2019-03-05 14:42:44 +05:30
Zim Kalinowski
8ef75a1901 cleaning up azure_rm_sql* class names (#53261) 2019-03-05 15:44:32 +08:00
Lukas Kämmerling
66beeaf032 Add hcloud server module (#53062) 2019-03-05 07:30:24 +01:00
Zim Kalinowski
bdfa99af9f cleaning up class names in azure_rm_mysql* (#53260) 2019-03-05 13:55:51 +08:00
Abhijeet Kasurde
d39f35c1d6
assert: allow list of strings in msg or failed_msg (#50531) 
Added check for assert module for msg and failed_msg as a list or string types.

Fixes: #48547

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-03-05 11:12:17 +05:30
Jordan Borean
b74295d25f
win_chocolatey - add ability to pin a package (#53157) 
* win_chocolatey - add ability to pin a package

* fix typoe in changelog fragment
 2019-03-05 14:18:42 +10:00
Jordan Borean
be7768efc7
win_chocolatey_source - fix state=disabled with no source (#53097) 2019-03-05 14:18:00 +10:00
Jordan Borean
ae24bbff4a winrm - try and recover from a send input failure (#53187) 2019-03-04 17:31:00 -08:00
Steven Gerhart
f1fed45e40 new maintenance group node module (#53094) 
* create aci_maintenance_policy module

* aci_maintenance_group_node

* Various small fixes
 2019-03-05 01:58:16 +01:00
Dag Wieers
1937c5301b
MSO: Clarify the site-local modules in the index (#53301) 2019-03-05 00:41:50 +01:00
Dag Wieers
1a4e983364
mso_st_contract_filter: Add support for directives (#53300) 
This PR also fixes an issue introduced in the previous commit.
 2019-03-05 00:26:45 +01:00
Felix Fontein
6249bb8ea4 openssl_certificate: make sure extensions are present when they are queried by assertonly (#53207) 
* Make sure extensions are present when they are queried by assertonly provider.

* Add changelog.
 2019-03-05 00:09:48 +01:00
Sam Doran
aba4bed803
Move _handle_no_log_values() out of basic.py (#48628) 
* Rename method and make private
* Use is_iterable, combine transformations
* Remove unused return_values from network modules
* Improve docstrings in new functions
* Add new PASS_VAR
* Add unit tests for list_no_log_values
* Fix unit tests for Python 2.6
 2019-03-04 17:02:44 -05:00
Abhijeet Kasurde
917520d560 Misc typo fixes (#53284) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-03-04 15:30:18 -05:00
Brian Coca
b8799ef84e
improved nmap fix, updated as per fb (#53280) 
(cherry picked from commit 5280ae917c4a49df1bb4ff354885bc046e7ee397)
 2019-03-04 14:47:38 -05:00
Martin Krizek
5734b4e69e Clarify return value of the sequence lookup (#53275) 
* Clarify return value of the sequence lookup

Fixes #17852

* Mention range filter
 2019-03-04 14:09:55 -05:00
Sloane Hertel
4cf7854ca3
If the private_ip has been provided for the new network interface it shouldn't also be added to top level parameters for run_instances (#52579) 
changelog
 2019-03-04 12:55:37 -06:00
Martin Krizek
239fb1f68d yum/dnf: Add download_dir param (#53171) 2019-03-04 13:08:58 -05:00
Mariusz Mazur
4ea51fd7ee k8s_auth: use group module defaults in example (#52712) 
The yaml anchor thing was just a stopgap until all the module defaults
group stuff got merged. Which it did.
 2019-03-04 12:55:30 -05:00
Abhijeet Kasurde
d901ba18d1 Correct usages of module.warn (#53268) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-03-04 12:11:27 -05:00
Chris Archibald
ab22ea1a66 Wrong Setup function was being used, which could result in failure if new global options were used. (#52862) 
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a37b42886aebb4d2b2ab27c91c96d97858a.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a37b42886aebb4d2b2ab27c91c96d97858a.

* Fix setup bug
 2019-03-04 16:58:09 +00:00
Chris Archibald
1e776c34a2 Add NVME to gatherfacts (#53007) 
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a37b42886aebb4d2b2ab27c91c96d97858a.

* Updtes
 2019-03-04 16:57:05 +00:00
Chris Archibald
11a058fa39 Bug fix for na_elementsw_admin_users (#52377) 
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a37b42886aebb4d2b2ab27c91c96d97858a.

* Updates

* bug fix

* Bug fix

* Revert "Bug fix"

This reverts commit 5cbea70a6587b7bc5e8a4da912549fbc63ff6235.
 2019-03-04 16:56:18 +00:00
Chris Archibald
725654f9d3 Add support for FlexCache to na_ontap_vserver_peer (#52301) 
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* updates

* doc fix

* Revert "Revert "changes to clusteR""

This reverts commit 8e56b999e6cf6a65de339e516f7134a6b6b39cba.

* fix wrong fucntion
 2019-03-04 16:55:51 +00:00
Abhijeet Kasurde
bf8ada0eb5 VMware: Fail when unable to find managed object (#53158) 
Fixes: #52119

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-03-04 11:48:57 -05:00
Felix Fontein
6b948ab031 Make clear which option is used by which provider. (#53208) 2019-03-04 11:27:16 -05:00
Abhijeet Kasurde
7011257274
F5: correct check in _transform_api_names API (#53269) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-03-04 20:32:34 +05:30
John R Barker
2033b3d066 Minor formatting (#53178) 2019-03-04 07:28:48 -06:00
Nathaniel Case
d5aabd02ba
restconf_config module (#51971) 
* Add restconf_config module

* Try to do the right thing when given partial paths

* Add PATCH

* Delete should not require content

* Non-JSON exceptions need raising, too

* Let ConnectionError objects pass through exec_jsonrpc
 2019-03-04 08:27:18 -05:00
ftntcorecse
718a591fb2 New FortiManager Module: fmgr_fwpol_package (#53026) 
* Auto Commit for: fmgr_fwpol_package

* Auto Commit for: fmgr_fwpol_package

* Auto Commit for: fmgr_fwpol_package
 2019-03-04 16:46:28 +05:30
ftntcorecse
e585e948fb New FortiManager Module: fmgr_fwobj_service (#53027) 
* Auto Commit for: fmgr_fwobj_service

* Auto Commit for: fmgr_fwobj_service
 2019-03-04 16:43:05 +05:30
Felix Fontein
8e26c2dfbe docker_swarm: support older docker-py versions (#53129) 
* Decreasing docker_swarm requirements.

* Fixing docker-py / docker API version requirements, and some comments.

* Add changelog.

* Only send parameters specified by user to docker daemon.

* Extend labels test: not specifying == keep labels.

* Bump minimally required docker-py version for docker_node and docker_node_facts to 2.4.0.

* Prevent crashing when publish or healthcheck is not provided.

* Similarly to docker_swarm tests, only execute docker_node tests on real VMs and restart docker daemon when tests are done.
 2019-03-04 12:10:09 +01:00
ftntcorecse
340aa26edf New FortiManager Module: fmgr_secprof_appctrl (#53028) 
* Auto Commit for: fmgr_secprof_appctrl

* Auto Commit for: fmgr_secprof_appctrl
 2019-03-04 16:39:48 +05:30
ftntcorecse
29657bdda5 New FortiManager Module: fmgr_secprof_proxy (#53029) 
* Auto Commit for: fmgr_secprof_proxy

* Auto Commit for: fmgr_secprof_proxy

* Auto Commit for: fmgr_secprof_proxy
 2019-03-04 16:25:02 +05:30
ftntcorecse
421a5c4c91 New FortiManager Module: fmgr_secprof_voip (#53030) 
* Auto Commit for: fmgr_secprof_voip

* Auto Commit for: fmgr_secprof_voip
 2019-03-04 16:19:50 +05:30
ftntcorecse
8888faf716 New FortiManager Module: fmgr_fwobj_ippool (#53031) 
* Auto Commit for: fmgr_fwobj_ippool

* Auto Commit for: fmgr_fwobj_ippool
 2019-03-04 16:09:56 +05:30
ftntcorecse
0e9bf838ff New FortiManager Module: fmgr_fwobj_ippool6 (#53032) 
* Auto Commit for: fmgr_fwobj_ippool6

* Auto Commit for: fmgr_fwobj_ippool6
 2019-03-04 16:07:55 +05:30
Nilashish Chakraborty
e55955d01b
frr: New module for BGP configuration management (#51281) 
* Added frr_bgp module

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix pycodestyle warnings

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI docs issues

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Initial test files

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix dir structure to make CI happy

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix imports

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Split neighbor spec to handle general session and af session

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* New set of unittests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI - 2

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Update license

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add port option for neighbor

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Validate network input

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Validate network input

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix sanity test failure

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add validation for AF and more examples

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-03-04 15:02:56 +05:30
Joseph Andreatta
3fb383b1ae VMware: Update vmware_object_role_permission to allow permissions at root folder (#50465) 
* Update vmware_object_role_permission to allow permissions at root folder
* Add example for adding to root folder
 2019-03-04 14:49:56 +05:30
Zim Kalinowski
b547376db9
Adding DevTest Lab ARM Template facts (#53196) 2019-03-04 17:18:45 +08:00
Yuwei Zhou
d1b9e211a2 Add addon/network/aad support for AKS (#51014) 2019-03-04 17:15:04 +08:00
Miguel Angel Muñoz González
9aa59bebe0 Fortinet's FortiOS wireless controller global (#52844) 
* Fortinet's FortiOS wireless controller global

* Avoid using global

* Updated from comments received
 2019-03-04 13:45:46 +05:30
Nilashish Chakraborty
55bfa18c0c
New module to support BGP configuration management in IOS (#49121) 
* ios_bgp initial push

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added tests for ios_bgp

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fixed docs

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added space

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix Shippable Errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix Shippable Errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add support for af_neighbor option

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add support for af_neighbor option - 2

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add support for af_neighbor option - 3

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix typo

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Refactor BGP

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI and previous reviews

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add missing params documentation

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Remove previous tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Remove elements=dict from keys with type=list from args spec for element validation to pass

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added function to validate input

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix sanity test failure

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Minor bug fixes

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix typo in fixture

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add integration tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-03-04 13:37:57 +05:30
Miguel Angel Muñoz González
bf3fc86437 Fortinet's FortiOS wireless controller wtp profile (#52851) 
* Fortinet's FortiOS wireless controller wtp profile

* Avoid using global

* Remove unnecessary code ('flatten' method)
 2019-03-04 13:31:53 +05:30
ftntcorecse
13517fe822 FortiManager Plugin Module Conversion: fmgr_device_config (#52765) 
* Auto Commit for: fmgr_device_config

* autopep8 changes

* Auto Commit for: fmgr_device_config

* Auto Commit for: fmgr_device_config
 2019-03-04 11:25:40 +05:30
ftntcorecse
785c567f72 FortiManager Plugin Module Conversion: fmgr_device (#52767) 
* Auto Commit for: fmgr_device

* Auto Commit for: fmgr_device
 2019-03-04 11:22:16 +05:30
ftntcorecse
a8f1ad8602 FortiManager Plugin Module Conversion: fmgr_query (#52770) 
* Auto Commit for: fmgr_query

* Auto Commit for: fmgr_query
 2019-03-04 11:06:12 +05:30
ftntcorecse
c4d29868ca FortiManager Plugin Module Conversion: fmgr_fwobj_address (#52773) 
* Auto Commit for: fmgr_fwobj_address

* Auto Commit for: fmgr_fwobj_address

* Auto Commit for: fmgr_fwobj_address

* Auto Commit for: fmgr_fwobj_address

* Commit contains updates to module, unit test, and/or fixture files: fmgr_fwobj_address
 2019-03-04 10:59:55 +05:30
ftntcorecse
a65db027e8 Fortinet FortiManager Module_Utils MINOR Update (#52756) 
* PR for minor update to FortiManager.py.

Now accepts entire module as input, so it can use those data points for decisions later. This update is entirely related to our debugging and should have zero impact on existing modules.

* Minor change to documentation to kick off another shippable. Suspected error on last run.

* Commented out reference to the import library for fortimanager debug (which is only used by us, internally). It needs to be moved outside of the Ansible namespace so we can call it with try/catch without any other issues. Right now /ansible/executor/module_common.py runs w/ recursive_finder, and throws errors because it can't find debug on other machines within the ansible namespace. We don't have this issue with pyFMG legacy usage.

So, we're disabling the code until we have a better way of calling this debug module. It isn't required for production usage.
 2019-03-04 10:56:06 +05:30
Zim Kalinowski
c0c6eebed6 Adding DevTest Lab Artifact facts (#53195) 2019-03-04 12:53:44 +08:00
Zim Kalinowski
d96543880b
Adding DevTest Lab Artifact Source facts module (#53194) 2019-03-04 11:54:10 +08:00
Dag Wieers
4e7a3df1e6
MSO: New module to manage local site VRF region CIDR subnets (#53254) 
This adds a new module to manage local site VRF region CIDR subnets on ACI MultiSite schema templates.
 2019-03-04 02:13:03 +01:00
Dag Wieers
121c2d90dc
MSO: New module to manage local site VRF region CIDRs (#53253) 
This adds a new module to manage local site VRF region CIDRs on ACI MultiSite schema templates.
 2019-03-04 02:11:20 +01:00
Dag Wieers
38afee0937
MSO: New module to manage local site VRFs (#53251) 
This adds a new module to manage local site VRFs on ACI MultiSite schema templates.
 2019-03-04 02:11:01 +01:00
Dag Wieers
9294943f6c
MSO: New module to manage local site VRF regions (#53252) 
This adds a new module to manage local site VRF regions on ACI MultiSite schema templates.
 2019-03-04 02:10:38 +01:00
Dag Wieers
095eb59f5a
MSO: New module to manage local site EPG subnets (#53250) 
This adds a new module to manage local site EPG subnets on ACI MultiSite schema templates.
 2019-03-04 02:02:58 +01:00
Dag Wieers
6551b4640c
MSO: New module to manage local site BD l3outs (#53249) 
This adds a new module to manage local site BD l3outs on ACI MultiSite schema templates.
 2019-03-04 01:55:55 +01:00
Dag Wieers
b5e1f1bf18
MSO: New module to manage local site BDs (#53248) 
This adds a new module to manage local site BDs on ACI MultiSite schema templates.
 2019-03-04 01:54:25 +01:00
Dag Wieers
eeccf0e2e6
MSO: New module to manage local site EPG subnets (#53247) 
This adds a new module to manage local site EPG subnets on ACI MultiSite schema templates.
 2019-03-04 01:49:58 +01:00
Dag Wieers
e1b79d0aae
MSO: New module to manage local site static ports (#53246) 
This adds a new module to manage local site EPG static ports on ACI MultiSite schema templates.
 2019-03-04 01:47:04 +01:00
Dag Wieers
e6275c7f12
MSO: New module to manage local site static leafs (#53245) 
This adds a new module to manage local site static leafs on ACI MultiSite schema templates.
 2019-03-04 01:44:50 +01:00
Dag Wieers
9b5741090f
MSO: New module to manage local site EPGs (#53244) 
This adds a new module to manage local site EPGs on ACI MultiSite schema templates.
 2019-03-04 01:42:13 +01:00
Dag Wieers
cd3890b4e7
MSO: New module to manage local site ANPs (#53243) 
This adds a new module to manage local site ANPs on ACI MultiSite schema
templates.
 2019-03-04 01:38:15 +01:00
Dag Wieers
8c659c35ec
mso_st_bd_subnet: Fix various issues (#53240) 
This PR includes:
- Rename 'ip' to 'subnet' as that's what we're managing
- Small improvement in logic
 2019-03-04 01:27:14 +01:00
Dag Wieers
12a949229d
mso_stae_subnet: Fix various issues (#53239) 
This PR includes:
- Rename 'ip' to 'subnet' as that's what we're managing
- Use the correct module name in the examples
- Small improvement in logic
 2019-03-04 01:26:58 +01:00
Dag Wieers
85eb8c30a6
MSO: Clean up internal references (#53242) 
During the development of the new site modules the use of references is
more common and this urged making the mechanism more simple overall.
 2019-03-04 01:26:47 +01:00
Dag Wieers
e4093fbad4
mso_st_filter_entry: Fix various issues (#53241) 
This PR includes:
- Use the correct module name in the examples
- Small improvement in logic
- Fix an issue where updating an existing entry could reset to defaults
 2019-03-04 01:20:02 +01:00
Dag Wieers
9c2879d8e6
mso_s_t_anp_epg: Fix incompatibility with newer MSO (#53238) 
Due to a change with the backend contractRelationships is required.
 2019-03-04 01:13:30 +01:00
Dag Wieers
33ae15e070
mso_schema_template: Fix examples (#53237) 
The examples were using the wrong module.
 2019-03-04 01:13:16 +01:00
Bill Bagdon
aa1ed59e1b Add documentation for win_copy as become user needing temp dir set (#53211) 2019-03-03 11:59:43 +00:00
Ruben Tsirunyan
0df453bb5d Zabbix action: Correcting 'notify_all_involved' for acknowledge operations (#53197) 2019-03-03 04:23:22 -05:00
Andrea Tartaglia
d5d92e4a70 openssl_certificate, fixed has_expired to check the cert expiration date (#53168) 2019-03-02 00:37:28 +01:00
Tuan-Anh Hoang-Vu
1ba1f712fd Used C locale instead of relying on system locale. 2019-03-01 15:22:46 -08:00
Arnaud Morin
0da471e54f Fix typo (#53123) 
I changed the typo: acceess to access
 2019-03-01 23:45:59 +01:00
Ruben Tsirunyan
befd5b2ff7 Zabbix action: Adding operation condition (#53173) 2019-03-01 11:14:06 -05:00
John R Barker
6e74816516 hpe3par document type (#52992) 
* Update lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py

Co-Authored-By: gundalow <john@johnrbarker.com>
 2019-03-01 09:57:22 -06:00
Martin Krizek
66eb301cd3 profile_tasks: Fix last task time with multiple plays (#53065) 2019-03-01 10:29:33 -05:00
Ruben Tsirunyan
832a669104 [zabbix_action] Refactoring the argument spec (#53106) 
* Refactoring the argument spec

* Adding subarguments for recovery and acknowledge operations

* Correcting the linting errors
 2019-03-01 07:38:45 -05:00
Ruben Tsirunyan
1b338f917f Fixing mediatype default value (#53114) 
* Fixing mediatype default value

* Updating the documentation of media_type
 2019-03-01 07:25:56 -05:00
Miguel Angel Muñoz González
c9a79f12b4 Fortinet's FortiOS wireless controller setting (#52845) 
* Fortinet's FortiOS wireless controller setting

* Avoid using global
 2019-03-01 10:17:08 +00:00
Miguel Angel Muñoz González
92398f6106 Fortinet's FortiOS wireless controller utm profile (#52846) 
* Fortinet's FortiOS wireless controller utm profile

* Avoid using global
 2019-03-01 10:16:28 +00:00
Miguel Angel Muñoz González
1ef20453d9 Fortinet's FortiOS wireless controller vap (#52847) 
* Fortinet's FortiOS wireless controller vap

* Avoid using global
 2019-03-01 10:16:06 +00:00
Miguel Angel Muñoz González
ffc778d036 Fortinet's FortiOS wireless controller wids profile (#52849) 
* Fortinet's FortiOS wireless controller wids profile

* Avoid using global
 2019-03-01 10:15:46 +00:00
Miguel Angel Muñoz González
ef8958c694 Fortinet's FortiOS wireless controller wtp (#52850) 
* Fortinet's FortiOS wireless controller wtp

* Avoid using global
 2019-03-01 10:15:27 +00:00
Xander Madsen
96549bf6ff Remove mistaken commits from other pull request. (#52928) 2019-03-01 10:13:08 +00:00
Xander Madsen
9f7eb8ee53 Resolved conflicts with mistaken commits in earlier history (#52953) 2019-03-01 10:11:46 +00:00
Mariusz Mazur
fb4d0d84ec Add kubevirt_cdi_upload module (#52990) 2019-03-01 10:09:01 +00:00
Ondra Machacek
b54f2799f1 kubevirt: Fix cloud_init in kubevirt_vm (#52999) 2019-03-01 10:06:17 +00:00
Tony Finch
ccad79d162 get_url: return no change in check mode when checksum matches (#53070) 
Signed-off-by: Tony Finch <dot@dotat.at>
 2019-03-01 09:53:28 +00:00
Michael Miko
00efa26cdb Do not delete duplicate host when fetching Zabbix Hosts (#53160) 2019-03-01 09:51:39 +00:00
Yunge Zhu
75abb27677 fix class name (#53162) 2019-03-01 15:32:29 +08:00
Yunge Zhu
861b710c73
fix keyvault auth in msi auth (#53100) 2019-03-01 15:26:34 +08:00
Chris Adams
14d4a4fc3b docs: SAN prefixes are required for openssl_csr (#53144) 
The openssl_csr docs use “should” where (at least following IETF nomenclature) “must” would be more accurate.

See #53141 

+label: docsite_pr
 2019-03-01 01:26:00 -05:00
Matt Davis
9c644d9bcc
interpreter discovery message tweaks (#53155) 
* fixes #53120 (doclink generator now understands devel)
* added hosts to some warnings
 2019-02-28 17:53:55 -08:00
Sloane Hertel
8a02f894a6 replace uses of sort_json_policy_dict with compare_policies (#52943) 
* replace uses of sort_json_policy_dict with compare_policies which is compatible with Python 3 and remove sort_json_policy_dict from the AWS guidelines since it only works on Python 2

* Sort any lists containing only strings

* Sort the original policy too
 2019-02-28 17:09:00 -05:00
Sam Doran
2a98faee2b
Move _handle_aliases() out of basic.py (#48578) 
Refinements:
- return legal_inputs and update class properties
- remove redundant arguments from method and handle in caller
- add better exception types to method

* Add unit tests for handle_aliases
 2019-02-28 16:43:19 -05:00