Arnaud
84117e57ba
nxos: 32 bits AS in as-dot format not recognized by regexp asn_regex ( #30569 )
...
* added test for 32 bits AS
* Lint not happy.
2017-11-20 10:09:16 +00:00
Pilou
a5c9726502
Unit tests: share common code ( #31456 )
...
* move set_module_args to units.modules.utils
* unit tests: reuse set_module_args
* unit tests: mock exit/fail_json in module.utils.ModuleTestCase
* unit tests: use module.utils.ModuleTestCase
* unit tests: fix 'import shadowed by loop variable'
2017-11-17 09:17:07 -08:00
Trishna Guha
3ee2501c83
multiple fixes nxos ( #32903 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-14 15:23:11 +00:00
Trishna Guha
c40de24e9c
fix mtu check nxos_interface ( #32880 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-14 10:40:37 +00:00
Trishna Guha
f49555d494
nxos_bgp_neighbor_af feature idea disable-peer-as-check ( #32665 )
...
* nxos_bgp_neighbor_af feature idea disable-peer-as-check
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-13 14:48:31 +00:00
Trishna Guha
e4052c1261
Add mtu option nxos_interface feature idea ( #32680 )
...
* Add mtu option nxos_interface feature idea
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add unit test for mtu feature
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-13 14:48:04 +00:00
Kedar K
916e6be888
- Fix to return error message back to the module. ( #31035 )
2017-09-29 17:06:30 +05:30
Kedar K
4c21563ac6
- Adds sub-interface support for nxos_interface and nxos_ip_interface ( #30830 )
...
- Support dot1 encapsulation on routed sub-interface
2017-09-26 21:34:51 +05:30
Ganesh Nalawade
d72eb08902
Fix nxos provider transport warning issue ( #30610 )
...
* Fix nxos provider transport warning issue
* Add default value of transport arg in provider spec
* Remove default value if transport arg in top level spec
This ensure deprecation warning is seen only in case transport
is given as a top level arg in task
* Refactor nxos modules to reference transport value from provider
spec
* Fix unit test
* Remove transport arg assignment in nxos action plugin
* As assigning transport value is handled in provider spec
top level task arg assignment is no longer required
2017-09-22 10:32:25 +05:30
Mike Wiebe
173c41aefe
Rel240/fix nxos pim interface ( #29885 )
...
* fix nxos_pim_interface
* Add integration test coverage and fix unit test
* Add clarifying comments
* Make ansibot happy
2017-09-14 13:36:32 -07:00
Nathaniel Case
f84ff216b6
Generalize nxos_bgp event-history detection ( #28890 )
...
* More general handling of event-history
* Update unit tests
2017-09-06 17:37:44 -04:00
Nathaniel Case
8bfdbd0f73
nxos_bgp_neighbor: Fix regex &report warnings ( #28888 )
...
* Fix over-detection of log-neighbor-as
* Report nxos warnings
* Update nxos_bgp_neighbor unit tests to test remove-private-as
2017-09-01 15:17:42 -04:00
Mike Wiebe
d9fc3def94
Fixes #28779 eth_mode key error ( #28782 )
...
* Fixes #28779 eth_mode key error
* Remove unused get_config references
* Addressed PR comment
2017-08-29 17:07:46 -04:00
Nathaniel Case
64dac346c9
Fix nxos_pim_interface dr-priority handling ( #28472 )
...
* Fix nxos_pim_interface dr-priority handling
* Prefer execute_show over `| json`
* Mock get_config
* Fix sparse-mode detection
2017-08-29 14:42:09 -04:00
Mike Wiebe
3d46258cff
Refactor/fix nxos_nxapi to use show run ( #28675 )
...
* Refactor/fix nxos_nxapi to use show run
* Fix unit tests
* Python 3 compatibility
2017-08-28 15:00:56 -04:00
Mike Wiebe
ec11cd2696
nxos_bgp_neighbor_af fix problem with advertise-map properties ( #28413 )
...
* Fix problem with advertise-map properties
* Change limit_to back to run all tests
* Fix unit tests
* Move advertise_map out of get_custom_value
2017-08-21 15:28:02 -04:00
Peter Sprygada
6886153b54
refactors nxos_vrf_af module ( #28208 )
...
* refactors nxos_vrf_af module
fixes #27595
* fix up unit test cases
* add commands to result dict
* add route-target on afi create
* adds deprecation note to safi argument
2017-08-16 10:11:12 -04:00
saichint
d69440c4ef
Fix nxos_vpc issues ( #28188 )
...
* fix for nxos_vpc issues
* fix unit tests
* clean documentation
2017-08-15 12:08:55 -04:00
saichint
9d84a4e530
fix for nxos_ospf_vrf invalid cmd and ntp errors ( #27977 )
...
* fix for nxos_ospf_vrf invalid cmd
* fix for nxos_ntp issues
2017-08-14 16:09:16 -04:00
Trishna Guha
60ce6438e3
fix nxos_overlay_global idempotence ( #28150 )
...
* fix nxos_overlay_global idempotence
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify nxos_overlay_global unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-14 16:09:53 +05:30
David Newswanger
a01aa6e9df
Fix structured output not supported in nxos_pim_interface ( #28125 )
...
* fixed unstructured error
* fix unit tests so they accept commands in dictionary form
2017-08-14 12:34:05 +05:30
Nathaniel Case
a78f3faa6c
nxos_bgp_neighbor_af does not want required_together ( #26370 )
...
* nxos_bgp_neighbor_af does not want required_together
* fixup tests
* Fix max_prefix_* issues
* Require address-family
* Fix idempotency for next_hop_third_party
* Fix idempotency for allowas_in*
* Fix idempotency for *_in and *_out
* Reorder command generation again
`default` is first, then `max-prefix`, then booleans
2017-08-09 15:54:34 -04:00
Nathaniel Case
c1bf74283e
Network load_config: Capture configuration output and display as warnings ( #27851 )
...
* Capture configuration output and display as warnings
* Don't break on nxapi
nxapi errors very loudly instead, so no need to muck about with warnings
2017-08-09 09:43:04 -04:00
Trishna Guha
a49c419651
fix nxos_vrf_af nxapi & cli ( #27307 )
...
* fix nxapi failure #27142
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_vrf_af nxapi and cli
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-28 09:02:02 +05:30
saichint
9b9a8749da
Add integration tests and fix nxos providers ( #26913 )
...
* fix issues with python3.x
* Add integration testa and fix for nxos_evpn_vni
* add nxos_evpn_vni to nxos.yaml
* fix get_vtp_config()
* add new integration tests
* fix rollback
* add integration test files
2017-07-27 09:32:35 -04:00
Trishna Guha
41ce724801
fix nxos_hsrp ( #27306 )
...
* fix nxos_hsrp
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify nxos_hsrp test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-26 11:38:55 +05:30
Nathaniel Case
85e7e342b0
nxos_bgp_af correct parents ( #26996 )
...
* move config location
* client-to-client is inverse of BOOL_PARAMS
2017-07-20 13:42:26 -04:00
Nathaniel Case
56a0b988a9
nxos integration fix part 1 ( #27069 )
...
* Assorted Python 3 fixes
* Fix `testcase` definition in integration tests
* Fix nxos_acl_interface
* clean up nxapi after nxos_nxapi
2017-07-19 14:00:05 -04:00
Nathaniel Case
855544604a
Fix nxos_bgp_neighbor_af advertise_map and advertise_map_non_exist ( #26721 )
2017-07-17 11:15:06 -04:00
Nathaniel Case
61249995a1
Update nxos_interface_ospf & add test ( #26644 )
...
* Update nxos_interface_ospf & add test
2017-07-14 12:31:36 -04:00
Nathaniel Case
5cfdd5df0f
nxos_pim_interface ( #26367 )
...
* Add unit tests to nxos_pim_interface
* Update tests to match module
* Update nxos_pim_interface
* Address pep8 issues
2017-07-12 15:39:43 -04:00
rahushen
74947168e3
Add nxos_command IT and generalize UT ( #26617 )
...
* Add nxos_command IT sanity
* generalize nxos_command UT for different NXOS platforms
2017-07-12 13:19:02 -04:00
Trishna Guha
07498ebed3
fix nxos_overlay_global ( #26422 )
...
* fix nxos_overlay_global
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* swap check_mode with candidate
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-10 18:53:52 +05:30
Trishna Guha
c5fb4bbcc0
Fix nxos_switchport and unit test ( #26131 )
...
* fix nxos_switchport
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_switchport unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* legacy file
* update unit test
* handle exception
2017-07-06 18:58:36 +05:30
saichint
5229370364
fix for nxos_acl_interface idempotency ( #26156 )
...
* fix for nxos_acl_interface idempotency
* shippable error fix
* fix issues with python3.x
2017-07-05 12:05:47 -04:00
Nathaniel Case
3102746ebe
nxos_pim_rp_address fixes ( #26119 )
...
* nxos_pim_rp_address tests
* nxos_pim_rp_address changes
* Address issues with idempotence
2017-06-29 10:22:26 -04:00
Nathaniel Case
ad6c4a544e
nxos_pim updates ( #26145 )
...
* nxos_pim tests
* Cleanup nxos_pim
2017-06-28 19:40:19 -04:00
Nathaniel Case
eea18e9875
nxos_vxlan_vtep_vni fixes ( #25913 )
...
* nxos_vxlan_vtep_vni first pass
* nxos_vxlan_vtep_vni tests
2017-06-28 19:38:31 -04:00
Nathaniel Case
3d6d428bbc
Test multiple nxos versions at once ( #25595 )
...
* Extend tests to have multiple device representations
* Move filepath munging to nxos_module
* Device needs to be kwarg so we can leave it off
* Update other nxos tests
* Update tests that fell through
2017-06-27 12:45:36 -04:00
Nathaniel Case
21c7fcf9c0
nxos_vxlan_vtep ( #25971 )
...
* nxos_vxlan_vtep tests
* Fix issues with nxos_vxlan_vtep
2017-06-24 14:09:11 -04:00
Trishna Guha
3482a6326b
Fixes nxos_vpc_interface ( #25907 )
...
* nxos_vpc_interface fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_vpc_interface unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix state_present
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add state_present unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* make ansibot happy
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* teardown get_config
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-24 18:05:07 +05:30
Nathaniel Case
0296c2285b
nxos_vrf fix ( #25812 )
...
* Fixes #25031
* Slight cleanup and add tests
2017-06-20 10:59:03 -04:00
Nathaniel Case
a38e727380
nxos_nxapi fix ( #25306 )
...
* Add nxos_nxapi tests
* Simple changes to nxos_nxapi
* Move validation to check_args
* Don't mark protocol change unless change is requested
* Add different regex to handle HTTP{,S} ports on a different version of nxos
2017-06-16 07:15:08 -06:00
Trishna Guha
9c6ee8d0bb
Add nxos_banner implementation module ( #25695 )
...
* Add nxos_banner implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_banner integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_banner unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* doc update
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-15 22:05:38 +05:30
Nathaniel Case
4344132a7d
nxos_vpc updates ( #25452 )
...
* Add nxos_vpc tests
* Split execute-show between get_config and run_commands
2017-06-14 11:06:49 -04:00
Nathaniel Case
f52dcef7ba
Actually check for equality on empty commands array ( #25308 )
2017-06-06 09:56:44 -04:00
Trishna Guha
343b83041e
nxos_feature fix and unit test ( #25200 )
...
* nxos_feature fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_feature unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove from pep8/legacy-file
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-01 08:58:35 +05:30
Trishna Guha
fb87680046
fix state present nxos_evpn_vni ( #25212 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-01 08:57:17 +05:30
Nathaniel Case
53837c2ab0
Assorted nxos_bgp_* fixes ( #25080 )
...
* Simplify apply_key_map
* Fix nxapi
* Clean up get_value
* Fix missing non-values
* Add test for existing bgp_af case
* Fix small issues with bgp_neighbor_af
2017-05-30 14:11:15 -04:00
Dag Wieers
4efec414e7
test/: PEP8 compliancy ( #24803 )
...
* test/: PEP8 compliancy
- Make PEP8 compliant
* Python3 chokes on casting int to bytes (#24952 )
But if we tell the formatter that the var is a number, it works
2017-05-30 18:05:19 +01:00