Matt Clay
f012c94fa5
Handle bad options syntax in validate-modules.
2017-10-16 11:38:14 -07:00
Eike Frost
1b71fb0499
fix legacy PEP8 violations in zabbix modules, remove test exception for them ( #31702 )
...
* fix legacy PEP8 violations in zabbix_*, remove test exception for them
* fix new pep8 violations for zabbix_maintenance.py
2017-10-16 19:20:54 +02:00
René Moser
8b8d5aaca7
cs_instance: remove CloudStackException dep ( #31724 )
...
- fixes dep
- fix docs
2017-10-14 00:09:57 +02:00
Pilou
840a57a4ed
s3_sync: fix broken import ( #31460 )
2017-10-12 20:48:05 +02:00
Abhijeet Kasurde
9d811a34c4
pep8 fixes for vmware modules ( #31537 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-10-12 07:50:05 +02:00
René Moser
540d53327d
cs_instance_facts: fix pep8 ( #31606 )
2017-10-12 14:00:14 +10:00
Toshio Kuratomi
f38b8d9997
Remove boundary_meter module as the hosted service it configured has been removed. ( #31506 )
...
References #29387
2017-10-12 09:12:37 +10:00
René Moser
e872763877
cs_portforward: remove CloudStackException dep ( #31610 )
...
- fixes pep8
- fixes doc
2017-10-12 00:25:01 +02:00
René Moser
c1121dd5fb
cs_securitygroup_rule: remove CloudStackException dependency ( #31603 )
...
- fixes pep8
- fixes docs
2017-10-11 22:23:00 +02:00
René Moser
af6e89fbc8
cs_securitygroup: remove CloudStackException dep ( #31597 )
...
- fixes pep8
- fixes docs
2017-10-11 20:58:08 +02:00
Rene Moser
d6e1f02990
cs_snapshot_policy: remove CloudStackException dependency
2017-10-11 18:35:54 +02:00
Toshio Kuratomi
b454115e9f
Update test cases
...
* Remove cloudstack, f5, and nxos from the wildcard import whitelist
* Remove nxos and f5 from the get_exception whitelist
* Remove some files from the pep8 legacy whitelist
2017-10-09 21:41:02 -07:00
Toshio Kuratomi
c81314dcb9
Add a hack to test whether type=path should be used in a module
2017-10-09 21:15:56 -07:00
Toshio Kuratomi
5e9384300d
Add boilerplate and remove wildcard imports for openstack modules ( #31461 )
...
* Add boilerplate and remove wildcard imports for openstack modules
* Remove openstack files that are now pep8 compliant from the legacy list
2017-10-09 09:56:26 -07:00
Sofiane Medjkoune
ef72eda172
Adding doc for the description argument of lxd_profile module
2017-10-09 11:11:58 -04:00
Toshio Kuratomi
9c81257ce3
Remove wildcard imports from amazon modules ( #31451 )
...
* Remove wildcard imports from amazon modules
* Remove files from legacy pep8 that now pass
2017-10-09 07:38:41 -07:00
Pilou
870974e0be
ec2_vpc_route_table: fix broken import ( #31459 )
2017-10-09 20:20:31 +10:00
Pilou
0be8ac6797
ec2_vpc_igw: fix broken import ( #31458 )
2017-10-09 15:36:12 +10:00
Dag Wieers
ae5d8e5ebb
modprobe: PEP8 compliancy and doc fixes ( #31255 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
- Make module a bit more consistent with existing practices
2017-10-08 09:21:58 -04:00
Matt Clay
a333f2e5b0
Fix ansible-test config management.
2017-10-04 12:52:36 -07:00
Dag Wieers
17fbeeb2f0
rhn_channel: PEP8 compliancy and doc fixes ( #30912 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-10-03 09:50:44 +02:00
Dag Wieers
4a358b5396
foreman: PEP8 compliancy and doc fixes ( #30910 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-10-03 09:50:27 +02:00
Pilou
44f5b2bd25
ansible_tower: fix broken import, reuse tower_argument_spec and documentation fragment ( #29115 )
...
* module_utils/ansible_tower: fix broken import
* tower_*: use tower_argument_spec & doc fragment
* tower doc fragment: Ansible requires Python 2.6+
* tower_job_wait: fix broken import (Py3 compat)
2017-10-02 16:21:24 -04:00
Dag Wieers
1241d0a3f4
pip: PEP8 compliancy and doc fixes
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-10-02 16:18:56 -04:00
Dag Wieers
bedfd0a5a4
atomic: PEP8 compliancy and doc fixes ( #30918 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-09-29 13:17:29 +02:00
Rene Moser
d7fa3ab487
cloudstack: cs_template: remove dependency to CloudStackException
...
* fixes docs
* fixes pep8
2017-09-29 11:11:22 +02:00
Dag Wieers
fde4244d04
kubernetes: PEP8 compliancy and doc fixes ( #30914 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-09-29 01:51:23 -04:00
Dag Wieers
0ef87c849f
virt: PEP8 compliancy and doc fixes ( #30917 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-09-27 22:37:54 -04:00
René Moser
b444332412
fix pep8 for cloudscale_server ( #30974 )
2017-09-27 11:39:02 -04:00
Dag Wieers
fd91da7297
pacman: PEP8 compliancy and doc fixes ( #30913 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-09-27 03:13:18 -04:00
Dag Wieers
91bb211922
redis: PEP8 compliancy and doc fixes ( #30920 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-09-27 02:12:06 -04:00
Dag Wieers
125c4b135d
mount: PEP8 compliancy and doc fixes
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-09-27 01:56:08 +02:00
Will Thames
ce2f5d26ab
Improve cloudwatchevent_rule exception handling ( #30823 )
...
* Fix cloudwatchevent_rule exception handling
Where it is currently present, this change fixes the exception handling.
However, there are many places that it is lacking.
Fixes #30806
* Add new exception handling for cloudwatchevent_rule
Ensure all API calls are wrapped with exception handling
* PEP8 tidy up
* Remove unnecessary HAS_BOTO3 import and checks
Tidy up documentation so that NO_QA can be removed
2017-09-26 12:47:24 -04:00
Dag Wieers
c3707aaf37
linode: PEP8 compliancy and doc fixes ( #30922 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-09-26 09:48:08 -04:00
Dag Wieers
4647713be9
cron: PEP8 compliancy and doc fixes ( #30884 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
2017-09-25 19:48:22 -04:00
Dag Wieers
5175bd8ebd
replace: PEP8 compliancy, pylint and docs ( #30856 )
...
This PR includes;
- PEP8 compliancy fixes
- pylint fixes
- Documentation updates
2017-09-25 17:55:45 -04:00
Dag Wieers
989bd1f829
xattr: PEP8 compliancy, pylint and docs ( #30861 )
...
This PR includes;
- PEP8 compliancy fixes
- pylint fixes
- Documentation updates
2017-09-25 12:21:18 -04:00
Dag Wieers
04b5c17578
ini_file: PEP8 compliancy, pylint and docs ( #30851 )
...
This PR includes;
- PEP8 compliancy fixes
- pylint fixes
- Documentation updates
2017-09-25 11:39:46 -04:00
Hervé Beraud
0e9ae5b8cc
[fix] no-unicode-literals sanity error on ansible.egg-info ( #30446 )
...
* [fix] no-unicode-literals sanity error on ansible.egg-info
2017-09-21 12:47:24 -07:00
Toshio Kuratomi
46e5c48f03
Split ec2_elb_* modules in service of rename/interface changes ( #30532 )
...
* Undeprecate ec2_elb_*
* Make ec2_elb* full fledged modules rather than aliases
* Split tests for ec2_elb_lb and elb_classicb_lb
* Change names in documentation of old and new elb modules
Add tests for ec2_elb_lb
2017-09-21 13:06:14 -04:00
Dag Wieers
f5dded59c2
mail: Fix charset encoding issue
...
This PR includes:
- An important fix to charset encoding of from address
- Documentation and examples cleanup
- PEP8 fixes
- Warning on insecure access
- Strict parameter typing
- More modern interface (using lists rather than comma, space or pipe-delimited strings)
- Warn on failure to send mail to some recipients
```
[WARNING]: Failed to send mail to 'foobar': 550 5.1.1 <foobar>:
Recipient address rejected: User unknown in local recipient table
```
- Warn on failure to parse some headers
```
[WARNING]: Skipping header 'Foobar', unable to parse
```
- Return failed recipients as return value
- Changed default encoding to utf-8
2017-09-21 01:07:53 +02:00
Matt Clay
dbf9634b1b
Enable more pylint rules and fix reported issues. ( #30543 )
...
* Enable pylint invalid-encoded-data test.
* Enable pylint anomalous-unicode-escape-in-string test.
2017-09-19 00:45:35 -07:00
Matt Clay
7714dcd04e
Enable more pylint rules and fix reported issues. ( #30539 )
...
* Enable pylint unreachable test.
* Enable pylint suppressed-message test.
* Enable pylint redundant-unittest-assert test.
* Enable pylint bad-open-mode test.
* Enable pylint signature-differs test.
* Enable pylint unnecessary-pass test.
* Enable pylint unnecessary-lambda test.
* Enable pylint raising-bad-type test.
* Enable pylint logging-not-lazy test.
* Enable pylint logging-format-interpolation test.
* Enable pylint useless-else-on-loop test.
2017-09-18 23:20:32 -07:00
Toshio Kuratomi
c82cf791dd
Add a code-smell test for smart quotes and remove smart quotes from all files
2017-09-18 16:49:16 -07:00
Matt Davis
6b5b465125
azure_rm_dnsrecordset rewrite ( #30449 )
...
As-merged, had several issues that prevented idempotent usage. Some args were defined at the wrong UI level. Dual-state args didn't match up with typical Ansible UI.
2017-09-15 18:12:46 -07:00
René Moser
f128796782
cs_volume: fix CloudStackException dependency ( #30389 )
...
fixes pep8
2017-09-15 20:40:28 +02:00
Pierre-Louis Bonicoli
e9d202f944
module_utils/avi.py: fix broken import
2017-09-14 10:59:25 -07:00
Nathaniel Case
8c03609e54
nxos_snmp cleanup ( #28922 )
...
* Clean up nxos_snmp_contact & nxos_snmp_location
* Bring nxos_snmp_community in line
* Bring nxos_snmp_host in line
* And I would have gotten away with it too,
if it weren't for those meddling sanity tests
* Bring nxos_snmp_traps & nxos_snmp_user in line
* Appease Shippable
2017-09-13 08:23:36 -07:00
Matt Clay
442af3744e
Miscellaneous pylint fixes.
...
The following rules are no longer disabled:
- bad-format-string
- duplicate-key
- lost-exception
- trailing-newlines
- unexpected-keyword-arg
- useless-suppression
- using-constant-test
2017-09-13 01:53:08 -07:00
John R Barker
bc2f4365b5
Correctly validate module name for modules with aliases ( #29957 )
...
* Correctly validate module name for modules with aliases
If a module has an alias (ie is a symlink) then we need to ensure that
DOCUMENTATION.module is set to the main name, not the aliased name
* formatting
2017-09-12 13:30:49 +01:00