1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

6949 commits

Author SHA1 Message Date
Pavlos Tzianos
a4eb4b2551 Rabbitmq user permission fixes (#49404)
* Simplify permission changing code for rabbitmq_user module

* Add check for multiple permission dicts for same host to rabbitmq_user module

* Add docstring for _get_permission method of rabbitmq_user

* Fix method that compares vhost permissions in rabbitmq_user

* Add tests for rabbitmq_user module

* Add helper function for simulating collections.Counter functionality
2018-12-07 13:19:08 +00:00
Matt Clay
a1a0893ebd Fix template_jinja2_latest aliases file. 2018-12-07 00:22:37 -08:00
Jordan Borean
6a09db5131
ansible-test - swap Fedora 25 for 29 (#49634) 2018-12-07 12:00:23 +10:00
Jordan Borean
28a903a1e2
pip tests: skip distribute test case for py3 compat (#49636) 2018-12-07 10:24:46 +10:00
Jordan Borean
198f1e1bea
Revert "Fixes #49362 module dnf: install python3-dnf preferably over python2-dnf. (#49402)" (#49633)
This reverts commit 3247eec97a.
2018-12-07 08:29:12 +10:00
Sean Myers
9434f8608a Add rhsm_repository_release module (#43211)
* Add rhsm_repository_release module

* bump ansible version_added

* Fix imports in rhsm_repository_release unit test
2018-12-06 20:16:18 +00:00
Dave Bendit
73640a4190 [docker_network] Adding scope and attachable flags (#49562)
Incorporating the abandoned work from PRs #35288 and #45552. Also adding in
the version checking from `docker_container.py`, which should be abstracted
out to `docker_common.py`.
2018-12-06 18:50:45 +00:00
lrrb
4f9f1754b4 fix: ensure than all item of a list of excluded files aren't checked (#45122)
* fix: ensure than list of excluded files aren't checked
* test: exclude a list of files
2018-12-06 10:13:31 -08:00
Jordan Borean
5392caee14
ansible-test: change Fedora 24 to 28 (#49586) 2018-12-06 16:30:11 +10:00
Adam Miller
6f90d62be3 fix py3 scope for unique filter errors, enable filters integration tests on rhel8 beta (#48961)
* fix py3 scope for unique filter errors, enable filters integration tests on rhel8 beta

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-12-06 16:13:26 +10:00
Jordan Borean
0420d606de
create local subversion server for tests (#49047)
* create local subversion server for tests

* fix sanity issues

* don't touch system config when bringing up site

* removed original setup files

* fix opensuse config
2018-12-06 13:41:05 +10:00
uberjew666
b72187cd2c Fixed win_route module (#46395)
* Changed $IpAddress to $Gateway

* Tweaked win_route unit tests

Checks to see if new static route has the correct gateway

* Create win_route.yaml

* Fixed incorrect variable name
2018-12-05 22:39:06 -05:00
Tim Rupp
1c3fa2b07f
Deprecate the bigip_asm_policy module (#49574)
Specific import and export modules should be used instead
2018-12-05 16:02:16 -08:00
Adam Miller
a5d98d69ff enable service integration test target for rhel8 beta (#48939)
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-12-05 18:07:18 -05:00
Adam Miller
6c61336a4b enable template target integration tests on rhel8 beta (#48940)
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-12-05 17:58:15 -05:00
Adam Miller
ea2b0114ea enable mysql related integration tests for rhel8 beta (#49163)
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-12-05 17:57:44 -05:00
Rhys Campbell
cdc0011333 mongodb_shard module and test exception (#43673)
* mongodb_shard module and test exception

* Update version_added

* Documentation improvements

* Correct yaml errors

* Correct lines over 160 chars

* Correct replicaset

* Minor documentation changes
2018-12-05 16:29:45 -05:00
John R Barker
be8b08f946 Mark cs_snapshot_policy unstable (#49543) 2018-12-05 09:38:48 -08:00
Anil Kumar Muraleedharan
dd004321d4 Refactoring code of cnos_portchannel as cnos_linkagg in tune with other vendors. (#49467)
* Refactoring code of cnos_portchannel as cnos_linkagg in tune with other vendors.
2018-12-05 11:03:42 -05:00
Mike Wiebe
49009879b9 Add explicit ansible_httpapi_port setting (#49314) 2018-12-05 09:51:49 -05:00
Josue David Hernandez
6d42c5020a Fix for changes in clearlinux (#49344)
* Fix for changes in clearlinux

clearlinux is now providing /etc/os-release file and ansible is identifying as NA
then this change allow ansible to find it

Signed-off-by: Josue David Hernandez Gutierrez <josue.d.hernandez.gutierrez@intel.com>

* Add changelog fragment for clearlinux changes

Signed-off-by: Josue David Hernandez Gutierrez <josue.d.hernandez.gutierrez@intel.com>
2018-12-05 13:13:40 +00:00
chris93111
7c8b5a407d VMware: Add option to modify disk type while cloning template (#47859)
* Add parameters to module vmware_guest for conversion of disk to thin or thick when vm is cloned or deployed with template

* unit test for convert clone vm

Co-Authored-By: chris93111 <christopheferreira@ymail.com>
2018-12-05 15:50:23 +05:30
Naval Patel
880390ca0a Added new module lxca_nodes for Lenovo XClarity Administrator (#46767)
* Added new module lxca_nodes
2018-12-05 10:18:36 +00:00
Christian Kotte
f3c4b2fc74 VMware: New module vmware_vcenter_statistics (#48084) 2018-12-05 15:46:42 +05:30
Toshio Kuratomi
c817bef3ae Fix for callback plugins on Python3 when a module returns dictionary keys that aren't strings
This fixes one of the problems reported in https://github.com/ansible/ansible/issues/49343

Upstream Python3 bug for the json traceback:
https://bugs.python.org/issue25457

and PR that may fix it:
https://github.com/python/cpython/pull/8011
2018-12-04 23:03:48 -08:00
Tim Rupp
60b75c2cfd
Adds ASM policy import module (#49526) 2018-12-04 21:34:55 -08:00
Tim Rupp
7a4c7b8c0f
Adds module for gtm topology regions (#49510) 2018-12-04 20:58:52 -08:00
Abhijeet Kasurde
1763c8123b
AWS: Add support for available db types (#48703)
Add several database types which are supported by AWS in valid engine type.

Fixes: #48623

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-05 08:59:36 +05:30
James E. King III
79c0e30c5a azure_rm_image: fix creation of image with data disks (#49394) 2018-12-05 09:36:34 +08:00
Wojciech Sciesinski
e4a3e73b15 Add win_psrepository (#48828)
* Add win_psrepository

* Small corrections

* Correct requiqurements - add NuGet

* Extend tests

* Post-review updates

* Post-review - updates 2

* Add empty RETURN section in documentation

* Add empty line at EOF

* Post-review updates 3

* Update tests to run in check_mode too

* Minor updates

* Correct installing/updating NuGet

* a few changes for review

* Remove copyrights

* Revert "Remove copyrights"

This reverts commit 2d687ec6a691d8d71358ae447e0fdc828976a767.
2018-12-04 22:47:28 +01:00
Robert de Bock
3247eec97a Fixes #49362 module dnf: install python3-dnf preferably over python2-dnf. (#49402)
* Create python3and2

Adding tests to see if dnf still works when python-2 and python-3 are installed.

* Update main.yml

Include the tests that run on python 2 and python 3, based on the package manager.

* Update dnf.py

Use python3-dnf by default, otherwise python2-dnf.

* Rename python3and2 to python3and2.yml

Rename.
2018-12-04 16:43:45 -05:00
Tim Rupp
c7dd13758e
Adds bigip_profile_analytics module (#49499) 2018-12-04 12:53:31 -08:00
Tim Rupp
caa6ed3c66
Adds ASM policy fetch module (#49494) 2018-12-04 11:24:34 -08:00
Tim Rupp
138690519d
Various small fixes for f5 ansible modules (#49492) 2018-12-04 11:15:49 -08:00
Sam Doran
40a5f7bfdf Add better error when k=v syntax is used with YAML in tasks (#41754)
* Add error message for k=v and YAML in a single task

Find the correct line, column, and position for k=v errors since they are different than the position reported initially.

Document bug in quoting syntax check.

* Change tense or error message

Since the error still exists, switch to present tense rather than past tense.

* Remove double spaces after periods in error messages.

http://www.slate.com/articles/technology/technology/2011/01/space_invaders.html

* Add changelog fragment

* Add tests for new error message

* Fix tests

* Add clarifying comments to unit test
2018-12-04 12:32:02 -05:00
Mike Wiebe
415292d618 Fix nxos_vxlan_vtep test (#49479) 2018-12-04 21:55:26 +05:30
Richard Levenberg
5cb39d0d57 Use System.Xml.XmlDocument.Load rather than Get-Content to avoid (#49206)
encoding errors when writing out XML

removing executable bit

refactor tests to handle sanity checking
2018-12-04 15:19:38 +00:00
Jon Bergli Heier
9c02ade536 rabbitmq_binding: Add support for state=absent (#48599)
* rabbitmq_binding: Add support for state=absent

* Add integration tests for rabbitmq_binding

* Update testcases

* Add changelog fragment
2018-12-04 12:42:18 +00:00
Abhijeet Kasurde
1b04571ea0
VMware: Fix module usages in module_utils (#49421)
* VMware: Fix module usages in module_utils
* Skip test for Python 2.6 as SSL context is not available in Python 2.6

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-04 10:11:29 +05:30
Mike Wiebe
dd984709f5 Fix issues related to track feature (#49454) 2018-12-04 09:57:35 +05:30
Xaroth
a6db7f7abd -Fix: The Ubuntu 14.04 image on Shippable runs an old version of python, causing issues with checking out bitbucket, adjust tests to compensate. (#49433)
-Add: Mention bitbucket dropping TLSv1 and TLSv1.1 support as per 01 Dec 2018, potentially causing issues with older clients.
2018-12-03 12:35:58 +00:00
Akshay Gaikwad
597e449afe Support for pids_limit parameter in docker_container module (#49319)
* Support for pids_limit parameter in docker_container module

This add pids_limit parameter support in docker_container module

Fixes #43337

Signed-off-by: Akshay <akshay@localhost.localdomain>

* Add changelog for pids_limit parameter

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Remove unnecessary lines of code

The map is needed if the names are different.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Update pids_limit option tests

It also run for docker-py < 1.10.0

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
2018-12-03 11:22:43 +00:00
John Kerkstra
672acbea68 Adds redshift_cross_region_snapshots module (#35527)
* add redshift_cross_region_snapshots module, unit tests.

* fix errors

* use ec2_argument_spec as the basis for the argument spec. fixed
metadata_version

* follow best practices by naming example tasks.

* code review changes

* fix linting errors

* Update version added
2018-12-03 08:34:53 +00:00
Felix Fontein
b0c7efcc6b ACME: add diff to acme_account, account_public_key to acme_account_facts, and general refactoring (#49410)
* Only one exit point.

* Refactoring account handling.

* Add diff support for acme_account.

* Insert public_account_key into acme_account_facts result and into acme_account diff.

* Add changelog.
2018-12-02 18:40:14 +01:00
Chris Archibald
62dd1fe29e New options of na_ontap_aggregate (#48906)
* add new options for na_ontap_aggregate

* add gpl line

* remove dup option

* Put files in wrong directory

* change unit test to match the request from PR 48941

* Changed for review comments

* pep8
2018-12-02 14:24:27 +00:00
Felix Fontein
34c57b4c42 ACME: fix bug introduced in #49266, work around problem with Pebble (#49407) 2018-12-02 10:07:21 +01:00
Brian Coca
fc71cde7d3
Yaml inventory more tolerant (#48883)
* make yaml inv more tolerant to comments
* add tests for bad inventory processing

fixes #47254
2018-11-30 22:04:39 -05:00
ftntcorecse
b4ce4e1571 Fortinet FortiManager Device Group Module (#46086)
* fmgr_device_group PR candidate

* fgmr_device_group PR candidate

* PR candidate

* PR candidate

* Fixing Edits.

* Fixing Edits.

* Fixing Authors

* Removed State Parameter and replaced with Mode, per request of justjais
2018-11-30 15:54:41 +05:30
Christian Kotte
68cafbda2b Improve vmware_dvswitch module (#48720) 2018-11-30 03:34:43 -05:00
Felix Fontein
2bd8e47247 add acme_inspect module (#48444) 2018-11-30 08:26:18 +01:00
Felix Fontein
3726d467ec Code style adjustment. (#49329) 2018-11-29 21:57:32 +01:00
Matt Martz
77befcf5d7
Do not allow addressing an import from handlers via notify. Fixes #48936 (#49317) 2018-11-29 13:50:07 -06:00
Paul Neumann
a914f494a8 ios_facts: Gather CDP neighbor data (#49129)
* ios_facts: Gather CDP neighbor data

* ios_facts: Create tests for ansible_net_neighbors
2018-11-29 14:05:17 -05:00
Ryan Brown
a51eca364f New module: AWS EC2 Launch Template (#46972)
* Add launch template integration tests
2018-11-29 13:59:10 -05:00
Pilou
62c05033d6 templar: ensure that exceptions are handled, fix 'AttributeError' (#48792)
* templar: ensure that exceptions are handled

* Fix AttributeError: object has no attribute 'message'

'message' attribute is deprecated since Python 2.6 and not available
with Python 3.

Simple reproducer:

    - hosts: localhost
      vars:
        not_json: "{{ 'test str' | from_json }}"
      tasks:
        - command: "echo {{ not_json }}"
2018-11-29 09:56:23 -05:00
Felix Fontein
1e0ab16247 Add basic unit tests for module_utils/acme.py. (#49103) 2018-11-29 09:32:15 +00:00
Yunge Zhu
ecd995496c new module: azure_rm_rediscache (#47914)
* add new redis cache module

* fix version

* fix lint
2018-11-28 15:59:55 -08:00
Anil Kumar Muraleedharan
7a81d859c5 Refactoring cnos_vlan in line with ios, eos etc. (#48924)
* Refactoring cnos_vlan in line with ios, eos etc.
2018-11-28 12:51:39 -05:00
Patrick Marques
d9a17e098c Digital Ocean Integration tests (#29960)
* Digital Ocean Integration tests
2018-11-28 12:07:47 +00:00
Abhijeet Kasurde
bc3e7bbeba
E325 Removal - Part II (#49196)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-28 13:55:52 +05:30
Mike Wiebe
374ca783bb nxos_logging message fix (#49205)
* nxos_logging message fix

* Remove rescue in block
2018-11-28 10:37:04 +05:30
Yunge Zhu
dc871bd493
add module azure_rm_virtualnetworkpeering (#47045) 2018-11-28 11:37:00 +08:00
Jordan Borean
098b18e846
win basic - fix issue when serializing PSObjects in result (#48860) 2018-11-28 12:17:49 +10:00
Yunge Zhu
e0af9b2ce0 new module cdnendpoint (#46796)
* new module cdnendpoint
2018-11-28 09:57:04 +08:00
Martin Krizek
d4568d97d4 Fix using vault encrypted data with jinja2_native (#49025)
Fixes #48950
2018-11-27 16:44:22 -05:00
Jordan Borean
694c505452
ansible-test: recursively scan setup dependencies (#49170)
* ansible-test: recursively scan setup dependencies

* removed need for default set()
2018-11-28 06:38:27 +10:00
Lars Kellogg-Stedman
bafc1f8a41 fix constructed functionality in openstack inventory plugin (#48833)
* test for openstack inventory constructed functionality

this adds unit tests for the compose, groups, and keyed_var features
of the openstack inventory plugin

* fix constructed functionality in openstack inventory plugin

The compose, groups, and keyed_groups functionality of the openstack
inventory plugin was broken:

- the plugin was not passing the correct variables to the
  Constructable methods for compose and groups
- the plugin was simply never calling the appropriate method for
  implementing keyed_groups

This commit fixes both issues.
2018-11-27 13:01:56 -05:00
Matt Clay
3b705efc93 Fix ansible-test skip warning message. 2018-11-27 07:50:22 -08:00
Abhijeet Kasurde
9b732df436
E325 removal - Part I (#49136)
Remove E325 from Amazon modules

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-27 20:41:01 +05:30
Matt Clay
704dae2cda
Fix lookup_passwordstore test skipping. (#49178)
* Fix lookup_passwordstore test skipping.

Skip all of RHEL instead of specific versions.
Skip all of CentOS < 7 instead of specific versions.

This makes the test more robust when testing newer versions.

Tests could be executed on RHEL if EPEL was installed during the test.
2018-11-26 23:25:27 -08:00
Matt Clay
6f29eafef4 Use virtualenv in pip test to remove distribute. 2018-11-26 16:40:58 -08:00
Matt Davis
8c1f701e6e
split PS wrapper and payload (CVE-2018-16859) (#49142)
* prevent scriptblock logging from logging payload contents
* added tests to verify no payload contents in PS Operational event log
* fix script action to send split-aware wrapper
* fix CLIXML error parser (return to -EncodedCommand exposed problems with it)
2018-11-26 15:28:21 -08:00
Toshio Kuratomi
61e5d04a60 Replace nose with pytest 2018-11-26 13:41:57 -08:00
Gregor Riepl
02893520a9 Cloudstack: Add password reset module (#47931) 2018-11-26 18:20:52 +01:00
Martin Krizek
48ffd8789f
Properly handle FieldAttribute.default if callable (#48992)
* Properly handle FieldAttribute.default if callable

Fixes #48673

* Add changelog...

* Add integration test

* Add aliases file
2018-11-26 18:14:46 +01:00
Matt Martz
46b465283c
Fix metadata comparison (#49133) 2018-11-26 10:45:48 -06:00
Zhikang Zhang
93c5781f61 pip: Fix the mistake replacement from 'distribute' to 'setuptools' (#47403)
* Fix the mistake replace from distribute to setuptools

* Add a testcase for this bug
2018-11-26 17:12:36 +01:00
Matt Martz
7287d396e2 Prevent metadata changes in a stable branch (#48994) 2018-11-26 14:51:39 +00:00
Christian Kotte
1ed9e72dc3 Improve vmware_portgroup_facts module (#47357) 2018-11-26 09:27:49 -05:00
Varun Chopra
90c3337316 Add win_partition (#46292)
* Added win_partition module

* Fixes sanity tests

* Requested changes minus changes in partition_size

* Removed trailing whitespace and fixed docstring

* Changes to parititon_size to allow variable units

* Stricter regex for partition_size
2018-11-26 11:01:59 +10:00
Tad Merchant
4b2356ff55 Ecs service force new deployment (#47983)
* Support UpdateService forceNewDeployment in ecs_service module

* Force update to be called if force_new_deployment set

* Fixes for review

* Add force_new_deployment option to ecs_service.py

cherrypicks changes from via/ansible
Adds tests for pull request #42518
fixes backwards compatability with boto<1.8.4

* change version_added to 2.8 for force_new_deployment

* remove extra lines from test

* remove more unnecessary whitespace
2018-11-24 11:26:44 +10:00
Stefan Horning
c3b059d61c Ecs service module health check settings (#47217)
* Added feature health_check_grace_period_seconds to ecs_service, this time with a botocore version check and some initial testing

* Only set health_check_grace_period_seconds when loadbalancers are defined

* Removed leftover commas and fix in test

* Removed blank line

* Minor improvements for ecs_service module

* Removed default (30) for health_check_grace_period_seconds param

* Changed botocore version allowed to 1.8.20 for health check param.

* Fix empty healthcheck failure
2018-11-23 22:35:25 +10:00
Will Thames
960ebd981f k8s append_hash (#48830)
* Add append_hash functionality to k8s module

append_hash adds a hash based on the contents of a ConfigMap
or Secret to the name - this enables immutable ConfigMaps and
Secrets.

* Provide k8s_config_resource_name plugin

The k8s_config_resource_name filter plugin provides a means of determining
the name of ConfigMaps and Secrets created with append_hash

* Add changelog fragment

* fix failing tests

* Update openshift version needed for append_hash
2018-11-22 08:14:43 +00:00
Jordan Borean
a568bbed3c
win_mapped_drive - refactor module and docs (#48642)
* win_mapped_drive - refactor module and docs

* Updated code to work with become and split tokens

* use win_credential_manager instead of cmdkey

* updated credential manager module name

* harden the system token impersonation process
2018-11-22 08:12:41 +10:00
Jordan Borean
8e92cca139
win_credential: new module to manage credentials (#48840)
* win_credential_manager: new module to manage credentials

* fix sanity issues and removed CredSSP references

* renamed module to win_credential

* fix typo on test variable

* fix sanity ignore line
2018-11-22 06:55:48 +10:00
Michael Cassaniti
10af3874b5 win_snmp: Initial commit (#45710)
* win_snmp: Initial commit

* win_snmp: Better handling of lists

* win_snmp: Documentation fixes

* win_snmp: Updated documentation to match parameters

* win_snmp: Added integration tests

* win_snmp: Fixed typo in test

* win_snmp: Adjusted parameter checks to match documentation

* win_snmp: Updated option descriptions to be full sentences

* win_snmp: Better type checking and output suppression

* win_snmp: Fixed unset managers and communities

* win_snmp: Fixed skipping default registry keys

* win_snmp: Migrated to using add/set/remove action from replace

* win_snmp: Fixed check mode

* win_snmp: Fixed setting action and documentation. Expanded tests.

* win_snmp: Efficiency changes and documentation cleanup
  * Added example of explicitly setting an empty set of managers to
documentation
  * Made sure set will only remove items if there is a list of items
provided. This list can be of length 0
  * Improved efficiency in selecting next index for SNMP manager
  * Updated tests

* win_snmp: Added output of permitted managers and community strings

* win_snmp: Documentation fix
2018-11-22 06:55:10 +10:00
John R Barker
75407d3e43
Validate DOCUMENTATION.author (#48993)
* Validate DOCUMENTATION.author

Ensure that author line includes a GitHub account
2018-11-21 17:29:29 +00:00
Brian Coca
91150423f4
ignore netapp tests when no libs (#48941)
* ignore tests when no libs
2018-11-21 11:51:40 -05:00
abarbare
70fff13a6e feat: meaningful error message scaleway image not found (#48829) 2018-11-21 11:40:15 +00:00
John R Barker
e7da4975cc
Botmeta validate path macros (#48980)
BOTMETA validation - use path macros

Rather than hard coding the list of path macros, read them directly from
BOTMETA
2018-11-21 11:15:56 +00:00
ftntcorecse
fb7b6f9521 Fortinet FortiManager Device Add Module (#45954)
* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_fwobj_address PR candidate

* Grammar

* grammar changes

* pylint changes

* Fixing Authors
2018-11-21 12:05:33 +05:30
ftntcorecse
050a2c51dd Fortinet FortiManager Device Config Module (#46080)
* fmgr_device_config PR candidate

* fmgr_fwobj_address PR candidate

* PR candidate

* Resolving Edits

* Resolving Edits

* Fixing Authors
2018-11-21 12:03:38 +05:30
ftntcorecse
1da3c5c302 Fortinet FortiManager Firewall Objects - Addresses (#46084)
* fmgr_fwobj_address PR candidate

* fmgr_fwobj_address PR candidate

* PR candidate

* PR candidate

* Adding requested changes by @samccann

* minor issue...

* minor pylint issue

* More changes from @samccann

* more grammar

* Author Mention Change

* Fixing Authors
2018-11-21 12:00:39 +05:30
ftntcorecse
86222fd4c4 Fortinet FortiManager HA Configuration Module (#46085)
* fmgr_ha PR candidate

* PR candidate

* PR candidate

* PR candidate

* PR candidate

* Fixing Edits.

* Fixing Edits.

* Fixing Edits.

* Fixing Edits.

* Fixing Authors
2018-11-21 11:57:04 +05:30
Tim Rupp
212b48b6fd
Adds module to configure ldap device auth on a bigip (#48974) 2018-11-20 22:15:50 -08:00
ftntcorecse
44b20fbf96 Fortinet Firewall Object - Virtual IPs (#47637)
* PR Candidate

* PR Candidate - pylint fix

* PR Candidate minor pylint fix v2

* Fixed Odd type annotation -- needed double comments

* Missed one of the # type: comments in fixture...

* Fixing Edits. Nixing Stale CI Flag

* Fixing Edits.

* Fixed Authors -- Fixed Changes.

* Fixing pep8...

* Fixing a description
2018-11-21 11:19:58 +05:30
ftntcorecse
4862a4aeb4 FortiManager security profile group module (#46220)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
2018-11-21 11:18:19 +05:30
ftntcorecse
64c4881d58 FortiManager DNS security profile (#46239)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Initial commit for FMG DNS security profile

* Fixing pep8 line too long in unit test

* Removing excess modules and unit tests

* Fixing trailing white space for dns module

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
2018-11-21 11:17:37 +05:30
ftntcorecse
37e932c4ee Fortinet FortiManager IPv4 Policy Module (#47638)
* Needs unit test fix -- the "delete" calls a GET command and another function to get policy ID of a firewall policy before deleting it. Nested functions like this, where a GET occurs to determine a new call, breaks the unitTestGen output. Need to figure out what's going on, and adjust the generator.

* PR Candidate

* PR Candidate (fixes)

* Reverting

* Fixing Edits.

* Fixing Authors - Fixing Requested Changes
2018-11-21 11:14:47 +05:30
ftntcorecse
d7e1e6429c FortiManager Web Application Firewall Security Profile (#46967)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Initial commit for FMG Security Profile Web Application Firewall

* adding extra line at bottom for pep8 conditions

* Adding descriptions to documentation

* Fixing more pep8 issues

* New commit for new PR

* Removing todo in documentation

* Changing module name in documentation to match actual module name

* Fixing yaml syntax for long choices list

* Fixing yaml syntax for long choices list

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
2018-11-21 10:46:13 +05:30
ftntcorecse
a171b80a0c FortiManager Web Filter Security Profile (#47150)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Initial commit for FMG Security Profile Web Application Firewall

* adding extra line at bottom for pep8 conditions

* Adding descriptions to documentation

* Fixing more pep8 issues

* New commit for new PR

* Removing todo in documentation

* Changing module name in documentation to match actual module name

* Fixing yaml syntax for long choices list

* Fixing yaml syntax for long choices list

* Initial commit for fmgr web filter security profile

* Fixing pep8 syntax issues

* Fixing documentation yaml syntax errors with choices on new lines

* Fixing documentation yaml syntax errors, removing Todo comments

* Fixing choices additional tab

* Fixing choices on multiple lines

* Fixing choices on multiple lines

* Adding yaml block scalar for multiline choices

* Changing YAML syntax for multiline to YAML sequence for choices

* Fixing all sanity test errors

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
2018-11-21 10:45:00 +05:30
ftntcorecse
199cd1bc77 FortiManager SSL SSH Security Profiles (#47152)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Initial commit for FMG Security Profile Web Application Firewall

* adding extra line at bottom for pep8 conditions

* Adding descriptions to documentation

* Fixing more pep8 issues

* New commit for new PR

* Removing todo in documentation

* Changing module name in documentation to match actual module name

* Fixing yaml syntax for long choices list

* Fixing yaml syntax for long choices list

* Initial commit for fmgr web filter security profile

* Initial commit for SSL and SSH security profiles in FMG

* Fixing pep8 syntax issues

* Adding better playbook example

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
2018-11-21 10:44:35 +05:30
Tim Rupp
cd02b3637c
Removes remaining nose usage from f5 unit tests (#48973) 2018-11-20 20:34:01 -08:00
Tim Rupp
c1118389cf
Remove nose usage from a bigip unit test (#48964) 2018-11-20 15:49:29 -08:00
Matt Martz
9773a1f289
Add a Singleton metaclass, use it with Display (#48935)
* Add a Singleton class, use it with Display

* update six import

* Move remaining failes to display singleton

* Fix rebase issues

* Singleton improvements

* Add code-smell for 'from __main__ import display'. ci_complete

* s/self/cls/g

* Add docs for no-main-display

* Address linting issues

* Add changelog fragment. ci_complete

* Implement reentrant lock for class instantiation in Singleton

* Add Display singleton porting guide
2018-11-20 17:06:51 -06:00
Sloane Hertel
54a2f21f93 Fix comparison of determining which rules to purge by ignoring descriptions (#48443)
AWS uses rule type, protocol, port range, and source as an idempotent identifier.
There can only be one rule with that unique combination. Rules that differ only by description are allowed but overwritten by AWS.
Add a test

Co-authored-by: Will Thames <will@thames.id.au>
2018-11-21 08:04:10 +10:00
Tim Rupp
fb782fa3e9
Adds the bigip_password_policy module (#48951)
This module can be used to manage password policy settings on a BIG-IP
2018-11-20 11:59:02 -08:00
Björn
9c71f176f3 Make wait_for return matched groups defined in search_regex. Closes #… (#47690)
* Make wait_for return matched groups defined in search_regex. Closes #25020.

* Fix formatting issues.

* Fix issues raised in review.

- Use output_dir instead of hardcoded /tmp for temp files
- Sleep for only 3s instead of 10s
- Revert indent change
2018-11-20 14:19:17 -05:00
David Soper
9f1b75db0e Ucs disk group policy (#43578)
* ucs_disk_group_policy module and integration tests

* Additional refactor based on review in other modules.

* Fix issue with automatic config and add virtual_drive config.
Integration tests added for automatic config and virtual_drive config.

* Code review updates (documentation items)

* update version added to 2.8
2018-11-20 13:34:49 +01:00
Mike Wiebe
a721572206 Fix issues with nxos_os_install module (#48811)
* Use expect module to copy files

* Remove old and redundant upgrade files

* Return error message instead of code

* Cleanup copy command code

* Fix force issue in nxos_install_os

* new nxos_install_os integration tests

* Uncomment transport tests

* Revert negative test change

* Remove combined option that is no longer required

* Make shippable happy

* Add n5k test files
2018-11-20 10:14:15 +05:30
Tim Rupp
10095a397c
Adds the bigip_monitor_gateway_icmp module (#48915) 2018-11-19 19:11:00 -08:00
Tim Rupp
fdbc0e5798
Adds the bigip_dns_cache_resolver module (#48914) 2018-11-19 19:05:24 -08:00
Tim Rupp
e7d1c0fb77
Removes f5-sdk references from bigip modules (#48911) 2018-11-19 19:02:02 -08:00
Jordan Borean
e62edfc796
Ansible.Basic - fix deprecate return value (#48908) 2018-11-20 09:26:16 +10:00
Tim Rupp
8e6c3b06b8
Adds the ip_intelligence_policy parameter to vs module (#48903) 2018-11-19 15:24:44 -08:00
Tim Rupp
e6d586f703
Change port to allow strings too (#48899)
The port technically supports an asterisk, but the argument spec was
requiring integers only.
2018-11-19 13:44:20 -08:00
Matt Davis
9973bea504 fix failing tests
* removal of deprecated win_get_url arg `skip_certificate_validation` broke win_unzip tests
2018-11-19 11:09:53 -08:00
Adam Miller
2b878546d3 fix yamllint sanity
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-19 10:13:07 -08:00
Adam Miller
4a06e95671 dnf to support modularity module appstream specs
Fixes #48743

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-19 10:13:07 -08:00
Brian Coca
87e44a7ed1
better handling of bad type in config (#48821)
* better handling of bad type in config

 fixes #22468, fixes #22476
2018-11-19 11:45:45 -05:00
tchernomax
943edb3319 apt: add policy_rc_d option (#47191) 2018-11-19 14:45:48 +00:00
Chris Archibald
50808ffa8f Add common files for ONTAP and SOLIDFIRE unit tests (#48739)
* And unit test files

* Changes to netapp.py

* Matt's changed, and pep8 change for test_netapp.py
2018-11-19 14:43:32 +00:00
Felix Fontein
3bb41ccb8e docker_* tests: check API version (#48620)
* Check minimal API and docker-py versions for all docker_* tests.

* Improve docker_swarm creation/destruction for tests.

* Fail when conditions aren't met.

* Don't hardcode address for advertise_addr.
2018-11-19 10:01:40 +00:00
Felix Fontein
891687284f docker_* modules: improve diff (#48546)
* Add difference tracking tool

* Improve --diff mode for docker_container.

* Improve diffs of sets by ordering the sets.

* Rewrite imports, get rid of HAS_DOCKER_PY_x variables and use docker_version instead.

* Rename container -> active (more generic).

* Add --diff for docker_volume. Change old diff output.

* Add --diff for docker_network. Change old diff output.

* Add --diff for docker_swarm_service.

* Add changelog.

* Add entry for porting guide on docker_network and docker_volume.
2018-11-19 09:59:54 +00:00
Dag Wieers
f69e3e1cec win_get_url: Rewrite using AnsibleModule (#48390)
* win_get_url: Rewrite using AnsibleModule

* Fix sanity issue

* Implemented review suggestions

* Try something else

* fix circular dependency issues
2018-11-19 08:17:13 +10:00
jhawkesworth
361acd3547 win_say: Port to use CSharpUtil AnsibleBasic (#48361)
* port win-say to use CSharpUtil AnsibleBasic and add warning when requested voice not found

* win_say: fixes following code review: use C# style properties consistently; prefix changelog fragments

* fix invalid yaml in change log fragment

* win_say: fixes following code review: use generic module parameter validation where possible

* remove redundant setting of Result.changed to false, simplified some logic for readability.

* fix serialisation issue when message text is drawn from a file; allows tests to be run not in check mode and fix up some test descriptions
2018-11-19 07:07:12 +10:00
Jordan Borean
fd4b282f6f
Ansible.Basic.cs - fix check mode run with nested spec (#48838) 2018-11-17 18:15:36 +10:00
Matt Clay
a41c0405a7
Add CI platform: rhel/8.0 (#48835) 2018-11-16 22:06:19 -08:00
Susant Sahani
88dcb11695 nmcli: Introduce IPIP Tunnel (#45933)
This work enables to add ipip tunnel via nmcli module

```
  - nmcli:
       state: present
       type: ipip
       conn_name: ipip_test1
       autoconnect: yes
       ip_tunnel_dev: enp0s8
       ip_tunnel_local: 192.168.1.2
       ip_tunnel_remote: 192.168.1.5
```

version2: Added tests
Signed-off-by: Susant Sahani <susant@redhat.com>

Rebase
2018-11-16 23:57:11 -05:00
Adam Miller
4771ccc24b enable rhel8 beta for testing in ec2 (#48831) 2018-11-16 19:09:27 -08:00
Matt Clay
0826a00803 Add --raw option to ansible-test shell command.
It is currently supported only with the `--remote` option.

This makes it easier to troubleshoot new instances which are not
yet supported by the setup scripts used by ansible-test.
2018-11-16 17:38:15 -08:00
Matt Clay
8066acc90c
Support skip of platforms by version in tests. (#48826)
* Support skip of platforms by version in tests.

Previously a remote platform could be skipped completely using the alias:

`skip/{platform}` such as `skip/rhel`

Now a specific platform version can be skipped using the alias:

`skip/{platform}{version}` such as `skip/rhel7.6`

This feature is available for platforms specified with the `--remote` option.

* Add skip by version to the docs.
2018-11-16 16:38:47 -08:00
Tim Rupp
9af5724bd4
Remove the f5-sdk from bigip_remote_syslog (#48539) 2018-11-16 15:13:08 -08:00
Matt Davis
97f97339f7
re-enable batch tests for win_script (#48822)
* skipped on Server 2008 since batch interpreter is busted under UTF8 codepage
* see https://github.com/ansible/ansible/issues/21915 for more details
2018-11-16 11:23:53 -08:00
Tim Rupp
dd2629ff0b
Adds new module for gtm topology records (#48817) 2018-11-16 10:05:23 -08:00
Tim Rupp
0e1dca6e8f
Adds the bigip_imish_config module. (#48779)
This can be used to manage bgp configuration on a BIG-IP.
2018-11-16 09:17:57 -08:00
David Soper
62b165c8d3 UCS managed objects module for direct control of any object (#44470)
* UCS managed objects module for direct control of any object and properties.

* Avoid checks for parent info or passwords in property compares

* Planned for 2.8

* try except for imports
2018-11-16 12:46:41 +00:00
Will Thames
aaf29c785f Provide Kubernetes resource validation to k8s module (#43352)
* Provide Kubernetes resource validation to k8s module

Use kubernetes-validate to validate Kubernetes resource
definitions against the published schema

* Additional tests for kubernetes-validate

* Improve k8s error messages on exceptions

Parse the response body for the message rather than returning
a JSON blob

If we've validated and there are warnings, return those too - they
can be more helpful

```
"msg": "Failed to patch object: {\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},
       \"status\":\"Failure\",\"message\":\"[pos 334]: json: decNum: got first char 'h'\",\"code\":500}\n",
```
vs
```
"msg": "Failed to patch object: [pos 334]: json: decNum: got first char 'h'\nresource
        validation error at spec.replicas: 'hello' is not of type u'integer'",
```

* Update versions used

In particular openshift/origin:3.9.0

* Add changelog for k8s validate change
2018-11-16 12:44:59 +00:00
lwm
ae0054a79e Add new linode_v4 module. (#46151)
Refs:
  * https://github.com/ansible/ansible/issues/36348
  * https://github.com/ansible/ansible/pull/41875
2018-11-16 12:39:05 +00:00
Felix Fontein
afded1c778 Use force_kill instead of stop_timeout to fasten container cleanup. (#48733) 2018-11-16 12:37:12 +00:00
Matt Clay
e6ffc4f89a Remove CI platform: freebsd/10.4 2018-11-16 00:46:09 -08:00
Anton Nikulin
9770ac70f9 FTD modules: upsert functionality and bug fixes (#47747)
* FTD modules: bug fixes and upsert functionality

* Fix sanity checks

* Fix unit tests for Python 2.6

* Log status code for login/logout

* Use string formatting in logging
2018-11-16 11:55:36 +05:30
Matt Clay
6745ee7cc8 Switch tests from RHEL 7.5 to 7.6. 2018-11-15 21:42:49 -08:00
Zim Kalinowski
e9c91ebd09
updating container service to 4.2.2 (#48768) 2018-11-16 12:38:54 +08:00
Dan
01b06dd5f2 Added track option for nxos_static_route module (#48710) 2018-11-16 09:33:22 +05:30
Tim Rupp
a7b7c07ad2
Adds bigip_file_copy module (#48770)
This module can be used to copy files to specific datastores on
a bigip
2018-11-15 19:42:53 -08:00
Matt Clay
feb5b0b299 Fix unit test issues with pytest >= 4.0.0. 2018-11-15 10:06:07 -08:00
Xaroth
87d10b9b78 Include dependency role names in role_names. (#46483)
* -Change: Include dependency role names in `role_names`.
-Add: `play_role_names` magic variable to include only explicitly named roles (formerly `role_names`).
-Add: `dependent_role_names` magic variable to include all dependency names for all roles.

* -Change: use the ansible_ prefix for new magic variables.
-Change: keep `role_names` as a deprecated variable, using the old functionality.

* -Add: changelog fragment for the role_names rework.

* -Add: Tests for the role_names (and ansible_*role_names) special variables

* -Fix: resolve erroneous documentation snippet that was introduced after rebasing.

* -Fix: explicitly sort to ensure list comparison works in test.
2018-11-15 10:01:29 -05:00
Zim Kalinowski
406da7a568
upgrading azure-mgmt-compute to the latest (#47601)
* upgrading azure-mgmt-compute to the latest
2018-11-15 15:24:42 +08:00
Hiroyuki Matsuo
60dcfc3a09 Add rabbitmq_vhost_limits module (#37821)
* Improve code structure
* Add author for module
* Now returns some values
* Update module's metadata
* Copy test case of rabbitmq_lookup
* Add test cases for rabbitmq_vhost_limits
* Minor fixes in documentation
* Fix module's return values
* Refactor module
* Improve test case
* Revise English in documentation
* Disable returning values because it's useless & unnecessary
* Work on failures: E261: match PEP8 styles
* Work on failures: E312: add RETURN section in documentation
2018-11-15 10:10:41 +05:30
Matt Clay
de11b473a6 Revert "Relax ansible-test python version checking."
This reverts commit d6cc3c4187.
2018-11-14 17:39:00 -08:00
Zim Kalinowski
dfe554eaf8 upgrading network packages (#47639) 2018-11-15 09:26:35 +08:00
Kyle Knapp
e822450a79 Add integration tests for iam_policy (#40115)
* Add integration tests for iam_policy

* Fix indentation and ignore errors during clean up

* Mark iam_policy integration tests as unsupported by CI

* Add policies to a temporary folder that is cleaned up

* Add tasks to verify that iam_policy can remove policies from users, roles, and groups
2018-11-14 20:14:19 -05:00
John Imison
54c54fc960 RabbitMQ publisher module (#44718)
* RabbitMQ basic publisher

* Split out of a module_util. Preparing for binary posts.

* Can now send a file to the queue.

* Allowing an empty queue to be used so RabbitMQ returns a random queue.

* Added RETURN docstring.

* Updated and added tests.  Now returns a dictionary with msg, content_type and queue published to.

* Extra tests and introduced a none url method of providing server host details.

* Added testing and errors for url/host parameters.

* Updating RETURN sample

* Added an image file for testing binary publishing.

* Minor changes to test.

* Added filename key/value to headers if a binary file is published.

* Adding ability to specify headers.

* Renaming to rabbitmq_publish

* Changed tests to reflect name, and, preparing for testing headers.

* Updated some documentation

* Minor pip install update

* Modifications after feedback.

* Updates based on feedback.

* Fixing pep8 issue.

* Updating module and module_util name to amqp.

* Reverting back to rabbitmq_publish naming.

* Minor addition to notes.
2018-11-15 11:06:54 +10:00
Matt Clay
136a2cca2f Use state: latest for dpkg_selections test.
We don't need to test with `upgrade: dist`, since we're not trying
to test the `apt` module. We just need to make sure the hold set
by the `dpkg_selections` module is working.

This change will avoid updating all the packages on the system,
which is slow, unnecessary, and can cause the installed python
to be changed.
2018-11-14 17:03:07 -08:00
Martin Krizek
0c86df33a4 apt: disable ubuntu repos to not change test env 2018-11-14 15:04:58 -08:00
Matt Clay
fa53b4805b Fix ansible-test interpreter tracking.
Track the interpreter for each copy of the injector by the interpreter
path instead of the interpreter version. This avoids the possibility
of mixing different interpreters with the same version.
2018-11-14 13:58:03 -08:00
Matt Clay
aa7fe919d3 Fix ansible-test merge change detection. 2018-11-14 12:27:40 -08:00
Matt Clay
d6bf45cd9d Correct ansible-test injector python behavior.
Inject a symlink to the correct python into the copied injector
directory instead of altering the shebang of the injector. This
has the side-effect of also intercepting `python` for integration
tests which simplifies cases where it needs to be directly invoked
without collecting code coverage.
2018-11-14 12:17:09 -08:00
Matt Clay
9979a32e5c Fix passing of env vars to Shippable. 2018-11-14 10:50:31 -08:00
Ed Costello
b70d5d9aee [AWS] ses rule set module for inbound email processing (#42781)
* Add module ses_rule_set for Amazon SES

* Update behaviours and naming to be consistent with other aws_ses_ modules.

* Add global lock around tests using active rule sets to prevent intermittent test failures.

* Fix deletion of rule sets so that we don't inactivate the active rule set
when force deleting an inactive rule set.
2018-11-14 12:15:24 -05:00
Ryan Brown
405d6d605f [AWS] Enable Route53 integration tests (#46228) 2018-11-14 11:40:38 -05:00
saichint
ba2c8a24e2 add N3K-F type to nxos platforms (#47944) 2018-11-14 10:43:35 -05:00
Martin Krizek
907ff2f26c Add new meta task end_host (#47194)
* Add new meta task  end_host
2018-11-14 09:46:25 -05:00
Sumit Jaiswal
feac12f9b7
fix nios modules (#48559)
* resolves 47839

* update name

* update name

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* update name tests

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* update name tests

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* modifying the condn

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2018-11-14 18:05:25 +05:30
Zim Kalinowski
7db4352f6e
Adding missing idempotence support in load balancer (#45548)
idempotence
2018-11-14 16:57:03 +08:00
Matt Clay
1a3bf09f8a
Add test to require docs for action plugins. (#48376) 2018-11-13 22:52:36 -08:00
Matt Clay
eec21a3d12 Use correct interpreter for ansible-test injector. 2018-11-13 22:50:34 -08:00
Matt Clay
c25db4ee8d Add change classification for powershell wrappers. 2018-11-13 22:47:06 -08:00
Jordan Borean
9ac89af355
win_chocolatey - move over to AnsibleModule and add allow_multiple (#48370) 2018-11-14 16:18:34 +10:00
Martin Krizek
d6bd842c5f
Run "update foo*" integration test on dnf too (#48607) 2018-11-14 06:57:53 +01:00
Matt Clay
d6cc3c4187 Relax ansible-test python version checking. 2018-11-13 19:45:18 -08:00
Jordan Borean
6898f02431
win_shortcut: add run as admin and fix shell folder idempotency (#48584) 2018-11-14 12:15:04 +10:00
Matt Martz
8765d2a8e8
code-smell test that can find deprecated config items (#46273)
* Start of code-smell test that can find deprecated config items

* Strip deprecated.version from config item

* Don't use os.walk, rely on explictly passed list of files

* Properly disable the test

* Add docs

* Make config an orphan
2018-11-13 09:29:39 -06:00
Felix Fontein
b1acabcd03 docker_container: fix tests and idempotency for init and shm_size (#48551)
* Fix tests: use same command if not testing command option.

* Fix idempotency of init option.

* Fix shm_size idempotency (it is included in inspect results from docker API version 1.22 on).

* Add changelog.
2018-11-13 13:07:36 +00:00
Will Thames
4e1e9589b5 Add wait functionality to k8s module (#47493)
Provide wait and wait_timeout parameters and wait for certain
resource kinds to become available.
2018-11-13 12:50:15 +00:00
Abhijeet Kasurde
03f71e778b
Refactor ingate module_utils (#47959)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-13 17:42:53 +05:30
Olivier Bourdon
cf3483e752 Add tests filters (#43221)
This will allow tests to be carried out condtionally if necessary
using regexp include and/or exclude filters
Reorganize imports into alphabetical order for easier insertion
2018-11-13 11:16:49 +00:00
Dag Wieers
24d7b4a660
Various small fixes to MSC modules and tests (#48417) 2018-11-13 09:01:45 +01:00
Felix Fontein
0206a46e1d docker_* modules: updating argument_spec (#48491)
* Updating argument_spec for docker_* modules.

* Adjust docker_network to work with new recursive argument_spec.

* Adjust device IO limits to recursive argument_spec.

* Improve test (test Ansible's cast from str to int).

* Adjust healthcheck options construction.

* Remove superfluous check.

* Make flake8 happy.

* Simplify comparison.
2018-11-12 11:33:42 +00:00
Felix Fontein
feb60b947c Docker volume fix labels (#48536)
* Add integration test for labels (which fails).

* Changing labels from list to dict.

* Add changelog.
2018-11-12 11:24:07 +00:00
Tim Rupp
5e7a02d574
Remove f5-sdk from bigip_vcmp_guest (#48541) 2018-11-11 13:58:11 -08:00
Tim Rupp
62332155b5
Removes the f5-sdk from bigip_routedomain (#48543) 2018-11-11 11:29:21 -08:00
Tim Rupp
708c2b4b71
Removes the f5-sdk from bigip_selfip (#48544) 2018-11-11 11:14:56 -08:00
Tim Rupp
452cf2b1a3
Adds the bigip_dns_resolver module (#48540) 2018-11-11 11:09:53 -08:00
Tim Rupp
232fcb9f34
Adds the bigip_profile_server_ssl module (#48532) 2018-11-11 10:57:26 -08:00
Tim Rupp
69d24cc7fc
Remove f5-sdk from bigip_profile_udp module (#48534) 2018-11-11 10:40:25 -08:00
Tim Rupp
d89fa23412
Remove f5-sdk from bigip_profile_tcp module (#48533) 2018-11-11 10:40:02 -08:00
Tim Rupp
b292f8338f
Corrects parameters to flatten correctly. (#48531)
Also fixes unit tests and adds other code patterns that other f5
modules use
2018-11-11 10:39:44 -08:00
Tim Rupp
4e2891e38f
Adds bigip_profile_fastl4 module (#48527) 2018-11-10 22:16:26 -08:00
Tim Rupp
6134281d28
Remove f5-sdk from bigip_profile_oneconnect (#48530) 2018-11-10 22:13:16 -08:00
Tim Rupp
875d83df50
Fixes unit tests in bigip_profile_http_compression (#48529) 2018-11-10 22:12:53 -08:00
Tim Rupp
77afc32621
Adds new parameters to bigip_profile_http (#48528) 2018-11-10 22:12:19 -08:00
Tim Rupp
f126db7f21
Remove f5-sdk from bigip_profile_client_ssl (#48525) 2018-11-10 21:59:56 -08:00
Tim Rupp
50fb2d7795
Remove f5-sdk from bigip_profile_dns (#48526) 2018-11-10 21:46:19 -08:00
Tim Rupp
ed818edd5a
Remove f5-sdk from bigip_partition. Fix partition descriptions. (#48522) 2018-11-10 21:46:04 -08:00
Tim Rupp
0c3f168087
Remove f5-sdk from bigip_policy_rule (#48524) 2018-11-10 21:35:34 -08:00
Tim Rupp
dbbc752d56
Removes the f5-sdk from bigip_policy (#48523) 2018-11-10 21:33:42 -08:00
Tim Rupp
4dc5a26293
Adds new params to bigip_node. Fix unit tests. (#48521) 2018-11-10 21:16:00 -08:00
Tim Rupp
1e57b91c35
Add new parameters to bigip monitor modules (#48520) 2018-11-10 20:34:48 -08:00
Tim Rupp
240d2baebd
Removes f5-sdk from bigip_management_route (#48519) 2018-11-10 20:34:15 -08:00
Tim Rupp
73ec37b6b6
Remove f5-sdk from bigip_log_destination (#48517) 2018-11-10 20:10:07 -08:00
Tim Rupp
94d04b7da4
Remove the f5-sdk from bigip_irule (#48516) 2018-11-10 20:09:05 -08:00
Tim Rupp
25344da0ad
Remove f5-sdk from bigip_log_publisher (#48518) 2018-11-10 19:54:59 -08:00
Tim Rupp
a260e86729
Remove f5-sdk from bigip_iapp_service module (#48511) 2018-11-10 19:23:44 -08:00
Tim Rupp
1a226a86b5
Remove f5-sdk from bigip_iapplx_package (#48513) 2018-11-10 19:14:49 -08:00
Tim Rupp
4579b6516f
Remove f5-sdk from bigip_iapp_template (#48512) 2018-11-10 19:12:35 -08:00
Tim Rupp
8dabd0cde3
Remove f5-sdk from bigip_gtm_virtual_server (#48508) 2018-11-10 18:49:46 -08:00
Tim Rupp
ce06cfe8ef
Remove f5-sdk from bigip_gtm_wide_ip (#48509) 2018-11-10 18:48:52 -08:00
Tim Rupp
4a74c1fec6
Add new features to gtm server module (#48507)
Remove the f5-sdk. Fix unit tests. Add new prober parameters
2018-11-10 18:34:48 -08:00
Tim Rupp
364ed4e660
Remove f5-sdk from bigip_hostname (#48510) 2018-11-10 18:23:10 -08:00
Tim Rupp
bfd8dc56ea
Remove the f5-sdk from bigip_gtm_pool_member (#48506) 2018-11-10 18:22:55 -08:00
Tim Rupp
830f1880b7
Remove f5-sdk from bigip_gtm_pool (#48505) 2018-11-10 18:03:39 -08:00
Tim Rupp
98a15013dc
Remove f5-sdk from bigip_gtm_monitor_tcp_half_open (#48504) 2018-11-10 18:03:26 -08:00
Tim Rupp
8a57ae1702
Remove f5-sdk from bigip_gtm_monitor_tcp (#48503) 2018-11-10 18:03:14 -08:00
Tim Rupp
530a21dfc0
Remove the f5-sdk from bigip_gtm_monitor_https (#48502) 2018-11-10 17:39:30 -08:00
Tim Rupp
0f2ea94c00
Remove f5-sdk from bigip_gtm_monitor_firepass (#48499) 2018-11-10 15:32:07 -08:00
Tim Rupp
ce1c88a7b8
Remove the f5-sdk from bigip_gtm_monitor_http (#48500) 2018-11-10 15:26:33 -08:00
Tim Rupp
75661cc5f6
Removes the f5-sdk from bigip_gtm_monitor_external (#48498) 2018-11-10 15:08:47 -08:00
Tim Rupp
7664d1d91c
Removes the f5-sdk from bigip_gtm_monitor_bigip (#48497) 2018-11-10 15:03:03 -08:00
Tim Rupp
7ce3d7c8ef
Removes the f5-sdk from bigip_gtm_global (#48496) 2018-11-10 14:53:54 -08:00
Tim Rupp
3186f2b576
Removes the f5-sdk from bigip_gtm_datacenter (#48495) 2018-11-10 14:53:41 -08:00
Tim Rupp
3132ce8404
Fixes unit tests and move client variable (#48494) 2018-11-10 14:42:01 -08:00
Tim Rupp
7d11e6e3e5
Adds token cleanup and fixes unit tests (#48493) 2018-11-10 14:40:14 -08:00
Tim Rupp
1afbe4d61b
Remove the f5-sdk from bigip_firewall_port_list module (#48492) 2018-11-10 14:39:26 -08:00
Tim Rupp
fd0f3ad648
Fixes unit tests for bigip_firewall_policy module (#48490) 2018-11-10 14:39:10 -08:00
Tim Rupp
112ce6da89
Adds bigip_firewall_dos_vector module (#48487)
This module can be used to manage DoS vectors in a DoS profile or
device config
2018-11-10 14:08:31 -08:00
Tim Rupp
d1288f9ea1
Adds bigip_dns_zone module (#48482)
This module can be used to manage zones on a BIG-IP. The managed
zones should **not** be confused with ZoneRunner zones as they are
not the same.
2018-11-10 13:14:57 -08:00
Tim Rupp
9a396cc45d
Fixes unit tests broken in ansible 2.8 and minor module cleanup (#48484) 2018-11-10 13:06:07 -08:00
Tim Rupp
1378e9fca2
Removes the f5-sdk from bigip_firewall_address_list module (#48483) 2018-11-10 12:58:12 -08:00
Tim Rupp
b5ee96a576
Adds bigip_dns_nameserver module (#48480)
This module can be used to manage DNS nameservers (usually used for
DNS express) functionality on a BIG-IP.
2018-11-10 12:56:48 -08:00
Tim Rupp
0c14b75eec
Remove f5-sdk from bigip_device_trust (#48479) 2018-11-10 12:07:49 -08:00
Tim Rupp
1c7e6d354c
Remove f5-sdk from bigip_device_sshd (#48478) 2018-11-10 12:07:03 -08:00
Tim Rupp
90857004c9
Remove f5-sdk from bigip_device_ntp (#48477) 2018-11-10 12:06:46 -08:00
Tim Rupp
ccb6349e70
Removes f5-sdk from bigip_device_license (#48476) 2018-11-10 12:06:32 -08:00
Tim Rupp
0873043e5a
Fixes ssl cipher ordering in bigip_device_httpd. Also fix unit tests (#48475) 2018-11-10 11:40:18 -08:00
Tim Rupp
fccbbf3405
Removes f5-sdk from bigip_device_group_member (#48464) 2018-11-09 22:35:34 -08:00
Tim Rupp
70cdf477e4
Remove f5-sdk from bigip_device_group (#48463) 2018-11-09 22:17:49 -08:00
Tim Rupp
03ccf50466
Remove f5-sdk from bigip_device_dns (#48461) 2018-11-09 22:13:01 -08:00
Tim Rupp
a1a899353c
Remove f5-sdk from bigip_device_facts and add more facts (#48462) 2018-11-09 22:12:47 -08:00
Tim Rupp
de066ceef8
Removes f5-sdk from bigip_device_connectivity (#48460) 2018-11-09 21:59:21 -08:00
Tim Rupp
c161ffef81
Fixes unit tests for bigip_device_auth that were broken in 2.8 (#48459) 2018-11-09 21:56:26 -08:00
Tim Rupp
68084d989c
Removes f5-sdk from bigip_data_group (#48458) 2018-11-09 21:52:46 -08:00
Tim Rupp
effa22245e
Remove the f5-sdk from bigip_configsync_action (#48457) 2018-11-09 21:38:01 -08:00
Tim Rupp
e6fad87e20
Removes the f5-sdk from bigip_config (#48456) 2018-11-09 21:37:48 -08:00
Tim Rupp
ec2933e20b
Removes the f5-sdk from bigip_command (#48455) 2018-11-09 21:24:21 -08:00
Tim Rupp
d97abff0ad
Fixes unit tests that were broken in ansible 2.8 (#48454) 2018-11-09 21:00:03 -08:00
Tim Rupp
5196188b97
Minor fixes to bigip_cli_alias (#48452) 2018-11-09 20:39:50 -08:00
Tim Rupp
70cf5acf13
Remove f5-sdk from bigip_asm_policy (#48451) 2018-11-09 20:11:46 -08:00
Tim Rupp
77d14b36b0
Remove the f5-sdk from as3 module (#48449) 2018-11-09 19:40:27 -08:00
Tim Rupp
f4c2587d47
Adds new parameters to bigip_pool_member (#48448) 2018-11-09 16:48:08 -08:00
Tim Rupp
55f5a707fe
Removes f5-sdk from bigip_pool (#48431)
Additionally fixes forwarding, small bugs, and adds small enhancements
2018-11-09 12:31:07 -08:00
Tim Rupp
cdc5ab7737
Adds functional tests for new mysql_user privs (#48403)
Adds tests for FUNCTION and PROCEDURE privs
2018-11-09 08:59:19 -08:00
David Soper
9757d9d4c3 support for iscsi vnics based on customer feature request (#48377)
* support for iscsi vnics based on customer feature request
integration tests added for iscsi vnics and vnic state absent

* correct version_added for iscsi and vnic lists
2018-11-09 16:26:23 +00:00
Rémy Léone
f4fa3314c4 Add support for Scaleway object storage (#46353) 2018-11-09 16:16:53 +00:00
René Moser
9050c7abeb
vultr_server_facts: add tests and changelog for firewall group fix in #48342 (#48411) 2018-11-09 14:06:34 +01:00
Andrea Tartaglia
b7d9feb7dc ec2_instance: ebs_optimized is not sub-option of 'network' (#48341)
* ebs_optimized is not suboption of 'network'

* Add Shaps as ec2_instance maintainer

* Added workaround-backward compatible check for ebs_optimized

* Added ebs_optimized test

* CI fixes, dynamic select of ENA-enabled AMI
2018-11-09 12:11:51 +00:00
Tim Rupp
7290bc23b8
Removes the f5-sdk from bigip_provision (#48397) 2018-11-08 21:46:56 -08:00
Tim Rupp
38806e8507
Fixes for bigip_qkview (#48396)
Fixes unit tests for ansible 2.8 and adds more error handling
for qkview generation
2018-11-08 21:08:27 -08:00
Christopher Gadd
f75a84e382 make password locking in user module idempotent (#43671)
* Simplify logic and add FreeBSD & NetBSD

* Remove incorrect flag for lock and unlock on FreeBSD

* Add tests and changelog


Co-authored-by: Chris Gadd <gaddman@email.com>
2018-11-08 21:29:38 -05:00
Strahinja Kustudic
b89b688d52 Fix pip idempotence in check mode
PIP package names must be case insensitive, and must consider hyphens
and underscores to be equivalent
(https://www.python.org/dev/peps/pep-0426/#name), because of this the
module didn't work correctly in check mode. For example if the passed
package name had a different case or an underscore instead of a hyphen
(or the other way around) compared to the installed package, check mode
reported as changed, even though packages were installed. Now the module
ignores case and hyphens/underscores in package names, so check mode
works correctly.
2018-11-08 17:09:34 -08:00
Sam Doran
96c2375692
Add setup roles for passlib and pexpect for use with pause and vars_prompt tests (#43613)
* Add passlib to RHEL test instance

This looks like the only tests instance that is missing this libary. It is needed for vars_prompt tests.

* Create setup roles for pexect and passlib

Switch to using aliases rather than installing directly in the test scripts
2018-11-08 17:05:54 -05:00
David Soper
dda753dc05 ucs_service_profile_template and integration tests (#48277) 2018-11-08 18:42:20 +00:00
Jack Haden-Enneking
15e77ebfe8 ipaddr filter - return a network address when given an address with /32 subnet (#47539)
* fix #17872

* add changelog fragment and enable unit test
2018-11-08 11:49:42 -05:00
Martin Krizek
6ec820e264 yum: add integration test for 'update foo*' (#48336) 2018-11-08 11:39:02 -05:00
Jimmy McCrory
d2969884b4 Add run_once as a valid TaskInclude keyword (#48068)
* Add run_once as a valid TaskInclude keyword

* Add changelog fragment

* Add integration test that documents run_once behavior
2018-11-08 10:29:24 -05:00
John McDonough
9c83640d75 Add module for UCS Org (#46785)
* Add module for UCS DNS Server
2018-11-08 10:50:46 +00:00
John McDonough
7609fe8b09 Add UCS DNS Server management module (#46789)
* Add module for UCS DNS Server
2018-11-08 10:49:24 +00:00
Martin Krizek
41dfc5162f user: fix removing the expiry time when it's 0 (#47115)
* user: fix removing the expiry time when it's 0

* Improve tests and add changelog

Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
2018-11-07 16:44:34 -05:00
Martin Krizek
421d67f1ee
conditional: fix direct boolean "shortcut" (#47941)
* conditional: fix direct boolean "shortcut"

* Add unit tests
2018-11-07 21:33:54 +01:00
Matt Martz
0d068f1e3a
Support list of dicts with omit. Fixes #45907 (#45923) 2018-11-07 13:41:22 -06:00
Matt Clay
17b3171917 Get rabbitmq and erlang GPG keys from S3 in tests. 2018-11-07 09:57:47 -08:00
Raphael Meudec
c062f37984 Bug 42787 create volume with label (#46527)
* add None value to docker-version so it can be mocked in tests
2018-11-07 13:31:12 +00:00
Hugh Ma
a858089eb2 Add survey_spec parameter to module. (#48182)
* Add survey_spec parameter to module.
Fixes #48011

* Removed trailing white space. Added integration test.
2018-11-07 13:09:40 +01:00
Michael Cassaniti
a2f3f16930 win_updates: Add post search category matching to support product matching (#45708)
* win_update: Add post search category matching to support product matching

* win_updates: Return categories of each update

* win_updates: Documentation fix-up

* win_updates: Adjusted documentation to reflect regex vs sub-string match of post-cat strings

* win_updates: Sped up post-category checking

* win_updates: Updated documentation to suggest querying post-category strings

* win_updates: Simplified saving and checking post-categories

* fixed some issues and added filtered categories to return value

* win_updates: Moved all category matching to occur after initial search

* win_updates: Adjustments to satisfy PowerShell lint checks

* win_updates: Dropped category validation from action plugin

* win_updates: Documentation updates

* win_updates: Fixed plugin unit tests
2018-11-07 19:32:07 +10:00
Jordan Borean
501acae5ab
Added basic equivalent to PowerShell modules (#44705)
* Added basic equivalent to PowerShell modules

* changes based on latest review

* Added tests

* ignore sanity test due to how tests are set up

* Changes to work with PSCore

* Added documentation and change updated more modules

* Add some speed optimisations to AddType

* fix some issues in the doc changes

* doc changes
2018-11-07 10:53:17 +10:00
Adam Miller
091fb1dc3f yum also parse obsolete package output (#45365)
* yum also parse obsolete package output

This is a rebase of the patch originally proposed in
https://github.com/ansible/ansible/pull/40001 by machacekondra

Fixes #39978

Signed-off-by: Adam Miller <admiller@redhat.com>

* properly parse the obsoletes, provide a new output entry, add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>

* make pep8 happy

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove q debugging output

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-06 16:07:50 -05:00
Andrew Herrington
43bbc505a1 Add threading to slack notification module (#47333)
* Add threading to slack notification module

* Fix sanity check

* Change thread_ts to thread_id
2018-11-06 12:04:07 -05:00
Felix Fontein
602d02be5f Add docker_container_facts module. (#48062) 2018-11-06 15:08:28 +00:00
Dave Bendit
d7686e1bc0 [docker_network] Add handling for Python booleans in driver_options (#48105)
Fixes #26708
2018-11-06 14:39:45 +00:00
Lars
b6b238ae43 facts: suse: fix SLES4SAP12 detection (#44388) 2018-11-06 08:12:38 -05:00
Jordan Borean
8787c65b65
powershell: add ability to ignore specific warnings in C# Add-Type (#47643) 2018-11-06 10:48:31 +10:00
Matt Clay
150cdd7931 Pin openshift version for k8s test.
This will avoid spontaneous test failure for new releases of openshift on PyPI.
2018-11-05 15:59:57 -08:00
Sam Doran
8c49fd2a2c
Adjust pause test (#48125)
Use send() rather than sendlin() calls when testing interactive prompting and echo.
2018-11-05 17:03:41 -05:00
Sam Doran
066af3b6ca
User module - allow bang and exclamation in password field without warning (#46498)
* Allow bang and exclamation without warning

Allow the password field to be ! or * without warning when using this feature to create accounts that are locked.

Add documentation  and tests to cover this.

* Use set() rather than braces for Python 2.6
2018-11-05 16:35:10 -05:00
Deric Crago
7f3c21f628 bump version of 'vcenter-test-container' to '1.4.0' (govmomi v0.19.0) 2018-11-05 11:57:15 -08:00
Dag Wieers
df6b0b0e9e aci_aptiplp: Support missing policy_group (#48000)
* aci_aptiplp: Support missing policy_group

* Adapt integration tests to fix

* Add changelog fragment

* Fix

Co-Authored-By: dagwieers <dag@wieers.com>
2018-11-05 18:21:01 +00:00
Dag Wieers
d1f6ff646a aci_iplpg: Support missing aep (#48001)
* aci_iplpg: Support missing aep
2018-11-05 18:20:23 +00:00
Dag Wieers
591b074e43
aci_switch_leaf_selector: Support missing policy_group (#47992)
* aci_switch_leaf_selector: Support empty policy_group

* Reorganize code

* Adapt integration tests to fix
2018-11-05 19:02:06 +01:00
Felix Fontein
2728a22f73 Add docker_prune module (#48063)
* Add docker_prune module.

* Fix spelling error.
2018-11-05 17:05:26 +00:00
Pilou
6f8ffeb6bf tower{job,workflow}_template: use same retries value (#47865) 2018-11-05 16:56:19 +00:00
Dag Wieers
2c0707c034
Add missing MSC support
This was missing from PR #46116
2018-11-05 16:38:37 +01:00
Abhijeet Kasurde
57c9532cad OpenStack: add an alias for name (#47972)
This fix adds an additional alias for name parameter viz. subnet

Fixes: #37352

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-05 12:56:30 +00:00
Felix Fontein
8eb656de8b Fixing idempotency test. (#48038) 2018-11-05 12:55:27 +00:00
Jesse Pretorius
0fc99c3939 Fix lvg module idempotency (#47620)
* Fix lvg module idempotency

In [1] changes were made to ensure that the physical
devices were appropriately filtered, but the dev_list
which is used to prepare the filter is modified from
the original arguments to resolve any symlinks. This
results in the existing devices given in the module
args to be left out of the filter, resulting
in the module trying to add the same device again
every time the task is executed.

In this PR we change dev_list to be a copy of the
module arguments so that we're able to add the given
pv list from the module arguments into the filter
as well, ensuring that there is idempotence when
running the task again.

[1] https://github.com/ansible/ansible/pull/38446

* Add lvg module idempotence test

To ensure that the lvg module is tested for idempotency,
we add a basic integration test.

Support for MacOS and FreeBSD are skipped because the
module does not currently support those platforms.
2018-11-05 12:50:21 +00:00
Felix Fontein
569ec812e7 Improve paused test and behavior. (#48056) 2018-11-05 11:34:23 +00:00
Felix Fontein
af79adca1d Make tests fail less often with strange errors. (#48059) 2018-11-05 11:33:29 +00:00
Felix Fontein
35809e99bc docker_container: fix ipc_mode and pid_mode idempotency (#47997)
* Fix ipc_mode and pid_mode idempotency when container names are used.

* Add changelog.

* Update pid_mode documentation.
2018-11-05 10:26:13 +10:00
Felix Fontein
3cca4185be docker_container: simplify minimal required version per option handling (#47711)
* Store parsed docker-py / docker API versions in client.

* Began refactoring 'minimal required version' for docker_container options.

* Removing some fake defaults.

* Added changelog.

* Improve tests (check older docker versions).

* Fix comparison. The breaking point is not docker-py 2.0.0, but 1.10.0.

(Verified by testing with these versions.)

* Move docker-py/API version detection to setup_docker.

* Add YAML document starter.

* docker_network requirement for docker-py was bumped to 1.10.0 in #47492.
2018-11-05 10:25:11 +10:00
René Moser
788247583b
vultr: fix for API returned unexpected empty list (#48036)
* vultr: fix for API returned unexpected empty list

* add changelog
2018-11-04 11:23:36 +01:00
Tim Rupp
16032d37c4
Removes f5-sdk from bigip_service_policy (#48033) 2018-11-02 23:14:16 -07:00
Tim Rupp
11ff831998
Remove f5-sdk from bigip_snat_pool (#48030) 2018-11-02 23:03:16 -07:00
Tim Rupp
1373a25ed3
Remove the f5-sdk from bigip_smtp (#48032) 2018-11-02 22:42:02 -07:00
Tim Rupp
438827ca4d
Remove f5-sdk from bigip_snmp (#48029) 2018-11-02 22:39:54 -07:00
Tim Rupp
45e990c5f8
Remove the f5-sdk from snmp community module (#48028) 2018-11-02 22:28:18 -07:00
Tim Rupp
6b14bab750
Fixes ansible unit tests for bigip_software_install (#48025) 2018-11-02 22:20:54 -07:00
Tim Rupp
5afe77933b
Removes the f5-sdk from bigip_snmp_trap (#48027) 2018-11-02 22:20:39 -07:00
Tim Rupp
b45b2b3cc4
Fixes unit tests for bigip_software_image (#48026) 2018-11-02 22:20:24 -07:00
Tim Rupp
a90bf9fb32
Removes f5-sdk from bigip_software_update (#48024) 2018-11-02 22:17:13 -07:00
Tim Rupp
787b12e016
Adds the bigip_ssl_ocsp module (#48018)
This module can be used to manage OCSP profiles on a BIG-IP
2018-11-02 22:06:16 -07:00
Tim Rupp
32e77c12e0
Fixes to bigip_static_route (#48017)
Corrects documentation. Fixes unit tests, Fixes ip address checks
for gateway_address
2018-11-02 20:57:08 -07:00
Tim Rupp
f25d9a1b30
Remove sdk and deprecated features (#48016)
This removes deprecated params and the f5-sdk from the sys_global module
2018-11-02 15:38:59 -07:00
Tim Rupp
96c9d9fdaa
Removes the f5-sdk from bigip_sys_db (#48015) 2018-11-02 15:38:36 -07:00
Tim Rupp
f9402e5a91
Removes the f5-sdk from timer policy module (#48014) 2018-11-02 15:30:29 -07:00
Tim Rupp
d8a8c21efe
Removes the f5-sdk from the traffic group module (#48008) 2018-11-02 13:01:22 -07:00
Tim Rupp
24be9c030c
Remove f5-sdk and add qinq ethertype (#48006)
This patch removes the f5-sdk from bigip trunk and adds the qinq
ethertype parameter
2018-11-02 12:47:58 -07:00
Tim Rupp
b4af058c55
Fixes unit tests and token cleanup (#48005)
The unit tests in 2.8 were broken. this fixes them and adds a token
cleanup to the bigip_tunnel module
2018-11-02 12:14:30 -07:00
Tim Rupp
2a69dfb22f
Removes f5-sdk from bigip_ucs module (#48003)
This patch removes the usage of the f5-sdk from the bigip_ucs module
2018-11-02 12:13:44 -07:00
Dag Wieers
6a37582158
msc_role: Manage roles on ACI MultiSite (#47757)
This includes the new msc_role module and integration tests.
2018-11-02 20:08:11 +01:00
Dag Wieers
1ac40e21b4
msc_site: Manage sites on ACI MultiSite (#47756)
This includes the new msc_site module and integration tests.
2018-11-02 20:07:10 +01:00
Dag Wieers
e97ad60f3b
msc_tenant: Manage tenants on ACI MultiSite (#47755)
This includes the new msc_tenant module and integration tests.
2018-11-02 20:02:42 +01:00
Dag Wieers
7142715b15
msc_user: Manage users on ACI MultiSite (#47754)
This includes the new msc_user module and integration tests.
2018-11-02 20:00:17 +01:00
Tim Rupp
f6309d19a3
Removes f5-sdk from bigip_uce_fetch module (#48002)
This is part of the ongoing effort to fully remove the f5-sdk from
the f5 ansible modules
2018-11-02 11:54:40 -07:00
Tim Rupp
5b5d41e958
Removes the f5-sdk from bigip_user (#47794)
This is more work in the ongoing effort to remove the f5-sdk from
all f5 ansible modules
2018-11-02 11:25:18 -07:00
Dag Wieers
67aa98c30f
msc_label: Manage label on ACI MultiSite (#47753)
This includes the new msc_label module and integration tests.
2018-11-02 19:22:20 +01:00
f-bor
35b97a2fa7 edgeswitch_facts (#47618) 2018-11-02 18:50:11 +05:30
Christian Kotte
754c377dbd VMware: Improve output of vmware_local_role_facts (#47871) 2018-11-02 14:28:36 +05:30
saichint
b92556549e Add new configurations for nxos_vxlan_vtep (#47834)
* add new commands for vxlan

* review comments

* fix unit test

* fix sanity yaml spaces
2018-11-02 11:23:37 +05:30
René Moser
064530b72e
cs_network_acl_rule: fix doc and sanity (#47835)
* cs_network_acl_rule: fix doc and sanity

* doc styling
2018-11-02 01:08:15 +01:00
Stephan Müller
00bab2d24d [docker_network] add ipv6 support (#47492)
* [docker_network] add ipv6 support

* docker_network: review ipam_options

* docker_network: fix requirements

* docker_network: fix deprecation notice

* docker_network: add minimum docker version change

* docker_network: remove trailing whitespace

* docker_network: revert rename of network_four #discussion_r228707101

* docker_network: refactor IPAM config comparison #discussion_r228707255, #discussion_r228707280

* docker_network: correct spelling of IPv4 and IPv6 #discussion_r228707114, #discussion_r228707138

* docker_network: manually remove networks #discussion_r228709051

* docker_network: refactor enable_ipv6 condition #discussion_r228707317

* docker_network: add mutually_exclusive #discussion_r228707185

* docker_network: fix iprange #discussion_r228709072

* docker_network: add auxiliary addresses in examples and tests

* docker_network: link to docker docs #discussion_r228707018

* docker_network: remove list default #discussion_r228707060, #discussion_r228709091

* docker_network: introduce params syntax for create_network() #discussion_r228709031

* docker_network: beautify code

* docker_network: resolve change requests

* docker_network: add yaml header

* docker_networking: fix get_ip_version

* docker_network: extend CIDR test

* docker_network: use backported unittest2 for python 2.6

* docker_network: migrate unittest to pytest
2018-11-02 08:59:16 +10:00
Akshay Gaikwad
80ca779aa7 Support for device read write limit parameters (#47814)
* Support for device read write limit parameters

* Add following options in docker_container module
  - device_read_bps
  - device_write_bps
  - device_read_iops
  - device_write_iops

Fixes #36831

* test for device_read_iops
* combined test for device_write_bps and device_write_iops
2018-11-02 08:58:06 +10:00
Matt Martz
042a0cff23
Add unit tests for unsafe_proxy (#47887)
* Add unit tests for unsafe_proxy

* Remove unused import

* Address comments

* Add inheritance test
2018-11-01 16:42:32 -05:00
Matt Clay
1939f6c412 Fix ansible-test invocation of pytest. 2018-11-01 09:45:17 -07:00
Jordan Borean
f0535bac80 dnf yum: fix tests running on Fedora 29 (#47910)
* dnf yum: fix tests running on Fedora 29

* wrap in always block
2018-11-01 12:20:29 -04:00
Tomas Tomecek
23becece53 Implement connection plugin for podman (#47519)
* new connection plugin: podman

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>

* podman,conn: utilize remote_user to run commands

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>

* podman connection: update docs

Co-Authored-By: TomasTomecek <ttomecek@redhat.com>
2018-11-01 10:14:18 -04:00
anasbadaha
dc8b3e94ad Adding IGMP vlan module for onyx switches (#47811)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-11-01 14:25:25 +05:30
anasbadaha
760e57f877 Adinng new module for supporting PTP interface in Onyx switches (#47489)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-11-01 14:19:51 +05:30
anasbadaha
dea9e9b4c8 Adding new module for supporting PTP Global Protocol (#47501)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-11-01 14:16:30 +05:30
Lindsay Hill
a1b0d20368 New voss_config module (#47533)
* New voss_config module

* Updated test import paths as per #46996
2018-11-01 14:07:41 +05:30
Thierry Bouvet
87de2dde9f Fix advertise addr (#47608)
* Fix issue #46326

* Update example to create a default swarm
2018-11-01 08:10:03 +00:00
Felix Fontein
65768b996d docker_container: fix paused and add some tests (#47900)
* cleanup is already tested.

* Add test for paused.

* Add recreate and restart tests.

* timeout is a common docker option

* Implement paused and fix paused test.

* Add changelog.

* Improve paused test.
2018-11-01 08:08:43 +00:00
René Moser
242bd512d0
cs_ip_address: fix vpc and network mutually exclusive (#47846)
* cs_ip_address: fix vpc and network mutually exclusive

* add changelog

* streamline docs
2018-11-01 07:26:08 +01:00
James Cassell
8eacaf6a77 command modules: optional stdin_add_newline (#45170)
* stdin_add_newline: allow newline suppression on command modules

* command/shell: test for stdin_add_newline

* changelog for stdin_add_newline
2018-10-31 12:53:02 -04:00
Nilashish Chakraborty
baae7fa9ba
Fix ios_user not able to handle certain scenario (#47656)
* added support for users with password(not secret) configs

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added example

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix typo

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix pep8

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add integration tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2018-10-31 16:51:46 +05:30
Mike Wiebe
c53e3ca8e9 Add force disruptive option (#47694)
* Use expect module to copy files

* Add force option for disruptive upgrades

* Revert changes to copy_kick_system_images.yaml
2018-10-31 14:53:43 +05:30
Dag Wieers
b7e77c4274 BOTMETA: Move rabbitmq modules to own directory (#46064)
Moving rabbitmq modules to own directory makes it possible to automatically include $team_rabbitmq for new modules.
2018-10-30 14:54:38 -05:00
Paul Harvey
cd75074fc5 fix yum proxy regex (closes #47797) (#47800)
* Modify yum/tasks/proxy.yml to usernames that expose regex bug

* Fix bad regex backref/interpolation w/yum proxy username

A yum proxy username that begins with a number was being
interpolated as part of the backref, resulting in an error:
"sre_constants.error: invalid group reference"

Closes #47797
2018-10-30 16:35:37 +01:00
Martin Krizek
4b8f2c99d2
yum: fix 'package == version' syntax (#47744) 2018-10-30 16:28:22 +01:00
Abhijeet Kasurde
b32b4111b2
plugin_filter: check for type error (#46664)
* Parsing plugin filter may raise TypeError, gracefully handle this exception
and let user know about the syntax error in plugin filter file.

* Test for plugin_filtering

Fixes: #46658

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-30 18:25:02 +05:30
Felix Fontein
73533d3fc2 docker_* modules: simplify idempotency comparisons (#47709)
* More generic comparison code from docker_container to docker_common.

* More flexibility if a is None and method is allow_to_present.

Note that this odes not affect docker_container, as there a is never None.

* Update docker_secret and docker_config: simplify labels comparison.

* Added unit tests.

* Use proper subsequence test for allow_more_present for lists.

Note that this does not affect existing code in docker_container, since lists
don't use allow_more_present. Using allow_more_present will only be possible
in Ansible 2.8.

* pep8
2018-10-30 08:50:34 +00:00
Susant Sahani
2596ac196f nmcli: Introduce VxLan (#45932)
This work enables to add vxlan via nmcli module

```
  - nmcli:
      type: vxlan
      conn_name: vxlan_test1
      vxlan_id: 16
      vxlan_local: 192.168.1.2
      vxlan_remote: 192.168.1.5
```
ansible 2.8.0

revision 1: Added tests

Signed-off-by: Susant Sahani <susant@redhat.com>
2018-10-30 03:17:33 -04:00
Christian Kotte
e0f7a522a3 VMware: Improve module vmware_host_vmnic_facts (#47278)
* fix "AttributeError: 'NoneType' object has no attribute 'nicDevice'"
* add vmnic_details output (speed, duplex, vendor, mac, etc. pp.)
* add NIC capabilities, DirectPath I/O, and SR-IOV information output
* add num_vmnics
2018-10-30 12:21:50 +05:30
Tim Rupp
1ddfac5ad5
Fixes unit tests for vcmp guest module (#47792)
Tests were not working for ansible 2.8
2018-10-29 21:51:50 -07:00
Christian Kotte
6ebd20bf22 VMware: New module: vmware_host_vmhba_facts (#47502) 2018-10-30 10:10:43 +05:30
Tim Rupp
1aae9ad282
Remove f5-sdk from bigip_virtual_address module (#47791)
Removes the f5-sdk and fixes unit tests for ansible 2.8
2018-10-29 21:38:10 -07:00
Tim Rupp
3ad1cb5619
Adds bigip_device_syslog module (#47790)
This module can be used to alter the device syslog settings and
priorities for syslog settings
2018-10-29 21:24:24 -07:00
Tim Rupp
e0d2419683
Adds firewall global rules module (#47789)
This module allows the user to change global rules in AFM firewalls
2018-10-29 21:10:49 -07:00
Tim Rupp
10f3e0c187
Adds module to manage cookie persistence profiles in BIG-IP (#47786) 2018-10-29 20:47:25 -07:00
Tim Rupp
7336dd595b
Adds ipsec policy module for BIG-IP (#47785)
Allows users to manage IPSec policies on a BIG-IP
2018-10-29 15:49:22 -07:00
Tim Rupp
9d2f68e00a
Adds bigip_traffic_selector module (#47784)
This module enables the user to manage traffic selector policies on a BIG-IP
2018-10-29 15:27:18 -07:00
Tim Rupp
d69b8e4bfd
Import mdule for managing sys daemon logs in BIG-IP (#47783)
This module allows one to manage the daemon log settings in tmm on BIG-IP
2018-10-29 15:16:51 -07:00
Tim Rupp
9d351f2ee7
Adds bigip profile for http2 (#47782)
This allows one to manage HTTP2 profiles on a BIG-IP
2018-10-29 14:53:20 -07:00
Tim Rupp
f80288c0c4
Adds bigip_monitor_ldap module (#47781)
Adds new module to manage LDAP monitors on a BIG-IP
2018-10-29 14:42:49 -07:00
Felix Fontein
2dab10f1ec docker_network: adding/updating tests (#47775)
* Add substring test (fixes #32927).

* Extend idempotency tests (fixes #32580).
2018-10-29 17:34:00 -04:00
Dave Bendit
6ca88ab75d docker_network: Adding basic integration test for overlay network (#47772)
Fixes #19271
2018-10-29 17:29:50 -04:00
Tim Rupp
114d591f31
Adds bigip_ike_peet module (#47780)
Adds new module to managing IKE peers
2018-10-29 14:25:43 -07:00
Tim Rupp
8edbfb488c
Adds new parameters to bigip_vlan (#47777)
Also fixes unit tests to work in ansible 2.8
2018-10-29 13:57:53 -07:00
Tim Rupp
7c84ba8051
Fixes tests in bigip_wait for ansible 2.8 (#47773) 2018-10-29 13:08:35 -07:00
Tim Rupp
38844194ae
Fixes bigiq unit tests for ansible 2.8 (#47771)
fixes the unit tests for bigiq in ansible 2.8 because changes broke them
2018-10-29 12:43:56 -07:00
Tim Rupp
8ede4c5e60
Adds more facts to bigiq_device_facts (#47765)
Adds more facts to the bigiq_device_facts module
2018-10-29 11:33:47 -07:00
Dag Wieers
3e890bdbaa
Initial import of MSC module_utils (#46116)
This is required for upcoming MSC modules.
2018-10-29 18:45:42 +01:00
Tim Rupp
cbc8571809
Adds fixes to the bigiq unit tests (#47763)
The tests were not working on ansible 2.8. This fixes that.
2018-10-29 10:41:35 -07:00
Tim Rupp
6e28b7d572
Remove the f5-sdk from more bigiq modules (#47721) 2018-10-29 10:10:11 -07:00
Simon
893c0dbba7 New facts module: Memset server products (#42386)
* initial commit of facts module for Memset VPS/dedicated server products

* add missing brace

* add integration tests (disabled until we have a mock API to test against)

* bump ansible release version to 2.8
2018-10-29 12:28:00 +00:00
Simon
2d6c01005d New facts module: Memset Memstore (#42387)
* initial commit of facts module to return usage of a Memstore cloudstorage product

* switch API wrapper to use basic auth instead of passing the api_key in the body

* add integration tests (disabled until we have a mock API to test against)

* bump ansible release version to 2.8
2018-10-29 12:27:03 +00:00
codylane
d3fe6c01f2 Addresses comments in #38971 (#44324)
* Controlled params within no section

* Added tests to control params within no section

* Cleaning output_file before creating no-section params and check the content

* addresses comment in PR "s/hate/beverage/g"
2018-10-29 11:33:14 +00:00
Dario Zanzico
2162d7d4de Docker swarm service integration tests (#45674)
* integration test for docker_swarm_service

* ensure stack de-initialization

* Set default value for 'configs' parameter to None

Docker-py uses None as a default value for configs.
Using the same default here allows to create services on older docker
setups (docker_api<1.30).

* Set default value for 'update_order' parameter to None

Docker-py uses None as a default value for update_order.
Using the same default here allows to create services on older docker
setups (docker_api<1.29)

* Set default value for 'publish.mode' parameter to None

Docker-py uses None as a default value for publish_mode.
Using the same default here allows to create services on older docker
setups (docker_api<1.32)

* Allow tests to run on older version of docker.

* remove workarounds for old docker versions

* test correct swarm cleanup

* changelog fragment for docker_swarm_service defaults change
2018-10-29 11:28:51 +00:00
Felix Fontein
92d9569bc9 ACME: add support for POST-as-GET if GET fails with 405. (#44988)
* Add support for POST-as-GET if GET fails with 405.

* Bumping ACME test container version to 1.4. This includes letsencrypt/pebble#162 and letsencrypt/pebble#168.

* Also use POST-as-GET for account data retrival.

This is not yet supported by any ACME server (see letsencrypt/pebble#171),
so we fall back to a regular empty update if a 'malformedRequest' error is
returned.

* Using newest ACME test container image.

Includes letsencrypt/pebble#171 and letsencrypt/pebble#172, which make Pebble behave closer to the current specs.

* Remove workaround for old Pebble version.

* Add changelog entry.

* First try POST-as-GET, then fall back to unauthenticated GET.
2018-10-29 10:32:53 +01:00
Zim Kalinowski
7c11c67156
adding enable_rbac option in aks (#47730)
* adding enable_rbac option in aks

* fixes

* addressed comments
2018-10-29 14:36:38 +08:00
Zim Kalinowski
bc1e6b3039 pre-adding new packages to save testing time while merging new resources (#47729) 2018-10-29 12:44:34 +08:00
Ganesh Nalawade
17fea30841
Revert "enhance recv calls in network_cli (#47345)" (#47731)
This reverts commit c649d0ea32.

The change results in deadlock in network_cli while it is
waiting to check the return value of recv_ready() which
was added in this commit to improve performance
2018-10-29 09:50:30 +05:30
Christian Kotte
d052618838 VMware: Add check mode support in vmware_vswitch_facts (#47263)
* Check mode support
* Fixed num_ports
2018-10-28 20:00:51 +05:30
Tim Rupp
d5d18a995a
Removes f5 sdk from bigiq modules and fixes unit tests (#47720) 2018-10-27 20:20:07 -07:00
Tim Rupp
b7a937cb0d
Updates bigiq_utility_license_assignment for ansible 2.8 (#47719) 2018-10-27 19:30:34 -07:00
Christian Kotte
c779ef5313 VMware: New module: vmware_host_hyperthreading (#46750) 2018-10-27 21:42:41 +05:30
Brandon Bell
5568ffd45b Fix syntax error for Python 2.6 (#47635)
* Fix syntax error for Python 2.6

* Removing consul.py from pylint/ignore.txt
2018-10-27 12:43:53 +10:00
Rémy Léone
338605882e Add support for adding custom query parameters to URL (#46390) 2018-10-26 15:20:00 +01:00
John Hu
82f1438b14 Add docker_config module (#38792)
* Add docker_config module

* Address review comments

* Merge description lines

* Stop returning empty config_id in results

* Add integration tests for docker_config

Based on docker_secret's tests.

* Ensure swarm using docker_swarm module

* Add minimum docker / docker api version requirements

ref: https://github.com/ansible/ansible/pull/47046

* Check Docker API version before running tests

ref: https://github.com/ansible/ansible/pull/47340

* Typo

* Wording

* Improve example

* Assert state == absent is idempotent
2018-10-26 10:58:17 +01:00
f-bor
c649d0ea32 enhance recv calls in network_cli (#47345)
* enhance recv calls in network_cli

* updated network_cli test unit

* enhance recv calls in network_cli

* fix mistake

* better timeout management

* remove exception trigger

* test

* test2

* restore exception and timeout

* ganeshrn's way

* correction

* timeout and exception return
2018-10-26 09:49:17 +05:30
Ingate Systems
9fe20123cf modules: network: Add initial support for Ingate modules (#47494)
* modules: network: Add initial support for Ingate modules

* modules: network: Add ingate module ig_unit_information

* module_utils: network: ingate: Use default 'v1' for version

* modules: network: ingate: Remove unused code
2018-10-26 09:47:58 +05:30
s3lph
5b1c68579d Type error in openssl_certificate (#47508)
* Fixed #47505: Type error in openssl_certificate
* Use to_bytes instead of str.encode in SelfSignedCertificate. Updates #47508
* Use to_bytes instead of str.encode in OwnCACertificate
* Added integration tests for openssl_certificate: selfsigned_not_before/after and ownca_not_before/after
2018-10-26 09:11:00 +05:30
Felix Fontein
f19ab56eb4 docker_image, docker_image_facts, docker_volume: add basic integration tests (#47383)
* Add docker_image_facts tests.

* Add basic integration test for docker_volume.

* Add basic docker_image tests.

* Only start test registry when tests are actually run (i.e. not on CentOS 6).
2018-10-26 10:51:41 +10:00
Matt Martz
10e129e2e9 Detect the socket path after starting the service. Fixes #47582 2018-10-25 11:13:23 -07:00
Zim Kalinowski
1724b633f2
adding subnet service endpoints (#47549)
adding subnet service endpoints
2018-10-25 13:43:47 +08:00
Zim Kalinowski
5193e31886
adding mysql firewall rule facts (#47342)
* adding mysql firewall rule facts

* fixes
2018-10-25 10:10:12 +08:00
Zim Kalinowski
1cb78209ae
upgrading sql package to newest (#47544)
* upgrading sql package to newest

* LROPOller
2018-10-25 10:08:56 +08:00
Zim Kalinowski
4cda7a7883
upgrading rdbms to the latest version (#47547) 2018-10-25 09:55:00 +08:00
Zim Kalinowski
9b2465e7ad
added missing stuff to aliases (#47458) 2018-10-25 09:53:40 +08:00
Yunge Zhu
1587bb9f65
fix webapp test (#47546) 2018-10-25 09:45:40 +08:00
abarbare
b4a9b29ab2 feat: add security_group to scaleway compute resource (#45699)
feat: add more tests
2018-10-24 22:33:40 +01:00
Toshio Kuratomi
748ea39ecd Fix mysql authentication errors
The mysql-server package on Ubuntu16.04 was recently updated to disallow
unauthenticated root user login over tcp/ip.  This, coupled with pymysql
using tcp/ip whenever host and port is specified causes us to fail to
connect to the database when testing Python3 on Ubuntu16.04.

The fix is to use the unix socket instead.
2018-10-24 10:33:19 -07:00
lolcube
eb7f6a5e62 Add openssh_keypair module (#46436)
* add openssh_keypair module
2018-10-24 11:51:45 +01:00
Akshay Gaikwad
20b95adf2b Add Support of healthcheck in docker_container module (#46772)
* Add Support of healthcheck in docker_container module

Fixes #33622
Now container can be started with healthcheck enabled

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Extend docker_container healthcheck (#1)

* Allowing to disable healthcheck.

* Added test for healthcheck.

* Make sure correct types are used.

* Healthcheck needs to be explicitly disabled with test: ['NONE'].

* pep8 fixes

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Fix bug if healthcheck interval is 1 day or more

`timedelta` object has days too and seconds are up to one day.
Therefore use `total_seconds()` to convert time into seconds.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Add test for healthcheck when healthcheck is not specified

This is to avoid the situation when healthcheck is not specified and
treat this as healthcheck is changed or removed.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Convert string syntax for healthcheck test to CMD-SHELL

Also add another test case to check idempotency when healthcheck test
is specified as string

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Playbook fails if minimun docker version is not satisfy for healthcheck

This is to make more consistent with other non-supported options.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
2018-10-24 11:49:56 +01:00
Zim Kalinowski
0fb0ea2ab3
upgrading msrest packages (#47541) 2018-10-24 09:26:06 +08:00
Dag Wieers
691ff4b9e6 WinRM/PSRP: Ensure shell returns UTF-8 output (#47404)
* WinRM/PSRP: Ensure shell returns UTF-8 output

This PR makes UTF-8 output work in PSRP shells.

* Add win_command and win_shell integration tests

* Fix tests

* more test fixes
2018-10-24 10:40:54 +10:00
Jordan Borean
f28b7c7ab1
psrp - fix unicode handling in Python 2 (#47461)
* psrp - fix unicode handling in Python 2

* skip psrp become test when on Server 2008
2018-10-24 05:37:05 +10:00
John R Barker
fb2e838a42
TEMP HACK: Avoid overloading codecov.io (#47515)
Without this patch we are overloading codecov.io by uploading 90+ tests.

As a workaround limit uploading to only "Group 1"

Will be removed/updated based on codecov.io's support team
2018-10-23 17:32:34 +01:00
Matt Martz
f6ecdf0b87
Handle sets differently than lists in wrap_var. Fixes #47372 (#47510) 2018-10-23 11:18:21 -05:00
Matt Martz
d5e4f37ca0
Ensure we don't overwrite roles from include/import_role when loading the play (#47512)
* Ensure we don't overwrite roles from include/import_role when loading the play. Fixes #47454

* Add changelog fragment
2018-10-23 11:08:48 -05:00
Felix Fontein
3afdb28209 docker_container: fix interaction of detach:no with auto_remove:yes (#47396)
* Behave better if auto_remove and output_logs are combined. Warn if output cannot be retrieved because of auto_remove.

* Add tests.

* Added changelog.
2018-10-23 07:51:24 +01:00
Dave Bendit
29b4b36501 Adding "internal" option to "docker_network" module (#35370)
Fixes #27065
2018-10-23 07:49:26 +01:00
Toshio Kuratomi
ccabc2bff5 Revert "[stable-2.7] Handle sets differently than lists in wrap_var. Fixes #47372."
This reverts commit 0e933f76ba4edb0e06f0779f5fb4b0ea85191e8b.

The tests for this were broken on centos6 because jinja2 does not have
a map filter on that platform.  Tests need to be rewritten
2018-10-22 21:00:15 -07:00
Matt Clay
8d00afc013 Ignore user module use of subprocess. 2018-10-22 17:42:15 -07:00
Matt Clay
8f072ea0f5 Fix sanity test failure. 2018-10-22 17:35:47 -07:00
Brian Coca
581b6aed2e really skip if no boto3
makes no sense to check/skip after you already fail to import
2018-10-22 17:18:25 -04:00
Zhikang Zhang
b697da39c8 Fix problem where pip module cannot accept multiple extras
PR #46937
Fixes #46519
2018-10-22 22:21:45 +02:00
Jocelyn Jaubert
4352a4e54d interfaces_file: Add test for pre-up/post-up with inet/inet6 2018-10-22 20:51:59 +02:00
Jocelyn Jaubert
bd7001cdb6 interfaces_file: Add test for changing ipv4 or ipv6 address through address_family 2018-10-22 20:51:59 +02:00
Jocelyn Jaubert
a4916e848d interfaces_file: Add test for multiple address_family for same iface 2018-10-22 20:51:59 +02:00
Martin Krizek
a0aa53d1a1 user: do not pass ssh_key_passphrase on cmdline
CVE-2018-16837

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2018-10-22 14:00:55 -04:00
Matt Martz
c58de75f38 Handle sets differently than lists in wrap_var. Fixes #47372 2018-10-22 11:56:28 -04:00
Pablo
6497049f2a Fix exception when including tasks from handlers (#47307)
Set _notified_handlers for the task's _uuid that is run as a handler

Fix #47287
2018-10-22 10:46:36 -05:00
Ganesh Nalawade
335a979f1d
Fix prompt mismatch issue for ios (#47004)
* Fix prompt mismatch issue for ios

Fixes #40884 #44463

*  If the command prompt is matched check if data is
   still pending to be read from buffer.
*  This fix adds a new timer `buffer_read_timeout`
   which will be trigerred after command prompt
   is matched and data is attempted to be read from channel.
   If not data is present of channel the timer will expire
   and response we be returned to calling function.

* Fix unit test failure

* Update to make buffer timeout float

* Update doc and fix review comment

* Fix CI issues

* Update doc

* Fix review comments

* Fix review comments
2018-10-22 21:05:15 +05:30
abarbare
6d6245db0f feat: dynamic security group (#46571) 2018-10-21 16:05:30 +01:00
Christian Kotte
c50a69c2eb VMware: New module vmware_host_powermgmt_policy (#46688)
* New module vmware_host_powermgmt_policy
* minor changes

Signed-off-by: Christian Kotte <christian.kotte@gmx.de>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-19 23:15:43 +05:30
Christian Kotte
cd988f645a VMware: New module vmware_host_ipv6 (#47275)
* New module vmware_host_ipv6
* Minor changes

Signed-off-by: Christian Kotte <christian.kotte@gmx.de>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-19 22:34:17 +05:30
Christian Kotte
ea42ec7e90 VMware: Improve module vcenter folder (#46497)
* Add datacenter_name alias
* Improve vcenter_folder module
* add check mode support
* fix VM folder deletion
* fix folder deletion under parent folder
* fix (host) folder creation if two datacenters are present
2018-10-19 21:15:58 +05:30
Matt Clay
c24c19594e
Enable pylint rules and fix exposed bugs. (#47219)
* Resolve invalid-unary-operand-type.

* Resolve raising-format-tuple.

* Resolve stop-iteration-return.

* Use disable comment instead of fixing logic.

The affected line in _find_address_range will only fail on Python 3.7
and later if the function is called with an empty address list. As an
internal method it is never called in this way, making it a non-issue
for use via public methods.

Using a comment to disable the rule in favor of an ignore.txt entry
since there are no plans to change the logic in the code itself. This
will also prevent any potential future issues being added in other
parts of the code when updating it based on upstream changes.
2018-10-19 08:32:52 -07:00
Christian Kotte
dc2eb05491 VMware: Add check mode support to vmware_vmkernel_facts (#47286) 2018-10-19 19:24:34 +05:30
Anil Kumar Muraleedharan
0f943f7584 Adding full list of supported devices (#46949) 2018-10-19 09:49:29 -04:00
Pluggi
f13091d142 Add runtime option to docker_container module (#47247)
* Add runtime option to docker_container module

Signed-off-by: Antoine Bardoux <abardoux@nvidia.com>

* Add changelog fragment

Signed-off-by: Antoine Bardoux <abardoux@nvidia.com>

* Add idempotency test for docker_container.runtime

Signed-off-by: Antoine Bardoux <abardoux@nvidia.com>
2018-10-19 09:04:17 +01:00
Felix Fontein
131efcff9d docker_network: add basic integration tests (#46137)
* Adding very basic integration tests for docker_network.

* Fixing some details (review comments).
2018-10-19 08:42:27 +01:00
Zim Kalinowski
b0c88ddab1
Adding postgresql firewall rule facts (#45078)
* adding postgresql firewall rule facts

* fixed sanity

* fixed sanity

* updating tests

* firewall rule facts updated

* fixed test

* fix crash

* small updates

* updated postgresql firewall rule

* removed unnecessary type

* fixed postgresql facts

* fixed azure

* one more fix

* test fixes

* fix class name
2018-10-19 15:13:45 +08:00
Felix Fontein
d2f524fb27 Use {{ ansible_python.executable }} instead of python in integration tests. (#47340) 2018-10-19 09:00:34 +02:00
Jordan Borean
e6a327fb82
ansible-test: add retry for Windows httptester download (#47334) 2018-10-19 15:15:03 +10:00
Paul Belanger
e844bfe1d4 Force PEM SSH keys for paramiko
Trying to get ansible-test working on my fedora-28 system, I noticed I
was getting invalid keys from paramiko. It looks like this is because
ssh-keygen is now defaulting to RFC4716 format for private / public
keys.

For now, we can still use PEM based SSH keys, but the long term fix here
is to report a bug to paramiko and support RFC4716 for rsa keys.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2018-10-18 21:25:55 -07:00
Jordan Borean
c0546b4133
win httptester: add wait for endpoint in case it is still coming up (#47326) 2018-10-19 13:43:54 +10:00
Claude Dioudonnat
1a51b08875 Fix increase fake disk size for filesytem's tests 2018-10-19 01:20:33 +02:00
Pierre-Louis Bonicoli
e016af3cc6 filesystem tests: enable LVM
Co-authored-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
2018-10-19 01:20:33 +02:00
Martin Krizek
541255a2d8
Do not strip new lines in native jinja (#46751)
* Do not strip new lines in native jinja

* Add changelog/fragment
2018-10-19 00:14:43 +02:00
Matt Clay
37b013aca3
Enable additional pylint rules and resolve issues found. (#47221)
* Resolve unneeded-not.
* Resolve global-at-module-level.
* Resolve useless-import-alias.
* Resolve bad-whitespace.
* Resolve global-variable-not-assigned.
* Resolve logging-not-lazy.
* Resolve comparison-with-itself.
2018-10-18 13:38:08 -07:00
Matt Martz
77d32b8f57
Don't use the task for a cache, return a special cache var (#47243)
* Don't use task to cache loop results, use hostvars. Fixes #47207

* Avoid a race condition, supply _ansible_loop_cache through get_vars directly

* Add tests

* Add changelog fragment

* Remove unnecessary copy

* Remove unnecessary host from _get_delegated_vars signature
2018-10-18 15:25:43 -05:00
Matt Clay
f74f7b0373
Add constraint for requests on python 2.6. (#47306)
* Add constraint for requests on python 2.6.
* Use constraints in lookup_hashi_vault test.
2018-10-18 13:05:29 -07:00
Matt Clay
14da4d66f2 Add constraints to pip install in setup_docker. 2018-10-18 10:25:48 -07:00
Toshio Kuratomi
bcd6dbcd65 Remove get_exception from the remainder of the modules 2018-10-18 08:37:04 -07:00
Ryan Brown
18a088c64e
GCP MagicModules bug fixes (#47285)
Closes: #46930 #46929 #46928 #46927 #46926 #46925 #46924 #46923 #46922 #46921 #46920 #46919 #46918 #46917 #46916 #46915 #46914 #46913 #46912 #46911 #46910 #46909 #46908 #46907 #46906 #46905 #46903 #46902 #46901 #46900 #46899 #46898 #46897 #46896 #46895 #46894 #46893 #46892 #46891 #46890 #46889 #46888 #46887 #46886 #46885 #46884 #46883 #46882 #46881 #46880 #46879 #46878 #46877 #46876 #46875 #46874 #46873 #46872 #46871 #46870 #46869 #46868 #46867 #46866 #46865 #46864 #46863 #46862 #46861 #46860 #46859 #46858 #46857 #46856 #46855 #46854 #46853 #46852
2018-10-18 10:55:42 -04:00
flowerysong
0fc639e755 ec2_tag: Fix removing tags without specifying a value (#47228) 2018-10-18 10:13:08 -04:00
Alex Stephen
3f629c426c New GCP Module: gcp_compute_region_disk (#46886) 2018-10-18 10:08:14 -04:00
Pierre-Louis Bonicoli
7231f7da84 test-module: check availability of special attrs 2018-10-18 09:45:56 +02:00
Jordan Borean
5d2927c9a0
test: filesystem update note on test comment (#47260) 2018-10-18 17:10:16 +10:00