saichint
ed42331105
fix nxos_igmp_snooping issues ( #38566 )
...
* fix nxos_igmp_snooping issue
* shippable error fix
2018-04-11 10:14:27 -04:00
John R Barker
38491fe93d
Explicitly exclude W504 ( #38539 )
...
pycodestyle 2.4 has changed the default for W504
2018-04-10 20:07:57 +01:00
Matt Martz
6332beef65
Add unit tests for ansible.module_utils.urls ( #38059 )
...
* Start of tests for ansible.module_utils.urls
* Start adding file for generic functions throughout urls
* Add tests for maybe_add_ssl_handler
* Remove commented out line
* Improve coverage of maybe_add_ssl_handler, test basic_auth_header
* Start tests for open_url
* pep8 and ignore urlopen in test_url_open.py tests
* Extend auth tests, add test for validate_certs=False
* Finish tests for open_url
* Add tests for fetch_url
* Add fetch_url tests to replace-urlopen ignore
* dummy instead of _
* Add BadStatusLine test
* Reorganize/rename tests
* Add tests for RedirectHandlerFactory
* Add POST test to confirm behavior is to convert to GET
* Update tests to handle recent changes to RedirectHandlerFactory
* Special test, just to confirm that aliasing http_error_308 to http_error_307 does not cause issues with urllib2 type redirects
2018-04-09 10:17:43 -05:00
jhawkesworth
ad94d03ba1
Tolerate win line endings on windows module_util load ( #37291 )
...
* tolerate windows line endings when loading windows module utils. Helpful for old custom windows modules.
* add test modules to demonstrate win line ending module load behaviour.
* attempt to fix sanity check failures
* pep8 fix
* explict skip of test modules from shebang check (core modules must still have expected unix style line endings)
* switch to rstrip() following core team meeting feedback
2018-04-06 07:13:31 +10:00
Jordan Borean
f37a44430f
win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets ( #37897 )
...
* win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets
* compare username in lowercase for test
2018-04-03 18:28:10 -07:00
René Moser
b06dfbec54
cs_user: fix E325 ( #38158 )
2018-03-31 11:44:04 +02:00
Matt Martz
ffbbb5a25b
Use arg_spec type for comparisons on default and choices ( #37741 )
...
* Use arg_spec type for comparisons on default and choices
* Further improve type casting
* Make sure to capture output in more places
* Individually report invalid choices
* Update ignore.txt after resolving merge conflicts
2018-03-26 12:15:32 -05:00
saichint
0df5cfd41f
fix nxos_static_route issues ( #37614 )
...
* fix nxos_static_route issues
* remove nxos_static_route from ignore
2018-03-26 11:13:32 -04:00
Matt Clay
0dade18f43
Fix yamllinter handling of tuple assignment.
2018-03-22 23:14:21 -07:00
Dag Wieers
2c2f335893
win_psexec: Fix pslint issues ( #37718 )
2018-03-22 03:21:07 +01:00
Dag Wieers
de5fb66026
win_product_facts: Fix pslint issues ( #37722 )
2018-03-22 03:18:48 +01:00
Dag Wieers
fdc0e5c5fb
win_defrag: Fix pslint issues ( #37719 )
2018-03-22 00:06:42 +01:00
Dag Wieers
f78b415db0
win_wakeonlan: Fix pslint issues ( #37717 )
2018-03-21 23:45:17 +01:00
Matt Clay
307d8b5330
Disable PowerShell null comparison test.
...
Too many false positives due to unknown types.
2018-03-21 15:41:49 -07:00
Matt Clay
05220d693d
Complete updates of remaining code-smell tests. ( #37743 )
...
* Add text/binary file support to code smell tests.
* Enhance line-endings code smell test.
* Enhance no-smart-quotes code-smell test.
* Enhance shebang code-smell test.
2018-03-21 12:02:06 -07:00
Matt Clay
8daa80e5bb
Move var precedence check to integration tests.
2018-03-21 09:43:32 -07:00
Matt Clay
775539a8b8
Fix api_profile choices in Azure docs fragment.
2018-03-20 11:07:34 -07:00
Dag Wieers
51662acc6c
Clean up Grafana docs a bit ( #37516 )
...
* Clean up Grafana docs a bit
But more is needed, default values, missing choices, proper
descriptions, actual sentences :-)
* Remove validate-modules entries
2018-03-17 02:53:26 +01:00
Dag Wieers
cdd21e2170
Clean up module documentation ( #36909 )
...
* Clean up module documentation
This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required
* Fix remaining (new) validation issues
2018-03-15 22:15:24 +01:00
Matt Martz
8980d275a0
Support recursive suboptions schema ( #37206 )
...
* Support recursive suboptions schema
* Remove todo line, add voluptuous version constraint
2018-03-09 17:09:58 -06:00
Pilou
bc6b96d42e
webfaction modules: fix broken import ( #35024 )
...
* webfaction_app: fix broken import
* doc: use formatting functions
* webaction_db: fix broken import
* webfaction_domain: fix broken import
* webfaction_mailbox: fix broken import
* webaction_site: fix broken import
* webfaction modules: fix doc
2018-03-07 06:22:06 -08:00
René Moser
e1297af18a
cs_router: fix missing doc ( #37107 )
...
* cs_router: fix missing doc
* update ignore.txt
2018-03-07 13:34:39 +00:00
René Moser
67d8c8f5c6
cs_ip_address.py: fix missing doc ( #37109 )
...
* cs_ip_address.py: fix missing doc
* update ignore.txt
2018-03-07 13:15:39 +00:00
René Moser
2559e832df
cloudstack: fix common E324 in docs ( #37082 )
...
Notes about precedence of common args.
Partly fixes E324.
2018-03-07 11:09:08 +01:00
René Moser
4705edd1a7
letsencrypt: add new param force ( #37077 )
...
* letsencrypt: add new param force to ignore remaining days
* letsencrypt: fix E325
2018-03-06 20:51:24 +01:00
Mikhail Naletov
7d0e1f92f4
[terraform] Support initializing modules and providers at runtime ( #36996 )
...
* Fixes #36994
Added function for force initializing modules and providers
Added type for force_init parameter
2018-03-05 11:01:53 -05:00
Matt Martz
ca092b5c26
Skip top level args that are the same as args in provider in doc<->arg_spec comparisons ( #36911 )
2018-03-01 10:47:20 -06:00
Gaurav Rastogi
60e39b9718
Updated the documentation of modules to match argspec including the type setting for bool parameters ( #36821 )
2018-02-28 14:38:03 +00:00
Matt Clay
dc71c2197f
More code-smell sanity test updates. ( #36830 )
...
* Add test for missing Azure requirements.
* Improve readability.
* Enhance no-unicode-literals code-smell test.
2018-02-28 00:50:00 -08:00
Matt Clay
ac1698099d
Overhaul additional sanity tests. ( #36803 )
...
* Remove unnecessary sys.exit calls.
* Add files filtering for code-smell tests.
* Enhance test-constraints code-smell test.
* Simplify compile sanity test.
* Pass paths to importer on stdin.
* Pass paths to yamllinter on stdin.
* Add work-around for unicode path filtering.
* Enhance configure-remoting-ps1 code-smell test.
* Enhance integration-aliases code-smell test.
* Enhance azure-requirements code-smell test.
* Enhance no-illegal-filenames code-smell test.
2018-02-27 15:05:39 -08:00
Matt Clay
60a24bbdaa
Pass code-smell paths on stdin.
2018-02-27 00:36:16 -08:00
Mário Santos
8b52006d5c
Fix sanity checks in OpenStack docs fragment ( #36722 )
...
* Fix sanity checks in OpenStack docs fragment
Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
2018-02-26 13:05:53 +00:00
Ed Costello
2a0c7c4331
Fix documentation of validate_certificates option in aws doc_fragment.
...
Unignore sanity test failures for AWS modules caused by this common
fragment.
2018-02-23 13:21:44 -08:00
Pilou
07927f52ae
filesystem: fix documentation ( #36556 )
2018-02-23 10:59:38 +00:00
Matt Clay
5b5cba5e50
Update more code-smell tests. ( #36570 )
...
* Enhance use-compat-six code-smell test.
* Enhance use-argspec-type-path code-smell test.
* Enhance replace-urlopen code-smell test.
* Enhance boilerplate code-smell test.
* Enhance no-underscore-variable code-smell test.
2018-02-22 08:08:29 -08:00
Matt Clay
891f4f3b2d
Upgrade more code-smell tests. ( #36560 )
...
* Enhance no-dict-* code-smell tests.
* Enhance no-basestring code-smell test.
* Enhance no-get-exception code-smell test.
* Enhance empty-init code-smell test.
* Enhance required-and-default-attribute test.
* Remove unused code-smell test.
2018-02-21 20:09:13 -08:00
Jordan Borean
ef4f8851dc
win_feature: better error handling to make it easier to debug issues ( #36491 )
...
* win_feature: better error handling to make it easier to debug issues
* removed ignroed pslint rules that are no longer needed
2018-02-22 11:33:48 +10:00
John R Barker
5d0ed38e3a
Fixup VMware module docs issues ( #36409 )
...
Fix various argspec vs documentation issue
2018-02-21 15:20:42 +00:00
Matt Clay
2b6ac4561b
Add support for enhanced code-smell tests. ( #36332 )
...
* Add support for enhanced code-smell tests:
- Path selection handled by ansible-test.
- Optional path filtering based on extension.
- Optional path filtering based on prefixes.
- Optional lint friendly output.
* Enhance no-assert code-smell test.
* Enhance no-tests-as-filters code-smell test.
2018-02-20 13:37:23 -08:00
Matt Clay
a9b58b84d8
Fix path handling in validate-modules sanity test.
2018-02-20 11:02:42 -08:00
ABond
591695932e
Fix bug in DigitalOcean module_util ( #36352 )
2018-02-18 07:47:26 +05:30
Abhijeet Kasurde
5242914ae5
Fix digital ocean issues ( #36347 )
...
Remove module from ignore lists and some documentation fix in
digital_ocean_block_storage and digital_ocean module.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-17 22:48:52 +05:30
Matt Clay
ff922ac2ad
Import sanity test for main() in Ansible modules.
2018-02-16 11:17:36 -08:00
John R Barker
365630df65
Update ignore to deal with renamed files ( #36323 )
2018-02-16 19:07:36 +00:00
Matt Clay
80b55e3742
Add missing validate-modules ignore entries.
2018-02-16 01:40:45 -08:00
Matt Martz
831a9d67d7
Arg spec doc comparison fixes ( #36265 )
...
* Ensure we merge doc fragments early, for comparisons
* Perform boolean conversion from arg_spec data too
* Update valdiate-modules ignore.txt due to recent changes
2018-02-15 22:49:11 +00:00
Matt Martz
50adc5409b
Add several new doc<->arg_spec checks ( #36247 )
...
* Add several new doc<->arg_spec checks. See #18183
* Update ignore.txt for validate-modules
2018-02-15 20:34:40 +00:00
John R Barker
7dfa11cd8a
Notice in 2.6 remove in Ansible 2.10 ( #36191 )
...
Update the list of allowed removed_in for modules
2018-02-14 09:24:18 -08:00
John R Barker
3e22efa0ba
Ensure docs are valid before checking deprecation ( #36160 )
2018-02-14 14:47:31 +00:00
John R Barker
17c0d3eae0
Fix more docs vs argspec ( #36048 )
2018-02-12 17:42:25 +00:00