1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

13254 commits

Author SHA1 Message Date
David Shrewsbury
e25c04aeb0 Add new os_flavor_facts.py module
New module to retrieve facts about existing instance flavors.
By default, facts on all available flavors will be returned.
This can be narrowed by naming a flavor or specifying criteria
about flavor RAM or VCPUs.
2016-12-08 11:33:56 -05:00
David Shrewsbury
b697d986c1 Add new os_keystone_role module.
This new module allows for creating and deleting Keystone
roles.
2016-12-08 11:33:56 -05:00
Doug Luce
030fbaef64 Use os module for checking absolute/joining paths 2016-12-08 11:33:55 -05:00
Doug Luce
d4275e576e cronvar.py: support absolute destinations
Mainly so /etc/crontab can be written to.
2016-12-08 11:33:55 -05:00
Rene Moser
c00688a118 iptables: add defaults to docs 2016-12-08 11:33:55 -05:00
David Hocky
4abd217aa5 add version added to new params 2016-12-08 11:33:55 -05:00
David Hocky
a3b7dbe1df fix doc issue 2016-12-08 11:33:55 -05:00
David Hocky
994edea253 add support for setting dscp marks with iptables module 2016-12-08 11:33:55 -05:00
liquidat
7abe6b0e8c correct win_firewall state parameter
- original parameter comment was probably copy&paste error
- new comment highlights that firewall rules can be
  added or removed altering this parameter
2016-12-08 11:33:55 -05:00
Toshio Kuratomi
32ff89b30e Fix module docs 2016-12-08 11:33:55 -05:00
Rene Moser
fd68e66827 cloudstack: new module cs_zone_facts 2016-12-08 11:33:55 -05:00
Michael Scherer
4589b67a44 Remove unused variables
Session_id is unused in update_session, changed is always specifically
set in all exit_json call, and consul_client.session.destroy return True
or False, and is unused later (nor checked)
2016-12-08 11:33:55 -05:00
Michael Scherer
fabd619070 Rename consul variable to consul_client
Since the module is also named consul, pyflakes emit a warning
about it since the variable shadow the module.
2016-12-08 11:33:55 -05:00
Michael Scherer
78571c053b Pyflakes complain about unused import, so remove it 2016-12-08 11:33:55 -05:00
Michael Scherer
334bfbd465 Add a datacenter parameter, fix #1693 2016-12-08 11:33:55 -05:00
Eike Frost
b8b2613c35 Replace deprecated exists API for Zabbix 3.0 compatibility 2016-12-08 11:33:55 -05:00
Calvin Walton
f623057e0e zabbix_maintenance: Stop using api removed in zabbix 3.0 2016-12-08 11:33:55 -05:00
Ricky Cook
4a9daf6bae New json_fail syntax for dnsimple module 2016-12-08 11:33:55 -05:00
yta
0446231380 osx_defaults: Do not make any changes in check mode 2016-12-08 11:33:55 -05:00
Ritesh Khadgaray
06d2682b08 Fix test failure for lxc_container
TRACE:
    while parsing a block mapping
      in "<string>", line 33, column 13:
                    description: resulting state of  ...
                    ^
    expected <block end>, but found ','
      in "lxc_container.RETURN", line 419, column 53:
         ... "/tmp/test-container-config.tar",

ERROR: RETURN is not valid YAML. Line 419 column 53
2016-12-08 11:33:54 -05:00
Brian Coca
bb355e6ccd add container name to return and document return
fixes #1848
2016-12-08 11:33:54 -05:00
mxpt user
0798bfe2dc Fixing typo in bigip_monitors Correcting set_template_int_property to set_template_integer_property 2016-12-08 11:33:54 -05:00
nitzmahone
2afecc7198 fix version_added issues in win_iis_website 2016-12-08 11:33:54 -05:00
nitzmahone
2e4cb9c651 added doc note to win_iis_website site_id arg 2016-12-08 11:33:54 -05:00
Corwin Brown
659c1078ba Updated Documentation to include site_id param 2016-12-08 11:33:54 -05:00
Corwin Brown
2c9512aece Adding Site_ID param 2016-12-08 11:33:54 -05:00
Brian Coca
864bf4e19e added new puppet path to bin search
fixes #1835
2016-12-08 11:33:54 -05:00
Brian Coca
b1281319c1 updated to match core module forms 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
bb27e38578 corrected replacement of last backslash 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
cd0e97dc77 corrected requirements 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
5f9eaf193e fixxed problems related to path input 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
0d01a36dd9 first implementation of win_share module 2016-12-08 11:33:54 -05:00
Marcin Dobosz
6f68db5c1a Fix win_iis_webapppool module to not null ref when removing an apppool using PS4 2016-12-08 11:33:54 -05:00
nitzmahone
092c3ccbde fix default arg handling and error messages in win_file_version 2016-12-08 11:33:54 -05:00
nitzmahone
db58300aa7 fix missing bracket in win_file_version 2016-12-08 11:33:54 -05:00
Sam Liu
a077c4bc9d fix some error for passing CI build. 2016-12-08 11:33:53 -05:00
Sam Liu
b174416895 Fixed: exception swallowing 2016-12-08 11:33:53 -05:00
Sam Liu
d5fe7633e2 new module win_file_version 2016-12-08 11:33:53 -05:00
liquidat
87bc5fcb24 remove legacy action style from examples
- "action" style invoking is a legacy way to call modules
- the examples were updated to the typical style of calling complex
  modules:

ovirt:
  parameter1: value1
  parameter2: value2
  ...
2016-12-08 11:33:53 -05:00
Matt Martz
019a944fb3 Catch errors related to insufficient (old) versions of pexpect. Fixes #13660 2016-12-08 11:33:53 -05:00
Will Keeling
876fe06290 Better handling of package groups in pacman module 2016-12-08 11:33:53 -05:00
Jonathan Mainguy
ac8b171da4 fixes bug where puppet fails if logdest is not specified 2016-12-08 11:33:53 -05:00
Toshio Kuratomi
c602d49d42 Fail due to no dnf module installed earlier as we use a dnf utility function to determine if we have permission to install packages. 2016-12-08 11:33:53 -05:00
Jiri Tyr
bb194b03bc Removing parameter from yum_repository module 2016-12-08 11:33:53 -05:00
Jiri Tyr
709ae10207 Adding more options to the yum_repository module 2016-12-08 11:33:53 -05:00
Eike Frost
85f6bb4d8e Check whether interface-list exits before querying its length 2016-12-08 11:33:53 -05:00
Ricardo Carrillo Cruz
9fea94b5bf Fix instantiation of openstack_cloud object in os_project
The os_project module instantiates the openstack cloud object
by passing the module params kwargs.
As the params contain a key named 'domain_id', this is used
for domain in the OpenStack connection, instead of the domain value
the user specifies on the OSCC clouds.yaml or OpenStack envvars.
This fix corrects this by popping the 'domain_id' key, so it we
keep the value but it's not passed later on module.params.
2016-12-08 11:33:53 -05:00
Darek Kaczyński
17a6cea512 ecs_task module documentation fixes 2016-12-08 11:33:53 -05:00
Joseph Callen
773db55233 Resolves issue with vmware_migrate_vmk module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_migrate_vmk module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Migrate Management vmk
      local_action:
        module: vmware_migrate_vmk
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        esxi_hostname: "{{ hostvars[item].hostname }}"
        device: vmk1
        current_switch_name: temp_vswitch
        current_portgroup_name: esx-mgmt
        migrate_switch_name: dvSwitch
        migrate_portgroup_name: Management
      with_items: groups['foundation_esxi']
```

Module Testing
```
TASK [Migrate Management vmk] **************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/migrate_vmk.yml:3
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" )
localhost PUT /tmp/tmpdlhr6t TO /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" )
localhost PUT /tmp/tmpqfZqh1 TO /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" )
localhost PUT /tmp/tmpf3rKZq TO /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/" > /dev/null 2>&1
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp001", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-01"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp002", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-02"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp003", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-03"}
```
2016-12-08 11:33:53 -05:00
Joseph Callen
eece1346ab missing doc fragment 2016-12-08 11:33:53 -05:00
Joseph Callen
3721a4647c Resolves issue with vmware_vm_vss_dvs_migrate module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_vm_vss_dvs_migrate module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Migrate VCSA to vDS
      local_action:
        module: vmware_vm_vss_dvs_migrate
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        vm_name: "{{ hostname }}"
        dvportgroup_name: Management
```

Module Testing
```
ASK [Migrate VCSA to vDS] *****************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:260
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859 )" )
localhost PUT /tmp/tmpkzD4pF TO /root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/vmware_vm_vss_dvs_migrate
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/vmware_vm_vss_dvs_migrate; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => {"changed": true, "invocation": {"module_args": {"dvportgroup_name": "Management", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root", "vm_name": "cscvcatmp001"}, "module_name": "vmware_vm_vss_dvs_migrate"}, "result": null}

```
2016-12-08 11:33:53 -05:00
Joseph Callen
cef9e42896 Resolves issue with vmware_host module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_host module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
    - name: Add Host
      local_action:
        module: vmware_host
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        datacenter_name: "{{ mgmt_vdc }}"
        cluster_name: "{{ mgmt_cluster }}"
        esxi_hostname: "{{ hostvars[item].hostname }}"
        esxi_username: "{{ esxi_username }}"
        esxi_password: "{{ site_passwd }}"
        state: present
      with_items: groups['foundation_esxi']
```

Module Testing
```
TASK [Add Host] ****************************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:214
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937 )" )
localhost PUT /tmp/tmppmr9i9 TO /root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834 )" )
localhost PUT /tmp/tmpVB81f2 TO /root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563 )" )
localhost PUT /tmp/tmpFB7VQB TO /root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp001", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-01", "result": "'vim.HostSystem:host-15'"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp002", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-02", "result": "'vim.HostSystem:host-20'"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp003", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-03", "result": "'vim.HostSystem:host-21'"}

```
2016-12-08 11:33:53 -05:00
Joseph Callen
fb3bb746b2 Resolves issue with vmware_dvs_portgroup module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_dvs_portgroup module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Create Management portgroup
      local_action:
        module: vmware_dvs_portgroup
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        portgroup_name: Management
        switch_name: dvSwitch
        vlan_id: "{{ hostvars[groups['foundation_esxi'][0]].mgmt_vlan_id }}"
        num_ports: 120
        portgroup_type: earlyBinding
        state: present
```

Module Testing
```
TASK [Create Management portgroup] *********************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/dvs_network.yml:17
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693809.13-142252676354410 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693809.13-142252676354410 )" )
localhost PUT /tmp/tmpeQ8M1U TO /root/.ansible/tmp/ansible-tmp-1454693809.13-142252676354410/vmware_dvs_portgroup
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693809.13-142252676354410/vmware_dvs_portgroup; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693809.13-142252676354410/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "172.27.0.100", "num_ports": 120, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "portgroup_name": "Management", "portgroup_type": "earlyBinding", "state": "present", "switch_name": "dvSwitch", "username": "root", "vlan_id": 2700}, "module_name": "vmware_dvs_portgroup"}, "result": "None"}
```
2016-12-08 11:33:52 -05:00
Joseph Callen
9bdc59a6ac Resolves issue with vmware_cluster module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_cluster module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
    - name: Create Cluster
      local_action:
        module: vmware_cluster
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        datacenter_name: "{{ mgmt_vdc }}"
        cluster_name: "{{ mgmt_cluster }}"
        enable_ha: True
        enable_drs: True
        enable_vsan: True
```

Module testing
```
TASK [Create Cluster] **********************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:188
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693788.92-14097560271233 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693788.92-14097560271233 )" )
localhost PUT /tmp/tmpAJfdPb TO /root/.ansible/tmp/ansible-tmp-1454693788.92-14097560271233/vmware_cluster
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693788.92-14097560271233/vmware_cluster; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693788.92-14097560271233/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "enable_drs": true, "enable_ha": true, "enable_vsan": true, "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_cluster"}}
```
2016-12-08 11:33:52 -05:00
Joseph Callen
0aa4f867de Resolves issue with vmware_dvs_host module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_dvs_host module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Add Host to dVS
      local_action:
        module: vmware_dvs_host
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        esxi_hostname: "{{ hostvars[item].hostname }}"
        switch_name: dvSwitch
        vmnics: "{{ dvs_vmnic }}"
        state: present
      with_items: groups['foundation_esxi']
```
Module Testing
```
TASK [Add Host to dVS] *********************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:234
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844 )" )
localhost PUT /tmp/tmpGrHqbd TO /root/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844/vmware_dvs_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844/vmware_dvs_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796 )" )
localhost PUT /tmp/tmpkP7DPu TO /root/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796/vmware_dvs_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796/vmware_dvs_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663 )" )
localhost PUT /tmp/tmp216NwV TO /root/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663/vmware_dvs_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663/vmware_dvs_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": true, "invocation": {"module_args": {"esxi_hostname": "cscesxtmp001", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "username": "root", "vmnics": ["vmnic2"]}, "module_name": "vmware_dvs_host"}, "item": "foundation-esxi-01", "result": "None"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": true, "invocation": {"module_args": {"esxi_hostname": "cscesxtmp002", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "username": "root", "vmnics": ["vmnic2"]}, "module_name": "vmware_dvs_host"}, "item": "foundation-esxi-02", "result": "None"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": true, "invocation": {"module_args": {"esxi_hostname": "cscesxtmp003", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "username": "root", "vmnics": ["vmnic2"]}, "module_name": "vmware_dvs_host"}, "item": "foundation-esxi-03", "result": "None"}
```
2016-12-08 11:33:52 -05:00
Rene Moser
fb4c299f13 cloudstack: new module cs_zone 2016-12-08 11:33:52 -05:00
Rene Moser
3a6fd536ab cloudstack: new module cs_cluster 2016-12-08 11:33:52 -05:00
Rene Moser
2b21212dc6 cloudstack: new module cs_pod 2016-12-08 11:33:52 -05:00
Rene Moser
7d1a4db9ee cloudstack: new module cs_instance_facts 2016-12-08 11:33:52 -05:00
Rene Moser
b609250cfd cloudstack: add new module cs_resourcelimit 2016-12-08 11:33:52 -05:00
Rene Moser
595eb1f8f1 cloudstack: new module cs_configuration 2016-12-08 11:33:52 -05:00
Eike Frost
9779792b07 return as unchanged if macro update is unnecessary 2016-12-08 11:33:52 -05:00
Konstantin Shalygin
3956549e6c Fix recurse delete. Add force update_cache feature. 2016-12-08 11:33:52 -05:00
Corwin Brown
62e8f46390 Converting result to snake_case before returning 2016-12-08 11:33:52 -05:00
Corwin Brown
ac620b79dd Added UseBasicParsing flag
win_uri uses "Invoke-WebRequest" under the covers, which apparently
uses Internet Explorer to parse a webpage. The problem is if a user
has never run Internet Explorer, it will be unable to do that. The
work around for this is to set the "-UseBasicParsing" flag.

The only advantage to having the Internet Explorer parsed page is
that you can then access the DOM as if it was a powershell
argument. That doesn't seem super useful for Ansible to be able
to do, so I set the default to be "-UseBasicParsing"
2016-12-08 11:33:52 -05:00
Corwin Brown
20284fed88 bug fixes 2016-12-08 11:33:52 -05:00
Corwin Brown
88e4faa1ac Using Get-AnsibleParam
conflict

typo
2016-12-08 11:33:52 -05:00
Corwin Brown
a979624b88 Adding win_uri module 2016-12-08 11:33:52 -05:00
Marcos Diez
ece891baec Updated database/misc/mongodb_user.py, the docs now explain how to add a read user to the local/oplog db 2016-12-08 11:33:51 -05:00
Matt Martz
4842758fd1 Choices should be a list of true/false not the string BOOLEANS 2016-12-08 11:33:51 -05:00
Matt Martz
402a996430 Don't call sys.exit in sns_topic, use HAS_BOTO to fail 2016-12-08 11:33:51 -05:00
Matt Martz
27be34ef9d DOCUMENTATION fixes for a few modules 2016-12-08 11:33:51 -05:00
Matt Martz
e3cffb0de4 Fix version_added for recently added modules 2016-12-08 11:33:51 -05:00
Joseph Callen
9ab5b367bd Resolves issue with vmware_dvswitch module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_dvswitch module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Create dvswitch
      local_action:
        module: vmware_dvswitch
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        datacenter_name: "{{ mgmt_vdc }}"
        switch_name: dvSwitch
        mtu: 1500
        uplink_quantity: 2
        discovery_proto: lldp
        discovery_operation: both
        state: present
```
Module Testing
```
TASK [Create dvswitch] *********************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/dvs_network.yml:3
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693792.01-113207408596014 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693792.01-113207408596014 )" )
localhost PUT /tmp/tmptb3e2c TO /root/.ansible/tmp/ansible-tmp-1454693792.01-113207408596014/vmware_dvswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693792.01-113207408596014/vmware_dvswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693792.01-113207408596014/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => {"changed": true, "invocation": {"module_args": {"datacenter_name": "Test-Lab", "discovery_operation": "both", "discovery_proto": "lldp", "hostname": "172.27.0.100", "mtu": 1500, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "uplink_quantity": 2, "username": "root"}, "module_name": "vmware_dvswitch"}, "result": "'vim.dvs.VmwareDistributedVirtualSwitch:dvs-9'"}
```
2016-12-08 11:33:51 -05:00
Ronny
bb417d2b62 Update zabbix_host.py
Use existing proxy when updating a host unless proxy is specified. Before change proxy was always set to none(0) when updating.
2016-12-08 11:33:51 -05:00
Rene Moser
5344701557 cloudstack: cs_instance: implement updating security groups
ACS API implemented in 4.8, has no effect < 4.8.
2016-12-08 11:33:51 -05:00
Rene Moser
51393a0e0f cloudstack: use CS_HYPERVISORS from cloudstack utils 2016-12-08 11:33:51 -05:00
Joseph Callen
750f6f35ed Fixed documentation 2016-12-08 11:33:51 -05:00
Joseph Callen
e4d7af368b Resolves issue with vmware_vswitch module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing.

Playbook
```yaml
   - name: Add a temporary vSwitch
      local_action:
        module: vmware_vswitch
        hostname: "{{ inventory_hostname }}"
        username: "{{ esxi_username }}"
        password: "{{ site_passwd }}"
        switch_name: temp_vswitch
        nic_name: "{{ vss_vmnic }}"
        mtu: 1500
```

Module Testing
```bash
TASK [Add a temporary vSwitch] *************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/esxi_network.yml:13
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566 )" )
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598 )" )
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801 )" )
localhost PUT /tmp/tmpLLExSG TO /root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/" > /dev/null 2>&1
localhost PUT /tmp/tmpyoAaHt TO /root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/" > /dev/null 2>&1
localhost PUT /tmp/tmpPcmaMZ TO /root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/" > /dev/null 2>&1
changed: [foundation-esxi-01 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-01", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}
changed: [foundation-esxi-02 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-02", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}
changed: [foundation-esxi-03 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-03", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}

```

Documentation fix
2016-12-08 11:33:51 -05:00
Thierno IB. BARRY
0f175cec07 Add ES 2.x support
Add compatibility between ES 1.x and ES 2.x.

bin/plugin install | remove [plugin_name] works on ES 1.x and ES 2.x
2016-12-08 11:33:51 -05:00
Rene Moser
e9667eb542 doc: replace yumrepo with yum_repository 2016-12-08 11:33:51 -05:00
Rene Moser
84259eb2d6 rename yumrepo to yum_repository 2016-12-08 11:33:51 -05:00
jhawkesworth@users.noreply.github.com
d5ad463a5a Add extra PS Drives so you can access other parts of the registry 2016-12-08 11:33:50 -05:00
Phil
55c671a18b removed hardcoded paths, check for .exe error exit code, use get-attr for required param check. 2016-12-08 11:33:50 -05:00
Phil
f1579a1207 init commit win_timezone 2016-12-08 11:33:50 -05:00
jhawkesworth@users.noreply.github.com
061365e892 First pass at adding win_regmerge module for handling bulk registry changes 2016-12-08 11:33:50 -05:00
Eike Frost
007b637e7a Add explicit argument_spec types to avoid misinterpretation and subsequent errors (i.e. getting an int instead of the expected str) 2016-12-08 11:33:50 -05:00
Matt Martz
2738ae94c0 Exclude modules that are importing requests 2016-12-08 11:33:50 -05:00
Borys Borysenko
149ebdb15f The size option is required for lvol module with state=present 2016-12-08 11:33:50 -05:00
Brian Coca
88c946ba4d added docs to blockinfile with_ interactions
fixes #1592
2016-12-08 11:33:50 -05:00
Michael Scherer
0670a6c56d Add documentation to explain that pvs will be created if needed
Fix #1720
2016-12-08 11:33:50 -05:00
Travis J Parker
b8c8bb5238 fixes documented command for svc sending SIGUSR1 2016-12-08 11:33:50 -05:00
Matt Martz
d44dd63a00 Add actual version to version_added for svc module 2016-12-08 11:33:50 -05:00
Joel Thompson
8539d6f502 Fix documentation for sns_topic module
Currently the documentation does not correspond to the Ansible standards
for module documentation. This should bring it into compliance.
2016-12-08 11:33:50 -05:00
Dag Wieers
9199f56d80 Fix typo 2016-12-08 11:33:50 -05:00
Ton Kersten
fb471fc0a8 Fix facter path 2016-12-08 11:33:50 -05:00
Brian Coca
383403282f now point to local template 2016-12-08 11:33:50 -05:00
Brian Coca
392fde1847 initial addition of issue/pr temlpates 2016-12-08 11:33:50 -05:00
Brian Coca
130aca03fa minor docfixes 2016-12-08 11:33:50 -05:00
Ritesh Khadgaray
c3e9c54f29 files/blockinfile.py : ERROR: version_added for new option (follow) should be 2.1. Currently 0.0 2016-12-08 11:33:49 -05:00
Matt Martz
1f7a2041be Indicate proxy_host and proxy_port were added in 2.1 2016-12-08 11:33:49 -05:00
Brad Wilson
6c07f42b8d Issue #1668: rabbitmq_user: Ansible HEAD incorrectly treats permissions as a string instead of a list 2016-12-08 11:33:49 -05:00
Brian Coca
4702cc9b1b added follow docs back, removed from shared 2016-12-08 11:33:49 -05:00
Brian Coca
c7108db1a0 merged duplicate entries for vdc_name 2016-12-08 11:33:49 -05:00
Jan Chaloupka
6e201948bc dnf module: package not installed with state=latest
dnf: name=PACKAGE state=latest is reponsible for two use cases:
- to install a package if not already installed.
- to update the package to the latest if already installed.

The latter use cases is not handled properly as base.upgrade does not
throw dnf.exceptions.MarkingError if a package is not installed.

Setting base.conf.best = True ensures a package is installed or
updated to the latest when calling base.install.

Sign-off: jsilhan@redhat.com
Sign-off: jchaloup@redhat.com
2016-12-08 11:33:49 -05:00
Michael Baydoun
221d1b7744 Update ec2_vpc_net_facts.py
Corrected version_added
2016-12-08 11:33:49 -05:00
Thierno IB. BARRY
4c07e1447e update doc for proxy support
Update documentation to add proxy section
2016-12-08 11:33:49 -05:00
Thierno IB. BARRY
32d4a8811c Elasticsearch: Add proxy support
Add proxy support for plugin installation.
2016-12-08 11:33:49 -05:00
Alex Kalinin
126f8b709f Fix opening libvirt esx connection 2016-12-08 11:33:49 -05:00
Brian Coca
51e034a8cc fixed version added 2016-12-08 11:33:49 -05:00
James Cammarata
f1e50f7616 Adding version_added field to logdest field for puppet module 2016-12-08 11:33:49 -05:00
Monty Taylor
d8f35dfb18 Add option to send puppet apply logs to syslog
While returning puppet logs as ansible stdout is useful in some cases,
there are also cases where it's more destructive than helpful. For
those, local logging to syslog so that the ansible logging makes sense
is very useful.

This defaults to stdout so that behavior does not change for people.
2016-12-08 11:33:49 -05:00
Brian Coca
c7f4fbb8a7 corrected parameter name and added missing description 2016-12-08 11:33:49 -05:00
Brian Coca
e25032cc86 fixed misppelled description 2016-12-08 11:33:49 -05:00
Toshio Kuratomi
7a686ab6d8 U() markings in pushover docs should remain but need to be uppercased.
pri description needs to be a list.
2016-12-08 11:33:49 -05:00
Baptiste Mille-Mathias
1c3bbfe767 remove unicode prefix and correct text in table
Remove the unicode prefix displayed before the url pushover.net
Attempt to correct the text in the table which appear vertically.
2016-12-08 11:33:48 -05:00
Jiri Tyr
014d78e78d Adding params option into the yumrepo module 2016-12-08 11:33:48 -05:00
Tim Rupp
6ef0c71523 Fixes missing validate_certs parameter
The bigip_api method was changed in the module_utils function definition
to include the validate_certs option but the bigip_virtual_server module
was not updated accordingly. This patch updates the method so that the
error message below is not returned to the user

received exception: bigip_api() takes exactly 4 arguments (3 given)
2016-12-08 11:33:48 -05:00
Johan Wirén
c54841fb3e Keep, but ignore createparent option 2016-12-08 11:33:48 -05:00
Johan Wirén
dc15c98e6f Removes the createparent property.
The least surprising thing is to always create parents
2016-12-08 11:33:48 -05:00
Johan Wirén
7bb79093c2 Only considers local attributes when comparing state
This should fix #1092
2016-12-08 11:33:48 -05:00
Johan Wirén
14a0cf142d Documentation fixes 2016-12-08 11:33:48 -05:00
Johan Wirén
a410f524b4 Update example 2016-12-08 11:33:48 -05:00
Johan Wirén
e08638b737 Changes how zfs properties are handled
This moves the validation of properties to the zfs command itself. The
properties and their choices were not really correct anyway due to
differences between OpenZFS and Solaris/ZFS.
2016-12-08 11:33:48 -05:00
Charles Ferguson
f4a533fa95 Update 'patch' documentation for src, remote_src, backup and binary.
The patch module has a few missing items, and inconsistencies, in its
documentation. A few of which are addressed here.

Within Ansible documentation, the choices for boolean values are
commonly 'yes', and 'no'. We standardise the options on that.

'remote_src' documentation uses 'False' and 'True' for its documentation,
so these have been updated in both the choices and default.

'src' documentation refers to 'remote_src', so is updated to use
the 'no' choice.

'backup' did not describe its options and default at all, so we add
them.

'binary' default used 'False', but specified the type as 'bool' which is
implicitly documented as 'yes'/'no', so we make that 'no' as well.
2016-12-08 11:33:48 -05:00
Toshio Kuratomi
96f1bd82c0 Allow dnf to remove dependent packages of a package that is being removed
Fixes #1517
2016-12-08 11:33:48 -05:00
Matt Martz
78759c667a Fix DOCUMENTATION for ec2_vpc_dhcp_options.py and add missing RETURN to ec2_vol_facts.py 2016-12-08 11:33:48 -05:00
Sumit Roy
8eeb30da3d Ensure that port_path is split into at most 2 components.
cloudstack: cs_instance: fix do not require name to be set to avoid clashes

Require one of display_name or name. If both is given, name is used as identifier.

cloudstack: fix name is not case insensitive

cloudstack: cs_template: implement state=extracted

Update f5 validate_certs functionality to do the right thing on multiple python versions

This requires the implementation in the module_utils code here
https://github.com/ansible/ansible/pull/13667 to funciton

fixed domain_id to actually be supported

also added domain as an alias
alt fixes #1437

Simplify the code and remove use_unsafe_shell=True

While there is no security issue with this shell snippet, it
is better to not rely on shell and avoid use_unsafe_shell.

Fix for issue #1074. Now able to create volume without replica's.

Improved fix for #1074. Both None and '' transform to fqdn.

Fix for ansible-modules-extras issue #1080
2016-12-08 11:33:48 -05:00
Vincent VAN HOLLEBEKE
3fd5173413 Do not fail when action is delete and volume is not present
This prevents failing when a playbook describes a volume deletion and
is launched more that once.

Without this fix, if you run the playbook a second time, it will fail.
2016-12-08 11:33:48 -05:00
Chad Nelson
89baffa06f Doc wrongly indicates permanent is required
But it isn't. :)
2016-12-08 11:33:48 -05:00
Brian Coca
91ff5ce256 added missing verison_added 2016-12-08 11:33:48 -05:00
Mstislav Bobakov
dcc841d8d6 Add custom parameter for a sensu_check. revert newline 2016-12-08 11:33:47 -05:00
Mstislav Bobakov
b649a15a97 Add custom parameter for a sensu_check. Fixes.
JSON replaced within dict.
Added more docs.
2016-12-08 11:33:47 -05:00
Mstislav Bobakov
1665254453 Add custom parameter for a sensu_check 2016-12-08 11:33:47 -05:00
Brian Coca
4873b941ff added missing version_added 2016-12-08 11:33:47 -05:00
Daniel Vigueras
4c60c2acc1 iptables: add --limit-burst option 2016-12-08 11:33:47 -05:00
Joel Thompson
bace230f25 Add new ec2_vpc_dhcp_options module
This module manages EC2 DHCP options for a given VPC. It allows you to
specify all the options which AWS allows you to set in a DHCP option
set.
2016-12-08 11:33:47 -05:00
Shawn Siefkas
7cf0f8a7f6 Fixing check mode support for vpc route tables
Loop compatibility for dry run exception handling

Route table deletion dry run handler

Fixing regression in propagating_vgw_ids default value

Adjusting truthiness of changed attribute for route manipulation

Updating propagating_vgw_ids default in docstring
2016-12-08 11:33:47 -05:00
Hans-Joachim Kliemeck
84a5a7a831 fail if type parameter is empty 2016-12-08 11:33:47 -05:00
Hans-Joachim Kliemeck
9a533f1b5f added credits, fixed documentation 2016-12-08 11:33:47 -05:00
Hans-Joachim Kliemeck
464fb89698 made win_acl strict compliant 2016-12-08 11:33:47 -05:00
Hans-Joachim Kliemeck
8f7517ac21 fixed problem with sid/windows 2008 by using SID. fixed problems related to default accounts like BUILTIN\SYSTEM 2016-12-08 11:33:47 -05:00
wimnat
6d239c6a3f New module - ec2_vol_facts 2016-12-08 11:33:47 -05:00
Corwin Brown
dd918401f8 Added Error messages to the Try/Catch blocks 2016-12-08 11:33:47 -05:00
Corwin Brown
e0fa5fa74c Switching to Get-AnsibleParam
Switching to Win_Unzip
2016-12-08 11:33:47 -05:00
Corwin Brown
34ff61e24f Made Powershell Strict Complient 2016-12-08 11:33:47 -05:00
Marian Rusu
e0e45bd383 Enable managing multiple user permissions rules from one shot
One of inconvinence this address is the the fact that
you have to pass user's tags even if you just want to
add a permission rule

Signed-off-by: Marian Rusu <rusumarian91@gmail.com>
2016-12-08 11:33:47 -05:00
Baptiste Mille-Mathias
06b3d39076 fix typo
conainerization => containerization
2016-12-08 11:33:46 -05:00
Daniel Jakots
ffc291bc9a fix the spelling of vim's flavor in the example 2016-12-08 11:33:46 -05:00
Toshio Kuratomi
255c4b01a8 Remove duplicate documentation fields 2016-12-08 11:33:46 -05:00
Dale Smith
7404418cbd Fix regression of #821 in puppet of show_diff
Issue #821 fix: 1382576100ee3b17f4eb28c7186d92376f370676
Regressed since: 6912ca0acaed0d738d8dd9867721d2ff0094084a

Issue: #821
2016-12-08 11:33:46 -05:00
Ashley Penney
48c075d363 Fix package list for nmcli module.
There was a missing package that causes this to fail.
2016-12-08 11:33:46 -05:00
Ashley Penney
58aa9d38b8 Change example to include ethernet as the type. 2016-12-08 11:33:46 -05:00
tcr
7a1284fe70 Fix #1512 add missing property in win_firewall_rule 2016-12-08 11:33:46 -05:00
RajeevNambiar
77ca6641cb Update sts_assume_role.py for showing the correct example syntax role_session_name instead of session_name
Update sts_assume_role.py for showing the correct example syntax role_session_name instead of session_name. session_name is not a valid property.
2016-12-08 11:33:46 -05:00
Yannig Perré
bf5fbfe2a7 Use -f when pvcreate to avoid interactive input. Fix https://github.com/ansible/ansible-modules-extras/issues/1504 2016-12-08 11:33:46 -05:00
Daniel Vigueras
801e895f62 iptables: fix param check in append_csv function 2016-12-08 11:33:46 -05:00
Michal Mach
855bf75709 Fix seport module issue when ports argument is interpolated from a variable and is a int 2016-12-08 11:33:46 -05:00
Alexander Bulimov
23675c3f8b Allow recreation of same FS with force=yes 2016-12-08 11:33:46 -05:00
Alexander Gubin
58f3518666 Make fileystem module idemponent. Compare devicesize and filesystemsize. 2016-12-08 11:33:46 -05:00
Robb Wagoner
f7c044badf InService percent key as literal percent (i.e 50, not .5) 2016-12-08 11:33:46 -05:00
Robb Wagoner
8f2eff6ca8 Include instance states (InService or OutOfService) as ELB facts 2016-12-08 11:33:46 -05:00
Mike Liu
fafb89cde5 Check that the current output from 'list_users' command contains a '\t'.
The `rabbitmqctl list_users` command will list the user's last login time
which does not include `\t` character. This is causing a ValueError exception
when attempting to split a user and its tags from the command output. This
fix will check for a `\t` in the current line of the output before splitting.
2016-12-08 11:33:45 -05:00
Rob White
d608dee29f Add missing doc fragments 2016-12-08 11:33:45 -05:00
Matt Martz
38c258d9de Add functionality to give multiple iterative responses for a question in expect 2016-12-08 11:33:45 -05:00
colynn.liu
ed48fb0f25 fixed python 2.4 compatibility
nf=tempfile.NamedTemporaryFile(delete=False)
TypeError: NamedTemporaryFile() got an unexpected keyword argument 'delete'
2016-12-08 11:33:45 -05:00
David Shrewsbury
ccee183143 Fix exception output for os_keystone_domain.
The message attribute of a shade exception is not very helpful.
Converting to a full string will contain many more details.
2016-12-08 11:33:45 -05:00
Scott Bonds
7f1ccad39b add python 2.5 requirement and ansible 2.1 version_added 2016-12-08 11:33:45 -05:00
Scott Bonds
056a532d75 add ports support in openbsd_pkg 2016-12-08 11:33:45 -05:00
Rene Moser
10be5eb908 cloudstack: cs_portforward: fix missing return and remove unused arg 2016-12-08 11:33:45 -05:00
Björn Lichtblau
f9383cb8ef Check to make sure the firewalld client is connected before proceeding.
Fixes #1138

Original patch referenced in https://github.com/ansible/ansible/issues/6911 ( f547733b1f ) was undone by 6f2b61d2d8
2016-12-08 11:33:45 -05:00
David Shrewsbury
17e9b85228 Update Keystone Domain module for latest shade 2016-12-08 11:33:45 -05:00
Monty Taylor
072cf69cc1 Extract module for keystone domain management 2016-12-08 11:33:45 -05:00
Haneef Ali
e4e88807e8 Ansible module for Keystone V3 API
Change-Id: I9db323cc9e5a42353cab5cf4be6e22449cef8542
2016-12-08 11:33:45 -05:00
Charles Paul
8e0d982204 use doc fragments 2016-12-08 11:33:45 -05:00
Tom X. Tobin
1223143ebe osx_defaults: Fix boolean value parsing
Values for boolean types were being unconditionally treated as strings
(by calling `.lower()`), thus breaking value parsing for actual boolean
and integer objects.

It looks like the bug was introduced in:

- 130bd670d82cc55fa321021e819838e07ff10c08

Fixes #709.
2016-12-08 11:33:45 -05:00
lipanski
9d355fb5af Fix: Rename gem_install_path to gem_path - as specified in the docs 2016-12-08 11:33:45 -05:00
Linus Unnebäck
a928198783 iptables: cleanup 2016-12-08 11:33:44 -05:00
Jeroen Geusebroek
f1c3eb1413 Fix documentation default value for gluster_volume start_on_create 2016-12-08 11:33:44 -05:00
Toshio Kuratomi
5c6a3a348e Trick ansible-modules-validate to pass this with no RETURN.
This is a module present in 1.9 so we have to have it in even though it doesn't have RETURN
2016-12-08 11:33:44 -05:00
Alejandro Guirao
59fce041af Change for enabling future tests 2016-12-08 11:33:44 -05:00
Alejandro Guirao
315c4e773c Change example to match a severity providen by Taiga out-of-the-box 2016-12-08 11:33:44 -05:00
Alejandro Guirao
f8df9e12d4 Minor example change 2016-12-08 11:33:44 -05:00
Alejandro Guirao
03117f9337 Fix version_added in DOCUMENTATION 2016-12-08 11:33:44 -05:00
Alejandro Guirao
4a17a20679 Fix DOCUMENTATION typo 2016-12-08 11:33:44 -05:00
Alejandro Guirao
6c776c687b Add taiga_issue module 2016-12-08 11:33:44 -05:00
Jose A. Rivera
73a9abd1c8 gluster_volume: allow probing ourselves
We should allow "gluster peer probe" to determine if a given "host" maps to the
localhost, and detect that case accordingly.
2016-12-08 11:33:44 -05:00
Constantin07
e20317b3be Print explicit error cause when no ELBs are found in AWS 2016-12-08 11:33:44 -05:00
Stepan Stipl
9bba1b66c5 Fix: route53_facts hosted_zone_id boto error
Boto is expecting parameter called "Id", not "HostedZoneId".
See
http://boto3.readthedocs.org/en/latest/reference/services/route53.html#Route53.Client.get_hosted_zone

Fixes ansible/ansible-modules-extras/#1465
2016-12-08 11:33:44 -05:00
Stanislav Ivchin
699a570f8b little fix: facts['path'] -> facts['project_path'] 2016-12-08 11:33:44 -05:00
Dreamcat4
49fe0b7815 win_regedit: fixes #1404
When 'value:' is set to be the key's  "(default)" property value
2016-12-08 11:33:44 -05:00
Benjamin Wilson
0a8310b29f Properly handle adding multiple bricks to volume 2016-12-08 11:33:44 -05:00
Toshio Kuratomi
ad0d2c1747 Update for modules which import json.
Some do not use the json module directly so don't need import json.
Some needed to fallback to simplejson with no traceback if neither was installed

Fixes #1298
2016-12-08 11:33:44 -05:00
Sebastien Couture
db051ff9d2 removed comment 2016-12-08 11:33:43 -05:00
Sebastien Couture
b50980d912 Added support for DNS SRV records 2016-12-08 11:33:43 -05:00
Jonathan Mainguy
be5dd09237 add snapshot feature to lvol 2016-12-08 11:33:43 -05:00
Alexander Winkler
dca9d618f0 fixed inline for more compatibility 2016-12-08 11:33:43 -05:00
Alexander Winkler
c730bd6f1c Added update_catalog and some error handling 2016-12-08 11:33:43 -05:00
Rob
2916a8bf5d Add secondary addresses to facts 2016-12-08 11:33:43 -05:00
Brian Coca
b014769c30 added note on choice version availability 2016-12-08 11:33:43 -05:00
Jordan Cohen
63bdeb6e6f support for event alert monitors 2016-12-08 11:33:43 -05:00
Brian Coca
fbc52c233a added version_added 2016-12-08 11:33:43 -05:00
Brad Wilson
37de6e7fd6 Add apply_to option to rabbitmq_policy 2016-12-08 11:33:43 -05:00
Yoshinori Teraoka
47b09873e2 add executable parameter to cpanm module
like other packaging modules (pip, gem)
2016-12-08 11:33:43 -05:00
Brian Coca
a57da4e329 added version info on autodetection feature 2016-12-08 11:33:43 -05:00
Łukasz Proszek
d2f060f278 add lxc support, without dropping openvz 2016-12-08 11:33:43 -05:00
Javier Palacios
9dcea19175 Allow relative path for bower executable
Add default value

Rename argument

Explicit verification of relative bower path

Add example

Old keyword name used in example

BUGFIX: tilde expansion actually useless on relative paths

Modify relative_execpath default value as suggested

Added version_added for relative_execpath

Update for last few comments on the bug report

* version to 2.1 since this feature enhancement will now go into 2.1
* set path and relative_execpath type to path
* Set default value of path to None
2016-12-08 11:33:43 -05:00
Toshio Kuratomi
0501a18608 Really disable RETURN 2016-12-08 11:33:43 -05:00
Toshio Kuratomi
c98db451ac Disable RETURNS because the approved module doesn't have a RETURNS that is buildable 2016-12-08 11:33:43 -05:00
Mark Chance
ac86f8f0ad fix, update the documentation of the modules 2016-12-08 11:33:42 -05:00
Mark Chance
00bd01c293 WIP documentation update 2016-12-08 11:33:42 -05:00
Mark Chance
7634539da7 add author tag in doc 2016-12-08 11:33:42 -05:00
Mark Chance
a1429f868b update version, fix fail msgs 2016-12-08 11:33:42 -05:00
Mark Chance
9aa40a5826 cloud amazon ECS service modules 2016-12-08 11:33:42 -05:00
Toshio Kuratomi
b8e95535c2 Add a returns section for bigip_virtual-server 2016-12-08 11:33:42 -05:00
Toshio Kuratomi
e1bf46a32a Fix documentation build 2016-12-08 11:33:42 -05:00
Charles Paul
3cd6e4c1f8 make dest use path type
path type
2016-12-08 11:33:42 -05:00
Toshio Kuratomi
0d66ac6f6f Update the version_added to 2.1 2016-12-08 11:33:42 -05:00
Etienne CARRIERE
e85519a967 Developpement of enabled/disabled state 2016-12-08 11:33:42 -05:00
Etienne CARRIERE
824d57e852 Apply changes according to the review 2016-12-08 11:33:42 -05:00
Etienne CARRIERE
292e0a2275 Take review comments in accounts (pull request :582) 2016-12-08 11:33:42 -05:00
Etienne CARRIERE
c51c36d8d7 Add "Default Persistence profile" support 2016-12-08 11:33:42 -05:00
Etienne CARRIERE
3c06b968bc Rework on Exception management 2016-12-08 11:33:42 -05:00
Etienne CARRIERE
37cb6519af Localize exceptions for F5 LTM virtual server module 2016-12-08 11:33:42 -05:00
Etienne CARRIERE
ed3a2ca136 Factor F5 virtual_server module with the common functions 2016-12-08 11:33:42 -05:00
Etienne CARRIERE
0fb56e4c5b Creation of bigip_virtual_server module 2016-12-08 11:33:42 -05:00
Rene Moser
5430497151 cloudstack: fixes and improvements
cs_instance: fix case insensitivity
cs_instance: remove duplicate code block
cs_securitygroup_rule: fix KeyError on older ACS
2016-12-08 11:33:41 -05:00
Jonathan Mainguy
badef2912b Remove advertising show_diff feature
--diff will be added to more modules soon, and we want puppet module to utilize this instead of show_diff
2016-12-08 11:33:41 -05:00
Casey Lang
1c8ad72b7b Fix puppet module formatting issue
The `->` in the `show_diff` option doc seemed to be causing the docs
page to break. Not sure why, since it was still valid YAML.
2016-12-08 11:33:41 -05:00
Charles Paul
bc21c565fe adding no_log to password 2016-12-08 11:33:41 -05:00
ag-wood
67cd464ac7 Fix for ansible-modules-extras issue #1080 2016-12-08 11:33:41 -05:00
Jeroen Geusebroek
0b12f35f61 Improved fix for #1074. Both None and '' transform to fqdn. 2016-12-08 11:33:41 -05:00
Jeroen Geusebroek
6fc533d663 Fix for issue #1074. Now able to create volume without replica's. 2016-12-08 11:33:41 -05:00
Michael Scherer
d504253257 Simplify the code and remove use_unsafe_shell=True
While there is no security issue with this shell snippet, it
is better to not rely on shell and avoid use_unsafe_shell.
2016-12-08 11:33:41 -05:00
Brian Coca
896eecfdad fixed domain_id to actually be supported
also added domain as an alias
alt fixes #1437
2016-12-08 11:33:41 -05:00
Toshio Kuratomi
6a02b17a2e Update f5 validate_certs functionality to do the right thing on multiple python versions
This requires the implementation in the module_utils code here
https://github.com/ansible/ansible/pull/13667 to funciton
2016-12-08 11:33:41 -05:00
Rene Moser
d2db491098 cloudstack: cs_template: implement state=extracted 2016-12-08 11:33:41 -05:00
Rene Moser
75456f7b3a cloudstack: fix name is not case insensitive 2016-12-08 11:33:41 -05:00
Rene Moser
e484e0dbda cloudstack: cs_instance: fix do not require name to be set to avoid clashes
Require one of display_name or name. If both is given, name is used as identifier.
2016-12-08 11:33:41 -05:00
Matt Martz
bc8bbee640 Update .travis.yml to remove the validation exclusion for route53_zone 2016-12-08 11:33:41 -05:00
Matt Martz
51f9961b17 Update excludes with currently failing modules 2016-12-08 11:33:40 -05:00
Matt Martz
74c3e008d2 Import module snippets in the correct location 2016-12-08 11:33:40 -05:00
Matt Martz
22733a7574 Fix tabbed indentation in packaging/os/pkgutil.py 2016-12-08 11:33:40 -05:00
Matt Martz
8c14013b95 Fix tabbed indentation in network/haproxy.py 2016-12-08 11:33:40 -05:00
Matt Martz
7f42dda976 Remove unneeded spaces at the end of ohai 2016-12-08 11:33:40 -05:00
Matt Martz
3992ce127e Use ansible-testing project to validate basic module requirements 2016-12-08 11:33:40 -05:00
Brian Coca
e60d7cc840 added examples to route53_zone
fixes #1061
2016-12-08 11:33:40 -05:00
quoing
6f782c342f Fix 'An error occurred while looking up _xmpp-client._tcp.10.100.1.108' when IP host is configured
...
    jabber: user=ansible@mydomain.tld
            host=10.100.1.108
...

fatal: [bruce.mess.cz] => failed to parse: Invalid debugflag given: always
Invalid debugflag given: nodebuilder
2016-12-08 11:33:40 -05:00
Michael Scherer
df195b3076 Replace choices=BOOLEANS by type='bool', fix #1326 2016-12-08 11:33:40 -05:00
Rene Moser
c7f6b5e41f cloudstack: cs_volume: simplify detach on state=absent 2016-12-08 11:33:40 -05:00
Joel Thompson
3796e26a9d Add no_log=True to consul modules' API tokens
API tokens should be considered sensitive and not logged.
2016-12-08 11:33:40 -05:00
Gauvain Pocentek
165e025a6d Add an __init__.py file in openstack/
The os_project module doesn't get installed if the __init__ file doesn't
exist in the repository.
2016-12-08 11:33:40 -05:00
Jonathan Mainguy
a50b661e54 Unify mysql modules.
Added config_file, ssl_ca, ssl_cert, ssl_key, changed connect method, added error checking where a backtrace previoussly was possible
2016-12-08 11:33:40 -05:00
Zach Abrahamson
7d072140b3 Wrapping room parameter in a string in case of using room IDs 2016-12-08 11:33:40 -05:00
Marc Mettke
43d2e3ad68 Pacman Module Fixes
Update: query_package documentation
Fix: Number of Packages to Updated was one to high,
     'cause of counting the '\n'
Fix: Pacman was reinstalling state=latest packages,
     even when it was unable to load the remote version
2016-12-08 11:33:40 -05:00
Robert Lu
c588be9bd8 check current version's existence (fire or cleanup)
* reserve current version when cleanup
* verify existence before fire a new version
* update doc of deploy_helper
2016-12-08 11:33:39 -05:00
Rene Moser
8ac9901481 cloudstack: cs_volume fixes and improvments
cloudstack: cs_volume:  fix not usable in older cloudstack versions

affects CCP 4.3.0.2 , but not ACS / CCP 4.5.1
closes #1321

cloudstack: cs_volume: fix uable to create volumes with the same name on multiple zones

cloudstack: cs_volume: use type bool and fix python3 support
2016-12-08 11:33:39 -05:00
Brian Coca
8687151f7c fix error with misArg not being declared
also fixed test to work on empty string or not for error reporting
2016-12-08 11:33:39 -05:00
Robert Lu
d9337fbd9c update current_link without downtime
fix support of check mode
fix check module when needn't update current link
2016-12-08 11:33:39 -05:00
Monty Taylor
40a4247611 Sync minor fixes from OpenStack Infra
Infra has been keeping a local copy of this waiting for ansible 2 to
release. In getting ready for ansible 2 (and our ability to delete our
local copy of the file, I noticed we had a couple of minor cleanups.

Also, the timeout command is there to improve life and workaround puppet
deficiencies. However, it's not working around deficiencies on systems
that do not have the timeout command if we blindly use it.

The puppet specific timeout options are more complex and out of scope of
this.

Issue: #1273
2016-12-08 11:33:39 -05:00
Rene Moser
7ecbd8e34e cloudstack: cs_instance: fixes and improvements
- cs_instance: fix VM not updated with states given stopped, started, restarted
  A missing VM will be created though but an existing not updated. This fixes the lack of consistency.

- cs_instance: fix user data can not be cleared

- cs_instance: fix deleted VM not recovered on state=present
2016-12-08 11:33:39 -05:00
gfrank
9387c842a1 Use "" for AppParameters if it's null 2016-12-08 11:33:39 -05:00
Rene Moser
5f43afff5b cloudstack: cs_facts: fix wrong description of returns cloudstack_public_ipv4, cloudstack_public_hostname
Also see http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.6/api.html#user-data-and-meta-data
2016-12-08 11:33:39 -05:00
Rene Moser
73c6a35cae cloudstack: cs_instance: implement state=restored 2016-12-08 11:33:39 -05:00
autotune
fa852c14fe Fixed bug to recognize haproxy changes 2016-12-08 11:33:39 -05:00
Brian Coca
ccb5829673 added missing version_added to new options 2016-12-08 11:33:39 -05:00
Guido Lorenz
42d89dec18 win_chocolatey: Clean up documentation 2016-12-08 11:33:39 -05:00
Guido Lorenz
633773f386 win_chocolatey: Add install_args, params and ignoredependencies 2016-12-08 11:33:39 -05:00
Vladimir Dimov
cb338ccb46 Doc fix ec2_vpc_route_table.py 2016-12-08 11:33:39 -05:00
Vladimir Dimov
74a0665530 Doc fix on route53_health_check.py. Fixed first example. Should be register instead of record. 2016-12-08 11:33:39 -05:00
Kirill Kozlov
6f663fa7bf Set latest as version argument default value 2016-12-08 11:33:38 -05:00
Brian Coca
a9abec5a03 updated version version_added to 2.1 2016-12-08 11:33:38 -05:00
Dylan Martin
766b53b066 added version option 2016-12-08 11:33:38 -05:00
Will Keeling
f1f98a15ca Fixes #634 - multiple param handling by modprobe.py 2016-12-08 11:33:38 -05:00
Brian Coca
4db5119893 corrected version_added for new monit timeout opt 2016-12-08 11:33:38 -05:00
Björn Andersson
d577fedc26 monit: Set a high timeout waiting for status changes
Instead of waiting for up to a certain number of retries we set a high
timeout and only re-check every five seconds. Certain services can
take a minute or more to start and we want to avoid waisting resources
by polling too often.
2016-12-08 11:33:38 -05:00
Björn Andersson
69e9bd3406 monit: Add version_added and type for new argument 2016-12-08 11:33:38 -05:00
Björn Andersson
757c9bffee monit: Wait for pending state changes for reloads
@mpeters reported that we're not checking that the named service is
actually there after a reload. And that sometimes monit doesn't actually
return anything at all after a reload.
2016-12-08 11:33:38 -05:00
Björn Andersson + SU Sheng Loong
469bf9ebd0 monit: Add retry for pending/initializing services
If there are already ongoing actions for a process managed by monit, the
module would exit unsuccessfully. It could also give off false positives
because it did not determine whether the service was started/stopped
when it was in a pending state. Which might be turning the service off,
but the action was to start it.

For example "Running - pending stop" would be regarded as the service
running and "state=enabled" would do nothing.

This will make Ansible wait for the state to finalize, or a timeout decided
by the new `max_retries` option, before it decides what to do.

This fixes issue #244.
2016-12-08 11:33:38 -05:00
Michal Svab
5f743c4fdc maven_artifact: check whether snapshot is the latest snapshot 2016-12-08 11:33:38 -05:00
Matthew Jones
d24f02fd39 Fix up vsphere_copy after open_url change
* Remove leading module parameter on open_url call as it's no longer used
  by module_utils.urls.open_url
* Force basic auth otherwise vsphere will just return a 401
2016-12-08 11:33:38 -05:00
twmartin
33ee8d6f89 Correct 'object not iterable' TypeError 2016-12-08 11:33:38 -05:00
Bruce Pennypacker
e5970186ad Remove extraneous space from end of command string in nagios_cmd 2016-12-08 11:33:38 -05:00
daveres
ab7aa73cdb Correct problem with changed:true
I have just changed a small piece of this module to avoid to return always that the task is changed
2016-12-08 11:33:38 -05:00
Chrrrles Paul
0606233431 Changing docs to reflect vm_name as the default vm_id_type 2016-12-08 11:33:38 -05:00
Rob
103be7ab51 Added missing else statement that caused existing rules to be discarded 2016-12-08 11:33:38 -05:00
Charles Paul
caea50ba4d pep8 whitespace 2016-12-08 11:33:37 -05:00
Charles Paul
a1efe9486a upped version added, search by vm_name by default 2016-12-08 11:33:37 -05:00
Ritesh Khadgaray
8f362afc34 vmware_vm_shell: add the ability to start program without network connection 2016-12-08 11:33:37 -05:00
Toshio Kuratomi
6f40bab20f Simplify code 2016-12-08 11:33:37 -05:00
Guido Günther
13deae9b8f zypper: Add returncode to result
This will be used in integration tssts and makes the whole thing
more similar to the yum module.
2016-12-08 11:33:37 -05:00
Gordon Fierce
c23162c04b Fix documentation to prevent formatting error where each letter has its own line. 2016-12-08 11:33:37 -05:00
Brian Geihsler
30da816c54 Fix #1101: win_webpicmd strict mode fixes 2016-12-08 11:33:37 -05:00
Brian Coca
c60d6cad72 corrected version added to 2.1 2016-12-08 11:33:37 -05:00
Rob
f547c37db4 Use doc fragment and fix examples 2016-12-08 11:33:37 -05:00
Rob
2b0fc33fd5 Tolerate missing classic_link_enabled attribute 2016-12-08 11:33:37 -05:00
whiter
a873e9a3cb New module - ec2_vpc_net_facts 2016-12-08 11:33:37 -05:00
Atsushi Sasaki
6278cef67b Enable to resize a volume with cs_volume 2016-12-08 11:33:37 -05:00
gfrank
5b3363d178 Replace slashes in the parameter string Also remove duplicate documentation 2016-12-08 11:33:37 -05:00
Michael Scherer
4e4085ad7e Add a more explicit error message, fix #1282 2016-12-08 11:33:37 -05:00
Adam Keech
28baed011d Appending "Registry::" is not needed and no longer works. 2016-12-08 11:33:37 -05:00
Guillaume Grossetie
af12e6d3a3 Resolves #1312, Improve pam_limits documentation
Adds comment parameter and improve examples.
2016-12-08 11:33:37 -05:00
Michael Weber
bee443c983 Fix error 'fail_json() takes exactly 1 argument'
Fixes bug #1257
2016-12-08 11:33:36 -05:00
Josh Gachnang
058feb47c2 Fix mongodb_user docs typo
Bob's last name is Belcher: http://bobs-burgers.wikia.com/wiki/Bob_Belcher.

These docs made me chuckle, so thanks :)
2016-12-08 11:33:36 -05:00
Toshio Kuratomi
5bd1bcaa2d Don't raise or catch StandardError in amazon modules 2016-12-08 11:33:36 -05:00
GUILLAUME GROSSETIE
5fbc5cb529 Resolves #1290, Adds limit_type choice "-" 2016-12-08 11:33:36 -05:00
Rene Moser
2715cbffb7 cloudstack: new module cs_volume 2016-12-08 11:33:36 -05:00
Xav Paice
f30dbc9b20 Added stdout and stderr to puppet output for rc=2 2016-12-08 11:33:36 -05:00
Tom Bamford
fa9e1fd384 Ensure tag values get updated in ec2_vpc_subnet 2016-12-08 11:33:36 -05:00
Ryan Sydnor
1899e9e6cc Use boto normalized location for bucket creation
If a bucket is being created in us-east-1, the module passed
'us-east-1' to boto's s3.create_bucket method rather than
Location.DEFAULT (an empty string). This caused boto to generate
invalid XML which AWS was unable to interpret.
2016-12-08 11:33:36 -05:00
Hans-Joachim Kliemeck
b3ffcd7c6c fix race condition and missing property 2016-12-08 11:33:36 -05:00
Jiri tyr
d4d24bac60 Adding yumrepo module
This patch is adding a new module which allows to add and remove YUM
repository definitions. The module implements all repository options
as described in the `yum.conf` manual page.
2016-12-08 11:33:36 -05:00
Brian Coca
4ddb181d71 removed json import 2016-12-08 11:33:36 -05:00
Toshio Kuratomi
f68b88b84d Quote strings that make the module docs fail to build 2016-12-08 11:33:36 -05:00
Toshio Kuratomi
d6db0f3981 Switch StrictVersion for LooseVersion since some distros ship beta versions and StrictVersion would fail on that.
Also clean up some minor style things
2016-12-08 11:33:36 -05:00
Olaf Kilian
c048990419 Add requirement and check for compatible version of docker-py 2016-12-08 11:33:36 -05:00
Olaf Kilian
64838bb52d Set no_log for password argument 2016-12-08 11:33:35 -05:00
Olaf Kilian
7c8d1a1d0a Improve registry key parity between clients * Don't extract hostname part from docker_url since this leads to docker CLI client not recognizing Docker Hub credentials set by docker_login module anymore (looks for the full URL as a key). 2016-12-08 11:33:35 -05:00
Olaf Kilian
b826aa6b35 Rework change detection 2016-12-08 11:33:35 -05:00
Olaf Kilian
348cab4511 Adapt to new dockercfg file location and structure 2016-12-08 11:33:35 -05:00
Olaf Kilian
d330f72213 Make module importable for unit tests 2016-12-08 11:33:35 -05:00
Olaf Kilian
32862e737f Set default for email parameter to None 2016-12-08 11:33:35 -05:00
Olaf Kilian
dab1588253 Add requirement for python >= 2.6 2016-12-08 11:33:35 -05:00
Olaf Kilian
4ea0125dc6 Default registry to docker hub 2016-12-08 11:33:35 -05:00
Olaf Kilian
a64bae30b5 Added more meaningful fail messages on Docker API 2016-12-08 11:33:35 -05:00
Olaf Kilian
dfaa1ec528 Added default email address 2016-12-08 11:33:35 -05:00
Olaf Kilian
36330d00ad Removed unused import of sys module 2016-12-08 11:33:35 -05:00
Olaf Kilian
e998090d52 Extract only the hostname part from self.registry This is needed for update_dockercfg() to register only the host part of a specified registry URL in the .dockercfg. 2016-12-08 11:33:35 -05:00
Olaf Kilian
c42d94edd1 Remove registry from exit_json because misleading docker-py is not returning the name of the registry if already logged in. It can differ from the registry specified by the user, which was return as registry. 2016-12-08 11:33:35 -05:00
Olaf Kilian
9d69e78f18 Update PR based on review from @resmo 2016-12-08 11:33:34 -05:00
Olaf Kilian
d23f78c799 Add docker_login module - Ansible version of "docker login" CLI command - Persists Docker registry authentification in .dockercfg (only login once - no need to specify credentials over and over again anymore) - Works for all other docker-py based modules (docker, docker_images) as well as the Docker CLI client 2016-12-08 11:33:34 -05:00
Romain Brucker
e8b5b8bd20 Editing iptable module to use -m state --state instead of -m conntrack --ctstate 2016-12-08 11:33:34 -05:00
Alberto Gireud
a7b90cf456 Fix return documentation 2016-12-08 11:33:34 -05:00
Alberto Gireud
bbdebd7548 Add openstack project module 2016-12-08 11:33:34 -05:00
Jonathan Davila
66569ab725 Sendgrid docs fix 2016-12-08 11:33:34 -05:00
Brian Coca
507986703c corrected choices which was meant to be type 2016-12-08 11:33:34 -05:00
James Cammarata
df517b5f03 Version bump for new beta 2.0.0-0.5.beta3 2016-12-08 11:33:34 -05:00
Jonathan Mainguy
c277a8b191 Added style= and more colors. 2016-12-08 11:33:34 -05:00
YAEGASHI Takeshi
ae72b7c12c New module: blockinfile 2016-12-08 11:33:34 -05:00
Indrajit Raychaudhuri
92efb6eb51 homebrew: Aditional examples for documentation 2016-12-08 11:33:34 -05:00
Indrajit Raychaudhuri
273d1c51e6 homebrew: Add explicit documentation for 'path' argument (with expected default)
In Homebew, a formula is installed in a location relative to the actual
`brew` command. The documentation clarifies that.

Additionally, removed redundant 'path' reconstruction in multiple places.
2016-12-08 11:33:34 -05:00
Caduri
a364ec5483 exchange name contains chars that needs to be quoted 2016-12-08 11:33:34 -05:00
Joel Thompson
5bedb1f12d Add sns_topic module to manage AWS SNS topics
This adds an sns_topic module which allows you to create and delete AWS
SNS topics as well as subscriptions to those topics.
2016-12-08 11:33:34 -05:00
Etherdaemon
0fbfcc3b20 Add new module to allow for getting and listing of Route53 relevant details 2016-12-08 11:33:34 -05:00
Kenny Gryp
c908c0663d revert to unbreak pull request 2016-12-08 11:33:34 -05:00
Kenny Gryp
c766cbd98a in order for replication setup to work, some errors should be ignored 2016-12-08 11:33:33 -05:00
Kenny Gryp
4e401fc4e6 including error code and error number when database connection creation fails 2016-12-08 11:33:33 -05:00
Robin Roth
85f2165273 better cope with rpm not returning package name
if the rpm query is missing a package name (or giving some error): fail soft

before the patch: the module fails because the installed_state dict is missing the package name

after the patch: the missing package is assumed to not be in the correct state and is installed/removed with zypper
2016-12-08 11:33:33 -05:00
xiaclo
b36b12e968 Allow NPM to update packages 2016-12-08 11:33:33 -05:00
Ritesh Khadgaray
83bf44c78f allows user to not update zabbix host config if host is present. 2016-12-08 11:33:33 -05:00
Kerim Satirli
9802112dd4 fixes a typo in Datadog Monitor docs 2016-12-08 11:33:33 -05:00
Jimmy Tang
40e6b3870e Fix documentation, the correct parameter is "name" 2016-12-08 11:33:33 -05:00
root
4e72c23bae Fixed call to module.log 2016-12-08 11:33:33 -05:00
Greg DeKoenigsberg
f475a123c0 Add new SMEs for Zabbix 2016-12-08 11:33:33 -05:00
wimnat
482f0a8d1c Prevent ec2_remote_facts from failing when listing a terminated instance 2016-12-08 11:33:33 -05:00
Romain Brucker
3ef5be470f Fixing limit type from list to string 2016-12-08 11:33:33 -05:00
Romain Brucker
fbad76e86a Adding limit feature to iptables module 2016-12-08 11:33:33 -05:00
Brian Coca
61ba4b98e1 made ctstate default to [] and evaluation conditional on the list being popoulated 2016-12-08 11:33:33 -05:00
Brian Coca
fb3aec47ca fixed default from None to [] for ctstate 2016-12-08 11:33:33 -05:00
Brian Coca
eae8942583 avoid index error on empty list, key being true means its not None nor [] fixes #13009 2016-12-08 11:33:33 -05:00
pmakowski
9ab42a98ca no-suggests is obsolete, switch to no-recommends 2016-12-08 11:33:33 -05:00
Henrik Wallström
2b860bbae8 Adds examples for win_iis_virtualdirectory 2016-12-08 11:33:32 -05:00
whiter
d8dc9485f4 Refactor ec2_remote_facts to use filters 2016-12-08 11:33:32 -05:00
Henrik Wallström
6d166d75bc Fix: support for virtual directories in applications 2016-12-08 11:33:32 -05:00
Adam Keech
b8fbbdbff0 Fixing Some Issues with out Parameters are passed around. Also some refactoring. 2016-12-08 11:33:32 -05:00
Hans-Joachim Kliemeck
3ad86e383e added start mode feature 2016-12-08 11:33:32 -05:00
Hans-Joachim Kliemeck
b2f666a2dd strict variables fix 2016-12-08 11:33:32 -05:00
Hans-Joachim Kliemeck
349c4a2a48 added dependency and user settings 2016-12-08 11:33:32 -05:00
nitzmahone
51b1cd061a Strict-Mode fixes
Changes to missing member handling to support running top-level script under Strict-Mode v2 (as Ansible 2.0.0 does now)
2016-12-08 11:33:32 -05:00
Kirill Kozlov
426613b00d Fix broken examples in docs 2016-12-08 11:33:32 -05:00
Brian Coca
42a27ce558 added missing : to docs 2016-12-08 11:33:32 -05:00
Brian Coca
eb4fe5a0d8 made ctstate accept lists 2016-12-08 11:33:32 -05:00
Daniel Vigueras
d332a9a8e4 Add conntrack module ctstate support to iptables 2016-12-08 11:33:32 -05:00
Toshio Kuratomi
a47427cddf Return errno and http status as requested by @bcoca 2016-12-08 11:33:32 -05:00
Toshio Kuratomi
24ce8887bf Better status conditional from dagwieers 2016-12-08 11:33:32 -05:00
Toshio Kuratomi
117f640bb9 Port vsphere_copy from httplib to open_url for TLS cert validation 2016-12-08 11:33:32 -05:00
Javier Palacios
185761bfcb BUGFIX: misnamed function name breaks check mode 2016-12-08 11:33:32 -05:00
Ramunas Dronga
86bea2d6ab fixed composer usage example 2016-12-08 11:33:31 -05:00
Ramunas Dronga
ae18a1d877 added constraint for space in composer command 2016-12-08 11:33:31 -05:00
Ramunas
662fa86f07 removed check for empty composer response 2016-12-08 11:33:31 -05:00
Ramunas Dronga
6e4b42ebbc added version info for params 'arguments' 2016-12-08 11:33:31 -05:00
Ramunas Dronga
ae59ea7deb allow specify arguments for composer 2016-12-08 11:33:31 -05:00
Toshio Kuratomi
8c8c63110e Move existing check for root before we make expensive network calls 2016-12-08 11:33:31 -05:00
Brian Coca
8e255afbec switched to 'support check mode' as it does not make changes and gathers information that might be needed for other tasks to check 2016-12-08 11:33:31 -05:00
Rene Moser
83021279a1 new module ipify_facts 2016-12-08 11:33:31 -05:00
Brian Coca
b7372b509a corrected extension in module spec fixes #1190 2016-12-08 11:33:31 -05:00
Brian Geihsler
92cbe5be0e Fix #1107: Prepend registry type on key path 2016-12-08 11:33:31 -05:00
Brian Geihsler
6fed60c1bd Fix #1107: Use Get-Attr in win_regedit 2016-12-08 11:33:31 -05:00
Monty Taylor
9b9464ab89 Revert "Change show_diff to default to yes"
This was originally to match what puppet agent --test is, since the
rest of the options defaulted to on are grabbed from --test. However,
some security concerns have since been raised - namely that since this
is not the same invocation as --test but instead a remote orchestration
of puppet, the fact that passwords leak into the diff is a dangerous
default.

This reverts commit b86762c1806aa7f021a4780d06db2d3937910a62.
2016-12-08 11:33:31 -05:00
Trond Hindenes
d90f91e802 Various improvements to win_package 2016-12-08 11:33:31 -05:00
Toshio Kuratomi
9c75b5eac3 Make the pkg/name param into a list so that changes to make changes to _squash_items easier 2016-12-08 11:33:31 -05:00
Rene Moser
682b7ce3bd cloudstack: cs_portforward: fix example does not match description 2016-12-08 11:33:31 -05:00
Brian Coca
29fad0223d whitespace fixes 2016-12-08 11:33:30 -05:00
Romain Brucker
e4ce38fa0b Adding comment support for iptables module 2016-12-08 11:33:30 -05:00
Brian Coca
50905e5673 fixed typos in cryptab, thanks @timw fixes #1176 2016-12-08 11:33:30 -05:00
Siva Popuri
c3ecf5a0bf added author to module doc string. 2016-12-08 11:33:30 -05:00
Siva Popuri
34ba9fa4f8 Added RETURN doc string for all modules and few minor enhancements. 2016-12-08 11:33:30 -05:00
Matteo Acerbi
e6fe4b10f5 Fix docs for ec2_vpc_route_table
The documentation pointed to vpc_peering_connection, not vpc_peering_connection_id.
2016-12-08 11:33:30 -05:00
Greg DeKoenigsberg
5c494fb37b Remove @lorin from list of reviewers 2016-12-08 11:33:30 -05:00
Corwin Brown
8e557dfc45 Made win_iis_webapppool Strict Compliant 2016-12-08 11:33:30 -05:00
Alexander
8e509c2736 fix typo error
fix spell error for whether
2016-12-08 11:33:30 -05:00
Matt Carroll
164e1f3baa Fix ZFS create
This was failing due to the createparent variable being referenced but
never actually loaded from properties
2016-12-08 11:33:30 -05:00
Brian Coca
d9a29f394f fixed missed passing use-sudo 2016-12-08 11:33:30 -05:00
Ondra Machacek
d43d4718f3 system: pam_limits: add support for unlimited/infinity/-1
Early pam_limits module didn't support special values for items.
This patch is adding support to special values unlimited, infinity and -1.

Issue: https://github.com/ansible/ansible-modules-extras/issues/1033
Signed-off-by: Ondra Machacek <machacek.ondra@gmail.com>
2016-12-08 11:33:30 -05:00
Jonathan Mainguy
451a05c1a2 Change show_diff to default to yes, to match what puppet agent --test is, since the rest of the options defaulted to on are grabbed from --test 2016-12-08 11:33:30 -05:00
james
c2a4e230aa More consistent use of run_command() wrapper function, which now adds the default binary location to the search path 2016-12-08 11:33:30 -05:00
James Cammarata
d26e062331 Version bump for new beta 2.0.0-0.4.beta2 2016-12-08 11:33:30 -05:00
Ramon de la Fuente
79352b5e38 module guideline changes 2016-12-08 11:33:29 -05:00
Ramon de la Fuente
c0b69067d7 added the folder structure and general explanation to examples, removed module name typo 2016-12-08 11:33:29 -05:00
Ramon de la Fuente
88ac3eca78 removed link to guide, and added more documentation and examples 2016-12-08 11:33:29 -05:00
Ramon de la Fuente
7841bf9c91 adding the deploy_helper module 2016-12-08 11:33:29 -05:00
M0ses
a1dbb83075 fix errorhandling in zypper.py module
package_latest was calling package_present but did not care
about the return code so errors in package_present were hidden
and everthing look ok on the console when zypper update did not fail,
but no packages where installed.
2016-12-08 11:33:29 -05:00
Brian Coca
d15b3776f0 added version_added to new feature, removed unused aliases 2016-12-08 11:33:29 -05:00
daniel-sc
04efe69c34 configurable timeout for creating gce image 2016-12-08 11:33:29 -05:00
Chrrrles Paul
6777f634d5 tpyo in doc string 2016-12-08 11:33:29 -05:00
whiter
5e529a6afc Use filters attribute rather than eni id so facts can be filtered on much more. Matches the new ec2_vpc_route_table_facts and ec2_vpc_subnet_facts modules 2016-12-08 11:33:29 -05:00
ogenstad
7c6175af3d lookupMib=False for pysnmp 4.3.0 2016-12-08 11:33:29 -05:00
Toshio Kuratomi
2dcbacd48e Fix doc build by moving misplaced CIDR documentation 2016-12-08 11:33:29 -05:00
Brian Coca
577566139f fixed undefined msg and now actually return something meaningful fixes #1127 2016-12-08 11:33:29 -05:00
Rene Moser
ea6fdeb585 cloudstack: add new loadbalancer rule modules 2016-12-08 11:33:29 -05:00
Shawn Siefkas
29d6313366 Handling dry run exception 2016-12-08 11:33:29 -05:00
Shawn Siefkas
253d177dc3 Check mode support for VPC route table creation 2016-12-08 11:33:29 -05:00
Christopher M. Fuhrman
5574516934 pkgin: Support multiple matching packages
pkgin searches for packages such as 'emacs' can return multiple matches,
the first of which is not guaranteed to match.  So, iterate through
found packages until we have an appropriate match.  Should we *not* find
a match, then return False indicating match failure.
2016-12-08 11:33:29 -05:00
Brian Geihsler
2f6f6cedf8 Fix #1099: Only populate site result when it is there 2016-12-08 11:33:28 -05:00
Siva Popuri
002fc53863 minor change to remove extra brackets 2016-12-08 11:33:28 -05:00
Siva Popuri
85c09c9944 fixed typos 2016-12-08 11:33:28 -05:00
Siva Popuri
d13e34e131 corrected a typo 2016-12-08 11:33:28 -05:00
Siva Popuri
56cdaba0ab ansible module for managing anti affinity policy in centurylink cloud has been added 2016-12-08 11:33:28 -05:00
Siva Popuri
843ad8e7e8 minor refactor to remove un-used parameter 2016-12-08 11:33:28 -05:00
Siva Popuri
fd09597267 removed empty aliases from doc string 2016-12-08 11:33:28 -05:00
Siva Popuri
a2c2efb2ae Corrected a typo 2016-12-08 11:33:28 -05:00
Siva Popuri
4a8e3e9632 ansible module for managing alert policy in centurylink cloud has been added 2016-12-08 11:33:28 -05:00
Siva Popuri
01847f7bfc Ansible module for managing server snapshots in Centurylink Cloud 2016-12-08 11:33:28 -05:00
Toshio Kuratomi
60c495f18c Fix win_acl docs build 2016-12-08 11:33:28 -05:00
Toshio Kuratomi
0111b616d7 Fix docs to build 2016-12-08 11:33:28 -05:00
Linus Unnebäck
ebfb8bc7cf iptables: add note about rules 2016-12-08 11:33:28 -05:00
Linus Unnebäck
8d93747275 iptables: expand rule options 2016-12-08 11:33:28 -05:00
Linus Unnebäck
1790722dd4 module: system/iptables 2016-12-08 11:33:28 -05:00
Phil
0524904dda fixes examples in docs to use updated param name 2016-12-08 11:33:28 -05:00
Phil
43074a736d changes param src to path, and updates docs accordingly 2016-12-08 11:33:27 -05:00
Phil
00a4ec5e3b updates user search verification for local/domain - Thanks to @trondhindenes for implementing this strategy - also updated documentation 2016-12-08 11:33:27 -05:00
Phil
9ad30acd96 changes check for src 2016-12-08 11:33:27 -05:00
Phil
6abfcffc70 check if the rule exists or not before allow/deny rules are added/removed, and fixes where result changed would be true on all executions. 2016-12-08 11:33:27 -05:00
schwartzmx
25a3793a49 inital commit win_acl 2016-12-08 11:33:27 -05:00
Brian Coca
a65647efee added version_added and fixed some doc parsing issues 2016-12-08 11:33:27 -05:00
Jeremy Wells
c8e0f3a552 Add consul http checks to consul.py
Consul module already supports ttl and script checks. This commit adds
http checks.
2016-12-08 11:33:27 -05:00
Steve
fea8995df1 Fix bug #1105 - incorrect use of lstrip()
Remove only the literal prefix '/dev/mapper/' - not any of the characters
in '/dev/mapper/' - from the name param of the crypttab module.
2016-12-08 11:33:27 -05:00
Brian Coca
d530764c49 fixed option in examples 2016-12-08 11:33:27 -05:00
Charles Paul
3913de1c43 reference instance_id in docs, fixes for calls to fail_json 2016-12-08 11:33:27 -05:00
Trond Hindenes
15ac8e9141 turned out strict msi code checking 2016-12-08 11:33:27 -05:00
Nicolas Landais
4fc4030c58 Adding fix to get around bug found with the New-Webstire command when running playbook on a vanilla machine. 2016-12-08 11:33:27 -05:00
Dreamcat4
40a1bd1962 fix: Add 'enable:' flag for enabling existing rules which are disabled by default.
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.

Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.

But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
2016-12-08 11:33:27 -05:00
Dreamcat4
e0da4a3362 fix: update documentation with new module name "win_firewall_rule" 2016-12-08 11:33:27 -05:00
Dreamcat4
7188ae4fe1 fix: The names of firewall profiles are different on win10 & win2008r2
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
2016-12-08 11:33:27 -05:00
Dreamcat4
f64e438150 fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
2016-12-08 11:33:26 -05:00
Dreamcat4
b9dd3568f3 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
2016-12-08 11:33:26 -05:00
Ramon de la Fuente
1d09eaf6d0 updated the examples to the new Slack API 2016-12-08 11:33:26 -05:00
Ramon de la Fuente
918012a42f module guidelines compliency 2016-12-08 11:33:26 -05:00
Stefan Berggren
aeb1090542 Add attachments support to slack module. 2016-12-08 11:33:26 -05:00
Kevin
b43329b6a0 Remove homebrew- prefix when checking if repo has already been tapped
See: https://github.com/Homebrew/homebrew/blob/master/Library/Homebrew/cmd/tap.rb

Example:

```
$ brew tap neovim/homebrew-neovim
$ brew tap
neovim/neovim
...
```
2016-12-08 11:33:26 -05:00
Luis Rodriguez
adedc7ef3f Fix bug #1067 2016-12-08 11:33:26 -05:00
Brian Coca
1426c3ba02 added missing GPL licences fixes #508 2016-12-08 11:33:26 -05:00
Michael Perzel
f84dc8fd5d Improve example wide_ip variable 2016-12-08 11:33:26 -05:00
Michael Perzel
9c8891740c Wrap main() in conditional 2016-12-08 11:33:26 -05:00
Michael Perzel
21425f36ef Update bigip_api method to use variable name server 2016-12-08 11:33:26 -05:00
Michael Perzel
6681a5b386 Style updates 2016-12-08 11:33:26 -05:00
Michael Perzel
ca0d4aad52 Module for managing F5 wide ip 2016-12-08 11:33:26 -05:00
Toby Fleming
3293fe7231 Homebrew: Allow colons, direct check for outdated formula 2016-12-08 11:33:26 -05:00
Indrajit Raychaudhuri
e115f62a2d homebrew: Also add 'formula' as alias for 'name' and reformat 2016-12-08 11:33:25 -05:00
Indrajit Raychaudhuri
c397dfe9ed homebrew: Improve 'argument_spec' handling
- Remove choice list for boolean values in argument_spec and make it
  more consistent with core modules
- Add 'package' alias and support for list type for 'name' parameter
- Added self as maintainer
2016-12-08 11:33:25 -05:00
jhawkesworth@users.noreply.github.com
17d1c8916d Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908 2016-12-08 11:33:25 -05:00
Matt Martz
803d9695e0 sys.exit removal for system/capabilities.py 2016-12-08 11:33:25 -05:00
Matt Martz
a87cf4967e sys.exit removal for notification/mail.py 2016-12-08 11:33:25 -05:00
Matt Martz
e99a202ac5 sys.exit removal for cloud/google/gce_img.py and cloud/google/gce_tag.py 2016-12-08 11:33:25 -05:00
Matt Martz
7cb0d86c27 sys.exit removal for cloud/misc/ovirt.py 2016-12-08 11:33:25 -05:00
Matt Martz
950c951e06 sys.exit removal for cloud/xenserver_facts.py 2016-12-08 11:33:25 -05:00
James Cammarata
766ad0ace2 Updating version for 2.0.0-0.3.beta1 release 2016-12-08 11:33:25 -05:00
Matt Martz
9c4fae7e3f Fix open_iscsi EXAMPLES section 2016-12-08 11:33:25 -05:00
Matt Martz
e2872a984a Switch from old style replacer code to new style for ansible.module_utils.basic 2016-12-08 11:33:25 -05:00
Matt Martz
793f0e0fd1 Fix interpreter line in a few vmware modules 2016-12-08 11:33:25 -05:00
Rick Mendes
7bb6a5aa90 added missing license 2016-12-08 11:33:25 -05:00
Charles Paul
0acfd95747 allow floating point input for size vale 2016-12-08 11:33:25 -05:00
Brian Coca
4134b7a04d doc formatting fixes 2016-12-08 11:33:25 -05:00
Toshio Kuratomi
7ccd6a4de0 Change documented requirement from dnf to python-dnf as dnf could be taken to mean the command line tool.
Fixes #1032
2016-12-08 11:33:25 -05:00
nitzmahone
bf59d1cc1e win_updates rewrite for 2.0
uses scheduled job to run under a local token (required for WU client)
supports check mode
no external PS module deps
2016-12-08 11:33:24 -05:00
Brian Coca
ae84177514 switched to use module loggigng 2016-12-08 11:33:24 -05:00
Brian Coca
a04972c79b changed use_sudo to system_lib (kept alias) and expanded description to explain how it works 2016-12-08 11:33:24 -05:00
Milad Soufastai
c3c9f46ba4 Updating Description to provide better explanation of what the use_sudo flag does 2016-12-08 11:33:24 -05:00
Milad Soufastai
07a4ab2fc5 Adding the --sudo flag for CPANM use since the sudo: yes on the task doesn't work 2016-12-08 11:33:24 -05:00
Trond Hindenes
86be6b1dba added module author 2016-12-08 11:33:24 -05:00
Trond Hindenes
6890cc81be fixes #984 2016-12-08 11:33:24 -05:00
Matt Martz
503948203f znode requires a minimum of python2.6 2016-12-08 11:33:24 -05:00
Michael J. Schultz
6b6aeefa7b sns: remove BabyJSON 2016-12-08 11:33:24 -05:00
Toshio Kuratomi
dc788cf045 Make the znode module a valid ansible module 2016-12-08 11:33:24 -05:00
Toshio Kuratomi
07af4c3627 Fix doc build 2016-12-08 11:33:24 -05:00
Rene Moser
a134a71187 cloudstack: implement common argument spec handling 2016-12-08 11:33:24 -05:00
Alan Loi
6e4c78d165 Docfixes - add version_added and missing default values. 2016-12-08 11:33:24 -05:00
Alan Loi
a14420dcf0 Fix sqs_queue module to check that boto library is installed and AWS region & credentials are provided. 2016-12-08 11:33:24 -05:00
Alan Loi
e8e1e41e08 Updated documentation for sqs_queue - state option is not required. 2016-12-08 11:33:24 -05:00
Alan Loi
6022f5abc7 Rename module to sqs_queue.py to differentiate from other potential modules e.g. reading/writing messages. 2016-12-08 11:33:23 -05:00