Michael Scherer
43d0fbd342
Add a better error message for service
...
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.
So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
2014-04-22 09:13:57 +02:00
James Cammarata
c115c34a1f
Set the default LANG to en_US.UTF-8 and also set LC_CTYPE
...
Fixes #6737
2014-04-22 00:48:32 -05:00
Michael DeHaan
491a00af21
Merge pull request #7108 from bcoca/freebsd_mtu_fix
...
should now work with versions older than 8.4
2014-04-21 22:27:26 -04:00
James Martin
8a21f226b5
ec2_eip integration tests.
2014-04-21 22:10:22 -04:00
Mike Buzzetti
b2c5106833
Adding support for purging subnets
2014-04-21 21:42:05 -04:00
Brian Coca
c3e559b914
should now work with versions older than 8.4
2014-04-21 21:00:58 -04:00
Richard Hoop
06c64785fb
Large cleanups. Reintegrating all modules together for a guest
2014-04-21 16:38:31 -04:00
James Cammarata
f1ce9abe0d
Merge pull request #7099 from faust64/patch-2
...
Update facts.py
2014-04-21 12:48:41 -05:00
faust64
78b9a11ccf
Update facts.py
...
Fixes #7093 --devel
2014-04-21 19:44:47 +02:00
James Cammarata
149339f620
Merge pull request #7089 from dagwieers/debug-docs
...
Add an example to show all hostvars using debug
2014-04-21 12:11:39 -05:00
James Cammarata
53754357f7
Merge pull request #7096 from CaptTofu/docker
...
Small bug - 'acts' should be 'facts'
2014-04-21 11:49:26 -05:00
James Cammarata
afee14173e
Merge pull request #7095 from radeksimko/pokemon-exc-fix
...
Prevent catching unrelated exceptions
2014-04-21 11:49:04 -05:00
James Cammarata
568b4a801c
Merge pull request #7094 from radeksimko/apt-autoinstall-fix
...
Add check of return code for autoinstallation of python-apt
2014-04-21 11:48:27 -05:00
James Cammarata
68c30548e0
Properly catch and decode unicode strings in module _log_invocation()
...
Fixes #7084
2014-04-21 11:33:23 -05:00
James Cammarata
4f673b9497
Merge pull request #7083 from mscherer/better_message_multiple_action
...
Improve error message when multiple action are given
2014-04-21 10:53:55 -05:00
James Cammarata
39c6141b4a
Merge pull request #7082 from bcoca/freebsd_mtu_fix
...
fixed issue with FreeBSD network facts
2014-04-21 10:53:22 -05:00
James Cammarata
086b877719
Merge pull request #7079 from mscherer/fix_error_whitespace_in_config
...
Clean a bit more the ssh_args configuration
2014-04-21 10:43:31 -05:00
James Cammarata
54f86099e4
Merge pull request #7078 from mscherer/fix_error_message_controlpersist
...
Enhance error message about missing ControlPersist
2014-04-21 10:41:58 -05:00
CaptTofu
2990db728a
Small bug - 'acts' should be 'facts'
2014-04-21 08:06:00 -07:00
Radek Simko
1513d2bd64
Prevention for catching unrelated exceptions added
2014-04-21 15:35:49 +01:00
Michael DeHaan
f09c0c7c64
Merge pull request #7081 from bcoca/freebsd_fact_fix
...
fixed ETIME issue on FreeBSD 8 through 10, which broke fact gather
2014-04-21 09:15:10 -04:00
Radek Simko
8bdd96b273
Explicit check of return code for autoinstallation of python-apt added
...
This will allow easier debugging through more meaningful error message.
2014-04-21 14:10:09 +01:00
Dag Wieers
3c15d64655
Add an example to show all hostvars using debug
...
This is a useful example to help debug how facts and vars are being collated.
2014-04-21 11:40:53 +02:00
Michael Scherer
1e34e95ba0
Improve error message when multiple action are given
...
This can be illustrated using this playbook:
- command: id
delegate_to: "{{ remote_server }}"
user: "{{ remote_user }}"
The error is to use 'user' instead of 'remote_user', but the error message
do not really mention it, so it can be a bit hard to spot.
2014-04-20 20:32:33 +02:00
Brian Coca
e5f297697a
ifconfig changed on FreeBSD, tested this on 8,9 and 10 latest stable
...
versions and it now works
2014-04-19 22:03:30 -04:00
Brian Coca
bc23926f42
fixed ETIME issue on FreeBSD 8 through 10, which broke all fact
...
gathering
2014-04-19 21:42:56 -04:00
Michael Scherer
c87afc1109
Clean a bit more the ssh_args configuration
...
If someone add ssh_args = " " to his .ansible.cfg, it will result into
strange failure later :
<server.example.org> ESTABLISH CONNECTION FOR USER: misc
<server.example.org> REMOTE_MODULE ping
<server.example.org> EXEC ['ssh', '-C', '-tt', '-q', ' ', '-o', 'KbdInteractiveAuthentication=no',
'-o', 'PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey', '-o', 'PasswordAuthentication=no',
'-o', 'ConnectTimeout=10', 'server.example.org', "/bin/sh -c 'mkdir -p /tmp/ansible-tmp-1397947711.21-5932460998838
&& chmod a+rx /tmp/ansible-tmp-1397947711.21-5932460998838 && echo /tmp/ansible-tmp-1397947711.21-5932460998838'"]
server.example.org | FAILED => SSH encountered an unknown error during the connection. We recommend you re-run the
command using -vvvv, which will enable SSH debugging output to help diagnose the issue
The root cause is the empty string between -q and -o, who kinda break mkdir.
2014-04-20 00:47:00 +02:00
Michael Scherer
3a09c99811
Enhance error message about missing ControlPersist
...
ansible_ssh_args is good for playbook, but in the ~/.ansible.cfg
file, it should be ssh_args in a specific section.
2014-04-20 00:35:10 +02:00
James Cammarata
ae29e43f93
Merge branch 'issue_7009_nfs_selinux' into devel
2014-04-18 22:21:03 -05:00
Michael DeHaan
bec0e596e8
Fix date in changelog for RPM builds off devel branch.
2014-04-18 19:41:44 -04:00
James Cammarata
a32dd34359
Make sure HostVars object is instantiated before assigning it
...
Fixes #7006
2014-04-18 16:23:01 -05:00
James Cammarata
cc6d213d72
Updating changelog/releases/packaging for 1.5.5 release
2014-04-18 16:07:28 -05:00
Jim Kleckner
46ec238613
Fix #7057 missing False default for vars_prompt
...
The test for default should be "is not None" since a boolean value of
False is a valid value.
See discussion at:
https://groups.google.com/forum/#!topic/ansible-project/oc1_zE-FnyI
2014-04-18 12:04:11 -07:00
James Cammarata
75e0b7a5cf
Make sure umask is set restrictively before creating any vault files
2014-04-18 13:38:59 -05:00
Bruce Pennypacker
b57887bafd
Fix for https://github.com/ansible/ansible/issues/7054 - when renaming an instance and waiting for the change to occur, force result.id to the name of the new instance so the subsequent call to get_current_resource succeeds.
2014-04-18 17:56:11 +00:00
James Cammarata
3715482d7c
Determine selinux context for NFS mount points correctly
...
Fixes #7009
2014-04-18 09:39:58 -05:00
Michael Heca
4271613aa5
module docker_image - default tag latest
...
Fix constant rebuild of image if no tag specified.
2014-04-18 16:14:12 +02:00
Mike Buzzetti
5dada9403e
Adds support for VPC subnets to ELB
2014-04-18 09:59:35 -04:00
Sébastien Gross
22d6572270
Honor ansible_private_key_file for delegated hosts
...
If a delegated host is not found in the inventory specified
private_key_file for primary host was not used.
This allows running playbooks without having to define any inventory at
all and to use the same ssh private key for both primary host and
delegated one.
2014-04-18 01:48:02 +02:00
Joshua Conner
4defd9a15a
docker: exclude 'entrypoint' from comparing 'command' param with containers
...
The JSON the Docker API returns includes the container's ENTRYPOINT value (if it has one) with the 'Command' value. So instead of checking if `container['Command'] == module.params['command']`, we just check that `container['Command'].endswith(module.params['command'])` so the entrypoint won't affect a container being properly classified as matching the module params or not.
Also I refactored a super-long `if` statement into some temporary variables - I did it to help me figure out what was going wrong, and then it makes the code more readable so I kept it.
2014-04-17 16:10:53 -07:00
Joshua Conner
10171dc42b
docker: send 1.10 params if docker-py is new enough version
2014-04-17 16:05:50 -07:00
Michael DeHaan
632eb18333
Merge pull request #7044 from 42wim/devel
...
hint to install python-ssl on redhat systems
2014-04-17 18:34:39 -04:00
Wim
6ed4ca97a8
hint to install python-ssl on redhat systems
2014-04-18 00:07:07 +02:00
James Cammarata
1ef0402f03
Make sure a default allow out rule exists if no other egress rules do
...
Fixes #7027
2014-04-17 15:24:18 -05:00
Chad Nelson
ef1a8e4cdd
Only update submodules when recursive is true
2014-04-17 09:34:36 -04:00
Michael DeHaan
09e0d1c51f
Merge pull request #7029 from mattjbray/docker-api-error
...
docker.client.APIError has moved to docker.errors.APIError
2014-04-16 22:38:40 -04:00
Andreas Fleig
337a0059d9
apt_key: fix key lookup for 64 bit key ids
...
Fixes #7018 by extending `all_keys` to work with either short or long keys.
Also removes the ununsed method `key_present`.
2014-04-17 03:51:19 +02:00
Matt Bray
3948dc2d1d
docker.client.APIError has moved to docker.errors.APIError
...
see 18d4db09ec
2014-04-16 23:42:56 +01:00
James Cammarata
a37a84243b
Check resource_tags value before using it in ec2_vpc
...
Fixes #7024
2014-04-16 12:21:32 -05:00
Brian Brazil
8ec400669f
Fix race conditions where a process gets in state "Running"
...
between the restart/start command and the summary command.
Refactor to avoid repeating the status, and fail if a given call to monit fails.
2014-04-16 18:04:19 +01:00