John R Barker
6845234d72
nmcli: fix docs for add necessary package ( #24071 )
...
Originally report in https://github.com/ansible/ansible/pull/23817
2017-04-27 17:38:11 +01:00
Erwin Lang
b729b35e32
synchronize: Fix (delegated) local rsync
...
Makes delegated local rsync work even if ansible_host or ansible_ssh_host is set.
Makes local rsync work when no ssh is installed.
2017-04-27 09:33:26 -07:00
John R Barker
fcb52ce808
Added note on netcat dependency ( #24070 )
...
Originally https://github.com/ansible/ansible/pull/23911/files
2017-04-27 17:25:00 +01:00
Trishna Guha
2741907cba
Refactor nxos_interface and add unit test ( #24008 )
...
* [WIP] Refactor nxos_interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Modification in refactor
Unittest for nxos_interface
2017-04-27 21:19:10 +05:30
Nathaniel Case
689b93bf14
Junos_config unicode ( #23369 )
...
* Try to handle unicode output more sensibly
* Appears I'm getting latin1 instead
Ugh.
2017-04-27 11:44:26 -04:00
John R Barker
1c61b9bae7
Split modules/network into two parts ( #24024 )
...
* Split modules/network into two parts
Given the dedicated team we we have working on Ansible Networking a
clearer split is needed between Networking modules and "things that
happen to use the network"
* nmcli to net_tools
* nmcli moved
2017-04-27 16:42:41 +01:00
Colin Chan
2d9d1762ba
Improve parsing of 'systemctl show' output
2017-04-27 11:42:26 -04:00
Nathaniel Case
fc0bf87c20
Run save
inside config mode. ( #23977 )
...
* Run `save` before exiting config mode.
* Fix unit tests for `save`
* Allow `save` to be on its own again and introspect success
* Introspecting `compare running` makes this a lot harder.
Move `save` tests to integration tests
2017-04-27 11:08:37 -04:00
Ganesh Nalawade
1f7c2c63c2
Fix python version check issue ( #24063 )
...
Fix python version check issue
2017-04-27 20:10:58 +05:30
Ricardo Carrillo Cruz
2716fad38f
Return commands instead of command ( #24061 )
...
Ok, so for openvswitch_db in particular we just return one command
but in the sake of consistency and code re-use, let's return a list
of "commands", even if it's just one.
2017-04-27 16:36:08 +02:00
Abhijeet Kasurde
9456f93ea8
Pep8 fixes for known_hosts.py ( #24029 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-27 09:21:49 -05:00
Andrea Tartaglia
1d0a629dcc
Fixed docs for cloud modules ( #23745 )
...
* Fixed docs for cloud modules
* removed blank line in ec2_snapshot_facts
2017-04-27 12:01:11 +01:00
Senthil Kumar Ganesan
ce99ffe205
Fixed PEP8 issues ( #24030 )
2017-04-27 11:41:43 +01:00
Ganesh Nalawade
7d710882a8
Fix exception issue in junos_config ( #24049 )
...
ParseError execption is added to ElementTree
in py2.7. Prior to py2.7 need catch ExpatError
execption
2017-04-27 13:16:40 +05:30
Andrej Svenke
3185ec94c5
ecs_service: add tasks placement constraints and strategy. ( #20503 )
...
ecs_service: documentation fix.
ecs_service: updated version_added.
ecs_service: pep8 fixes.
2017-04-27 08:33:23 +01:00
Toshio Kuratomi
51e3390333
Document deprecation of fetch module validate_md5 and update --tags merging deprecation ( #24022 )
...
* Document deprecation of fetch module validate_md5 and update --tags merging deprecation
Update the default of --tags merging config option to merge by default
* Update CHANGELOG.md
Minor edit
2017-04-26 19:57:21 -07:00
jctanner
a5d6d3b9af
Remove unused+circular import in listify.py ( #24038 )
2017-04-26 16:56:00 -04:00
Nathaniel Case
0d67a49d5a
nxos_bgp fixes ( #23927 )
...
* Pre-emptively fix sanity/pep8
* fix for commands
* Quick unit test
2017-04-26 16:33:54 -04:00
Nathaniel Case
c0ebdf144d
nxos_acl_interface fixes ( #23917 )
...
* Update nxos_acl_interface
* Add basic unit tests to nxos_acl_interface
2017-04-26 16:32:36 -04:00
Nathaniel Case
f0914ee3c2
nxos_acl fixes ( #23915 )
...
* Update nxos_acl
* unit tests for nxos_acl
* Remove nxos_acl from pep8-legacy
2017-04-26 16:29:53 -04:00
Toshio Kuratomi
bffccb5396
fetch idempotence test and deprecate validate_md5
...
Added an integration test for fetch module idempotence. (Testing
that validate_checksum is doing what it's supposed to is harder as we'd
have to create a race condition with the downloaded data to trigger it.
Probably need to make that a unittest eventually).
Also give a deprecation message to the validate_md5 parameter so that we
can eventually get rid of it.
2017-04-26 12:00:01 -07:00
KeepZero
98e7d4b49d
Set validate_checksum default yes of fetch to match the doc
2017-04-26 09:27:06 -07:00
Abhijeet Kasurde
86a63cfcd7
Handle fetch_url error gracefully ( #23821 )
...
Fix adds http response code check for fetch_url.
Also, method in fetch_url call.
Fixes https://github.com/ansible/ansible/issues/23800
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-26 10:35:40 -05:00
Giuseppe Scrivano
d02a9016a2
Atomic containers ( #21366 )
...
* atomic_image: add support for pull --storage=
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* atomic_container: new module
Manage atomic containers
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2017-04-26 08:21:08 -07:00
Andrea Tartaglia
d1517f997a
fixed RETURN docs for modules ( #24011 )
...
* fixed RETURN docs for remaining modules
* updated proxymysql_mysql_users 'sample' to yaml dict
* fixed whitespace errors
2017-04-26 15:56:13 +01:00
Patrick Ogenstad
9a0a7f78d7
asa_command: set default_output to text ( #23979 )
2017-04-26 09:46:39 -04:00
ka7
b11219440b
spelling fixes (non-trivial, might catch a bug) ( #23646 )
2017-04-26 13:14:34 +01:00
Abhijeet Kasurde
d16fe5bef3
Minor typo and PEP8 fixes for dnf module ( #23845 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-26 12:57:49 +01:00
Abhijeet Kasurde
9fbbb5e10f
Pep8 fixes for mysql module ( #23923 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-26 12:56:35 +01:00
cptchips
dde383aea2
[Doc] win_package - product_id is a mandatory parameter ( #24007 )
...
product_id is a mandatory parameter for windows/win_package module.
2017-04-26 12:36:12 +01:00
Sumedh Sidhaye
be6ca006a2
Corrected -su cmdline option to --su to be consistent with the man page entry ( #23899 )
...
Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
2017-04-25 21:26:20 -07:00
Brian-Williams
8466c808d9
Change wait_for time to utc ( #23987 )
2017-04-25 17:04:29 -05:00
Brian Coca
e29dc49a49
moved to exceptions for basic skip/fails
...
better handling of checkmode and async
fix test to follow new flow control
2017-04-25 14:48:56 -04:00
Ricardo Carrillo Cruz
a3a970180a
Unit tests for openvswitch_db module ( #23974 )
2017-04-25 20:02:55 +02:00
Ganesh Nalawade
09b8badc5e
Minor junos_config module changes ( #23972 )
...
* Minor junos_config module changes
* Add note for json config support
* Add example for lines argument
* Fix future warning for ElementTree
* Remove unwanted space
2017-04-25 23:09:55 +05:30
Ganesh Nalawade
15c19367d6
Fixes #23960 junos_config fail with config in xml ( #23962 )
...
If config is in xml format append it to <configuration>
tag as a instance of Element class.
2017-04-25 22:40:16 +05:30
Chris Madden
8e7c546ef9
Fix name description from lun to volume ( #23964 )
...
Help text stated to manage lun name but this module is for managing volumes. Updated accordingly.
2017-04-25 11:08:43 -04:00
Brian Coca
1a0b94fa17
schedule sudo/su removal
2017-04-25 10:54:23 -04:00
René Moser
3959597f7d
exoscale: fix TXT type records handling ( #23956 )
2017-04-25 13:05:37 +02:00
Trishna Guha
f354bd1eab
Set terminal width for network *_command modules to avoid paging ( #23728 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-04-25 14:10:39 +05:30
Trishna Guha
47edac6ebd
Remove repetition of code nxos ( #23908 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-04-25 08:37:22 +05:30
Indrajit Raychaudhuri
45252b79be
pacman: Fail fast when 'rc != 0'
...
We fail-fast and display 'stderr' in case 'pacman' returns with 'rc != 0'.
There is no point computing 'module._diff' in such case anyway.
Fixes #23910
(cherry picked from commit 8c6a2a848cf6a6d6522c8f5be56decf8df1ed6ab)
2017-04-24 21:12:20 -04:00
Brian Coca
72a4e1cf0d
fixed code to actually check the parameter not key
...
also made rest conditional on unit being provided, previouslly it changed from being always required
fixes #23810 alternate to #23907
2017-04-24 20:54:14 -04:00
Kai
cb13aea88b
Fix systemd in chroot ( #23904 )
...
* Fix systemd in chroot
The 'request ignored' message is in stderr, not stdout.
* Check both stdout and stderr for systemd message
Some versions of systemd report to stderr, others to stdout. Also check
whether output could be a valid normal response to avoid false positives.
2017-04-24 19:53:12 -04:00
Sloane Hertel
d021d8f16b
efs: include name in results ( #23931 )
2017-04-24 17:49:14 -04:00
Sloane Hertel
380ac577c6
[cloud] ec2_facts: make ec2_facts python3 compatible - fixes #23595 ( #23872 )
...
* make ec2_facts python3 compatible
* remove parentheses and use pop() instead of del
2017-04-24 16:09:46 -04:00
Brian Coca
a108f0fcd3
avoid hosts 'pre templated warnings' ( #23878 )
...
* avoid hosts 'pre templated warnings'
fixed is_template failing on undefined
fixes #23057
* py3 compat
2017-04-24 15:19:52 -04:00
Adrian Likins
e0a7105c2d
Use sys.stdout.buffer to write vault bytes to stdout on py3 ( #23760 )
...
* Use sys.stdout.buffer to write vault bytes to stdout on py3
We need sys.stdout.buffer on py3 so we can write bytes to it since the plaintext
of the vaulted object could be anything/binary/etc
Before, attempting to write bytes to stdout on py3 would cause:
TypeError: write() argument must be str, not bytes
2017-04-24 10:09:03 -04:00
Ondra Machacek
80327d9d47
cloud: ovirt: import VM from external source ( #22450 )
2017-04-24 08:59:35 -04:00
Sloane Hertel
00ebd0c89d
make lineinfile docs clearer and make module pep8 ( #23857 )
2017-04-23 09:19:22 +02:00