1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

33345 commits

Author SHA1 Message Date
jctanner
65feaa11b2 Fix valueerror in vmware_inventory.py (#28597) 2017-08-24 10:04:52 -04:00
Trishna Guha
10467efaba Tested against VYOS version (#28562)
* Tested againset VYOS version

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix duplicate dict key error vyos_command

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-24 19:08:05 +05:30
Dag Wieers
11b50671ba win_robocopy: Check-mode support, improved return code and docs (#25410)
* win_robocopy: Cleanup logic, check-mode support

* win_robocopy: Cleanup logic, check-mode support

This PR includes:

- Improved check-mode support
- Clean up documentation
- Clean up code structure
- Add warnings in special cases

* minor fix for typo
2017-08-24 09:35:53 -04:00
Dag Wieers
967fbcb662 xml module: Add backup support (#28595)
This fixes #27949
2017-08-24 15:20:59 +02:00
René Moser
6fc8899290 test: yum: add test cases for state=latest (#28575)
* test: yum: add test with state=latest

* test: yum: extend test cases with check mode
2017-08-24 09:09:11 -04:00
Brian Coca
203d8d2e6e added diff keyword to changelog/docs 2017-08-24 08:55:39 -04:00
Brian Coca
725d4d4bc8 added diff as new keyword (#28581)
added diff to fake options in ec2_vpc_nat_gateway test
2017-08-24 14:43:19 +02:00
Kira Rose
46cd8ba7cd Check Windows service status before nssm STOP (#28379)
* Check Windows service status before nssm STOP

Add a condition on calling nssm STOP inside Nssm-Remove, to check whether or not a service has already been stopped. Currently nssm throws an exception:

```
failed: [...] (item=...) => {"changed": false, "failed": true, "item": "...", "msg": "an exception occurred when invoking NSSM: serviceName: STOP: The service has not been started."}
failed: [...] (item=...) => {"changed": false, "failed": true, "item": "...", "msg": "an exception occurred when invoking NSSM: serviceName: The service has not been started."}
```

Behaviour after change:

```
ok: [...] => (item=...)
ok: [...] => (item=...)
```

* Added named parameter to new Get-Service cmdlet
2017-08-24 08:40:48 -04:00
Dag Wieers
e7a525bd4a vmware_vswitch; Improve integration tests (#28484)
So the module was now not doing anything except adding a nic to a
vswitch. This PR adds idempotency checks, and removal checks.

We should probably add modification chacks as well, but I don't know
what the limitations are for vcsim.
2017-08-24 14:31:13 +02:00
Nathaniel Case
ada7f248c0 Add 'Tested on' string to NX-OS modules (#28531) 2017-08-24 08:27:39 -04:00
Dag Wieers
d830186e27 Fix the reboot_required return value (#28579)
As reported in #28565
2017-08-24 08:14:14 -04:00
Dag Wieers
d8429a69c5 xml module: Parse and evaluate xpath on input (#28591)
* xml module: Parse and evaluate xpath on input

This fixes cmprescott/ansible-xml#68

* Update error string
2017-08-24 14:09:26 +02:00
Dag Wieers
26d75144b2 xml module: Implement diff mode (#28592)
This fixes #27952
2017-08-24 14:05:13 +02:00
Reid Wahl
3026e5eb15 Fixes #28584: modules/windows/win_get_url.ps1: Change -msg option to -message (#28585) 2017-08-24 10:48:37 +02:00
Ganesh Nalawade
cd8c1c1108 Create persistent socket path using port and connection type (#28492)
* Create persistent socket path using port and connection type

*  Use remote address, port, connection type and remote user
   to create a socket path.

* Fix review comment
2017-08-23 18:28:44 -04:00
Matt
9407a17c40 Fix example
change count_tags to count_tag
2017-08-23 17:56:38 -04:00
Brian Coca
7b73ee0818 also strip strings to avoid spaces breaking match 2017-08-23 16:01:02 -04:00
Ryan S. Brown
cc802bc883 Update CHANGELOG and botmeta for aws_waf_facts 2017-08-23 15:10:57 -04:00
Will Thames
fbfa5624c3 [cloud] New module: aws_waf_facts module (#26671)
Initial implementation of waf_facts module

* Enhance waf_facts module to provide more info

Support check_mode trivially
Enhance rule and predicate information
Use AWSretry and wrap proper exception handling
Finish documentation
Remove arbitrary limits
Meet latest ansible standards.

* Rename module to use aws_ prefix.

Fix copyright.

Fix metadata version.
2017-08-23 15:09:27 -04:00
Patrick Murray
b828b5d33b Fixing Issue #27270 - EFS TypeError (#27318)
* Fixing Issue #27270 regarding a TypeError invoked by the addition of a Filter type and List type.

* Fix SecurityGroup from always being reported as changed on PY3

On Python3, filter returns a generator.  This causes us to report that
security groups are always defined on Python3 even when there are none.

Also change filter() calls into list comprehensions.
2017-08-23 11:43:09 -07:00
Matt Clay
5ea8a5e34b Add support for setup targets to ansible-test. (#28544)
* Add support for setup targets to ansible-test.
* Code cleanup.
2017-08-23 14:09:50 -04:00
Michael Tinning
282e743eb0 elb_application_lb: fix issue with boto parameter validation on Rules (#27333) 2017-08-23 13:49:52 -04:00
Trishna Guha
cfc6d9f904 Tested against IOS XR version (#28563)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-23 22:55:21 +05:30
Stephen Jennings
be2d4cc1c9 Check for an existing docker_network before trying to modify it (#24048)
This eliminates a TypeError in check mode.
2017-08-23 12:10:53 -04:00
Will Thames
b1df75fc1c [cloud] Return AMI info on ec2_ami module when changed=false (#27867)
Fixes #27861
2017-08-23 12:01:49 -04:00
Ryan S. Brown
c39c782282 [cloud] Update changelog/botmeta for aws_direct_connect_connection module 2017-08-23 11:57:15 -04:00
Sloane Hertel
24b49c2539 [cloud] New module: AWS Direct Connect connection (#26152)
* New module for AWS Direct Connect connections

Unittests for new module

Added utils that will be used by other Direct Connect modules

* pep8 fixes

* Correct aws_direct_connect_connection EXAMPLES to be valid yaml

* Make requested changes

* remove use of the variable changed

get rid of unnecessary parentheses

* Fix unit test

* Rename variable.

* Fix metadata version
2017-08-23 11:56:19 -04:00
David M. Lee
1d4ca0fd51 amazon: extract copies of boto_exception to module_utils.ec2 (#20403)
* amazon: extract boto_exception to ec2 module

This function was copy/pasted throughout several Amazon modules. This
causes a consistency problem, since some improvements to message
formatting were applied to some modules but not others. Now all modules
use the same, improved function.

* Rebase and make requested changes

* Rebase and make requested changes
2017-08-23 11:40:32 -04:00
mzizzi
587ab33415 [cloud] Add jittered backoff+retries to CloudFormation module (#27907) 2017-08-23 11:38:19 -04:00
Trishna Guha
4070a22c5b Tested against IOS version (#28559)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-23 21:03:09 +05:30
Trishna Guha
340f52ae96 tested against eos version (#28556)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-23 20:39:31 +05:30
Laurent Ribot
f92ae0831b Fix : get proper snapshotVersion when no classifier (#27102) (#27103) 2017-08-23 10:42:48 -04:00
mikedlr
f93515adb9 [MERGE] AWS module Guidelines - multiple changes to bring up to date and start on aws.core (#26871)
* aws module Guidelines - rewrite - add AWS WG - add fail_json_aws - more modern
practices and fix some spelling

* aws module Guidelines - minor further changes with agressive fill to 99 width

* aws module Guidelines - formatting fix as per gundalow request

* aws module Guidelines - mark more keywords and code with backquotes

* AWS module guidelines - fixes from ryansb review + minor other changes
2017-08-23 10:34:30 -04:00
Muhammad Panji
8ed0222eff fix sts_session_token parameter example (#28549) 2017-08-23 09:11:51 -04:00
Lukas Bednar
8c5b9d99ed ovirt_disks: added option to export disk to glance (#27959)
* ovirt_disks: added option to export disk to glance

* ovirt_disks: Moving exporting to separate branch

* ovirt_disks: removed redundant line obtaining disk obj
2017-08-23 08:46:51 -04:00
Yaniv Kaul
6b18a23385 [oVirt] Fix ovirt_disk.py example of adding a disk (#28496)
It was missing a required field - the storage_domain field.
2017-08-23 08:46:19 -04:00
Tareq Alayan
abc5910d86 cloud/ovirt: set mac pools via ovirt_clusters (#28120)
MAC pools are set per cluster since ovirt 4.1. Before that it was set
per data center.
2017-08-23 08:45:25 -04:00
Nijin Ashok
3c1ee57155 [cloud] ovirt: Add VM lease option to the ovirt_vms module (#27710)
Ovirt 4.1 is having new feature of VM lease for high availability.
The commit add support for configuring this in ovirt_vms module.
2017-08-23 08:44:51 -04:00
maorlipchuk
07feec30d3 [oVirt] Update/Add functionalities for import storage domain (#26568)
* ovirt_templates: Update the argument spec of templates.

Add id of template since it is needed for register.

* ovirt_vms: Register unregistered VM.

Use register of VM with id instead of name since an
unregitered entity can be registered also without name attribute.

* ovirt_hosts: Add iscsidiscover to ovirt_hosts

Adding functionality of iscsidiscover to be used to discover iscsi
targets.

* ovirt_storage_domains: Add support for import block storage domain.

* Add functionality of partial import to unregistered VMs.

* Add functionality of partial import to unregistered Templates.

* ovirt_hosts: Add iscsilogin to ovirt hosts.

Add functionality of iscsi login to ovirt hosts to be used to connect to
iscsi targets and to be able to import iSCSI storage domain eventually.

* Add ovirt_storage_templates_facts

Adding fact module for storage templates.
The module should help with registering unregistered templates.

* Add ovirt_storage_vms_facts

Adding fact module for storage VMs.
The module should help with registering unregistered VMs.
2017-08-23 08:44:02 -04:00
Ryan S. Brown
2f3d9566f9 Remove exec bit on elb_application_lb module 2017-08-23 08:32:20 -04:00
René Moser
fbcf6e23af yum: fix state=latest (#28547) 2017-08-23 10:22:16 +02:00
René Moser
6397e68bfd doc: replace play_hosts with ansible_play_batch (#28526) 2017-08-23 07:49:32 +02:00
Jordan Borean
4382216e10 win_copy: changes that were missed (#28533) 2017-08-22 23:23:07 -04:00
Jordan Borean
e631676546 fixed up win_robocopy return values (#28538)
* fixed up win_robocopy return values

* reduced lin size for validator
2017-08-22 23:22:08 -04:00
Ryan S. Brown
a9458ca609 Add aws_direct_connect_link_aggregation_group to changelog 2017-08-22 18:26:52 -04:00
Sloane Hertel
a48e0b5101 New Module to manage AWS direct connect link aggregation groups (#27250)
* Add module_utils/aws/direct_connect.py for frequently used functions

* new AWS Direct Connect link aggregation group module with tests and placebo recordings

* remove extra argument

* Remove use of undefined var

* Fix param name for extra exception codes for AWSRetry to use.

* Fix undefined var and line length and metadata version number

* Fix copyright headers
2017-08-22 18:24:54 -04:00
Eduard Iskandarov
fe21dd272d Kubernetes PATCH operation (#19428)
* add patch_operation parameter for kubernetes module

* Fix test errors
2017-08-22 18:11:10 -04:00
Matt Clay
871bd24358 Fix documentation references. 2017-08-22 17:09:28 -04:00
Trishna Guha
4271f6e5e6 fix aggregate doc example (#28528)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-23 02:16:45 +05:30
Trishna Guha
c2e41bf1ef remove net_command (#28525)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-23 02:07:39 +05:30