James Cammarata
135404738e
Fix a couple start-at-task issues
...
* added pattern matching to match v1 functionality
* check the task name, not the task+role name for matches
* make sure the input is unicode
Fixes #11692
2015-07-22 07:45:03 -04:00
ZviRackover
628925a77d
Fix: add missing import 'locale'
2015-07-22 01:09:31 +03:00
James Cammarata
4c733fe4b7
Fix issues with vars_prompt and vars_files
...
* Prompt had to be moved up, as it needed to be done before the first
templating of the play occurs, otherwise vars_files won't be templated
properly
* Fixed a bug related to an earlier fix of vars_files incorporating
extra vars to do the templating of the file name
Fixes #11404
2015-07-21 14:52:57 -04:00
James Cammarata
e64989beb4
Moving ConnectionInformation -> PlayContext
...
Also making PlayContext a child class of the Playbook Base class,
which gives it access to all of the FieldAttribute code to ensure
field values are correctly typed after post_validation
Fixes #11381
2015-07-21 12:13:50 -04:00
James Cammarata
dca36c1d16
Reestablishing the use of tags/when for role duplication detection
...
Not figuring these in can cause problems with "diamond" pattern relationships,
even though this is still not quite optimal.
2015-07-20 14:37:20 -04:00
Brian Coca
171c95672e
fixed gathering expression as it was triggering when gather_facts was no
2015-07-19 23:16:54 -04:00
James Cammarata
3d77723e3d
Cleaning up some stuff related to the connection info/become/executable change
2015-07-19 01:12:23 -04:00
James Cammarata
1c185b68be
Rearranging some become stuff in relation to action/connection plugins
...
Moving the make_sudo_cmd() calls back up to the action level so that connection
plugins don't have to know about it at all, and moving some of the become data
(prompt and success_key) into the ConnectionInformation object so they don't
need to be passed around needlessly.
2015-07-19 01:12:23 -04:00
James Cammarata
271a7f3281
Cleaning up some of the notify/facts logic added earlier to fix problems
2015-07-17 14:44:19 -04:00
James Cammarata
5abdd3b821
Handle notifications when coupled with a loop
...
Fixes #11606
2015-07-17 12:03:04 -04:00
Abhijit Menon-Sen
28e2eae902
Make gathering=explicit work again
...
There was a confusion between the valid values for defaults.gathering
(explicit/implicit/smart) and a play's gather_facts setting (boolean),
which resulted in gathering=explicit being ignored.
2015-07-17 13:05:00 +05:30
Brian Coca
c603caca27
removed extra print now that items are getting passed to callback in result
2015-07-16 15:13:35 -04:00
Piyush
f2bdd9af29
Fix #11369 A result is skipped when all it's children are skipped. This makes it fundamentally different from a result that was changed/failed/unreachable
2015-07-16 17:50:15 +05:30
James Cammarata
ba7243c5f9
Don't set changed for include tasks
...
Fixes #11197
2015-07-15 15:11:46 -04:00
Brian Coca
b76cb8f655
now that invocation is only async again, no need to sanitize
2015-07-15 10:40:37 -04:00
James Cammarata
0b035a4e35
Unicode in result debug statements caused a traceback
2015-07-15 01:56:28 -04:00
James Cammarata
8d887d8dd3
Adding back --start-at-task feature
...
Also implemented framework for --step, though it's not used yet
2015-07-14 15:02:20 -04:00
James Cammarata
4e94bb64d8
Fix group/host var loading relative to playbook basedir
2015-07-14 09:26:24 -04:00
Brian Coca
a09f44210e
now callback errors are not silent but warnings
2015-07-13 19:23:27 -04:00
Brian Coca
4203b699a8
removed dict comprehension as 2.6 does not like
2015-07-11 15:15:46 -04:00
Brian Coca
1274ce565d
added result sanitation to registered var and to callbacks
...
removed time display as it only is provided by command module
2015-07-11 01:05:29 -04:00
Brian Coca
a918a1bd16
now calls correct v2_on_any callback method
2015-07-10 10:30:33 -04:00
James Cammarata
b0e6baf8c3
Fix bug where options may not have the force_handlers value from the cli
2015-07-10 03:19:48 -04:00
James Cammarata
f8ddf2eb04
Move role cache into the play to avoid roles crossing play boundaries
2015-07-10 02:43:53 -04:00
James Cammarata
b520d5bc60
Lots of fixes for integration test bugs
2015-07-10 01:53:59 -04:00
James Cammarata
a9712bb0fb
Fixing some delegate_to bugs
...
* Moving connection creation until after the task is post_validated,
to make sure all fields are properly templated (#11230 )
* Fixing problems related to the connection method and remote address
lookup on the delegated-to host
Fixes #11230
2015-07-09 08:25:08 -04:00
James Cammarata
27fcf1a4b5
Fix bug in registered variables related to delegate_to changes
2015-07-08 12:38:24 -04:00
James Cammarata
8f0496d7ce
Fix usage of set_host_var when registering a result var
...
Fixes #11521
2015-07-08 09:15:55 -04:00
James Cammarata
2e5dfd57cc
Clear flag indicating role had run before each play is run
...
Fixes #11514
2015-07-07 21:47:48 -04:00
James Cammarata
293dd38d05
Correctly handle assigning results to the delegated to host
2015-07-07 16:09:36 -04:00
Brian Coca
50efeb13ba
made squashable with_ plugin list configurable
...
partially deals with #11383
2015-07-07 11:59:20 -04:00
Brian Coca
a6aedbcc51
now correctly picks up old become password host vars
2015-07-06 23:24:00 -04:00
James Cammarata
1d8ccfb99f
Fixing includes where the included file is "{{item}}"
2015-07-06 14:30:56 -04:00
James Cammarata
46b33152c8
Check for ansible_su*_pass as well as _password
...
Fixes #11500
2015-07-06 13:49:25 -04:00
Brian Coca
22a0aa016f
pbrun not forced to use local daemon anymore
2015-07-05 15:51:12 -04:00
James Cammarata
9155af20e3
Make sure vars in debug tasks aren't templated too early
...
If the syntax var={{something}} is used, that can be templated too
early in the post_validation, leading the debug module to fail when it
tries to template the same value in turn.
2015-07-05 01:06:54 -04:00
James Cammarata
67671e328a
Fix callback loading issue a slightly different way
2015-07-04 00:07:17 -04:00
James Cammarata
a51c165157
Revert "load callbacks on init again as they did not seem to load with new call from executor"
...
This reverts commit cf4ed9a556
2015-07-03 23:52:59 -04:00
James Cammarata
2ddd83360a
Revert "removed 2nd load_callbacks that was causeing dupe output"
...
This reverts commit de98dc2968
2015-07-03 23:52:49 -04:00
Brian Coca
de98dc2968
removed 2nd load_callbacks that was causeing dupe output
2015-07-03 14:28:10 -04:00
Brian Coca
cf4ed9a556
load callbacks on init again as they did not seem to load with new call from executor
2015-07-03 13:01:21 -04:00
James Cammarata
31239f44cd
Show failed result on a retry message
...
Fixes #10099
2015-07-02 10:33:41 -04:00
James Cammarata
08ad05c83b
Make sure callbacks are loaded in the tqm a bit earlier
...
Fixes #11463
2015-07-02 02:51:24 -04:00
James Cammarata
dcb9b5a69f
Make --module-path work and expand tilde's in paths
...
Fixes #9937
Fixes #9949
2015-07-01 12:39:39 -04:00
Benno Joy
4889d04fc6
fixes 11448 , yum with with_items
2015-07-01 10:02:54 +05:30
James Cammarata
ec4d1b11df
Fix some more handler issues
...
* Only notify handlers when the task is changed
* Don't run handlers on hosts which have failed
2015-06-30 14:44:41 -04:00
James Cammarata
2576f480fd
Restoring a state check to play_iterator, which otherwise broke block functionality
2015-06-30 13:57:47 -04:00
Matt Martz
65fdcf8b9d
Check for name or pkg when templating squashed items. Fixes #11430
2015-06-30 10:15:25 -05:00
Brian Coca
7416e00541
fixed condition for loading whitelisted callbacks
2015-06-29 20:45:50 -04:00
James Cammarata
927072546b
Fixing up some issues with plugin loading
2015-06-29 22:49:25 -04:00
James Cammarata
21c14363fd
Allow callback plugins to be whitelisted
2015-06-29 10:56:28 -04:00
Uli Martens
25fc0c7e1b
Fixing bug in failed_when results introduced by c3c398c
2015-06-26 16:55:06 -04:00
James Cammarata
b723f9a09a
Allow squashed loop items to use name=foo-{{item}}
...
Fixes #9235
Fixes #11184
2015-06-26 13:56:45 -04:00
Benno Joy
be81b650e8
fixes issue 11286 where role handlers are not run
2015-06-21 00:36:37 -04:00
James Cammarata
c3c398cffe
Cleaning up some task failure detection problems
...
* fixed a bug in which failures from a with_* loop were not being
caught correctly, leading to tasks continuing when they should stop
* when ignore_errors is enabled, the failure will no longer count
towards the number of failed tasks
2015-06-17 15:40:04 -04:00
James Cammarata
daa319881f
Make sure registered variable message is sent before other messages
...
Avoids a race condition where previously the registered variable message
was being sent after the 'host_task_ok' message, meaning the next task
may be started before the var is registered, leading to an undefined
variable error
2015-06-17 12:42:47 -04:00
James Cammarata
4b28a51f25
Don't fail outright when a play has an empty hosts list
2015-06-16 13:56:23 -04:00
Brian Coca
423f1233c8
removed typo file
2015-06-16 10:49:37 -04:00
Brian Coca
be8d797c23
fixed su prompt function reference
2015-06-15 01:07:02 -04:00
Brian Coca
872448e9e8
updated connection info update_vars to only update if data is not alreayd present
...
aslo added comment clarifying why we do this
2015-06-15 01:02:27 -04:00
Brian Coca
956937b110
made executable shell configurable again
2015-06-15 00:15:31 -04:00
Brian Coca
580993fef7
enabled initial support for password prompt on become
...
- moved check prompt/password functions to connection, make more senes there
- TODO: consider moving make_become to connection from connection_info
- removed executable param that was never overriden outside of connection info
2015-06-15 00:09:25 -04:00
Brian Coca
ff443d4534
added note to figurte out correct var udpate on connection_info
2015-06-14 23:48:03 -04:00
Brian Coca
de82c953f2
added privilege escalation special var mapping
2015-06-14 23:19:49 -04:00
Brian Coca
a248678518
initial become support to ssh plugin
...
- password prompt detection and incorrect passwrod detection to connection info
- sudoable flag to avoid become on none pe'able commands
2015-06-14 23:03:23 -04:00
Toshio Kuratomi
c346788194
Slight optimization of how we squash loops. Add dnf to the list of modules for which we squash.
...
Fixes #11235
2015-06-11 08:55:56 -07:00
Brian Coca
f29c1c7452
respect undefined config setting
2015-06-10 23:26:01 -04:00
Matt Martz
45b4ee9cfe
Don't allow setting become_pass in a play
2015-06-05 14:10:00 -05:00
Matt Martz
6bc2ea1f2b
Don't empty out become_pass. See #11169
2015-06-05 12:02:35 -05:00
Brian Coca
04f4f77d91
Merge pull request #11124 from sivel/jit-connect
...
Use a decorator to perform just in time connection
2015-06-05 11:38:17 -04:00
James Cammarata
ee5e166563
Fixing ansible_*_interpreter use
...
Fixes ansible/ansible-modules-core#1459
2015-06-04 15:43:07 -04:00
Matt Martz
9754c67138
Use a decorator to ensure jit connection, instead of an explicit call to _connect
2015-06-04 13:14:28 -05:00
James Cammarata
f3f3fb7c49
Fixing vars_prompt
2015-06-04 13:54:51 -04:00
Patrick McConnell
a899f8f016
Fix for task_executor on OS X
...
I get this exception during the setup task:
AttributeError: 'ConnectionInformation' object has no attribute 'remote_pass'
I believe it is supposed to be looking at the password attribute. Either that
or we should create a remote_pass attribute in ConnectionInformation.
2015-06-03 07:26:18 +02:00
Matt Martz
1b48111b12
If remote_addr isn't set, set to ipv4_address
2015-06-02 14:56:32 -05:00
James Cammarata
7a617e7b93
Merge pull request #11131 from sivel/issue/11130
...
Don't override ansible_ssh_host with inventory_hostname
2015-06-02 14:03:25 -05:00
Matt Martz
697a1a4061
Don't override ansible_ssh_host with inventory_hostname
2015-06-02 14:01:11 -05:00
James Cammarata
d1b4371287
Correctly evaluate changed/failed for tasks using loops
2015-06-02 09:42:08 -05:00
James Cammarata
4bc7703db3
Fixing some small bugs related to integration tests (v2)
2015-06-01 16:42:10 -05:00
James Cammarata
ecd5eb902d
Adding unit tests for ConnectionInformation (v2)
2015-05-22 03:32:40 -05:00
James Cammarata
361eb29146
Also make task_executor connect explicitly (v2)
2015-05-12 11:30:08 -05:00
James Cammarata
daf533c80e
V2 fixes
...
* PluginLoader class will now be more selective about loading some
plugin classes, if a required base class is specified (used to avoid
loading v1 plugins that have changed significantly in their apis)
* Added ability for the connection info class to read values from a
given hosts variables, to support "magic" variables
* Added some more magic variables to the VariableManager output
* Fixed a bug in the ActionBase class, where the module configuration
code was not correctly handling unicode
2015-05-11 11:29:48 -05:00
Brian Coca
d1977dad23
started implementing syntax check
2015-05-08 19:19:03 -04:00
James Cammarata
d34b586eb6
Add ability for connection plugins to set attributes based on host variables (v2)
2015-05-05 16:40:11 -05:00
James Cammarata
8fae2abed4
Properly fail out of the task loop in the linear strategy on failures (v2)
2015-05-05 13:41:32 -05:00
Brian Coca
1194195b1a
smoother commands with less quotes for pbrun
2015-05-04 11:38:28 -04:00
James Cammarata
803fb397f3
Fixing filter plugins directory from switch
2015-05-04 01:33:10 -05:00
James Cammarata
ce3ef7f4c1
Making the switch to v2
2015-05-03 21:47:26 -05:00
