Having used this script several times today, I came to notice the $SubjectName variable, being passed in via the CLI, is essentially ignored when generating the SSL certificates, rendering it useless. I believe it's a good idea to have it in place, so I've updated the script to reflect this.
I also cleaned up some random new lines throughout the file, and expanded on a comment.
It might be worth going a step further and commenting the file fully, as most people reviewing this file won't be familiar with PowerShell (like I wasn't unitl a few days ago). It could be helpful.
The current script fails on machines which have network interfaces designated
as connected to "Public" networks (choices for network designation being
Private, Domain, Public). This commit changes the script to NOT prevent winrm
initialization when device is connected to a "Public" network.
Replace .iteritems() with six.iteritems() everywhere except in
module_utils (because there's no 'six' on the remote host). And except
in lib/ansible/galaxy/data/metadata_template.j2, because I'm not sure
six is available there.
$powershell path is set to "C:\powershell" at line 27. This is fine, but on line 82 $powershellpath is called as ".$powershellpath\$filename". Because the path at line 27 is absolute, a period preceding the $powershellpath is not required at 82. It actually causes an error:
Start-Process : This command cannot be executed due to the error: Unknown error (0x80041002).
At C:\users\Nathan Sosnovske\Documents\ps2to3.ps1:81 char:14
Start-Process <<<< -FilePath ".$powershellpath\$filename" -ArgumentList /quiet
CategoryInfo : InvalidOperation: (:) [Start-Process], InvalidOperationException
FullyQualifiedErrorId : InvalidOperationException,Microsoft.PowerShell.Commands.StartProcessCommand
Removing the period on line 82 before $powershellpath fixes this error.
commit 5b9d29e08fba6402efccaa1ca56d834ff58f4b55
Merge: 7286f3a 111561f
Author: Michael DeHaan <michael.dehaan@gmail.com>
Date: Sun Jul 15 14:34:10 2012 -0400
Merge branch 'devel' of https://github.com/pas256/ansible into pasec2
commit 111561f7829b517fb0b7577a0e2147292bdba58f
Author: Peter Sankauskas <pas256@gmail.com>
Date: Mon Jul 16 16:13:48 2012 -0700
Reading the config file from the same directory as the script, and
fixing typo in security group name
commit e63659d04e65c0be3db833038f55a21d2ec511a9
Author: Peter Sankauskas <pas256@gmail.com>
Date: Mon Jul 16 10:56:59 2012 -0700
Adding list of variables to documentation
commit d0aecf025e23cf26f3df5a253639b0ec425b7223
Author: Peter Sankauskas <pas256@gmail.com>
Date: Fri Jul 13 15:35:00 2012 -0700
Finished EC2 external inventory script
commit 136b8a50824b7f964f162fad153784899d6dd634
Author: Peter Sankauskas <pas256@gmail.com>
Date: Thu Jul 12 18:01:44 2012 -0700
Almost done, just a few more types to deal with
commit 09f92052ce2e21a2c216692a20ce1bb03eacc2d9
Author: Peter Sankauskas <pas256@gmail.com>
Date: Tue Jul 10 23:43:30 2012 -0700
Adding region options to config, and getting host details happening, but
need to figure out complex types
commit a940c9b8fb9258043ec4f4a37fef80fdbcfcda7b
Author: Peter Sankauskas <pas256@gmail.com>
Date: Tue Jul 10 18:06:05 2012 -0700
Converting to a class, commenting methods, reading settings from a
config file, and starting to work on the host variables
commit 43eb3214a6bdd65d3ef3961183252932b6984004
Author: Peter Sankauskas <pas256@gmail.com>
Date: Mon Jul 9 13:11:27 2012 -0700
First pass of the Ansible EC2 inventory script
