1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

35397 commits

Author SHA1 Message Date
John Barker
10cd2cd1b7 Manually fix issues that autopep8 introduced
* iam.py 161 -> 160 chars
* lamba -> single line function -> multiline function

Avoid redefining key

iam line length

iam.py now clean
2017-12-07 20:25:55 +00:00
John Barker
c57a7f05e1 Bulk autopep8 (modules)
As agreed in 2017-12-07 Core meeting bulk fix pep8 issues

Generated using:
autopep8 1.3.3 (pycodestyle: 2.3.1)
autopep8 -r  --max-line-length 160 --in-place --ignore E305,E402,E722,E741 lib/ansible/modules

Manually fix issues that autopep8 has introduced
2017-12-07 20:25:55 +00:00
Will Thames
d13d7e9404 Fail when attempting to modify unmodifiable target group parameters (#33246)
* Fail when attempting to modify unmodifiable target group parameters

As you can't modify Port, Protocol or VPC id for a target group, fail
when this happens rather than pretending to do it.

One could argue that the target group could be recreated rather than
failing, but this has massive knock on implications to other resources
that depend on the TG (all ASGs would need to be updated, the ELB
listener would need to be updated, etc)

* Use `.get()` instead of direct dictionary access
2017-12-07 15:17:45 -05:00
Ryan S. Brown
55cd1f3377 Add ec2_placement_group to changelog 2017-12-07 14:51:24 -05:00
Brad Macpherson
a12cbc3dde [cloud] ec2_placement_group module to create/delete EC2 Placement Groups. (#33139)
* Added modules to create, delete, and describe EC2 Placement Groups.

* Remove unnecessary print statement

* Update to use boto3.

* De-linting

* Remove facts from this PR

* Update to newer method of handling Boto3 connections and exceptions.

* Futzing around with imports and HAS_BOTO3

* Fix up exception imports.

* Remove redundant default.

* Handle DryRunOperation errors appropriately.

* Remove redundant BOTO3 check.

* Use shorter licence declaration.

* Remove redundant HAS_BOTO3 import.

* Add AWSRetry decorators to API calls.

* Add new 'strategy' parameter to allow for cluster and spread PGs.
2017-12-07 14:44:09 -05:00
John R Barker
87776d75dc
Disable automerge while working on pep8 2017-12-07 19:00:19 +00:00
Kirill German
4e9aa8bea2 Adding ipmi settings for zabbix host (#33435)
* adding ipmi settings zabbix host

* adding ipmi settings zabbix host

* adding ipmi settings zabbix host

fix misspelling

* ipmi settings for zabbix host

add newline at eof

* update documentation and example section

* fix documentation

* fix documentation

delete 'choises'

* delete whitespaces

* fix default ipmi settings
2017-12-07 18:47:33 +00:00
ZhijunZhao
f8d7e477f0 fix azure test case failure for function apps module (#33658) 2017-12-07 12:41:19 -05:00
Andreas Olsson
b78ab37a94 Only expose rekey options to ansible-vault command
`ansible-vault` is the only cli command which knows how to handle the
rekey options `--new-vault-id` and `--new-vault-password-file`. No
point in exposing those rekey options to any of the other ansible
commands.

On a practical level I think this matters most in ensuring that
`--help` doesn't produce any false/unhelpful output.
2017-12-07 11:48:20 -05:00
Tim Rupp
a0dc776f56
Fixes a weird udf scenario (#33681)
The situation happened where in udf it stopped provisioning correctly.
Seems like the best resolution is to restart asm.
2017-12-07 08:47:35 -08:00
Eike Frost
31e3b8197f zabbix_host: fix integration tests only working individually (#33630)
* remove mod_evasive which is potentially installed by apache2_module
integration test and add zabbix_host to CI
2017-12-07 08:32:28 -08:00
Matt Martz
a7e49cde3b
Add some ignores on some namespaces for a few users (#33651) 2017-12-07 11:30:25 -05:00
Matt Martz
28373e1fe0
Address recent changes to tests to fix jinja tests as filters (#33679) 2017-12-07 11:30:09 -05:00
Brian Coca
d850992526 report correct file for callback 2017-12-07 11:28:42 -05:00
Jacob McGill
5e46a0add6 ACI Query: Update var name to be unique (#33217)
* ACI Query: Update var name to be unique

* Update dict copy to use deepcopy

* Update dict copy to use deepcopy
2017-12-07 16:26:38 +01:00
s-hertel
1057ec3dc4 Revert "add support for AWS NLB - fixes #30701 (#30907)"
This reverts commit 78858a5b12.
2017-12-07 10:28:40 -05:00
Peter Sprygada
1699a39ad0 fixes guess_os for netconf connections (#33671)
* fixes guess_os for netconf connections

This change fixes invalid calls to play_context when the network_os is
not set and the connection attempts to guess the network_os.  The method
will now check the correct values for ssh key file and allow agent
instead of returning errors.

* fix up pep8 issues
2017-12-07 20:17:41 +05:30
Kedar Kekan
012a96dabd
code cleanup for --diff and --check modes (#33665)
* code cleanup for `--diff` and `--check` modes

* fixes UT to remove exec_command
2017-12-07 20:14:57 +05:30
John R Barker
4d67cdd1f7
Use module formatting (#33413) 2017-12-07 14:26:52 +00:00
John R Barker
c2bef76c46
Various doc formatting fixes (#33626)
* Avoid italics from `with_`
* C() is for Modules, not for RST
* RST uses ``...`` for code
2017-12-07 14:25:46 +00:00
Matt Martz
349099a4c6
Fix sorting in man template on python3. Fixes #33663 (#33673) 2017-12-07 09:16:04 -05:00
Igor
22f4074daa Zabbix 3.4 support fix for zabbix_template module. (#33462)
* Zabbix 3.4 support fix.

As of 3.4 Zabbix version application does not have 'updateExisting'.

* added updateExisting in applications for old zabbix support.

* small codestylefix
2017-12-07 08:06:54 -05:00
Abhijeet Kasurde
2caae251ff
VMware: Refactor vmware_portgroup module (#33442)
This fix adds following:

* hosts as argument spec
* cluster_name as argument spec
* refactor to use Pyvmomi class
* API refactor and documentation

Fixes: #18980

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-07 16:47:38 +05:30
John R Barker
f4cc3fb56d
Remove fixme coment 2017-12-07 10:34:10 +00:00
John R Barker
e4a465b6e8
Docs: Network become for privilege mode (#33367)
* Network become for privilege mode

* Document what privilege mode is
* How to tell if you need it
* How to enable
* Tidy up formatting on page
* authorize & auth_pass
* network group_vars.
2017-12-07 10:27:43 +00:00
Abhijeet Kasurde
d78d044142 Fix documentation about mode in openssl_privatekey (#32664)
This fixes adds documentation about undocumented parameter
'mode'. Also, adds logic to specify mode in custom symbolic permissions.

Fixes: #32616

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-07 04:47:23 -05:00
Deepakkothandan
78858a5b12 add support for AWS NLB - fixes #30701 (#30907)
* add support for NLB

* added version for parameter type
2017-12-07 03:06:50 -05:00
Matt Davis
b91117dac8
azure_rm_containerservice (#33597)
* add acr

* acr

* acr

* fix a minor error

* add tests and fixes as suggested

* use get_mgmt_svc_client to enable bi

* fixes as zim suggested

* code refinement

* get acr instance before update

* fix a bug

* remove Classic sku as it's going to deprecate

* pass sanity test

* fix sanity

* fixes based on comments

* fix broken namespace unregistered error

* fix a bug

* fix a bug

* fix

* add register namespace

* fixes tests

* remove pdb

* add ci azure test

* removed required: false

* renamed acr -> containerregistry

* fixed spelling mistake

* fixed idempotence

* fix for idempotence was wrong

* fixed a few issues

* different log when exception different than ResourceNotFound

* self.fail instead of log

* updated sample return value

* added login server in results

* fixed else

* fixed line too long

* cmp -> __ne__

* fixed trailing whitespace

* output.changed is false when instance updated

* fix for state change

* one more update

* update instance only when location or sku has changed

* fixed syntax error

* fixed acr test

* just removed unnecessary comment to trigger ci

* update return value shape

* flatten `state`
* change credential dictionary state
* add credentials to integration tests
2017-12-06 20:30:28 -08:00
Kevin Brebanov
4c242ad2e7 Remove myself as apk maintainer (#33546)
* Remove myself as apk maintainer

* Add myself under the 'ignored' key
2017-12-07 11:26:35 +10:00
Kedar Kekan
4cc06cca1c
* Fix module._result['diff'] (#33654) 2017-12-07 06:19:14 +05:30
Alexey Shumkin
6f719ea848 fixed: win_copy: typo "file file" (double "file") (#33620)
* fixed: win_copy: typo "file file" (double "file")

Signed-off-by: Alexey Shumkin <Alex.Crezoff@gmail.com>

* Add quotes around filenames/directories

* Fix tests for new quotes

* Fix tests for new quotes

* One more ?

* Another one...
2017-12-07 00:42:39 +01:00
Sloane Hertel
4071cd7a95 Remove check for HAS_BOTO3 since AnsibleAWSModule checks it (#33649) 2017-12-07 08:08:10 +10:00
John Slay
065a2fe10d Add requirements to npm module (#33641)
npm is required in order for this module to work.
2017-12-07 08:03:32 +10:00
Alexandre Garnier
b4e6028ee7 Fix documentation description of remote_addr for docker connection plugin (#33520) 2017-12-07 07:41:33 +10:00
Abhijeet Kasurde
03d1e63f57 Fix wrong number of arguments for format (#33542)
This fix adds wrong number of arguments for format in
ec2.py module_util.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-07 07:32:57 +10:00
Denis Chapligin
b06dfc4891 Adds 'discard_after_delete' property to ovirt_storage_domains module. (#33450) 2017-12-06 16:22:44 -05:00
Alexey Shumkin
f13656782a fixed: win_copy failure from a VirtualBox share to a local path (#33576) 2017-12-07 06:55:50 +10:00
Brad Macpherson
dd041e6f72 Added module to describe EC2 Placement Groups. (#33228)
* Added module to describe EC2 Placement Groups.

* Update to newer way of handling Boto3 connections and exceptions.

* Futzing around with imports and HAS_BOTO3

* Fix up exception imports.

* Fix license block

* Correct task indenting in doc

* Added list-filtering example to docs
2017-12-06 15:36:25 -05:00
Brian Coca
65ffb92bff ensure quote runs on text
fixes #33260
2017-12-06 12:16:45 -08:00
Eike Frost
7ec692ea7f add Logan2211 to maintainers for zabbix_template (#33627) 2017-12-06 20:14:37 +00:00
Andreas Olsson
7bd54a51e2 Add --vault-id support to ansible-pull
Without this additional code snippet `ansible-pull` will still accept
the `--vault-id` option. It just won't pass the option along when
invoking `ansible-pull`.
2017-12-06 13:40:20 -05:00
Kedar Kekan
2bc4c4f156
IOS-XR NetConf and Cliconf plugin work (#33332)
*  - Netconf plugin addition for iosxr
 - Utilities refactoring to support netconf and cliconf
 - iosx_banner refactoring for netconf and cliconf
 - Integration testcases changes to accomodate above changes

* Fix sanity failures, shippable errors and review comments

* fix pep8 issue

* changes run_command method to send specific command args

* - Review comment fixes
- iosxr_command changes to remove ComplexDict based command_spec

* - Move namespaces removal method from utils to netconf plugin

* Minor refactoring in utils and change in deprecation message

* rewrite build_xml logic and import changes for new utils dir structure

* - Review comment changes and minor changes to documentation

* * refactor common code and docs updates
2017-12-06 22:37:31 +05:30
Evgeny Fedoruk
4b6061ce3e Fixing wrong parameter name in documentation example (#33633)
Fixes #33529
2017-12-06 17:04:13 +00:00
Andrew Gaffney
6a84772290 Add module_stdout/stderr fields to list in 'debug' callback plugin 2017-12-06 08:33:02 -08:00
Brian Coca
395566746e removed unused 2017-12-06 11:22:11 -05:00
rahushen
1a12e733b9 nxos_facts: add check for ipv6 (#33594) 2017-12-06 09:41:31 -05:00
Samer Deeb
48d3cbfc0f Adding network_cli support in mlnxos (and removing provider) (#33511)
Signed-off-by: Samer Deeb <samerd@mellanox.com>
2017-12-06 14:22:15 +00:00
Evgeny Fedoruk
e73d3dfe20 Fixing bug when returned 404 status code considered as invalid (#33530)
In case of workflow delete action, the returned 404 status code
considered as invalid although it's a valid code for not found (deleted)
entity.
Removed verification of the status. Only success should be verified.

Fixes #33524
2017-12-06 14:18:45 +00:00
Ganesh Nalawade
dfd68e4966
Fix persistent reset_connection issue (#33590)
Fixes #33589

If persistent socket does not exist catch the execption
and ignore it as the coneection is already closed.
2017-12-06 19:37:09 +05:30
Major Hayden
666692069d Clean up nmcli docs (#33596)
This patch cleans up the documentation for `nmcli` module.
2017-12-06 08:48:59 -05:00