Toshio Kuratomi
4ccea9905b
Fix async for old style modules and don't send an args file for new-style modules
2016-04-01 20:04:25 -07:00
James Cammarata
26a4761d0f
Fix logic error in script action plug related to use of shell.exists
2016-03-31 15:21:45 -04:00
Brian Coca
4b3257c4fe
Merge pull request #15208 from bcoca/constants_pathlist
...
centralize path list handling
2016-03-30 19:49:18 -07:00
James Cammarata
eab4ce19f3
Making the return parsing in ActionBase generic for reuse
...
Now also correctly parses the return value for the _low_level_execute_command
2016-03-30 12:45:21 -04:00
Brian Coca
92d154f4ef
centralize path list handling
...
move it to constants and avoid duplicating code or misinforming
developers on the nature of the data
2016-03-30 07:16:09 -07:00
Brian Coca
3f6166d2bf
always return rc
2016-03-30 07:15:51 -07:00
nitzmahone
05af5c88ea
fix Mac chown/chmod -R issue, add error checks
...
The changes to chown/chmod were broken on Mac (-R was being appended to the end of the command- OSX requires it before the file list).
A number of base action remote setup commands were also blindly proceeding without checking for success. Added error raises for unrecoverable failure cases.
2016-03-29 07:44:09 -07:00
Brian Coca
e9a4526251
allow bypassing executable setting
...
if you set executable to an empty string this avoids passing one to the command constructor
fixes #14813
2016-03-28 08:02:27 -07:00
Toshio Kuratomi
0fffb6c60c
Merge pull request #15163 from ansible/synchronize-connection-vs-play_context
...
Use _connection instead of _play_context for information about the connection
2016-03-27 10:24:46 -07:00
Brian Coca
28d20dbe53
moved 'path exists' function to shell
...
now it will work with powershell/winrm
2016-03-25 12:56:48 -07:00
Toshio Kuratomi
0cabd133ba
have to always run dwim() on the path to get the full absolute path.
...
Fixes #14944
2016-03-25 12:09:30 -07:00
Toshio Kuratomi
e2f5762232
Use _connection instead of _play_context for information about the connection
...
If we're not delegating then we change _connection into a local
connection midway through the file but we don't change
_play_context.connection (no need to alter that). When we later check
it in process_remote() we need to know the actual connection, not the
connection that we thought we were going to use at the start of run().
So we have to use _connection.transport in process_remote(). The rest
of the places could use either one (because we have not yet changed to
a local connection) but we go ahead and switch those to
_connection.transport as well to avoid confusion in the future.
Fixes https://github.com/ansible/ansible-modules-core/issues/3136
2016-03-25 09:25:19 -07:00
Brian Coca
1ebc2fda71
removes python requirement to script
...
mistakenly added when checksum was made to use stat module
fixed assertion in test
2016-03-24 16:17:58 -07:00
Toshio Kuratomi
f323eb858e
nv_por is needed later in the file
...
Fixes #14654
2016-03-24 06:58:56 -07:00
Toshio Kuratomi
52e9209491
Don't create world-readable module and tempfiles without explicit user permission
2016-03-23 09:52:19 -07:00
Brian Coca
db61e9be0c
add ansible_executable inventory var
...
also handle the overrides appropriately
also new executable to set shell type
2016-03-17 18:54:37 -07:00
Toshio Kuratomi
fe278202f2
Fix saving of tracebacks on module failure
2016-03-15 20:31:40 -07:00
James Cammarata
52efd7438c
Fixing template/assemble action plugins related to tmp dir use/cleanup
2016-03-10 14:07:58 -05:00
Matt Clay
f878a5d2e0
Fix unicode handling in connection plugins.
2016-03-10 09:04:32 -08:00
Brian Coca
5cbdaff9fd
avoid creating extra tmp dirs we don't delete
...
fixes #14867
2016-03-10 10:31:36 -05:00
Peter Sprygada
ae5951b97f
Merge pull request #14698 from privateip/plugin_action_ops_template
...
updates the ops_template plugin action backup key
2016-03-09 22:14:56 -05:00
Brian Coca
7d8b84dae6
fix assemble to not pass extra args to copy/file
...
also small refactor to dedupe code
fixes https://github.com/ansible/ansible-modules-core/issues/3154
2016-03-06 10:00:36 -05:00
Toshio Kuratomi
8f1303c81a
Remember to use errors=strict since this is looking up a filename on the filesystem (ie it has to match exactly)
2016-03-03 20:56:50 -08:00
Toshio Kuratomi
253376b3b7
Make the source path into a byte string before passing to os.path
2016-03-03 20:44:01 -08:00
Brian Coca
f565508d7f
Merge pull request #14764 from bcoca/max_diff_config
...
made max diff size configurable
2016-03-03 18:19:27 -05:00
Brian Coca
c24249c57d
made max diff size configurable
2016-03-02 17:25:22 -05:00
Brian Coca
ca0797fc4e
avoid issues when stdin is a closed file
...
this seems to happen when nohup is involved, so the check tty
does not get a chance to fail, it just works with pipes
fixes http://github.com/ansible/ansible-modules-core/issues/3166
2016-03-02 11:58:16 -05:00
Peter Sprygada
f67bf3f775
updates the ops_template plugin action backup key
...
This commit changes the key the ops_template will search for in order
to backup the current configuration to local disk on the Ansible control
host. This change was made to make ops_template consistent with the
other network template modules.
2016-02-28 23:40:05 -05:00
James Cammarata
2db3f290ba
Fix logic error when copying files recursively to a directory
2016-02-23 16:29:57 -05:00
Brian Coca
6eb4633b07
always return a checksum key, even if empty
2016-02-23 15:07:14 -05:00
Brian Coca
5552c04976
allow skipping debug depending on verbosity
2016-02-18 06:58:43 -08:00
Brian Coca
3e407ed743
Merge pull request #14490 from bcoca/stat_instead_of_checksum
...
Use stat module instead of checksum code
2016-02-18 01:45:50 -08:00
Brian Coca
2b5fffa751
updated to use to_unicode as per feedback
2016-02-18 01:41:23 -08:00
Brian Coca
b9d0662faf
use stat module instead of checksum code
...
- added new function for action plugins this avoids the very fragile checksum code that is shell dependant.
- ported copy module to it
- converted assemble to new stat function
- some corrections and ported temlpate
- updated old checksum function to use new stat one under the hood
- documented revamped remote checksum method
2016-02-16 08:43:38 -05:00
Brian Coca
6dc910c13a
shell + become fixes
...
1 less level of shell + quoting
simplified become commands, less quote and shell
2016-02-15 13:00:13 -05:00
Peter Sprygada
22aaff5af7
adds new action plugin iosxr_template
...
This adds a new action plugin iosxr_template that allows the
iosxr_template module to pass network device configurations through the
template engine. It also allows configurations to be backed up.
2016-02-12 17:08:21 -05:00
Peter Sprygada
cf251258a8
initial add of new action plugin junos_template
...
This adds a new action plugin, junos_template that allows the
the junos_template module to perform the templating function. It
implements net_template
2016-02-11 08:28:35 -05:00
Brian Coca
3079a03773
read full file when doing diff
...
but avoid reading file at all or full file when file is too big for diffing
2016-02-10 12:05:45 -05:00
Matthew Stoltenberg
d36394d6a6
strip BECOME-SUCCESS at lower level
...
Fixes #14395
2016-02-09 13:03:18 -05:00
James Cammarata
162dd2594f
Filter become success string from the stdout of script results
...
Fixes #14390
2016-02-09 12:34:15 -05:00
Toshio Kuratomi
0f15e59cb2
Also hide the before state of files with --diff and no_log
2016-02-08 22:05:46 -08:00
James Cammarata
1ea21f1f8c
Also chmod the args file path when using become for old-style modules
...
Fixes #14348
2016-02-08 10:00:26 -05:00
Peter Sprygada
18094d8595
Merge pull request #14313 from chouseknecht/net_template_changes
...
When in context of a role, create backup dir within role_path
2016-02-04 20:21:12 -05:00
Toshio Kuratomi
e2a7ba35db
Fix --diff to respect no_log task parameter.
2016-02-04 12:44:45 -08:00
chouseknecht
4f61fb6cce
Add safety check on _backup key.
2016-02-04 14:47:43 -05:00
chouseknecht
0766219f58
When in context of a role, create backup dir within role_path
2016-02-04 14:47:43 -05:00
Peter Sprygada
f30d5b1d94
Merge pull request #14012 from privateip/action_nxos_config
...
initial add of action plugin nxos_template
2016-02-04 11:41:41 -05:00
Peter Sprygada
c7180cf1a5
Merge pull request #14011 from privateip/action_ops_config
...
initial add of action plugin ops_template
2016-02-04 11:41:29 -05:00
Peter Sprygada
a48b521e62
Merge pull request #14010 from privateip/action_ios_config
...
initial add of action plugin ios_template
2016-02-04 11:41:08 -05:00
Peter Sprygada
30d03b93b4
Merge pull request #14009 from privateip/action_eos_config
...
initial add of action plugin eos_template
2016-02-04 11:40:21 -05:00
