1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

12423 commits

Author SHA1 Message Date
Evan Coury
f445e3c606 Update rax root pubkey example
The example was showing how to use the `files` option to pass in a local file as an authorized public key for root. While this works, it's a bit sloppy, given that there's a specific option, `key_name` which will use one of your public keys on your rackspace account and add it as an authorized key for root. In our case, one of our admins didn't notice the `key_name` option because they scrolled straight to the example and saw the `files` strategy.

I propose that the example still shows `files`, but not using a root public key as an example, and instead also demonstrate the `key_name` option so that it's clear from the example how to get the initial root public key deployed.
2014-09-17 18:06:59 -07:00
Sam Pierson
44cab4bf75 [#9048] convert Route53 TTL to integer before comparison
boto/Route53 are returning TTL as a string.
The route53 module is comparing it with an integer and therfore thinks the DNS entry has always changed.
2014-09-17 14:47:27 -07:00
James Cammarata
6b1ae82acc Allow filtering by availability zone for exact_count with ec2
Fixes #8863
2014-09-17 15:49:26 -05:00
James Cammarata
c3612e08f9 Move delegate_to out of runner module_vars to prevent bleeding across runs
Previously, the delegate_to value was stored in the module_vars of runner,
which could lead to bleeding that value across runs and incorrect hosts
being delegated to. This patch moves the value to a local variable in
the Runner class with some related refactoring of _compute_delegate() in
Runner (since the value is no longer required to be a parameter).

Fixes #8705
2014-09-17 14:24:31 -05:00
Toshio Kuratomi
5ec8c28d2a remove debugging that was causing failure 2014-09-17 10:25:54 -07:00
Toshio Kuratomi
8dfc54b517 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
2014-09-17 09:34:33 -07:00
Toshio Kuratomi
24a33d5c10 Revert "Refactor the Linux service_enable() method" needs some debugging
This reverts commit e294e31fd3.
2014-09-17 09:17:33 -07:00
James Cammarata
ed3c9c40ca Redoing patch for hostvars fix, since the previous one broke other tests 2014-09-17 11:04:10 -05:00
James Cammarata
3180a37457 Revert "Revert to using just the combined_cache for HostVars"
This reverts commit e9229cfeaa.
2014-09-17 11:04:10 -05:00
Toshio Kuratomi
e294e31fd3 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
2014-09-17 08:44:32 -07:00
James Cammarata
e9229cfeaa Revert to using just the combined_cache for HostVars 2014-09-17 02:32:09 -05:00
James Cammarata
28f6a18ef6 Allow git repo queries without a clone when update=no
This commit also makes the dest parameter optional, unless update=yes
(the default), since it is not required for queries without an update.

Fixes #8630
2014-09-17 02:05:29 -05:00
James Cammarata
b7a74e216f Merge pull request #8948 from sergevanginderachter/issue_8823
ansible-galaxy: exit with rc 1 if role doesn't exist/is not found
2014-09-16 21:47:29 -05:00
James Cammarata
4f03dd65ce Ensure port in docker expose list is a string
Fixes #8731
2014-09-16 21:38:49 -05:00
James Cammarata
bc583dabbc Removing reference to ansible-pull in bin/ansible-vault 2014-09-16 15:37:36 -05:00
James Cammarata
2b0b2f42df CHANGELOG update for ec2 filtering and file "following" param 2014-09-16 15:26:10 -05:00
James Cammarata
fa32bd34d6 Merge branch 'michalgasek-ec2-tag-filter' into devel 2014-09-16 15:24:46 -05:00
James Cammarata
21409d6052 Merge branch 'ec2-tag-filter' of https://github.com/michalgasek/ansible into michalgasek-ec2-tag-filter 2014-09-16 15:11:05 -05:00
Michael DeHaan
489574e072 Docs indentation - this time with feeling 2014-09-16 15:40:00 -04:00
Michael DeHaan
506d4554dc Fix documentation indent levels. 2014-09-16 15:27:40 -04:00
James Cammarata
4a9cf3f3f2 Allow hostvars variables to be templated
Fixes #7844
2014-09-16 14:25:55 -05:00
Michael DeHaan
590cfbac29 Merge pull request #9028 from dhoss/devel
updated git module documentation
2014-09-16 15:19:44 -04:00
James Cammarata
4f7fcf3463 Merge pull request #9026 from tedder/patch-1
rearrange description/short_description
2014-09-16 14:04:45 -05:00
James Cammarata
b9a1b0f088 Merge pull request #9025 from sivel/doc-vault-password-file
Document vault_password_file in intro_configuration
2014-09-16 14:02:41 -05:00
Toshio Kuratomi
9f70830569 My fix was wrong again. Base this try off of @mantiz's fix in #9016 2014-09-16 11:46:09 -07:00
Toshio Kuratomi
733290a731 Fix the case where a docker image is not part of a namespace.
Fixes #9016
2014-09-16 11:39:15 -07:00
James Cammarata
fdf126a337 Add note to ec2_vol state param regarding list option added in 1.8 2014-09-16 13:20:39 -05:00
James Cammarata
b376e208c7 Adding "follow" param for file/copy options
Also modifies the template action plugin to use this new param
when executing the file/copy modules for templating so that links
are preserved correctly.

Fixes #8998
2014-09-16 12:05:55 -05:00
Devin Austin
5dd9231743 updated git module documentation
Clarified key_file option for the git module, since it requires the user to specify a private key, not a public key.
2014-09-16 11:05:37 -06:00
Toshio Kuratomi
79a2e586fe Make systemd vs rht detection more robust for centos
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd.  Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.

Fixes #8997
2014-09-16 09:53:13 -07:00
Ted Timmons
d98bc79f77 further cleanup 2014-09-16 09:37:01 -07:00
Ted Timmons
61dfeaa43c rearrange description/short_description
it's really dorked on [the documentation page](http://docs.ansible.com/ec2_elb_lb_module.html). This puts it in line with other modules.
2014-09-16 09:35:20 -07:00
Matt Martz
c319df78f8 Also document force_color 2014-09-16 10:31:50 -05:00
Matt Martz
c1555987d7 Document vault_password_file in intro_configuration 2014-09-16 10:22:32 -05:00
Will Thames
2303044ffc Applied fix for sudo with no prompt to paramiko
Effectively reproduces @sivel's work from #8900 but for
the paramiko connection. Fixes #8418 when using paramiko

This allows `_remote_md5` to work if a sudo password is
passed in when no sudo password is required.
2014-09-16 10:25:21 +10:00
Matt Martz
de77f33796 Don't throw away useful stdout and stderr. Fixes #8418
When supplying a sudo password to a server that uses passwordless sudo,
we should not throw away useful stdout and stderr. This is particularly
important for modules that perform md5 checks as part of the pre module
execution.
2014-09-16 10:25:21 +10:00
Toshio Kuratomi
c6b26ff7c7 Remove duplicate call to remove tmp role file 2014-09-15 14:45:57 -07:00
Toshio Kuratomi
1e68041f9c Merge pull request #8995 from mscherer/fix_galaxy
Do not remove local role file if given on the commandline
2014-09-15 14:45:21 -07:00
Toshio Kuratomi
49a6af1378 Test that file touch does not keep a new file if we failed to set its
attributes
2014-09-15 12:36:52 -07:00
Toshio Kuratomi
a44ea2d1b7 Do not keep a new file if we fail to set its attributes. 2014-09-15 12:36:52 -07:00
James Cammarata
cdf938f2c2 Ensure remote files are chmod'd properly for su/su_user too
Fixes #8594
2014-09-15 13:15:46 -05:00
James Cammarata
0c4a7492bf Ensure checkmode is honored for templates that haven't changed
Fixes #8998
2014-09-15 11:37:53 -05:00
Toshio Kuratomi
9fb6cabe21 Fix splitting the tag from the image name
Fixes #8983
2014-09-15 09:01:07 -07:00
James Cammarata
8d6ed6e613 Merge pull request #8996 from mscherer/improve_doc_defaults
Mention defaults subdirectory in a more visible way
2014-09-15 09:58:34 -05:00
James Cammarata
d9b5986472 Merge pull request #8976 from nullren/patch-1
Update playbooks_variables.rst
2014-09-15 09:29:10 -05:00
James Cammarata
7a1a580e37 Merge pull request #8973 from sergevanginderachter/vsphere_guest_docfix
vsphere_guest module doc fix
2014-09-15 09:27:15 -05:00
Michael Scherer
8fb14db802 Mention defaults subdirectory in a more visible way
All examples do not show it, so only someone reading the doc from
end to end would know about it.
2014-09-13 13:25:07 +02:00
Michael Scherer
b9acaccc1d Do not remove local role file if given on the commandline
using this (for testing purpose) :
  $ ansible-galaxy install COPYING
  - error: the file downloaded was not a tar.gz
  - COPYING was NOT installed successfully.
  - you can use --ignore-errors to skip failed roles.

this result in COPYING being erased, which is surprising for the user.
This also prevent erasing requirements.yml if someone use the wrong flag.
2014-09-13 12:31:56 +02:00
Michael DeHaan
267b3fb7b7 Merge pull request #8988 from bbasleeper/bugfix_yum_module
Fix a bug causing yum module to not update to latest in some cases
2014-09-12 15:43:43 -04:00
Bruno BAILLUET
580968ca77 Fix a typo on is_update call inside latest function 2014-09-12 18:19:00 +02:00