1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

24 commits

Author SHA1 Message Date
Ross Williams
4c5239e82f pkgng: fix check_mode for annotate
Actions specified in the `annotate` parameter would
always be performed, even if `check_mode=yes`.

This commit fixes `check_mode` for the annotation
functions and adds integration tests to ensure that
check mode is honored in the future.
2021-10-12 18:37:39 +00:00
Ross Williams
8f013549fd pkgng: test invalid annotate strings
Ensure that some likely to occur, invalid strings
given to the annotate module parameter 1. fail,
2. do not cause an exception, and 3. do not create
any actual annotations on packages.
2021-10-12 18:33:05 +00:00
Ross Williams
b872b294fd pkgng: test multiple annotations
Test multiple annotations specified both in new (YAML list)
syntax and old (comma-delimited) syntax.

Rename some annotation test tags from the single-annotation
tests to make sure that single and multiple annotation tests
don't collide.
2021-10-12 18:09:33 +00:00
Ross Williams
8453c368c1 pkgng: test annotation for single package
Add/modify/remove annotation for a single package
2021-10-12 15:03:25 +00:00
Ross Williams
6c5f9810b0 pkgng: pass tests when package dependencies change
Tests that install packages with dependencies were failing
when those dependencies were not already installed, because
the count of installed packages was greater than the count
of requested to be installed packages. This change checks
for a count of installed packages that is greater than or
equal to the count of requested to be installed packages.

Example:
  - Test installs packages `zsh` and `fish`
  - `fish` has a dependency on `pcre2`
  - `pkg` reports `Number of packages to be installed: 3`
2021-10-12 13:43:05 +00:00
Ross Williams
406683383e pkgng: test jail creation logging less verbose
`ezjail-admin` had been spewing every filename copied
into the jail onto stderr, making the `ansible-test -v`
logs hard to scroll through. Changed it so that ezjail
output only shows up in the ansible task logs if
`ansible_verbosity > 1` (`-vv...`). Full `ezjail-admin`
output is always logged to `/tmp/ezjail.log`.
2021-10-12 12:57:53 +00:00
Ross Williams
a803240941 pkgng: test autoremove=yes only on FreeBSD > 12
The CI test runner on FreeBSD 12.0 times out when
downloading large packages.
2021-10-12 01:52:30 +00:00
Ross Williams
4f18ef5ba6 pkgng: add test for autoremove=yes
Install package with known dependencies, then
remove it and ask autoremove to run.
2021-10-11 19:55:28 +00:00
Ross Williams
aa88d68ebc pkgng: use YAML lists for multiple packages
I had been following the documentation examples, and
specifiying multiple packages on one line. The right way
to do it is with YAML list syntax.
2021-10-11 19:28:26 +00:00
Ross Williams
98ccc58ba0 pkgng: test state=latest for mixed install/upgrade
Test that a list of packages given, one not installed
and one installed but out-of-date are handled correctly.
2021-10-11 19:25:06 +00:00
Ross Williams
73eafc126f pkgng: test install multiple packages
Multiple packages should install with a single
invocation of the `pkg` utility.
2021-10-11 18:14:38 +00:00
Ross Williams
8805f408d6 pkgng: refactor tests for task reuse
Several tests need to install an out-of-date package
to test whether upgrades occur successfully, so this
commit refactors out the generation of the test package.

Also, factor out things like the name and path of the
test package so that is more maintainable should the
target test package (currently `zsh`) ever need to
change.
2021-10-11 17:10:35 +00:00
Ross Williams
d075c83ff2 pkgng: move FreeBSD tasks to imported file
Refactoring tests for more reuse and easier
readability.
2021-10-11 16:24:08 +00:00
Ross Williams
5b13caa2d3 pkgng: test pkg works on any FreeBSD version
Removing `ansible_distribution_version`, because the
test out-of-date zsh package should install on any
FreeBSD version.
2021-10-11 16:03:25 +00:00
Ross Williams
c38eeeda0a pkgng: add cached=yes test
Changed idempotency test, because this covers both.
2021-10-11 12:49:47 +00:00
Ross Williams
752817cf5a pkgng: refactor renaming test package manifests
refactored to make intent of adding '+' sign clearer
2021-10-11 02:11:26 +00:00
Ross Williams
0eb4c8221c pkgng: CI seems to dislike plus-signs in filenames 2021-10-11 02:11:26 +00:00
Ross Williams
68a1332a3f pkgng: use hand-generated test package
Instead of relying on a broken-ish installation
of an older package from FreeBSD 11, hand-generate
a package named `zsh` with no contents and a version
number of `0`. It can be installed on any architecture
and any revision of FreeBSD sucessfully, and it will
always be eligible for upgrade.
2021-10-11 02:11:26 +00:00
Ross Williams
7f30ac8a5b pkgng: add state=latest test
Including small filesize out-of-date package from
FreeBSD 11 package repository, because FreeBSD 11 is
currently EOL. This test might fail at some point in the
future if the pkg utility in a FreeBSD version > 14
makes breaking changes that prevents it from installing
older package formats.

If that occurs, the fix is to replace
`files/freebsd-release-manifests-20210413__FreeBSD_11.pkg`
with the version of freebsd-release-manifests from the oldest
non-breaking release of FreeBSD, and update the
references to it in tasks/main.yml accordingly.
2021-10-11 02:11:26 +00:00
Ross Williams
1654a70825 pkgng: add state=latest idemptency test
Add test between state=present and
state=absent that ensures state=latest runs
successfully on an already up-to-date package
with changed=false.
2021-10-11 02:11:26 +00:00
Ross Williams
9a867a38ee pkgng: add state=absent test
Also renumber `jail=...` test to make diffs less
noisy when adding more non-jailed tests.
2021-10-11 02:11:26 +00:00
Ross Williams
840cb8f408 pkgng: remove redundant test for docker container
These tests should be skip/docker, but the test
playbook also redundantly checked whether it was
running in a docker container.

Checking whether `ansible_facts.distribution` is
`FreeBSD` is really sufficient to be sure whether
the test is running in an environment that supports
the `pkgng` module.
2021-10-11 02:11:26 +00:00
Ross Williams
867b7d5bee pkgng: test with zsh not bash package
Had been using bash package, because it's not
likely to disappear from the package repository
any time soon. Turns out that bash is already
installed on the Ansible community.general
FreeBSD CI VM image, which makes the test fail.

Zsh probably isn't going away any time soon,
either, and likely won't be installed on the
CI image.
2021-10-11 02:11:26 +00:00
Ross Williams
bfdaed0ce5 pkgng: add basic integration tests
Test installing a package
Test installing a package into a jail
2021-10-11 02:11:26 +00:00