1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

23284 commits

Author SHA1 Message Date
Jordan Borean
ce515a626c
powershell - fix for ANSIBLE_KEEP_REMOTE_FILES on older Pythons (#45942) 2018-09-21 10:03:57 +10:00
Yanis Guenane
a7bf505474 inventory/tower: authors -< author so Doc can pick it up (#45936) 2018-09-20 16:44:22 -05:00
Sam Doran
4b121ea2ad
Remove temp checksum file (#45871) 2018-09-20 16:32:21 -04:00
lwm
0947948d6b Use dashes not underscores for linode labels. (#44719)
This is because underscores are illegals in hostnames and users might
want to create the same host names are the name of the Linode machine
(as in the report in #30059).

Closes https://github.com/ansible/ansible/issues/30059.
2018-09-20 15:42:45 -04:00
lwm
4774ea7a15 Linode: docs note for py3 limitation and deprecated API (#44723)
* Add note that linode-python having no py3 support.

Closes https://github.com/ansible/ansible/issues/44695.

* Add note that the module uses the deprecated API.
2018-09-20 15:41:46 -04:00
Andrew Gaffney
acac001742 Add number of skipped tasks to play recap in 'default' callback (#45797) 2018-09-20 14:38:54 -04:00
Michael Johnson
1a3bc7d746 Update azure_rm_virtualmachine.py (#45325)
* Update azure_rm_virtualmachine.py

A lot of Azure images are not cloud-init ready and need to be prepared manually before attempting to use the custom_data option of this module. Adding a line to the description to make others aware. If, like me, they are used to working with AWS AMIs that all seem to have cloud-init baked in, this could prevent some troubleshooting as to why their custom_data scripts aren't running in Azure.

* fixing addition to azure_rm_virtualmachine.py

* Update azure_rm_virtualmachine.py

* final update

* fixed url syntax

* nuked trailing whitespace
2018-09-21 02:22:53 +08:00
Matt Martz
95e77ac853
Ensure that the src file contents is converted to unicode in diff info (#45744)
* Ensure that the src file contents is converted to unicode in diff info. Fixes #45717

* Fix up and cleanup

* The diff functionality in the callback plugins should have the
  to_text() calls removed since we're now doing it in ActionBase
* catching of UnicodeError and warnings in the callback diff
  functionality from 61d01f549f haven't been
  needed since we switched to to_text so remove them.
* Add a note to ActionBase's diff function giving an example of when the
  diff function will be inaccurate and how to fix it

* Fix callback get_diff() tests

I believe the unittests of callback's get_diff() were wrong.  They were
sending in a list where strings were expected.  Because previous code
was transforming the lists into strings via their repr, the previous
tests did not fail but they would have formatted the test cases output
in an odd way if we had looked at it.
2018-09-20 12:31:48 -05:00
Roman D
dd5d191d7a Clarified documentation for the unsafe_writes option (#27471)
* Clarified documentation for the unsafe_writes option per #24449.
2018-09-20 11:40:14 -05:00
Rémy Léone
7c7a7efbbe Add an option to enable public ip at server creation (#44826) 2018-09-20 12:13:26 -04:00
Adam Miller
2fe150a1ef fix dnf wildcard pkg removal - fixes #27744 and #36970 (#45357)
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-09-20 12:13:17 -04:00
max-allan-surevine
cb460dee74 Update keycloak_client.py (#43547)
* Update keycloak_client.py to document the 'realm' parameter, eliminate E322 ignore
2018-09-20 10:34:04 -05:00
Nathaniel Case
406b59aeba
Move persistent connections to only use registered variables (#45616)
* Try to intuit proper plugins to send to ansible-connection

* Move sub-plugins to init so that vars will be populated in executor

* Fix connection unit tests
2018-09-20 09:56:43 -04:00
Jose Delarosa
e701b5a412 Fixes HTTP redirect issue (#45513) 2018-09-20 15:23:51 +03:00
Alicia Cozine
34b8cbd365 Explain what happens when gpgcheck is not set in yum
PR #45796
2018-09-20 15:14:55 +03:00
Yanis LISIMA
45c7facd64 ec2_vpc_igw: migrate to boto3 (#45346)
* ec2_vpc_igw: draft migrate to boto3

* ec2_vpc_igw: migrate to boto3

* ec2_vpc_igw: fix error and implement code review

* ec2_vpc_igw: always catch BotoCoreError with ClientError, remove unused fail method

* ec2_vpc_igw: fix pep error
2018-09-20 19:56:19 +10:00
Jordan Borean
5c73d4f4bd
async: use async_dir for the async results file directory (#45461)
* win async: use async_dir for the async results file directory

* tried to unify POSIX and PowerShell async implementations of async_dir

* fix sanity issue
2018-09-20 19:37:54 +10:00
Zim Kalinowski
60979a96a9
Fixing azure_rm_containerregistry_facts (#45897)
* fixing cr facts

* final fix?

* fixed

* syntax

* sanity
2018-09-20 16:58:07 +08:00
Dag Wieers
51c5e60e49 Add missing ConnectionError imports (#45879)
Small fix
2018-09-20 12:01:01 +10:00
Dag Wieers
197ddd3c45
Fix incorrect type in arg_spec 2018-09-20 02:13:29 +02:00
Zim Kalinowski
83645963fb Fixing assigning ssl certificate to http listener in app gateway (#45830)
* fixed ssl certificate reference

* modified test
2018-09-19 17:00:27 -07:00
Zim Kalinowski
16fa49a894 adding os disk name (#45126)
* adding os disk name

* fixed test
2018-09-19 16:51:37 -07:00
Marc Sensenich
2b4e40c109 Add Check Mode to consul_kv (#28934) 2018-09-19 18:21:03 -04:00
ansibot
534de2df27
Fixing but on version check when the "Apache/2.4.x (Distro)" regex is not met (#27457) 2018-09-19 18:10:29 -04:00
Joseph Benden
36ab77d454 New module: Xfconf-based management of the Xfce 4 DE (#28112) 2018-09-19 18:10:22 -04:00
David Resnick
02bfb9047c datadog_monitor: fix template vars in 'name' and 'escalation_message' (#38483) 2018-09-19 17:34:53 -04:00
Adam Miller
5fdf0290d0 handle yum and dnf lockfiles - fixes #44120 (#45359)
* handle yum and dnf lockfiles - fixes #44120

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix logic problem to properly check for dnf lockfile glob

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-09-19 16:14:25 -04:00
Chris Archibald
e3ec9e5345 NetApp Bulk Doc changes (#45856)
* Doc changes

* fix ansibot issue

* Fix spacing
2018-09-19 20:26:28 +01:00
Adrián
f85065dabf Explain disk size in mount and add example (#41681)
* Explain disk size in mount and add example

- Explain mount with 8GB
- Add new example to start container with mount

* Removed trailing whitespace
2018-09-19 20:01:49 +01:00
Tom Paine
61f2791d95 Update postgresql_user.py (#45777)
<!--- Your description here -->
Add expires example.
+label: docsite_pr
2018-09-19 19:46:26 +01:00
Stuart MacKay
f964277628 Added documentation for collectstatic --clear. (#42007)
* Added documentation for collectstatic --clear.

Added a description of the --clear argument used with the Django management
command, collectstatic. (When #1810 added this feature the documentation
was not updated).
2018-09-19 19:23:17 +01:00
Eric Helms
74b94e119e Deprecate foreman and katello modules (#42043)
* Deprecate foreman and katello modules in 2.8, remove in 2.12
2018-09-19 11:41:54 -05:00
Felix Fontein
bc69aeca7f Fixing HTTPError case of fetch_url for Python 3 compatibility. (#45628)
* Fixing HTTPError case of fetch_url for Python 3 compatibility.

* Adding unit test.

* PEP8.

* Changelog.
2018-09-19 10:53:16 -05:00
Daniel Speichert
d34cf93f1a Migrate from MySQLdb to PyMySQL (#40123)
* Migrate from MySQLdb to PyMySQL

* Deduplicate driver loading and failure message

* Explain requirements

* Apply requirements docs change to proxysql too

* Add changelog
2018-09-19 08:44:05 -07:00
ndswartz
205693a3f9 Update short description for NetApp E-Series modules. (#45820)
Update short description according to new standards
2018-09-19 11:23:49 -04:00
Michael Scherer
ec2c131bac Remove unused import and lines, to make linter happy (#45665) 2018-09-19 19:52:52 +05:30
cordones
742d702b96 incorrect sample eos_config usage (#45750)
no such option "config" for diff_against argument.
Further below, there is an example of eos_config using diff_against with a valid option.
+label: docsite_pr
2018-09-19 19:50:33 +05:30
Trishna Guha
1b0c4fde86
fix nxos_facts indefinite hang for text based output (#45845)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-19 19:37:44 +05:30
Dag Wieers
2edf20d1ed Docs: Avoid use of 'default: null' (#45795)
Various modules document the default 'null' value, but it causes None to
be shown in the documentation explicitly.
2018-09-19 09:02:27 -05:00
Jon Dufresne
2097d25506 Correct capitalization of PyPI (#45698)
As spelled on https://pypi.org/.
2018-09-19 08:51:49 -05:00
Michael Scherer
795b711394 Do not reset permissions in checkmode
If using authorized_key on a directory with non standard permissions,
using checkmode will reset the permission silently.
2018-09-19 14:40:33 +02:00
Michael Tipton
1b92e43dcb VMware: vCenter plugin : new module (#44963) 2018-09-19 17:58:11 +05:30
Dag Wieers
5f4173b8bf A few small fixes 2018-09-19 12:52:31 +02:00
João Soares
097902c35a Remove whitespaces 2018-09-19 12:52:31 +02:00
João Soares
01db7239ed Add input validation for the new asn parameter
Fix asn type from str to int
2018-09-19 12:52:31 +02:00
João Soares
165000adcd Update version_added on the asn parameter 2018-09-19 12:52:31 +02:00
João Soares
a60b14c826 Update aci_l3out documentation 2018-09-19 12:52:31 +02:00
João Soares
dd67e89f47 Add eigrp as a possible l3protocol in aci_l3out
Also fixes an error related to the required parameters. The l3out parameter is required but only 'name' was being accepted, and that should only be the alias.
2018-09-19 12:52:31 +02:00
Sviatoslav Sydorenko
a978d7f283 Fix collections.deque import in compat module 2018-09-19 13:14:24 +03:00
Tim Rupp
ccfbed3dbc
Adds bigiq_device_facts module (#45822)
This module can be used to query a variety of facts from a BIG-IQ
2018-09-18 22:30:31 -04:00
Sofiane Medjkoune
af40d8c2a5 Fix mixed output from ansible and lxd when using the lxd connection plugin (#45246)
* Replace fetch and put operations with Popen instead of call to prevent lxd to mess the Ansible output

* Remove extra blank line
2018-09-18 19:36:51 -04:00
Julien PRIGENT
6059246093 EFS - add support for new Provisioned Throughput (#43253)
* efs.py: Add support for EFS provisioned throughput

* efs_facts.py: Add support for EFS provisioned throughput

* efs_facts integration tests updated with provision throughput

* efs_facts: Tests refactoring - add failure and success playbook according to botocore version.

* efs_facts: More tests and new option descriptions adjustment

* efs_facts tests renamed to efs
2018-09-19 09:10:56 +10:00
Tim Rupp
8acbf10ed2
Removes unused f5 imports (#45821) 2018-09-18 18:34:31 -04:00
Tim Rupp
35e0434042
Update f5 module utils from downstream (#45819)
* various refactoring
* lgtm fixes
* bigiq support to different auth providers
2018-09-18 18:20:44 -04:00
René Moser
1ed3bd9168
vultr: fix for unreliable API behavior (#45712) 2018-09-19 00:01:53 +02:00
René Moser
22986648dc
vultr_server: fix diff for user data (#45753) 2018-09-18 23:20:11 +02:00
Sloane Hertel
8d2df9be52 ec2_group - fix VPC precedence for security group targets (#45787)
Update the dictionary with the preferred values last to get the right order of VPC precedence

Fixes #45782
2018-09-18 15:33:19 -04:00
Stijn Martens
049a462058 Update influxdb_database.py (#39984)
InfluxDB >= 1.2.4 is not supported

+label: docsite_pr
2018-09-18 12:54:02 -05:00
Christer Hemgren
4da13eefb2 asa_config add doc l3 interface (#41250)
* asa_config add doc l3 interface

+label: docsite_pr
Issue ansible/community#311

* fix interface idempotent

* newline, names, and debug:var
2018-09-18 13:39:14 -04:00
Christer Hemgren
7b1c61000e update asa_config with bgp doc example (#41376)
* update asa_config with bgp doc example

+label: docsite_pr
Issue ansible/community#311

* fix spelling
2018-09-18 10:53:32 -05:00
Sam Doran
afd8b97fb1
Make sure strings are bytes for Py2/3 compatibility (#45746) 2018-09-18 10:10:47 -04:00
Matt Martz
b6fcbfe813
Support transfering empty files to target host. Fixes #36725 (#45751) 2018-09-18 09:05:20 -05:00
Matt Martz
f8c98600a9
If including a file resulted in AnsibleFileNotFound, clarify error message. Fixes #45661 (#45667) 2018-09-18 09:04:33 -05:00
Sloane Hertel
c004a639b3
[ovirt] remove 2.8 deprecations (#45506) 2018-09-18 08:28:00 -04:00
mrmagooey
1f8c5905b3 VMware: fix return to return a tuple instead of a bool (#45764)
fixes "'bool' object is not iterable" exception when `res` is falsey
2018-09-18 16:53:17 +05:30
Martin Nečas
28a074c835 ovirt add vnic (#44716)
* ovirt add vnic
2018-09-18 10:02:49 +01:00
Dario Zanzico
54c3d1c24e New module: add docker_stack module (clound/docker/docker_stack) (#24588)
* add docker_stack module + tests
2018-09-18 09:54:44 +01:00
Felix Fontein
0961d914d7 Don't parse/interpret options if state is 'absent'. (#45700) 2018-09-17 22:07:52 -04:00
Will Thames
d2569a3f7d Improve iam_group exception handling (#45599)
* Improve iam_group exception handling

Use AnsibleAWSModule for iam_group and handle BotoCoreErrors
as well as ClientErrors. Use fail_json_aws to improve error messages

* Add minimal iam_group test suite

Update some of the read-only IAM permissions (this is not sufficient
to run the test suite but it gets further than it did until it tries
to add a (non-existent) user)

* Clean up after tests
2018-09-17 19:53:44 -04:00
Michael Scherer
5c49641798 Port the aix_inittab to python 3 (#45678)
Since izip no longer exist on python 3, we need to use zip
Fix #45220
2018-09-17 19:01:38 -04:00
Raymond Wanyoike
c41632fad2 Add the key_name/value_name options to the dict2items filter (#45550)
* Add the key_name/value_name options to dict2items - as with items2dict, allow users to configure the key/value name for dict2items, add "version added" and examples
2018-09-17 15:53:52 -05:00
Sandra McCann
7092dd7fbf Add 'Wait for' example to asa_command module (#45190)
* Added example to register result of a ping test, including a wait_for command.
* added names to tasks
* updated examples to remove deprecated commands etc
* removed group_var
2018-09-17 15:12:46 -05:00
Denis GERMAIN
68e264e878 Wrong parameter in scaleway sshkey module example (#45737)
* Update scaleway_sshkey.py
fix: typo "present" in example
2018-09-17 15:04:09 -05:00
zharalim
8526f63255 Enhance the note about fileglob being local (#45398)
Made the note clearer and instructed to use find module for remote operations.
Relating to #34497
2018-09-17 16:00:41 -04:00
C. Friedrichs
05840ffe16 updated documentation in vmware_guest.py (#45481)
Added note regarding online disk resizing and changed wording of a few sentences. Also added vSphere 6.7 as "tested on" as it works very well.
2018-09-17 15:59:21 -04:00
Rémy Jacquin
63444136ba Add example for multiple package selection with dnf (#45610)
Thanks for enhancing the Ansible documentation!
2018-09-17 15:54:48 -04:00
Michael Scherer
bef1e5621b Add a alias from organisation to organization (#45688)
Since 'organization' is the spelling used accross all others modules,
I think it would be better to at least have this one as a alias.

Organisation is the UK/Australia/NZ spelling, while organization is the
US one.
2018-09-17 15:50:46 -04:00
Nathaniel Case
52c20bbd3f
Update from napalm PR (#45743) 2018-09-17 15:39:07 -04:00
Aidan Feldman
fa18d45eb3 Link to the Galaxy platforms list from the meta file template (#34046)
* Link to the Galaxy platforms list from the meta file template
Fixes https://github.com/ansible/galaxy/issues/52.
* make ansible/ansible text match mazer text on platforms
2018-09-17 13:39:54 -05:00
Sloane Hertel
21f4b5911e [aws] fix version_added for elb_classic_lbmodule (#45559) 2018-09-17 14:32:51 -04:00
Sloane Hertel
b42c7f4512 [iam_role] A hyphen with nothing following becomes [None] rather than []. Fix example syntax. (#45742) 2018-09-17 14:32:15 -04:00
Sloane Hertel
d7ca3f2bd3 ec2_group: fix regression for targets that are a list containing strings and lists (#45594)
* Fix targets that may be a list containing strings and lists which worked prior to 2.6.

* Add ec2_group integration tests for lists of nested targets

* changelog

* Add diff mode support for lists of targets containing strings and lists.
2018-09-17 14:31:41 -04:00
Lingxian Kong
cf1e0bde99 os_loadbalancer: support to create populated load balancer (#44619)
The user can use os_loadbalancer module to configure a fully functional
load balancer by specifying the sub-resources definition in the module,
rather than combining os_listener, os_pool and os_member modules.
2018-09-17 14:10:03 -04:00
Dag Wieers
a7a99c5fd4 reboot: Fix typo and support bare Linux systems (#45607)
* reboot: Fix typo and support bare Linux systems

This fixes a problem for bare Linux systems that do not support 'who -b' or 'uptime -s'.

* Accumulate stdout and stderr information
2018-09-17 14:04:03 -04:00
Nathaniel Case
21ff9c6a4a
Add initial napalm connection plugin (#45224)
* Add initial napalm connection plugin

* Fix review comments
2018-09-17 12:53:57 -04:00
Nathaniel Case
917fcb9c55
These won't get upgraded to bool if ansible doesn't know they are (#45736) 2018-09-17 11:34:57 -04:00
David Passante
05328ebf21 Cloudstack: fix support for some VPC service capabilities (#45727)
* Fix support for VPC capabilities such as redundant routers or region level VPC

* Add integration test cases for "region level VPC" and "distributed router" capabilities
2018-09-17 16:08:16 +02:00
Nathaniel Case
780dc9c561
There are other instances of transform being used... update them as well (#45663) 2018-09-17 08:42:20 -04:00
Rémy Léone
66f03827d6 Add a netbox dynamic inventory plugin (#45347) 2018-09-16 15:13:56 +01:00
René Moser
00d04ef757
twilio: fix multi to_number support (#44878)
* twilio: fix multi to_number support

* use json helper
2018-09-16 08:38:25 +02:00
Matt Martz
07b2698c03 Add new expand_shell argument for run_command, to disable expanding shellisms (#45620)
* Add new expand_shell argument for run_command, to disable expanding shellisms. Fixes #45418

* s/expand_shell/expand_user_and_vars/g
2018-09-14 16:07:11 -04:00
Ken Dreyer
e46ce1619f add docstring for ansible.inventory.helpers.get_group_vars
Document the expected parameter type and return type of
get_group_vars().
2018-09-14 16:02:45 -04:00
julianladisch
5adcaf4538 Suggest full fingerprint for apt_key. (#44697)
* Suggest full fingerprint for apt_key.
Background: https://gwolf.org/node/4070 (Gunnar Wolf: Stop it with those short PGP key IDs!)
I've put the full fingerprint into the examples.
* avoids the phrase 'best practice'
2018-09-14 14:50:46 -05:00
Anil Kumar Muraleedharan
4ec317ceca Lenovo doc update (#45483)
* Merge issue

* Update cnos_rollback.py

* Updating license for the refactored method

* Update cnos_rollback.py

* Removing the BSD License as suggested by Legal

* To add Documentation for ENOS as well as CNOS

* Merge issue

* Revert "To add Documentation for ENOS as well as CNOS"

This reverts commit 80e6e39054be0c3a8f95d16dc39ca9d93baf8c4b.

* Adding Docs for ENOS and CNOS

* Update cnos.py

* Update cnos_rollback.py

* Update cnos.py

* Update platform_cnos.rst

* Update platform_enos.rst

* Removed version 2.7

* Removing 2.7
2018-09-14 15:23:57 -04:00
Jon Cormier
7aaa5da41d [aws_ssm_parameter_store] use describe_parameters paginator (#45632)
Fix the service reaching an internal limit while processing the results and returning unexpected data
2018-09-14 15:17:15 -04:00
lwm
1d754b43de Linode: clarify how to create/delete linode machines with linode_id. (#45659)
* Attempt to explain `linode_id` a bit better.

Don't include in any example that creates a Linode.

Based on comments in

> https://github.com/ansible/ansible/issues/45403#issuecomment-419752856

* Add simple creation example. Show how to pass `linode_id`.
2018-09-14 15:10:32 -04:00
Maugli
235b11f681 Return correct version on installed VyOS (#39115)
* Return correct version on installed VyOS

Previously existing regexp will shows only "VyOS" without numeric output of router version.
For example: from  "Version:      VyOS 1.1.6" only VyOS will be written in ansible_net_version variable
For more informative output numeric value should be returned as well

* Fixed unittests
2018-09-14 22:51:30 +05:30
Matt Martz
829f48e3f5
Flip default for AGNOSTIC_BECOME_PROMPT (#45563)
* Flip default for AGNOSTIC_BECOME_PROMPT

* simplify AGNOSTIC_BECOME_PROMPT porting guide entry

* clarify AGNOSTIC_BECOME_PROMPT changelog entry

* fixes version typo

* uses alternate wording (rather than escaping *)
2018-09-14 11:16:13 -05:00
Martin Krizek
d383d87b22 include_vars: fix checking for a string in ignore_files 2018-09-14 11:18:00 -04:00
Michael Scherer
a1e2f1bf73 [voss_facts] remove uneeded global declaration of variable warnings (#45653)
Since the variable is used only once, no need to declare it global.
Remove a warning from linter (lgtm.com)
2018-09-14 10:39:41 -04:00