Seth Vidal
4d29cd6ee3
make virt module command= work again - better error handling should be in its
...
future
2012-08-02 17:46:21 -04:00
Seth Vidal
fd492bebc6
- add a check for repoquery so we can abort politely
...
- make the results output a bit more readable
- fix up where repoquery is looked for so it is easier to change
2012-08-02 17:02:37 -04:00
Michael DeHaan
98e4034de2
Merge pull request #772 from gottwald/devel-serviceFix
...
Fixed a Bug in the service module "state changed" recognition
2012-08-02 08:49:30 -07:00
Ingo Gottwald
25b52109b4
Fixed a Bug in the service module state changed recognition
2012-08-02 17:18:25 +02:00
Stephen Fromm
85c838c835
Add Blade to FORM_FACTOR list and document SMBIOS spec URL
2012-08-02 07:24:05 -07:00
Stephen Fromm
9a3ad060dc
Catch exception if form factor id is unknown
2012-08-02 07:06:55 -07:00
Michael DeHaan
fa79d57d13
changelog / remove a failed=False
2012-08-01 22:35:07 -04:00
Michael DeHaan
b7c3fd1246
failed should not be in the result returns for a module upon success
2012-08-01 22:30:22 -04:00
Michael DeHaan
91d31d8164
Merge pull request #761 from skvidal/devel
...
redo of yum module - uses more system calls but should handle
2012-08-02 05:13:23 -07:00
Seth Vidal
c91befda5c
redo of yum module - uses more system calls but should handle
...
random plugin vomit better.
also should handle multiple withitems in a single execution, now.
2012-08-02 01:47:48 -04:00
Michael DeHaan
e820c282be
Merge pull request #760 from sfromm/fixes
...
A couple fixes for the file module
2012-08-02 04:54:16 -07:00
Will Thames
0e26ef9bdd
Revert acceptance of directory as dest for copy
...
Although library/copy can be corrected to understand that dest is
a directory, I can't see how to let _execute_copy know this and let the
file module know.
As a better solution than before #733 , the copy module now explicitly (rather
than silently) fails when dest is a directory.
2012-08-02 16:54:03 +10:00
Stephen Fromm
d0892c19ad
Add setype to file's argument_spec and remove secontext
...
secontext is used internally and should not be in argument_spec
2012-08-01 22:24:09 -07:00
Stephen Fromm
52afacf475
Fix module_fail_json call when symlink src does not exist
2012-08-01 22:23:02 -07:00
Michael DeHaan
25acfa8170
Join with_items for the apt module, yum pending, and various fixes to the yum module to support aliases
2012-08-01 20:33:13 -04:00
Michael DeHaan
ed14312ad6
reinstate invalid argument checks where possible, daisy chainee/chained modules turn it off
2012-08-01 19:42:31 -04:00
Michael DeHaan
77029a4227
Merge pull request #752 from go2sh/apt-patch
...
Enable apt module to handle multiply packages (comma separated)
2012-08-01 16:27:29 -07:00
Stephen Fromm
abe8d8d4d6
Return extra information from service module
...
If _do_enable() is run and returns rc == 0, set changed=True
Add enabled and state to result if they are supplied when the module is
run.
2012-08-01 14:58:32 -07:00
Stephen Fromm
42ad1c879f
Fix service module for issue 755 and another bug
...
Allow use of service module with just enable parameter, per issue #755 .
Also fixed two other issues:
- fixed parameter to be 'enabled' per docs, not 'enable'.
- fixed if block that checks whether to run _do_enable() to check
whether the parameter is set, not the value of the enable value which
may be None or False. If enabled=no, the service would never be
disabled.
2012-08-01 14:44:26 -07:00
Christoph Seitz
6baaea90ae
Tweaked error massages.
2012-08-01 18:45:32 +02:00
Christoph Seitz
b973910283
Some optimizations to previous code.
2012-08-01 18:43:39 +02:00
Christoph Seitz
418445d3c5
Enable apt module to handle multiply packages (comma separated)
2012-08-01 18:09:30 +02:00
Jan-Piet Mens
31c0e523c2
Fix exeptions, replace 'as' by ',' as reported on IRC for Python 2.4.3 on Centos5
2012-08-01 15:30:16 +02:00
Michael DeHaan
0a3ebdb6d5
Module consistency and make daisy chaining work with invalid arguments detection.
2012-08-01 00:22:02 -04:00
Michael DeHaan
8700de964c
Teach the common module code to warn users about typo'd arguments and also set everything to None automatically such
...
that code doesn't have to do a lot of params.get('foo', None) everywhere.
2012-07-31 21:23:34 -04:00
Lorin Hochstein
9bcc18d17b
Apt module: add update-cache as alias of update_cache
...
This will ensure users of previous versions of this module don't
have their playbooks break.
2012-07-31 09:56:36 -04:00
Michael DeHaan
d79900b434
Merge pull request #732 from willthames/fix_git_fail_json
...
Fixes for git module when it fails.
2012-07-31 05:04:47 -07:00
Michael DeHaan
89ef236e9c
Merge pull request #733 from willthames/copy_to_directory
...
Allow copy dest argument to be a directory
2012-07-31 05:03:50 -07:00
Michael DeHaan
a8d13fe40d
Merge pull request #735 from nix85/fix_ohai_mod
...
Changed funtion name to get_ohai_data
2012-07-31 05:02:44 -07:00
Petros Moisiadis
24c1d32120
added extra arguments for database creation
...
mysql_db: added 'encoding' and 'collation' args
postgresql_db: added 'owner', 'template' and 'encoding' args
2012-07-31 12:56:29 +03:00
Nikhil Singh
526a0b1f60
Changed funtion name to get_ohai_data
2012-07-31 13:07:53 +05:30
u348095
3cb51acd78
Allow copy dest argument to be a directory
...
Could have used shutil.copy rather than shutil.copyfile, but this
implementation preserves the md5 comparison to avoid unnecessary copies
2012-07-31 14:47:01 +10:00
u348095
e863ba0cec
Fixes for git module when it fails.
...
* module.fail_json *must* have msg argument
Using http://github.com/ rather than git://github.com/ as it gets through more
firewalls
2012-07-31 12:59:22 +10:00
Michael DeHaan
ce5f3dd148
Port the file module over to the new common code infrastructure + cleanup some redundant imports since the module code already imports those things.
2012-07-30 21:50:32 -04:00
Michael DeHaan
d0f6410326
Porting the virt module to new module core.
2012-07-30 21:16:29 -04:00
Michael DeHaan
6b72804cb4
remove unneeded imports
2012-07-28 17:15:07 -04:00
Michael DeHaan
d0a5dec686
Port setup module to use the common module base
2012-07-28 17:14:23 -04:00
Michael DeHaan
d79ba6f2aa
Port the ohai module over, while this is actually *longer* now, not transferring the args file makes this much
...
faster.
2012-07-28 17:07:55 -04:00
Michael DeHaan
5fd2018117
Convert authorized_key modules to use new common code + misc style things
2012-07-28 17:03:10 -04:00
Michael DeHaan
63459110c4
Merge pull request #730 from marktheunissen/mysql_change_params
...
Changing the parameter names to be consistent, and adding root user
2012-07-30 15:50:40 -07:00
Mark Theunissen
9a1265b856
Changing the parameter names to be consistent, and adding root user default with empty password, as per mysql standard
2012-07-30 17:15:24 -05:00
Michael DeHaan
47cead3603
Merge pull request #727 from sfromm/git
...
Git module ported to use module magic
2012-07-30 13:40:36 -07:00
Michael DeHaan
d0f0315c9d
Merge pull request #723 from skvidal/devel
...
fix trace-creating error in apt module - also make the default setting a...
2012-07-30 10:45:42 -07:00
Seth Vidal
21a35bde00
new patch - adds a 'boolean' function to the module_common class and cleans up
...
the apt module to use it
2012-07-30 13:41:42 -04:00
Seth Vidal
c4c53d545a
fix trace-creating error in apt module - also make the default setting actualy work
2012-07-30 13:07:19 -04:00
Petros Moisiadis
4ad0ff61e5
added a 'chdir' argument to the command module
...
the 'chdir' argument changes the current working directory to the
fullpath supplied as its value, before the execution of the command.
2012-07-30 18:39:45 +03:00
Stephen Fromm
87b3e1ecdc
Update git module to use module magic and other changes
...
Convert git module to module magic.
Drop cruft no longer needed.
Standardize indent to 4 spaces in methods switchLocalBranch, reset,
clone, and get_version.
Update is_local_branch to also handle '* branch' format.
Add is_current branch method()
Update pull() method to use is_current_branch()
2012-07-29 22:39:19 -07:00
Lorin Hochstein
dcd214a631
Use standard argument names in PostgreSQL modules
...
passwd -> password
loginpass -> login_password
loginuser -> login_user
loginhost -> login_host
Add an example playbook that shows how to use the modules.
2012-07-29 12:52:14 -04:00
Lorin Hochstein
a9c2e597ac
Fix typo in apt error message: update-cache -> update_cache
...
The apt parameter changed from update-cache to update_cache, but
the error message still mentioned update-cache
2012-07-29 12:29:00 -04:00
Michael DeHaan
ff82f0a168
Further service module tweaks
2012-07-28 16:48:04 -04:00
Michael DeHaan
e9c4eb36d1
Service tweaks WIP
2012-07-28 16:39:18 -04:00
Nikhil Singh
aca860df9c
Standardizing the module
2012-07-28 16:39:18 -04:00
Mark Theunissen
7a67145ef4
Fixes for apt module
2012-07-30 17:20:43 -05:00
Michael DeHaan
487c826700
Tweak alias consistency a bit. 'package' has never been documented, but since it works, make it work in both places.
...
'name' is the preferred form. Similarly, take 'name' for the 'guest' argument to the 'virt' module.
2012-07-28 09:22:13 -04:00
Michael DeHaan
4ecdd17caf
Merge pull request #702 from lorin/postgresql-module
...
Add postgresql_db and postgresql_user module.
2012-07-27 15:32:10 -07:00
Michael DeHaan
d55012e570
Merge pull request #704 from lorin/gitfix
...
git module: Don't pass rc as separate arg to fail_json
2012-07-27 05:49:22 -07:00
Lorin Hochstein
9253d89280
git module: Don't pass rc as separate arg to fail_json
2012-07-27 08:40:47 -04:00
Michael DeHaan
0c61d049a2
Merge pull request #690 from marktheunissen/mysql_default_password
...
Change modules to use credentials in my.cnf if they are available
2012-07-26 17:16:05 -07:00
Michael DeHaan
ebfd7ec7e3
Merge pull request #695 from nix85/fix_apt_mod
...
Standardizing the apt module
2012-07-26 17:15:28 -07:00
Lorin Hochstein
def1fa23f8
Add postgresql_db and postgresql_user module.
...
These modules are based on the mysql_db and mysql_user modules.
Currently, the postgresql_user module can only grant all permissions
on a database, fine-grained access has not been implemented yet.
2012-07-26 17:05:04 -04:00
Mark Theunissen
7395becf3a
Check file exists instead of relying on the exception. Leave the exception catch in, in case the file is deleted or some other issue crops up
2012-07-26 11:30:22 -05:00
Mark Theunissen
888ac86d70
Woops, missed the rest of them
2012-07-26 11:13:10 -05:00
Mark Theunissen
ac23c69bcc
Making the passwd parameter consistent
2012-07-26 11:10:22 -05:00
Mark Theunissen
6afe3fd497
Changing to read from a file pointer instead so that an exception is thrown if the file doesn't exist
2012-07-26 08:58:21 -05:00
Nikhil Singh
daf44331c4
Code review changes
...
1. Passing the module to the various functions so that they can use module.fail_json and module.exit_json methods inside.
2. Because of point 1, install and remove methods do not return anything. Instead, they use the module functions itself.
3. Move the import statement (for apt and apt_pkg) inside main function so on import error, we can use module.fail_json to print the error.
2012-07-26 17:29:15 +05:30
Nikhil Singh
dd9e09dee6
Adding dict() for json.dumps
2012-07-26 16:24:10 +05:30
Nikhil Singh
4c8d949642
Standardizing the apt module
2012-07-26 16:21:49 +05:30
Stephen Fromm
1727bd3b7a
Update git module to handle branches better
...
This drops the branch option. The version option is overloaded
to mean either a sha1, branch, or tag. This also adds the option
'remote' which defaults to 'origin'.
clone() was simplified by removing the checkout operation. That
happens later when switch_version() is called.
Added the methods get_branches(), is_remote_branch(), and
is_local_branch(). get_branches() returns an array listing all
of the branches for the git repository. is_remote_branch() checks
whether the arguments supplied correspond to a remote branch.
Similarly, is_local_branch() checks for a local branch.
The pull() method now checks to see if it is on the desired branch.
If not, it checks out the requested branch and then does a pull.
This should keep issue #604 still fixed.
switch_version(), formerly switchver(), looks to see if it is
checking out a branch. If a branch, it checks it out with the --track
option. This type of checkout was in pull() before.
Updated pull, clone, and switch_version to return (rc, out, err).
2012-07-26 00:22:30 -07:00
Michael DeHaan
2030f82bf2
Further standardize the yum module
2012-07-25 20:14:15 -04:00
Michael DeHaan
1584eda3f8
Merge pull request #684 from nix85/fix_yum_mod
...
Standardizing the yum module
2012-07-25 17:33:55 -07:00
Mark Theunissen
12979cf834
Change modules to use credentials in my.cnf if they are available
2012-07-25 16:31:12 -05:00
Stephen Fromm
40eaf282ea
More cleanup in assemble module for module magic (tm)
2012-07-25 09:24:10 -07:00
Nikhil Singh
b47bed9601
Standardizing the yum module
2012-07-25 19:45:41 +05:30
Michael DeHaan
772e241d1f
shorten up the assemble module
2012-07-24 19:44:53 -04:00
Michael DeHaan
f787cda7be
Merge pull request #675 from jpmens/assemble1
...
convert sfromm's assemble to module-magic
2012-07-24 16:41:25 -07:00
Michael DeHaan
f4a4649086
Port async_status to use the new common code.
2012-07-24 19:03:18 -04:00
Michael DeHaan
45354c6be5
Port command module over to new common code. Notice that this has to subclass AnsibleModule -- this should be the only
...
one that has to do that.
2012-07-24 18:52:52 -04:00
Michael DeHaan
2d1c297fb8
Merge pull request #674 from nix85/fix_facter_mod
...
Standardizing the module
2012-07-24 11:54:50 -07:00
Jan-Piet Mens
f6fe9124b8
convert assemble to module-magic
2012-07-24 18:35:06 +02:00
Nikhil Singh
8bbcef6f13
Standardizing the module
2012-07-24 21:08:56 +05:30
Mark Theunissen
97cc259d8c
Undefined variable error
2012-07-24 09:26:45 -05:00
Nikhil Singh
483f7fd625
Standardizing the mount module
2012-07-24 17:00:08 +05:30
Michael DeHaan
2cda36f7dc
Merge pull request #664 from jpmens/a1
...
Fix file module to support = in args; remove superflous call in get_url
2012-07-24 03:39:30 -07:00
Christoph Seitz
ab8a36686e
Fixes locale problem with ifconfig in setup module
2012-07-24 11:10:11 +02:00
Jan-Piet Mens
628b289ab3
Fix file module to support = in args; remove superflous call in get_url
2012-07-24 06:40:34 +02:00
Michael DeHaan
ec12cc4154
Save the transfer of the module file for new style modules, because we can inject the arguments into the modules.
...
Module consumers using the API don't have to know how this works. base64 stuff is only there
because escaping a docstring inside a docstring was a bit of a challenge :)
2012-07-23 19:18:45 -04:00
Stephen Fromm
f068bedfa1
Update user module to use new shared module code
2012-07-23 11:29:59 -07:00
Mark Theunissen
12e23a1a6c
Upgrading MySQL user module to new format
2012-07-22 12:11:39 -05:00
Michael DeHaan
0b891fc8fb
Tweaking daisychain internals to allow get_url to modify the path destination when downloading to a directory.
...
Minor module refactoring.
2012-07-22 11:08:16 -04:00
Michael DeHaan
46650cfcec
Merge branch 'get_url3' of https://github.com/jpmens/ansible into devel
2012-07-22 10:08:27 -04:00
Stephen Fromm
1a9c54b1e1
Update group module to use new shared module code
2012-07-21 22:30:13 -07:00
Mark Theunissen
efb60776f4
Upgrading to new shared module code
2012-07-21 18:02:34 -05:00
Michael DeHaan
9f149c9f1a
imports not needed
2012-07-21 17:25:47 -04:00
Michael DeHaan
d0f4358730
Port the copy module over to the new "common module" logic.
2012-07-21 17:07:42 -04:00
Jan-Piet Mens
b8d7b5041b
new module: get_url
...
get module (with new module-magic-code!)
Usage: ansible -m get -a "url=http://xxxxxxx dest=fileordirctory"
all cleanups as per @mpdehaan's suggestions
add daisychain
added example playbook (get_url.yml) with URLencode example
2012-07-21 13:34:42 +02:00
Stephen Fromm
2a0dfba838
Skip get_ipv6_facts if socket.has_ipv6 is false
2012-07-20 17:19:26 -07:00
Stephen Fromm
fd059a3df2
Fix for issue 604
...
Do not switch to master branch in pull()
Add --track to git checkout, when checking out a remote branch to track.
2012-07-20 10:43:26 -07:00
Michael DeHaan
70ef8e9ebb
Merge pull request #637 from goozbach/git-mkdir
...
git mkdir causes problems with older git (can't c/o to existing directory)
2012-07-20 06:54:20 -07:00
Derek Carter
f0f8eb3445
git mkdir causes problems with older git (can't checkout to existing directory)
2012-07-20 09:48:18 -04:00
Michael DeHaan
b114a6075f
Merge pull request #631 from sfromm/facts
...
Update setup module for facts derived from classes - take 2
2012-07-20 03:58:42 -07:00