* Refactor postgresql_idx to simplify code
Have refactored the postgresql_idx module to:
* Use the class schema in the drop function rather than a passed in one
* Remove the if/else and just return the bool in the drop and create
functions
* Refactor postgresql_ext module
Have refactored the postgresql_ext module to:
* Remove an unused exception
* Simplify logic in the create and update functions
* Use list comprehension to simplify getting the available version
* Refactor postgresql_user_obj_stat_info module
Have refactored the postgresql_user_obj_stat_info module to:
* Simplify the logic in some of the functions
* Reduce duplicate code
* Add changelog fragment
Have added a trust_input option to the postgresql_user_obj_stat_info
module. This only checks the session_role since all other options are
passed as parameters.
Using a list ensures that all subprocess arguments are correctly
escaped. By building strings and then calling .split(), potential
arguments with a space will be incorrectly split over two arguments.
When a string is needed for presentation, join to the list to build the
string.
* flatpak: Change use of Popen to module.run_command()
* Update changelogs/fragments/274-flatpak-run-command.yaml
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Updated listen_ports_facts module documentation to reflect
- Linux only support
- Required netstat command
Fixes: ansible/ansible#68077
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Add trust_input option to postgresql_slot module
Have added a trust_input option to the postgresql_slot module. This
only checks the session_role since all other options are passed as
parameters.
* Add Changelog fragment
* Update docs following PR review
* Add trust_input option to postgresql_sequence
Have added the trust_input option to the postgresql_sequence module.
* Add changelog fragment
Have added a changelog fragment for these changes.
* adds missing 'log alert' type to supported types
* added changelog fragment
* Update changelogs/fragments/277-datadog_monitor-adds-missing-log-alert-type.yml
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* Add optional input check to postgresql_ext
Have added a new trust_input check to the postgresql_ext module that
allows for checking the input that is passed to the module.
* Add changelog fragment
* Update tests/integration/targets/postgresql_ext/tasks/postgresql_ext_initial.yml
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* Add option to choose a specific make executable
* Add changelog fragment
* Fix pep8 issues
* Add ending dot to make option description
Co-Authored-By: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
* mysql_db: prevent broken pipe errors by using an intermediate shell process
* use module.run_command()
* mysql_db: add use_shell parameter
* add changelog fragment
* Slack: Add bot/user token support, correct thread_ts support
Add support for user/bot/application tokens (and Slack WebAPI).
Fix input type for thread_id, which needs to be string.
Return thread_ts/thread_id when user/bot tokens are used, so they can be reused later
* Slack: Add changelog fragment, fix YAML syntax
Co-authored-by: Middleton, Michal <Michal.Middleton@concur.com>
Currently the redfish_config module will convert boolean bios_attribute_value
settings to strings (type str). This will cause BMCs expecting booleans to
error out.
This PR will change the default type of bios_attribute_value to 'raw' in order
to support strings and booleans.
Fixes#68251
* [Add] Add parameter for __collect method
Add parameter for `__collect` method
By default the class `MySQL_Info` get all MySQL instance information,
add parameter for `__collect` to get only what wants to know(information)
Feature Pull Request
lib/ansible/modules/database/mysql/mysql_info.py
* typo
* [add] add changelog
- bugfixes:
- mysql_info - add parameter for __collect to get only what are wanted (https://github.com/ansible-collections/community.general/pull/136).
* puppet: fix check-mode
Commit 69ead0ba78 in the ansible/ansible
repository introduced another if-statement in the middle of a if/elif pair,
which causes the elif to execute together with the original if
which created '--noop --no-noop' commands
* puppet: fix manifest whitespace
There was a space missing before the manifest path causing
issues like: "invalid option: --noop/test.pp"
* puppet: Add a changelog entry for 8d7c830 and 6ed7f06
* Added search function to jira module
* Added jira Operations in update function
* Fixed Whitepsaces
* Fixed Author header
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: John R Barker <john@johnrbarker.com>
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: John R Barker <john@johnrbarker.com>
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: John R Barker <john@johnrbarker.com>
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: John R Barker <john@johnrbarker.com>
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: John R Barker <john@johnrbarker.com>
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: John R Barker <john@johnrbarker.com>
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: Andrew Klychkov <aaklychkov@mail.ru>
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: Andrew Klychkov <aaklychkov@mail.ru>
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: Andrew Klychkov <aaklychkov@mail.ru>
* Added changelog framgents and update with review comments
* Resolved https://github.com/ansible-collections/community.general/issues/109
* Added example for Transsition with comments
* Fixed Whitespaces
* Fixed whitepsaces again
* Update changelogs/fragments/22-jira.yaml
Co-Authored-By: Andrew Klychkov <aaklychkov@mail.ru>
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: Andrew Klychkov <aaklychkov@mail.ru>
* Added changes from Andersson007
* Update changelogs/fragments/22-jira.yaml
Co-Authored-By: Andrew Klychkov <aaklychkov@mail.ru>
* Updated Changelog framgnets as per reviews
* Update changelogs/fragments/22-jira.yaml
Co-Authored-By: Andrew Klychkov <aaklychkov@mail.ru>
* Added max results per review request, which supports limiting number of resuted searches from the Jira API.
* Removed whitespace
* Removed version_added per request
* Update plugins/modules/web_infrastructure/jira.py
Co-Authored-By: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Per Abildgaard Toft <pto@netic.dk>
Co-authored-by: John R Barker <john@johnrbarker.com>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* Remove the params module option from ldap_attr and ldap_entry
Module options that circumvent Ansible's option handling were disallowed
in:
https://meetbot.fedoraproject.org/ansible-meeting/2017-09-28/ansible_dev_meeting.2017-09-28-15.00.log.html
Additionally, this particular usage can be insecure if bind_pw is set
this way as the password could end up in a logfile or displayed on
stdout.
Fixes CVE-2020-1746
* Remove checking the version of Ansible
Fix fail_json
* Apply suggestions from code review
Co-Authored-By: Felix Fontein <felix@fontein.de>
Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
homebrew now returns details about changed and unchanged packages
after performing the operations.
Fixes: ansible/ansible#59376
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Update docker.py
#67832 fixes the need to run powershell modules on windows containers via docker connection. However, while running win_copy on windows containers, destination path is prefixed, which doesn't work in the case of windows. The changes in this PR take care of bypassing that while running the ansible role on windows containers.
* Update plugins/connection/docker.py
Co-Authored-By: Felix Fontein <felix@fontein.de>
* Create 80-update_docker_connection_plugin.yml
Add changelog fragment
* Update changelogs/fragments/80-update_docker_connection_plugin.yml
Co-Authored-By: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
