1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

26829 commits

Author SHA1 Message Date
Matt Martz
ca83a5c110
Version in deprecate calls should be a string (#55395)
* Version in deprecate calls should be a string. Fixes #55312. Fixes #55313. Fixes #55314. Fixes #55315. Fixes #55316. Fixes #55317.

* Add changelog fragment
2019-04-16 14:40:20 -05:00
Matt Martz
07443a2bcd
Address 2.9 uri deprecations (#55330)
* Address 2.9 uri deprecations. Fixes #55310

* Add changelog fragment
2019-04-16 14:17:03 -05:00
Matt Martz
9f83139dcb
Don't register tests as filters (#55332)
* Don't register tests as filters. Fixes #55319

* Remove tests for deprecated functionality

* Remove no-tests-as-filters sanity tests

* Remove docs too

* Revert "Remove docs too"

This reverts commit 7daf457a742e67ec6e91964852c7f804507b46b8.

* Make no-tests-as-filters doc an orphan
2019-04-16 14:10:14 -05:00
williammcbroom
272dceef42 ec2_launch_template - fix spelling mistake (#55383) 2019-04-16 11:45:12 -04:00
Martin Krizek
4ec8599c38 apt: remove deprecated installed/removed aliases (#55338)
* apt: remove deprecated installed/removed aliases

Fixes #55311
2019-04-16 11:42:53 -04:00
Dag Wieers
9495ddbc21
ACI: Cleanup deprecated boolean behaviour (#55207)
* ACI: Cleanup deprecated boolean behaviour

* Remove from sanity ignore list
2019-04-16 14:13:24 +02:00
Anatoly Pugachev
b28c73af62 Fixes solaris (sunos) uptime in ansible facts module (#54626)
* correct uptime on solaris by using system boot_time instead of snaptime
* add unit test
2019-04-15 18:01:24 -04:00
Jordan Borean
04cae4134f
Bump deps for ntlm-auth and PSScriptAnalyzer (#55269) 2019-04-16 06:43:41 +10:00
JP Mens
46420dd21a Clarify fact_path configurable in ansible.cfg (#54992)
Docs: Clarify that `fact_path` can be configured in `ansible.cfg`; uppercase two acronyms.
2019-04-15 15:21:00 -05:00
Hideki Saito
83f20e0ea0 Fixed wrong variable specification format in examples (#55252)
Signed-off-by: Hideki Saito <saito@fgrep.org>
2019-04-15 15:18:11 -05:00
Jiri Tyr
720f62bf85 Improving documentation of the aws_ec2 inventory plugin (#55255) 2019-04-15 15:16:21 -05:00
Kevin Breit
fb3cc7f687 meraki_vlan - Remove unnecessary API calls when net_id is specified (#54939)
* Remove unnecessary API calls when net_id is specified

* Remove temp_get_nets commented out code
2019-04-15 19:53:19 +01:00
Mauricio Tavares
f8834c5339 Template: Example of SELinux context type (#54861)
* Update template.py with an example using selinux with a suggestion of how to get the proper file context (cheating!)
2019-04-15 12:06:48 -05:00
Chris Collins
e90df4b566 DOCS: Update "connections" data type (#55290)
The k8s plugin expects the "connections" field to be a list - current docs examples trigger:
 [WARNING]:  * Failed to parse {...}/inventory.yml with k8s plugin: Expecting connections to be a list.

Updated examples for `host` and  `namespaces` to reflect this.
2019-04-15 10:18:09 -05:00
Jose Delarosa
f88b2cbe59 Use different headers for each HTTP method (#55193) 2019-04-15 11:04:18 +01:00
Andrey Klychkov
4190985995 postgresql_slot - sslrootcert fix (#55277) 2019-04-15 10:56:25 +01:00
Felix Fontein
cb5c57bcd5 openssl_csr: fix idempotency problems (#55142)
* Add test for generating a CSR with everything, and testing idempotency.

* Proper SAN normalization before comparison.

* Fix check in cryptography backend.

* Convert SANs to text. Update comments.

* Add changelog.
2019-04-15 09:15:08 +02:00
MyronFanQiu
91e808eed2 azure_rm_subnet: fix CI error for deleting the azure_tags (#55276) 2019-04-15 15:14:18 +08:00
James E. King III
32345641e7 azure_rm_subnet: remove documentation that says it supports tags (#55233) 2019-04-15 11:02:53 +08:00
James Cassell
7191d45885 VMware: vmware_tools tls warning fixes (#55187)
* vmware_tools: remove silence_tls_warnings option

* attempt import of bundled urllib3
2019-04-14 19:58:45 +05:30
Jonas Kongslund
36ab96e4a9 Fix minor documentation error: base64 -> b64encode (#55257)
* Fix minor documentation error: base64 -> b64encode

* Fix minor documentation error: base64 -> b64encode
2019-04-14 05:30:27 -04:00
Felix Fontein
d64b17731d docker_container: improve log_options idempotency by converting to string (#54955)
* Warn when log_options values are not strings.

* Add changelog.

* Improve message.

* Improve formatting and formulation of other messages.

* Add test for warning.

* Trying double escaping.
2019-04-12 18:36:11 -04:00
Abhijeet Kasurde
6ff4547489 VMware: get_all_host_objs accepts list of host (#55146)
vmware_portgroup accepts list of hosts, get_all_host_objs API modified
to accept list of hosts.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-12 15:35:35 -07:00
Kevin Breit
6fff8e1d7e Fix spelling error in connection (#54957)
`connection` module utility had a spelling error. s/catergory/category
2019-04-12 16:53:59 -04:00
Toshio Kuratomi
a1c8fc37e8 Remove modules which have ended their deprecation cycle
* Remove code but leave the metadata so that they can be listed as
  removed in documentation.
* Remove removed modules from validate-modules ignore
* Remove unittests for the removed nodules
* Remove links to removed modules and add list of removed moduels to the
  2.9 porting guide
2019-04-12 12:57:35 -07:00
Toshio Kuratomi
bc955b9d60 Cleanup the tree for post-2.8-branch
After branch, we do the following tasks:
* Remove all old changelog fragments.  The devel tree starts fresh.
* Remove all old generated changelog info (CHANGELOG-v2.8.rst and .changes.yaml)
* Set the new codename and version in release.py
2019-04-12 12:57:35 -07:00
Evert Mulder
39445786ff Bugfixes when removing a tenant- Module reported changed when tenant was not removed.- Script error when removing a non existing tenant without parent_id (#55110) 2019-04-12 13:25:33 -04:00
Evert Mulder
daaea17801 Fixed incorrect response removing a group (#55116) 2019-04-12 13:25:18 -04:00
Brian Coca
9f87552f06
add option to display per host start to default (#53819)
* add option to display per host start to default
2019-04-12 12:42:38 -04:00
Nathan Dines
5eb3117822 Added the OnFailure option to the AWS CloudFormation module (#52431)
* Added the OnFailure option to the AWS CloudFormation module

* Added unit tests for CloudFormation `on_create_failure`
2019-04-12 09:18:06 -07:00
Brian Coca
e40832df84
become mixin is no more (#54002)
* become mixin is no more
  since sudo/su keywords are removed in 2.9 .. no need to keep this code around
 * also don't need test for code that is removed
 * made preprocess_data on base noop
   its not used by anything anymore, but kept for backwards compat since other methods of same name are used
2019-04-12 12:13:55 -04:00
Bob Boldin
9ddde6b27f AWS: add ec2_transit_gateway_info module (#54460)
* AWS: add ec2_transit_gateway_info module

* move info module test to main module and ensure unique description for parallel tests

* add type designators to module options in documentation

* assign results and return instead of exit.  Add elements directive available with ansible 2.8

* assign results and return instead of exit

* get() method superfluous for module.params

* correct return type in documentation for ASN and format the sample for Tag correctly

* added random uid to test description - removing unstable alias

* change random uuid to resource_prefix to improve source of object identification in testing
2019-04-13 01:35:39 +10:00
Andrey Klychkov
d790285e80 postgresql_idx: improved doc, tests, remove useless lines from code (#55131)
* postgresql_idx: improve doc

* postgresql_idx: improve doc, removed unuseless rows from code

* postgresql_idx: misc doc fix

* postgresql_idx: moved common params where they were

* postgresql_idx: moved common params where they were 2
2019-04-12 14:15:21 +01:00
flowerysong
6273574eb4 Fix ec2_eip parameter logic (#55194) 2019-04-12 21:40:25 +10:00
Jordan Borean
6039ff9a24
win_domain - fix for checking for domain on new host (#55195) 2019-04-12 14:14:49 +10:00
James E. King III
a5f13dd361 ec2_group: docs: fix example for deletion by group ID (#55169)
requires the region for the example task to work
2019-04-11 18:53:32 -05:00
James Cassell
05fe9ef816 vmware_tools: ignore absence of urllib3 2019-04-11 16:29:44 -07:00
Dmitriusan
f40778cae3 Update documentation of filetree to mention limits of 'src' attribute (#54347)
* Filetree plugin does not return the 'src' attribute when `item.state` is set to `directory`

Error is `'dict object' has no attribute 'src'`. See https://github.com/ansible/ansible/issues/51513#issuecomment-459150769 .

* Update filetree.py
2019-04-11 16:39:56 -05:00
Keith Maxwell
04220478da Fewer examples use connection: local in docs (#55133)
* Fewer connection: local lines in module examples and scenario guides

The line 'connection: local' is not required. See
./docs/docsite/rst/inventory/implicit_localhost.rst
2019-04-11 16:28:14 -05:00
Alex Richman
698d2454c7 Fix access_logs_s3_prefix leading/trailing slash (#55148)
- Add documentation regarding restrictions on access_logs_s3_prefix (cannot have a leading or trailing slash)
2019-04-11 16:07:17 -05:00
Wojciech Wypior
adc0d2cd83 fixes an edge case where order of devices parameters breaks idempotency (#55181)
code correction for aggregates in bigip_gtm_pool_member and bigip_pool to be in line with established patterns
2019-04-11 12:51:16 -07:00
Simon Dodsley
30a216bf78 Remove unneccessary line in config section of purefa_facts (#55164) 2019-04-11 15:04:25 -04:00
Brian Coca
6579dfda17
Correct plugin loader context for persistent (#54860)
* Correct plugin loader context for persistent
2019-04-11 14:32:52 -04:00
Sam Doran
27a3ec3a12 Don't use SSLEOFError in vmware_tools.py 2019-04-11 10:17:59 -07:00
James Cassell
2b8cef340e VMware: vmware_tools connection plugin (#55059)
* variable standardisation and cleanup

- connection_address -> vmware_host
- connection_username -> vmware_user
- connection_password -> vmware_password
- connection_verify_ssl -> validate_certs
- connection_ignore_ssl_warnings -> silence_tls_warnings
- ansible_vmware_tools_vm_path -> ansible_vmware_guest_path
- standardize user/pass vars
- fallback to default ansible conneciton vars
- accept VMware standard env vars:
- note lack of "become" support
- add example usage
- more reasonable default sleep interval
- auto-silence tls warnings if validate_certs=false
- get_option for executable
- remove unsafe 'makedirs_safe'

* executable: support env vars and ini
2019-04-11 21:17:43 +05:30
anasbadaha
2cc91e26e0 Adding Support For Vxlan In Onyx Switches (#55081)
* Adding Support For Vxlan In Onyx Switches

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_vxlan.py

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_vxlan phase 2

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Shippable failures

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Samer's Comments on PR

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2019-04-11 20:59:11 +05:30
lumean
b24c037f62 fix 'APIC Error 403: padding check failed' in python3 (#55150)
* fix 'APIC Error 403: padding check failed' in python3

With python2 the APIC-Request-Signature is filled in correctly
APIC-Request-Signature=aAvxASu...

But with python3 the string format method seems to
add the encoding to the output, causing a padding error:
APIC-Request-Signature=b'lFmHWvwW4dr...

Reproduce:
# -*- coding: utf-8 -*-
import base64
a = base64.b64encode(b'\u0001')
b = '%s' % a
print(b)
=======
python --version; python test.py
Python 2.7.16 :: Anaconda, Inc.
XHUwMDAx
Python 3.6.3 :: Anaconda, Inc.
b'XHUwMDAx'

* Ensure we use native strings
2019-04-11 17:28:44 +02:00
ashanmukhapp
51c0fda63f make waiting for init optional for non-thin volumes 2019-04-11 11:16:45 -04:00
Swartz, Nathan
5e3a7ec1f5 Improve netapp_e_volume module and add unit tests.
netapp_e_volume was refactored for maintainability and its documentation
was improved for better clarity.
2019-04-11 11:16:45 -04:00
Matthias
1a7fed9b68 na_ontap_gather_facts: Add gather subset system_node_info (#54161)
* Add gather subset system_node_info

* Fix continuation line
2019-04-11 10:34:40 -04:00
Gonéri Le Bouder
d55e3ad0b8 vmware_host_vmnic_facts: ensure nm_config is define (#55156)
Fix a regression introduced by f96c569f9d.
2019-04-11 19:54:55 +05:30
rajeevarakkal
acd89b3300 as per IRC Core team comment, renaming pwd to password (#55033)
ie idrac_pwd to idrac_password
share_pwd to share_password
2019-04-11 12:56:48 +01:00
Hannes Ljungberg
23d0d225f4 docker_swarm_service_info: Read information about swarm services (#55008)
* Add docker_swarm_service_info module

* Remove unused import

* Limit to retrieving info about one service

* Add exists return value

* Add yaml 3-dash

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Document return value as jinja `none´

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Name is required
2019-04-11 12:30:00 +02:00
Zim Kalinowski
21ec3b294f additional sample for function app (#55136)
* additional sample for function app

* format
2019-04-11 05:57:41 -04:00
Zim Kalinowski
b0cc3072dc
Fix in function app (#55134) 2019-04-11 17:28:27 +08:00
Martin Krizek
a40c1ed811
setup: properly detect is_chroot on Btrfs (#55089)
* setup: properly detect is_chroot on Btrfs

Fixes #55006

* Use get_bin_path for stat

* Remove comment
2019-04-11 11:24:08 +02:00
Christopher Perrin
6e5165b4fb Added license_type, vm_identety and win_rm attributes to azure_rm_virtualmachine module (#42400) 2019-04-11 15:33:09 +08:00
Zim Kalinowski
5145473451
adding facts for Azure HDINsight cluster (#55124) 2019-04-11 15:08:01 +08:00
Matt Davis
1dc8436ed9
module_utils fixes in collections (#55118)
* module_utils fixes in collections

* fixed Windows module_utils in collections
* fixed more Python module_utils cases (from X import module)
* "medium style" Ansiballz modules now work properly with collections (ie, non-replacer but also not using basic.py)
* added more tests
* split Windows/POSIX exec

* sanity
2019-04-10 22:59:53 -07:00
anasbadaha
9bd060292e Adding New Model for Configure Buffer Pool on Onyx Switches (#55082)
* Adding New Model for Configure Buffer Pool on Onyx Switches

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_buffer_pool.py

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2019-04-11 11:02:08 +05:30
Gonéri Le Bouder
754dfc54c8 VMware: vmware_host_config_manager: avoid failure if no change (#55115)
If nothing was changed, the module was raising the following error
because the `message` variable was not defined:
2019-04-11 10:56:44 +05:30
Gonéri Le Bouder
f96c569f9d VMware: vmware_host_vmnic_facts: py3 fix (#55117)
With Python3, `filter()` returns an iterator. So we cannot do a `len()`
on the result.
2019-04-11 09:35:42 +05:30
Dag Wieers
b6bf910bf4
A static leaf is build from the pod id and leaf id (#55120) 2019-04-11 06:03:57 +02:00
Zim Kalinowski
62f4eb7053
adding missing Azure facts modules (#54838) 2019-04-11 11:46:12 +08:00
Yunge Zhu
ed1334fbe3
add wait_for_running option in azure_rm_rediscache module (#54976) 2019-04-11 11:17:31 +08:00
Chris Archibald
e12846f540 Update na_ontap_export_policy_rule to allow multiple rules to be set at once. (#54801)
* update

* add unit tests
2019-04-10 20:48:49 -04:00
Madhura-CSI
fe31b7eddb New module for azure virtual network gateway (#44411)
* module for azure vpn gateway

* updating vng
2019-04-10 17:47:33 -07:00
Chris Archibald
db0f5a3fdc Bug fix to na_elementsw_account.py (#54798)
* bug fixes

* bug fix
2019-04-10 20:05:32 -04:00
Sam Doran
c2be342ce1 Add podman_image and podman_image_info modules (#55103)
* Add podman_image and podman_image_info modules

* Add integration test for podman_image_info

* Change parameter names per feedback

* Add integration tests for podman_image
2019-04-10 18:28:09 -05:00
René Moser
e28d08a3c1
cloudscale_server: implement param server_groups (#54868) 2019-04-11 00:16:35 +02:00
Chris Archibald
c51f840faa Allow for multiple LIFS instead of 1 at a time (#54800)
* upload unit tests
2019-04-11 00:15:08 +02:00
Anatoly Pugachev
19f6634353 Add support of facts gathering WWNs on AIX OS (#51704)
* Extend git commit c65909d6db "Add network fact to obtain FC WWN initiator ports"
adding support of enumerating AIX device WWN ports

$ lsdev -Cc adapter -l fcs*
fcs0 Defined   00-00 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03)
fcs1 Defined   00-01 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03)
fcs2 Available 04-00 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03)
fcs3 Available 04-01 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03)

$ lscfg -vpl fcs3 | grep 'Network Address'
        Network Address.............10000090FA551509

* no self in this code

* Two fixes:

- fix run_command execution, passing 'use_unsafe_shell=True' since we have a pipe in it ( | grep )
  if we don't set unsafe shell, it will return error on execution.

- strip new line characters at the end of WWNs.

* fix pep8 , E225 missing whitespace around operator

* use module.get_bin_path() instead of hardcoded values

* move module.get_bin_path() out of for loop

* use python string parsing instead of calling external grep

* use in operator instead of find() for simplicity and readability

* add changelog fragment
2019-04-11 00:13:33 +02:00
Felix Fontein
7d2e4dd2fd ufw: fix default (again) (#55004) 2019-04-11 00:06:53 +02:00
s-hertel
44a07cfe71 Use standard _sanitize_group_name method 2019-04-10 17:34:13 -04:00
Ondra Machacek
af528bed80 inventory_plugins: Add kubevirt inventory plugin
Signed-off-by: Ondra Machacek <omachace@redhat.com>
2019-04-10 17:34:13 -04:00
desimaniac
b41c6fcdd4 Pushover: Adds support for optional 'title' (#53726)
** SUMMARY **
Adds support for optional 'title'.

** ISSUE TYPE **
Feature Pull Request

** COMPONENT NAME **
pushover
2019-04-10 17:13:54 -04:00
Dag Wieers
9ac57dff61
MSO: Remove parameters to specify object ids (#55107)
MSO: Remove parameters to specify object ids
2019-04-10 23:06:02 +02:00
Abhijeet Kasurde
bea397b458 Add type int for various argument params (#55026)
Specify type as int for various arguments where default value is int.

Fixes: #55005

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-10 16:19:00 -04:00
adamgoossens
dd3de27cc8 New module: keycloak_group (#35637)
* Initial implementation of groups module.

Not all parameters are supported, yet.

* Clarify read-only status of realmRoles, clientRoles and access attributes

* Fix testing failures

* Fix additional style issues.

* Minor updates and fixes after review feedback

* Simplify return values after feedback

This removes the 'proposed' and 'end_state' return values, replacing them instead with just 'group'. 'group' is the representation of the group after the module completes.

Also update the dates, and the Ansible version

* Corrections after module validation

* Further documentation updates after feedback

Minor whitespace adjustments also

* Add delegate_to: localhost stanzas to examples
2019-04-10 15:58:20 -04:00
Chris Archibald
7bb19f1b4d bug fix (#55057) 2019-04-10 15:57:42 -04:00
charlrvd
24c5a6ef4c grafana_plugin: Add check condition when plugin version is 'latest' (#53369)
* Add check condition when plugin version is 'latest'

* Add check condition when plugin version is 'latest' + pep 8
2019-04-10 15:55:55 -04:00
Chris Archibald
6661f17ce3 update (#54803) 2019-04-10 20:39:04 +01:00
Chris Archibald
c582e89f45 add missing ems logs (#54813)
* add missing ems logs

* fix issue
2019-04-10 20:37:16 +01:00
Sloane Hertel
a99bb0e493
ec2 - count_tag can be an int, str, list, or dict (#55046) 2019-04-10 15:11:18 -04:00
Toshio Kuratomi
04e5c550a8 Do not look for a paramiko compat package anymore (#55106) 2019-04-10 14:51:53 -04:00
Gaudenz Steinlin
a290cb4a35 Add cloudscale.ch API inventory plugin (#53517) 2019-04-10 20:01:13 +02:00
Dag Wieers
524a418a08
mso_st_deploy: Add state 'undeploy' (#55093)
This adds undeploy support to mso_schema_template_deploy.
2019-04-10 19:28:15 +02:00
René Moser
166a33ef4d
cloudscale: new module cloudscale_server_group (#54901) 2019-04-10 18:50:59 +02:00
ndswartz
eee51486fd Remove logged chap secret (#53287) 2019-04-10 12:12:42 -04:00
Rhys Campbell
de14cd7ae8 Minor change to excep handling for 4.0 (#53484) 2019-04-10 12:12:30 -04:00
Sandeep Kasargod
e1c4ee2514 New module for managing volumes in Vexata storage arrays (#49006)
* Initial commit for module to manage Vexata storage volumes + fixes form code review in pr #47091.

* Fix indent errors reported by lint.

* Refactor, implement code review changes

* Moved doc fragment file to new layout

* Added explicit types for all module parameters, updated copyrights + raw string for block text.
2019-04-10 21:12:23 +05:30
Matt Martz
e89f8bae86
Extend jinja2 nested undefined support to keys/indices (#55094) 2019-04-10 10:35:31 -05:00
Wilmar den Ouden
877ce12970 VMware: Rename results key to ansible_module_results (#55038)
* Rename results key to ansible_module_results

* Update to a better variable name

* Update example and adds change to porting guide
2019-04-10 19:58:25 +05:30
咚咔
72fc11ff13 Fix read vaulted toml inventory (#54226) (#54235) 2019-04-10 09:10:48 -05:00
Andrey Klychkov
d3dae4a444 postgresql_owner: fix doc (#55091)
* postgresql_owner: fix doc

* postgresql_owner: fix doc

* postgresql_owner: fix doc
2019-04-10 14:54:27 +01:00
Lukas Kämmerling
3f579eb68f hcloud: Fix testsuite (#55076) 2019-04-10 15:16:10 +02:00
Andrey Klychkov
a971a0eb80 New module postgresql_slot: Add or remove slots from a PostgreSQL database (#55079)
* New module postgresql_slot

* New module postgresql_slot: fixed sanity

* New module postgresql_slot: fixes

* New module postgresql_slot: fixes

* New module postgresql_slot: fix sanity
2019-04-10 14:12:57 +01:00
Patryk D. Cichy
56c553c55d Proper handling of lower case name for InternalLbVm Service Provider (#55087) 2019-04-10 07:50:08 -04:00
Felix Fontein
c411883618 openssl_* module_utils/crypto.py: add full list of OIDs known to current OpenSSL (#54943)
* Add full list of OIDs known to current OpenSSL.

* Remove hardcoded OIDs.

* UID -> x500UniqueIdentifier

* Reference actual version used.

* Don't normalize to lower-case.

* Change test back.

* Fix typo.

* Apply changes suggested by RedHat legal.
2019-04-10 12:46:10 +01:00
Andrea Tartaglia
0303ea2bfa openssl_pkcs12: Add idempotency checks (#54633)
* Added idempotency logic to openssl_pkcs12

Also decoupled the 'parse' and 'generate' function from the file write
as they are now used in different places that do not need the file to be
written to disk.

* Added idempotency tests for openssl_pkcs12

Also adds a new test for pkcs12 files with multiple certificates

* Regenerate if parsed file is invalid

* pkcs12_other_certificates check was wrong

* Updated ca_certificates to other_certificates

ca_certificates is left as an alias to other_certificates;
friendlyname depends on private key, so it will be ignored while
checking for idempotency if the pkey is not set;
idempotency check only checks for correct certs in the stack

* use different keys for different certs

* Added other_certificates in module docs

* Added changelog and porting guide

* removed unrelated porting guide entry

* renamed ca_cert* occurrence with other_cert
2019-04-10 11:43:08 +01:00