ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity
17868 commits 10 branches 167 tags 272 MiB
Commit graph

6156 commits

Author SHA1 Message Date
Brian Coca
c9a5f7ea7e updated self to cls to match convention 
tempted to just use this. in all cases
 2016-01-08 17:57:09 -05:00
Brian Coca
792db08259 Merge pull request #13772 from bcoca/vars_prompt_fixes 
restructure vars_prompt and fix regression
 2016-01-08 17:51:48 -05:00
Peter Sprygada
456b3d2c23 adds new iosxr shared module for developing modules that work with IOS XR devices 
This commit adds a new shared module for working with Cisco IOS XR devices over
CLI (SSH).  It also provides a documentation fragement for the commmon arguments
provided by the iosxr module.
 2016-01-08 14:14:29 -05:00
Peter Sprygada
d1dacfb3ca updates the ios shared module with new shell 
This update refactor the ios shared module to use the new shell shared
library instead of issh and cli.  It also adds the ios documentation
fragment to be used when building ios based modules.
 2016-01-08 14:14:08 -05:00
Peter Sprygada
87ccc5c869 initial add of eos shared module 
This adds a shared module for communicating with Arista EOS devices over
SSH (cli) or JSON-RPC (eapi).  This modules replaces the eapi.py module
previously added to module_utils.  This commit includes a documentation
fragment that describes the eos common arguments
 2016-01-08 14:13:48 -05:00
Matt Martz
5f0a348447 Restore ability for a module to specify WANT_JSON 2016-01-08 11:37:28 -06:00
Brian Coca
1cc5ac06e7 restructure vars_prompt and fix regression 
pushed it to use the existing propmpt from display and moved the vars prompt code there also for uniformity
changed vars_prompt to check extra vars vs the empty play.vars to restore 1.9 behaviour
sipmlified the code as it didn't need to check for syntax again (tqm is made none prior based on that)
fixes #13770
 2016-01-08 11:46:04 -05:00
Brian Coca
737090dd13 now show full callback stacktrace when vvv+ 
Still is a warning as we don't want to repeat it multiple times nor additional callbacks to stop ansible execution.
hopefully we can avoid shipping w/o exceptions in the default/minimal callbacks...

Also added feature that now allows for 'preformated' strings passed to warning
 2016-01-08 10:42:12 -05:00
Peter Sprygada
1d240902c6 adds shared module shell for creating cli based transports 
This commit add a new shared module shell that is used to build connections
to network devices that operate in a CLI environment.  This commit supercedes
the issh.py and cli.py commits and removes them from module_utils.
 2016-01-08 10:24:44 -05:00
Emil Lind
b0fe705384 Allow InventoryScript JSON with childgroups only 
and without hosts and vars

Without this patch, the simplified syntax is triggered when a group
is defined like this:

    "platforms": {
        "children": [
            "cloudstack"
        ]
    }

Which results in a group 'platforms' with 1 host 'platforms'.

more details in https://github.com/ansible/ansible/issues/13655
 2016-01-08 13:52:44 +01:00
nitzmahone
45355cd566 convert winrm put_file script template to Unicode string literal 
Fixes traceback on homedirs with non-ascii chars
 2016-01-07 16:23:55 -08:00
Brian Coca
eb4ab5fa2a Revert "Show version without supplying a dummy action" 
This reverts commit 11b55be5bb.
Parsing before action will fail if one of the action specific options is used
As per issue #13743
 2016-01-07 08:28:18 -05:00
Brian Coca
b7dcd7a3a0 pass diff and verbosity settings to modules 
also simplifies and guarantees that all flags are always passed, even when false
this should make checks simpler as you always expect them to exist
 2016-01-07 01:37:19 -05:00
Toshio Kuratomi
d26d76ea58 Fix typo 2016-01-06 15:46:42 -08:00
Toshio Kuratomi
46903c80fa More fixes for unicode handling in the connection plugins. 
Tested that ssh, docker, local, lxc-libvirt, chroot all work with the
updated unicode integration test.
 2016-01-06 15:19:40 -08:00
James Cammarata
90cb7e1937 Don't drop noops from task counting code in linear strategy 2016-01-06 14:02:33 -05:00
Tomasz Kontusz
9ac9c75d76 linear strategy: don't look at tasks from the next block 2016-01-06 14:02:33 -05:00
muffl0n
11b55be5bb Show version without supplying a dummy action 
fixes #12004
parsing x2 does not seem to break anything
 2016-01-06 11:53:33 -05:00
Abhijit Menon-Sen
7c8374e0f8 Strip string terms before templating 
The earlier code did call terms.strip(), but ignored the return value
instead of passing that in to templar.template(). Clearly an oversight.
 2016-01-06 20:44:19 +05:30
James Cammarata
dc47c25e58 Minor tweak to ensure diff is not empty in callback for file diffs 2016-01-05 22:01:01 -05:00
Charles Paul
a65543bbaf adding password no_log and cleaning up argument spec 2016-01-05 14:52:22 -06:00
Brian Coca
095790ac5c Merge pull request #13691 from bcoca/colors 
output color is now configurable
 2016-01-05 14:33:01 -05:00
Brian Coca
84f46701d0 Merge pull request #13626 from bcoca/hostvars_vars 
move hostvars.vars to vars
 2016-01-05 14:32:13 -05:00
Brian Coca
f3c45adfb8 simplified diff handling in callback 
no need for the copy or other complexity
 2016-01-05 14:26:38 -05:00
Brian Coca
9972c27a9b now handles 'non file diffs' 
this allows modules to pass back a 'diff' dict and it will still show using the file interface
 2016-01-05 14:26:38 -05:00
Toshio Kuratomi
22d4dc9d85 Merge pull request #13700 from feliksik/shred-vault-tmpfile 
[security] shred ansible-vault tmp_file. Also when editor is interruped
 2016-01-05 09:25:42 -08:00
Eric Feliksik
11ce08b9dd cleaner implementation and random chunk length. 2016-01-05 18:04:38 +01:00
Toshio Kuratomi
6470f7de2c Update submodule refs 2016-01-05 07:53:22 -08:00
Toshio Kuratomi
c0a8cd950b Fix problems with non-ascii values passed as part of the command to connection plugins 
@drybjed discovered this with non-ascii environment variables and
command line arguments to script and raw module.
 2016-01-04 20:35:25 -08:00
Toshio Kuratomi
8d57ffd16b Revert "Transform the command we pass to subprocess into a byte string in _low_level-exec_command" 
This reverts commit 0c013f592a.

Going to do this in the connection plugin
 2016-01-04 19:25:40 -08:00
Toshio Kuratomi
559ba467c0 Revert "Convert to bytes later so that make_become_command can jsut operate on text type." 
This reverts commit c4da5840b5.

Going to do this in the connection plugins
 2016-01-04 19:25:40 -08:00
Eric Feliksik
151e09d129 use unix shred if possible, otherwise fast custom impl; do not shred encrypted file 2016-01-05 01:43:42 +01:00
Eric Feliksik
1e911375e8 add docs, remove unnecessary int() cast 2016-01-04 18:13:59 +01:00
Michael Scherer
8599c56670 Do not set 'changed' to True when using group_by 
Since group_by is not changing in any way to the remote
system, there is no change. This also make things more consistent
with the set_fact plugin.
 2016-01-04 17:46:40 +01:00
Eric Feliksik
7193d27acc add os.fsync() so that the shredding data (hopefully) hits the drive 2016-01-04 17:22:18 +01:00
James Cammarata
210cf06d9a Tweak how strategies evaluate failed hosts via the iterator and bug fixes 
* Added additional methods to the iterator code to assess host failures
  while also taking into account the block rescue/always states
* Fixed bugs in the free strategy, where results were not always being
  processed after being collected
* Added some prettier printing to the state output from iterator

Fixes #13699
 2016-01-02 01:00:12 -05:00
Brian Coca
6f2f7a79b3 add support for diff in file settings 
this allows modules to report on what specifically changed when using
common file functions
 2016-01-01 21:53:19 -05:00
Yannig Perré
c4d2dbfcdb Replace to_string by to_unicode. 
Fix https://github.com/ansible/ansible/issues/13707
 2016-01-01 15:55:51 +01:00
Thilo Uttendorfer
5c34be15b1 Fix unsupported format character 2015-12-31 02:31:38 +01:00
James Cammarata
e39e8ba308 Fix logic mistake in unarchive action plugin 2015-12-30 13:49:39 -05:00
Eric Feliksik
946b82bef7 shred ansible-vault tmp_file. Also when editor is interruped. 2015-12-30 18:21:34 +01:00
Brian Coca
d3deb24ead output color is now configurable 2015-12-29 17:40:47 -05:00
James Cammarata
2d11cfab92 Squashed commit of the following: 
commit 24efa310b58c431b4d888a6315d1285da918f670
Author: James Cammarata <jimi@sngx.net>
Date:   Tue Dec 29 11:23:52 2015 -0500

    Adding an additional test for copy exclusion

    Adds a negative test for the situation when an exclusion doesn't
    exist in the target to be copied.

commit 643ba054877cf042177d65e6e2958178bdd2fe88
Merge: e6ee59f 66a8f7e
Author: James Cammarata <jimi@sngx.net>
Date:   Tue Dec 29 10:59:18 2015 -0500

    Merge branch 'speedup' of https://github.com/chrismeyersfsu/ansible into chrismeyersfsu-speedup

commit 66a8f7e873ca90f7848e47b04d9b62aed23a45df
Author: Chris Meyers <chris.meyers.fsu@gmail.com>
Date:   Mon Dec 28 09:47:00 2015 -0500

    better api and tests added

    * _copy_results = deepcopy for better performance
    * _copy_results_exclude to deepcopy but exclude certain fields. Pop
    fields that do not need to be deep copied. Re-assign popped fields
    after deep copy so we don't modify the original, to be copied, object.
    * _copy_results_exclude unit tests

commit 93490960ff4e75f38a7cc6f6d49f10f949f1a7da
Author: Chris Meyers <chris.meyers.fsu@gmail.com>
Date:   Fri Dec 25 23:17:26 2015 -0600

    remove uneeded deepcopy fields
 2015-12-29 11:40:18 -05:00
Brian Coca
56454d6a91 added newer vars to 'reset_vars' 
these vars pass back info to the task about the connection
moved to their own block at start at file for readability and
added the newer standard vars
 2015-12-28 12:25:27 -05:00
Toshio Kuratomi
d70a97b562 Update submodule refs 2015-12-25 12:17:22 -08:00
Toshio Kuratomi
deac4d00b2 bigip changes as requested by bcoca and abadger: 
* Fix to error if validate_cert is True and python doesn't support it.
* Only globally disable certificate checking if really needed.  Use
  bigip verify parameter if available instead.
* Remove public disable certificate function to make it less likely
  people will attempt to reuse that
 2015-12-24 11:49:31 -08:00
Brian Coca
fd7e01696f updated submodule refs to pick up module changes 2015-12-23 17:16:21 -05:00
Brian Coca
db1d153aca Merge pull request #13647 from bcoca/fix_role_search 
corrected role path search order
 2015-12-23 15:11:49 -05:00
Brian Coca
9a118ce213 Merge pull request #13648 from bcoca/fix_invocation_and_moderrors 
better module error handling
 2015-12-23 10:42:40 -05:00
Michael Scherer
42b9a206ad Fix last commit, make it python3 compatible (and py24) 2015-12-23 13:24:11 +01:00
Brian Coca
957b376f9e better module error handling 
* now module errors clearly state msg=MODULE FAILURE
* module's stdout and stderr go into module_stdout and module_stderr keys
which only appear during parsing failure
* invocation module_args are deleted from results provided by action
plugin as errors can keep us from overwriting and then disclosing info that
was meant to be kept hidden due to no_log
* fixed invocation module_args set by basic.py as it was creating different
keys as the invocation in action plugin base.
* results now merge
 2015-12-22 23:01:56 -05:00
Brian Coca
202b92179d corrected role path search order 
the unfraking was matching roles in current dir as it always returns a full path,
pushed to the bottom as match of last resort
fixes #13645
 2015-12-22 22:09:45 -05:00
Brian Coca
010839aedc fix no_log disclosure when using aliases 2015-12-22 17:15:58 -05:00
Toshio Kuratomi
c4da5840b5 Convert to bytes later so that make_become_command can jsut operate on text type. 2015-12-22 08:22:02 -08:00
Brian Coca
474772c81c Merge pull request #13639 from emonty/bool-conversion 
Also convert ints to bool for type=bool
 2015-12-22 10:21:18 -05:00
Monty Taylor
c60749c922 Also convert ints to bool for type=bool 2015-12-22 09:14:12 -06:00
Brian Coca
bbdfaf0522 move hostvars.vars to vars 
this fixes duplication under hostvars and exposes all vars in the vars dict
which makes dynamic reference possible on 'non hostvars'
 2015-12-22 00:24:35 -05:00
Toshio Kuratomi
0c013f592a Transform the command we pass to subprocess into a byte string in _low_level-exec_command 2015-12-21 13:53:35 -08:00
Brian Coca
75e94e0cba allow for non standard hostnames 
* Changed parse_addresses to throw exceptions instead of passing None
* Switched callers to trap and pass through the original values.
* Added very verbose notice
* Look at deprecating this and possibly validate at plugin instead
fixes #13608
 2015-12-21 13:42:34 -05:00
Yannig Perré
a4674906c6 Merge role params into variables separately from other variables 
Fixes #13617
 2015-12-21 13:03:09 -05:00
James Cammarata
6ae04c1e4f Fix logic in PlayIterator when inserting tasks during rescue/always 
Because the fail_state is potentially non-zero in these block sections,
the prior logic led to included tasks not being inserted at all.

Related issue: #13605
 2015-12-20 12:39:08 -05:00
James Cammarata
3ec0104128 Fixing bugs in conditional testing with until and some integration runner tweaks 2015-12-19 21:14:48 -05:00
Brian Coca
bb2935549f corrected service detection in docker versions 
now if 1 == bash it falls back into tool detection
 2015-12-19 16:16:10 -05:00
Toshio Kuratomi
e66c070e5c Add package module to squash list 2015-12-19 13:00:58 -08:00
Toshio Kuratomi
224d596336 Remove args from get_name() as we can't tell if any of the args are no_log 2015-12-19 11:51:16 -08:00
Toshio Kuratomi
8ffc1fa838 Comment to explain why we strip _ansible_notify specially 2015-12-19 11:31:46 -08:00
Toshio Kuratomi
d32a885e98 Make return invocation information so that our sanitized copy will take precedence over what the executor knows. 2015-12-19 11:24:59 -08:00
Toshio Kuratomi
2936682f00 Revert "removed invocation info as it is not no_log aware" 
This reverts commit 6127a8585e.
 2015-12-19 11:09:20 -08:00
Brian Coca
6127a8585e removed invocation info as it is not no_log aware 
This was added in 1.9 and 2.0 tried to copy, but since it cannot
obey no_log restrictions I commented it out. I did not remove as
it is still very useful for module invocation debugging.
 2015-12-19 11:48:48 -05:00
Toshio Kuratomi
07a0059306 update submodule ref for doc fix 2015-12-18 22:23:25 -08:00
Toshio Kuratomi
3197eeaaa8 update submodule refs 2015-12-18 22:16:49 -08:00
James Cammarata
a3dcb910b8 Fixing bugs with {changed,failed}_when and until with registered vars 
* Saving of the registered variable was occuring after the tests for
  changed/failed_when.
* Each of the above fields and until were being post_validated too early,
  so variables which were not defined at that time were causing task
  failures.

Fixes #13591
 2015-12-18 10:58:55 -05:00
Toshio Kuratomi
3057fc1753 Update submodule ref for mysql_user fix 2015-12-17 13:46:15 -08:00
James Cammarata
4ba7158282 Fixing a mistake from tweaking list stuff too much 
Use the action only if the task name is not set
 2015-12-17 16:33:23 -05:00
James Cammarata
d4ffc96c80 Further tweaks to the output format of list tasks/tags 2015-12-17 16:30:23 -05:00
James Cammarata
5929ffc7c3 Make --list-tasks respect tags 
Also makes the output closer to the appearance of v1

Fixes #13260
 2015-12-17 16:10:27 -05:00
Toshio Kuratomi
bad1c173b8 Update core submodule for mysql_db fix 2015-12-17 11:36:36 -08:00
Toshio Kuratomi
1b5e7ce025 Update submodule refs 2015-12-17 10:23:30 -08:00
James Cammarata
e546219426 Revert "Enable host_key checking at the strategy level" 
This reverts commit 1a6d660d7e285cceec474952a33af4d8dffd0a8d.
 2015-12-17 12:43:47 -05:00
James Cammarata
586208234c Revert "Fixing bugs in ssh known_host fetching" 
This reverts commit 21c127c581.
 2015-12-17 12:43:47 -05:00
James Cammarata
21c127c581 Fixing bugs in ssh known_host fetching 
* If remote_addr is not set in the PlayContext, use the host.address
  field instead (which is how the action plugin works)

Fixes #13581
 2015-12-17 12:06:17 -05:00
James Cammarata
d9c74536be Fix handling of environment inheritence, and template each inherited env 
Environments were not being templated individually, so a variable environment
value was causing the exception regarding dicts to be hit. Also, environments
as inherited were coming through with the tasks listed first, followed by the
parents, so they were being merged backwards. Reversing the list of environments
fixed this.
 2015-12-17 09:44:40 -05:00
James Cammarata
e5c2c03dea Enable host_key checking at the strategy level 
Implements a new method in the ssh connection plugin (fetch_and_store_key)
which is used to prefetch the key using ssh-keyscan.
 2015-12-16 21:41:07 -05:00
James Cammarata
15135f3c16 Make sure we're using the original host when processing include results 
Also fixes a bug where we were passing an incorrect number of parameters to
_do_handler_run() when processing an include file in a handler task/block.

Fixes #13560
 2015-12-16 19:13:45 -05:00
James Cammarata
857456ea5f Fixing template integration test for python 2.6 versions 
No longer immediately fallback to to_json if simplejson is not installed
 2015-12-16 18:22:22 -05:00
Toshio Kuratomi
fd4ad2c8f2 Update submodule ref to fix a bug in mysql_user with mariadb 2015-12-16 14:08:08 -08:00
James Cammarata
8716bf8021 All variables in complex args again 
Also updates the CHANGELOG to note the slight change, where bare variables
in args are no longer allowed to be bare variables

Fixes #13518
 2015-12-16 16:39:08 -05:00
James Cammarata
76b4b9ed2c Merge pull request #13501 from chouseknecht/galaxy-2.0-update 
Galaxy 2.0 update
 2015-12-16 15:01:12 -05:00
nitzmahone
baece499df fix plugin loading for Windows modules 
force plugin loader to only consider .py files, since that's the only place docs can live ATM...
 2015-12-16 11:47:12 -08:00
Toshio Kuratomi
9724117bbb Update submodule refs for mysql refactor 2015-12-16 11:15:39 -08:00
Toshio Kuratomi
1116bc6ca6 Merge pull request #13191 from Jmainguy/mysql 
Add shared connection code for mysql modules
 2015-12-16 10:47:49 -08:00
Jonathan Mainguy
34e88e48a5 Add shared connection code for mysql modules 2015-12-16 13:36:18 -05:00
James Cammarata
6a252a3f77 Preserve the cumulative path for checking includes which have parents 
Otherwise, each relative include path is checked on its own, rather
than in relation to the (possibly relative) path of its parent, meaning
includes multiple level deep may fail to find the correct (or any) file.

Fixes #13472
 2015-12-16 11:23:06 -05:00
Toshio Kuratomi
0095d04af9 Update submodule refs 2015-12-16 08:02:46 -08:00
Toshio Kuratomi
7d519127fe Merge pull request #13573 from ansible/ssl-context-with-proxy 
Fix a few problems with url handling.
 2015-12-16 08:00:59 -08:00
Toshio Kuratomi
33863eb653 Conditionally create the CustomHTTPSConnection class only if we have the required baseclasses. 
Fixes #11918
 2015-12-16 07:47:09 -08:00
Toshio Kuratomi
72a0654b81 Fixes for proxy on RHEL5 2015-12-16 07:47:07 -08:00
Toshio Kuratomi
73ead4fbba First attempt to fix https certificate errors through a proxy with python-2.7.9+ 
Fixes #12549
 2015-12-16 07:46:54 -08:00
Brian Coca
97275110d7 Merge pull request #13533 from bcoca/debug_fixes 
debug now validates its params
 2015-12-16 10:36:20 -05:00
James Cammarata
fcc9258b74 Use the original host rather than the serialized one when processing results 
Fixes #13526
Fixes #13564
Fixes #13566
 2015-12-16 01:48:22 -05:00
Toshio Kuratomi
d203438a2c Merge pull request #13554 from Yannig/devel_fix_python3_tests 
Use six lib to import urlparse properly.
 2015-12-15 07:55:56 -08:00
Brian Coca
be5488cb60 clean debug output to match prev versions 2015-12-15 09:27:53 -05:00
Brian Coca
a0842781a6 renamed ssh.py shared module file to clarify 2015-12-15 08:45:12 -05:00
Yannig Perré
be4d1f9ee3 Fix a part of python 3 tests (make tests-py3, see https://github.com/ansible/ansible/issues/13553 for more details). 2015-12-15 13:37:35 +01:00
Peter Sprygada
27cd7668c1 the ssh shared module will try to use keys if the password is not supplied 
The current ssh shared module forces only password based authentication.  This
change will allow the ssh module to use keys if a password is not provided.
 2015-12-15 07:16:28 -05:00
Toshio Kuratomi
8d16638fec Fix for template module not creating a file that was not present when force=false 2015-12-14 10:55:21 -08:00
Michael Scherer
a7ac98262d Make module_utils.known_hosts.get_fqdn work on ipv6 2015-12-14 19:30:54 +01:00
Toshio Kuratomi
c9eb41109f Update submodule refs 2015-12-14 08:03:56 -08:00
James Cammarata
80d23d639c Use an octal representation that works from 2.4->3+ for known_hosts 2015-12-14 10:43:30 -05:00
James Cammarata
6312e38133 Fixing up some non-py3 things for unit tests 2015-12-14 10:35:58 -05:00
Brian Coca
2a37f11738 Merge pull request #13542 from h0nIg/devel_default_ask 
ansible vault, ask pass: use default settings from ansible.cfg
 2015-12-14 09:14:48 -05:00
Hans-Joachim Kliemeck
f5f9b2fd35 use default settings from ansible.cfg 2015-12-14 15:04:31 +01:00
James Cammarata
f8ff63f8c8 A few tweaks to improve new forking code 2015-12-14 03:06:52 -05:00
Brian Coca
175c2d6510 Merge pull request #13502 from robinro/patch-3 
use shallow clones by default in ansible-pull
 2015-12-13 09:31:35 -05:00
Toshio Kuratomi
2bc3683d41 Restore comment about for-else since it is an uncommon idiom 2015-12-13 05:55:31 -08:00
chouseknecht
06dde0d332 Fixed documentation typos and bits that needed clarification. Fixed missing spaces in VALID_ACTIONS. 2015-12-13 05:23:04 -05:00
chouseknecht
342dee0023 Define and handle ignore_certs correctly. Preserve search term order. Tweak to Galaxy docsite. 2015-12-13 05:23:04 -05:00
chouseknecht
bc73920090 Updated ansible-galaxy man page. Removed -b option for import. 2015-12-13 05:23:04 -05:00
chouseknecht
d8e6bc98a2 Fix overloaded options. Show an error when no action given. Don't show a helpful list of commands and descriptions. 2015-12-13 05:23:04 -05:00
Robin Roth
1bd8d97093 fix whitespace 2015-12-13 11:19:50 +01:00
Robin Roth
1b2ebe8def make shallow clone the default for ansibel-pull 2015-12-13 10:56:47 +01:00
Brian Coca
d73562902b debug now validates its params 
simplified var handling
made default message the same as in pre 2.0
fixes #13532
 2015-12-13 00:13:13 -05:00
Brian Coca
f3bedbae29 simplified skippy 
thanks agaffney!
 2015-12-12 17:50:55 -05:00
Brian Coca
99e46440bd changed shell delimiters for csh 
fixes #13459
 2015-12-12 16:10:18 -05:00
Brian Coca
8e445c551a removed unused imports in galaxy/cli 2015-12-12 13:43:10 -05:00
James Cammarata
120b9a7ac6 Changing the way workers are forked 2015-12-11 23:35:07 -05:00
Brian Coca
ae988ed753 avoid set to unique hosts to preserver order 
swiched to using a list comp and set to still unique but keep expected order
fixes #13522
 2015-12-11 15:38:04 -05:00
Brian Coca
de71171fc2 removed merge conflict 2015-12-11 15:11:26 -05:00
James Cammarata
7f7e730dea Don't mark hosts failed if they've moved to a rescue portion of a block 
Fixes #13521
 2015-12-11 14:55:44 -05:00
Brian Coca
d9e510b192 narrow down exception catching in block builds 
this was obscuring other errors and should have always been narrow scope
 2015-12-11 13:13:05 -05:00
Chrrrles Paul
e56efa49c4 Merge pull request #13509 from chrrrles/vca_default_host 
fix default host for non vcd service types
 2015-12-11 10:17:55 -05:00
Abhijit Menon-Sen
37c4e9aee3 Clean up debug logging around _low_level_execute_command 
We were logging the command to be executed many times, which made debug
logs very hard to read. Now we do it only once.

Also makes the logged ssh command line cut-and-paste-able (the lack of
which has confused a number of people by now; the problem being that we
pass the command as a single argument to execve(), so it doesn't need an
extra level of quoting as it does when you try to run it by hand).
 2015-12-11 07:11:48 +05:30
Charles Paul
a6a58d6947 fix default host for non vcd service types 2015-12-10 16:39:27 -05:00
Toshio Kuratomi
bd9582d072 Update submodule refs 2015-12-10 08:10:45 -08:00
Toshio Kuratomi
1dda8158ff become_pass needs to be bytes when it is passed to ssh. 
Fixes #13240
 2015-12-10 07:29:38 -08:00
Charles Paul
6680cc7052 allow custom callbacks with adhoc cli for scripting 
missing import of CallbackBase
 2015-12-10 09:49:54 -05:00
Robin Roth
c20c1a6d49 add depth option to ansible-pull 
Allows shallow checkouts in ansible-pull by adding `--depth 1` (or higher number)
 2015-12-10 11:16:21 +01:00
James Cammarata
2b36343451 Missed one place we were appending the incorrectly escaped item to raw params 2015-12-09 17:58:44 -05:00
Toshio Kuratomi
62cbc03af6 Revert "Remove the funcd connection plugin" 
This reverts commit c0d79cf7e1.

We may still port the funcd connection plugin, just not in time for
2.0.0
 2015-12-09 13:32:11 -08:00
James Cammarata
30b6dd8bcd Merge pull request #13495 from Yannig/devel_debug_null_error 
Do not fail when variable is not correct in debug action.
 2015-12-09 16:27:05 -05:00
Yannig Perré
18ac12aee6 Do not fail when variable is not correct in debug action. 
See https://github.com/ansible/ansible/issues/13484 for more information.
 2015-12-09 22:08:30 +01:00
Toshio Kuratomi
c0d79cf7e1 Remove the funcd connection plugin 2015-12-09 13:07:00 -08:00
Brian Coca
64864829c4 changed deprecation to removal warning 2015-12-09 12:37:56 -08:00
Toshio Kuratomi
61dc4a7e67 Update module refs 2015-12-09 12:10:21 -08:00
James Cammarata
14e19c239d Make on_file_diff callback item-aware 2015-12-09 14:52:53 -05:00
Brian Coca
04d74fd680 reenabled --tree for ansible adhoc command 
previous fix to avoid callbacks now conflicted with tree optoin
which is implemented as a callback in 2.0
 2015-12-09 10:13:50 -08:00
Brian Coca
7936a4687e adhoc avoids callbacks by default as it did before 
Previous emptying of whitelist only affected callbacks that were
constructed for need whitelist. This now works for all callbacks.
 2015-12-09 10:01:21 -08:00
Brian Coca
ae2447df91 attribute defaults that are containers are a copy 
This is simpler way to prevent persistent containers across instances
of classes that use field attributes
 2015-12-09 08:40:06 -08:00
Brian Coca
2bfb13bfb3 removed unused 'pattern' from ansible.cfg 
also moved the config param to a 'deprecated' list in constants.py
added TODO for producing a deprecation warning for such vars
 2015-12-09 08:40:06 -08:00
Brian Coca
2820b4c243 removed default from hosts to make it requried 
prevents writing a play w/o a hosts entry which would default to
all/empty
 2015-12-09 08:40:06 -08:00
Brian Coca
c64298de02 Revert "avoid persistent containers in attribute defaults" 
This reverts commit 87969868d4.
found better way to do it
 2015-12-09 08:40:06 -08:00
James Cammarata
332a008273 Merge pull request #13489 from chouseknecht/galaxy-2.0 
Galaxy 2.0
 2015-12-09 11:29:20 -05:00
chouseknecht
4f84769a17 Galaxy 2.0 2015-12-09 10:51:12 -05:00
Brian Coca
87969868d4 avoid persistent containers in attribute defaults 
moved from the field attribute declaration and created a placeholder
which then is resolved in the field attribute class.

this is to avoid unwanted persistent of the defaults across objects which introduces
stealth bugs when multiple objects of the same kind are used in succession while
not overriding the default values.
 2015-12-09 07:29:36 -08:00
Brian Coca
0719eb3e2d clarified warning from tree callback 2015-12-09 07:29:12 -08:00
Brian Coca
d82d65ee7b keep string type filters as strings 
now we don't try to convert types if using a filter that outputs a specifically formated string
made list of filters configurable
 2015-12-08 12:52:20 -08:00
James Cammarata
1799de8528 Preserve original token when appending to _raw_params in parse_kv 
Fixes #13311
 2015-12-08 15:06:36 -05:00
Brian Coca
795fac917e fixed typo in tree callback, added default dir 
this would allow it to work with playbooks also
 2015-12-08 11:59:04 -08:00
James Cammarata
398f6bbb89 Fix typo from 5ae850c 2015-12-08 14:36:36 -05:00
James Cammarata
de690445bc Make fact delegating configurable, defaulting to 1.x behavior 2015-12-08 14:36:33 -05:00
Brian Coca
7ffd578a9d Revert "Fix always_run support in the action plugin for template when copying" 
This reverts commit 9c4eae5253.
 2015-12-08 09:24:20 -08:00
Brian Coca
d4ccb0be59 have always_run override check mode for a task 
Fixes #13418
 2015-12-08 09:24:07 -08:00
James Cammarata
9c4eae5253 Fix always_run support in the action plugin for template when copying 
Fixes #13418
 2015-12-08 11:56:39 -05:00
David L Ballenger
cdc3c88018 Merge remote-tracking branch 'ansible/devel' into issue_13438 2015-12-08 07:42:49 -08:00
Peter Sprygada
2d5b4b1799 Merge pull request #13273 from privateip/nxapi 
adds new device argument to nxapi command arguments
 2015-12-08 10:24:07 -05:00
David L Ballenger
970d7cadb7 Add ssh_host support for MacOSX El Capitan. 
OS X El Capitan moved the /etc/ssh_* files into /etc/ssh/. This fix
adds a distribution version check for Darwin to set the keydir
appropriately on El Capitan and later.
 2015-12-08 07:11:02 -08:00
Brian Coca
9ae1dede03 adhoc does not load plugins by default 
reimplemented feature from 1.x which kept additional callbacks from
poluting adhoc unless specifically asked for through configuration.
 2015-12-08 06:37:57 -08:00
Brian Coca
17b334d4a5 Merge pull request #13450 from privateip/feature_ios_shared_module 
bugfix for ios.py shared module argument creation
 2015-12-07 09:59:04 -05:00
James Cammarata
540cbe0f64 Merge pull request #13445 from n-st/tasks-string-repr 
More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers')
 2015-12-07 08:10:54 -05:00
James Cammarata
2884ff3932 Merge pull request #13455 from Yannig/devel_fix_debug_var_when_content_same_as_name 
Fix issue when var name is the same as content.
 2015-12-07 08:02:22 -05:00
Yannig Perré
2c8eee956f Fix issue when var name is the same as content. 
See https://github.com/ansible/ansible/issues/13453 for more details.
 2015-12-07 09:25:37 +01:00
Toshio Kuratomi
4d637e5780 Use self.args when we parse arguments that way the arguments can be constructed manually 2015-12-06 22:17:47 -08:00
Toshio Kuratomi
a8e015cc22 Add representers so we can output yaml for all the types we read in from yaml 2015-12-06 22:17:47 -08:00
Peter Sprygada
41773630ed adds new device argument to nxapi command arguments 
The device argument allows a dict of nxapi parameters to be passed to
the module to simplify passing the nxapi parameters
 2015-12-05 22:51:40 -05:00
Brian Coca
8607aa527d Merge pull request #13446 from lberruti/no_target_syslog 
Make no_target_syslog consistent.
 2015-12-05 16:08:00 -05:00
Brian Coca
955710267c only set become defaults at last possible moment 
tasks were overriding commandline with their defaults, not with the
explicit setting, removed the setting of defaults from task init and
pushed down to play context at last possible moment.
fixes #13362
 2015-12-05 16:03:50 -05:00
Luca Berruti
8ea45e8608 Make no_target_syslog consistent. 
no_target_syslog = False --> do log on target
 2015-12-05 19:43:02 +01:00
Brian Coca
f89f906f87 simplified get_hosts code to have 1 retrun point 2015-12-05 10:10:25 -05:00
Nils Steinger
a1f6d17e37 More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers') 2015-12-05 15:55:39 +01:00
Nils Steinger
0129fb0a44 Remove duplicates from host list *before* caching it 
Ansible previously added hosts to the host list multiple times for commands
like `ansible -i 'localhost,' -c local -m ping 'localhost,localhost'
--list-hosts`.
8d5f36a fixed the obvious error, but still added the un-deduplicated list to a
cache, so all future invocations of get_hosts() would retrieve a
non-deduplicated list.
This caused problems down the line: For some reason, Ansible only ever
schedules "flush_handlers" tasks (instead of scheduling any actual tasks from
the playbook) for hosts that are contained in the host lists multiple times.
This probably happens because the host states are stored in a dictionary
indexed by the hostnames, so duplicate hostname would cause the state to be
overwritten by subsequent invocations of … something.
 2015-12-05 15:54:08 +01:00
Toshio Kuratomi
c8fd599e14 Merge pull request #13373 from no2a/boolean 
BOOLEAN should contain boolean literals
 2015-12-04 12:17:12 -08:00
Toshio Kuratomi
0434644d12 Transform exceptions into ansible messages via to_unicode instead of str to avoid tracebacks. 
Fixes #13385
 2015-12-04 11:50:39 -08:00
James Cammarata
84507aedd4 Adding a uuid field so we can track host equality across serialization too 2015-12-04 13:33:27 -05:00
James Cammarata
750adbaa27 Changing up how host (in)equality is checked 
Fixes #13397
 2015-12-04 12:57:46 -05:00
Toshio Kuratomi
e385c91fa5 Update submodule refs# 2015-12-04 09:57:06 -08:00
Brian Coca
d5446f9804 fixed ansible-pull broken options 
* sudo was not working, now it supports full become
* now default checkout dir works, not only when specifying
* paths for checkout dir get expanded
* fixed limit options for playbook
* added verbose and debug info
 2015-12-03 20:47:02 -08:00
Brian Coca
e1c62fb5af reverted to previous pull checkout dir behaviour 
This fixes bugs with not finding plays when not specifying checkout dir
Also makes it backwards compatible
 2015-12-03 19:42:05 -08:00
Brian Coca
8d5f36a6c2 return unique list of hosts 2015-12-03 19:39:57 -08:00
Brian Coca
a1f516824e corrected playbook path, reformated options help 
the last just to make the help consistent and readable
 2015-12-03 18:23:53 -08:00
Brian Coca
26520442bd Now and/or shell expressions depend on shell plugin 
This should fix issues with fish shell users as && and || are
not valid syntax, fish uses actual 'and' and 'or' programs.
Also updated to allow for fish backticks pushed quotes to subshell,
fish seems to handle spaces w/o them.
Lastly, removed encompassing subshell () for fish compatibility.
fixes #13199
 2015-12-03 16:38:34 -08:00
James Cammarata
f467f1770f Properly compare object references for Hosts when adding new ones 
Fixes #13397
 2015-12-03 15:25:54 -05:00
James Cammarata
4426b7f6e0 fix sorting of groups for host vars 
Fixes #13371
 2015-12-03 14:23:02 -05:00
Brian Coca
7d073bdd17 Merge pull request #13345 from amenonsen/extract 
Add an 'extract' filter
 2015-12-03 11:19:06 -08:00
Peter Sprygada
29f5c5db71 bugfix for ios.py shared module argument creation 
This patch fixes a bug in module_utils/ios.py where the the wrong shared
module arguments are being generated.  This bug prevented the shared module
from operating correctly.  This patch should be generally applied.
 2015-12-03 12:53:07 -05:00
James Cammarata
5f83a6aeda Properly default remote_user for delegated-to hosts 
Fixes #13323
 2015-12-03 11:31:33 -05:00
Toshio Kuratomi
e201a255d1 Revert "Make sudo+requiretty and ANSIBLE_PIPELINING work together" 
This reverts commit f488de8599.

Reverting for now due to hard to pin down bugs: #13410  #13411
 2015-12-03 08:01:05 -08:00
Toshio Kuratomi
9b81c35d06 Don't compare or merge str with unicode 
Fixes #13387
 2015-12-02 20:53:50 -08:00
James Cammarata
a183972477 Don't use play vars in HostVars 
Fixes #13398
 2015-12-02 14:16:47 -05:00
James Cammarata
8ff67e0494 Default msg param to AnsibleError to avoid serialization problems 2015-12-02 14:16:47 -05:00
James Cammarata
5f1f2acfea Merge pull request #13405 from sivel/v2-playbook-on-start 
Get v2_playbook_on_start working
 2015-12-02 12:40:24 -05:00