Refactor the currently well-factored ec2 modules (i.e. those that already use ec2_connect) to
have a common argument spec. The idea is that new modules can use this spec without duplication
of code, and that new functionality can be added to the ec2 connection code (e.g. security
token argument)
* replace pointless patch with PYTHON=python2
* simplify git describe command
* move pkgver() function lower, so build chroots can make use of it
* align packages in optdepends using spaces
* use double quotation marks only where it's needed
* unify usage of brackets sorrounding variables
* shorten pkgdesc (kudos to Fedora)
* update README
The current version mentions nothing about chmod +x'ing the rax.py file, which means you get a really weird error message when you try to follow it:
```
raise ValueError, "No closing quotation"
```
... from deep inside shlex.py. I'm sure that makes sense if you realized that meant that it was trying to parse `rax.py` as an ini file...
This is accomplished by not setting the If-Modified-Since header,
and setting "cache-control: no-cache" instead. Note that if the
file content has not changed, the module will still report that
changed=false, as the md5's of the tmp file and existing file are
compared before swapping
Fixes#5104
We break the read while loop after waiting "the end of the process" and
the pipes are empty, otherwise we do another select that waits all the
timeout.
The copy action_plugin is not easy to read. Part of this commit is taking that file, restructuring it, and adding comments. No functionality changed in how it interacts with the world.
The fix for #5739 ends up being the assumption that there is a cleanup 'rm -rf' that happens at the end of the copy loop. This was not the fact before and we made a bunch of tmp directories that we hoped would end up being cleaned up. Now we just use the tmp directory that the runner provides and cleanup inline if it is a single file to be coppied or after the loop if it is a recursive copy.
As a part of this we did end up having to change runner to provide a flag so that we could short the inline tmp directory removal. This flag defaults to True so it will not change the behavior of other modules that are being called.
