1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

494 commits

Author SHA1 Message Date
Troy C
3007a8af7e import novaclient.exceptions for cs.images.find
cs.images.find(human_id= throws novaclient.exceptions.NotFound,
resulting in the try/except block with
image = cs.images.find(name=image)  being skipped. catching
novaclient.exception.NotFound allows images to be specified with the
human readable name.

Example:
  tasks:
    - name: Server build request
      local_action:
        module: rax
        region: DFW
        image: Ubuntu 12.04 LTS (Precise Pangolin)

Also, the import is placed after try: import pyrax, because pyrax
imports novaclient and should fail if novaclient is missing.
2013-12-13 16:27:21 -06:00
James Tanner
f55270e746 Set version_added for new_instance_name in cloud/rds module 2013-12-13 13:54:08 -05:00
jctanner
66cad764d2 Merge pull request #5028 from retr0h/correct-nova-api-auth-check
Nova doesn't attempt to auth on obj instantiation
2013-12-13 08:36:27 -08:00
Vincent Viallet
db37528fd2 Bumped to v1.5 2013-12-13 08:59:52 +08:00
jctanner
6051ee0df5 Merge pull request #5052 from bpennypacker/promote_rename
cloud/rds module: added promote command & updated modify command to allow for renaming of database instances.
2013-12-12 15:15:34 -08:00
James Tanner
35cd043e25 Addresses #5276 update documentation for ec2_ami no_reboot parameter 2013-12-12 18:03:00 -05:00
evan82
01e8390a8f Fix ec2_ami no_reboot setting (currently it will not reboot instances to create the AMI)
Line 276: no_reboot = dict(default=True, type="bool"),

This should really default to False (When AMIs are created the machine will reboot before copying the disk).

"When enabled, Amazon EC2 does not shut down the instance before creating the image. When this option is used, file system integrity on the created image cannot be guaranteed."
2013-12-12 15:49:24 -07:00
jctanner
1688a7c776 Merge pull request #5231 from jeffnappi/patch-1
Corrected documentation in ec2_ami module - no_reboot defaults to yes
2013-12-12 14:18:14 -08:00
Nicholas DeClario
b2ea24bc08 Added ability to start and stop existing EC2 instances. 2013-12-12 17:16:59 -05:00
Jim Dalton
aa329b4b48 Make sure initial_state is initialized 2013-12-12 13:09:40 -08:00
Matt Martz
27fb55519c Add version_added for vip_id 2013-12-12 09:32:06 -06:00
Matt Martz
6c6dd09e23 Add ability to specify a VirtualIP ID for sharing a VIP with another LB 2013-12-12 09:32:06 -06:00
Vincent Viallet
30820437bb Minor typos and remove extra dependencies. 2013-12-12 12:30:22 +08:00
Vincent Viallet
1150b78bb0 Add ec2_key module. 2013-12-12 12:23:58 +08:00
Jim Dalton
ac1e84d976 Account for instances that have not yet been registered. Fixes #5076 2013-12-09 19:38:03 -08:00
Jeffrey Nappi
2b82f7d75f Corrected documentation in ec2_ami module - no_reboot defaults to yes 2013-12-09 18:57:58 -07:00
Matt Martz
ccf4199ac8 Initial commit of rax_dns_record 2013-12-06 17:03:08 -06:00
Matt Martz
afd55934fc Remove errant raise 2013-12-06 16:49:28 -06:00
Matt Martz
7b3aa5c205 Add state attribute to description 2013-12-06 16:10:00 -06:00
Matt Martz
c5f54a94f8 Initial commit of rax_dns module 2013-12-06 13:13:09 -06:00
David Hummel
614efadb7a Fix issue #5043: ec2_vpc module wait=yes state attribute retrieval 2013-12-05 10:47:22 -05:00
Michael DeHaan
71a5de6e72 Merge pull request #5168 from sivel/rax_clb_required_together
rax_required_together is a function
2013-12-04 19:11:58 -08:00
Matt Martz
d73251c342 rax_required_together is a function 2013-12-04 19:26:34 -06:00
Bruce Pennypacker
d3480c5630 fixed documentation & added rename example 2013-12-04 10:01:30 -05:00
Michael DeHaan
27199dc219 Merge pull request #5133 from joshuaconner/add_docker_max_version_to_docs
add supported docker version to docs
2013-12-03 16:46:34 -08:00
Evgenii Terechkov
b5d8aa9ff1 Use ovirtsdk if it installed, but fall out gracefully if it is not 2013-12-03 20:21:16 +08:00
jctanner
c259993559 Merge pull request #5078 from brandonhilkert/fix-ec2-tags
Fix checking for existence of EC2 tags
2013-12-02 14:50:47 -08:00
Joshua Conner
c2f128f737 add supported docker version to docs 2013-12-02 13:08:47 -08:00
James Tanner
ad837709bd Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner
6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
jctanner
93159cb9cd Merge pull request #4996 from sivel/rax-module-utils
Implement ansible.module_utils.rax
2013-12-02 11:55:59 -08:00
James Tanner
04b031756c Merge pull request #4502 from dxsarmit/ansible
New library/cloud/ec2 module parameter (assign_public_ip) for non-default VPC instance launching.
2013-12-02 09:43:20 -05:00
Michael DeHaan
36effd237c There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
2013-11-27 21:23:03 -05:00
Michael DeHaan
ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
Brandon Hilkert
33afaebb95 Fix checking for existence of EC2 tags 2013-11-27 11:01:42 -05:00
jctanner
696ce0effe Merge pull request #5067 from justinludwig/fix-aws-credential-params
Fix AWS credential params for ec2_ami, ec2_elb, ec2_tag, ec2_vpc, route53, and s3 modules
2013-11-27 07:14:19 -08:00
Jim Rybarski
483bb58f2d fixed documentation typo about region purpose 2013-11-27 00:35:33 -06:00
Justin Ludwig
26374d89a0 Fix AWS credential params for s3 and other modules
The `ec2_ami`, `ec2_elb`, `ec2_tag`, `ec2_vpc`, `route53`, and `s3` modules
all canonicalize the AWS access and secret key params as
`aws_access_key` and `aws_secret_key`. However, following the fixes for #4540,
those modules now use `get_ec2_creds` from `lib/ansible/module_utils/ec2.py`,
which requires access/secret key params to be canonicalized as
`ec2_access_key` and `ec2_secret_key`. As a result, AWS credentials passed
to those six modules as parameters are ignored (they instead always use
the AWS credentials specified via environment variables, or nothing).

So this change fixes those six modules to canonicalize the
AWS access and secret key params as `ec2_access_key` and `ec2_secret_key`,
allowing them to again accept AWS credentials passed via module params.
2013-11-26 19:29:06 -08:00
Bruce Pennypacker
9abca424ea Added promote command to promote read-replicas to standalone databases (http://aws.amazon.com/about-aws/whats-new/2012/10/11/amazon-rds-mysql-rr-promotion/). Added ability for the modify command to rename a database instance via the optional new_instance_name parameter 2013-11-25 13:16:41 -05:00
John Dewey
15613de6f5 Nova doesn't attempt to auth on obj instantiation
Need to call nova.authenticate() to validate credentials.
2013-11-22 21:57:02 -08:00
Matt Martz
3f2cbb7583 Add ansible.module_utils.rax 2013-11-21 15:46:25 -06:00
Matt Thompson
8cd465938b Add missing exception name 2013-11-20 16:58:19 +00:00
Michael DeHaan
82a9387532 Merge pull request #4971 from erjohnso/devel
fixes #4954 plus updates for gcutil/v1beta16 tests
2013-11-19 14:54:32 -08:00
Eric Johnson
8ff58eb46e fixes #4954 plus updates for gcutil/v1beta16 tests 2013-11-19 22:30:22 +00:00
James Tanner
52032b80d4 Fix pep8 error in ec2_vpc 2013-11-19 16:31:25 -05:00
James Martin
592124f129 cloudformation parameters no longer required. 2013-11-19 14:17:23 -05:00
Michael DeHaan
f7c3975f21 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
Michael DeHaan
2726b13245 Changelog updates and a few module renames. vpc -> ec2_vpc, githooks -> github_hooks, blacklist -> kernel_blacklist. These are all new in 1.4 so safe to change. 2013-11-18 18:28:21 -05:00
Michael DeHaan
aee1fcad05 Update changelog, rename vpc module to ec2_vpc. 2013-11-18 17:59:40 -05:00
Tom Berger
8a39e0a615 Update cloud/docker: if the image name containes a repository, strip it.
When using repositories other than the main one at docker.io, the image name contains the repo name (which itself contains ":" as a separator between domain and port). We don't really care about it here, so just get rid of it before looking at the image name.
2013-11-16 23:15:03 +02:00
Matt Martz
1ef49405b3 Remove debug print statement 2013-11-15 19:52:10 -06:00
jctanner
7ebda819b5 Merge pull request #4919 from sivel/4577-rax-refactor
Refactor rax module. Fixes #4577
2013-11-15 12:20:13 -08:00
Matt Martz
234a78673b Refactor rax module 2013-11-15 12:25:21 -06:00
Matt Martz
fa4e55d677 follow suit with the rax refactor and split out the slugify code 2013-11-15 12:00:32 -06:00
Matt Martz
545aabaddc Add rax_facts module for retrieving facts about a Cloud Server 2013-11-15 11:12:48 -06:00
James Tanner
d0986a20a3 Use shared ec2 module snippet in elasticache module 2013-11-13 10:24:08 -05:00
James Tanner
fd6b16aca8 Merge pull request #4313 from jsdalton/ansible
Add AWS ElastiCache module
2013-11-13 10:15:51 -05:00
James Tanner
a8c531a2f6 Merge branch 'add_aws_elasticache_module' of git://github.com/jsdalton/ansible into jsdalton-add_aws_elasticache_module 2013-11-13 10:10:40 -05:00
James Tanner
a5c29b886e Merge pull request #4299 from psvo/ansible
Fix check for ROLLBACK_COMPLETE in cloudformation module
2013-11-13 10:03:09 -05:00
jctanner
deb33e9d0e Merge pull request #4272 from psvo/tags_parameter_for_cloudformation
Add support for tags parameter to cloudformation module
2013-11-12 11:58:43 -08:00
James Tanner
0ecc83fe98 Change route53 module to use shared ec2 authorization module snippet 2013-11-12 14:16:30 -05:00
James Tanner
fb903c5317 Change s3 module to use shared ec2 authorization module snippet 2013-11-12 14:13:05 -05:00
James Tanner
06eb7357fd Remove redundant credential code in vpc module 2013-11-12 14:10:38 -05:00
James Tanner
8332a0b75e Change vpc module to use shared ec2 authorization moudle snippet 2013-11-12 14:09:06 -05:00
James Tanner
b37a8b90a6 Fix docstring quoting in vpc module 2013-11-12 14:02:50 -05:00
jctanner
7fdeed6539 Merge pull request #4141 from carsongee/vpc
Added module for handling AWS Virtual Private Clouds
2013-11-12 11:01:00 -08:00
Michael DeHaan
0a34870b1f Merge pull request #4858 from sivel/rax-clb-serialize
Fix serialization error in rax_clb
2013-11-10 13:51:41 -08:00
Rob Szewczyk
fe95745a20 Correcting the security group id lookup from the list of security group names 2013-11-08 17:46:41 -05:00
Matt Martz
a897bb389c Remove unused variable 2013-11-08 13:15:38 -06:00
Matt Martz
8f2f8a5b53 DRY up dict conversion and fix serialization error 2013-11-08 13:11:15 -06:00
jctanner
8e8c8efc8f Merge pull request #4769 from alanfairless/more-password-entropy-revised
Revised patch for more password entropy
2013-11-07 13:39:05 -08:00
jctanner
6a5672c997 Merge pull request #4835 from sivel/rax-clb
Add module to create Rackspace Cloud Loadblancers. Fixes #4794
2013-11-07 11:15:23 -08:00
Matt Martz
2065253c3e Rename rax_clb to rax_clb_nodes in docs and examples 2013-11-07 12:56:59 -06:00
jctanner
e36781dace Merge pull request #4603 from claco/rax_network_module
Add rax_network module
2013-11-07 10:49:06 -08:00
Matt Martz
9d684c9e8e If you try to delete a balancer that isn't there, don't blow up 2013-11-07 10:46:50 -06:00
Matt Martz
772fbb8d0a Updates to rax_clb module 2013-11-07 10:42:15 -06:00
Christopher H. Laco
0be54b5585 Added replacement rax_clb that does LB detailed creation 2013-11-07 10:42:15 -06:00
Christopher H. Laco
6a964496b1 Renamed rax_clb to rax_clb_nodes since it's node management and not clb creation 2013-11-07 10:42:15 -06:00
jctanner
277dda5373 Merge pull request #4489 from cove/devel
add docker module
2013-11-07 07:00:23 -08:00
jctanner
31b5b66eb1 Merge pull request #4776 from jlaska/ec2_wait_on_terminate
Honor wait on ec2 instance termination
2013-11-06 12:02:00 -08:00
Christopher H. Laco
f214b9870a Update module based on upstream feedback
- Remove deleted state
- Use dict() instead of raw hash
- Wrap or statements in parens instead of backslash line continuations
- Change instances to networks in module return result
2013-11-06 12:36:47 -06:00
Christopher H. Laco
88083891bb Add rax_network module
Based on the refactor work @sivel is doing, adding a rax_network module
to create/delete networks in the Rackspace Public Cloud.

See: https://github.com/ansible/ansible/issues/4577
2013-11-06 12:36:46 -06:00
jctanner
15a9f7700f Merge pull request #4760 from urbanmapping/devel
make cloudformation module accept template_parameters from command line
2013-11-06 08:12:11 -08:00
Carson Gee
971976ae99 Added module for handling AWS Virtual Private Clouds
This handles creating and editing VPCs and takes care of vpcs,
subnets, Internet Gateways, and route tables.
2013-11-05 16:20:20 -05:00
dragon3
e54832a730 Remove duplicate "download_s3file" execution when the destination path doesn't exist 2013-11-05 22:03:40 +09:00
Cove Schneider
1ea17dee11 Fixes from docker-ansible, update license to be same as other modules 2013-11-03 12:48:03 -08:00
Mohan Krishnan
56bd9a14d5 Fix for connect method parameter order 2013-11-03 14:48:35 +07:00
Mohan Krishnan
0ae9128c7b ec2_eip connect method references module var that is not passed in 2013-11-03 05:18:27 +07:00
James Laska
2a5874b94f Honor wait on ec2 instance termination 2013-11-01 18:57:20 -04:00
Michael DeHaan
e725eea4be Merge pull request #4770 from dragon3/devel
ec2_vol: return volume_id/device even when volume mapping already exists
2013-11-01 09:32:54 -07:00
James Tanner
afa5988391 Fixes #4540 Use shared module snippet to evaluate ec2 credentials 2013-11-01 11:59:24 -04:00
dragon3
19b5008c0a return volume_id/device even when volume mapping already exists 2013-11-01 23:59:42 +09:00
Alan Fairless
0824f004d9 Revised patch for more password entropy 2013-11-01 09:51:35 -05:00
Brian Cavagnolo
869f32123b make cloudformation module accept template_parameters from command line
Passing cloudformation template_parameters on the command line
like so was failing:

    ansible localhost -m cloudformation -a "...template_parameters=foo=5,bar=4..."
2013-10-31 17:00:03 -07:00
Michael DeHaan
187ebf2f56 Leverage 4318b27 and no longer treat instance tags as JSON, but as dictionary types which could be key=value or dicts or JSON or references. 2013-10-31 18:46:13 -04:00
Michael DeHaan
aae3a0ea8d Merge pull request #4740 from retr0h/return-server-object-not-list
Need to compare on server object not list
2013-10-31 14:51:08 -07:00
Sheldon Hearn
6a02c75b7c Fix description of nova_compute:name option
It's the name of the instance, not of an image.
2013-10-31 12:34:04 +02:00
John Dewey
f1fa16b65f Need to compare on server object not list
TASK: [create test controller 0] **********************************************
    failed: [127.0.0.1] => {"failed": true, "parsed": false}
    invalid output was: Traceback (most recent call last):
      File "/Users/jdewey/.ansible/tmp/ansible-1383197329.62-262790004573235/nova_compute", line 1203, in <module>
        main()
      File "/Users/jdewey/.ansible/tmp/ansible-1383197329.62-262790004573235/nova_compute", line 261, in main
        _get_server_state(module, nova)
      File "/Users/jdewey/.ansible/tmp/ansible-1383197329.62-262790004573235/nova_compute", line 197, in _get_server_state
        if server.status != 'ACTIVE':
    AttributeError: 'list' object has no attribute 'status'
2013-10-30 22:41:02 -07:00
Scott Armit
ef317ecde7 If an AWS account does not have a default subnet in their VPC configuration, then creating instances in that VPC will not automatically provide a public IP/DNS. Boto added this functionality in 2.13.0 (NetworkInterfaceSpecification.associate_public_ip_address).
This change adds assign_pubic_ip as a parameter to the ec2 module, ensuring that it is not set to one of BOOLEANS_TRUE if vpc_subnet_id is not also set, and if Boto is less than 2.13.0.
2013-10-28 10:11:38 -04:00
kiri
c1c32c75ac add NoneType check. 2013-10-28 21:35:57 +09:00
Michael DeHaan
2b785ec7e5 Merge pull request #4610 from bennojoy/gcs_fix3
fix for overwrite in put operation
2013-10-26 11:29:11 -07:00
Christian Berendt
42d877146c fixed permissions of module library/cloud/ovirt 2013-10-26 09:05:21 +02:00
James Tanner
8157d5e52a Set version_added for ec2_eip's in_vpc parameter 2013-10-24 12:19:43 -04:00
jctanner
0b4f84d780 Merge pull request #4593 from pas256/eip-vpc
Add VPC support for EIP module
2013-10-24 10:22:43 -07:00
James Tanner
b803aac6ec Fixes #4500 change ec2 module params to type=bool
Revert 4833c2fdf0
2013-10-24 09:19:25 -04:00
Cove Schneider
94574f7296 update with current fixes from docker-ansible 2013-10-23 22:56:02 -07:00
jctanner
e34cde6bef Merge pull request #4112 from jsdalton/add_az_support_to_ec2_elb
Add enable_availability_zone parameter to ec2 module.
2013-10-22 14:01:24 -07:00
bennojoy
0c275424c6 fix to work like copy module 2013-10-22 09:03:52 +05:30
bennojoy
788e783b6d fix for overwrite in put operation 2013-10-21 09:46:21 +05:30
Jim Dalton
2d7f0e28db Availability zone should not be required 2013-10-20 16:20:36 -07:00
Jim Dalton
3957238fbf Ensure port can be read for both memcached as well as redis 2013-10-19 12:29:07 -07:00
Michael DeHaan
21d4400c96 Misc pep8 fixes 2013-10-19 13:03:15 -04:00
Michael DeHaan
aa93ce2dc2 Fix deprecation warnings in the Google modules. 2013-10-19 13:03:14 -04:00
Peter Sankauskas
b793248df4 Now this disassociates EIPs from instances inside a VPC correctly. Time
for a PR.
2013-10-18 15:12:49 -07:00
Peter Sankauskas
0e459f65f0 First round of changes to the EIP module to get it to be able to work well inside a VPC, and to be able to delete EIPs as well 2013-10-18 14:38:58 -07:00
Brian Schott
bdc8ea828e added aws_access_key and aws_secret_key aliases to ec2_group arguments 2013-10-17 15:23:24 -04:00
Michael DeHaan
8a516d1479 Various standardization to the proposed gce_storage module to bring things in line with updates to the S3 module.
Some typo fixes.

Further testing required.
2013-10-17 10:49:51 -04:00
Michael DeHaan
4bdf3da25a Merge pull request #4333 from bennojoy/gcs
support for google cloud storage module
2013-10-17 07:35:53 -07:00
Michael DeHaan
baa13a5cc7 Merge pull request #4395 from erjohnso/devel
adding Google Compute Engine modules and inventory plugin
2013-10-17 07:30:55 -07:00
Lorin Hochstein
1c5bdba977 s3: better check for walrus
Check for Walrus endpoint by looking to see if the endpoint is not AWS.

This fixes a bug where the user specifies an AWS endpoint via S3_URL,
but the code interprets it as Walrus and then fails.
2013-10-16 13:22:41 -04:00
Michael DeHaan
84ff24d92c Merge pull request #4346 from dmkoch/digitalocean-droplet-options
Add "virtio" and "private_networking" options for DigitalOcean droplets
2013-10-14 17:05:06 -07:00
Cove Schneider
5f7e1fc306 Un-camelcase DockerContainers, rename class to DockerManager(). 2013-10-14 13:49:53 -07:00
Michael DeHaan
b8ec300d4c Add note about feature being new in 1.4 2013-10-14 11:57:19 -04:00
Constantine Peresypkin
499a2fe456 add support for disk_config option to cloud/rax module 2013-10-14 11:57:19 -04:00
Michael DeHaan
54b5548068 Slight tweak to ovirt module docs. 2013-10-14 11:43:01 -04:00
Michael DeHaan
f6eae5571a Update version_added in ovirt module. 2013-10-14 11:41:24 -04:00
Michael DeHaan
5dd25692d4 Merge pull request #3838 from vincentvdk/ovirt-mod
added new module "ovirt"
2013-10-14 08:40:07 -07:00
Cove Schneider
565db64a04 remove comment about requirements 2013-10-13 21:37:42 -07:00
Cove Schneider
a4922bc74c add requirements back 2013-10-13 21:36:42 -07:00
Cove Schneider
618004f87b clean up a few warnings 2013-10-13 21:34:58 -07:00
Cove Schneider
c51981b5b7 add python requirements to docs 2013-10-13 21:14:27 -07:00
Cove Schneider
fbca1ebc04 add example docs 2013-10-13 20:34:14 -07:00
Cove Schneider
1fe45c4f6c add docker module 2013-10-13 15:07:27 -07:00
Eric Johnson
1b07e7a521 update defaults and help for 'name' and 'instance_names' 2013-10-13 13:48:09 -07:00
Eric Johnson
81b5c93c78 address a few review comments 2013-10-13 13:41:55 -07:00
Harrison Gu
b5500d9a4d Fix bug for setting ec2 tags 2013-10-12 20:57:32 +08:00
Andy Kluger
f97871e0d9 Corrected docs ("monitor" -> "monitoring" and dissociated monitoring from instance_tags in examples) 2013-10-11 13:32:23 -04:00
James Tanner
d21a0287a2 Remove all sys.exit calls in the cloud/s3 module
Fixes #4458
2013-10-11 11:28:47 -04:00
jctanner
861779bb6e Merge pull request #4457 from mbarrin/devel
Fixed crash when s3 bucket did not exist for put operation
2013-10-11 08:18:51 -07:00
Matthew Barrington
ce0bf71245 Fixed crash when s3 bucket did not exist for put operation 2013-10-11 16:01:54 +01:00
Michael DeHaan
119b6d73dd Remove examples of module antipattern of setting the choices array for boolean types. 2013-10-11 08:45:13 -04:00
bennojoy
40565ef236 nova compute fix regex in instance name 2013-10-10 11:44:30 +05:30
Joost Cassee
bd10aad71f Add in a retry loop for route53 requests
The route53 api doesn't allow multiple overlapping requests, so if
it is still processing a previous request when the next comes in will
return an error.

Fixes #4085
2013-10-09 12:50:41 -05:00
James Tanner
c679491ece #4408 s3: add force alias for overwrite and set True by default 2013-10-09 12:56:56 -04:00
James Tanner
c55107fa83 Remove debug comment from s3 module 2013-10-09 12:25:09 -04:00
James Tanner
9c3fb9c2b7 4006: return s3 url even if file exists 2013-10-09 12:12:24 -04:00
Eric Johnson
cfc249931a custom user-agent header 2013-10-08 16:36:35 +00:00
Michael DeHaan
d803ce7ab3 Fix documentation of default value in s3 module. Fixes #4289 2013-10-08 08:42:03 -04:00
Eric Johnson
9ca824c16d adding Google Compute Engine modules and inventory plugin 2013-10-07 21:01:37 +00:00
Michael DeHaan
0e909640c5 Make group_id be a list. 2013-10-07 15:34:35 -04:00