1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

23935 commits

Author SHA1 Message Date
John Hu
82f1438b14 Add docker_config module (#38792)
* Add docker_config module

* Address review comments

* Merge description lines

* Stop returning empty config_id in results

* Add integration tests for docker_config

Based on docker_secret's tests.

* Ensure swarm using docker_swarm module

* Add minimum docker / docker api version requirements

ref: https://github.com/ansible/ansible/pull/47046

* Check Docker API version before running tests

ref: https://github.com/ansible/ansible/pull/47340

* Typo

* Wording

* Improve example

* Assert state == absent is idempotent
2018-10-26 10:58:17 +01:00
Artem Bityutskiy
b3ec97cd36 swupd: fail in case of an incorrect bundle (#45993)
For some strange reasons the 'swupd' module does not fail if I specify a
non-existing bundle like "xxx". This is inconsistent with other modules, for
example 'dnf'.

The end result is that if someone uses the 'package' module, the result is
inconsistent across OSes: for Fedora trying to install an non-existing module
fails, bot for Clear Linux it just prints a warning and succeeds.

This patch fixes the inconsistent behavior. With this patch 'swupd' will fail
if one tries to install a bundle that does not exist.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
2018-10-26 09:13:03 +01:00
Jim Gu
99ee30768a VMware: Avoid misleading PyVmomi error if requests import fails (#47313)
* Avoid misleading PyVmomi error if requests import fails

Requests is imported by the VMware module_utils as an external
dependency; however, because it is in a try/catch block containing the
imports for PyVmomi, if requests fails to import properly, Ansible will
instead complain about PyVmomi not being installed.

By moving the import outside of the try/catch block, if requests fails
to import, an error like the following will be returned:

    ImportError: No module named requests

This should result in less confusion.

* catch requests ImportError
2018-10-26 12:40:25 +05:30
f-bor
c649d0ea32 enhance recv calls in network_cli (#47345)
* enhance recv calls in network_cli

* updated network_cli test unit

* enhance recv calls in network_cli

* fix mistake

* better timeout management

* remove exception trigger

* test

* test2

* restore exception and timeout

* ganeshrn's way

* correction

* timeout and exception return
2018-10-26 09:49:17 +05:30
Ingate Systems
9fe20123cf modules: network: Add initial support for Ingate modules (#47494)
* modules: network: Add initial support for Ingate modules

* modules: network: Add ingate module ig_unit_information

* module_utils: network: ingate: Use default 'v1' for version

* modules: network: ingate: Remove unused code
2018-10-26 09:47:58 +05:30
s3lph
5b1c68579d Type error in openssl_certificate (#47508)
* Fixed #47505: Type error in openssl_certificate
* Use to_bytes instead of str.encode in SelfSignedCertificate. Updates #47508
* Use to_bytes instead of str.encode in OwnCACertificate
* Added integration tests for openssl_certificate: selfsigned_not_before/after and ownca_not_before/after
2018-10-26 09:11:00 +05:30
Guido García
8f3c29a98f feat: support postgres 10 in azure_rm_postgresqlserver (#47003)
Add support to Azure Postgres 10.x (see [azure official docs](https://docs.microsoft.com/lv-lv/azure//postgresql/concepts-supported-versions)).
2018-10-26 11:37:54 +08:00
Milosz Galazka
04dd21dabb Update proxysql_manage_config.py (#47613)
Incorrect example - wrong module used (proxysql_global_variables instead of proxysql_manage_config)

+label: docsite_pr
2018-10-26 11:35:01 +10:00
curry9999
4906be1009 An error occurs if cluster_id is not specified (#47500)
* 	modified:   google/gcp_compute_backend_bucket.py
	modified:   google/gcp_compute_backend_service.py
	modified:   google/gcp_compute_forwarding_rule.py
	modified:   google/gcp_compute_global_forwarding_rule.py
	modified:   google/gcp_compute_image.py
	modified:   google/gcp_compute_instance.py
	modified:   google/gcp_compute_instance_group.py
	modified:   google/gcp_compute_instance_group_manager.py
	modified:   google/gcp_compute_instance_template.py
	modified:   google/gcp_compute_route.py
	modified:   google/gcp_compute_subnetwork.py
	modified:   google/gcp_compute_target_http_proxy.py
	modified:   google/gcp_compute_target_https_proxy.py
	modified:   google/gcp_compute_target_ssl_proxy.py
	modified:   google/gcp_compute_target_tcp_proxy.py
	modified:   google/gcp_compute_url_map.py
	modified:   google/gcp_container_node_pool.py
	modified:   google/gcp_dns_resource_record_set.py
	modified:   google/gcp_pubsub_subscription.py
	modified:   google/gcp_storage_bucket_access_control.py

* 	modified:   lib/ansible/modules/cloud/amazon/aws_ses_identity.py
	modified:   lib/ansible/modules/cloud/amazon/route53_facts.py
	modified:   lib/ansible/modules/cloud/cloudscale/cloudscale_server.py
	modified:   lib/ansible/modules/network/aos/_aos_logical_device.py
	modified:   lib/ansible/modules/network/aos/_aos_rack_type.py
	modified:   lib/ansible/modules/network/aos/_aos_template.py
	modified:   lib/ansible/modules/network/cumulus/nclu.py
	modified:   lib/ansible/modules/web_infrastructure/ansible_tower/tower_job_launch.py
	modified:   lib/ansible/modules/web_infrastructure/ansible_tower/tower_job_wait.py

* An error occurs if cluster_id is not specified

* An error occurs if cluster_id is not specified
2018-10-26 11:07:40 +10:00
Ross Williams
300db3af84 Module portinstall: use_packages is a bool (#47370)
The module has been checking if use_packages is
a string equal to "yes", but AnsibleModule actually
converts the use_packages argument to a bool.
2018-10-26 10:49:31 +10:00
Matt Martz
f7ba63e047
Add shorthand debugger method to recreate the task from the original ds (#46987)
* Add shorthand debugger method to recreate the task from the original ds, and re-template. Fixes #46321

* Fix rst header

* Indicate update_task was added in 2.8
2018-10-25 16:35:59 -05:00
AndyG
e5664c45a5 Update pip.py (#47568)
adding the option to install pip modules via  proxy, as per https://github.com/ansible/ansible/issues/36333#issuecomment-366374083
2018-10-25 15:29:01 -04:00
Toshio Kuratomi
e5a245de94 Fix from sivel for ansible-doc
* Major slow down due to using the wrong loader for plugin_types
* traceback due to adding httpapi and cliconf plugins to the plugins we
allow ansible-doc to process
2018-10-25 12:06:18 -07:00
Jose Delarosa
1c37471274 Fix idempotency issues in set_bios_attributes
- Added check to see if attribute even exists, if not, it exits.
- Then checks if attribute is already set to value we want to update
  it to. If yes, then it exits and changed=False
- Otherwise updates the attribute and changed=True
2018-10-25 11:02:02 -04:00
Zim Kalinowski
1724b633f2
adding subnet service endpoints (#47549)
adding subnet service endpoints
2018-10-25 13:43:47 +08:00
Trishna Guha
d79b6c8406
fix trailing command in net_neighbors nxos_facts (#47548)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-10-25 10:13:38 +05:30
Abhijeet Kasurde
5f404eb0c1
VMware: Add tag facts to vmware_guest_facts (#47495)
Fixes: #46460

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-25 09:45:38 +05:30
Zim Kalinowski
5193e31886
adding mysql firewall rule facts (#47342)
* adding mysql firewall rule facts

* fixes
2018-10-25 10:10:12 +08:00
Zim Kalinowski
1cb78209ae
upgrading sql package to newest (#47544)
* upgrading sql package to newest

* LROPOller
2018-10-25 10:08:56 +08:00
Zim Kalinowski
4cda7a7883
upgrading rdbms to the latest version (#47547) 2018-10-25 09:55:00 +08:00
Yunge Zhu
1587bb9f65
fix webapp test (#47546) 2018-10-25 09:45:40 +08:00
abarbare
b4a9b29ab2 feat: add security_group to scaleway compute resource (#45699)
feat: add more tests
2018-10-24 22:33:40 +01:00
Hagen Kuehn
0661f2f213 adds 'success_msg' to valid args for assert module (#47030) 2018-10-24 21:10:10 +02:00
Johann Queuniet
74ce8ce935 Add API pagination support to Scaleway inventory (#46117)
* Add Scaleway API pagination to server inventory call

* Move Link parsing to helper module

* Correct some PEP8 errors

* Replace AnsibleError with ScalewayException in module_utils since the former doesn't work

* Simplify the regexes to match the intended purpose

* Cleanup helper to conform to review

* Cleanup Scaleway inventory to conform to review

* Flatten the conditional branches structure

* fix a regexp typo
2018-10-24 17:53:46 +01:00
FragmentedPacket
f83fa2ac93 Netbox inventory: Fix NoneType issue if query_filters is not in netbox_inventory.yml (#46793)
* Added if state to refresh_url to avoid failure at NoneType when guesry_filters is undefined in netbox_inventory.yml
2018-10-24 16:52:20 +01:00
Nathaniel Case
6a866a5e10
ios check_rc: Default to sending text of exception, not the whole exception (#47300)
* Default to sending text of exception, not the whole exception
2018-10-24 09:56:47 -04:00
Simon Dodsley
4420e4c3cd Bug fix for purefb_fs to stop incorrect filesystem eradication (#47561) 2018-10-24 09:42:42 -04:00
Florian Apolloner
ecdcb6a09f Changed django_manage to return changed as boolean consistently (#46157) 2018-10-24 12:56:37 +01:00
John Imison
5ba4e4411b Adding headers to be returned for retrieved messages. (#47375) 2018-10-24 12:38:32 +01:00
lolcube
eb7f6a5e62 Add openssh_keypair module (#46436)
* add openssh_keypair module
2018-10-24 11:51:45 +01:00
Akshay Gaikwad
20b95adf2b Add Support of healthcheck in docker_container module (#46772)
* Add Support of healthcheck in docker_container module

Fixes #33622
Now container can be started with healthcheck enabled

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Extend docker_container healthcheck (#1)

* Allowing to disable healthcheck.

* Added test for healthcheck.

* Make sure correct types are used.

* Healthcheck needs to be explicitly disabled with test: ['NONE'].

* pep8 fixes

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Fix bug if healthcheck interval is 1 day or more

`timedelta` object has days too and seconds are up to one day.
Therefore use `total_seconds()` to convert time into seconds.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Add test for healthcheck when healthcheck is not specified

This is to avoid the situation when healthcheck is not specified and
treat this as healthcheck is changed or removed.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Convert string syntax for healthcheck test to CMD-SHELL

Also add another test case to check idempotency when healthcheck test
is specified as string

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Playbook fails if minimun docker version is not satisfy for healthcheck

This is to make more consistent with other non-supported options.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
2018-10-24 11:49:56 +01:00
Jan Christian Grünhage
01bee0c2d9 Add matrix notification module (#45823)
* Add matrix notification module

* try to make ansibot happy

* docs

* fix typo in encoding

* is ansibot happy now?

* change matrix python lib requirement description

* Example formatting & no_log

Thanks for this PR.
Few minor things that are easier for me to just fix, than explain and get you to fix.

* We suggest using `- name:` for examples, as Ansible best practice is to name your tasks
* To prevent secrets being leaked out use `no_log` in argspec
* use `requirements:` in `DOCUMENTATION`

* Clean up argument requirements

* Remove requirements duplicate

* not sure on syntax with these, were adapted from an example elsewhere
2018-10-24 08:54:38 +01:00
Dag Wieers
691ff4b9e6 WinRM/PSRP: Ensure shell returns UTF-8 output (#47404)
* WinRM/PSRP: Ensure shell returns UTF-8 output

This PR makes UTF-8 output work in PSRP shells.

* Add win_command and win_shell integration tests

* Fix tests

* more test fixes
2018-10-24 10:40:54 +10:00
Simon Dodsley
8a88d78285 Add hard_limit support to Pure Strage FlashBlade filesystem module (#43987) 2018-10-23 19:03:17 -04:00
Jordan Borean
ddfd1dbfc6
Add helper function to return helpful import error msg (#47409) 2018-10-24 07:21:36 +10:00
Jordan Borean
f28b7c7ab1
psrp - fix unicode handling in Python 2 (#47461)
* psrp - fix unicode handling in Python 2

* skip psrp become test when on Server 2008
2018-10-24 05:37:05 +10:00
He Guimin
85ba30a3db Add new module ali_instance (#36898) 2018-10-23 13:02:21 -05:00
Matthew DeNapoli
dc81a3b856 added in method to handle new and old login methods (#47170) 2018-10-23 13:19:31 -04:00
Adam Miller
079705f8da
dnf properly gpg check local packages based on param (#47455)
* dnf properly gpg check local packages based on param

Fixes #43624

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-10-23 11:41:27 -05:00
Adam Miller
0e3e646189
don't restrict disable_excludes choices incorrectly (#47453)
* don't restrict disable_excludes choices incorrectly

Fixes #47085

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-10-23 11:39:55 -05:00
Matt Martz
f6ecdf0b87
Handle sets differently than lists in wrap_var. Fixes #47372 (#47510) 2018-10-23 11:18:21 -05:00
Matt Martz
d5e4f37ca0
Ensure we don't overwrite roles from include/import_role when loading the play (#47512)
* Ensure we don't overwrite roles from include/import_role when loading the play. Fixes #47454

* Add changelog fragment
2018-10-23 11:08:48 -05:00
Francisco Gray
8c456d8e38 - Moved data sanitization logic so it is no longer conditionally applied (#41405) 2018-10-23 09:38:52 -04:00
Dan
dcb35c4270 Fix nxos_ospf_vrf module auto-cost idempotency and module check mode (#47190)
* fixing idempotency and check mode

* modified to avoid repetitive code
2018-10-23 14:28:24 +05:30
Joey
6629f153d2 Fix minor typos (#47381) 2018-10-23 03:25:44 -04:00
Will Thames
00ccad9764 Use kubeconfig if either context or kubeconfig is set (#47373)
kubeconfig should be loaded if *either* or both of context
or kubeconfig is set (this allows picking a context and default
kubeconfig or picking a kubeconfig with default context)

Fixes #47149
2018-10-23 07:53:22 +01:00
Felix Fontein
a11073df9a docker_image: allow to delete image by ID (#47393)
* Allow to delete docker image by ID.

* Added changelog.
2018-10-23 07:52:36 +01:00
Felix Fontein
4ffe3b14d4 docker_container: warn if ipvX_address is used for networks but not supported by docker-py (#47395)
* Only add parameters which are actually used.

* Fail if ipvX_address is used when not supported.

* Added changelog.
2018-10-23 07:52:08 +01:00
Felix Fontein
3afdb28209 docker_container: fix interaction of detach:no with auto_remove:yes (#47396)
* Behave better if auto_remove and output_logs are combined. Warn if output cannot be retrieved because of auto_remove.

* Add tests.

* Added changelog.
2018-10-23 07:51:24 +01:00
Dave Bendit
29b4b36501 Adding "internal" option to "docker_network" module (#35370)
Fixes #27065
2018-10-23 07:49:26 +01:00
Felix Fontein
8ef994fbc5 Fix option change detection / force support for docker_volume. (#47390) 2018-10-23 07:48:09 +01:00
Abhijeet Kasurde
6e5233b785
VMware: change type of state in vmware_host_ipv6 (#47362)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-23 11:37:34 +05:30
Valentin
2939f68897 Fix #33045: get existing network via inspect_network (Rebased #33048) (#43997) 2018-10-23 01:14:51 -04:00
Nijin Ashok
bc741eb2a0 ovirt_vm: Fix issue in setting the custom_compatibility_version to NULL
Currently there is no way to reset the custom_compatibility_version to
NULL. If we provide a empty string('') to custom_compatibility_version,
it will fail with error "IndexError: list index out of range" at _get_minor
function.

To reset the custom_compatibility_version, we have to pass None value to
types.Version. The PR fixes the same.
2018-10-22 21:12:08 -07:00
Ted Timmons
a0f58fa2ef AWS: docfix: spelling (#47443)
Fix spelling from paramaters to parameters
2018-10-23 09:36:39 +05:30
Toshio Kuratomi
ccabc2bff5 Revert "[stable-2.7] Handle sets differently than lists in wrap_var. Fixes #47372."
This reverts commit 0e933f76ba4edb0e06f0779f5fb4b0ea85191e8b.

The tests for this were broken on centos6 because jinja2 does not have
a map filter on that platform.  Tests need to be rewritten
2018-10-22 21:00:15 -07:00
Toshio Kuratomi
9088671c4e Fix python3 problem in user module cve fix 2018-10-22 18:31:57 -07:00
Jordan Borean
d46d92eed5
Revert "WinRM/PSRP: Fix UTF-8 issue (#46998)" (#47447)
This reverts commit 1bb674034f.
2018-10-23 09:10:28 +10:00
Zhikang Zhang
b697da39c8 Fix problem where pip module cannot accept multiple extras
PR #46937
Fixes #46519
2018-10-22 22:21:45 +02:00
Jocelyn Jaubert
7ec49d7472 interfaces_file: Add support for address_family 2018-10-22 20:51:59 +02:00
Martin Krizek
a0aa53d1a1 user: do not pass ssh_key_passphrase on cmdline
CVE-2018-16837

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2018-10-22 14:00:55 -04:00
Peter Sprygada
9180d2c7f2 escape default prompt detection in telnet action plugin (#46573)
This change fixes an issue with the default prompt handling.  The value
needs to be escaped otherwise it does not work when converted to bytes.
2018-10-22 13:59:10 -04:00
Peter Sprygada
299a5e4af3 fix error checking if netns exists (#47397)
This patch fixes an error that occurs when attempting to see if the
netns already exists on the remote device.  This change will now execute
`ip netns list` and check if the desired namespace is in the output.

Signed-off-by: Peter Sprygada <psprygada@ansible.com>
2018-10-22 13:58:48 -04:00
Thomas (TJ) Zimmerman
a66d5ccf03 Fixed spelling error
<!--- Your description here -->

+label: docsite_pr
2018-10-22 19:00:53 +02:00
Matt Martz
c58de75f38 Handle sets differently than lists in wrap_var. Fixes #47372 2018-10-22 11:56:28 -04:00
Pablo
6497049f2a Fix exception when including tasks from handlers (#47307)
Set _notified_handlers for the task's _uuid that is run as a handler

Fix #47287
2018-10-22 10:46:36 -05:00
Ganesh Nalawade
335a979f1d
Fix prompt mismatch issue for ios (#47004)
* Fix prompt mismatch issue for ios

Fixes #40884 #44463

*  If the command prompt is matched check if data is
   still pending to be read from buffer.
*  This fix adds a new timer `buffer_read_timeout`
   which will be trigerred after command prompt
   is matched and data is attempted to be read from channel.
   If not data is present of channel the timer will expire
   and response we be returned to calling function.

* Fix unit test failure

* Update to make buffer timeout float

* Update doc and fix review comment

* Fix CI issues

* Update doc

* Fix review comments

* Fix review comments
2018-10-22 21:05:15 +05:30
Sloane Hertel
c58c0b8547 [aws] Fix check mode bug in ec2_key (#45320)
Fix incorrect ec2_key check-mode behavior when a key already exists and key_material has been provided
2018-10-22 09:28:07 -04:00
Jonathan Oddy
7ba09adee1 Fix AWS EC2 inventory plugin caching of groups (#46961)
* Fix AWS EC2 inventory plugin caching of groups

* Added changelog fragment for aws_ec2 caching fix

* Store the AWS query results

The underlying inventory object contains inventory from other sources,
so caching it as ours would be wrong.
It seems easiest and safest to just cache the boto query results
instead.

* Remove unused functions
2018-10-22 09:15:27 -04:00
Trishna Guha
9c81634c77
nxos_file_copy fix for binary files (#46822)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-10-22 15:41:18 +05:30
cahlchang
6bd4665c4e add ec2_instance example docs (#47386)
* add ec2_instance example docs

* duplicate text
2018-10-22 08:11:31 +10:00
jfpanisset
fc516633a2 refresh_inventory doc typo (#47402)
Fix  typo in example for usage of refresh_inventory meta task
2018-10-22 07:59:24 +10:00
Dag Wieers
1bb674034f WinRM/PSRP: Fix UTF-8 issue (#46998)
* WinRM/PSRP: Fix UTF-8 issue

* added changelog fragment
2018-10-22 06:59:53 +10:00
Abhijeet Kasurde
cf2af97b78 rabbitmq_plugin: refactor logic (#46597)
* Docs update
* Example update
* Refactor logic

Fixes: #29196

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-21 16:14:25 -04:00
Dag Wieers
6f9c6071e5 psexec: Handle socket errors (Connection timeout) (#47201)
* psexec: Handle socket errors (Connection timeout)

This ensures we get a nicer error message from psexec.

* Add changelog fragment
2018-10-22 05:32:06 +10:00
Vipul Kanade
06d23019e7 VMware: Add check for timezone variable (windows customization) (#47135)
* vmware_guest.py: check if value for windows customization with timezone is integer, before proceeding.
2018-10-20 21:35:48 +05:30
Petr Ruzicka
0bb3205dee with_items should not be used any more - using loop instead (#47363) 2018-10-19 12:32:58 -07:00
hansmi
6c612c9e6c gluster_volume: Avoid error when deleting non-existent volume (#42097)
When a non-existent Gluster volume is to be deleted, i.e.:

  gluster_volume:
    state: absent
    name: vol1-does-not-exist

the "gluster_volume" module would always fail with "volume not found
vol1-does-not-exist". The reason is that the code checked whether the
state is "delete", a value which isn't accepted for the "state"
parameter. Instead the expected value for volume deletion is, as above,
"absent".
2018-10-19 15:16:05 -04:00
Eric Coulter
bc5af5a775 Update documentation for marker (#47292)
Using blockinfile with a custom marker lacking {mark} results in non-idempotency - block is repeatedly inserted on subsequent playbook runs. 

+label: docsite_pr
2018-10-19 14:31:03 -04:00
Martin Krizek
e8b6864e21 yum/dnf: fail when space separated string of names (#47109)
* yum/dnf: fail when space separated string of names

* Groups allow spaces in names
2018-10-19 14:29:27 -04:00
flowerysong
c21f92f8f7 Fix yum/dnf lock file polling (#47250) 2018-10-19 14:18:09 -04:00
Christian Kotte
c50a69c2eb VMware: New module vmware_host_powermgmt_policy (#46688)
* New module vmware_host_powermgmt_policy
* minor changes

Signed-off-by: Christian Kotte <christian.kotte@gmx.de>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-19 23:15:43 +05:30
Christian Kotte
cd988f645a VMware: New module vmware_host_ipv6 (#47275)
* New module vmware_host_ipv6
* Minor changes

Signed-off-by: Christian Kotte <christian.kotte@gmx.de>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-19 22:34:17 +05:30
Petr Ruzicka
6cd17401ec with_items should not be used any more - using loop instead (#47294) 2018-10-19 12:43:00 -04:00
Carsten Koester
04d3693e1f os_user_role: Include domain parameter in user lookup (#42913)
If a "domain" parameter is provided, use it in looking up the user ID.

Additionally, if both a domain and project parameter are provided, then
remove the domain ID from the list of filter criteria after having used
it to look up both the user and the project. OpenStack will not allow us
to apply both a project ID (which implies a domain) and a domain ID as a
search filter.

Fixes #42911
2018-10-19 12:16:19 -04:00
Christian Kotte
ea42ec7e90 VMware: Improve module vcenter folder (#46497)
* Add datacenter_name alias
* Improve vcenter_folder module
* add check mode support
* fix VM folder deletion
* fix folder deletion under parent folder
* fix (host) folder creation if two datacenters are present
2018-10-19 21:15:58 +05:30
Matt Clay
c24c19594e
Enable pylint rules and fix exposed bugs. (#47219)
* Resolve invalid-unary-operand-type.

* Resolve raising-format-tuple.

* Resolve stop-iteration-return.

* Use disable comment instead of fixing logic.

The affected line in _find_address_range will only fail on Python 3.7
and later if the function is called with an empty address list. As an
internal method it is never called in this way, making it a non-issue
for use via public methods.

Using a comment to disable the rule in favor of an ignore.txt entry
since there are no plans to change the logic in the code itself. This
will also prevent any potential future issues being added in other
parts of the code when updating it based on upstream changes.
2018-10-19 08:32:52 -07:00
Daniel Shepherd
c67ab296bb pamd: add delete=False to NamedTemporaryFile() (#47281)
* add delete=False to NamedTemporaryFile and remove print statement from module

* add changelog fragment
2018-10-19 10:46:47 -04:00
Joey
c5a9b6acb7 Fix minor typos on variable names (#47165) 2018-10-19 10:44:34 -04:00
Allyson Bowles
21859c06b9 Add output for skipped tasks 2018-10-19 10:38:29 -04:00
Allyson Bowles
219f1b8380 Display output for loops on 'ok' result 2018-10-19 10:38:29 -04:00
Christian Kotte
dc2eb05491 VMware: Add check mode support to vmware_vmkernel_facts (#47286) 2018-10-19 19:24:34 +05:30
Abhijeet Kasurde
a47b055ac7 Update profile_tasks docs (#46690)
Added configuration settings to enable profile_tasks via ansible.cfg

Fixes: #44555

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-19 08:19:57 -05:00
Ondra Machacek
b177aff41b ovirt_vm: Fix initialization of cloud init (#47348)
Fixes: https://github.com/ansible/ansible/issues/45900

This PR fixes the case when the cloud_init_persist was used, but we
still sent use_cloud_init=False, which is in oVirt API evaluated as not
to use cloud_init in first VM execution. This patch is changing it to
send just None, instead of False.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
2018-10-19 09:13:29 -04:00
Eugene Zvyagintsev
4c2efa4b67 Documentation for docker_container: fix documentation for memory_swappiness. Default value will not equal 0, it will be inherited from the host machine (#47296) 2018-10-19 06:12:28 -04:00
Pluggi
f13091d142 Add runtime option to docker_container module (#47247)
* Add runtime option to docker_container module

Signed-off-by: Antoine Bardoux <abardoux@nvidia.com>

* Add changelog fragment

Signed-off-by: Antoine Bardoux <abardoux@nvidia.com>

* Add idempotency test for docker_container.runtime

Signed-off-by: Antoine Bardoux <abardoux@nvidia.com>
2018-10-19 09:04:17 +01:00
richardlock
39f3984ce4 azure_rm_cdnprofile: Add 'standard_microsoft' to sku (#47309)
##### SUMMARY
The azure_rm_cdnprofile module was missing a valid sku 'standard_microsoft'.  Added it to the list of valid choices.

##### ISSUE TYPE
- Bugfix Pull Request

##### COMPONENT NAME
azure_rm_cdnprofile

##### ANSIBLE VERSION
```
ansible 2.8.0.dev0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]
```

##### ADDITIONAL INFORMATION
It was not possible to deploy using the 'standard_microsoft' sku previously.  This addition allows this.
2018-10-19 15:30:21 +08:00
Nijin Ashok
29c76c5a93 ovirt_vm: Add option to export the VMs (#47113)
The commit adds the feature to export the VM to export domain and as
OVA.
2018-10-19 03:29:37 -04:00
Nijin Ashok
c5d0461561 ovirt_vm: Fix issue in SSO option (#47312)
Currently the module will disable the SSO if we didn't pass any
value for SSO option. The PR fixes the same.
2018-10-19 03:28:36 -04:00
Zim Kalinowski
b0c88ddab1
Adding postgresql firewall rule facts (#45078)
* adding postgresql firewall rule facts

* fixed sanity

* fixed sanity

* updating tests

* firewall rule facts updated

* fixed test

* fix crash

* small updates

* updated postgresql firewall rule

* removed unnecessary type

* fixed postgresql facts

* fixed azure

* one more fix

* test fixes

* fix class name
2018-10-19 15:13:45 +08:00
Jordan Borean
013c44484a psexec: better error on import failure (#47327) 2018-10-19 08:56:16 +02:00
Dag Wieers
e758f69ce3 win_domain: Add missing functionality (#46552)
* win_domain: Add missing functionality

* Fix typo: Treshold -> Threshold

* Improvements based on feedback

* moved mode checks to after pre-reqs are installed
2018-10-19 13:18:52 +10:00
Abhijeet Kasurde
bfc3ca1da1 Remove extra parameter in format_exc (#46251)
`traceback.format_exc()` does not take any argument, this fix remove
such occurances.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-18 21:50:58 -04:00
Claude Dioudonnat
42730cffc4 Fix get_fs_size for LVM filesystem 2018-10-19 01:20:33 +02:00
Baptiste Mille-Mathias
3f8a0f6657 Use syntax loop instead of with_items in example (#47241) 2018-10-18 17:55:19 -05:00
Baptiste Mille-Mathias
bac43eebe0 Use loop instead of obsolete with_items in example (#47246) 2018-10-18 17:54:07 -05:00
Martin Krizek
541255a2d8
Do not strip new lines in native jinja (#46751)
* Do not strip new lines in native jinja

* Add changelog/fragment
2018-10-19 00:14:43 +02:00
Baptiste Mille-Mathias
65bb6a5af3 Use loop instead of with_items in examples (#47318) 2018-10-18 17:14:50 -04:00
Baptiste Mille-Mathias
0b9c033abe Use loop instead of with_items in examples (#47319)
with_items is deprecated
2018-10-18 17:14:35 -04:00
Matt Clay
37b013aca3
Enable additional pylint rules and resolve issues found. (#47221)
* Resolve unneeded-not.
* Resolve global-at-module-level.
* Resolve useless-import-alias.
* Resolve bad-whitespace.
* Resolve global-variable-not-assigned.
* Resolve logging-not-lazy.
* Resolve comparison-with-itself.
2018-10-18 13:38:08 -07:00
Matt Martz
77d32b8f57
Don't use the task for a cache, return a special cache var (#47243)
* Don't use task to cache loop results, use hostvars. Fixes #47207

* Avoid a race condition, supply _ansible_loop_cache through get_vars directly

* Add tests

* Add changelog fragment

* Remove unnecessary copy

* Remove unnecessary host from _get_delegated_vars signature
2018-10-18 15:25:43 -05:00
Sean Cavanaugh
81d22dc304 adding additional example and clarification (#47224)
The kind: paramter is missing from the original example (which won't actually work).  The organization needs to be listed as required (if you don't list it, you will get an error).  Also adding additional example using the tower_username and tower_password method.
2018-10-18 16:21:35 -04:00
John Imison
c809560385 Minor documentation fix. (#47276) 2018-10-18 16:19:45 -04:00
Matt Martz
19416a1343 Fix versions in module.deprecate call to align with module deprecation. Fixes #45035 #45034 (#47211) 2018-10-18 15:30:22 -04:00
Nathaniel Case
7844a40046
Update some cliconf plugins (#47141)
* Add `check_all` to many community cliconf plugins
2018-10-18 15:26:20 -04:00
Martin Krizek
096717edc5 ansible-galaxy: fix searching with unicode 2018-10-18 14:59:03 -04:00
Dag Wieers
06eabc9783 reboot: Add timeout in error to help troubleshooting (#47216)
* reboot: Add timeout in error to help troubleshooting

So we've been hit by 'Timed out waiting for boot_time check' and it was
unclear what timeout was used for the boot_time check. By adding the
timeout value it is easier to understand the used value, and verify if a
change to the timeout is reflected in the output.

* Add changelog fragment
2018-10-18 14:42:39 -04:00
Nathaniel Case
3feb6c9e0f
Try to be more verbose with JSON decode errors (#47066)
* Try to be more verbose with JSON decode errors
2018-10-18 12:09:00 -04:00
Toshio Kuratomi
bcd6dbcd65 Remove get_exception from the remainder of the modules 2018-10-18 08:37:04 -07:00
Ryan Brown
18a088c64e
GCP MagicModules bug fixes (#47285)
Closes: #46930 #46929 #46928 #46927 #46926 #46925 #46924 #46923 #46922 #46921 #46920 #46919 #46918 #46917 #46916 #46915 #46914 #46913 #46912 #46911 #46910 #46909 #46908 #46907 #46906 #46905 #46903 #46902 #46901 #46900 #46899 #46898 #46897 #46896 #46895 #46894 #46893 #46892 #46891 #46890 #46889 #46888 #46887 #46886 #46885 #46884 #46883 #46882 #46881 #46880 #46879 #46878 #46877 #46876 #46875 #46874 #46873 #46872 #46871 #46870 #46869 #46868 #46867 #46866 #46865 #46864 #46863 #46862 #46861 #46860 #46859 #46858 #46857 #46856 #46855 #46854 #46853 #46852
2018-10-18 10:55:42 -04:00
Nate Borener
3b5471a734 get_url: Updates documentation for proper use of headers (#47242)
* Fixes the example for headers in documentation

* remove whitespace

* missed a whitespace
2018-10-18 09:47:27 -05:00
flowerysong
0fc639e755 ec2_tag: Fix removing tags without specifying a value (#47228) 2018-10-18 10:13:08 -04:00
Alex Stephen
3f629c426c New GCP Module: gcp_compute_region_disk (#46886) 2018-10-18 10:08:14 -04:00
Alex Stephen
bd62da4e64 New GCP Module: gcp_compute_region_disk_facts (#46887) 2018-10-18 10:06:45 -04:00
Alex Stephen
437f8622d4 New GCP Module: gcp_dns_managed_zone_facts (#46917) 2018-10-18 10:06:14 -04:00
Alex Stephen
b6c99619e4 New GCP Module: gcp_dns_resource_record_set_facts (#46919) 2018-10-18 10:04:01 -04:00
Alex Stephen
aba8ebbbf8 New GCP Module: gcp_pubsub_subscription_facts (#46921) 2018-10-18 10:03:28 -04:00
Alex Stephen
f47cfd2204 New GCP Module: gcp_pubsub_topic_facts (#46923) 2018-10-18 10:01:31 -04:00
Felix Fontein
89f239f187 Fixup of #47046. (#47274) 2018-10-18 14:50:26 +01:00
Ondra Machacek
03bccdda92 ovirt_vm: Check next_run configuration update if exist (#47280)
This PR fixes the update check method so it now check also the next_run
configuration of the virtual machine if it exists.

So if previously the VM was updated with new parameters, and then reset
back, the module didn't set the parameters to be set back in next_run.
This PR fixes it so the next run configuration is set back with proper
parameters.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1639894
Signed-off-by: Ondra Machacek <omachace@redhat.com>
2018-10-18 08:41:54 -04:00
bverschueren
8a671f54dd ovirt_host_network: check for empty user_opts (#46695) 2018-10-18 08:25:54 -04:00
Felix Fontein
32e8251f86 docker_* modules: unify docker module version checks (#47046)
* Unify docker module version checks.

* Improve messages depending on required docker-py versions.

* Linting.
2018-10-18 10:51:58 +01:00
jerrejkw
44044f969d VMware: Add timeout parameter for vmware module vsphere_copy (#46762)
* Enhancement: add timeout parameter for vmware module vsphere_copy
2018-10-18 15:07:39 +05:30
Nicolas Bock
b3dd36bef8 Fix documentation (#47218)
The result variable is `openstack_image` and not `openstack` as incorrectly stated in the description.

+label: docsite_pr
2018-10-18 17:00:08 +10:00
Matt Martz
90d2620939 Remove deprecated os_server_actions alias (#47208)
* Remove deprecated os_server_actions alias. Fixes #44991

* Skip os_server_actions
2018-10-18 16:44:44 +10:00
Jonathan Davila
d3be4f75ca pamd: use module.tmpdir for NamedTemporaryFile() (#47133) 2018-10-18 16:09:07 +10:00
Shuang Wang
0c6513e9b1 add module aws_codecommit to represent AWS CodeCommit (#46161)
* kick off

* done for the day

* beta code and test

* fix a typo

* boto3_conn and boto_exception aren't used in this code, ec2_argument_spec is used but unneeded.

* Returning when find a match avoids doing extra work, especially when pagination is involved

* add new permissions for test

* (output is changed) is preferred over accessing the attribute directly.

* pass the result through camel_dict_to_snake_dict() before returning it.

* AnsibleAWSModule automatically merges the argument_spec.

* deletes the created resources even if a test fails.

* AnsibleAWSModule automatically merges the argument_spec.

* fix typo

* fix pep8

* paginate list_repositories

* specify permissions for test

* cut the unnecessary code.

* add return doc string

* add missed ':'

* fix syntax error: mapping values are not allowed here

* add description for return

* fix syntax error

* rename module name and turn off automated integration test.
2018-10-18 14:32:06 +10:00
Yuwei Zhou
9258ffa478 Fix auto scale create with fix date without recurrence (#47186)
* Fix auto scale create with fix date without  recurrence

* fix indent
2018-10-18 10:52:30 +08:00
Michael Scherer
1be69cd69c Clean up of docker swarm service (#45525)
* Remove redundant assignation of variable

Found with https://lgtm.com/

* Fix check_mode when force_update is used
2018-10-17 17:29:47 -04:00
Stanislas
9cc9ca584a Implement snap packaging module
PR #44939

Fixes #39155
Closes #40852

Co-authored-by: Victor Carceler <vcarceler@iespuigcastellar.xeill.net>
Co-authored-by: Stanislas Lange <angristan@pm.me>
Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
2018-10-17 22:59:41 +02:00
Loïc
a661b5f825 Add unsafe_perm flag (#36946) 2018-10-17 21:35:51 +01:00
nikkytub
539f0fee09 Fixed the ssl-certs in netbox plugin (#46543)
* Fixed the ssl-certs in netbox plugin

* Added validate_certs parameter and updated the example
2018-10-17 21:30:47 +01:00
Rémy Léone
8a7a819040 Add support for platform grouping (#45733) 2018-10-17 21:28:20 +01:00
Jordan Borean
6666b070a9
openss: fix various test and Python 3 issues (#47188) 2018-10-18 05:29:18 +10:00
maxstack
c11aba6ed8 [aws] New key_data argument to ec2_win_password module (#45463)
* add key_data argument

The key_data argument helps when using a private key stored in Vault.

* Add "version_added" line

Add version_added line to pass automated tests.

* remove unnecessary nesting
2018-10-17 14:01:59 -04:00
Dani Hodovic
28ba10b877 fix: Parse docker_service scale parameter to int (#45508) 2018-10-17 13:58:09 -04:00
Aaron
9c08ff7a94 [aws] New module: iam_password_policy (#36200)
* Adding iam_password_policy module

* fixing various issues -- error handling, bugs

* fixing various issues based on tests

* renaming dummy var

* fixing type reference in documentation

* adding int tests and other updates

* removing typo

* fixing auth for int tests

* removing int tests for now

* readding integration tests w/ unsupported designation

* removing conflicting group

* Update aliases

* Fix unused variable
2018-10-17 13:56:13 -04:00
Jeffrey Noehren
e685027fb8 spotinst_aws_elastigroup module: adding version to Rancher integration (#46293)
* [src] - adding version to spotinst rancher integration

* [src] - adding sdk version to docs
2018-10-17 13:45:02 -04:00
Sloane Hertel
b808e1bc5c [s3_bucket] Cast tag keys and values to text to match the values returned (#46405)
* Cast tag keys and values to text to match the values returned

* changelog
2018-10-17 13:39:52 -04:00
Chas Schley
7fd31b1da0 [docs] Include required ARN format of actions in ec2_metric_alarm (#46514)
<!--- Your description here -->

+label: docsite_pr
2018-10-17 13:39:03 -04:00
Petr Ruzicka
df57a3fc7a [aws][docs] Replace uses of now-obsolete with_items with loop (#47164) 2018-10-17 12:35:31 -04:00
Brian Scholer
2043aad582 [aws] ec2_instance: don't report changed when instance is already stopped (#46714) 2018-10-17 12:34:37 -04:00
Per-Henrik Lundblom
e744c83808 [aws] ec2_vol_facts: only access volume tags when set (#46801) 2018-10-17 12:31:31 -04:00
David González
b923bf708d [aws] Convert containerPort to int before comparing to avoid jinja2 string-int issues (#39215) (#47195) 2018-10-17 12:29:23 -04:00
Brian Coca
fce9673ac1 Adoc fixes (#47137)
* removed hardcoded loader/plugins list
* updated a few errors to keep orig object
* fix httpapi/cliconf listing
* ansible-doc fixes
* show undocumented as UNDOCUMENTEd
* added missing undoc
2018-10-17 10:48:24 -05:00
Steve Dodd
ee6ab5d5aa Add support for IOS vlan parsing filter. (#40555)
* Add support for IOS vlan parsing filter.
Example usage below:

{% set parsed_vlans = vlans | vlan_parser %}
switchport trunk allowed vlan {{ parsed_vlans[0] }}
{% for i in range (1, parsed_vlans | count) %}
switchport trunk allowed vlan add {{ parsed_vlans[i] }}

* Update test_network.py

Add import statement for filter

* Fixed PEP8 issues relating to comments

* Fix PEP8 issues related to blank lines

* Removed magic numbers for line lengths. This should generalize support
to other IOS-like NOS that use similar methods for listing vlans. The
default arguments for line lengths will still be specific to Cisco IOS.
The unit tests for line length are still specific to Cisco IOS.
2018-10-17 20:50:28 +05:30
Toshio Kuratomi
61ae6424a3 An earlier optimization of ansible-doc -l caused failures. (#47012)
* An earlier optimization of ansible-doc -l caused failures.

The optimization quickly searches the plugin code for short_description
fields and then uses that in the -l output.  The searching was a bit too
naive and ended up pulling out malformed yaml.  This caused those
plugins to be omitted from the list of plugins of that type with
a warning that their documentation strings were wrong.

This change makes the documentation parser aware that the documentation
string could have a relative indent for all of its fields which makes it
robust in the face of this particular problem.

* Don't search for space after short_description:

Any whitespace would be valid.  In particular newline
2018-10-17 11:15:59 -04:00
Ryan Merolle
b9cf09e9d5 network.py filter_plugin typo fix (#47011)
changed return_orginal to return_original in /lib/ansible/plugins/filter/network.py
2018-10-17 19:30:56 +05:30
Fran Fitzpatrick
fc341e01fa Fix junos terminal regex (#47096)
Fix junos stdout regex

Change at hing
2018-10-17 19:29:35 +05:30
Jordan Borean
dd46f953f6
postgresql_user: fix test errors on newer Fedora versions (#47166) 2018-10-17 14:01:11 +10:00
Jorgen
f1f47d9a40 Fixed typo (#47139)
<!--- fixed typo in exclude example -->

+label: docsite_pr
2018-10-17 06:14:02 +10:00
Matt Martz
02f4d0a57f
Ensure that an empty literal list with loop skips the task (#47129) 2018-10-16 13:35:10 -05:00
Mariusz Mazur
79119c62cd Correct wording in k8s module description (#47125) 2018-10-16 11:52:18 -05:00
Abhijeet Kasurde
b48526ca65
VMware: new module: vmware_guest_disk (#36165)
1. Add support for SCSI controller creation
2. Support for SCSI Type
3. Warn about Disk Unit Number 7
4. Allow specifying SCSI controller
5. Allow specifying Disk Unit Number
6. Idempotency
7. Remove disks
8. Do not allow to reduce disk
9. More than 15 disks support
10. No SCSI controller and unit number check
11. Thin support
12. Update documentation and example
13. Multiple Datastore and datastore cluster support
14. Check datatype of disk unit number and SCSI controller
15. Handle disk_size when it is int or float

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-16 18:37:20 +05:30
Fran Fitzpatrick
ab8ed2f84d Add unit tests for junos terminal (#47103) 2018-10-16 15:14:38 +05:30
Joey
c3cc2ecc5b ovirt_storage_domain: Improve logic for state controlling. (#46951) 2018-10-16 05:26:31 -04:00
Matt Hoffman
acbecd5f23 adds redirect configurations and probes to azure_rm_appgateway (#46607) 2018-10-16 10:34:24 +08:00
Wholeshoot
96db9a55e2 bigip_firewall_rule -- missing port_range (#47077)
port_range was missing from bigip_firewall_rule
2018-10-15 16:16:39 -07:00
Matt Martz
c3d5779a41
Use the copied and merged task for calculating task vars in the free strategy. Fixes #47024 (#47060) 2018-10-15 16:07:52 -05:00
Abhijeet Kasurde
871dd77f2b efs_facts: Documentation update (#46826)
* Update pydoc
* Update module documentation and example
* Add aliases for name as creation_token

Fixes: #28738

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-15 14:46:24 -04:00
Jorge Rodriguez (A.K.A. Tiriel)
150e9db568 rabbitmq_binding: Fix misnamed reference (#47049)
Fix for bug introduced in #18437
2018-10-15 23:54:27 +05:30
Zim Kalinowski
1c520ff70b adding postgresql firewall rule (#45077)
* adding postgresql firewall rule

* fixed test problems

* add state into the doc

* use lropoller

* updated samples and some naming
2018-10-15 10:17:42 -07:00
Zim Kalinowski
ca5460dd86 Adding mysql firewall rule module (#45074)
* adding mysql firewall rule

* fixed mysql firewall rule

* use mgmtclient from common

* fix pep8

* small updates

* minor docs fix
2018-10-15 10:11:26 -07:00
Shuang Wang
d302485f99 option [others] of get_url is unnecessary (#47005)
* parameters [others] of get_url is unnecessary

* delete a blank line

* test

* delete ignore

* Update get_url.py
2018-10-15 09:24:48 -05:00
Sumit Jaiswal
8a6059ad0a
revert 46677 changes (#47044) 2018-10-15 15:35:55 +05:30
Mike Healey
c73b2aa415 VMware: Added secure boot enable/disable to vmware_guest_boot_manager. (#46717)
* Added secure boot enable/disable to vmware_guest_boot_manager.  Also added its state to facts
* VMware does not support secure boot when boot_firmware is bios.  Add some guardrails to protect the user from misconfiguration
* Address review comments
2018-10-15 15:02:01 +05:30
Abhijeet Kasurde
ebeb788117
VMware: Provide facility to specify path for template (#38031)
When multiple virtual machines or templates are found in environment,
module needs folder path. This fix adds facility to specify folder path
for template or virtual machine if multiples are found.

Fixes: #37087

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-15 14:59:48 +05:30
Ganesh Nalawade
5394638047
Fix in confirmed_commit capability in netconf_config modules (#46964)
* Fix in confirmed_commit capability in netconf_config modules

Fixes #46804

*  If confirm value is greater than zero or confirm_commit option is set and confirmed-commit
   capability is not supported but Netconf server only in that case fail the module

* Update confirm-commit flag

* Minor changes
2018-10-15 11:34:35 +05:30
Sumit Jaiswal
9ddceaf78d
Fix to resolve bug 46671, which now handles checking for Nonetype connection prompt (#46677)
* added Nonetype check

* implemented review comment

* review changes
2018-10-15 11:21:06 +05:30
Christian Kotte
849912c01b VMware: Improve module vmware_host_datastore (#45652)
* Don't execute mount or umount in check mode
* The datastore was mounted or unmounted when you execute the playbook in
check mode.
* Test if running in check mode before mounting or unmounting the
datastore.
* Add support for NFS v4.1 datastores
2018-10-14 18:13:36 +05:30
Arun prasath
23b60d843e Fixes #35284 - Added ability for os_nova_flavor to update existing flavors (#37170) 2018-10-13 23:06:29 -04:00
Arun prasath
5b3e009198 Added ability to create Openstack users without password (#37338) 2018-10-13 23:04:44 -04:00
Dag Wieers
5fa51f3cd8 Add ConnectionError too 2018-10-13 21:47:13 +02:00
Dag Wieers
820f9f9c1e Move requests import into pypsrp try-block 2018-10-13 21:47:13 +02:00
Dag Wieers
6693adc9b2 WinRM/PSRP: Add support for unreachable
Currently PSRP connection always fail, even if the system is not
reachable. This PR fixes this.
2018-10-13 21:47:13 +02:00
Thomas Hughes
db304c27c7 Fix spelling issue (#46982)
Corrects spelling from `fo` to `of` for `storage_blob_name`

+label: docsite_pr
2018-10-13 09:38:07 +05:30
Matt Clay
3033fd96b0
Move unit test compat code out of lib/ansible/. (#46996)
* Move ansible.compat.tests to test/units/compat/.
* Fix unit test references to ansible.compat.tests.
* Move builtins compat to separate file.
* Fix classification of test/units/compat/ dir.
2018-10-12 20:01:14 -07:00
Sandra McCann
c44860057e update sros metadata to certified (#46981) 2018-10-12 14:48:16 -05:00
Jonathan Oddy
f2dccb90e8 Restore SIGPIPE handler to DFL on POpen
Python sets the SIGPIPE handler to SIG_IGN. On execv() signal handlers are
reset to their defaults, EXCEPT those that are SIG_IGN which are left ignored.
In Python 3 subprocess.popen explicitly resets the SIGPIPE handler to SIG_DFL,
but unfortunately in Python 2.7 it does not. This leads to subprocesses being
executed with SIGPIPE ignored. This is often a problem with bash scripts which
rely on SIGPIPE to terminate commands in a pipe, but can easily be a problem
with other applications.

This implements the Python 3 behaviour for Python 2.7 by using a preexec_fn.
2018-10-12 12:31:24 -07:00
Sandra McCann
1015c50034 update cyberark metadata to certified (#46978) 2018-10-12 13:54:48 -05:00
Sandra McCann
4513298971 Change netapp ontap and elementsw modules to certified (#46974)
* netapp ontap and elementsw modules to certified
2018-10-12 13:54:23 -05:00
Sandra McCann
f138f7019f Mark NIOS modules as certified (#46973)
* updated NIOS community modules to certified

* moved remaining nios modules to certified
2018-10-12 13:53:52 -05:00
Sandra McCann
dc3407eaeb changed F5 module metadata to certified (#46849) 2018-10-12 10:57:28 -05:00
Matt Martz
a06a5ded61
Do not use mutable defaults in FieldAttribute, instead allow supplying a callable for defaults of mutable types. Fixes #46824 (#46833) 2018-10-12 10:43:09 -05:00
Sandra McCann
0dd17b521f change UCS modules to certified (#46848) 2018-10-12 10:35:52 -05:00
Brian Coca
9e0c2a658f
better information for user from inventory plugins (#46766)
* better information for user from inventory plugins

 - use foreman as example
2018-10-12 11:27:29 -04:00
Brian Coca
a5bd84758a simpler/shorter option names for user
- internally we can keep long names, but user should not require extra typing
2018-10-12 11:23:42 -04:00
Brian Coca
3453dace85
use to_text instead of str in async_status (#45990)
* use to_text instead of str in async_status

* used to_native instead as per feedback
2018-10-12 10:04:37 -04:00
Brian Coca
643ff29d2d
use ansible json encoder for results in callbacks (#46830)
* use ansible json encoder for results in callbacks
2018-10-12 09:37:56 -04:00
Christian Kotte
ade5d938c3 VMware: Improve module vmware_host_config_manager (#46264)
* Improve module description
* Add check mode support and change message
2018-10-12 15:16:12 +05:30
Gustavo Muniz do Carmo
739a129322 ldap_attr: typecast values to list (#46818)
Adding a value to an attribute or removing a value from an attribute of a LDAP entry throws the exception TypeError: object of type 'filter' has no len()
2018-10-12 15:06:06 +05:30
Will Thames
b772485d97 Ensure that k8s_facts always returns resources key (#46733)
Fix bug returning `items` key if NotFound exception is hit
2018-10-12 05:11:48 -04:00
Alb0t
e2b9c36080 Add Alibaba to RedHat family list. (#46828) 2018-10-12 10:23:03 +02:00
Matt Davis
3e18bbec34 remove cross-module imports
* duplicated code instead; use module_utils if code-sharing needs increase
2018-10-11 19:54:54 -07:00
Shuang Wang
761f99a4e3 add sample for follow parameter of copy.py (#45765)
* add sample for follow parameter of copy.py
2018-10-11 18:48:54 -07:00
Sandra McCann
e43869cca9 mark Cisco ACI modules certified (#46842) 2018-10-11 15:35:12 -05:00
Sandra McCann
6479cb6a4a mark Cisco ACI modules as certified (#46841) 2018-10-11 15:34:35 -05:00
Alicia Cozine
e601521708 all amazon modules are community maintained (#46840) 2018-10-11 15:38:54 -04:00
Alicia Cozine
561a5b1adc all azure modules are community maintained (#46839) 2018-10-11 15:37:42 -04:00
cahlchang
1cce11b39c [AWS] Support check mode in aws ec2_instance module (#46774)
* fix checkmode

* Added checking test to existing test playbook

* Added test for check mode
2018-10-11 14:21:01 -04:00
Jose Delarosa
81640a2c67 Provide flexibility when retrieving facts (#46148)
* Provide flexibility when retrieving facts

* Check if keys exist before trying to read
2018-10-11 14:17:13 -04:00
Justin England
0bc5b799a6 Update win_scheduled_task.py (#46720)
* Update win_scheduled_task.py to document that the duration of a task trigger can be null, which will cause it to run indefinitely - docs update makes use of suboptions

* Add a fix for the validate-modules schema
2018-10-11 13:16:25 -05:00
Adam Miller
fd97c8e56c
fix yum proxy username/password handling (#46291)
Fixes #46249

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-10-11 12:51:40 -05:00
Peter Oliver
40fb992a6f Locate prtdiag even when absent from /usr/bin (#44113)
* Locate prtdiag even when absent from /usr/bin

On Solaris 8 hosts, this prevents fact collection from aborting with:

    Argument 'args' to run_command must be list or string

* Lint fix.

* Style: pass /usr/platform/.../sbin as optional path to get_bin_path().
2018-10-11 13:41:06 -04:00
Rémy Léone
46ed120778 Fix scaleway_compute dynamic_ip_required (#46256) 2018-10-11 18:28:16 +01:00
Rémy Léone
faf262977e Add virtualization devices in the inventory (#45728) 2018-10-11 18:09:01 +01:00
Rémy Léone
a8925484c9 Use constructable with NetBox dynamic inventory (#45913) 2018-10-11 18:01:29 +01:00
Brian Coca
b2ac745461 add note to inform awx team on change 2018-10-11 12:45:53 -04:00
Sloane Hertel
f3d5ebb355 add more consistent extension matching for inventory plugins (#46786)
* Add consistent extension matching for inventory plugins that support YAML configuration files

* Document extension matching expectations
2018-10-11 11:06:52 -05:00
Brian Coca
e3882ad6f6
added friendlier aliases for auth options (#46816)
* added friendlier aliases for auth options
2018-10-11 11:34:41 -04:00
Shuang Wang
cd1faca6e0 copy - support recursive copying with remote_src (#43998)
* Allow copy module to work with recursive and remote_src #14131
2018-10-11 08:18:44 -07:00
Adam Miller
fb6e91bf98
yum module properly check for None config_file (#46641)
* yum module properly check for None config_file
* add conf_file test cases to yum integration tests

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-10-11 10:11:34 -05:00
Anil Kumar Muraleedharan
d0e89bc1bb Lenovo finetune modules (#46623)
* Making username password etc non mandatory as we use persistence connection.
Some documentation fine tuning also done.

* To update version which was tested against.

* Adding Bacon switch (NE0152T) to device rules

* Qalthos Review catch

* Updating version

* Changing documentation to add Bacon switch. This is effective since 2.8
2018-10-11 09:49:49 -04:00
Johannes Brunswicker
b3063e37be Convert results with to_native in consul_kv plugin (#46551)
* #42851 convert results with to_native

* added missing ANSIBLE_METADATA

* removed unneeded brackets

* * replaced to_native with to_text to avoid getting bytecode
2018-10-11 09:35:49 -04:00
markafarrell
4c169a1a6d Enable HTTP Authentication for url lookup (#43467)
* Add url_username and url_password options for url lookup

* Update url.py

Fix documentation

* Fix options documentation 

Default value for url_password and url_username is None not an empty string

* Add version added to documentation

* Break command over multiple lines to fix linting

* Fix more linting

* Update version_added in url.py to 2.8
2018-10-11 09:30:56 -04:00
dangoscomb
fb72a5424c nmcli: fix vlan connection modification Fixes #42322 (#42415)
* ensure optional items are set to empty strings rather than not presented
fix syntax of vlan modification command

* extended tests for nmcli
2018-10-11 07:52:18 -04:00
Christian Kotte
2230f40041 VMware: Add check mode support to module vmware_host_firewall_manager (#46266) 2018-10-11 15:54:30 +05:30
Christian Kotte
0bc2e6795d VMware: Gather extended datastore facts (#46546)
* Add datacenter_name alias
* Add check mode support
* Add extended datastore information
2018-10-11 15:52:30 +05:30
Scott Xu
db69f46cf9 Update nso_action.py (#46763)
* Update nso_action.py

The module's name should be nso_action.

* Update nso_action.py

Fixed the input field in the example.
2018-10-11 14:07:59 +10:00
Adam Miller
ad405fc21e yum module handle list optional empty strings properly (#46634)
Fixes #46517

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-10-10 18:49:24 -04:00
José R Cordones
d3cc2f803a Update eos_config.py (#45810)
Switches will accept the previously used syntax for /32 ACL entries, but they get changed to host ipaddress in the config file.
This results in the config check failing every time (permit ip 1.1.1.1/32 any log != permit ip host 1.1.1.1 any log), resulting in the ACL getting re-created on every single run of the Playbook.
Making this proposed change to the example will make it work in an idempotent manner.
+label: docsite_pr
2018-10-10 16:47:11 -04:00
Brian Coca
8743e6ae2e remove default from delegate_facts to inherit (#45492)
* remove default from delegate_facts to inherit

fixes #45456

* test delegate_facts

* added note about inheritance and defaults

* yamllint
2018-10-10 15:10:23 -04:00
Ganesh Nalawade
58aaf53271
Fix netconf module_utils dict changed size issue (#46778)
Fixes #46755

Use list() to copy the keys of attribute dict
while iterating over attribute dict.
2018-10-11 00:01:17 +05:30
Abhijeet Kasurde
32397531d0
lambda: fix unboundLocalError in lambda (#46729)
This fix initializes current_version to None so that
module proceeds in check mode.

Fixes: #46654

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-10 22:57:58 +05:30
Brian Coca
80d977bac6
manage levels for 'multiple included lists' (#46359)
* manage levels for 'multiple included lists'

fixes #46343
2018-10-10 12:34:58 -04:00
akatch
878599fd9f Do not append msg to verbose tasks (#46721) 2018-10-10 12:11:43 -04:00
anasbadaha
2c24cfb401 Add support for IGMP interfaces on onyx switches (#46218)
Signed-off-by: Anas Badaha <anasb@ufm-host08-004.mtr.labs.mlnx>
2018-10-10 11:42:47 -04:00
gardouille
0d824ad777 Add xz-utils requirement (#46159)
* Document xz-utils requirement for deb parameter of apt module
2018-10-10 09:45:58 -05:00
Abhijeet Kasurde
d76a84a6c8 [do
* Add U() in front of URL
* Add period at end of statement
* Spell check

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-10 10:44:17 -04:00
Dominik Holler
452a4ab781 Fix os_router ignores enable_snat: no (#45921)
If enable_snat is False, this should be used to build the
request, because the default value in the OpenStack Networking
API is True.

Fixes the issue #45915.
2018-10-10 10:01:45 -04:00
Abhijeet Kasurde
5351a00445 Correct usage of message in ConnectionError (#46566)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-10 19:21:20 +05:30
Paul Neumann
39673dfc37 ios_facts: Fix minor aesthetical glitches (#46577)
* ios_facts: Fix LLDP gathering without neighbors

When LLDP is enabled but no neighbors are present, the following
structure is generated:
...
            "ansible_net_neighbors": {
                "null": [
                    {
                        "host": null,
                        "port": null
                    }
                ]
            },
...
If we are not able to find any relevant LLDP information, bail out early
so cases like shown above are handled more gracefully.

* ios_facts: Remove trailing space in lineprotocol

Some Cisco devices (at least CSR1000V 16.6.4) add a space after the
line protocol. This causes the space to be present in the result of
fact gathering:
            "ansible_net_interfaces": {
                "GigabitEthernet2": {
...
                    "lineprotocol": "up ",

Be more clear about scanning the output to avoid this behaviour.
2018-10-10 08:02:14 -04:00
Sebastien Pouplin
4ba0cfeb4b Added iostype details in network ios_facts module (#46599) 2018-10-10 08:00:25 -04:00
Thomas Picariello
62d131716b Do not try to encode metadata if it is None (#46739)
* Do not try to encode metadata if it is None

* Add changelog fragment

* Fix fragment missing EOF line
2018-10-10 12:14:47 +02:00
AndyG
fcef4fdb26 ec2_asg: adding explanation of replace_all_instances (#46694)
* adding explanation of replace_all_instances

How does "replace_all_instances" work? does it increase the number of instances by 1 in the Load balancer and it scales in a server and waits for it to complete its health check, OR   does it terminate a node a that causes an autoscale event to happen and then adds a new server?
+label: docsite_pr
2018-10-10 19:59:27 +10:00
Jorge Rodriguez (A.K.A. Tiriel)
e7ddff1928 Rabbitmq: Enable communication to management API over HTTPS (#18437)
* Enable communication to management API over HTTPS.
* Specify version added tags to new parameters
* Set proper parameter type.
* Corrected version_added numbers.
* Extracted commons to ansible utils.
* Fix PEP8 error
* Fix documentation extension syntax.

Fixes #22953
2018-10-10 09:55:08 +05:30
Nick
5e67981dd2 fix: check execute_lock boolean, not lock string var (#45329) 2018-10-09 22:46:00 -04:00
bjakubiak
e50de2c35f Fixes #23456 (#35171) 2018-10-09 19:04:51 -04:00
Eitan Adler
063a9dd911 Reduce noise in warnings from ansible (#40754)
When python is compiled in debug mode, or certain command line flags are
passed, python issues helpful warnings to let users know of files opened
by not closed.

This can be fairly spammy on an ansible run.  This change reduces the
number of such warnings by a factor of 10.
2018-10-09 18:53:03 -04:00
Joey
3c7a503a53 ovirt_storage_domain: Fix error message formating (#46678) 2018-10-09 10:01:05 -04:00
lwm
8d0f823de0 Add a Linode v4 dynamic inventory plugin. (#45902)
* Add a Linode v4 dynamic inventory plugin.

Closes https://github.com/ansible/ansible/issues/44721.

* Use the latest API for accessing host variables.

References:

  * https://github.com/linode/linode_api4-python/issues/141

* Minor docs formating
2018-10-09 12:54:31 +01:00
Ondra Machacek
23c2dc3b2a ovirt_disk: Add wipe_after_delete option (#46679) 2018-10-09 06:05:11 -04:00
Cyril Jouve
05ca828619 create sources.list.d directory if needed (#36981) 2018-10-08 18:35:05 -04:00
Pilou
955579cd72 rabbitmq_user: 'node' parameter: add default value (#38156)
* Remove unnecessary workaround

* add test: set RABBITMQ_NODENAME environment variable

The following error occurs:

  TASK [rabbitmq_user : Add user] ***
  fatal: [testhost]: FAILED! => {
    "changed": false,
    "cmd": "/usr/sbin/rabbitmqctl -q list_users",
    "rc": 69,
    "msg": "Error:********@c65c2bc59398'. Please see diagnostics information and suggestions below.\n\nMost common reasons for this are:\n\n * Target node is unreachable (e.g. due to hostname resolution, TCP connection or firewall issues)\n * CLI tool fails to authenticate with the server (e.g. due to CLI tool's Erlang cookie not matching that of the server)\n * Target node is not running\n\nIn addition to the diagnostics info below:\n\n * See the CLI, clustering and networking guides on http://rabbitmq.com/documentation.html to learn more\n * Consult server logs on node test@c65c2bc59398\n\nDIAGNOSTICS\n===========\n\nattempted to contact:********@c65c2bc59398\n * effective user's home directory: /var/lib/rabbitmq\n * Erlang cookie hash: 3MxcYFrJzfhEL+FlUfLlQw==",
    "stderr":  [...],
    "stderr_lines": [
      "Error: unable to perform an operation on node 'test@c65c2bc59398'. Please see diagnostics information and suggestions below.", "",
      "Most common reasons for this are:", "",
      " * Target node is unreachable (e.g. due to hostname resolution, TCP connection or firewall issues)",
      " * CLI tool fails to authenticate with the server (e.g. due to CLI tool's Erlang cookie not matching that of the server)",
      " * Target node is not running", "",
      "In addition to the diagnostics info below:", "",
      " * See the CLI, clustering and networking guides on http://rabbitmq.com/documentation.html to learn more",
      " * Consult server logs on node test@c65c2bc59398", "",
          "DIAGNOSTICS", "===========", "",
          "attempted to contact: [test@c65c2bc59398]", "",
          "test@c65c2bc59398:",
      "  * connected to epmd (port 4369) on c65c2bc59398",
      "  * epmd reports: node 'test' not running at all",
      "                  other nodes on c65c2bc59398: [rabbit]",
      "  * suggestion: start the node", "",
      "Current node details:",
      " * node name: rabbitmqcli2@c65c2bc59398",
      " * effective user's home directory: /var/lib/rabbitmq",
      " * Erlang cookie hash: 3MxcYFrJzfhEL+FlUfLlQw==", ""
    ],
    "stdout": "",
    "stdout_lines": []
  }

* node parameter: fix default value

'rabbit' is the default value mentioned in the module documentation.
2018-10-08 18:34:08 -04:00
Benoit Dunand-Laisin
19deb6b49e Fix python 3 compatibility (#41645) 2018-10-08 18:30:05 -04:00
Dan Quinn
a3a595e60a merge conflict (#25235) 2018-10-08 18:08:55 -04:00
Tom 'Biwaa' Riat
6ad9e1c3de feat(apt): add -f --fix-broken option to apt module (#27162) 2018-10-08 18:07:52 -04:00
Major Hayden
bf8863eeb3 Docs: Fix ftype list in sefcontext module (#46364)
Add the list of file types to the `sefcontext` module documentation.
2018-10-08 14:39:49 -05:00
Daniel Jakots
753711cd12 Register missing parameter reboot_timeout (#46585) 2018-10-08 14:56:40 -04:00
Sandra McCann
27132cd0b8 added jinja2 example (#46445)
* added jinja2 example
2018-10-08 13:50:45 -05:00
Matt Clay
a11f631ee4 Python 3.8 collections compatibility fixes.
Includes a new pylint blacklist plugin to prevent regressions.
2018-10-08 11:26:37 -07:00
Colin McCarthy
84a40b71c2 Added (Define Values From CSV File) to example section (#46620)
Adding a new example demonstrating setting facts from a CSV file, from a real-world network use case.
2018-10-08 10:48:46 -05:00
Abhijeet Kasurde
39e71bb7ce Plugin: check if executable exists in local connection (#46201)
This fix checks if executable exists in local connection specified using
ANSIBLE_EXECUTABLE variable.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-08 09:40:27 -04:00
Evgeni Golov
7c66c90afc introduce module_utils.urls.fetch_file as a wrapper to download and save files (#19172)
* module_utils.urls: add fetch_file function

* apt: use fetch_file instead of own download()

* unarchive: use fetch_file instead of own codecopy

* apt: add test for deb=http://…

* unarchive: add test for a remote file download and unarchive

* yum: replace fetch_rpm_from_url by fetch_file

* use NamedTemporaryFile

* don't add a dot to fileext, it's already there
2018-10-08 14:41:57 +02:00
Adam Miller
c8ed5c29e9 allow update_cache as stand alone operation for yum/dnf (#46183)
* allow update_cache as stand alone operation for yum/dnf

Fixes #40068

Signed-off-by: Adam Miller <admiller@redhat.com>

* make sanity tests happy

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-10-08 08:39:49 -04:00
Guido Günther
960dfa862b influxdb_retention_policy: don't fail with empty error message (#28792)
On connection errors the influxdb python module raises an exception with
an empty message leading to a fail_json with an empty error message:

    265d14736b/influxdb/influxdb08/client.py (L252)

Fail with a more descriptive error in this case.
2018-10-08 07:23:53 -04:00
Jay Jahns
ffcebd317b Account for boolean OVF properties (#45529)
Currently, Ansible interprets variables with a True|False value as
boolean. This causes the vmware_deploy_ovf module to break, because
it can only accept string values as properties.

This fix checks if a value is boolean, and converts it to a string
if it is. Since integers do not seem to be causing the same error, this
is the only check we appear to need.

After completion, OVF properties that are boolean can be specified as
yes|no or true|false.

Closes: #45528
2018-10-08 06:14:58 -04:00
Felix Fontein
a74774488d docker_container: add port range and IPv6 support for published_ports (#46596)
* Allow port ranges.

* Adding IPv6 support for published_ports.

* Die when hostname is passed instead of IP address.

* Added changelog.
2018-10-08 10:53:24 +01:00
Christian Kotte
ccfa6ff011 VMware: Add check mode support to module vmware_host_ntp (#46268) 2018-10-08 15:11:52 +05:30
Christian Kotte
c4cfeb183f VMware: Add check mode support to module vmware_host_service_manager (#46271) 2018-10-08 15:09:38 +05:30
Felix Fontein
77127d6768 docker_container: allow more mount modes for volumes (#46598)
* Being more strict about volume mount modes.
2018-10-08 10:11:03 +01:00
Abhijeet Kasurde
513be8923d
VMware: new module vmware_host_feature_facts (#45966)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-08 14:28:29 +05:30
Felix Fontein
c5ea3d058e docker_container: fix problem with published_ports idempotency (#46595)
* Fix comparisons for expected_ports (set vs dict).

* Added changelog.
2018-10-08 08:41:15 +01:00
Felix Fontein
8afe46dc02 docker_container: improve publish all ports functionality (#46594)
* Improve handling of published_ports: all.

* Add changelog.
2018-10-08 08:23:23 +01:00
Trishna Guha
d69700b236
nxos_evpn_vni check_mode (#46612)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-10-08 11:11:01 +04:00
Simon Liddicott
f731e68bca Add chdir support to win_package (#46123)
* Add chdir support to win_package

* Add chdir support to uninstall too.

* Update docs to account for uninstall.

* Correct variable substitution for hashtable.

* added changelog fragment
2018-10-08 16:28:28 +10:00
Jordan Borean
bc6d441cf2
Win chocolatey facts module (#46610)
* add module win_chocolatey_facts

* rename example name

* fix ansible-test errors

* add integration tests

* fix integration test

* implementation of improvement proposals

* implementation feedback

* implementation feedback

* fix trailing-whitespace

* implementation feedback

* fix version

* fix lint

* add test targets

* Updated modules docs and tests

Co-authored-by: Simon Baerlocher <sbaerlocher@users.noreply.github.com>
2018-10-08 16:12:06 +10:00
Mehdi Youb
a7425a7e79 proxmox: doc: Fix example for restart container (#46602)
+label: docsite_pr
2018-10-07 23:22:14 +02:00
flowerysong
be05069c61 Port the sns module to boto3 (#45634)
* Port sns to boto3

* Exception handling for ARN lookup

* sns: Add integration tests
2018-10-07 16:03:48 -04:00
Evert Mulder
146709fb21 Added module to manage manageiq tenants (#43988)
* Added module to manage manageiq tenants

* Fixed pep8 and module validation issues for manageiq_tenant

* Changes based on review
- Added parent attribute to specify the parent
- Cleanup return of tenant
- Update documentation on quotas

* Updated version added to 2.8
2018-10-07 05:13:01 -05:00
ABond
f225d90018 Digital Ocean firewall facts (#46582) 2018-10-07 05:09:52 -05:00
Rémy Léone
4967ef5936 Specify region in IP facts (#46210) 2018-10-07 05:09:12 -05:00
Rémy Léone
2903033c1d Add region parameters to sg (#46211) 2018-10-07 05:09:02 -05:00
Rémy Léone
3a1d8867ed Add region to server facts (#46212) 2018-10-07 05:08:50 -05:00
Rémy Léone
6ab07d1a74 Add region to snapshots facts (#46213) 2018-10-07 05:08:25 -05:00
Abhijeet Kasurde
dbc80f89ca
Misc typo in logentries plugin module (#46568)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-07 07:25:01 +05:30
Christian Kotte
5cd1ba3477 VMware: Add check mode support to module vmware_host_dns_facts (#46530) 2018-10-06 10:44:33 -05:00
Rémy Léone
9ff25c1383 Add tags grouping (#45741) 2018-10-06 11:06:39 -04:00
Rémy Léone
c3e5ebfa79 Add region to the volume facts (#46214) 2018-10-06 09:36:29 -05:00
Felix Fontein
a520ca3298 docker_container, docker_image_facts: allow to use image IDs (#46324)
* Allow to specify images by hash for docker_container and docker_image_facts.

* flake8

* More sanity checks.

* Added changelog.

* Added test.

* Make compatible with Python < 3.4.

* Remove out-commented imports.
2018-10-06 08:50:31 -05:00
Felix Fontein
895019c59b docker_container: fix behavior when image is not specified (#46322)
* Don't simply ignore container in present() if image is not specified.

* Use image from existing container for recreation if not specified.

* Added changelog.

* Improve comment.
2018-10-06 08:50:12 -05:00
Abhijeet Kasurde
25dfa78dc2
Add missing bracket in documentation (#46564)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-06 02:48:07 -05:00
Abhijeet Kasurde
e5878d19de AWS: check dbname attribute before accessing (#46253)
Check dbname attribute in instance before accessing it in RDS module

Fixes: #38210

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-05 16:37:34 -04:00
Yixin Xu
5a35907b71 zabbix_host: fix link template error (#46521)
* add host interface before link template
2018-10-05 10:40:30 -04:00
Dag Wieers
b82f965616 mail: Fix regression when sending mail without SSL (#46403)
When refactoring the code the non-SSL use-case was broken.

The main cause is that we have no way to do integration tests for
testing SMTP.
2018-10-05 09:38:00 -04:00
rhodain
65952571d6 Ovirt_disk - Add ability to refresh passthrough disks (#46386)
* Ovirt_disk - Add ability to refresh passthrough disks

A new paramter "host" is added. When this paramter is specified the newly
created disk or an existing disk will refresh its information about the
underlying storage via the specified host. This oprion is only valid for
passthrough disks. This option requires at least the logical_unit.id to be
specified.

* Host search modification and some other minor changes.

* pep8 correction
2018-10-05 08:12:48 -04:00
Jordan Borean
02c11e6b51 azure_rm_common: use __version__ from module_util (#46184) 2018-10-05 07:02:44 -04:00
Martin Nečas
66b1c838c7 Ovirt delete snapshots after x days (#45551)
* ovirt add snapshot delete after x days

* update logic of deleting snapshot and rename it

* update docs and names of vars

* update docs syntax

* Update ovirt_snapshot.py

* put remove logic to function

* use default removing function for snapshot
2018-10-05 06:38:25 -04:00
Jonathan
4376417743 fix drain mode 'bool' (#30833) (#46478) 2018-10-05 03:55:42 -04:00
Martin Nečas
4c7bb32c1f Ovirt add kernel persist (#45555)
* ovirt add kernel persist

* Add description to kernel_params_persist

* update kernel_params_persist control logic

* correct pep8 syntax

* add condition for kernel_params

* put kernel persist check to function

* kernel persist check update tabs
2018-10-05 03:09:45 -04:00