4 commits

Author	SHA1	Message	Date
Artem Zinenko	2b63ae61f2	minor updates + tests to win_firewall_rule as per jborean93 review (#29148) ... * Added warning for 'force' option * Changed 'profiles' type to list * Changed 'interfacetypes' type to list * Added deprecation warning and fixed doc * updated force parameter	2017-10-10 16:23:08 +10:00
Artem Zinenko	06fadefbdc	[18807] win_firewall_rule module uses HNetCfg.FwPolicy2 COM Object (#27381) ... * #18807 win_firewall_rule uses HNetCfg.FwPolicy2 COM object * Added missing tests * Added support for InterfaceTypes property * Added support for EdgeTraversalOptions property * Added SecureFlags property * Port ranges are not possible in W2K8 * Added windows version checks * Fixed doc: removed 'force' option and all notes * Fixed copirights and docs	2017-08-29 16:18:03 -04:00
Dag Wieers	d958440bcb	win_firewall_rule: Implement idempotency, check-mode and diff support (#23162) ... * win_firewall_rule: Small idempotency fix This PR includes the following changes: - an idempotency fix when `profile: any` - better difference output to debug idempotency issues - documentation fixes (remove `required: false`) - Parameter handling fixes - RDP example that matches default RDP rule - Renamed parameter 'enable' to 'enabled' (kept alias) - Renamed parameter 'profile' to 'profiles' (kept alias) * Rewrite module completely The logic is still intact, but various changes with a single goal: - Make the module idempotent - Implement check-mode - Implement diff-mode - Adapted integration tests This fixes #18807 and #23455. * Change casing to lowercase * Improve the logic wrt. diff	2017-05-30 16:10:33 -07:00
Artem Zinenko	f4b34a4c3b	win_firewall_rule doesn't fail when profile is "any" or remoteip is IPv4 and the task runs more than once. (#22555) ... * Fixed #22554 * Wrote tests for win_firewall_rule module * Fixed #22786 * Fixed review comments * Fixed #22799 * Added test when RemoteIP containt a netmask * Revert comment	2017-03-23 20:01:26 -07:00