Adrian Likins
28771960a1
Merge pull request #15851 from sivel/py24-urllib2-code
...
Use .code instead of .getcode() as py24 does not have .getcode()
2016-05-13 12:20:41 -04:00
Matt Martz
878b0dca68
Use .code instead of .getcode() as py24 does not have .getcode(). Fixes https://github.com/ansible/ansible-modules-core/issues/3608
2016-05-13 09:44:00 -05:00
Jason McKerr
5b7896ce7f
Update committer_guidelines.rst
...
Adding Ryan and Adrian
2016-05-13 10:43:46 -04:00
James Cammarata
d2bade6daf
Make sure setting facts with run_once makes copies of the data
...
When using run_once, there is only one dict of facts so passing that
to the VariableManager results in the fact cache containing the same
dictionary reference for all hosts in inventory. This patch fixes that
by making sure we pass a copy of the facts dict to VariableManager.
Fixes #14279
2016-05-13 10:05:19 -04:00
Matt Davis
2cc50c6dc6
Merge pull request #15799 from bocharsky-bw/patch-1
...
Highlight SSH protocol types
2016-05-12 17:20:53 -07:00
Matt Davis
bc7405efc9
Merge pull request #15797 from robinro/patch-1
...
reduce async timeout in unittests
2016-05-12 17:19:10 -07:00
Toshio Kuratomi
a404d0ffe2
Update submodule refs
2016-05-12 17:01:25 -07:00
Matt Martz
a521b70217
Merge pull request #15306 from sivel/ansible-modules-core/issue/3370
...
Cascade ssh_*args configurations in synchronize
2016-05-12 18:59:37 -05:00
Matt Martz
0fabfee0a8
Merge pull request #15843 from sivel/binary-changelog
...
Add note to changelog for 2.2 about binary modules
2016-05-12 18:39:12 -05:00
Matt Martz
049e0ba276
Add note to changelog for 2.2 about binary modules
2016-05-12 18:38:30 -05:00
Matt Martz
196453b9b2
Merge pull request #13771 from sivel/binary-modules
...
First pass at allowing binary modules
2016-05-12 18:36:34 -05:00
Matt Martz
72b6f8244c
Merge pull request #15337 from sivel/ignore-profile-crap
...
Guard against a shell profile printing extraneous data
2016-05-12 18:32:02 -05:00
James Cammarata
ae09648068
Merge pull request #15812 from cThrice/patch-3
...
Fixes #15745 playbook include: Conditional scoping
2016-05-12 15:02:17 -04:00
Toshio Kuratomi
b4e78caf25
Merge pull request #15825 from abadger/fix-squashing-traceback
...
If we can't squash for any reason, then simply do not optimize the items loop.
2016-05-12 10:59:48 -07:00
Matt Martz
ca22783086
modify_module does not need to return module_path, as the calling code already has access to it
2016-05-12 12:53:49 -05:00
Matt Martz
34adb54734
Make _is_binary use already read module_data, move _is_binary check to the top of the stack
2016-05-12 12:53:49 -05:00
Matt Martz
651b83d8be
Run test_binary_modules
2016-05-12 12:53:44 -05:00
Matt Martz
2e8146c52f
Improve documentation about the JSON args file
2016-05-12 12:25:09 -05:00
Matt Martz
0faddfa168
Move binary module detection into executor/module_common.py
2016-05-12 12:25:09 -05:00
Matt Martz
3466e73c50
Resolve test failures
2016-05-12 12:25:09 -05:00
Matt Martz
a4d2238e50
Bumping binary modules functionality to 2.2
2016-05-12 12:25:09 -05:00
Matt Martz
c22c1b4785
Add note about reading input for binary modules
2016-05-12 12:25:09 -05:00
Matt Martz
ddf3c3838f
Re-implement/move some code lost due to merge conflicts
2016-05-12 12:25:09 -05:00
Matt Martz
2d18607f1e
Add GPL3 header to helloworld.go
2016-05-12 12:25:09 -05:00
Matt Martz
6ad8ec0919
Add integration tests for binary modules
2016-05-12 12:25:09 -05:00
Matt Martz
35246abb2e
Don't register new vars that aren't needed
2016-05-12 12:25:09 -05:00
Matt Martz
1e038e5043
Update for py26
2016-05-12 12:25:09 -05:00
Matt Martz
0a8d016642
Get binary modules working for windows, assuming .exe for windows
2016-05-12 12:25:08 -05:00
Matt Martz
d8a243bef0
First pass at allowing binary modules
2016-05-12 12:25:08 -05:00
Toshio Kuratomi
292f0ed0d6
If we can't squash for any reason, then simply do not optimize the items loop.
...
Also add more squashing testcases
Fixes #15649
2016-05-12 10:06:18 -07:00
Matt Martz
1cee3f35b1
Guard against a shell profile printing extraneous data
2016-05-12 11:43:37 -05:00
Toshio Kuratomi
4d59779e0a
Fixed importing the libcloud modules to give a nice error rather than a traceback.
2016-05-12 09:13:46 -07:00
Vic Iglesias
dac356466c
Update GCE module to use JSON credentials ( #13623 )
...
* Update GCE module to use JSON credentials
* Ensure minimum libcloud version when using JSON crednetials for GCE
* Relax langauge around libcloud requirements
2016-05-12 08:57:26 -07:00
James Cammarata
d391c53b4f
Clear blocked hosts when a role duplicate task is found in free strategy
...
In the free strategy, we mark a host as blocked when it has work to do
(the PlayIterator returns a task) to prevent multiple tasks from being sent
to the host. However, we check for role duplicates after setting the blocked
flag, but were not clearing that when the task was skipped leading to an
infinite loop. This patch corrects that by clearing the blocked flag when
the task is skipped.
Fixes #15681
2016-05-12 10:38:53 -04:00
James Cammarata
08f6283c3f
Merge pull request #15747 from larsks/bug/15744
...
do not erroneously set gathered_facts=True
2016-05-12 10:22:45 -04:00
James Cammarata
64a738ce51
Merge branch 'zenbot-refresh-inventory-exit' into devel
2016-05-12 09:52:00 -04:00
James Cammarata
3439bcc744
Merge branch 'refresh-inventory-exit' of https://github.com/zenbot/ansible into zenbot-refresh-inventory-exit
2016-05-12 09:36:12 -04:00
James Cammarata
0d7530e6da
Change error about loop variable in use to a warning
2016-05-11 21:50:12 -04:00
Toshio Kuratomi
8a184381af
Strip junk after JSON return. ( #15822 )
...
Fixes #15601
2016-05-11 17:54:01 -07:00
James Cammarata
9d9a451b34
Simply being in an always block shouldn't mean a host did not fail
...
Previously the changed code was necessary, however it is now problematic
as we've started using the is_failed() method in other places in the code.
Additional changes at the strategy layer should make this safe to remove
now.
Fixes #15625
2016-05-11 19:13:12 -04:00
Carl
fefd87c61a
Fixes #15745 playbook include: Conditional scoping
...
Fixes #15745
Applies conditional forwarding to all tasks/roles within the included playbook.
The existing line only applies forwarded conditionals to the main Task block, and misses pre_, post_, and roles.
Typo ::
Made a selection mistake when I copied over the one line change
2016-05-11 15:58:36 -04:00
James Cammarata
37737ca6c1
Merge pull request #15466 from alikins/pr_10555_cobbler_auth_rebase
...
add cobbler api authentication options
2016-05-11 15:17:37 -04:00
Toshio Kuratomi
18587842c6
Exclude the sample directory from tests
2016-05-11 12:03:23 -07:00
James Cammarata
33de7707c9
Do not include params when getting role vars in certain situations
...
In VariableManager, we fetch the params specifically in the next step,
so including them in the prior step is unnecessary and could lead to things
being overridden in an improper order.
In Block, we should not be getting the params for the role as they are
included earlier via the VariableManager.
Fixes #14411
2016-05-11 13:17:32 -04:00
James Cammarata
161388226b
Merge branch 'dagwieers-samples-to-test' into devel
2016-05-11 09:57:46 -04:00
James Cammarata
67c32ac30a
Merge branch 'samples-to-test' of https://github.com/dagwieers/ansible into dagwieers-samples-to-test
2016-05-11 09:57:21 -04:00
Toshio Kuratomi
9096901c1f
Update submodule refs
2016-05-10 21:59:42 -07:00
Toshio Kuratomi
99e3880181
small python3 fix so that ping will run on python3
2016-05-10 21:59:42 -07:00
Matt Martz
accf40d8a8
Use httptester docker image for http tests ( #15811 )
...
* Use httptester docker image for http tests
* When not running with an httptester linked container, use public test sites
2016-05-10 23:43:07 -04:00
Brian Coca
4561be00af
simplified inventory error messaging
2016-05-10 17:16:26 -04:00
