Christian Berendt
2c39eff60e
[get_url] check against lowered stripped sha256sum
...
The content of the sha256sum attribute should be lowered before comparing it with the calculated sha256sum.
In the following example the used sha256sum uses ABC.. and not abc.. and the check failed. This should not happen.
```
TASK: [get_url url=http://ftp.fau.de/apache/hadoop/common/hadoop-2.4.0/hadoop-2.4.0.tar.gz dest=/home/vagrant/hadoop-2.4.0.tar.gz mode=0644 sha256sum=024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A] ***
failed: [instance000] => {"failed": true}
msg: The SHA-256 checksum for /home/vagrant/hadoop-2.4.0.tar.gz did not match 024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A; it was 024326ac68a1a68b5566b10f95609eaafd9f70cfeb37fca0e97cbb1674e57c3a.
FATAL: all hosts have already failed -- aborting
```
2014-05-06 18:27:43 +02:00
James Cammarata
537494c2d6
Make sure distro variable is set if python-apt is installed
...
Fixes #7295
2014-05-06 09:42:50 -05:00
James Cammarata
941af22d5d
Merge pull request #7294 from adamchainz/patch-1
...
Fix sync_binlog name in mysql_variables example
2014-05-06 08:18:05 -05:00
James Cammarata
7bf86ec1c0
Merge branch 'fixing_apache2_module' of https://github.com/berendt/ansible into berendt-fixing_apache2_module
2014-05-06 08:02:21 -05:00
Adam Chainz
967de3cdf9
Fix sync_binlog name in mysql_variables example
...
The previous sync_binary_log is not a real MySQL variable.
2014-05-06 12:25:11 +01:00
James Cammarata
d6fc9f1dfc
Fixing two bugs in the ec2_elb_lb module
...
* the current state of the ELB was not reflected properly when checking
the status after a change was made.
* invalid zones caused a traceback when enabling/disabling zones
2014-05-05 12:48:45 -05:00
James Cammarata
faf733bc49
Removing zone choices that overly-limit available zones for gce
...
Fixes #7270
2014-05-05 11:58:39 -05:00
James Cammarata
b753625dbf
Refuse to convert a non-empty directory into a link with the file module
...
Also adds an integration test for the above.
Fixes #7254
2014-05-02 14:46:38 -05:00
James Cammarata
ae7503d6fb
Merge branch 'fix-copy-recursive-issue' of https://github.com/tksmd/ansible into tksmd-fix-copy-recursive-issue
2014-05-01 13:39:11 -05:00
James Cammarata
c0f92317ef
Fixing a documentation error in the new stackdriver module
2014-05-01 11:44:31 -05:00
James Cammarata
2b898e7e8b
Minor fix to imports in new stackdriver module
2014-05-01 11:39:46 -05:00
someda
50080b3774
fix #7244 recursive copy fails when setting directory attributes
...
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
2014-05-02 01:38:16 +09:00
James Cammarata
6069d5d4cf
Merge branch 'stackdriver' of https://github.com/bwhaley/ansible into bwhaley-stackdriver
2014-05-01 11:21:36 -05:00
James Cammarata
ce48e1f9ff
Merge pull request #7230 from binarytemple/fix_for_issue_7228
...
fix issue #7228 ec2_vol crash
2014-04-30 08:30:27 -05:00
bryan hunt
88aaa70f0c
fix issue #7228 ec2_vol crash
2014-04-30 10:43:05 +01:00
Atlas Health
49d0ad0644
added example
2014-04-29 17:13:25 -04:00
Atlas Health
4258eb6be7
updated docs to include snapshot_tags option
...
added version
2014-04-29 17:13:25 -04:00
James Cammarata
04793ff640
Merge branch 'patch-2' of https://github.com/budlight/ansible into budlight-patch-2
2014-04-29 15:58:05 -05:00
Michael DeHaan
6b26efdee0
Merge pull request #7119 from jjshoe/patch-4
...
Finish reverting a broken commit in #5679
2014-04-29 16:47:46 -04:00
James Cammarata
ac1948c04c
Minor tweak to rsync_path construction in synchronize module
...
Fixes #7182
2014-04-29 15:47:16 -05:00
Michael DeHaan
d5e254d3c7
Merge pull request #6794 from follower/patch-4
...
Make `vpc_security_group` docs more accurate
2014-04-29 15:49:57 -04:00
Michael DeHaan
5c75ce1133
In apt module show 'name' vs pkg to standardize with the rest of the modules. 'pkg' is an alias for name.
2014-04-29 15:48:51 -04:00
James Cammarata
d2819e22e3
Merge pull request #7212 from jimi-c/issue_7027_ec2_group_egress_rules
...
Make sure a default allow out rule exists if no other egress rules do
2014-04-29 10:39:36 -05:00
James Cammarata
67092039d7
Merge pull request #7190 from jimi-c/issue_7180_vsphere_guest_hardware_variable_casts
...
Make sure values are integers for certain hardware items for vpshere_guest
2014-04-28 21:00:46 -05:00
James Cammarata
826198196b
Merge branch 'elb' of https://github.com/bpennypacker/ansible into bpennypacker-elb
2014-04-28 20:39:10 -05:00
Christian Berendt
67a8ee24e1
made enabled/disabled checks of apache2_module workable
2014-04-28 19:46:34 +02:00
James Cammarata
50cd3a4a8f
Make sure values are integers for certain hardware items for vpshere_guest
...
Fixes #7180
2014-04-28 11:40:00 -05:00
James Cammarata
a482e1583d
Merge branch 'fix_user_non_root_on_rhel' of https://github.com/mscherer/ansible into mscherer-fix_user_non_root_on_rhel
2014-04-28 10:47:36 -05:00
Michael Scherer
28c373da0c
Do not fail if we try to generate a ssh key for a user without being root
...
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.
So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
2014-04-28 12:29:57 +02:00
Skyler Leigh Amador
a8d9470938
Remove --timeout option to rsync from synchronize defaults
...
The current 10-second default timeout for rsync seems to be behind issue #6809 .
As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
2014-04-27 20:21:54 -07:00
Michael DeHaan
2ea386fe04
Merge pull request #7168 from jjshoe/fix_apache2_module_docs
...
Fix example
2014-04-27 16:28:31 -04:00
Joel Schuweiler
7916545979
Fix example
2014-04-27 12:16:51 -05:00
Joel Schuweiler
5bad971873
Finish reverting #b73cddc
2014-04-27 09:36:13 -05:00
jjshoe
a34478d6f3
Ensure the validation string has %s in it
2014-04-27 09:30:36 -05:00
Brian Brazil
d25f1dc2d0
Use empty string rather than None to avoid TypeError
...
Improve error messages.
2014-04-25 13:30:19 +01:00
mkosmach
fbf3b78ace
add simplejson as alternative to json
2014-04-25 02:44:51 -07:00
Ben Holloway
e45d33954b
documentation fix
2014-04-24 17:58:39 -06:00
Ben Holloway
4596521147
attempt to set availability_zones to all if neither availability_zones or vpc_identifier are set
2014-04-24 17:56:26 -06:00
Bruce Pennypacker
dc912ca201
removed unwanted 'if wait else None'
2014-04-24 20:41:51 +00:00
Ben
5a39672efa
documentation fix availability_zones should be required for ec2_asg
2014-04-24 11:56:25 -06:00
Ben
30b634eae9
updated example to include instance_type
2014-04-24 11:50:49 -06:00
Ben
9770c7f47d
Added instance_type to ec2_lc variable list
2014-04-24 11:47:41 -06:00
Michael DeHaan
31f7a0693e
Add missing license headers to two modules and standardize formatting of another.
2014-04-24 10:32:54 -04:00
James Cammarata
89fa9b7305
Add parameters to get_url for the url username/password
...
Fixes #6928
2014-04-24 00:26:50 -05:00
James Cammarata
83f300ddd6
Merge branch 'apt_key_format' of https://github.com/andreasf/ansible into andreasf-apt_key_format
2014-04-24 00:02:10 -05:00
James Cammarata
3f1545f9db
Fixing the version_added string in the vsphere_guest module
2014-04-23 22:46:14 -05:00
James Cammarata
833ceeca24
Merge branch 'vmware_core' of https://github.com/rhoop/ansible into rhoop-vmware_core
2014-04-23 21:12:40 -05:00
James Cammarata
2bc640c82f
Merge pull request #7141 from lamby/devel
...
Correct/update debconf examples - need to specify vtype.
2014-04-23 21:09:52 -05:00
npeters
61bb40c0dd
Remove invalid variable
2014-04-24 01:12:55 +02:00
Ben Whaley
1c996085ff
Updated to use fetch_url
2014-04-23 15:26:13 -07:00
James Cammarata
16874464e9
Merge pull request #7047 from joshuaconner/docker_bugfix_exclude_entrypoint_from_command_check
...
docker: exclude 'entrypoint' from comparing 'command' param with containers
2014-04-23 16:14:48 -05:00
James Cammarata
46c0eb2f3e
Merge pull request #7022 from jjshoe/patch-1
...
apt_key lists all keys in uppercase
2014-04-23 15:58:23 -05:00
Richard Hoop
578ba471b1
Author
2014-04-23 16:53:12 -04:00
Chris Lamb
446765ace0
Correct/update debconf examples - need to specify vtype.
...
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2014-04-23 21:51:01 +01:00
James Cammarata
060e2193a1
Merge pull request #6991 from joshuaconner/bugfix_dont_send_wrong_params_to_dockerclient_start
...
Docker: don't send wrong parameters to client.start()
2014-04-23 15:48:04 -05:00
Richard Hoop
07ad8432ec
Ready for pull request
2014-04-23 16:44:49 -04:00
Richard Hoop
5692ae95ab
Core complete
2014-04-23 15:26:03 -04:00
James Cammarata
eb090ad4a2
Merge pull request #6599 from dmage/nova_region_name
...
use region_name in nova_compute
2014-04-23 10:15:57 -05:00
James Cammarata
24cfcd1f88
Merge pull request #6985 from jimi-c/issue_6763_ec2_vpc_params
...
Ensure params were set in ec2_vpc before accessing them
2014-04-23 10:08:50 -05:00
Brian Coca
f079d022a3
now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-04-23 10:38:38 -04:00
James Cammarata
ed1c7a0f5d
Merge pull request #7128 from stansonhealth/improve_tag_docu
...
update ec2_tags documentation to include missing option
2014-04-23 09:31:42 -05:00
Erika Heidi
036c7a7759
Possible docs error: 'path' instead of 'src'
...
I came to this example today (line 50), and when I tried it, I got an error:
`msg: src and dest are required for creating links`
So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
2014-04-23 16:00:22 +02:00
Richard Hoop
68d45a6484
Started reconfigured
2014-04-23 09:53:12 -04:00
Ted Timmons
b5895712b3
update documentation to include missing option
...
'list' was added more recently, it was omitted from the documentation.
2014-04-23 08:44:43 -05:00
Richard Hoop
630367ebfc
Creation complete
2014-04-22 17:12:23 -04:00
Richard Hoop
3e75e504e0
More config checks and clean up for vm_config settings
2014-04-22 16:20:04 -04:00
Bruce Pennypacker
2be8feebce
Changed behavior of deregister. If an instance is not found in the ELB then simply return 'changed=false'. Otherwise always remove the instance from the ELB no matter what state its currently in.
2014-04-22 18:44:41 +00:00
James Cammarata
d88ac5e24d
Merge pull request #7076 from mscherer/better_message_service
...
Add a better error message for service
2014-04-22 08:44:14 -05:00
Mike Buzzetti
4cb41de987
Updated and corrected example section
2014-04-22 09:27:26 -04:00
Michael Heca
9ad6511be7
module docker - add docker version comment
...
Default docker version 0.9.1 from Ubuntu 14.04 LTS don't report APIVersion.
2014-04-22 12:21:51 +02:00
Michael Scherer
43d0fbd342
Add a better error message for service
...
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.
So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
2014-04-22 09:13:57 +02:00
Mike Buzzetti
b2c5106833
Adding support for purging subnets
2014-04-21 21:42:05 -04:00
Richard Hoop
06c64785fb
Large cleanups. Reintegrating all modules together for a guest
2014-04-21 16:38:31 -04:00
James Cammarata
149339f620
Merge pull request #7089 from dagwieers/debug-docs
...
Add an example to show all hostvars using debug
2014-04-21 12:11:39 -05:00
James Cammarata
53754357f7
Merge pull request #7096 from CaptTofu/docker
...
Small bug - 'acts' should be 'facts'
2014-04-21 11:49:26 -05:00
James Cammarata
afee14173e
Merge pull request #7095 from radeksimko/pokemon-exc-fix
...
Prevent catching unrelated exceptions
2014-04-21 11:49:04 -05:00
CaptTofu
2990db728a
Small bug - 'acts' should be 'facts'
2014-04-21 08:06:00 -07:00
Radek Simko
1513d2bd64
Prevention for catching unrelated exceptions added
2014-04-21 15:35:49 +01:00
Radek Simko
8bdd96b273
Explicit check of return code for autoinstallation of python-apt added
...
This will allow easier debugging through more meaningful error message.
2014-04-21 14:10:09 +01:00
Dag Wieers
3c15d64655
Add an example to show all hostvars using debug
...
This is a useful example to help debug how facts and vars are being collated.
2014-04-21 11:40:53 +02:00
Bruce Pennypacker
b57887bafd
Fix for https://github.com/ansible/ansible/issues/7054 - when renaming an instance and waiting for the change to occur, force result.id to the name of the new instance so the subsequent call to get_current_resource succeeds.
2014-04-18 17:56:11 +00:00
Michael Heca
4271613aa5
module docker_image - default tag latest
...
Fix constant rebuild of image if no tag specified.
2014-04-18 16:14:12 +02:00
Mike Buzzetti
5dada9403e
Adds support for VPC subnets to ELB
2014-04-18 09:59:35 -04:00
Joshua Conner
4defd9a15a
docker: exclude 'entrypoint' from comparing 'command' param with containers
...
The JSON the Docker API returns includes the container's ENTRYPOINT value (if it has one) with the 'Command' value. So instead of checking if `container['Command'] == module.params['command']`, we just check that `container['Command'].endswith(module.params['command'])` so the entrypoint won't affect a container being properly classified as matching the module params or not.
Also I refactored a super-long `if` statement into some temporary variables - I did it to help me figure out what was going wrong, and then it makes the code more readable so I kept it.
2014-04-17 16:10:53 -07:00
Joshua Conner
10171dc42b
docker: send 1.10 params if docker-py is new enough version
2014-04-17 16:05:50 -07:00
James Cammarata
1ef0402f03
Make sure a default allow out rule exists if no other egress rules do
...
Fixes #7027
2014-04-17 15:24:18 -05:00
Chad Nelson
ef1a8e4cdd
Only update submodules when recursive is true
2014-04-17 09:34:36 -04:00
Andreas Fleig
337a0059d9
apt_key: fix key lookup for 64 bit key ids
...
Fixes #7018 by extending `all_keys` to work with either short or long keys.
Also removes the ununsed method `key_present`.
2014-04-17 03:51:19 +02:00
Matt Bray
3948dc2d1d
docker.client.APIError has moved to docker.errors.APIError
...
see 18d4db09ec
2014-04-16 23:42:56 +01:00
James Cammarata
a37a84243b
Check resource_tags value before using it in ec2_vpc
...
Fixes #7024
2014-04-16 12:21:32 -05:00
Brian Brazil
8ec400669f
Fix race conditions where a process gets in state "Running"
...
between the restart/start command and the summary command.
Refactor to avoid repeating the status, and fail if a given call to monit fails.
2014-04-16 18:04:19 +01:00
James Cammarata
f9eb0ba4ad
Merge branch 'devel' of https://github.com/evanccopengeo/ansible into evanccopengeo-devel
2014-04-16 10:24:39 -05:00
jjshoe
5258f75789
apt_key lists all keys in uppercase
...
allow for a little user error
2014-04-16 10:06:59 -05:00
Michael Heca
a1706e6411
module replace - report changed only if contents is changed
2014-04-16 09:25:56 +02:00
Hernandes B. de Sousa
202fc57253
Add missing info for the append option
...
Both 'default' and 'choices' options were missing at the documentation.
2014-04-16 01:22:12 -03:00
James Cammarata
e8b33636ae
Get the bin path for commands in the unarchive module
...
Fixes #6927
2014-04-15 20:39:22 -05:00
evanccopengeo
ac64f3c8cf
cleaning up the code a bit more
2014-04-15 18:16:34 -04:00
evanccopengeo
88b30a74d2
fixing bug where if both private_ip and assign_public_p are set ansible fails out
2014-04-15 17:55:26 -04:00
James Cammarata
f547733b1f
Check to make sure the firewalld client is connected before proceeding
...
Fixes #6911
2014-04-15 15:03:52 -05:00
Cédric RICARD
3384021fe6
Fixed test on 'cached' parameter.
...
'cached' parameter is boolean, not string
2014-04-15 16:41:27 +02:00