James Cammarata
22dbb65b13
Move initscript rc check to later in service status check
...
Fixes #7284
2014-09-11 12:11:06 -05:00
Michael DeHaan
26cdddaebf
Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules.
2014-09-11 12:27:21 -04:00
Patrik Lundin
e65ca6876f
service: use self.changed in service_enable_rcconf().
...
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
2014-08-28 00:52:23 +02:00
James Cammarata
d6a8d4671a
Add additional checks to detect upstart services
...
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
2014-08-25 13:41:39 -05:00
Eri Bastos
82ec224a93
Proposed fix for issue #7757
2014-08-25 12:10:14 -05:00
James Cammarata
0dda8a7996
Tweaking change to documentation language for cron name param
2014-08-25 09:54:21 -05:00
James Cammarata
a415993142
Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel
2014-08-25 09:51:17 -05:00
James Cammarata
2d683cbd30
Merge pull request #8740 from mattparker/patch-1
...
Name appears to be a required parameter for cron module
2014-08-25 09:49:58 -05:00
James Cammarata
77ef324ab7
Merge pull request #8729 from ercpe/openrc-hostname
...
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
2014-08-25 09:28:29 -05:00
Matt Parker
fd982cf8b7
Update cron documenation
...
The "name" parameter seems to be rather important as the identifying feature of a cron job. This is an update to the documentation to further emphasize this.
2014-08-25 10:29:45 +01:00
Matt Parker
dc634bc644
Name appears to be a required parameter
...
As far as I can tell, `name` is a required parameter. The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear. Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too. However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
2014-08-25 10:23:54 +01:00
Johann Schmitz
9945a732f7
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
2014-08-23 09:00:28 +02:00
Ding Deng
13db184d7f
debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7).
2014-08-19 17:44:02 +08:00
Michael DeHaan
46e9c287a7
Fix documentation builds.
2014-08-08 15:12:10 -04:00
Michael DeHaan
8cab5937c3
Merge pull request #8002 from prune998/patch-2
...
added missing force flag on mkfs commandline
2014-08-08 13:55:19 -04:00
Michael DeHaan
3bead39c75
Merge branch 'spelling' of git://github.com/cgar/ansible into devel
...
Conflicts:
docsite/rst/guide_rax.rst
plugins/callbacks/mail.py
2014-08-08 13:28:45 -04:00
Michael DeHaan
19ef7b3eeb
Update docs.
2014-08-08 11:51:27 -04:00
Michael DeHaan
bfe8437a21
Updating docs.
2014-08-08 11:51:27 -04:00
Brian Coca
db146717b5
bumped to 1.7
2014-08-08 11:51:27 -04:00
Brian Coca
268122d7d0
added control to fail or not on missing key
...
made split 'smarter' but still overridable
2014-08-08 11:51:27 -04:00
Brian Coca
27bf4d8ec4
added getent module to get system data as facts
2014-08-08 11:51:27 -04:00
Serge van Ginderachter
25b696c2d2
execute the mount after path validation
...
This avoids a stale situation where name/path contains some impossible path,
but gets configured (faultly) in fstab, and the module only fails after that,
when creating that path.
2014-08-06 10:52:08 +02:00
Jonathan Mainguy
c0966eee7c
Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl
2014-08-02 15:38:52 -04:00
Michael DeHaan
f61ba3d047
Merge pull request #8283 from ps-jay/sys_mount_fstype_doc
...
Add fstype arg to the mount examples
2014-07-30 08:28:59 -04:00
Michael DeHaan
6300ded89c
Merge pull request #8311 from neersighted/wrap_distroversion
...
Wrap get_distribution_version() in the hostname module
2014-07-28 15:48:18 -04:00
Michael DeHaan
226dacc7e6
Cleaning up explanation of mount module states.
2014-07-28 12:18:45 -04:00
Bjorn Neergaard
adcdbdf894
Wrap get_distribution_version() in the hostname module
...
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.
This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
2014-07-28 11:16:30 -05:00
Michael DeHaan
b69f096e8a
Merge branch 'ufw' of git://github.com/Trozz/ansible into devel
2014-07-28 12:08:29 -04:00
Michael DeHaan
216f803aa5
Merge pull request #7954 from alimony/patch-3
...
cron module: Use correct parameter name in error message.
2014-07-28 11:29:05 -04:00
James Cammarata
d1d318b028
Merge pull request #8308 from robinro/extend-hostname-distrolist
...
Extended distributions list for hostname module
2014-07-28 09:12:59 -05:00
Robin Roth
e91c318327
Fix extra newline at end of hostname for Fedora
...
This fixes a bug introduced by 138b45e3
.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
2014-07-28 15:22:10 +02:00
Robin Roth
7a09f87b8c
Extended distributions list for hostname module
...
Implementations already present
2014-07-28 15:19:41 +02:00
Tom Lazar
146a0f1cb7
FreeBSD 10 compatibility fix
...
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
2014-07-25 14:33:24 +02:00
Philip Jay
138fffb152
Add fstype arg to the mount examples
...
Needed fstype in the examples, since fstype is a required argument for
mount.
2014-07-25 09:58:54 +10:00
Berend de Boer
869cc7947e
Default for fstab missing, causing KeyError: 'fstab'
2014-07-24 13:14:46 +12:00
James Cammarata
593057515c
Merge pull request #8223 from renard/create-fstab-if-not-exists
...
Create fstab if not exists
2014-07-21 15:03:14 -05:00
Sébastien Gross
48128ec0ab
[mount] make sure fstab exists
...
This is mainly to prevent from failing with no such file or directory
during module execution.
2014-07-21 18:32:02 +02:00
Sébastien Gross
f2e2337d07
[mount] Add documentation for fstab option
2014-07-21 18:30:59 +02:00
Hector Acosta
ec70bb01ef
Add check_mode support to authorized_key. Fixes #7300
...
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
2014-07-19 17:55:58 -05:00
Yasser Nabi
8a6bbfd3b5
Enable puppet facts
...
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.
In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.
The benefit is, filtering can be done based on facts set by Puppet.
2014-07-17 17:53:12 +01:00
Michael DeHaan
64b874129f
Merge pull request #8139 from peterkh/devel
...
Fix "TypeError: group id must be integer" if groupid passed in for group key
2014-07-16 15:55:14 -04:00
Ruggero Marchei
8904c61932
fix LooseVersion exception with empty distribution_version
2014-07-16 07:55:20 +02:00
Peter Hall
09a5d8f6d1
Fix "TypeError: group id must be integer" if groupid passed in for group
...
key
2014-07-15 11:16:47 +10:00
Ruggero Marchei
d6bca15aa5
fix issue #8102
2014-07-15 01:26:44 +02:00
Cristian Ciupitu
6a8bc42014
Remove useless code
2014-07-09 23:11:15 +03:00
Michael Leer
891aa41001
add interfact documentation #7704
2014-07-01 18:49:07 +01:00
Prune
42966c22da
added missing force flag on mkfs commandline
...
even if the option ```force=yes``` is used in the playbook, it is not reflected in the mkfs command line.
As force option is dependent of the fs type, a "if-then-else" case have been added. Also, some FS types does not have a force option.
2014-07-01 15:09:39 +02:00
Markus Amalthea Magnuson
a44e322db4
Use correct parameter name in error message.
...
The parameter is called `cron_file` but the error message uses `file` which is confusing.
2014-06-27 14:53:54 +02:00
James Cammarata
98f8438236
Updating the other classes in the group module to match #7249
2014-06-24 12:28:43 -05:00
James Cammarata
bdd9b4cac4
Merge pull request #7249 from jfchevrette/implement-group-checking-if-state-present
...
Allow group module to handle check_mode properly when group.state=present and group already exists
2014-06-24 12:27:31 -05:00