1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

4260 commits

Author SHA1 Message Date
James Cammarata
32ce085689 Merge branch 'patch-1' of https://github.com/telsacolton/ansible into telsacolton-patch-1 2014-05-14 21:48:31 -05:00
James Cammarata
df877f2e79 Check module_path permissions when creating ssh_wrapper for git
If the module directory is not writable/executable to the current user
(most likely because of a sudo to a non-root user), the ssh_wrapper
will be created in the default location for mkstemp() calls. To facilitate
the deletion of these new files, a new mechanism for cleaning up files
created by the module was also added.

Fixes #7375
2014-05-14 21:22:22 -05:00
telsacolton
06963c7826 Make file hardlink error message reasonble
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
2014-05-14 16:54:26 -05:00
telsacolton
0d8104b8b7 Give reasonable error when symlink fails
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
2014-05-14 16:31:20 -05:00
James Cammarata
67d8df0e32 During vsphere config check attempt cast before marking values missing
Fixes #7385
2014-05-14 15:57:26 -05:00
James Cammarata
154ef942eb Merge pull request #7404 from jimi-c/issue_7363_docker_names
Make sure the docker data has a "Names" field before using it
2014-05-14 14:44:16 -05:00
James Cammarata
e623911df6 Merge branch 'bcoca-file_new_dirs_perms' into devel 2014-05-14 13:56:27 -05:00
James Cammarata
a9311a5dcb Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms 2014-05-14 13:53:08 -05:00
James Cammarata
bf405ef7a8 Merge pull request #7400 from etehtsea/patch-1
Fix env splitting in docker module
2014-05-14 11:00:32 -05:00
Konstantin Shabanov
ad9225895b Fix env splitting in docker module
ENV variable value could contain '=' (for example mysql://host/db?pool=10)
2014-05-14 18:11:43 +04:00
Scott Sturdivant
726dc1d2e8 Clarify that the encrypted param must also be set.
While the encrypted parameter's documentation clearly states that it needs to
be set, if you are focused on the password parameter's documentation, there's
nothing to draw your attention to the fact that encrypted may also need to be
set.
2014-05-14 07:49:11 -06:00
James Cammarata
19dbff916f Correctly cast the size_gb value for vpshere disks
Fixes #7385
2014-05-13 15:13:13 -05:00
Carson Gee
e6fbd2d8cb Fix missing variable initialization so an unspecified internal_network runs 2014-05-13 09:56:13 -04:00
Matt Martz
92b77048dc Handle ValueError during json.loads of json data from build 2014-05-12 14:16:07 -05:00
James Cammarata
bfc1201ecd Make sure the docker data has a "Names" field before using it
Fixes #7363
2014-05-12 12:27:07 -05:00
Yuichi TANIKAWA
2b644da4ca Add dots to valid path characters 2014-05-10 18:13:16 +09:00
James Cammarata
3bf890998b Merge pull request #7348 from adamchainz/patch-2
Fix grammar and value errors in cron documentation
2014-05-09 22:27:31 -05:00
James Cammarata
62c4a15c73 Merge pull request #7346 from tongpu/devel
Add documentation for required parameter name to quantum_subnet
2014-05-09 16:21:28 -05:00
Johannes 'fish' Ziemke
ea71c0c317 Fix: Remove check for Ghost state
This fixed the just committed change handling non existent Ghost state.
2014-05-09 20:13:25 +02:00
James Cammarata
c97dec9d75 Merge pull request #7338 from discordianfish/remove-ghost-state
Remove check for Ghost state
2014-05-09 13:06:16 -05:00
Johannes 'fish' Ziemke
b9d9ef511f Remove check for Ghost state
This doesn't exist anymore and causes ansible to throw a KeyError
2014-05-09 18:07:02 +02:00
Adam Chainz
3497582581 Fix grammar and value errors in cron documentation 2014-05-09 15:19:42 +01:00
James Cammarata
b78058022d Merge pull request #7342 from herbygillot/rds-params-fix
rds module: Fix undeclared reference to "params" when setting password in modify mode
2014-05-09 08:34:16 -05:00
Lukas Grossar
0aa4cb9a79 Add documentation for required parameter name to quantum_subnet 2014-05-09 15:17:04 +02:00
Michael DeHaan
54ac0fe92c Merge pull request #7343 from lberruti/alternatives_python5_2
Make alternatives module python 2.5 compatible
2014-05-09 09:08:34 -04:00
Herby Gillot
efbe4ca8d5 rds module: Fix undeclared reference to "params" when setting password in
modify mode.
2014-05-09 05:49:11 -04:00
James Cammarata
5c7109b8b9 Merge pull request #7110 from orgoj/docker-patch-version_comment
module docker - add docker version comment
2014-05-09 00:57:41 -05:00
James Cammarata
a18f4b6230 Merge branch 'devel' of https://github.com/jjshoe/ansible into jjshoe-devel 2014-05-09 00:31:39 -05:00
James Cammarata
0215134907 Fixing a doc mistake in the ec2 module from 4269bb6 2014-05-09 00:21:35 -05:00
James Cammarata
48e2a5e5a2 Merge branch 'ec2-start-stop' of https://github.com/sayap/ansible into sayap-ec2-start-stop 2014-05-09 00:04:34 -05:00
Yap Sok Ann
4269bb6a45 ec2: Fix bug with running/stopped state and wait=yes.
If `get_all_instances` returns multiple reservations, the old wait loop only
dealt with the first reservation. Thus, the wait loop may end before all
instances get to be running/stopped.

Also clean up the code a little.
2014-05-09 11:35:48 +08:00
James Cammarata
9d3583cab3 Merge pull request #7055 from bpennypacker/rds_modify
cloud/rds : renaming an rds instance always fails
2014-05-08 21:10:47 -05:00
James Cammarata
ebac5dfbce Updating docstring for docker_image based on new default for tag 2014-05-08 21:04:55 -05:00
James Cammarata
34e52c5884 Merge branch 'docker_image-patch-notag' of https://github.com/orgoj/ansible into orgoj-docker_image-patch-notag 2014-05-08 21:03:57 -05:00
James Cammarata
8dd91021f4 Merge branch 'git-submodule-when-recursive-true' of https://github.com/bibliotechy/ansible into bibliotechy-git-submodule-when-recursive-true 2014-05-08 20:47:10 -05:00
James Cammarata
39433949e0 Merge branch 'elb_subnets' of https://github.com/jimbydamonk/ansible into jimbydamonk-elb_subnets 2014-05-08 19:28:54 -05:00
James Cammarata
4358c846a0 Merge branch 'brian-brazil-devel' into devel 2014-05-08 16:47:21 -05:00
James Cammarata
b97f087f18 Fixing a typo in the monit module (status and not status()) 2014-05-08 16:46:32 -05:00
James Cammarata
a969941b85 Merge branch 'devel' of https://github.com/brian-brazil/ansible into brian-brazil-devel 2014-05-08 16:11:18 -05:00
James Cammarata
d9bb1a480a Merge pull request #7013 from orgoj/replace-patch-changed
module replace - report changed only if contents is changed
2014-05-08 15:14:19 -05:00
James Cammarata
3ac4943751 Some cleanup for the rds/vpc_security_groups fix 2014-05-08 15:08:43 -05:00
James Cammarata
768de238d4 Merge branch 'vpc_fix' of https://github.com/ebrevdo/ansible into ebrevdo-vpc_fix 2014-05-08 14:39:07 -05:00
James Cammarata
1a52fcce03 Merge pull request #7335 from napkindrawing/patch-1
Route53 module handling of domains with "*" is broken
2014-05-08 14:02:00 -05:00
napkindrawing
011ec5d9e6 Fix to unescape * was discarded by unescape of @
`decoded_name` was created twice, each from `rset.name`

So, the second call to `.replace(r'\100', '@')` overwrites decoded_name, discarding the result of the call to `.replace(r'\052', '*')`

I had a problem with wildcard domains that was fixed by this patch.
2014-05-08 14:20:32 -04:00
Chris Lamb
f510389298 Fail if monit reload failed; don't mask the error.
This is necessary for the scenario when you push a new, broken monit
config out, and then set a state=reloaded handler - the error was
previously swallowed so you could end up with successful play but missing
monitoring (!).

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2014-05-08 18:18:28 +01:00
Luca Berruti
a3d1f06cb2 Make alternatives module python 5 compatible 2014-05-08 14:46:49 +02:00
James Cammarata
713657d684 Make sure the default ec2_group egress rule is not removed
Upon a second run, the default egress rule will be removed when a
vpc is specified but no other egress rules were set. This patch
corrects that behavior by removing the default egress rule from the
list of unmatched outbound rules.

Fixes #7309
2014-05-07 20:52:03 -05:00
James Cammarata
bd56cfdf18 Merge pull request #7313 from mmoya/doc-fixes
Minor typo fix
2014-05-07 10:12:26 -05:00
James Cammarata
b71a451ed0 Close fds when running commands from the accelerate daemon
Fixes #7307
2014-05-07 08:47:38 -05:00
Maykel Moya
1d3ce41e83 Fix typo 2014-05-07 10:35:16 +02:00
Christian Berendt
2c39eff60e [get_url] check against lowered stripped sha256sum
The content of the sha256sum attribute should be lowered before comparing it with the calculated sha256sum.

In the following example the used sha256sum uses ABC.. and not abc.. and the check failed. This should not happen.

```
TASK: [get_url url=http://ftp.fau.de/apache/hadoop/common/hadoop-2.4.0/hadoop-2.4.0.tar.gz dest=/home/vagrant/hadoop-2.4.0.tar.gz mode=0644 sha256sum=024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A] ***
failed: [instance000] => {"failed": true}
msg: The SHA-256 checksum for /home/vagrant/hadoop-2.4.0.tar.gz did not match 024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A; it was 024326ac68a1a68b5566b10f95609eaafd9f70cfeb37fca0e97cbb1674e57c3a.

FATAL: all hosts have already failed -- aborting
```
2014-05-06 18:27:43 +02:00
James Cammarata
537494c2d6 Make sure distro variable is set if python-apt is installed
Fixes #7295
2014-05-06 09:42:50 -05:00
James Cammarata
941af22d5d Merge pull request #7294 from adamchainz/patch-1
Fix sync_binlog name in mysql_variables example
2014-05-06 08:18:05 -05:00
James Cammarata
7bf86ec1c0 Merge branch 'fixing_apache2_module' of https://github.com/berendt/ansible into berendt-fixing_apache2_module 2014-05-06 08:02:21 -05:00
Adam Chainz
967de3cdf9 Fix sync_binlog name in mysql_variables example
The previous sync_binary_log is not a real MySQL variable.
2014-05-06 12:25:11 +01:00
James Cammarata
d6fc9f1dfc Fixing two bugs in the ec2_elb_lb module
* the current state of the ELB was not reflected properly when checking
  the status after a change was made.
* invalid zones caused a traceback when enabling/disabling zones
2014-05-05 12:48:45 -05:00
James Cammarata
faf733bc49 Removing zone choices that overly-limit available zones for gce
Fixes #7270
2014-05-05 11:58:39 -05:00
James Cammarata
b753625dbf Refuse to convert a non-empty directory into a link with the file module
Also adds an integration test for the above.

Fixes #7254
2014-05-02 14:46:38 -05:00
James Cammarata
ae7503d6fb Merge branch 'fix-copy-recursive-issue' of https://github.com/tksmd/ansible into tksmd-fix-copy-recursive-issue 2014-05-01 13:39:11 -05:00
James Cammarata
c0f92317ef Fixing a documentation error in the new stackdriver module 2014-05-01 11:44:31 -05:00
James Cammarata
2b898e7e8b Minor fix to imports in new stackdriver module 2014-05-01 11:39:46 -05:00
someda
50080b3774 fix #7244 recursive copy fails when setting directory attributes
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
2014-05-02 01:38:16 +09:00
James Cammarata
6069d5d4cf Merge branch 'stackdriver' of https://github.com/bwhaley/ansible into bwhaley-stackdriver 2014-05-01 11:21:36 -05:00
James Cammarata
ce48e1f9ff Merge pull request #7230 from binarytemple/fix_for_issue_7228
fix issue #7228 ec2_vol crash
2014-04-30 08:30:27 -05:00
bryan hunt
88aaa70f0c fix issue #7228 ec2_vol crash 2014-04-30 10:43:05 +01:00
Atlas Health
49d0ad0644 added example 2014-04-29 17:13:25 -04:00
Atlas Health
4258eb6be7 updated docs to include snapshot_tags option
added version
2014-04-29 17:13:25 -04:00
James Cammarata
04793ff640 Merge branch 'patch-2' of https://github.com/budlight/ansible into budlight-patch-2 2014-04-29 15:58:05 -05:00
Michael DeHaan
6b26efdee0 Merge pull request #7119 from jjshoe/patch-4
Finish reverting a broken commit in #5679
2014-04-29 16:47:46 -04:00
James Cammarata
ac1948c04c Minor tweak to rsync_path construction in synchronize module
Fixes #7182
2014-04-29 15:47:16 -05:00
Michael DeHaan
d5e254d3c7 Merge pull request #6794 from follower/patch-4
Make `vpc_security_group` docs more accurate
2014-04-29 15:49:57 -04:00
Michael DeHaan
5c75ce1133 In apt module show 'name' vs pkg to standardize with the rest of the modules. 'pkg' is an alias for name. 2014-04-29 15:48:51 -04:00
James Cammarata
d2819e22e3 Merge pull request #7212 from jimi-c/issue_7027_ec2_group_egress_rules
Make sure a default allow out rule exists if no other egress rules do
2014-04-29 10:39:36 -05:00
James Cammarata
67092039d7 Merge pull request #7190 from jimi-c/issue_7180_vsphere_guest_hardware_variable_casts
Make sure values are integers for certain hardware items for vpshere_guest
2014-04-28 21:00:46 -05:00
James Cammarata
826198196b Merge branch 'elb' of https://github.com/bpennypacker/ansible into bpennypacker-elb 2014-04-28 20:39:10 -05:00
Christian Berendt
67a8ee24e1 made enabled/disabled checks of apache2_module workable 2014-04-28 19:46:34 +02:00
James Cammarata
50cd3a4a8f Make sure values are integers for certain hardware items for vpshere_guest
Fixes #7180
2014-04-28 11:40:00 -05:00
James Cammarata
a482e1583d Merge branch 'fix_user_non_root_on_rhel' of https://github.com/mscherer/ansible into mscherer-fix_user_non_root_on_rhel 2014-04-28 10:47:36 -05:00
Michael Scherer
28c373da0c Do not fail if we try to generate a ssh key for a user without being root
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
2014-04-28 12:29:57 +02:00
Skyler Leigh Amador
a8d9470938 Remove --timeout option to rsync from synchronize defaults
The current 10-second default timeout for rsync seems to be behind issue #6809.

As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
2014-04-27 20:21:54 -07:00
Michael DeHaan
2ea386fe04 Merge pull request #7168 from jjshoe/fix_apache2_module_docs
Fix example
2014-04-27 16:28:31 -04:00
Joel Schuweiler
7916545979 Fix example 2014-04-27 12:16:51 -05:00
Joel Schuweiler
5bad971873 Finish reverting #b73cddc 2014-04-27 09:36:13 -05:00
jjshoe
a34478d6f3 Ensure the validation string has %s in it 2014-04-27 09:30:36 -05:00
Brian Brazil
d25f1dc2d0 Use empty string rather than None to avoid TypeError
Improve error messages.
2014-04-25 13:30:19 +01:00
mkosmach
fbf3b78ace add simplejson as alternative to json 2014-04-25 02:44:51 -07:00
Ben Holloway
e45d33954b documentation fix 2014-04-24 17:58:39 -06:00
Ben Holloway
4596521147 attempt to set availability_zones to all if neither availability_zones or vpc_identifier are set 2014-04-24 17:56:26 -06:00
Bruce Pennypacker
dc912ca201 removed unwanted 'if wait else None' 2014-04-24 20:41:51 +00:00
Ben
5a39672efa documentation fix availability_zones should be required for ec2_asg 2014-04-24 11:56:25 -06:00
Ben
30b634eae9 updated example to include instance_type 2014-04-24 11:50:49 -06:00
Ben
9770c7f47d Added instance_type to ec2_lc variable list 2014-04-24 11:47:41 -06:00
Michael DeHaan
31f7a0693e Add missing license headers to two modules and standardize formatting of another. 2014-04-24 10:32:54 -04:00
James Cammarata
89fa9b7305 Add parameters to get_url for the url username/password
Fixes #6928
2014-04-24 00:26:50 -05:00
James Cammarata
83f300ddd6 Merge branch 'apt_key_format' of https://github.com/andreasf/ansible into andreasf-apt_key_format 2014-04-24 00:02:10 -05:00
James Cammarata
3f1545f9db Fixing the version_added string in the vsphere_guest module 2014-04-23 22:46:14 -05:00
James Cammarata
833ceeca24 Merge branch 'vmware_core' of https://github.com/rhoop/ansible into rhoop-vmware_core 2014-04-23 21:12:40 -05:00
James Cammarata
2bc640c82f Merge pull request #7141 from lamby/devel
Correct/update debconf examples - need to specify vtype.
2014-04-23 21:09:52 -05:00
npeters
61bb40c0dd Remove invalid variable 2014-04-24 01:12:55 +02:00
Ben Whaley
1c996085ff Updated to use fetch_url 2014-04-23 15:26:13 -07:00