James Cammarata
7483acde5d
Fix linking issue to directories in file module
...
The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.
Fixes #7657
2014-06-04 22:48:08 -05:00
Brian Coca
202ac68995
Correctly examine path for relative links in file module
...
Fixes #7515
Fixes #7537
2014-05-28 11:47:44 -05:00
Kit Westneat
fabe8521cb
Fixed documentation for etype parameter on acl module.
...
The etype parameter just had a copy of the default parameter documentation.
Changed it to reflect what it really is for.
2014-05-27 13:34:01 -04:00
Brian Coca
c24956032d
unified calls to fs function vs duplicate functions for file and
...
directory
2014-05-24 09:28:45 -04:00
James Cammarata
062e82937f
Fixing absolute path calculation for file module when linking
...
Fixes #7403
2014-05-21 12:49:42 -05:00
telsacolton
06963c7826
Make file hardlink error message reasonble
...
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
2014-05-14 16:54:26 -05:00
telsacolton
0d8104b8b7
Give reasonable error when symlink fails
...
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
2014-05-14 16:31:20 -05:00
James Cammarata
a9311a5dcb
Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms
2014-05-14 13:53:08 -05:00
James Cammarata
a18f4b6230
Merge branch 'devel' of https://github.com/jjshoe/ansible into jjshoe-devel
2014-05-09 00:31:39 -05:00
James Cammarata
d9bb1a480a
Merge pull request #7013 from orgoj/replace-patch-changed
...
module replace - report changed only if contents is changed
2014-05-08 15:14:19 -05:00
James Cammarata
b753625dbf
Refuse to convert a non-empty directory into a link with the file module
...
Also adds an integration test for the above.
Fixes #7254
2014-05-02 14:46:38 -05:00
someda
50080b3774
fix #7244 recursive copy fails when setting directory attributes
...
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
2014-05-02 01:38:16 +09:00
Michael DeHaan
6b26efdee0
Merge pull request #7119 from jjshoe/patch-4
...
Finish reverting a broken commit in #5679
2014-04-29 16:47:46 -04:00
James Cammarata
ac1948c04c
Minor tweak to rsync_path construction in synchronize module
...
Fixes #7182
2014-04-29 15:47:16 -05:00
Skyler Leigh Amador
a8d9470938
Remove --timeout option to rsync from synchronize defaults
...
The current 10-second default timeout for rsync seems to be behind issue #6809 .
As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
2014-04-27 20:21:54 -07:00
Joel Schuweiler
5bad971873
Finish reverting #b73cddc
2014-04-27 09:36:13 -05:00
jjshoe
a34478d6f3
Ensure the validation string has %s in it
2014-04-27 09:30:36 -05:00
Brian Coca
f079d022a3
now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-04-23 10:38:38 -04:00
Erika Heidi
036c7a7759
Possible docs error: 'path' instead of 'src'
...
I came to this example today (line 50), and when I tried it, I got an error:
`msg: src and dest are required for creating links`
So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
2014-04-23 16:00:22 +02:00
Michael Heca
a1706e6411
module replace - report changed only if contents is changed
2014-04-16 09:25:56 +02:00
James Cammarata
e8b33636ae
Get the bin path for commands in the unarchive module
...
Fixes #6927
2014-04-15 20:39:22 -05:00
James Tanner
b0556ab1fb
Addresses #6702 Remove version_added from description string
2014-04-11 11:18:05 -04:00
James Tanner
42fbbd0502
Addresses #6702 set version_added for rsync_opts
2014-04-11 11:04:05 -04:00
jctanner
bb3ce0c744
Merge pull request #6702 from jjshoe/devel
...
Allow you to pass in arbitrary rsync options
2014-04-11 10:43:14 -04:00
James Tanner
dfdc3b82a0
Fixes #6929 remote file module doc fragments from copy and template
2014-04-10 16:06:35 -04:00
James Tanner
68cd7258b6
Fixes #6894 create docs fragment for files
2014-04-08 13:20:15 -04:00
James Cammarata
b73cddc485
Revert "Fix #5679 again after recent changes in core"
...
This reverts commit 2bfaacd170
.
Fixes #6821
2014-04-07 09:55:59 -05:00
Richard C Isaacson
dc93b31d22
assemble module: fix insertion of newlines when not needed.
...
This builds on GH-6359 and changes the logic so that a newline is only inserted between fragments if the previous fragment does not end with a newline.
2014-04-03 16:32:35 -05:00
Peter Gehres
3ac731087c
Fix for #6353 adding a newline between assembled files
2014-04-03 16:32:35 -05:00
Michael DeHaan
1fa19e29e8
Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
...
Application to other cloud providers would make very good sense.
2014-04-03 16:52:39 -04:00
James Tanner
9fe2bcd076
Merge #5903 from rhaido/ansible
...
Update files documentation for usage of force=True and hardlinks
2014-03-31 12:53:03 -04:00
cgtx
f6abc17e8a
backreferences should be double escaped
2014-03-29 18:14:56 -05:00
Michael DeHaan
8baaf458c7
Repairs for documentation build.
2014-03-28 14:57:29 -04:00
Michael DeHaan
c1fbf80f70
Slight docs tweak, split lines according to code standards
2014-03-28 14:04:59 -04:00
Andrea.Mandolo
838b914a0d
correct documentation comment and version_added in "synchronize" module
2014-03-28 14:04:59 -04:00
Andrea.Mandolo
c039dbe300
Add STDOUT lines in response of "synchronize" module
2014-03-28 14:04:59 -04:00
Andrea.Mandolo
f9ec53cdef
Add "checksum" option support to 'synchronize' module
2014-03-28 14:04:59 -04:00
Michael DeHaan
37efa1640f
Merge branch 'update_docs_validate_cmd_not_passed_via_shell' of git://github.com/rwehner/ansible into devel
...
Conflicts:
library/files/template
2014-03-28 11:21:41 -04:00
Michael DeHaan
2ddb251538
Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile
...
Handle missing symlink tempfile
2014-03-28 11:11:32 -04:00
jjshoe
d57910b93a
Allow you to pass in arbitrary rsync options. I also added help for it, and what version it was added in.
2014-03-27 08:00:20 -05:00
Jeff Geerling
8960cba4a3
Fixed template validation docs and example.
2014-03-26 12:42:15 -05:00
jjshoe
12c84dd6bd
Show argument dependency
...
failed: [192.168.1.2] => {"cmd": "rsync --delay-updates -FF --compress --timeout=10 --delete-after --rsh 'ssh -i /home/jjshoe/.vagrant.d/insecure_private_key -o StrictHostKeyChecking=no' --rsync-path 'sudo rsync' --out-format='<<CHANGED>>%i %n%L' /tmp/app vagrant@192.168.1.2:/home/ubuntu/app", "failed": true, "item": "", "rc": 1}
msg: rsync: --delete does not work without --recursive (-r) or --dirs (-d).
rsync error: syntax or usage error (code 1) at main.c(1453) [client=3.0.9]
2014-03-26 08:32:55 -05:00
James Cammarata
f2c06cadc3
Cleanup from merge of replace module and CHANGELOG update
2014-03-25 11:13:51 -05:00
James Cammarata
9775872f83
Merge branch 'devel' of https://github.com/EvanK/ansible into EvanK-devel
2014-03-25 10:38:59 -05:00
James Cammarata
d545b73ccb
Merge branch 'file_fixes_agg' of https://github.com/bcoca/ansible into bcoca-file_fixes_agg
2014-03-24 16:38:35 -05:00
Robert Wehner
8a19d31391
Update 'validate=' parameter documentation to make clear that the command
...
passed via this paramter is not passed via shell and so all shell features
will not work.
2014-03-24 09:06:25 -06:00
James Tanner
ea5186ca63
Fixes #6590 add set_remote_user parameter to synchronize
...
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
2014-03-20 13:56:07 -04:00
Steve Smith
e157355fd6
Only unlink the symlink tempfile on error if it was created in the
...
previous operation.
2014-03-20 13:14:24 +01:00
Brian Coca
1b38bd8a40
fixed issue with tmp file (path can include filename) and added missing
...
else which made it try to link x2
2014-03-20 07:55:53 -04:00
Brian Coca
6e6ad97239
now correctly checks absolute path for src= existance for links
...
also updated docs to be a bit clearer on symlink behaviour
2014-03-20 07:49:25 -04:00