1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

4575 commits

Author SHA1 Message Date
Andrew DeMaria
5fdd2a7b01 Fix #8047
Ensure that json is returned when only updating the cache and in check mode
2014-07-12 10:57:30 -05:00
James Cammarata
8a6cfa1a23 Merge pull request #8103 from Jmainguy/mysql_db_6214
mysql_db: Fix error message for #6214
2014-07-11 14:47:03 -05:00
James Cammarata
fe3f6b3253 Merge pull request #8104 from AdmiralNemo/patch-1
Correct regex in is_keyid
2014-07-11 14:30:35 -05:00
James Cammarata
aa08368b8f Merge pull request #8094 from ghjm/vsphere-fixes
Fixed tracebacks during VM creation. Fixes #8067.
2014-07-11 14:22:53 -05:00
Dustin C. Hatch
dc304e6488 Correct regex in is_keyid
The `rpm_key` module claims to take a key ID as an argument, however it fails if one is actually given:

    msg: Not a valid key DEADBEEF

The reason for this is the regular expression in the `RpmKey.is_keyid` method is incorrect; it will only match the literal string "0-9a-f" exactly 8 times, rather than exactly 8 characters in the set 0-9 or a-f.
2014-07-11 14:02:25 -05:00
Jonathan Mainguy
40ef07a286 Errors out with stderr 1049, unknown database: when importing a database that does not exist 2014-07-11 14:57:45 -04:00
James Cammarata
5e0d07c93e Merge pull request #8092 from ghjm/mysql-exceptions
Added exception handling to database creation and deletion. Fixes #8075.
2014-07-11 11:59:12 -05:00
James Cammarata
9dc1931576 Merge pull request #8093 from ghjm/mysql-dbname
Switched primary and alias names of the name/db parameter. Fixes #8065.
2014-07-11 11:57:20 -05:00
Michael DeHaan
fbdb10d8a5 Documentation simplification for git module parameter 2014-07-11 08:44:29 -04:00
Graham Mainwaring
fb83bdffa8 Fixed tracebacks when datacenter not found, when notes not given, and when collecting facts after VM creation. Fixes #8067. 2014-07-10 23:05:23 -04:00
Graham Mainwaring
22390e50e5 Switched primary and alias names of the name/db parameter, to match documentation. Fixes #8065. 2014-07-10 22:37:46 -04:00
Graham Mainwaring
980d9da7e9 Added exception handling to database creation and deletion. Fixes #8075. 2014-07-10 22:28:56 -04:00
James Cammarata
c96b2ae391 Merge pull request #8080 from ciupicri/service
Remove unused code
2014-07-10 12:27:53 -05:00
James Cammarata
4d86bbe6dc Merge pull request #8086 from dataxu/dev-fix-typo
Bug Fix - fixed the choices typo got the ec2_asg module
2014-07-10 12:20:21 -05:00
James Cammarata
3a6d00f81d Add note about changing resource_tags to required in ec2_vpc 2014-07-10 12:18:35 -05:00
James Cammarata
2184b15542 Merge branch 'psa-resource-tag-required' into devel 2014-07-10 12:17:39 -05:00
Matt Ferrante
03fc2714f1 fixed the choices typo got the ec2_asg module 2014-07-10 11:01:19 -04:00
James Cammarata
3e7d91723f Adding version_added for new vm_hw_version field in vpshere_guest 2014-07-10 08:53:56 -05:00
James Cammarata
87d1cdd035 Merge branch 'fix-7206' of https://github.com/hiciu/ansible into hiciu-fix-7206 2014-07-10 08:19:05 -05:00
James Cammarata
dc89cc5f44 Merge pull request #8079 from Jmainguy/mysql_db_8070
Makes ansible fail if login_port is defined and login_host is either not...
2014-07-09 15:49:45 -05:00
Cristian Ciupitu
6a8bc42014 Remove useless code 2014-07-09 23:11:15 +03:00
Jonathan Mainguy
90f7f82224 Makes ansible fail if login_port is defined and login_host is either not defined, or defined as localhost. This is because if login_host is localhost then MySQLdb will use the socket instead of TCP. This leads to confusion for ansible users as, when a port is defined it gets ignored if login_host is localhost. This is to fix the bug reported by wrosario #8070. Info on MysqlDb can be read here http://mysql-python.sourceforge.net/MySQLdb.html 2014-07-09 14:38:27 -04:00
James Cammarata
0798f3cda4 Merge branch 'issue_7848' of https://github.com/mpeters/ansible into mpeters-issue_7848 2014-07-09 12:24:06 -05:00
James Cammarata
26707568c7 Merge branch 'issue_7906' of https://github.com/mpeters/ansible into mpeters-issue_7906 2014-07-09 12:09:40 -05:00
James Cammarata
aecd292f13 Merge branch 'resource-tag-required' of https://github.com/psa/ansible into psa-resource-tag-required 2014-07-09 11:49:41 -05:00
James Cammarata
06f72ca3b1 Merge branch 'bug/8057' of https://github.com/ericwb/ansible into ericwb-bug/8057 2014-07-08 14:38:35 -05:00
Andreas Fleig
30ad859fe0 ini_file: replace lambda with named function
Fixes #6876
2014-07-08 10:17:03 -05:00
James Cammarata
0da5996bb5 Merge pull request #8049 from ranjan/dev
Provision VM using virtual network.
2014-07-08 10:11:18 -05:00
Eric Brown
cdedb0f817 Adds an option to specify the glance endpoint type
Some environments that utilize an SSL terminator with a self-signed
certificate can use the publicURL without getting certificate
verify errors.  This allows using the internalURL with in my case
is HTTP and not HTTPS.

Closes issue: #8057
2014-07-08 00:30:40 -07:00
James Cammarata
1f2a436bbf Merge pull request #8038 from caphrim007/correct-missing-msg-argument
Fix missing msg argument
2014-07-05 00:30:20 -05:00
James Cammarata
ec16b18bab Merge pull request #8036 from sqs/remove-fragile-RDS-instance-type-validation
Remove validation of RDS DB instance type names because Amazon frequently adds new ones
2014-07-05 00:29:12 -05:00
James Cammarata
1f813ba128 Merge pull request #8022 from psa/vpc-gateway-peering
Fix for #7368 breaks peering connections. Unreak them.
2014-07-05 00:08:04 -05:00
Tim Rupp
4a871f496a Fix missing msg argument
The following patch adds a missing 'msg=' syntax. An exception is raised
in ansible if this block is reached during the execution of the module

    TypeError: fail_json() takes exactly 1 argument (2 given)

With the 'msg=' added, you get a more informative error. For example

    msg: No settings provided to update_domain().
2014-07-04 14:00:15 -05:00
Michael DeHaan
1a3a3af04c Merge pull request #8015 from cchurch/test_win_service
win_service module updates and tests
2014-07-03 19:29:24 -05:00
Quinn Slack
9190df2aa9 Remove validation of RDS DB instance type names because Amazon frequently adds new ones 2014-07-03 15:57:28 -07:00
Ranjan Kumar
ac252ea731 Provision VM using virtual network. 2014-07-03 15:36:51 +05:30
Paul Armstrong
97b3e8c6e4 Fix for #7368 breaks peering connections. Unreak them. 2014-07-02 23:13:29 +00:00
James Cammarata
746f52c5aa Merge pull request #7896 from botify-labs/feature/add-instance-monitoring-to-ec2-lc
Adds support for Cloudwatch detailled monitoring in ec2_lc module.
2014-07-02 09:50:27 -05:00
James Cammarata
0ee28c1a0e Make sure subnets and route_tables are initialized before using
Fixes #7712
2014-07-02 09:26:51 -05:00
Chris Church
efc07cf627 Return service name, display name, start mode and state from win_service module. 2014-07-02 08:12:40 -04:00
Paul Armstrong
d5b6781482 Make resource_tags required and do whitespace cleanup 2014-07-01 12:33:06 -07:00
Hector Acosta
d3268d05ec Correctly handle .repo files in zypper_repository module
Before the changes, removing a repository required a repo url. This shouldn't be required since zypper allows removing a repo based on its alias (mapped to name in this module).

The name variable was always required, which is misleading since repofiles provide their own alias. So a runtime check was added to avoid this confusion.

Additionaly, running this module on .repo files weren't idempotent. e.g

Before:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"msg": "Repository named 'devel_languages_python' already exists. Please use another alias.\n", "failed": true}

After:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": false}

Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
2014-06-26 13:17:27 -07:00
James Cammarata
29434b06b8 Merge pull request #7942 from sidred10/devel
Fixed FreeBSD ports install issue
2014-06-26 11:50:33 -05:00
sid
08370b3caf Fixed FreeBSD ports install issue 2014-06-26 20:52:57 +05:30
Maxim Odinintsev
82c026387f Successfull exit if sync=yes and no package provided 2014-06-26 15:02:15 +03:00
Maxim Odinintsev
a58912773d Success exit if sync=yes and no package provided 2014-06-26 14:55:16 +03:00
James Cammarata
05eb6aacec Merge pull request #7925 from devpopol/fixes/api_error
fixes the now-incorrect module for ApiError -- noticed since 0.3.2
2014-06-25 22:33:22 -05:00
James Cammarata
2305ac9881 Merge pull request #7930 from trbs/apt_key_fetch_url_failure_codes
apt_key clear message when downloading key returns an (http) error code
2014-06-25 22:27:08 -05:00
Michael DeHaan
f6c7e34527 Merge pull request #7931 from quiver/fix-yum-module-doc
In yum module example, use present/absent instead of installed/removed
2014-06-25 17:03:10 -05:00
George Yoshida
779c6cb7f8 In the yum module example, use present/absent instead of installed/removed 2014-06-25 23:21:43 +09:00
trbs
dfc625a7df apt_key clear message when downloading key returns an (http) error code 2014-06-25 15:30:34 +02:00
Tim Ruffles
676f0a6e76 grammar fix 2014-06-25 14:00:01 +01:00
Stephen Paul Suarez
49cf5831c5 support old and new versions of APIError 2014-06-25 14:52:00 +08:00
Stephen Paul Suarez
dfabf2707a fixes the now-incorrect module for ApiError
https://github.com/dotcloud/docker-py/blob/0.3.2/docker/errors.py
- ApiError is now(0.3.2) under the docker.errors
2014-06-25 14:20:07 +08:00
James Cammarata
375edbd087 Check to make sure key exists in tag list before using it
Fixes #7910
2014-06-24 13:54:33 -05:00
James Cammarata
98f8438236 Updating the other classes in the group module to match #7249 2014-06-24 12:28:43 -05:00
James Cammarata
bdd9b4cac4 Merge pull request #7249 from jfchevrette/implement-group-checking-if-state-present
Allow group module to handle check_mode properly when group.state=present and group already exists
2014-06-24 12:27:31 -05:00
James Cammarata
5951f14dcb Merge pull request #7915 from gitaarik/devel
Add examples for `shell` and `command` modules.
2014-06-24 12:24:21 -05:00
Rik
59d98993eb Added examples to the command module 2014-06-24 13:47:23 +02:00
Rik
1146c09f9d Added examples to the shell module 2014-06-24 13:45:33 +02:00
Sam Hanes
769ee61f66 Restore #6484 reverted by c751168. 2014-06-23 17:12:19 -07:00
Michael Peters
45cf1dbbc5 Fixing issue #7906
Catch any InvalidInstanceID.NotFound errors coming from the boto library
when trying to find the newly created instance. When this happens We should
just wait and try again.
2014-06-23 16:58:07 -04:00
Frédéric de Villamil
126d15cc43 Adds support for Cloudwatch detailled monitoring in ec2_lc module.
Enabling detailled monitoring in the launch config is mandatory to be able to activate cloudwatch in the to be created autoscaling group.
2014-06-23 21:00:58 +02:00
James Cammarata
6bd0621037 Merge branch 'devel' of https://github.com/ansible/ansible into devel 2014-06-23 12:59:12 -05:00
James Cammarata
5ad7dcf4f0 Merge pull request #6766 from Jmainguy/mysql_db_bug
mysql_db module now correctly fails on import if bz2 or gz fails.
2014-06-23 12:42:42 -05:00
James Cammarata
9564818e1e Merge branch 'fix_lineinfile_newlines' into devel 2014-06-23 12:38:12 -05:00
James Cammarata
2bfdad1e86 Merge pull request #7904 from loglevel9/7903
force evaluation of vars memory_mb, num_cpus to be int fixes #7903
2014-06-23 12:35:08 -05:00
James Cammarata
eef05f7b31 Merge branch 'botify-labs-bug/fix-health-check-to-zero-bug/7898' into devel 2014-06-23 12:32:01 -05:00
James Cammarata
9137679e59 Merge branch 'bug/fix-health-check-to-zero-bug/7898' of https://github.com/botify-labs/ansible into botify-labs-bug/fix-health-check-to-zero-bug/7898 2014-06-23 12:31:15 -05:00
James Cammarata
5d4046204b Merge pull request #7893 from botify-labs/feature/add-launch-group-sport-support
Adding support for spot instances in ansible_lc.
2014-06-23 12:09:02 -05:00
James Cammarata
67fb2e653e Merge branch 'upgrade-release' of https://github.com/amenonsen/ansible into amenonsen-upgrade-release 2014-06-23 10:35:48 -05:00
Dann Bohn
677e99e375 force evaluation of vars memory_mb, num_cpus to be int fixes #7903 2014-06-23 11:16:03 -04:00
Frédéric de Villamil
1f3663b196 Adds support for health_check_period and health_check_type in ec2_asg module.
Default is set to 300 seconds, which is AWS default.

This PR fixes a bug (#7898) where instances created within an autoscaling group using the `ec2_asg` module gets immediately terminated because the `health_check_period` is set to 0, which causes the instance to be checked without having the time to actually boot.

Adding `health_check_type` is needed because you may want to check your instance health against an ELB instead of just EC2 default cloudwatch.
2014-06-23 12:09:31 +02:00
Frédéric de Villamil
93daebe1e2 Adding support for spot instances in ansible_lc.
AWS allows to define launch configuration with spot instances. This is also natively supported by boto (see http://boto.readthedocs.org/en/latest/ref/autoscale.html)
2014-06-23 09:05:47 +02:00
Michael DeHaan
4acc93b665 Merge pull request #7889 from chrishoffman/win_group
Adding win_group module
2014-06-22 11:26:27 -05:00
Chris Hoffman
0dab7b014b Adding win_group module 2014-06-22 09:01:04 -04:00
Chris Hoffman
1c2d244964 Fixing bug with stopped state 2014-06-21 22:01:02 -04:00
Chris Hoffman
844e90093b Better propagation of cmdlet errors 2014-06-21 21:59:53 -04:00
Chris Hoffman
31f5069212 Using generic windows service for example 2014-06-21 21:58:26 -04:00
Michael DeHaan
122fff970f Merge pull request #7880 from yuyak/fix_typo_in_apt_doc
Fix typo in apt module documentation
2014-06-21 11:32:08 -05:00
Michael DeHaan
1d632d65ae Merge pull request #7881 from cchurch/devel
Fix typo in powershell setup module.
2014-06-21 11:31:35 -05:00
Chris Hoffman
8af38ae436 Adding win_service module 2014-06-21 12:04:11 -04:00
Chris Church
f59041871e Fix typo in powershell setup module. 2014-06-21 10:27:43 -04:00
yuyak
5482208eee Fix typo in apt module documentation 2014-06-21 21:27:57 +08:00
James Cammarata
70abc6f6de Merge pull request #7374 from hfinucane/wait_for_pipes
Allow wait_for to wait on non-traditional files
2014-06-20 15:55:10 -05:00
James Cammarata
1c3a654912 Conditionally try to get ebs_optimized parameter from instance 2014-06-20 14:26:21 -05:00
Yap Sok Ann
f80467e013 ec2_vpc: Fix error when using InstanceId as a route gateway.
See https://github.com/ansible/ansible/issues/7368

Fixes #7368
2014-06-20 14:08:22 -05:00
James Cammarata
1c318fa3bd Merge branch 'exit_json' of https://github.com/psa/ansible into psa-exit_json 2014-06-20 13:59:55 -05:00
James Cammarata
8e0148f084 Merge branch 'lvg_dm_names' of https://github.com/ajsalminen/ansible into ajsalminen-lvg_dm_names 2014-06-20 13:24:07 -05:00
James Cammarata
d0a115972a Merge branch 'pkit-git_fix' into devel 2014-06-20 12:48:32 -05:00
James Cammarata
1864347f44 Merge branch 'git_fix' of https://github.com/pkit/ansible into pkit-git_fix 2014-06-20 12:47:21 -05:00
James Cammarata
cc9658463b Merge pull request #7868 from simono/patch-1
win_feature: Fix Description.
2014-06-20 11:29:22 -05:00
James Cammarata
bba4f58240 Merge pull request #7856 from njharman/devel
Lineinfile now supports symlinks.
2014-06-20 11:14:43 -05:00
James Cammarata
4d3205b753 Update authors for modprobe module 2014-06-20 11:12:49 -05:00
James Cammarata
81dad9f355 Merge branch 'add_name' of https://github.com/stygstra/ansible into stygstra-add_name 2014-06-20 11:12:24 -05:00
Michael Peters
87a6290065 Use the right name for the vpc_id parameter
Fixes #7853
2014-06-20 10:49:41 -05:00
Simon Olofsson
5fe8cf1948 win_feature: Fix Description. 2014-06-20 17:14:36 +02:00
James Cammarata
48dbb79fbe Merge branch 'issue_5679_lineinfile' into fix_lineinfile_newlines 2014-06-20 00:19:35 -05:00
James Cammarata
d8bb116c1a Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel 2014-06-19 22:41:58 -05:00
Michael DeHaan
5156794738 Merge pull request #7861 from cchurch/devel
Windows Remote Support
2014-06-19 22:10:41 -05:00