ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity
40790 commits 10 branches 167 tags 272 MiB
Commit graph

359 commits

Author SHA1 Message Date
James Cammarata
c9a004227e Improve error catching from malformed playbook data 
Fixes #12478
 2015-09-23 08:56:36 -04:00
James Cammarata
e81947c3b4 Fix vars_prompt short form support (and mark deprecated) 2015-09-09 17:52:44 -04:00
James Cammarata
0859ba7726 Adjust field loading order for vars and tweak post_validate exclusion logic 
FieldAttributes will now by default not be post_validated unless a flag
is set on them in the class, as a large number of fields are really there
simply to be inherited by Task/PlayContext and shouldn't be templated too
early.

The other (unrelated to the base issue) in #12084 is also fixed here, where
the roles field is loaded before vars/vars_files, meaning there are no vars
yet loaded in the play when the templating occurs.

Fixes #12084
 2015-08-28 15:56:42 -04:00
James Cammarata
af41ba929c Add float and percent types for FieldAttributes 
Also sets the max_fail_percentage value to the percent type.
 2015-08-26 12:03:47 -04:00
James Cammarata
e7d0c9f820 Re-add vars to Base and standardize var processing 
Fixes #11779
 2015-08-07 00:06:30 -04:00
James Cammarata
37e38924de Allow field attributes to have priorities 
So that roles are loaded ahead of all other play fields, meaning any
plugins contained within the roles are loaded first before tasks.

Fixes #11858
 2015-08-05 13:54:00 -04:00
James Cammarata
8279557e8f Allow role names to be templated 
Fixes #10858
 2015-08-03 16:26:13 -04:00
James Cammarata
bcbcfc79be Fix relative paths for included files 
Also modifies the Play class to not include become* fields in the
post-validation step.

Fixes #11353
 2015-08-03 12:04:31 -04:00
James Cammarata
71867f9480 Remove vars attribute from base 
Fixes #11779
 2015-07-29 09:45:30 -04:00
James Cammarata
4b6525fb58 Fix handler flushing to match how v1 worked 
Also adds meta tasks to the list of tasks excluded from tag filtering

Fixes #11574
 2015-07-22 11:21:38 -04:00
Pierre-Louis Bonicoli
8c392a94b7 Play.get_name: remove prefix, return name only 2015-07-20 12:41:39 +02:00
Abhijit Menon-Sen
28e2eae902 Make gathering=explicit work again 
There was a confusion between the valid values for defaults.gathering
(explicit/implicit/smart) and a play's gather_facts setting (boolean),
which resulted in gathering=explicit being ignored.
 2015-07-17 13:05:00 +05:30
James Cammarata
f8ddf2eb04 Move role cache into the play to avoid roles crossing play boundaries 2015-07-10 02:43:53 -04:00
James Cammarata
b520d5bc60 Lots of fixes for integration test bugs 2015-07-10 01:53:59 -04:00
Brian Coca
b5f3e84014 now allows for empty vars sections, returns empty dict 
fixes #11532
 2015-07-08 22:45:01 -04:00
James Cammarata
24226646fc When loading the play hosts list, enforce some consistency 
Fixes #9580
 2015-06-28 01:00:32 -04:00
James Cammarata
cb5f630f33 Don't post_validate vars and vars_files on Play objects 
Fixes #11343
 2015-06-22 11:23:23 -04:00
Benno Joy
be81b650e8 fixes issue 11286 where role handlers are not run 2015-06-21 00:36:37 -04:00
James Cammarata
f3f3fb7c49 Fixing vars_prompt 2015-06-04 13:54:51 -04:00
James Cammarata
50542db0be Make the default playbook name an empty string (v2) 2015-05-06 02:56:52 -05:00
James Cammarata
fba5588028 Handle empty role definitions in YAML (v2) 2015-05-05 13:17:04 -05:00
James Cammarata
ce3ef7f4c1 Making the switch to v2 2015-05-03 21:47:26 -05:00
Carlos E. Garcia
cfbfd38723 just a few spelling error changes 2015-04-28 09:36:42 -04:00
James Cammarata
f4172fb9da Fix tag handling on meta:flush_handlers tasks 
Fixes #10758
 2015-04-17 13:02:09 -05:00
Jesse Rusak
652cd6cd5e Fix --force-handlers, and allow it in plays and ansible.cfg 
The --force-handlers command line argument was not correctly running
handlers on hosts which had tasks that later failed. This corrects that,
and also allows you to specify force_handlers in ansible.cfg or in a
play.
 2015-04-10 19:38:59 -04:00
Brian Coca
0d1e2e74a1 converted error on play var initialization into warning with more information 2015-03-31 23:07:03 -04:00
Brian Coca
662b35cbce readded sudo/su vars to allow role/includes to work with passed sudo/su 2015-03-27 18:30:42 -04:00
Brian Coca
bbdcba53da fixed bug on using su on play level not setting become method correctly 2015-03-16 19:37:03 -04:00
Brian Coca
a675b10b3b Merge pull request #10329 from bcoca/var_merge_combined 
changed from hash_merge to combine vars which resets default to
 2015-03-12 10:58:12 -04:00
Brian Coca
de5eae2007 fixed traceback when x_user implicitly sets the become method 
Fixes #10430

Also removed redundant resolution of sudo/su for backwards compatibility which
confused the conflict detection code.
 2015-03-11 12:18:53 -04:00
Brian Coca
5f6db0e164 preliminary privlege escalation unification + pbrun 
- become constants inherit existing sudo/su ones
- become command line options, marked sudo/su as deprecated and moved sudo/su passwords to runas group
- changed method signatures as privlege escalation is collapsed to become
- added tests for su and become, diabled su for lack of support in local.py
- updated playbook,play and task objects to become
- added become to runner
- added whoami test for become/sudo/su
- added home override dir for plugins
- removed useless method from ask pass
- forced become pass to always be string also uses to_bytes
- fixed fakerunner for tests
- corrected reference in synchronize action plugin
- added pfexec (needs testing)
- removed unused sudo/su in runner init
- removed deprecated info
- updated pe tests to allow to run under sudo and not need root
- normalized become options into a funciton to avoid duplication and inconsistencies
- pushed suppored list to connection classs property
- updated all connection plugins to latest 'become' pe

- includes fixes from feedback (including typos)
- added draft docs
- stub of become_exe, leaving for future v2 fixes
 2015-03-10 18:42:36 -04:00
Brian Coca
c81d981164 Merge pull request #10183 from bcoca/tag_control 
adds complex tag management
 2015-02-25 10:36:11 -05:00
Brian Coca
4fa51652b4 fixed typoe in combined_Vars 2015-02-24 05:26:41 -05:00
Brian Coca
ce764063f1 corrected merge vs combined in all pertinent sections 2015-02-24 05:14:22 -05:00
Toshio Kuratomi
920b71984e lists => frozenset as we're only using them in membership checks 2015-02-23 07:09:33 -08:00
Brian Coca
f6a6df2169 removed unused method 2015-02-13 08:27:35 -05:00
Brian Coca
95fa770ba0 adds complex tag management 
Adds a special tag:
 - always: always runs no matter what --tags, --skip-tags say

Adds 4 special keywords for --tags/skip-tags
 - all: all tagged + untagged tasks
 - tagged: only tagged tasks
 - untagged: only untagged tasks
 - always: only run tasks tagged 'always'
 2015-02-13 08:27:07 -05:00
Brian Coca
cbbe2f4e26 more resilient errors for bad host declarations in play 
should fix #10148
 2015-02-03 10:26:48 -05:00
Brian Coca
1698b17b14 Merge pull request #8651 from ks888/enable-env-kw-at-play-level 
Enable environment keyword at play level
 2015-01-02 11:07:35 -05:00
James Cammarata
f1386bb114 Use more variable sources when templating the play ds 
Fixes #9699
 2014-12-03 12:44:32 -06:00
James Cammarata
6570a6c6de Use additional vars when templating included file names 
Fixes #9669
 2014-12-01 15:00:14 -06:00
Hagai Kariti
bc505050b0 Don't template play vars by themselves, it's too early 2014-11-26 15:45:38 +02:00
James Cammarata
968c56d765 Expand playbook_dir in time for loading tasks 
Fixes #9618
 2014-11-25 13:01:08 -08:00
Kishin Yagami
ac4dc1f739 enable environment keyword at play level 2014-11-22 10:41:13 +09:00
James Cammarata
4b6b58ab11 Fix role parameter precedence after 9a0f8f0 
Fixes #9497
 2014-11-20 12:53:48 -06:00
James Cammarata
9a0f8f0158 Split out various vars-related things to avoid merging too early 
Fixes #9498
 2014-11-17 15:31:55 -06:00
James Cammarata
12d5b75a43 Template play vars after reading them 
Fixes #9242
 2014-10-06 10:50:55 -05:00
James Cammarata
0c40c6c23c Fix order of resolving dependent role variables from vars files 
Also adds a new class to the test_var_precedence test to check for
this type of error in the future.

Fixes #9178
 2014-10-03 13:30:47 -05:00
James Cammarata
313f26f866 Fix issue with vars precedence from roles 
Fixes #9219
 2014-09-30 15:50:46 -05:00
James Cammarata
8cc3543918 Re-allow templating of complex_args, but count params to prevent injection 
Fixes #8810
 2014-09-05 14:24:05 -05:00
Will Thames
ada9074276 Allow installation of roles from yaml roles file 
Added docs
Added more tests
Improved how roles are returned from the parsers
 2014-08-21 17:15:23 -04:00
Will Thames
46b59b02ed Friendly Role Names and roles from URLs 
* Roles can now be given a friendly name as third field in role spec csv
* Roles can be installed from URL (not just from archived SCMs)
* Integration tests to demonstrate this
* Unit tests to ensure that role spec parsing works as expected
 2014-08-21 17:15:23 -04:00
Will Thames
1803976a40 Ensured that role version can be specified in role dependencies 2014-08-21 17:15:23 -04:00
Will Thames
c2fe33f9f4 Tidied up a little, added tests 
Moved repo_url_to_role_name to common method in ansible.utils
Added unit test for repo_url_to_role_name
Added integration tests for galaxy
 2014-08-21 17:15:23 -04:00
Will Thames
b550cb9bc3 Need to take URLs into account when running playbooks too 
Ensure that if meta/main.yml has dependencies containing URLs
these are correctly resolved at playbook runtime.

Update role_name during run time so that output of e.g. task names
look sensible
 2014-08-21 17:15:23 -04:00
Serge van Ginderachter
7051cdeb57 roles: make role_path (path of current role) available as variable to the task 2014-08-21 11:56:27 +02:00
James Cammarata
8a1fbed5d6 Correct variable blending from vars_files with hostvars in them 
Fixes #8638
 2014-08-20 15:49:01 -05:00
James Cammarata
8a5675ca9f Fixing no_log for the playbook level use 
Fixes #8647
 2014-08-19 10:35:01 -05:00
James Cammarata
542f07128e Correct check for role library/ existence 
Fixes #8633
 2014-08-18 13:33:23 -05:00
James Cammarata
fc7859f445 Make sure playbook_dir variable is an absolute path 
Fixes #8317
 2014-08-12 09:51:44 -05:00
James Cammarata
ac8950fd36 Set special vars in play.vars rather than load_vars 
Also refactors playbook loading code relating to vars in playbooks
to a sub-function.

Fixes #8534
 2014-08-11 19:23:54 -05:00
James Cammarata
783a1e3dfc Fixing broken patch 20957a1 
Also adds integration tests for nested includes with conditionals
 2014-08-11 14:58:48 -05:00
James Cammarata
20957a1b85 Remove duplicate compiling of task when: statements 
Fixes #8538
 2014-08-11 13:23:07 -05:00
Josh Drake
aa419044c4 WIP on the re-implementation of fact caching and various backends. 2014-08-11 12:23:05 -04:00
Howard Oettle
cbf0bd6baf playbook: permit the serial attribute to be a pecentage string as well as well as a straight integer 2014-08-08 13:46:57 -04:00
Michael DeHaan
8c4161d4a1 Merge branch 'retf_py' of git://github.com/berendt/ansible into devel 
Conflicts:
	lib/ansible/inventory/vars_plugins/group_vars.py
	plugins/callbacks/mail.py
 2014-08-08 12:17:37 -04:00
James Cammarata
e6fa50a306 Move splitter to module_utils so modules can use it and fix command arg splitting 
Fixes #8338
 2014-07-29 14:55:16 -05:00
James Cammarata
6e814566de Unquote params passed to an include statement 
Fixes #8315
 2014-07-28 16:35:52 -05:00
James Cammarata
6eac47e519 Use split_args instead of shlex.split for included params 
Fixes #8296
 2014-07-26 00:30:42 -05:00
Michael DeHaan
0fad9575e9 Refine error message about invalid ops since people forget to indent tasks fairly often. 2014-07-17 10:13:10 -04:00
James Cammarata
ff04b2b532 Allow empty yaml vars files 
Fixes #7843
 2014-07-04 23:10:32 -05:00
James Cammarata
6d9cc64e0f Add role_names to valid keys entry for plays 
Prevents a "not a legal parameter" error for play ds structures that
may be passed into the Play() constructor, which really is mainly a
concern during tests.
 2014-06-16 10:00:43 -05:00
James Cammarata
74f20ebf79 Removing cruft leftover from the deprecation of include+with_items 
Also cleaning up integration tests that had checks for the empty item
attribute in certain results.

Fixes #7535
 2014-06-03 13:33:26 -05:00
James Cammarata
360ffc4dfd Properly merge role conditionals in with pre-existing conditionals 
Fixes #7387
 2014-05-14 01:45:35 -05:00
James Cammarata
187619c7fe Use utils.combine_vars on vars_files data 
Fixes #7345
 2014-05-13 11:24:41 -05:00
James Cammarata
2e2e5d5321 Use the existing module_vars during the templating of module_vars 
Since some of the vars contained in there may be used in the templating
of other variables. This also reverts e83a494 which originally fixed
issue #6979 but broke some other variable related things.

Fixes #6979
Fixes #7321
Fixes #7332
 2014-05-08 13:09:36 -05:00
Christian Berendt
6676720ce5 fixed typos found by RETF rules in PY files 
rules are avaialble at https://en.wikipedia.org/wiki/Wikipedia:AutoWikiBrowser/Typos
 2014-05-03 18:40:05 +02:00
Michael Scherer
0f0f5ff1ce Give more information when a task is empty 
I made a typo in a playbook and was great by:

    ERROR: expecting dict; got: None

The issue was a single - on the last line of a playbook.
With the name of the file, I was able to see right away where the
error was.
 2014-04-23 13:13:46 +02:00
James Cammarata
e83a494e41 Make sure VARS_CACHE for hosts are updated with the play vars too 
Fixes #6979
 2014-04-22 14:42:43 -05:00
James Tanner
4eb626825b Refactor play._update_vars_files_for_host to make common functions and easier debugging 
Fixes #4883
 2014-04-10 13:43:59 -04:00
James Cammarata
317c2f4bc0 Fixes to variable issues introduced by recent changes 
Fixes #6801
Fixes #6832
 2014-04-02 19:49:38 -05:00
James Cammarata
a6a4680e5c Fix variable naming issue in _load_tasks() 
Fixes #6800
 2014-04-02 16:13:22 -05:00
James Cammarata
e2d86e4f43 Splitting SETUP_CACHE into two caches, one for host vars and one for setup facts 2014-04-01 16:23:33 -05:00
James Cammarata
612a1a64f0 Apply extra vars after all other vars have been merged in a play 
Fixes #6677
 2014-03-31 15:31:10 -05:00
James Tanner
38de8cc87e Addresses #6705 Only set the role_uuid inside the role vars 2014-03-26 14:43:07 -04:00
James Tanner
8991e403e8 Fixes #6705 Give each role a unique uuid and apply tags only to tasks matching the uuid 2014-03-26 13:29:41 -04:00
James Cammarata
9ede6f7f49 Convert gather_facts to a boolean value if it is not None 
Fixes #5618
 2014-03-26 12:04:06 -05:00
James Tanner
95c79ad483 Fixes #4239 merge injects with new vars loaded from files 2014-03-20 13:12:33 -04:00
James Tanner
d327e3d11a Fixes #5622 included tasks in roles now inherit tags from the role 2014-03-20 11:56:13 -04:00
Brian Coca
4dfa40f18e added gathering control to ansible, defaults to 'smart' 2014-03-19 18:03:03 -04:00
James Cammarata
eb7717aa02 Make sure all tags are in a list before merging for role deps 
Fixes #6557
 2014-03-18 12:32:22 -05:00
James Cammarata
84908a57fc Don't filter role deps on tags 
Also, fixed a bug where the tags were being merged into the wrong
data structure (passed_vars) in _build_role_dependencies()

Fixes #6439
Fixes #5709
 2014-03-17 23:03:16 -05:00
James Cammarata
7edee91aba Fixing a bug in role tag handling where only the first tag was used 
Fixes #6517
 2014-03-17 11:28:54 -05:00
Michael DeHaan
b8f1e4f765 Merge pull request #6134 from veeti/include_with_items_path 
Show the offending file name with the include + with_items error
 2014-03-16 15:10:31 -05:00
Michael DeHaan
9cdbc53741 Merge pull request #6420 from bcoca/role_names 
added new role_names variable that exposes current roles list
 2014-03-16 14:42:40 -05:00
Cristian Ciupitu
0749112286 Micro-optimization: replace s.find(x)!=-1 with x in s 
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
 2014-03-16 13:10:28 -04:00
James Cammarata
86d2ee4b97 Don't append tags from roles to the plays tags list 
Fixes #6393
 2014-03-12 10:41:18 -05:00
Brian Coca
906e59d8a8 added new role_names variable that exposes current roles list 2014-03-11 22:13:29 -04:00
James Cammarata
6577ff5f85 Add tags from handlers to tag availability calculation 2014-03-10 16:06:13 -05:00
James Cammarata
04a6dc6d12 Check for skipped tags in passed role variables before adding to them 
Fixes #6330
 2014-03-08 18:55:42 -06:00