telsacolton
06963c7826
Make file hardlink error message reasonble
...
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
2014-05-14 16:54:26 -05:00
telsacolton
0d8104b8b7
Give reasonable error when symlink fails
...
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
2014-05-14 16:31:20 -05:00
James Cammarata
a9311a5dcb
Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms
2014-05-14 13:53:08 -05:00
James Cammarata
b753625dbf
Refuse to convert a non-empty directory into a link with the file module
...
Also adds an integration test for the above.
Fixes #7254
2014-05-02 14:46:38 -05:00
Brian Coca
f079d022a3
now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-04-23 10:38:38 -04:00
Erika Heidi
036c7a7759
Possible docs error: 'path' instead of 'src'
...
I came to this example today (line 50), and when I tried it, I got an error:
`msg: src and dest are required for creating links`
So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
2014-04-23 16:00:22 +02:00
James Tanner
68cd7258b6
Fixes #6894 create docs fragment for files
2014-04-08 13:20:15 -04:00
Michael DeHaan
1fa19e29e8
Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
...
Application to other cloud providers would make very good sense.
2014-04-03 16:52:39 -04:00
James Tanner
9fe2bcd076
Merge #5903 from rhaido/ansible
...
Update files documentation for usage of force=True and hardlinks
2014-03-31 12:53:03 -04:00
Michael DeHaan
2ddb251538
Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile
...
Handle missing symlink tempfile
2014-03-28 11:11:32 -04:00
Steve Smith
e157355fd6
Only unlink the symlink tempfile on error if it was created in the
...
previous operation.
2014-03-20 13:14:24 +01:00
Brian Coca
1b38bd8a40
fixed issue with tmp file (path can include filename) and added missing
...
else which made it try to link x2
2014-03-20 07:55:53 -04:00
Brian Coca
6e6ad97239
now correctly checks absolute path for src= existance for links
...
also updated docs to be a bit clearer on symlink behaviour
2014-03-20 07:49:25 -04:00
Brian Coca
f6a75ebaf1
fixed issue with directory permissions on copy #6552
2014-03-18 22:29:22 -04:00
James Cammarata
5d8c9d3f0f
Merge branch 'file_fixes_clean' of https://github.com/bcoca/ansible into bcoca-file_fixes_clean
2014-03-17 14:03:26 -05:00
Cristian Ciupitu
0749112286
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
Brian Coca
2d25577e11
Fixes and cleanup to file functions and module
...
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
2014-03-15 13:54:24 -04:00
Sven Schliesing
f62cc1e351
Fix link in documentation
...
c(dest) -> c(path)
2014-03-06 13:16:29 +01:00
Michael DeHaan
6c43e0e010
Simplify file module parameter description.
2014-02-28 13:55:07 -05:00
Mike Grozak
f386e137fe
Updated the force parameter description; added one example how to create the symlinks pointing to non-absolute paths
2014-02-07 14:29:20 +01:00
Mike Grozak
d3b544e842
Found a way how to have symlinks towards files without absolute paths in prefixes; fixed incorrect force setting on the hard links, which can not point to non-existing files
2014-02-07 14:13:41 +01:00
Mike Grozak
2b4688a0bd
Started the development of the 'chdir' functionality for file module - creation symlinks without the base directory prefix
2014-02-06 17:20:32 +01:00
jctanner
9ed379b7f8
Merge pull request #5282 from rhaido/hard_link_fix
...
file module: Added to the file module the functionality to force conversion hard link...
2014-01-14 07:15:46 -08:00
jctanner
aa1f9f24c3
Merge pull request #5264 from drewlll2ll/file-fix
...
file module: Fixed missing prev_state == 'directory' in file
2014-01-06 14:07:07 -08:00
Maykel Moya
0711447d3a
Missing "is" in file module description
2013-12-26 12:34:46 +01:00
Jens Rantil
1b6019f6e0
module(file): Fail instead of exit on exception
2013-12-13 21:34:19 +01:00
Jens Rantil
f4aa808b8d
module(file): state what went wrong on exception
2013-12-13 21:33:19 +01:00
Mike Grozak
ed7c9a1fbb
Added to the file module the functionality to force conversion hard link and symlink when the force attribute is set to 'yes'
2013-12-13 17:10:50 +01:00
drewlll2ll
54a28eb45b
Added prev_state for directory
2013-12-12 09:44:29 -05:00
Jens Rantil
705316e303
file module: Don't catch SystemExit
...
This fixes issue #5159 .
2013-12-04 13:13:49 +01:00
James Tanner
ad837709bd
Addresses #5023 Fix import comments
2013-12-02 15:13:49 -05:00
James Tanner
6000d636b3
Fixes #5023 Convert all modules to use new snippet import pattern
2013-12-02 15:11:23 -05:00
Michael DeHaan
f7c3975f21
Add version_added to all modules missing version_added information, the docs formatter will now
...
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
James Tanner
33242cacf3
Merge pull request #4375 from pfalcon/ansible
...
copy: Implement recursive copying if src is a directory.
2013-11-13 15:52:40 -05:00
James Tanner
5a3032a950
Fixes #4884 Do not prematurely exit from file module if src not defined
2013-11-12 18:17:20 -05:00
James Tanner
934ec1c0b6
Addresses #4801 Update file module docs to indicate behavior for relative src paths
2013-11-07 17:02:34 -05:00
sspans
904a129ac1
skip absolute path creation for old_src, not needed with the new relative links
2013-11-04 10:44:06 +01:00
sspans
684921c1c1
only require absolute paths for hardlinks
2013-11-04 10:37:36 +01:00
James Tanner
f4b59fe285
Fixes #4516 file module: check prev_state earlier and use that if state is not specified
2013-11-01 09:31:32 -04:00
Michael DeHaan
99d6726114
Revert "fix conversion from file to hardlink when force=yes"
...
This reverts commit 4d4518ed52
2013-10-27 11:51:43 -04:00
Dave Simons
4d4518ed52
fix conversion from file to hardlink when force=yes
...
Signed-off-by: Dave Simons <dave@inuits.eu>
2013-10-22 10:46:45 +02:00
jctanner
c737f222d5
Merge pull request #4480 from joemaller/absent_path_fix
...
ignore src when file module state=absent
2013-10-16 17:29:21 -07:00
Paul Sokolovsky
2e668f14f7
copy: Handle "no copy/propagate attrs only" for recursive mode well.
...
For this, add internal "original_basename" param to file module,
similar to copy module. (Param name is a bit misnormer now, should
be treated as "original basepath").
2013-10-15 18:40:40 +03:00
Joe Maller
8597bf6bba
ignore src when file module state=absent
2013-10-13 01:22:53 -04:00
Julian Yap
76cec9d360
Assume state='directory' if recurse is set and previous state was 'directory'
...
Resolves this issue: https://github.com/ansible/ansible/issues/2067
2013-10-11 15:56:14 -10:00
Andrew Pope
6342046da6
Fixed broken force=yes on files for directories
2013-10-11 18:02:18 -04:00
Michael DeHaan
b9c337e436
"touch" option on file is new in 1.4
2013-10-04 08:45:05 -04:00
James Cammarata
4a467f71cd
Change touched -> touch for new file state, and cleaning up docs
2013-09-22 09:16:07 -05:00
René Moser
3a0fd84115
file: added file attributes in state=touched
2013-09-22 12:54:24 +02:00
René Moser
573ea5bdce
file: skip in check_mode if state=touched
2013-09-22 12:53:49 +02:00
