1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

26761 commits

Author SHA1 Message Date
Joseph Callen
e4d7af368b Resolves issue with vmware_vswitch module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing.

Playbook
```yaml
   - name: Add a temporary vSwitch
      local_action:
        module: vmware_vswitch
        hostname: "{{ inventory_hostname }}"
        username: "{{ esxi_username }}"
        password: "{{ site_passwd }}"
        switch_name: temp_vswitch
        nic_name: "{{ vss_vmnic }}"
        mtu: 1500
```

Module Testing
```bash
TASK [Add a temporary vSwitch] *************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/esxi_network.yml:13
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566 )" )
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598 )" )
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801 )" )
localhost PUT /tmp/tmpLLExSG TO /root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/" > /dev/null 2>&1
localhost PUT /tmp/tmpyoAaHt TO /root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/" > /dev/null 2>&1
localhost PUT /tmp/tmpPcmaMZ TO /root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/" > /dev/null 2>&1
changed: [foundation-esxi-01 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-01", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}
changed: [foundation-esxi-02 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-02", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}
changed: [foundation-esxi-03 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-03", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}

```

Documentation fix
2016-12-08 11:33:51 -05:00
Thierno IB. BARRY
0f175cec07 Add ES 2.x support
Add compatibility between ES 1.x and ES 2.x.

bin/plugin install | remove [plugin_name] works on ES 1.x and ES 2.x
2016-12-08 11:33:51 -05:00
Rene Moser
e9667eb542 doc: replace yumrepo with yum_repository 2016-12-08 11:33:51 -05:00
Rene Moser
84259eb2d6 rename yumrepo to yum_repository 2016-12-08 11:33:51 -05:00
jhawkesworth@users.noreply.github.com
d5ad463a5a Add extra PS Drives so you can access other parts of the registry 2016-12-08 11:33:50 -05:00
Phil
55c671a18b removed hardcoded paths, check for .exe error exit code, use get-attr for required param check. 2016-12-08 11:33:50 -05:00
Phil
f1579a1207 init commit win_timezone 2016-12-08 11:33:50 -05:00
jhawkesworth@users.noreply.github.com
061365e892 First pass at adding win_regmerge module for handling bulk registry changes 2016-12-08 11:33:50 -05:00
Eike Frost
007b637e7a Add explicit argument_spec types to avoid misinterpretation and subsequent errors (i.e. getting an int instead of the expected str) 2016-12-08 11:33:50 -05:00
Matt Martz
2738ae94c0 Exclude modules that are importing requests 2016-12-08 11:33:50 -05:00
Borys Borysenko
149ebdb15f The size option is required for lvol module with state=present 2016-12-08 11:33:50 -05:00
Brian Coca
88c946ba4d added docs to blockinfile with_ interactions
fixes #1592
2016-12-08 11:33:50 -05:00
Michael Scherer
0670a6c56d Add documentation to explain that pvs will be created if needed
Fix #1720
2016-12-08 11:33:50 -05:00
Travis J Parker
b8c8bb5238 fixes documented command for svc sending SIGUSR1 2016-12-08 11:33:50 -05:00
Matt Martz
d44dd63a00 Add actual version to version_added for svc module 2016-12-08 11:33:50 -05:00
Joel Thompson
8539d6f502 Fix documentation for sns_topic module
Currently the documentation does not correspond to the Ansible standards
for module documentation. This should bring it into compliance.
2016-12-08 11:33:50 -05:00
Dag Wieers
9199f56d80 Fix typo 2016-12-08 11:33:50 -05:00
Ton Kersten
fb471fc0a8 Fix facter path 2016-12-08 11:33:50 -05:00
Brian Coca
383403282f now point to local template 2016-12-08 11:33:50 -05:00
Brian Coca
392fde1847 initial addition of issue/pr temlpates 2016-12-08 11:33:50 -05:00
Brian Coca
130aca03fa minor docfixes 2016-12-08 11:33:50 -05:00
Ritesh Khadgaray
c3e9c54f29 files/blockinfile.py : ERROR: version_added for new option (follow) should be 2.1. Currently 0.0 2016-12-08 11:33:49 -05:00
Matt Martz
1f7a2041be Indicate proxy_host and proxy_port were added in 2.1 2016-12-08 11:33:49 -05:00
Brad Wilson
6c07f42b8d Issue #1668: rabbitmq_user: Ansible HEAD incorrectly treats permissions as a string instead of a list 2016-12-08 11:33:49 -05:00
Brian Coca
4702cc9b1b added follow docs back, removed from shared 2016-12-08 11:33:49 -05:00
Brian Coca
c7108db1a0 merged duplicate entries for vdc_name 2016-12-08 11:33:49 -05:00
Jan Chaloupka
6e201948bc dnf module: package not installed with state=latest
dnf: name=PACKAGE state=latest is reponsible for two use cases:
- to install a package if not already installed.
- to update the package to the latest if already installed.

The latter use cases is not handled properly as base.upgrade does not
throw dnf.exceptions.MarkingError if a package is not installed.

Setting base.conf.best = True ensures a package is installed or
updated to the latest when calling base.install.

Sign-off: jsilhan@redhat.com
Sign-off: jchaloup@redhat.com
2016-12-08 11:33:49 -05:00
Michael Baydoun
221d1b7744 Update ec2_vpc_net_facts.py
Corrected version_added
2016-12-08 11:33:49 -05:00
Thierno IB. BARRY
4c07e1447e update doc for proxy support
Update documentation to add proxy section
2016-12-08 11:33:49 -05:00
Thierno IB. BARRY
32d4a8811c Elasticsearch: Add proxy support
Add proxy support for plugin installation.
2016-12-08 11:33:49 -05:00
Alex Kalinin
126f8b709f Fix opening libvirt esx connection 2016-12-08 11:33:49 -05:00
Brian Coca
51e034a8cc fixed version added 2016-12-08 11:33:49 -05:00
James Cammarata
f1e50f7616 Adding version_added field to logdest field for puppet module 2016-12-08 11:33:49 -05:00
Monty Taylor
d8f35dfb18 Add option to send puppet apply logs to syslog
While returning puppet logs as ansible stdout is useful in some cases,
there are also cases where it's more destructive than helpful. For
those, local logging to syslog so that the ansible logging makes sense
is very useful.

This defaults to stdout so that behavior does not change for people.
2016-12-08 11:33:49 -05:00
Brian Coca
c7f4fbb8a7 corrected parameter name and added missing description 2016-12-08 11:33:49 -05:00
Brian Coca
e25032cc86 fixed misppelled description 2016-12-08 11:33:49 -05:00
Toshio Kuratomi
7a686ab6d8 U() markings in pushover docs should remain but need to be uppercased.
pri description needs to be a list.
2016-12-08 11:33:49 -05:00
Baptiste Mille-Mathias
1c3bbfe767 remove unicode prefix and correct text in table
Remove the unicode prefix displayed before the url pushover.net
Attempt to correct the text in the table which appear vertically.
2016-12-08 11:33:48 -05:00
Jiri Tyr
014d78e78d Adding params option into the yumrepo module 2016-12-08 11:33:48 -05:00
Tim Rupp
6ef0c71523 Fixes missing validate_certs parameter
The bigip_api method was changed in the module_utils function definition
to include the validate_certs option but the bigip_virtual_server module
was not updated accordingly. This patch updates the method so that the
error message below is not returned to the user

received exception: bigip_api() takes exactly 4 arguments (3 given)
2016-12-08 11:33:48 -05:00
Johan Wirén
c54841fb3e Keep, but ignore createparent option 2016-12-08 11:33:48 -05:00
Johan Wirén
dc15c98e6f Removes the createparent property.
The least surprising thing is to always create parents
2016-12-08 11:33:48 -05:00
Johan Wirén
7bb79093c2 Only considers local attributes when comparing state
This should fix #1092
2016-12-08 11:33:48 -05:00
Johan Wirén
14a0cf142d Documentation fixes 2016-12-08 11:33:48 -05:00
Johan Wirén
a410f524b4 Update example 2016-12-08 11:33:48 -05:00
Johan Wirén
e08638b737 Changes how zfs properties are handled
This moves the validation of properties to the zfs command itself. The
properties and their choices were not really correct anyway due to
differences between OpenZFS and Solaris/ZFS.
2016-12-08 11:33:48 -05:00
Charles Ferguson
f4a533fa95 Update 'patch' documentation for src, remote_src, backup and binary.
The patch module has a few missing items, and inconsistencies, in its
documentation. A few of which are addressed here.

Within Ansible documentation, the choices for boolean values are
commonly 'yes', and 'no'. We standardise the options on that.

'remote_src' documentation uses 'False' and 'True' for its documentation,
so these have been updated in both the choices and default.

'src' documentation refers to 'remote_src', so is updated to use
the 'no' choice.

'backup' did not describe its options and default at all, so we add
them.

'binary' default used 'False', but specified the type as 'bool' which is
implicitly documented as 'yes'/'no', so we make that 'no' as well.
2016-12-08 11:33:48 -05:00
Toshio Kuratomi
96f1bd82c0 Allow dnf to remove dependent packages of a package that is being removed
Fixes #1517
2016-12-08 11:33:48 -05:00
Matt Martz
78759c667a Fix DOCUMENTATION for ec2_vpc_dhcp_options.py and add missing RETURN to ec2_vol_facts.py 2016-12-08 11:33:48 -05:00
Sumit Roy
8eeb30da3d Ensure that port_path is split into at most 2 components.
cloudstack: cs_instance: fix do not require name to be set to avoid clashes

Require one of display_name or name. If both is given, name is used as identifier.

cloudstack: fix name is not case insensitive

cloudstack: cs_template: implement state=extracted

Update f5 validate_certs functionality to do the right thing on multiple python versions

This requires the implementation in the module_utils code here
https://github.com/ansible/ansible/pull/13667 to funciton

fixed domain_id to actually be supported

also added domain as an alias
alt fixes #1437

Simplify the code and remove use_unsafe_shell=True

While there is no security issue with this shell snippet, it
is better to not rely on shell and avoid use_unsafe_shell.

Fix for issue #1074. Now able to create volume without replica's.

Improved fix for #1074. Both None and '' transform to fqdn.

Fix for ansible-modules-extras issue #1080
2016-12-08 11:33:48 -05:00