1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

1351 commits

Author SHA1 Message Date
Gavin Kyte
a722021207 Change un-ordered list to ordered ()
Makes sense to make implied order explicit with an ordered list
2019-02-13 09:21:08 -06:00
Sayed Anisul Hoque
bf20c4126c Updated the ansible-galaxy docs ()
* Updated the ansible-galaxy docs

<!--- Your description here -->

Updated the documentation that reflects the default branch that will be used for the `version` option in ansible-galaxy.

+label: docsite_pr

* Updated the documentation

As per the code (6d4307377f/lib/ansible/galaxy/role.py (L237))[ansible/galaxy/role.py] Defaults to the branch set as a default in the repository otherwise defaults to the master.

* Update docs/docsite/rst/reference_appendices/galaxy.rst

Co-Authored-By: anis016 <anis016@users.noreply.github.com>
2019-02-12 16:33:54 -05:00
Andrew Gaffney
9c35f18dd6 Custom jinja Undefined class for handling nested undefined attributes ()
This commit creates a custom Jinja2 Undefined class that returns
Undefined for any further accesses, rather than raising an exception
2019-02-12 15:04:00 -05:00
Keith Maxwell
7fbacf920d Remove misleading statement passwords must be same ()
* Remove misleading statement passwords must be same

Since 2.4 Ansible has supported multiple vault passwords:
<https://docs.ansible.com/ansible/latest/user_guide/vault.html#multiple-vault-passwords>

Meaning lines like the following are misleading:

> The password used with vault currently must be the same for all files you wish
> to use together at the same time.

-- `docs/docsite/rst/user_guide/vault.rst`

To demonstrate this with Ansible 2.7, save the following as `example.yaml`:

```
- name: Display output from two vaults with different passwords
  hosts: localhost
  connection: local
  vars_files: [one.yaml, two.yaml]
  tasks:
    - name: View secret from one.yaml vault
      debug: { var: one }
    - name: View secret from two.yaml vault
      debug: { var: two }
```

Then run the three following commands choosing two different passwords:

```
$ echo 'one: 1' | ansible-vault encrypt --vault-id id1@prompt --output=one.yaml
$ echo 'two: 2' | ansible-vault encrypt --vault-id id2@prompt --output=two.yaml
$ ansible-playbook --vault-id id1@prompt --vault-id id2@prompt example.yaml
```

`ansible-vault` stores an ID in plain text in the vault file.

* Remove note about default in Ansible 2.1

As requested by gundalow in https://github.com/ansible/ansible/pull/49798
2019-02-12 10:47:01 -05:00
Abhijeet Kasurde
fab815fc3b
VMware: Handle duplicate VM names in vmware_vm_facts ()
This fix changes facts returned from vmware_vm_facts to list of dict from
dict of dict.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-12 16:31:42 +05:30
Evgeni Golov
ace38a2646 two indentation fixes in playbooks_reuse_roles.rst ()
+label: docsite_pr
2019-02-11 14:47:09 -05:00
Matt Martz
445ff39f94
Become plugins ()
* [WIP] become plugins

Move from hardcoded method to plugins for ease of use, expansion and overrides
  - load into connection as it is going to be the main consumer
  - play_context will also use to keep backwards compat API
  - ensure shell is used to construct commands when needed
  - migrate settings remove from base config in favor of plugin specific configs
  - cleanup ansible-doc
  - add become plugin docs
  - remove deprecated sudo/su code and keywords
  - adjust become options for cli
  - set plugin options from context
  - ensure config defs are avaialbe before instance
  - refactored getting the shell plugin, fixed tests
     - changed into regex as they were string matching, which does not work with random string generation
     - explicitly set flags for play context tests
 - moved plugin loading up front
 - now loads for basedir also
 - allow pyc/o for non m modules
 - fixes to tests and some plugins
 - migrate to play objects fro play_context
 - simiplify gathering
 -  added utf8 headers
 - moved option setting
 - add fail msg to dzdo
 - use tuple for multiple options on fail/missing
 - fix relative plugin paths
 - shift from play context to play
 - all tasks already inherit this from play directly
 - remove obsolete 'set play'
 - correct environment handling
 - add wrap_exe option to pfexec
 - fix runas to noop
 - fixed setting play context
 - added password configs
 - removed required false
 - remove from doc building till they are ready

future development:
  - deal with 'enable' and 'runas' which are not 'command wrappers' but 'state flags' and currently hardcoded in diff subsystems

* cleanup

  remove callers to removed func
  removed --sudo cli doc refs
  remove runas become_exe
  ensure keyerorr on plugin
  also fix backwards compat, missing method is attributeerror, not ansible error
  get remote_user consistently
  ignore missing system_tmpdirs on plugin load
  correct config precedence
  add deprecation
  fix networking imports
  backwards compat for plugins using BECOME_METHODS

* Port become_plugins to context.CLIARGS

This is a work in progress:
* Stop passing options around everywhere as we can use context.CLIARGS
  instead

* Refactor make_become_commands as asked for by alikins

* Typo in comment fix

* Stop loading values from the cli in more than one place

Both play and play_context were saving default values from the cli
arguments directly.  This changes things so that the default values are
loaded into the play and then play_context takes them from there.

* Rename BECOME_PLUGIN_PATH to DEFAULT_BECOME_PLUGIN_PATH

As alikins said, all other plugin paths are named
DEFAULT_plugintype_PLUGIN_PATH.  If we're going to rename these, that
should be done all at one time rather than piecemeal.

* One to throw away

This is a set of hacks to get setting FieldAttribute defaults to command
line args to work.  It's not fully done yet.

After talking it over with sivel and jimi-c this should be done by
fixing FieldAttributeBase and _get_parent_attribute() calls to do the
right thing when there is a non-None default.

What we want to be able to do ideally is something like this:

class Base(FieldAttributeBase):
    _check_mode = FieldAttribute([..] default=lambda: context.CLIARGS['check'])

class Play(Base):
    # lambda so that we have a chance to parse the command line args
    # before we get here.  In the future we might be able to restructure
    # this so that the cli parsing code runs before these classes are
    # defined.

class Task(Base):
    pass

And still have a playbook like this function:

---
- hosts:
  tasks:
  - command: whoami
    check_mode: True

(The check_mode test that is added as a separate commit in this PR will
let you test variations on this case).

There's a few separate reasons that the code doesn't let us do this or
a non-ugly workaround for this as written right now.  The fix that
jimi-c, sivel, and I talked about may let us do this or it may still
require a workaround (but less ugly) (having one class that has the
FieldAttributes with default values and one class that inherits from
that but just overrides the FieldAttributes which now have defaults)

* Revert "One to throw away"

This reverts commit 23aa883cbed11429ef1be2a2d0ed18f83a3b8064.

* Set FieldAttr defaults directly from CLIARGS

* Remove dead code

* Move timeout directly to PlayContext, it's never needed on Play

* just for backwards compat, add a static version of BECOME_METHODS to constants

* Make the become attr on the connection public, since it's used outside of the connection

* Logic fix

* Nuke connection testing if it supports specific become methods

* Remove unused vars

* Address rebase issues

* Fix path encoding issue

* Remove unused import

* Various cleanups

* Restore network_cli check in _low_level_execute_command

* type improvements for cliargs_deferred_get and swap shallowcopy to default to False

* minor cleanups

* Allow the su plugin to work, since it doesn't define a prompt the same way

* Fix up ksu become plugin

* Only set prompt if build_become_command was called

* Add helper to assist connection plugins in knowing they need to wait for a prompt

* Fix tests and code expectations

* Doc updates

* Various additional minor cleanups

* Make doas functional

* Don't change connection signature, load become plugin from TaskExecutor

* Remove unused imports

* Add comment about setting the become plugin on the playcontext

* Fix up tests for recent changes

* Support 'Password:' natively for the doas plugin

* Make default prompts raw

* wording cleanups. ci_complete

* Remove unrelated changes

* Address spelling mistake

* Restore removed test, and udpate to use new functionality

* Add changelog fragment

* Don't hard fail in set_attributes_from_cli on missing CLI keys

* Remove unrelated change to loader

* Remove internal deprecated FieldAttributes now

* Emit deprecation warnings now
2019-02-11 11:27:44 -06:00
James Cassell
953058d025 standardize connection variable names ()
* standardize user/password connection vars

* docs: use ansible_user and ansible_password

* docs: var precedence for connection vars

* docs: ansible_become_pass -> ansible_become_password etc
2019-02-11 10:43:10 -05:00
Andrii Radyk
07cff73719 Fix yaml indentation for from_yaml_all filter example () 2019-02-10 21:21:15 +05:30
Richard Diphoorn
ad549e375a Changed 'Control Machine' to 'Control Node' ()
* Changed 'Control Machine' to 'Control Node' in the documentation. Changing the term 'Control Machine' to 'Control Node', to be in line with the basic concepts here: https://docs.ansible.com/ansible/latest/network/getting_started/basic_concepts.html

Also for both entities; Control/Managed using the same common denominator 'Node' brings consistency.

* Updated reference links to new term.
2019-02-08 13:40:09 -06:00
RMuskovets
eb54dab362 Update developing_rebasing.rst () 2019-02-08 13:29:39 -06:00
Nathaniel Case
7ad238b358
Document httpapi and cliconf plugins ()
* Create new documentation pages for httpapi and cliconf

* Add new documentation to plugins toctree and Makefile

* Add DOCUMENTATION to cliconf

* Apply suggestions from code review
2019-02-08 11:04:05 -05:00
Ingo Meldau
1fdceac37e Update playbooks_delegation.rst ()
Changed from 'comand' to 'command'
2019-02-08 16:19:16 +05:30
Toshio Kuratomi
dfd8b659c0 Have update-bundled check for updates to all bundled code
Add a test for whether we have bundled code inside of ansible that needs to be updated
2019-02-06 13:59:55 -08:00
Sandra McCann
2c0897caf2 mention ansible-lint and editor tools that help with playbook development ()
* introduce ansible-lint in playbook docs, mention editors help playbook syntax

Co-Authored-By: samccann <samccann@redhat.com>
2019-02-06 14:56:52 -06:00
Sandra McCann
d92797f594 removed old localhost content () 2019-02-06 14:16:36 -06:00
Sandra McCann
9c058d3121 Add default Network timeout values to network troubleshooting guide ()
* add toc and default timeout values

* make options more obvious
2019-02-05 14:46:29 -06:00
Alex Willmer
c7f8e5d05e doc: Correct path of unit tests directory ()
+label: docsite_pr
2019-02-02 00:59:13 +01:00
Wojciech Sciesinski
fbbda7267b Add a missed command ()
* Add a missed command

* Link to the WinRM configuration page
2019-02-01 12:46:24 +10:00
Bianca Henderson
51ac4d3441 Update Ansible docsite CSS to fix multi-page printing issue ()
* Update css to fix multi-page printing issue

* Add margin edit
2019-01-31 18:36:38 -06:00
Satyajit Bulage
dab381dd71 Broken link fixed. ()
Fixes 

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
2019-01-31 12:53:17 -06:00
Brian Coca
4ac0c23db6
added unsafe toggle to vars_prompt ()
* added unsafe toggle to vars_prompt

	fixes 
2019-01-30 15:01:13 -05:00
Mahendra Yadav
10a402a9c8 Update developing_modules_general_windows.rst ()
<!--- Your description here -->
Typo fix
+label: docsite_pr
2019-01-30 10:16:32 -06:00
Toshio Kuratomi
b0ac7d9652 Toshio is now release manager for 2.8 and future 2.6 () 2019-01-29 18:05:59 -06:00
Brian Coca
eebece91b1 add note about register + skip ()
* add note about register + skip

 fixes 

* Update docs/docsite/rst/user_guide/playbooks_conditionals.rst

Co-Authored-By: bcoca <bcoca@users.noreply.github.com>

* Update docs/docsite/rst/user_guide/playbooks_conditionals.rst

Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
2019-01-29 16:28:18 -05:00
allan bailey
1f9ad3bf50 grammer fix and changed description to iteratively from recursively. () 2019-01-29 15:37:01 -05:00
Will Thames
23b5599244 Add k8s module_defaults group and document ()
It makes sense to use module_defaults with k8s modules, and thus
have a k8s module_defaults group.
2019-01-29 14:23:27 -06:00
Ryan Merolle
8c703da46a dellos module doc updates for network_cli ()
* dellos module doc updates for network_cli

* remove ansible 2.6 reference from dellos10

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>

* remove ansible 2.6 reference from dellos6

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>

* remove ansible 2.6 reference from dellos10

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>

* remove ansible 2.6 reference from dellos6

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>

* fix dellos6 register copy mistake

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>

* remove ansible 2.6 reference from dellos9

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>

* fix dellos6 register copy mistake

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>

* removed indicator of dellos modules being maintained by ansible network team

dellos modules are maintained by Dell

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>

* removed indicator of dellos modules being maintained by ansible network team

dellos modules are maintained by Dell

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>

* Removed indicator of dellos modules being maintained by ansible network team

DellOS modules are maintained by Dell

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>

* remove ansible 2.6 reference from dellos9

Co-Authored-By: ryanmerolle <ryanmerolle@users.noreply.github.com>
2019-01-29 15:19:55 -05:00
kysamson
60d134aeaf Clarify priority setting in Inventory doc ()
* priority setting note in inventory doc

The `ansible_group_priority` variable is also described in *Using Variables* and was given a clarification in issue . The variable is also documented in *Working with Inventory* without the caveat that it needs to be declared on the inventory and not a group_vars file. This change adds that as a note

+label: docsite_pr
2019-01-29 14:44:31 -05:00
Dag Wieers
49afb3da34 Update Docsite edit ()
* Improved template for docsite edits
2019-01-29 14:28:16 -05:00
Hannes Ljungberg
b426daa064 docker_swarm_service: Remove root as default user ()
* Remove root as default user

* Add changelog fragment

* Add deprecation documentation

* Tweak user default docs for docker_swarm_service

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Tweak user default deprecation docs

Co-Authored-By: hannseman <hannes@5monkeys.se>
2019-01-27 16:26:41 +00:00
vvvlc
48442a4a33 added pipelining for z/OS ()
* added pipelining for z/OS

* Update docs/docsite/rst/reference_appendices/faq.rst

agreeed

Co-Authored-By: vvvlc <vitezslav+github@vvvlcek.info>

* Update docs/docsite/rst/reference_appendices/faq.rst

agreeed

Co-Authored-By: vvvlc <vitezslav+github@vvvlcek.info>

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: vvvlc <vitezslav+github@vvvlcek.info>

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: vvvlc <vitezslav+github@vvvlcek.info>

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: vvvlc <vitezslav+github@vvvlcek.info>

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: vvvlc <vitezslav+github@vvvlcek.info>

* Update docs/docsite/rst/reference_appendices/faq.rst

* Update docs/docsite/rst/reference_appendices/faq.rst

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: vvvlc <vitezslav+github@vvvlcek.info>

* Update faq.rst

reformatted section for error message `The module libpython2.7.so was not found.`
2019-01-25 10:42:54 -05:00
Felix Fontein
4732728e40 Updating : add rename to porting guide. () 2019-01-24 16:50:11 -06:00
Jeremy Booker
b787d8b23c Remove "as mentioned above" ()
Remove "as mentioned above" because "variables" weren't mentioned anywhere above.
2019-01-24 16:39:24 -06:00
Felix Fontein
f6122fb63b Fix docs syntax highlighting errors ()
* Add support for [WARNING]: ...

* Fix unreachable/failed output lexing.

* Detecting retry/--limit lines.

* Removing strange (invisible) characters which cause lexing problems.

* Using better-fitting lexers.

* Improve YAML lexing: don't accept quotes in keys.

* Add Django lexer (unchanged) from Pygments.

* Add support for != and % operators.
2019-01-24 16:09:41 -06:00
mclean
8e9a5c8de7 changes 'github' to 'GitHub' in community ()
* changes 'github' to 'GitHub' in community
2019-01-24 14:28:39 -06:00
Brian Coca
96b3ef5553
Doc fragments to plugins ()
* promote doc_fragments into actual plugins

  change tests hardcoded path to doc fragments
  avoid sanity in fragments
  avoid improper testing of doc_fragments
  also change runner paths
 fix botmeta
 updated comment for fragments
 updated docs
2019-01-23 20:03:47 -05:00
Sandra McCann
16511501b6 Remove outdated minor release info from table ()
* removed outdated minor release info from table
* fixed grammar nits
* added link to releases
2019-01-23 15:22:40 -06:00
Brian Coca
9793b194b9 clarify environment ()
* clarify environment

* it does work on windoez
2019-01-23 13:54:05 -06:00
Ken Dreyer
1b09197244 doc: describe merging to ansible.module_utils.* ()
Add a section to the documentation describing precisely how Ansible
merges custom module_utils/* Python code into the "ansible.module_utils"
namespace.
2019-01-23 13:52:16 -06:00
Sandra McCann
47d22bbcd8 add network roles info ()
* add network roles info
* add role update instructions
* implemented feedback

Co-Authored-By: samccann <samccann@redhat.com>
2019-01-23 13:36:05 -06:00
Dag Wieers
2798d5bafc
Clarify gather_facts and highlight important lines
Clarify gather_facts and highlight important lines

+label: docsite_pr
2019-01-23 17:25:24 +01:00
Felix Fontein
d2c4f57f16 docker_service: rename to docker_compose. ()
* Rename docker_service -> docker_compose.

* Added changelog.

* Update scenario guide.

* Clean up module.
2019-01-23 12:21:57 +00:00
Sandra McCann
b023b89ec9 add example of hosts in multiple inventory groups ()
* add example of hosts in multiple groups

* fixed spacing

* added nested group example
2019-01-22 17:49:51 +01:00
Dag Wieers
1fb2165bd8
Fix typo
+label: docsite_pr
2019-01-22 15:45:01 +01:00
Nathaniel Case
9702893729
Remove deprecated options from modules ()
* Remove deprecated options from modules

* Update tests

* Add porting guide notes
2019-01-22 09:18:26 -05:00
Matt Martz
552cb1f6b9
Add porting guide note about change from 49317 () 2019-01-21 13:28:07 -06:00
Matt Martz
ab0985a83a
Update the example for API use to reflect new context object () 2019-01-21 11:21:06 -06:00
Ganesh Nalawade
1b6228fa10
Increase persistent command_timeout default value ()
* Increase persistent command_timeout default value

*  Increase command_timeout default value from 10 to 30 sec
   to reduce frequent timeout issue for network connection
   types (netconf/network_cli/httpapi/napalm)

* Fix review comments
2019-01-21 10:50:52 +05:30
ABond
d55479d063 DigitalOcean module deprecation () 2019-01-19 21:25:33 +00:00