ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity
39820 commits 10 branches 167 tags 272 MiB
Commit graph

23190 commits

Author SHA1 Message Date
Jon Cormier
7aaa5da41d [aws_ssm_parameter_store] use describe_parameters paginator (#45632) 
Fix the service reaching an internal limit while processing the results and returning unexpected data
 2018-09-14 15:17:15 -04:00
lwm
1d754b43de Linode: clarify how to create/delete linode machines with linode_id. (#45659) 
* Attempt to explain `linode_id` a bit better.

Don't include in any example that creates a Linode.

Based on comments in

> https://github.com/ansible/ansible/issues/45403#issuecomment-419752856

* Add simple creation example. Show how to pass `linode_id`.
 2018-09-14 15:10:32 -04:00
Maugli
235b11f681 Return correct version on installed VyOS (#39115) 
* Return correct version on installed VyOS

Previously existing regexp will shows only "VyOS" without numeric output of router version.
For example: from  "Version:      VyOS 1.1.6" only VyOS will be written in ansible_net_version variable
For more informative output numeric value should be returned as well

* Fixed unittests
 2018-09-14 22:51:30 +05:30
Matt Martz
829f48e3f5
Flip default for AGNOSTIC_BECOME_PROMPT (#45563) 
* Flip default for AGNOSTIC_BECOME_PROMPT

* simplify AGNOSTIC_BECOME_PROMPT porting guide entry

* clarify AGNOSTIC_BECOME_PROMPT changelog entry

* fixes version typo

* uses alternate wording (rather than escaping *)
 2018-09-14 11:16:13 -05:00
Martin Krizek
d383d87b22 include_vars: fix checking for a string in ignore_files 2018-09-14 11:18:00 -04:00
Michael Scherer
a1e2f1bf73 [voss_facts] remove uneeded global declaration of variable warnings (#45653) 
Since the variable is used only once, no need to declare it global.
Remove a warning from linter (lgtm.com)
 2018-09-14 10:39:41 -04:00
Deaton64
3782a236ba Update azure_rm_trafficmanagerprofile.py examples (#45649) 
Wrong module name used in examples. changed `azure_rm_trafficmanager` to `azure_rm_trafficmanagerprofile`
 2018-09-14 09:48:11 -04:00
Michael Scherer
518f80c3fb [module_utils/aws/urls] remove assigning variable itself (#45612) 
Flagged by lgtm.com
 2018-09-13 17:42:04 -04:00
Xyon
8d6522c671 Update mysql_db.py (#41317) 
Add note to inform that mysql_db is not idempotent when state is "import".

+label: docsite_pr
 2018-09-13 17:31:45 -04:00
Michael Scherer
ede3a8cee1 Fix formatting for the error on azure_rm_appserviceplan_facts (#45613) 
Since there is only 1 argument, {1} can't work since that's the
2nd argument for format. Flagged by lgmt.com
 2018-09-13 17:00:21 -04:00
Tim Rupp
5a3a865ca0
More bigip software fixes (#45633) 
Fixes problems related to token timeout. Adds cleanup of tokens.
 2018-09-13 15:58:17 -04:00
Brian Coca
ddb3764039
avoid empty groups in json output (#45621) 
they get confused as hosts by script plugin

fixes #45601
 2018-09-13 15:38:52 -04:00
Tim Rupp
e619052424
Fixes multiple lgtm issues (#45629) 
Most of the issues were just inclusions of code that were not used.
This cleans those up. Other alerts were semi-false-positives for now
 2018-09-13 15:26:17 -04:00
Matt Martz
e68f895e61
Support empty files with piped transfer_method. Fixes #45426 (#45618) 2018-09-13 13:53:36 -05:00
Vibhav Sinha
e26d758d6f fix gce_backend_service examples for healthchecks (#31134) 
gce_backend_service module expects healthchecks to be an array of string. The previous example incorrectly mentioned healthchecks as an array of objects each containing a `name` key.
 2018-09-13 13:47:43 -05:00
Tim Rupp
34d08adea0
Fixes lgtm alert (#45619) 
Alert was for an include that was not used.
https://lgtm.com/projects/g/ansible/ansible/latest/files/lib/ansible/modules/network/f5/_bigip_facts.py?sort=name&dir=ASC&mode=heatmap&showExcluded=false#L98
 2018-09-13 13:45:55 -04:00
Michael Scherer
de84a05bf4 Remove unused import iControlUnexpectedHTTPError (#45611) 
Since that's unused in the code, no need to import it.
This got flagged by linter
 2018-09-13 13:16:23 -04:00
Anton Nikulin
b7263eab1d Store Authorization header inside HttpApi connection plugin (#45598) 2018-09-13 19:34:30 +05:30
Nathaniel Case
285b927889
network command modules cleanup (#45242) 
* Standardize _command modules

* Centralize command transformation process

* Fix check mode error test
 2018-09-13 08:55:35 -04:00
Zim Kalinowski
df768914a1 adding sql firewall rule facts (#45059) 2018-09-13 17:54:58 +08:00
Strahinja Kustudic
8d8df46fe6 Add an error message if a pkg cannot be removed, fixes #35672 (#40723) 2018-09-13 02:54:38 -04:00
tterranigma
cc477ec920 Update fileglob.py (#45558) 
* Update fileglob.py

Closes #45557

* Update fileglob.py
 2018-09-13 12:10:00 +10:00
Nathaniel Case
3d0f19d8cd
Exclude the whole ansible_failed_task block (#45587) 
It has lots of FieldAttributes that won't serialize.
Also the connection doesn't care.
 2018-09-12 21:17:24 -04:00
Jordan Borean
d81249994e
win_script: add support for become and centralise exec wrapper builder (#45582) 
* win_script: add support for become and centralise exec wrapper builder

* satisfying the pep8 gods

* do not scan for module dependencies when running as a script
 2018-09-13 08:50:13 +10:00
Sam Doran
03dbb1d9c4 Improve code stability is checksum checking 
- use context manager for dealing with the checksum file
- use loop that can tolerate zero, one, or more items return rather than the previous expression which would break if anything other than exactly one item was returned
 2018-09-12 15:29:15 -07:00
Martin Nečas
2a3f3382fd Ovirt add rename functionality (#44951) 
* add renaming of ovirt
* add renaming func to ovirt cluster
* ovirt update examples in docs
 2018-09-12 14:36:06 -07:00
Jon "The Nice Guy" Spriggs
ab2e6fded1 Show multi-line messages in debug documentation (#23000) 
* Show multi-line messages in debug documentation

* Add two-line entry
* Indicate that jinja2 filters are not applied here

* Fix to incorrect documentation change
 2018-09-12 16:55:48 -04:00
Ferdinand Holzer
3c083837c0 Clarify how java_cert checks keystore certificates (#26567) 2018-09-12 15:51:37 -05:00
Dag Wieers
310b0a2521 Docs: Make docsite rebuilds smarter/faster (#45062) 
* Make the following scripts  idempotent so that we only have to rebuild changed docs, not all docs:

  * plugin_formatter
  * generate_man
  * dump_keywords.py
  * dump_config.py
  * testing_formatter.sh
 2018-09-12 13:50:36 -07:00
Tim Rupp
e266a24263
Fixes bugs in the bigip_software modules (#45577) 
This patch makes hotfix code work, where before, only base images
were working
 2018-09-12 15:56:43 -04:00
Brian Coca
1ed57f1f64 moving from with_ff to just ff (#44847) 2018-09-12 15:35:04 -04:00
Evert
f7ef06e849 Added a note regarding the delegate_facts option. (#25257) 
* Added a note regarding the delegate_facts option with a link to documentation
 2018-09-12 14:30:05 -05:00
Richard Schwab
ea8924f744 Make it clear that recurse only applies to state=directory (#40222) 
This would otherwise cause confusion as it could be interpreted as only changing attributes for directories (and not files inside).

+label: docsite_pr
 2018-09-12 13:00:49 -04:00
Anil Kumar Muraleedharan
ac58c36ad0 Lenovo cli bugfixes (#45278) 
* To change all CLIs present in the code to latest CNOS CLI. One bug of executing with Lenovo Jakku switch is also getting fixed.

* To change the file names as the commands have changed from display to show

* To change to new CLI in test_cnos_comand.py as well
 2018-09-12 10:31:45 -04:00
thetuxkeeper
11cfa96797 fixing bytes <-> str regexp issue in cloudengine (#45285) 2018-09-12 09:59:42 -04:00
abirami-n
06fd9820a3 Fixes handling of terminal_initial_prompt on dellos6 and dellos9 devices (#45273) 
* Fix terminal initial prompt on dellos6 and dellos9

* Fix_pylint
 2018-09-12 19:28:32 +05:30
Nathaniel Case
eaf01d321f
eos: Don't error on VLAN missing warning (#45433) 2018-09-12 09:55:23 -04:00
Ghilli3
6040175186 Initial commit of fmgr_sys_proxy.py (#45518) 2018-09-12 19:18:27 +05:30
Zim Kalinowski
73c8041ec0 Azure load balancer crash fix (#45546) 2018-09-12 16:25:35 +08:00
Zim Kalinowski
111febe62e extended vmss facts (#45535) 2018-09-12 13:22:47 +08:00
Brian Brooks
0198d93f68 Update keycloak_client.py (#45505) 
Slightly improve wording about lack of input sanity checking on API calls.

+label: docsite_pr
 2018-09-12 06:22:54 +02:00
Zim Kalinowski
821c27cefb fixed tag support in autoscale facts (#45533) 
* fixed tag support in autoscale facts

* forgot to add tags to arg spec
 2018-09-11 23:00:58 -04:00
Deepak Agrawal
81214409cf
asa_config/ios_config: diff strict does not work with multiple parents (#45150) 
* multiple parents issues in diff

* Integration tests for missing functionality

* add testcase for other platforms. vnxos does not support qos so need to find a command chain on v-nxos for multiple parets. junos uses on-device diff so should not need this.

* Fix for issue when any candidate parent did not meet the exact line in running-config

* DCI runs eos_config without become flag
 2018-09-12 07:50:24 +05:30
Michael Scherer
004621ef8e Fix useless comparaison between 2 constants (#45524) 
Found with https://lgtm.com
 2018-09-11 19:37:50 -04:00
Jose Delarosa
197059b4a2 Update the root URI to match the DMTF specification (#45295) 2018-09-11 19:15:59 -04:00
Kerry
bf90a44468 Clarify the creates and removes options (#45485) 
* Clarify the creates and removes options

The description for the creates and removes options were worded poorly. This change improves readability and is easier to understand.

 Double negatives are BAD

+label: docsite_pr

* Fix trailing whitespace
 2018-09-11 15:45:19 -05:00
William
2ea9cfcd52 Fix python 3 compatibility for network id lookup (#45467) 
Due to a change in python 3 filters return filter instead of list. This breaks the network name to id lookup for the docker_swarm_module. By wrapping it in list it ensures it is a list when returned and the id is extracted.
 2018-09-11 15:45:42 -04:00
Sloane Hertel
e5269c047c [AWS] cloudfront_distribution - fix method name from 'validate_distribution_id_from_caller_reference' to 'validate_distribution_from_caller_reference' and set distribution_id to the distribution's key 'Id' (#45498) 2018-09-11 15:08:30 -04:00
Matt Martz
5785de582f
Fix logic to not re-download existing files when force=no (#45495) 
* Fix logic to not re-download existing files when force=no. Fixes #45491

* Reduce logic complexity
 2018-09-11 13:56:13 -05:00
Nathaniel Case
b22b07e300 Fixup network connection documentation (#45487) 
* Fixup network connection documentation similar to suggestions in #45224

* Another tpyo
 2018-09-11 14:23:38 -04:00
Matt Clay
ae4d5e3257 Avoid duplicate Azure storage account types. 2018-09-11 10:37:48 -07:00
David Rodríguez
600c7ac108 Fix remote checksums when paths have leading dots (#45287) 
* Fix remote checksums with paths have leading dots

* Fix result recorded from the wrong file

* Add changelog fragment
 2018-09-11 12:47:29 -04:00
Michael Scherer
804d574d1f Add documentation for the modify command, by giving a example (#19699) 2018-09-11 11:38:39 -04:00
Sam Doran
03414727ba Add documentation about patterns with commas to find module (#45360) 
Thanks @samdoran  for the example and clarification!
 2018-09-11 11:04:17 -04:00
Yuwei Zhou
fa04387550 fix the autoscale resource id (#45477) 
* fix the autoscale resource id

* Update main.yml
 2018-09-11 18:52:43 +08:00
James Cassell
211aeebd0d remove unused templar._clean_data() (#42739) 2018-09-11 09:11:03 +02:00
Zim Kalinowski
8a221d81dd fixing facts for mysql server (#45374) 2018-09-11 14:27:50 +08:00
Harald Albers
796d8b5dc8 VMware: Fix wait_for_task backoff behavior (#45429) 
Signed-off-by: Harald Albers <github@albersweb.de>
 2018-09-11 09:58:53 +05:30
Jordan Borean
01398f61d5
Win deprecate 2.8 (#45473) 
* Remove deprecated/expired functionality

* win:_msi: Remove the win_msi module

* removed some missed deprecated return options and added porting guide reference

Co-authored-by: dagwieers <dagwieers@users.noreply.github.com>
 2018-09-11 14:23:48 +10:00
Jordan Borean
ec6d82435f
win_scheduled_task: add deprecation warning for repetition format (#45468) 
* win_scheduled_task: add deprecation warning for repetition format

* fixed up sanity issues
 2018-09-11 14:22:57 +10:00
Mike Klebolt
ee8a10b87d Fixes authentication error when ansible_user is a local account and computer is already joined to domain (#44270) 
* Fixes authentication error when ansible_user is a local account and computer is already joined to domain

* recommended fixes
 2018-09-11 13:20:45 +10:00
Jordan Borean
3371a779b6
win_group_membership - fix random issue with CI on 2012 R2 (#45462) 2018-09-11 13:07:43 +10:00
Jordan Borean
881f3a599c
windows testing - changes to accomodate future behaviour changes (#45464) 2018-09-11 13:04:23 +10:00
Zim Kalinowski
0b029d6792 adding tags support to postgresql (#45339) 2018-09-11 10:20:27 +08:00
Jordan Borean
d4ce1b9f31
fix Ansible.ModuleUtils.FileUtil to respect ErrorAction if running in a try/catch (#45451) 2018-09-11 09:47:56 +10:00
Jordan Borean
c9c141fb6a
win_say - fix up syntax and test issues (#45450) 2018-09-11 08:23:46 +10:00
Seuf
69bbd32264 Grafana datasource module : Use url_argument_spec from urls (#40402) 
* Added client_cert and client_key modules parem

* Use url_argument_spec to init module arguments

* Do not compare version and readOnly

* Convert HTTPResponse content to text before json.loads

* Added password in secureJsonPayload when datasource type is postgres
 2018-09-10 16:06:34 -04:00
Matt Martz
0015d4cef3
2.8 Core Deprecation Removal (#45232) 
* Remove deprecated ansible.vars.unsafe_proxy. Fixes #45040

* Remove deprecated validate_md5 alias from fetch module. Fixes #45039

* Remove deprecated private arg from import/include_role. Fixes #45038

* All include deprecations bumped to 2.12. Fixes #45037

* Add changelog for deprecated removals
 2018-09-10 15:05:52 -05:00
Alexhha
99aafcc8ca Update postgresql_user.py (#45146) 
* Update postgresql_user.py

md5sum generates output with hypen. Something like the following
```
$ echo "md5$(echo -n 'verysecretpasswordJOE' | md5sum)"
md5d011966da94d776cf59bf6dbde240e5d  -
```

We need to remove hyphen from the output. Also the command by itself is incorrect

```
echo "md5$(echo -n 'verysecretpasswordJOE' | md5sum")
```

double quotes must be after right parenthesis

```
echo "md5$(echo -n 'verysecretpasswordJOE' | md5sum)"
```

+label: docsite_pr

* Update postgresql_user.py

Add curly braces
 2018-09-10 16:00:18 -04:00
Matt Martz
263b9fade8
Don't pass file_name to DataLoader.load in script inventory plugin (#45428) 
* Don't pass file_name to DataLoader.load in script inventory plugin. Fixes #34164

* Add changelog fragment
 2018-09-10 14:37:18 -05:00
Fabian von Feilitzsch
aa01d9d243 Set defaults from params after loading files, allowing params to override (#44142) 
* Set defaults from params after loading files, allowing params to override

* cleanup, add some comments
 2018-09-10 15:30:59 -04:00
Jon Dufresne
ef67d4074b Prefer io.BytesIO over six; available on all supported Pythons (#45388) 
On all supported Pythons, the io.BytesIO is always a stream
implementation using an in-memory bytes buffer. Makes code slightly more
forward compatible by reducing use of the six module.
 2018-09-10 15:19:16 -04:00
Isaac McDonald
371d9596f4 Add Sangoma linux (#45430) 
Fixes https://github.com/ansible/ansible/issues/45300
 2018-09-10 14:20:22 -04:00
Eric Thiel
7d0cd81d4f VMware: exclude start_connected from host customization check (#40990) 2018-09-10 16:15:47 +05:30
Abhijeet Kasurde
d4bef8652a VMware: skip customization if no type is specified (#44510) 
VM customization is not necessary if user is not specifying IP address
and netmask. This fix adds exception for type 'DHCP' which is set by default
if no networking details are provided.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-09-10 06:07:15 -04:00
Zim Kalinowski
e203531735 fixing broken sql server tags (#45378) 2018-09-10 15:31:01 +08:00
Abhijeet Kasurde
d41e568a4d
VMware: use UUID to find templates and VMs (#45208) 
This fix adds functionality to find the templates or VMs for cloning
operations.

Fixes: #45081

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-09-10 12:45:47 +05:30
Harald Albers
d61b4492cf VMware: Fix timeout detection in vmware_deploy_ovf module (#45159) 
Signed-off-by: Harald Albers <github@albersweb.de>
 2018-09-10 12:27:40 +05:30
Harald Albers
a9c829bdf2 VMware: honor "wait_for_ip_address" when powering on a VM (#45226) 
Signed-off-by: Harald Albers <github@albersweb.de>
 2018-09-10 12:25:35 +05:30
Zim Kalinowski
6110163f99 Fixes in container registry documentation (#45390) 
* adding tags to container registry

* fixed tags
 2018-09-10 01:49:04 -04:00
Zim Kalinowski
6d0b0f8338 added missing facts in container instance (#45380) 
* returning tags in container instance facts

* small fix
 2018-09-10 01:10:40 -04:00
Stéphane Travassac
0f7ef141ad VMware: more detail error on bad http code return for vmware_guest_file_operation.py (#41897) 
Fixes: #41721
 2018-09-10 09:21:00 +05:30
Sandeep Mendiratta
d6b0b61aa3 Update copy.py (#45393) 
<!--- Your description here -->
Removed additional  apostrophe in dest:
+label: docsite_pr
 2018-09-10 04:05:34 +02:00
Zim Kalinowski
376082c37d added tags to webapp documentation (#45375) 2018-09-10 09:51:17 +08:00
Kevin Breit
afbf72cfeb meraki_network - Fix enabling my.meraki.com (#45352) 
* Fix enabling my.meraki.com
- A parameter of "no" wouldn't be picked up
- Check for False in addition to whether it exists

* Clean up disable_my_meraki parameter check
 2018-09-09 20:31:35 +02:00
Will Thames
1463c2e4a8
Use a sensible default for k8s merge_type (#45284) 
* Use a sensible default for k8s merge_type

The sensible default for merge_type is `['strategic-merge', 'merge'].
However, we can't make this the default default, as we need to support
users who are using openshift 0.6.0, where the merge_type parameter is
unsupported.

* Refactor k8s test suite for merge_type tests

Allow tests with pre-merge-type openshift and post-merge-type
openshift.
 2018-09-08 10:08:09 +10:00
Meecr0b
2f6b8591b1 tower_credential: expect ssh_key_data to be a string instead of path (#45158) 
* expect ssh_key_data to be a string instead of path

ssh_key_data should be a string filled with the private key
the old behavior can be archived with a lookup

Fixes #45119

* clarifies ssh_key_data description, adds newline
 2018-09-07 13:41:09 -04:00
Jesse Morgan
ac4e611f9d not sure if typo or pun. (#45358) 
Fixing header to be SNapshot
+label: docsite_pr
 2018-09-07 13:29:19 -04:00
Matt Martz
2ac647def8
Ensure loop with delegate_to can short circuit the same as without delegate_to. Fixes #45189 (#45231) 2018-09-07 10:16:03 -05:00
kryptsi
1325ddbb0b VMware: new plugin for setting an object's role/permission (#39988) 2018-09-07 19:03:58 +05:30
Ryan Brown
4d7e261074 [aws] Remove deprecated ec2_vpc_dhcp_options_facts alias of ec2_vpc_dhcp_option_facts (#45322) 2018-09-07 09:09:28 -04:00
Ryan Brown
8d363f7693 [aws] Remove deprecated ec2_vpc_dhcp_options alias of ec2_vpc_dhcp_option (#45321) 2018-09-07 09:08:09 -04:00
Pieter Avonts
1a810f8f11 VMware: Rewrite get_resource_pool method for correct resource_pool selection (#39792) 
* rewrite get_resource_pool method for correct resource_pool selection
* only keep name if path is given for cluster, esxi_hostname or resource_pool
* Revert "only keep name if path is given for cluster, esxi_hostname or resource_pool"
* This reverts commit 50293ec763c024b0eaceac5d775ccc0ad3ff8bd7.
* if the name argument contains a path, only use the last part for matching
* remove path from cluster argument in tests
* remove find_objs in favour of reusing find_obj with an extra folder argument
* fix find_obj ignoring first if name is not given
 2018-09-07 18:23:26 +05:30
Trishna Guha
d5bfd93e28
cli_config module doc update (#45345) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-09-07 17:09:08 +05:30
Abhijeet Kasurde
fd985db72d
VMware: Refactor disc logic (#39285) 
* Refactoring related to network device
* Assign unique random temporary key while creating SCSI or/and IDE controller devices
* Add testcase for this change

Fixes: #38679

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-09-07 17:04:02 +05:30
Trishna Guha
f18856d0e2
Add ambiguous command check as the error message is not persistent on nexus devices (#45337) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-09-07 16:35:37 +05:30
Armin Ranjbar Daemi
778b789c84 VMware: New module vmware_guest_vnc (#36282) 2018-09-07 16:00:37 +05:30
Richard Schwab
97fcc3ef66 Correct version_added for strategy host_pinned (#45333) 2018-09-07 09:15:46 +02:00
John Imison
38a714833d pyvcloud requirement documented (#44347) 2018-09-07 01:01:49 -04:00
Mike Klebolt
b14206a578 [New Module] vmware_guest_tools_upgrade (#42698) 
New module to manage VMware guest tools upgrade.
 2018-09-07 09:54:50 +05:30