Jesse Keating
23720ff19d
Use list comprehensions for efficiency
...
For loops can be inefficient, particularly when doing a dot command with
them. https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Loops and
https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Avoiding_dots ...
This patch makes use of list comprehensions to be as efficient as
possible while still retaining order. Efficiency was lost a bit when
switching away from sets() but this gains some of it back.
2014-01-03 18:07:00 -08:00
Michael DeHaan
c4eb3b47ed
Merge pull request #5497 from paulbeattie/devel
...
Fixed typo in example documentation
2014-01-03 17:57:15 -08:00
Jesse Keating
35328ed503
Return early from setup step when possible
...
The _list_available_hosts call can be lengthy, and in the case where
gather_facts is disabled the call is pointless. So re-arrange the logic
to return early from _do_setup_step when gather_facts is false.
2014-01-03 16:39:13 -08:00
Michael DeHaan
c41a23a35a
Complete removal/refactoring of conditional deprecations.
2014-01-03 19:23:19 -05:00
Paul Beattie
e96377685e
Fixed typo in example documentation
2014-01-04 00:22:14 +00:00
Michael DeHaan
8e5b7d3095
Remove code underlying when_* and only_if, which are deprecated features slated for removal in the 1.5 release.
2014-01-03 19:13:21 -05:00
James Tanner
191be7b951
Resolves issues with newer versions of pip not having a --use-mirrors paramater for the install command
2014-01-03 15:29:18 -05:00
Michael DeHaan
28b9fd4e30
We have had only_if, when_foo, etc, deprecated for a while and said they would be removed in 1.5. Now they are, with friendly error messages still.
...
Users of these features should use "when:" as documented at docs.ansible.com.
Similarly, include + with_items has been removed. The solution is to loop
inside the task files, see with_nested / with_together, etc.
2014-01-03 13:47:54 -05:00
Michael DeHaan
5d50bcf6dc
Correct typo in variable in docs.
2014-01-03 13:47:54 -05:00
James Tanner
21fdb2bbc7
Fixes #5200 Handle template contents with unicode strings better
2014-01-03 11:18:20 -05:00
Michael DeHaan
1270e2350c
Remove man3 stuff since this is available via ansible-doc, rpm target should
...
build manpages.
2014-01-03 11:06:45 -05:00
Michael DeHaan
0882eefdff
Merge conflict
2014-01-03 11:06:32 -05:00
James Tanner
fc473b3246
Fixes #5146 Handle missing stdin when running under celery with rabbitmq or redis
2014-01-03 09:46:16 -05:00
rgbj
f2150b101e
On OpenBSD, make user module status 'changed' only if necessary when using 'login_class' parameter
2014-01-03 15:41:12 +01:00
Dag Høidahl
279098bd03
Use "brew list <name>" instead of grepping the output of "brew list".
...
Some brew packages are not listed with their package name, e.g. libjpeg.
2014-01-03 15:15:20 +01:00
jctanner
89abc35e59
Merge pull request #5167 from jaspernbrouwer/devel
...
service_module: Fixed false positive on initctl as enable_cmd
2014-01-02 20:24:00 -08:00
Michael DeHaan
288a6a10dc
Merge pull request #5481 from jarv/jarv/docfix
...
bad closing quote in footer
2014-01-02 18:23:10 -08:00
John Jarvis
318116f291
bad closing quote in footer
2014-01-02 20:16:19 -05:00
Michael DeHaan
de2ffc1276
Don't need to document these guys.
2014-01-02 17:55:59 -05:00
Michael DeHaan
c4a8a6d3c2
Add an "all" category so all modules show up uncategorized there.
2014-01-02 17:42:18 -05:00
Michael DeHaan
1251538e96
Fix syntax of docsite anchors.
2014-01-02 17:37:48 -05:00
Michael DeHaan
2f811c40d7
Basic docsite formatting fixups
2014-01-02 17:36:52 -05:00
James Tanner
86719ce77f
Fixes #5040 setup module: do not add primary interface info to the secondary interface data
2014-01-02 16:17:24 -05:00
Jim Kleckner
dacef1915a
Add quotes to password argument for dump/import
...
The password is passed on a command line for dump and import and needs
quoting.
Ideally, this would not be passed on a command line at all - any ideas?
Or at least have a stronger form of quoting so that embedded single
quotes will be escaped.
2014-01-02 12:04:03 -08:00
James Tanner
cb2214d6f8
Fixes #4935 Synchronize module: set destination to an fqdn if connection is not local, and abide by ansible_remote_user
2014-01-02 14:58:12 -05:00
jctanner
99560e3902
Merge pull request #5047 from sergevanginderachter/synch_template_ansiblesshhost
...
synchronize: allow ansible_ssh_host to be templated
2014-01-02 09:05:14 -08:00
Rutger Spiertz
763c0305c1
apt_repository: don't crash if default_file doesn't exist
2014-01-02 15:41:24 +01:00
jeromew
b2cd4a62de
fix issue #5372 on ssh_alt: accept -K option even for a user with NOPASSWD
2013-12-31 14:29:46 -05:00
Deon Bredenhann
c85aac8b17
Treat a False mandatory variable as defined.
2013-12-31 13:41:40 +02:00
Deon Bredenhann
4f1f13b100
Remove trailing space
2013-12-31 13:40:21 +02:00
Michael DeHaan
99616d0c80
Pass scrub_data by default, see response from DO here: https://www.digitalocean.com/blog
2013-12-30 20:21:15 -05:00
Michael DeHaan
c45f166235
Merge pull request #5453 from jensenbox/patch-1
...
Fix a small typo
2013-12-29 16:06:00 -08:00
Christian Jensen
80bb49c8b7
Fix a small typo
2013-12-29 15:56:38 -08:00
Michael DeHaan
12ecff71ba
Add a few notes about variables to the FAQ.
2013-12-27 15:52:53 -05:00
Michael DeHaan
81fdd5d02a
Add a note about hosts being ok in multiple groups.
2013-12-27 15:42:11 -05:00
Michael DeHaan
fdb8505a5e
Add ansible-pull's -o to the manpage.
2013-12-27 15:33:33 -05:00
Michael DeHaan
132a7fa88e
Added note about tag groups to AWS guide.
2013-12-27 15:19:19 -05:00
Michael DeHaan
d4cd1fba8b
add a note about raw/endraw
2013-12-27 15:01:27 -05:00
Michael DeHaan
4658a98066
Remove line about undocumented variables as they should be documented :)
2013-12-27 14:50:50 -05:00
Michael DeHaan
3ef228a906
Merge pull request #5387 from sa2ajj/fix-docs-refs
...
fix various documentation xrefs
2013-12-27 11:45:54 -08:00
Michael DeHaan
d84b236ad5
Merge pull request #5436 from jkleckner/fix-fail-doc-example
...
Fix documentation example for the fail module
2013-12-27 11:21:51 -08:00
Mikhail Sobolev
64652fa6ab
fix various documentation xrefs
2013-12-27 18:21:08 +02:00
Jim Kleckner
edca1d69cf
Fix documentation example for the fail module
...
The example for the fail module doesn't work:
http://www.ansibleworks.com/docs/modules.html#fail
The current text shows:
- fail: msg="The system may not be provisioned according to the CMDB status."
when: "{{ cmdb_status }} != 'to-be-staged'"
The "when" documentation indicates that the argument is already a Jinja2
expression:
http://www.ansibleworks.com/docs/playbooks_conditionals.html#the-when-statement
Thus, the following is
when: cmdb_status != "to-be-staged"
is preferred even though the following could work but generates a
deprecation warning:
when: {{cmdb_status != "to-be-staged"}}
2013-12-26 16:32:32 -08:00
Jim Kleckner
f532b449d7
Fix mysql_db dump and import to use port argument
...
The code for mysql_db did not pass the port argument when state=dump or
state=import.
2013-12-26 16:21:16 -08:00
Michael DeHaan
af98ce8433
Add topics index to installation page.
2013-12-26 14:35:57 -05:00
Michael DeHaan
eec9b6c8b8
Fix a intra-doc link.
2013-12-26 14:35:57 -05:00
Michael DeHaan
bde41bac35
Fix some small docsite formatting things.
2013-12-26 14:35:57 -05:00
Michael DeHaan
1c29f043b4
Add contents to various pages with more than one topic per page.
2013-12-26 14:35:57 -05:00
Mikhail Sobolev
8733b5da8b
fix short/full description for elasticache
2013-12-26 14:35:57 -05:00
Mikhail Sobolev
84948292f3
include short_description in the module page's title
2013-12-26 14:35:57 -05:00
