ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

gitlab_hook: minor refactoring (#5271)

Browse source 
* gitlab_hook: minor refactoring

* add changelog fragment
This commit is contained in:
Alexei Znamensky 2022-09-13 06:30:49 +12:00 committed by GitHub
parent 6b463e6fa6
commit fbb6ceea1d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/5271-gitlab_hook-refactor.yaml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- gitlab_hook - minor refactoring (https://github.com/ansible-collections/community.general/pull/5271).

17
plugins/modules/source_control/gitlab/gitlab_hook.py
View file

@ -223,9 +223,8 @@ class GitLabHook(object):
hook.save() hook.save()
except Exception as e: except Exception as e:
self._module.fail_json(msg="Failed to update hook: %s " % e) self._module.fail_json(msg="Failed to update hook: %s " % e)
return True
else: return changed
return False
''' '''
@param project Project Object @param project Project Object
@ -247,9 +246,9 @@ class GitLabHook(object):
changed = False changed = False
for arg_key, arg_value in arguments.items(): for arg_key, arg_value in arguments.items():
if arguments[arg_key] is not None: if arg_value is not None:
if getattr(hook, arg_key, None) != arguments[arg_key]: if getattr(hook, arg_key, None) != arg_value:
setattr(hook, arg_key, arguments[arg_key]) setattr(hook, arg_key, arg_value)
changed = True changed = True
return (changed, hook) return (changed, hook)
@ -277,10 +276,8 @@ class GitLabHook(object):
return False return False
def delete_hook(self): def delete_hook(self):
if self._module.check_mode: if not self._module.check_mode:
return True self.hook_object.delete()
return self.hook_object.delete()
def main(): def main():