diff --git a/docs/docsite/rst/porting_guides/porting_guide_2.8.rst b/docs/docsite/rst/porting_guides/porting_guide_2.8.rst index e40125325e..8df162d97b 100644 --- a/docs/docsite/rst/porting_guides/porting_guide_2.8.rst +++ b/docs/docsite/rst/porting_guides/porting_guide_2.8.rst @@ -144,6 +144,7 @@ The following modules will be removed in Ansible 2.12. Please update your playbo * ``github_hooks`` use :ref:`github_webhook ` and :ref:`github_webhook_facts ` instead. * ``digital_ocean`` use :ref `digital_ocean_droplet ` instead. * ``gce`` use :ref `gce_compute_instance ` instead. +* ``panos`` use `Ansible Galaxy role `_ instead. Noteworthy module changes @@ -199,6 +200,10 @@ Noteworthy module changes * ``vmware_vm_facts`` used to return dict of dict with virtual machine's facts. Ansible 2.8 and onwards will return list of dict with virtual machine's facts. Please see module ``vmware_vm_facts`` documentation for example. +* The ``panos`` modules have been deprecated in favor of using the Palo Alto Networks `Ansible Galaxy role + `_. Contributions to the role can be made + `here `_. + Plugins ======= diff --git a/lib/ansible/modules/network/panos/panos_admin.py b/lib/ansible/modules/network/panos/_panos_admin.py similarity index 96% rename from lib/ansible/modules/network/panos/panos_admin.py rename to lib/ansible/modules/network/panos/_panos_admin.py index 9ea051ff32..0c6274336b 100644 --- a/lib/ansible/modules/network/panos/panos_admin.py +++ b/lib/ansible/modules/network/panos/_panos_admin.py @@ -20,7 +20,7 @@ # along with Ansible. If not, see . ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -35,6 +35,10 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - pan-python +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: admin_username: description: diff --git a/lib/ansible/modules/network/panos/panos_admpwd.py b/lib/ansible/modules/network/panos/_panos_admpwd.py similarity index 96% rename from lib/ansible/modules/network/panos/panos_admpwd.py rename to lib/ansible/modules/network/panos/_panos_admpwd.py index b68b550e4f..c6d0407b8f 100644 --- a/lib/ansible/modules/network/panos/panos_admpwd.py +++ b/lib/ansible/modules/network/panos/_panos_admpwd.py @@ -30,6 +30,10 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - paramiko +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: ip_address: description: @@ -74,7 +78,7 @@ status: ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_cert_gen_ssh.py b/lib/ansible/modules/network/panos/_panos_cert_gen_ssh.py similarity index 96% rename from lib/ansible/modules/network/panos/panos_cert_gen_ssh.py rename to lib/ansible/modules/network/panos/_panos_cert_gen_ssh.py index 31d5730c19..c15c155c04 100644 --- a/lib/ansible/modules/network/panos/panos_cert_gen_ssh.py +++ b/lib/ansible/modules/network/panos/_panos_cert_gen_ssh.py @@ -30,6 +30,10 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - paramiko +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. notes: - Checkmode is not supported. options: @@ -79,7 +83,7 @@ RETURN = ''' ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_check.py b/lib/ansible/modules/network/panos/_panos_check.py similarity index 93% rename from lib/ansible/modules/network/panos/panos_check.py rename to lib/ansible/modules/network/panos/_panos_check.py index 09a3228650..c2dbd5969c 100644 --- a/lib/ansible/modules/network/panos/panos_check.py +++ b/lib/ansible/modules/network/panos/_panos_check.py @@ -30,17 +30,21 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - pan-python +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: timeout: description: - timeout of API calls required: false - default: "0" + default: 0 interval: description: - time waited between checks required: false - default: "0" + default: 0 extends_documentation_fragment: panos ''' @@ -68,7 +72,7 @@ RETURN = ''' ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_commit.py b/lib/ansible/modules/network/panos/_panos_commit.py similarity index 97% rename from lib/ansible/modules/network/panos/panos_commit.py rename to lib/ansible/modules/network/panos/_panos_commit.py index b35da19ba8..866f6f8721 100644 --- a/lib/ansible/modules/network/panos/panos_commit.py +++ b/lib/ansible/modules/network/panos/_panos_commit.py @@ -34,6 +34,10 @@ author: version_added: "2.3" requirements: - pan-python +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: ip_address: description: @@ -119,7 +123,7 @@ panos_commit: ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_dag.py b/lib/ansible/modules/network/panos/_panos_dag.py similarity index 94% rename from lib/ansible/modules/network/panos/panos_dag.py rename to lib/ansible/modules/network/panos/_panos_dag.py index 6b7e0f90a7..36aee6f394 100644 --- a/lib/ansible/modules/network/panos/panos_dag.py +++ b/lib/ansible/modules/network/panos/_panos_dag.py @@ -29,6 +29,10 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - pan-python +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: dag_name: description: @@ -60,7 +64,7 @@ RETURN = ''' ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_dag_tags.py b/lib/ansible/modules/network/panos/_panos_dag_tags.py similarity index 97% rename from lib/ansible/modules/network/panos/panos_dag_tags.py rename to lib/ansible/modules/network/panos/_panos_dag_tags.py index 1c7cd94ecf..94466b7f66 100644 --- a/lib/ansible/modules/network/panos/panos_dag_tags.py +++ b/lib/ansible/modules/network/panos/_panos_dag_tags.py @@ -21,7 +21,7 @@ # limitations under the License. ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} DOCUMENTATION = ''' @@ -35,6 +35,10 @@ version_added: "2.5" requirements: - pan-python can be obtained from PyPI U(https://pypi.org/project/pan-python/) - pandevice can be obtained from PyPI U(https://pypi.org/project/pandevice/) +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. notes: - Checkmode is not supported. - Panorama is not supported. diff --git a/lib/ansible/modules/network/panos/panos_import.py b/lib/ansible/modules/network/panos/_panos_import.py similarity index 96% rename from lib/ansible/modules/network/panos/panos_import.py rename to lib/ansible/modules/network/panos/_panos_import.py index 782735198f..7fdcdabb85 100644 --- a/lib/ansible/modules/network/panos/panos_import.py +++ b/lib/ansible/modules/network/panos/_panos_import.py @@ -34,6 +34,10 @@ requirements: - pan-python - requests - requests_toolbelt +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: category: description: @@ -71,7 +75,7 @@ RETURN = ''' ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_interface.py b/lib/ansible/modules/network/panos/_panos_interface.py similarity index 96% rename from lib/ansible/modules/network/panos/panos_interface.py rename to lib/ansible/modules/network/panos/_panos_interface.py index 03aa2dd02c..1174b133ea 100644 --- a/lib/ansible/modules/network/panos/panos_interface.py +++ b/lib/ansible/modules/network/panos/_panos_interface.py @@ -20,7 +20,7 @@ # along with Ansible. If not, see . ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -34,6 +34,10 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - pan-python can be obtained from PyPI U(https://pypi.org/project/pan-python/) +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. notes: - Checkmode is not supported. options: diff --git a/lib/ansible/modules/network/panos/panos_lic.py b/lib/ansible/modules/network/panos/_panos_lic.py similarity index 95% rename from lib/ansible/modules/network/panos/panos_lic.py rename to lib/ansible/modules/network/panos/_panos_lic.py index 536da8c4a2..c7427f6f7b 100644 --- a/lib/ansible/modules/network/panos/panos_lic.py +++ b/lib/ansible/modules/network/panos/_panos_lic.py @@ -31,6 +31,10 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - pan-python +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: auth_code: description: @@ -70,7 +74,7 @@ serialnumber: ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_loadcfg.py b/lib/ansible/modules/network/panos/_panos_loadcfg.py similarity index 93% rename from lib/ansible/modules/network/panos/panos_loadcfg.py rename to lib/ansible/modules/network/panos/_panos_loadcfg.py index 3fb9bf6852..9c14ab0d9d 100644 --- a/lib/ansible/modules/network/panos/panos_loadcfg.py +++ b/lib/ansible/modules/network/panos/_panos_loadcfg.py @@ -29,6 +29,10 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - pan-python +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: file: description: @@ -62,7 +66,7 @@ RETURN = ''' ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_match_rule.py b/lib/ansible/modules/network/panos/_panos_match_rule.py similarity index 97% rename from lib/ansible/modules/network/panos/panos_match_rule.py rename to lib/ansible/modules/network/panos/_panos_match_rule.py index 1e0ae4a93c..0b86de9fa7 100644 --- a/lib/ansible/modules/network/panos/panos_match_rule.py +++ b/lib/ansible/modules/network/panos/_panos_match_rule.py @@ -21,7 +21,7 @@ # limitations under the License. ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} DOCUMENTATION = ''' @@ -35,6 +35,10 @@ version_added: "2.5" requirements: - pan-python can be obtained from PyPI U(https://pypi.org/project/pan-python/) - pandevice can be obtained from PyPI U(https://pypi.org/project/pandevice/) +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. notes: - Checkmode is not supported. - Panorama NOT is supported. @@ -57,7 +61,10 @@ options: rule_type: description: - Type of rule. Valid types are I(security) or I(nat). - default: "security" + required: true + choices: + - security + - nat source_zone: description: - The source zone. diff --git a/lib/ansible/modules/network/panos/panos_mgtconfig.py b/lib/ansible/modules/network/panos/_panos_mgtconfig.py similarity index 96% rename from lib/ansible/modules/network/panos/panos_mgtconfig.py rename to lib/ansible/modules/network/panos/_panos_mgtconfig.py index 7385a20e26..015d885be8 100644 --- a/lib/ansible/modules/network/panos/panos_mgtconfig.py +++ b/lib/ansible/modules/network/panos/_panos_mgtconfig.py @@ -29,6 +29,10 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - pan-python +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: dns_server_primary: description: @@ -66,7 +70,7 @@ RETURN = ''' ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_nat_rule.py b/lib/ansible/modules/network/panos/_panos_nat_rule.py similarity index 94% rename from lib/ansible/modules/network/panos/panos_nat_rule.py rename to lib/ansible/modules/network/panos/_panos_nat_rule.py index 4ff0775446..47aac20521 100644 --- a/lib/ansible/modules/network/panos/panos_nat_rule.py +++ b/lib/ansible/modules/network/panos/_panos_nat_rule.py @@ -19,6 +19,10 @@ version_added: "2.4" requirements: - pan-python can be obtained from PyPI U(https://pypi.org/project/pan-python/) - pandevice can be obtained from PyPI U(https://pypi.org/project/pandevice/) +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. notes: - Checkmode is not supported. - Panorama is supported. @@ -41,10 +45,22 @@ options: operation: description: - The action to be taken. Supported values are I(add)/I(update)/I(find)/I(delete). + required: true + choices: + - add + - update + - delete + - find + devicegroup: + description: + - If Panorama, the device group to put this rule in. rule_name: description: - name of the SNAT rule required: true + description: + description: + - The description source_zone: description: - list of source zones @@ -68,10 +84,17 @@ options: snat_type: description: - type of source translation + choices: + - static-ip + - dynamic-ip-and-port + - dynamic-ip snat_address_type: description: - type of source translation. Supported values are I(translated-address)/I(translated-address). - default: 'translated-address' + default: 'interface-address' + choices: + - interface-address + - translated-address snat_static_address: description: - Source NAT translated address. Used with Static-IP translation. @@ -95,6 +118,13 @@ options: dnat_port: description: - dnat translated port + tag_name: + description: + - Tag for the NAT rule. + to_interface: + description: + - Destination interface. + default: 'any' commit: description: - Commit configuration if changed. @@ -126,7 +156,7 @@ RETURN = ''' ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} # import pydevd diff --git a/lib/ansible/modules/network/panos/panos_object.py b/lib/ansible/modules/network/panos/_panos_object.py similarity index 95% rename from lib/ansible/modules/network/panos/panos_object.py rename to lib/ansible/modules/network/panos/_panos_object.py index 010fc51cd5..d1221690c4 100644 --- a/lib/ansible/modules/network/panos/panos_object.py +++ b/lib/ansible/modules/network/panos/_panos_object.py @@ -21,7 +21,7 @@ # limitations under the License. ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} DOCUMENTATION = ''' @@ -36,6 +36,10 @@ version_added: "2.4" requirements: - pan-python can be obtained from PyPI U(https://pypi.org/project/pan-python/) - pandevice can be obtained from PyPI U(https://pypi.org/project/pandevice/) +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. notes: - Checkmode is not supported. - Panorama is supported. @@ -59,6 +63,11 @@ options: description: - The operation to be performed. Supported values are I(add)/I(delete)/I(find). required: true + choices: + - add + - update + - delete + - find addressobject: description: - The name of the address object. @@ -68,6 +77,11 @@ options: address_type: description: - The type of address object definition. Valid types are I(ip-netmask) and I(ip-range). + default: 'ip-netmask' + choices: + - ip-netmask + - ip-range + - fqdn addressgroup: description: - A static group of address objects or dynamic address group. @@ -89,6 +103,9 @@ options: protocol: description: - The IP protocol to be used in a service object definition. Valid values are I(tcp) or I(udp). + choices: + - tcp + - udp servicegroup: description: - A group of service objects. @@ -105,6 +122,23 @@ options: description: > - The color of the tag object. Valid values are I(red, green, blue, yellow, copper, orange, purple, gray, light green, cyan, light gray, blue gray, lime, black, gold, and brown). + choices: + - red + - green + - blue + - yellow + - copper + - orange + - purple + - gray + - light green + - cyan + - light gray + - blue gray + - lime + - black + - gold + - brown devicegroup: description: > - The name of the Panorama device group. The group must exist on Panorama. If device group is not defined it diff --git a/lib/ansible/modules/network/panos/panos_op.py b/lib/ansible/modules/network/panos/_panos_op.py similarity index 95% rename from lib/ansible/modules/network/panos/panos_op.py rename to lib/ansible/modules/network/panos/_panos_op.py index a57fe55bad..1acc036b71 100644 --- a/lib/ansible/modules/network/panos/panos_op.py +++ b/lib/ansible/modules/network/panos/_panos_op.py @@ -20,7 +20,7 @@ # along with Ansible. If not, see . ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} DOCUMENTATION = ''' @@ -33,6 +33,10 @@ version_added: "2.5" requirements: - pan-python can be obtained from PyPI U(https://pypi.org/project/pan-python/) - pandevice can be obtained from PyPI U(https://pypi.org/project/pandevice/) +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. notes: - Checkmode is NOT supported. - Panorama is NOT supported. diff --git a/lib/ansible/modules/network/panos/panos_pg.py b/lib/ansible/modules/network/panos/_panos_pg.py similarity index 96% rename from lib/ansible/modules/network/panos/panos_pg.py rename to lib/ansible/modules/network/panos/_panos_pg.py index d66d5131ae..6d35f2554b 100644 --- a/lib/ansible/modules/network/panos/panos_pg.py +++ b/lib/ansible/modules/network/panos/_panos_pg.py @@ -29,6 +29,10 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - pan-python +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: pg_name: description: @@ -80,7 +84,7 @@ RETURN = ''' ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_query_rules.py b/lib/ansible/modules/network/panos/_panos_query_rules.py similarity index 98% rename from lib/ansible/modules/network/panos/panos_query_rules.py rename to lib/ansible/modules/network/panos/_panos_query_rules.py index 85b064b82c..97ea311b5d 100644 --- a/lib/ansible/modules/network/panos/panos_query_rules.py +++ b/lib/ansible/modules/network/panos/_panos_query_rules.py @@ -21,7 +21,7 @@ # limitations under the License. ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} DOCUMENTATION = ''' @@ -38,6 +38,10 @@ requirements: - pan-python can be obtained from PyPI U(https://pypi.org/project/pan-python/) - pandevice can be obtained from PyPI U(https://pypi.org/project/pandevice/) - xmltodict can be obtains from PyPI U(https://pypi.org/project/xmltodict/) +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. notes: - Checkmode is not supported. - Panorama is supported. @@ -81,6 +85,9 @@ options: protocol: description: - The protocol used to be queried. Must be either I(tcp) or I(udp). + choices: + - tcp + - udp tag_name: description: - Name of the rule tag to be queried. diff --git a/lib/ansible/modules/network/panos/panos_restart.py b/lib/ansible/modules/network/panos/_panos_restart.py similarity index 92% rename from lib/ansible/modules/network/panos/panos_restart.py rename to lib/ansible/modules/network/panos/_panos_restart.py index 17d2d6b794..ad5b326f48 100644 --- a/lib/ansible/modules/network/panos/panos_restart.py +++ b/lib/ansible/modules/network/panos/_panos_restart.py @@ -29,6 +29,10 @@ author: "Luigi Mori (@jtschichold), Ivan Bojer (@ivanbojer)" version_added: "2.3" requirements: - pan-python +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. extends_documentation_fragment: panos ''' @@ -48,7 +52,7 @@ status: ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} diff --git a/lib/ansible/modules/network/panos/panos_sag.py b/lib/ansible/modules/network/panos/_panos_sag.py similarity index 96% rename from lib/ansible/modules/network/panos/panos_sag.py rename to lib/ansible/modules/network/panos/_panos_sag.py index d22e85e28c..7b9bcb1e1f 100644 --- a/lib/ansible/modules/network/panos/panos_sag.py +++ b/lib/ansible/modules/network/panos/_panos_sag.py @@ -31,6 +31,10 @@ requirements: - pan-python can be obtained from PyPI U(https://pypi.org/project/pan-python/) - pandevice can be obtained from PyPI U(https://pypi.org/project/pandevice/) - xmltodict can be obtained from PyPI U(https://pypi.org/project/xmltodict/) +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. options: api_key: description: @@ -39,10 +43,10 @@ options: description: - name of the dynamic address group required: true - static_match_filter: + sag_match_filter: description: - Static filter user by the address group - required: true + type: list devicegroup: description: > - The name of the Panorama device group. The group must exist on Panorama. If device group is not defined @@ -62,6 +66,10 @@ options: description: - The operation to perform Supported values are I(add)/I(list)/I(delete). required: true + choices: + - add + - list + - delete extends_documentation_fragment: panos ''' @@ -81,7 +89,7 @@ RETURN = ''' ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} from ansible.module_utils.basic import AnsibleModule diff --git a/lib/ansible/modules/network/panos/panos_security_rule.py b/lib/ansible/modules/network/panos/_panos_security_rule.py similarity index 97% rename from lib/ansible/modules/network/panos/panos_security_rule.py rename to lib/ansible/modules/network/panos/_panos_security_rule.py index 19d59ebbca..a36b476699 100644 --- a/lib/ansible/modules/network/panos/panos_security_rule.py +++ b/lib/ansible/modules/network/panos/_panos_security_rule.py @@ -8,7 +8,7 @@ __metaclass__ = type ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -26,6 +26,10 @@ requirements: - pan-python can be obtained from PyPI U(https://pypi.org/project/pan-python/) - pandevice can be obtained from PyPI U(https://pypi.org/project/pandevice/) - xmltodict can be obtained from PyPI U(https://pypi.org/project/xmltodict/) +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. notes: - Checkmode is not supported. - Panorama is supported. @@ -49,6 +53,16 @@ options: description: - The action to be taken. Supported values are I(add)/I(update)/I(find)/I(delete). default: 'add' + choices: + - add + - update + - delete + - find + category: + description: + - The category. + type: list + default: ['any'] rule_name: description: - Name of the security rule. diff --git a/lib/ansible/modules/network/panos/panos_set.py b/lib/ansible/modules/network/panos/_panos_set.py similarity index 95% rename from lib/ansible/modules/network/panos/panos_set.py rename to lib/ansible/modules/network/panos/_panos_set.py index c81446bb79..7b35cd7ad2 100644 --- a/lib/ansible/modules/network/panos/panos_set.py +++ b/lib/ansible/modules/network/panos/_panos_set.py @@ -41,6 +41,10 @@ description: - The 'element' is "Australia/Melbourne" author: "Jasper Mackenzie (@spmp)" version_added: "2.7" +deprecated: + alternative: Use U(https://galaxy.ansible.com/PaloAltoNetworks/paloaltonetworks) instead. + removed_in: "2.12" + why: Consolidating code base. requirements: - pan-python options: @@ -99,7 +103,7 @@ RETURN = ''' ''' ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} from ansible.module_utils.basic import AnsibleModule