From f8d8f691bc0de8d7e25bc11ea1c7d548ff9346fa Mon Sep 17 00:00:00 2001 From: buzz-tee <11776936+buzz-tee@users.noreply.github.com> Date: Wed, 15 Nov 2023 22:00:34 +0100 Subject: [PATCH] Netcup DNS: Add support for additional record types (#7489) * Netcup DNS: Add support for additional record types * Netcup DNS: Add changelog fragment * Netcup DNS: Include information on minimum required versions in module documentation * Apply suggestions from code review Co-authored-by: Felix Fontein --------- Co-authored-by: Felix Fontein --- changelogs/fragments/7489-netcup-dns-record-types.yml | 2 ++ plugins/modules/netcup_dns.py | 9 +++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/7489-netcup-dns-record-types.yml diff --git a/changelogs/fragments/7489-netcup-dns-record-types.yml b/changelogs/fragments/7489-netcup-dns-record-types.yml new file mode 100644 index 0000000000..b065a4d239 --- /dev/null +++ b/changelogs/fragments/7489-netcup-dns-record-types.yml @@ -0,0 +1,2 @@ +minor_changes: + - netcup_dns - adds support for record types ``OPENPGPKEY``, ``SMIMEA``, and ``SSHFP`` (https://github.com/ansible-collections/community.general/pull/7489). \ No newline at end of file diff --git a/plugins/modules/netcup_dns.py b/plugins/modules/netcup_dns.py index 00306eb455..cba70c0fa3 100644 --- a/plugins/modules/netcup_dns.py +++ b/plugins/modules/netcup_dns.py @@ -53,7 +53,10 @@ options: type: description: - Record type. - choices: ['A', 'AAAA', 'MX', 'CNAME', 'CAA', 'SRV', 'TXT', 'TLSA', 'NS', 'DS'] + - Support for V(OPENPGPKEY), V(SMIMEA) and V(SSHFP) was added in community.general 8.1.0. + - Record types V(OPENPGPKEY) and V(SMIMEA) require nc-dnsapi >= 0.1.5. + - Record type V(SSHFP) requires nc-dnsapi >= 0.1.6. + choices: ['A', 'AAAA', 'MX', 'CNAME', 'CAA', 'SRV', 'TXT', 'TLSA', 'NS', 'DS', 'OPENPGPKEY', 'SMIMEA', 'SSHFP'] required: true type: str value: @@ -213,7 +216,9 @@ def main(): domain=dict(required=True), record=dict(required=False, default='@', aliases=['name']), - type=dict(required=True, choices=['A', 'AAAA', 'MX', 'CNAME', 'CAA', 'SRV', 'TXT', 'TLSA', 'NS', 'DS']), + type=dict(required=True, choices=['A', 'AAAA', 'MX', 'CNAME', 'CAA', 'SRV', 'TXT', + 'TLSA', 'NS', 'DS', 'OPENPGPKEY', 'SMIMEA', + 'SSHFP']), value=dict(required=True), priority=dict(required=False, type='int'), solo=dict(required=False, type='bool', default=False),