From f4f5d941e56e85cda4dfca7d2505bd16c3b9fc6f Mon Sep 17 00:00:00 2001 From: John R Barker Date: Tue, 25 Sep 2018 18:37:01 +0100 Subject: [PATCH] botmeta support: core (#45917) * botmeta enforce `support: core` --- .github/BOTMETA.yml | 2 ++ test/sanity/code-smell/botmeta.py | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/.github/BOTMETA.yml b/.github/BOTMETA.yml index 9e88561afe..c4b395f421 100644 --- a/.github/BOTMETA.yml +++ b/.github/BOTMETA.yml @@ -37,6 +37,8 @@ automerge: True files: .github/BOTMETA.yml: labels: botmeta + # Changes to BOTMETA MUST always be reviewed by Core Team + support: core $modules/cloud/amazon/: ignored: erydo seiffert simplesteph $modules/cloud/amazon/aws_api_gateway.py: willthames diff --git a/test/sanity/code-smell/botmeta.py b/test/sanity/code-smell/botmeta.py index bae2f0ecd8..56dea07f71 100755 --- a/test/sanity/code-smell/botmeta.py +++ b/test/sanity/code-smell/botmeta.py @@ -59,6 +59,11 @@ def main(): # No way to get line numbers print('%s:%d:%d: %s' % (path, 0, 0, humanize_error(botmeta, error))) + # Ensure botmeta is always support:core + botmeta_support = botmeta.get('files', {}).get('.github/BOTMETA.yml', {}).get('support', '') + if botmeta_support != 'core': + print('%s:%d:%d: .github/BOTMETA.yml MUST be support: core' % (path, 0, 0)) + # We have two macros to define locations, ensure they haven't been removed module_utils_path = botmeta.get('macros', {}).get('module_utils', '') modules_path = botmeta.get('macros', {}).get('modules', '')