Adjust booleans in monitoring modules. (#5156) (#5170)

(cherry picked from commit 1b480e9f37)

Co-authored-by: Felix Fontein <felix@fontein.de>

plugins/modules/monitoring/airbrake_deployment.py

@@ -65,10 +65,10 @@ options:
     type: str
   validate_certs:
     description:
-      - If C(no), SSL certificates for the target url will not be validated. This should only be used
+      - If C(false), SSL certificates for the target url will not be validated. This should only be used
         on personally controlled sites using self-signed certificates.
     required: false
-    default: 'yes'
+    default: true
     type: bool
 
 requirements: []

plugins/modules/monitoring/bigpanda.py

@@ -68,10 +68,10 @@ options:
     default: https://api.bigpanda.io
   validate_certs:
     description:
-      - If C(no), SSL certificates for the target url will not be validated. This should only be used
+      - If C(false), SSL certificates for the target url will not be validated. This should only be used
         on personally controlled sites using self-signed certificates.
     required: false
-    default: 'yes'
+    default: true
     type: bool
   deployment_message:
     type: str

plugins/modules/monitoring/datadog/datadog_event.py

@@ -75,10 +75,10 @@ options:
         description: ["An arbitrary string to use for aggregation."]
     validate_certs:
         description:
-            - If C(no), SSL certificates will not be validated. This should only be used
+            - If C(false), SSL certificates will not be validated. This should only be used
               on personally controlled sites using self-signed certificates.
         type: bool
-        default: 'yes'
+        default: true
 '''
 
 EXAMPLES = '''

plugins/modules/monitoring/datadog/datadog_monitor.py

@@ -91,7 +91,7 @@ options:
         description:
           - Whether this monitor will notify when data stops reporting.
         type: bool
-        default: 'no'
+        default: false
     no_data_timeframe:
         description:
           - The number of minutes before a monitor will notify when data stops reporting.
@@ -116,7 +116,7 @@ options:
         description:
           - Whether tagged users will be notified on changes to this monitor.
         type: bool
-        default: 'no'
+        default: false
     thresholds:
         type: dict
         description:
@@ -128,7 +128,7 @@ options:
         description:
           - Whether changes to this monitor should be restricted to the creator or admins.
         type: bool
-        default: 'no'
+        default: false
     require_full_window:
         description:
           - Whether this monitor needs a full window of data before it gets evaluated.
@@ -153,7 +153,7 @@ options:
         description:
           - Whether notifications from this monitor automatically inserts its triggering tags into the title.
         type: bool
-        default: yes
+        default: true
         version_added: 1.3.0
     priority:
         description:

plugins/modules/monitoring/honeybadger_deployment.py

@@ -45,10 +45,10 @@ options:
     default: "https://api.honeybadger.io/v1/deploys"
   validate_certs:
     description:
-      - If C(no), SSL certificates for the target url will not be validated. This should only be used
+      - If C(false), SSL certificates for the target url will not be validated. This should only be used
         on personally controlled sites using self-signed certificates.
     type: bool
-    default: 'yes'
+    default: true
 
 '''
 

plugins/modules/monitoring/icinga2_host.py

@@ -26,16 +26,16 @@ options:
       - HTTP, HTTPS, or FTP URL in the form (http|https|ftp)://[user[:pass]]@host.domain[:port]/path
   use_proxy:
     description:
-      - If C(no), it will not use a proxy, even if one is defined in
+      - If C(false), it will not use a proxy, even if one is defined in
         an environment variable on the target hosts.
     type: bool
-    default: 'yes'
+    default: true
   validate_certs:
     description:
-      - If C(no), SSL certificates will not be validated. This should only be used
+      - If C(false), SSL certificates will not be validated. This should only be used
         on personally controlled sites using self-signed certificates.
     type: bool
-    default: 'yes'
+    default: true
   url_username:
     type: str
     description:
@@ -53,7 +53,7 @@ options:
         send a 401, logins will fail. This option forces the sending of the Basic authentication header
         upon initial request.
     type: bool
-    default: 'no'
+    default: false
   client_cert:
     type: path
     description:

plugins/modules/monitoring/newrelic_deployment.py

@@ -64,10 +64,10 @@ options:
     required: false
   validate_certs:
     description:
-      - If C(no), SSL certificates will not be validated. This should only be used
+      - If C(false), SSL certificates will not be validated. This should only be used
         on personally controlled sites using self-signed certificates.
     required: false
-    default: 'yes'
+    default: true
     type: bool
 
 requirements: []

plugins/modules/monitoring/pagerduty.py

@@ -73,10 +73,10 @@ options:
         default: Created by Ansible
     validate_certs:
         description:
-            - If C(no), SSL certificates will not be validated. This should only be used
+            - If C(false), SSL certificates will not be validated. This should only be used
               on personally controlled sites using self-signed certificates.
         type: bool
-        default: 'yes'
+        default: true
 '''
 
 EXAMPLES = '''

plugins/modules/monitoring/pagerduty_change.py

@@ -73,10 +73,10 @@ options:
     type: str
   validate_certs:
     description:
-      - If C(no), SSL certificates for the target URL will not be validated.
+      - If C(false), SSL certificates for the target URL will not be validated.
         This should only be used on personally controlled sites using self-signed certificates.
     required: false
-    default: yes
+    default: true
     type: bool
 notes:
   - Supports C(check_mode). Note that check mode simply does nothing except returning C(changed=true) in case the I(url) seems to be correct.

plugins/modules/monitoring/rollbar_deployment.py

@@ -56,11 +56,11 @@ options:
     default: 'https://api.rollbar.com/api/1/deploy/'
   validate_certs:
     description:
-      - If C(no), SSL certificates for the target url will not be validated.
+      - If C(false), SSL certificates for the target url will not be validated.
         This should only be used on personally controlled sites using
         self-signed certificates.
     required: false
-    default: 'yes'
+    default: true
     type: bool
 '''
 

plugins/modules/monitoring/sensu/sensu_check.py

@@ -43,7 +43,7 @@ options:
       - Create a backup file (if yes), including the timestamp information so
       - you can get the original file back if you somehow clobbered it incorrectly.
     type: bool
-    default: 'no'
+    default: false
   command:
     type: str
     description:
@@ -97,7 +97,7 @@ options:
     description:
       - Whether the check is a metric
     type: bool
-    default: 'no'
+    default: false
   standalone:
     description:
       - Whether the check should be scheduled by the sensu client or server
@@ -153,7 +153,7 @@ EXAMPLES = '''
   community.general.sensu_check:
     name: cpu_load
     command: /etc/sensu/plugins/system/cpu-mpstat-metrics.rb
-    metric: yes
+    metric: true
     handlers: relay
     subscribers: common
     interval: 60
@@ -328,7 +328,7 @@ def main():
     arg_spec = {'name': {'type': 'str', 'required': True},
                 'path': {'type': 'str', 'default': '/etc/sensu/conf.d/checks.json'},
                 'state': {'type': 'str', 'default': 'present', 'choices': ['present', 'absent']},
-                'backup': {'type': 'bool', 'default': 'no'},
+                'backup': {'type': 'bool', 'default': False},
                 'command': {'type': 'str'},
                 'handlers': {'type': 'list', 'elements': 'str'},
                 'subscribers': {'type': 'list', 'elements': 'str'},
@@ -339,7 +339,7 @@ def main():
                 'subdue_begin': {'type': 'str'},
                 'subdue_end': {'type': 'str'},
                 'dependencies': {'type': 'list', 'elements': 'str'},
-                'metric': {'type': 'bool', 'default': 'no'},
+                'metric': {'type': 'bool', 'default': False},
                 'standalone': {'type': 'bool'},
                 'publish': {'type': 'bool'},
                 'occurrences': {'type': 'int'},

plugins/modules/monitoring/sensu/sensu_client.py

@@ -44,7 +44,7 @@ options:
     description:
       - If safe mode is enabled for the client. Safe mode requires local check definitions in order to accept a check request and execute the check.
     type: bool
-    default: 'no'
+    default: false
   redact:
     type: list
     elements: str
@@ -58,7 +58,7 @@ options:
     description:
       - If Sensu should monitor keepalives for this client.
     type: bool
-    default: 'yes'
+    default: true
   keepalive:
     type: dict
     description:

plugins/modules/monitoring/sensu/sensu_handler.py

@@ -64,12 +64,12 @@ options:
     description:
       - If events matching one or more silence entries should be handled.
     type: bool
-    default: 'no'
+    default: false
   handle_flapping:
     description:
       - If events in the flapping state should be handled.
     type: bool
-    default: 'no'
+    default: false
   command:
     type: str
     description:

plugins/modules/monitoring/sensu/sensu_subscription.py

@@ -40,7 +40,7 @@ options:
       - can get the original file back if you somehow clobbered it incorrectly.
     type: bool
     required: false
-    default: no
+    default: false
 requirements: [ ]
 author: Anders Ingemann (@andsens)
 '''
@@ -133,7 +133,7 @@ def main():
     arg_spec = {'name': {'type': 'str', 'required': True},
                 'path': {'type': 'str', 'default': '/etc/sensu/conf.d/subscriptions.json'},
                 'state': {'type': 'str', 'default': 'present', 'choices': ['present', 'absent']},
-                'backup': {'type': 'bool', 'default': 'no'},
+                'backup': {'type': 'bool', 'default': False},
                 }
 
     module = AnsibleModule(argument_spec=arg_spec,

plugins/modules/monitoring/spectrum_device.py

@@ -65,16 +65,16 @@ options:
     use_proxy:
         required: false
         description:
-            - if C(no), it will not use a proxy, even if one is defined in an environment
+            - if C(false), it will not use a proxy, even if one is defined in an environment
                 variable on the target hosts.
-        default: 'yes'
+        default: true
         type: bool
     validate_certs:
         required: false
         description:
-            - If C(no), SSL certificates will not be validated. This should only be used
+            - If C(false), SSL certificates will not be validated. This should only be used
                 on personally controlled sites using self-signed certificates.
-        default: 'yes'
+        default: true
         type: bool
     agentport:
         type: int
@@ -108,7 +108,7 @@ EXAMPLES = '''
     oneclick_url: http://oneclick.example.com:8080
     oneclick_user: username
     oneclick_password: password
-    use_proxy: no
+    use_proxy: false
     state: absent
 '''
 

plugins/modules/monitoring/spectrum_model_attrs.py

@@ -43,9 +43,9 @@ options:
      aliases: [password]
    use_proxy:
      description:
-     - if C(no), it will not use a proxy, even if one is defined in
+     - if C(false), it will not use a proxy, even if one is defined in
        an environment variable on the target hosts.
-     default: yes
+     default: true
      required: false
      type: bool
    name:
@@ -63,7 +63,7 @@ options:
      - Validate SSL certificates. Only change this to C(false) if you can guarantee that you are talking to the correct endpoint and there is no
        man-in-the-middle attack happening.
      type: bool
-     default: yes
+     default: true
      required: false
    attributes:
      description:

plugins/modules/monitoring/statusio_maintenance.py

@@ -74,32 +74,32 @@ options:
         description:
             - If it affects all components and containers
         type: bool
-        default: 'no'
+        default: false
     automation:
         description:
             - Automatically start and end the maintenance window
         type: bool
-        default: 'no'
+        default: false
     maintenance_notify_now:
         description:
             - Notify subscribers now
         type: bool
-        default: 'no'
+        default: false
     maintenance_notify_72_hr:
         description:
             - Notify subscribers 72 hours before maintenance start time
         type: bool
-        default: 'no'
+        default: false
     maintenance_notify_24_hr:
         description:
             - Notify subscribers 24 hours before maintenance start time
         type: bool
-        default: 'no'
+        default: false
     maintenance_notify_1_hr:
         description:
             - Notify subscribers 1 hour before maintenance start time
         type: bool
-        default: 'no'
+        default: false
     maintenance_id:
         type: str
         description: